Page MenuHomePhabricator

ZarkoCA (Zarko Todorovski)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2018, 9:51 AM (51 w, 5 d)

Recent Activity

Fri, Dec 6

ZarkoCA added inline comments to D70724: [PowerPC] Add Support for indirect calls on AIX..
Fri, Dec 6, 6:14 PM · Restricted Project
ZarkoCA added inline comments to D70724: [PowerPC] Add Support for indirect calls on AIX..
Fri, Dec 6, 8:50 AM · Restricted Project
ZarkoCA added inline comments to D70724: [PowerPC] Add Support for indirect calls on AIX..
Fri, Dec 6, 8:11 AM · Restricted Project

Wed, Dec 4

ZarkoCA added inline comments to D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Wed, Dec 4, 9:14 AM · Restricted Project
ZarkoCA accepted D70126: [PowerPC] Refactor FinishCall [NFC].

Patch looks good to me.

Wed, Dec 4, 7:21 AM · Restricted Project

Tue, Nov 26

ZarkoCA updated the diff for D69578: [AIX] Add support for lowering int, float and double formal arguments..

Fixed testcase typo.

Tue, Nov 26, 1:26 PM · Restricted Project
ZarkoCA updated the diff for D69578: [AIX] Add support for lowering int, float and double formal arguments..

Rebase of latest masters (Nov 26, 2019) and fix testcase register typo.

Tue, Nov 26, 12:59 PM · Restricted Project
ZarkoCA added a comment to D69578: [AIX] Add support for lowering int, float and double formal arguments..

Only a couple minor comments. Otherwise LGTM.

Tue, Nov 26, 10:12 AM · Restricted Project
ZarkoCA updated the diff for D69578: [AIX] Add support for lowering int, float and double formal arguments..

Moved variable declarations and definition to just before they are first used.
Added zext i1 testcase and check for absence of clear instruction.

Tue, Nov 26, 10:12 AM · Restricted Project

Tue, Nov 19

ZarkoCA added inline comments to D69578: [AIX] Add support for lowering int, float and double formal arguments..
Tue, Nov 19, 1:20 PM · Restricted Project
ZarkoCA updated the diff for D69578: [AIX] Add support for lowering int, float and double formal arguments..

Fixed testcases.

Tue, Nov 19, 1:20 PM · Restricted Project
ZarkoCA updated the diff for D69578: [AIX] Add support for lowering int, float and double formal arguments..

Moved assert to earliest position in truncateScalarIntger().
Fixed typos.
Removed std::max when calculating MinReservedArea.
Used opt -mem2reg to remove allocas resulting in body of callee functions looking cleaner with fewer unnecessary lines.

Tue, Nov 19, 5:38 AM · Restricted Project
ZarkoCA added inline comments to D69578: [AIX] Add support for lowering int, float and double formal arguments..
Tue, Nov 19, 5:38 AM · Restricted Project

Thu, Nov 14

ZarkoCA added inline comments to D69578: [AIX] Add support for lowering int, float and double formal arguments..
Thu, Nov 14, 12:34 PM · Restricted Project
ZarkoCA updated the diff for D69578: [AIX] Add support for lowering int, float and double formal arguments..

Made truncateScalarIntegers not a member of PPCISelLowering class.
Removed fatal error for altivec, CC_AIX already errors with vector args.
Removed -mattr=-maltivec on tests where I added it, as we no longer error on those.

Thu, Nov 14, 12:34 PM · Restricted Project
ZarkoCA added a comment to D70126: [PowerPC] Refactor FinishCall [NFC].

Overall, I think this refactor aids in readability and clarity of calling convention code PPCISelLowering.cpp. Even small changes like renaming InFlag to Glue go a long way in helping understanding.

Thu, Nov 14, 6:35 AM · Restricted Project

Wed, Nov 13

ZarkoCA updated the diff for D69578: [AIX] Add support for lowering int, float and double formal arguments..

Updates testcases to use all of the parameters in the function definition.

Wed, Nov 13, 12:50 PM · Restricted Project
ZarkoCA added a comment to D69578: [AIX] Add support for lowering int, float and double formal arguments..

A couple high level comments on the tests.

  • I like how you extended the 'LowerCall' tests to test both the caller and callee side, as opposed to adding new tests just for the formal argument lowering.
  • There are a lot of tests covering quite a few cases. Its good to have thorough coverage. Having separate test cases for things like 1 float vs 3 floats, and 1 i8, vs 4 sext i8s, vs 4 zext i8s might be a little too verbose though. Having a couple calls that mix various extensions of the i8/i16 types i32 and i64 types should give adequate test coverage. Similarly for the fpr tests, a call which mixes doubles and floats should be adequate. I think the most descriptive test are those that are mixing floating and integer/pointer values. For example calling a function with a signature like: (i64 %a, double %d, i1 zeroext %b, float %f, i16 signext %c) shows how we split the i64 for 32-bit codegen, skip gprs for doubls/floats and map the smaller then register sized types into a gpr all in 1 test.
Wed, Nov 13, 8:18 AM · Restricted Project
ZarkoCA added inline comments to D69578: [AIX] Add support for lowering int, float and double formal arguments..
Wed, Nov 13, 8:09 AM · Restricted Project
ZarkoCA updated the diff for D69578: [AIX] Add support for lowering int, float and double formal arguments..
  1. Addressed second round of comments.
    • Added truncateScalarIntegerArgs function, now we add sext, zext nodes if they are needed and truncate whenever an int size is smaller than the register size.
    • use CCinfo to allocate stack.
    • consolidated calling convention testcases and removed some non-essential tests
Wed, Nov 13, 8:08 AM · Restricted Project

Nov 5 2019

ZarkoCA updated the diff for D69578: [AIX] Add support for lowering int, float and double formal arguments..

1 .Fixed broken testcases for AIX because of explicit error with altivec, and added reviewer for these.

  1. Added additional guard to assert if i64 are not split into i32 before register allocation.
  2. Rebased patch on master.
Nov 5 2019, 10:38 AM · Restricted Project

Oct 31 2019

ZarkoCA added inline comments to D69578: [AIX] Add support for lowering int, float and double formal arguments..
Oct 31 2019, 6:16 AM · Restricted Project

Oct 29 2019

ZarkoCA created D69578: [AIX] Add support for lowering int, float and double formal arguments..
Oct 29 2019, 11:51 AM · Restricted Project

Oct 23 2019

ZarkoCA added inline comments to D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..
Oct 23 2019, 6:30 PM · Restricted Project