Rebase and fix test.

Thanks for fixing this and for pre-comitting the test case.

Looks like I was beat to committing this by https://github.com/llvm/llvm-project/commit/9566c4a682065105a653c4c148325671755faace. Abandoning since the change is already in.

• Rebase and add FDecl check before calling checkAIXMemberAlignment()

• Fixed double use of ClUseDefaultBlacklist

Rebase and fix formatting

Ping

Ping

ping

ping

Pinging this for the libc++ group

• Restructured checks
• fixed comment
• removed unnecessary parameter passed to function
• slightly reworded summary of patch

• Remove formatting changes to unrelated code

• Try to remove deeply nested ifs by using early returns
• Fix note so it refers to struct
• Add a struct that isn't called byval in test case to make it clearer that

warning isn't emitted on every declaration

Reworked implementation so the diagnosis is more correct:

• Warn when the struct is passed that contains the member
• Warn when alignment is 16 and not 16 and greater

After offline discussion with @sfertile , the warning should occur only when the struct member is passed on the stack. I will be updating the patch shortly.

• Shorten warning message
• Add new note

• Warn on declaration of struct member and add note for call

• Add note for diagnostic pointing to declaration of the struct member
• cleaned up use of unneeded variable

• Moved AIX check to its own function to hopefully avoid Arg and ArgTy getting out of sync
• Rebased and removed LIT test cases workaround

I don't know whether it's an issue that the patch is missing context but the change is good, Thanks @daltenty

In D118350#3282855, @nemanjai wrote:

Would it make sense (and would it be possible) to check the linkage of the callee? Presumably calling something like
static void localfunc(int *)
with an over-aligned member shouldn't be a problem.

• Warning shouldn't apply to functions that have internal linkage

Addressed some of the comments:

Addressing comments:

• Fixed formatting
• Fixed test case
• Check for when Arg is nullptr

Ping.

Ping.

LGTM, thanks

• Address comments (removed settings that are already default)

Enabled test-suite.

In D115305#3201112, @gkistanova wrote:

Hi Zarko,

This patch has broken llvm-zorg.

There is no worker with the name "aix-ppc64" in the workers.py.

Did you forget to rename "aix-ppc64-ppc64le" to "aix-ppc64"?

If so, I have fixed that for you in https://github.com/llvm/llvm-zorg/commit/d4d8bac3d9d02ad73201dd2d5156724a7e421db0. Don't forget to rename you worker in the buildbot.tac file and restart.

Otherwise, you would need to propose a patch for workers.py.

Thanks, LGTM.

• Add OBJECT_MODE

The change seems fine but would you mind adding the reason why this test is not expected to pass on AIX in the description?

Ping.

Ping

In D114025#3162140, @rjmccall wrote:

Those all look good, thanks.

@rjmccall These are the proposed changes which address some of your comments. I am planning on waiting for further clarification on some of the others.

Pushed 715d2dc126ee4aaf0cb1df8826c3f1072c952e66 to fix the docs buildbot break.