Page MenuHomePhabricator

ZarkoCA (Zarko Todorovski)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2018, 9:51 AM (102 w, 6 d)

Recent Activity

Today

ZarkoCA committed rGbc7b2688d676: Add -fintegrated-as to second invocation of clang in test case. (authored by ZarkoCA).
Add -fintegrated-as to second invocation of clang in test case.
Mon, Nov 30, 9:16 AM

Fri, Nov 27

ZarkoCA added inline comments to D78903: [Driver] Add option -fproc-stat-report.
Fri, Nov 27, 2:57 PM · Restricted Project
ZarkoCA committed rG979bcbd3a6f7: Add -fintegrated-as to clang invocation (authored by ZarkoCA).
Add -fintegrated-as to clang invocation
Fri, Nov 27, 12:57 PM
ZarkoCA committed rGff8e8c1b14ea: [AIX] Enabling vector type arguments and return for AIX (authored by ZarkoCA).
[AIX] Enabling vector type arguments and return for AIX
Fri, Nov 27, 6:56 AM
ZarkoCA closed D92117: [AIX] Enabling vector type arguments and return for AIX.
Fri, Nov 27, 6:56 AM · Restricted Project

Thu, Nov 26

ZarkoCA added inline comments to D78903: [Driver] Add option -fproc-stat-report.
Thu, Nov 26, 10:29 AM · Restricted Project
ZarkoCA committed rG6d648e69c094: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX (authored by ZarkoCA).
[AIX] Add support for non var_arg extended vector ABI calling convention on AIX
Thu, Nov 26, 9:04 AM
ZarkoCA closed D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Thu, Nov 26, 9:04 AM · Restricted Project
ZarkoCA updated the diff for D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Updated regex in test cases to check register correct usage.

Thu, Nov 26, 7:26 AM · Restricted Project

Wed, Nov 25

ZarkoCA retitled D92117: [AIX] Enabling vector type arguments and return for AIX from [AIX] Enabling vector types for AIX to [AIX] Enabling vector type arguments and return for AIX.
Wed, Nov 25, 7:33 PM · Restricted Project
ZarkoCA updated the diff for D92117: [AIX] Enabling vector type arguments and return for AIX.

Added regex and variable for function attribute

Wed, Nov 25, 7:29 PM · Restricted Project
ZarkoCA updated the summary of D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Wed, Nov 25, 3:12 PM · Restricted Project
ZarkoCA updated the diff for D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Removed passing vector parameters to the stack portion of patch, fixed test case and added test cases for errors.

Wed, Nov 25, 3:11 PM · Restricted Project
ZarkoCA retitled D92117: [AIX] Enabling vector type arguments and return for AIX from [AIX] Enabling vectory types for AIX to [AIX] Enabling vector types for AIX.
Wed, Nov 25, 11:53 AM · Restricted Project
ZarkoCA requested review of D92117: [AIX] Enabling vector type arguments and return for AIX.
Wed, Nov 25, 10:50 AM · Restricted Project
ZarkoCA added inline comments to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Wed, Nov 25, 7:37 AM · Restricted Project
ZarkoCA updated the diff for D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Removed vector long error

Wed, Nov 25, 7:35 AM · Restricted Project

Tue, Nov 24

ZarkoCA committed rGbe7d425edc64: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI (authored by ZarkoCA).
[PPC][AIX] Add vector callee saved registers for AIX extended vector ABI
Tue, Nov 24, 8:02 PM
ZarkoCA closed D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Tue, Nov 24, 8:02 PM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Seems a few test cases require mattr=-altivec to pass with this patch.

Tue, Nov 24, 7:33 PM · Restricted Project, Restricted Project
ZarkoCA committed rGc92f29b05e68: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector… (authored by ZarkoCA).
[AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector…
Tue, Nov 24, 3:18 PM
ZarkoCA closed D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Tue, Nov 24, 3:18 PM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Tue, Nov 24, 2:06 PM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .

Simplified option logic as per suggestion.
Removed stray isXCOFF reference.

Tue, Nov 24, 2:04 PM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Tue, Nov 24, 10:33 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .

Went back to old option selection logic as updated version did not emit an error when selecting 'maltivec` but not mabi=vec-extabi.

Tue, Nov 24, 10:24 AM · Restricted Project, Restricted Project

Mon, Nov 23

ZarkoCA updated the diff for D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .

Addressed some of the comments.

Mon, Nov 23, 1:46 PM · Restricted Project, Restricted Project

Fri, Nov 20

ZarkoCA updated the diff for D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .

Addressed comments and added a test to check whether the driver passes these options.

Fri, Nov 20, 8:09 AM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Fri, Nov 20, 8:03 AM · Restricted Project, Restricted Project

Thu, Nov 19

ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Fixed failing test cases.

Thu, Nov 19, 3:17 PM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Thu, Nov 19, 1:10 PM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Rebase and remove regmask altivec change.

Thu, Nov 19, 1:08 PM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Thu, Nov 19, 12:51 PM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .

Addressed comments:
Added and fixed test cases and changed option selection logic.

Thu, Nov 19, 12:45 PM · Restricted Project, Restricted Project

Wed, Nov 18

ZarkoCA added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Wed, Nov 18, 12:36 PM · Restricted Project, Restricted Project
ZarkoCA accepted D91265: [PowerPC] Don't reuse the address of an illegal typed load for int_to_fp..
Wed, Nov 18, 6:38 AM · Restricted Project, Restricted Project

Fri, Nov 13

ZarkoCA updated the diff for D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Rebase to reflect changes in parent revisions.

Fri, Nov 13, 9:54 AM · Restricted Project
ZarkoCA added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Fri, Nov 13, 8:02 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Rebased and addressed comments.

Fri, Nov 13, 8:00 AM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Fri, Nov 13, 7:54 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .

Addressed comments:

Fri, Nov 13, 7:30 AM · Restricted Project, Restricted Project

Oct 19 2020

ZarkoCA updated the diff for D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Addressed comments and adding parent revisions.

Oct 19 2020, 3:42 AM · Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Fixed typo in test case.

Oct 19 2020, 3:39 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Separated the option portion of the previous diff (now found here: https://reviews.llvm.org/D89684).
Addressed other comments.

Oct 19 2020, 3:32 AM · Restricted Project, Restricted Project
ZarkoCA requested review of D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Oct 19 2020, 3:27 AM · Restricted Project, Restricted Project

Oct 16 2020

ZarkoCA accepted D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error.

LGTM

Oct 16 2020, 7:01 AM · Restricted Project

Oct 15 2020

ZarkoCA added inline comments to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Oct 15 2020, 2:41 PM · Restricted Project
ZarkoCA updated the diff for D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Rebased based on new changes in https://reviews.llvm.org/D88676.
Added error for vector long type.

Oct 15 2020, 2:34 PM · Restricted Project
ZarkoCA added a reviewer for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI: cebowleratibm.
Oct 15 2020, 10:16 AM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Oct 15 2020, 10:15 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Added mvecnvol/mnovecnvol options in clang and vecnvol option in llc
Addressed other comments related to formatting and test case regex usage.
Updated test cases that fail when vecnvol is enabled.

Oct 15 2020, 10:13 AM · Restricted Project, Restricted Project

Oct 7 2020

ZarkoCA added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Oct 7 2020, 6:26 AM · Restricted Project, Restricted Project

Oct 6 2020

ZarkoCA added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Oct 6 2020, 1:05 PM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Added test case that includes FP and GP csrs along with the vector crs.
Reduced the number of clobbered VRs in the initial test case.

Oct 6 2020, 12:54 PM · Restricted Project, Restricted Project

Oct 5 2020

ZarkoCA updated the diff for D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

This patch now only contains the ISel lowering portion of the previous version. Additionally, lowering on the callee side was implemented since with the work already contained in CC_AIX only the removal of the error in LowerCall_AIX() was required. Return vector types was also enabled. The test case checks the caller, callee and return assembly instructions.

Oct 5 2020, 7:50 AM · Restricted Project

Oct 1 2020

ZarkoCA requested review of D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Oct 1 2020, 9:53 AM · Restricted Project, Restricted Project

Sep 30 2020

ZarkoCA committed rG052c5bf40a9f: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9 (authored by ZarkoCA).
[PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9
Sep 30 2020, 8:07 AM
ZarkoCA closed D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Sep 30 2020, 8:07 AM · Restricted Project
ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Code changes didn't get included in last diff.

Sep 30 2020, 7:59 AM · Restricted Project
ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Used REG variables in 64Bit part of test case.

Sep 30 2020, 7:56 AM · Restricted Project

Sep 29 2020

ZarkoCA accepted D75059: [PowerPC] Remove support for VRSAVE save/restore/update..

LGTM.

Sep 29 2020, 1:27 PM · Restricted Project, Restricted Project

Sep 28 2020

ZarkoCA added a comment to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Hi Zarko, could rebase this patch on the latest master?

Sep 28 2020, 9:29 AM · Restricted Project
ZarkoCA added inline comments to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Sep 28 2020, 7:35 AM · Restricted Project

Sep 25 2020

ZarkoCA added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Sep 25 2020, 8:09 PM · Restricted Project
ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Fixed register usage.

Sep 25 2020, 1:01 PM · Restricted Project
ZarkoCA added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Sep 25 2020, 1:01 PM · Restricted Project
ZarkoCA committed rGf330d9f163f6: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX (authored by cebowleratibm).
[PPC] [AIX] Implement calling convention IR for C99 complex types on AIX
Sep 25 2020, 4:44 AM
ZarkoCA closed D88130: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX.
Sep 25 2020, 4:44 AM · Restricted Project

Sep 24 2020

ZarkoCA accepted D88130: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX.

LGTM.

Sep 24 2020, 8:37 PM · Restricted Project
ZarkoCA committed rG64b8a633a872: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex (authored by cebowleratibm).
[NFC] [PPC] Add PowerPC expected IR tests for C99 complex
Sep 24 2020, 8:31 PM
ZarkoCA closed D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.
Sep 24 2020, 8:31 PM · Restricted Project
ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Generated test case using update_llc_test_checks.py, added stores and used DAG instead of NEXT when appropriate.

Sep 24 2020, 11:44 AM · Restricted Project
ZarkoCA planned changes to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Going to work on rebasing this patch.

Sep 24 2020, 6:09 AM · Restricted Project
ZarkoCA added a comment to D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.

This clearly changes behaviour and should thereby not have the [NFC] tag.

Sep 24 2020, 6:08 AM · Restricted Project

Sep 23 2020

ZarkoCA accepted D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.

Thanks for doing the formatting changes.

Sep 23 2020, 8:13 PM · Restricted Project
ZarkoCA added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Sep 23 2020, 8:11 PM · Restricted Project
ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Updated test case.

Sep 23 2020, 8:01 PM · Restricted Project
ZarkoCA added inline comments to D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.
Sep 23 2020, 7:39 AM · Restricted Project

Sep 22 2020

ZarkoCA added inline comments to D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.
Sep 22 2020, 10:41 AM · Restricted Project
ZarkoCA added a comment to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Does PPCMIPeephole::combineSEXTAndSHL have a similar problem that needs to be addressed?

Sep 22 2020, 9:52 AM · Restricted Project

Sep 21 2020

ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Moved !Subtarget.isPPC64() check earlier alongside other checks.

Sep 21 2020, 5:15 AM · Restricted Project
ZarkoCA added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Sep 21 2020, 5:13 AM · Restricted Project

Sep 10 2020

ZarkoCA committed rG035396197a5f: Remove unused variable introduce in 0448d11a06b451a causing build (authored by ZarkoCA).
Remove unused variable introduce in 0448d11a06b451a causing build
Sep 10 2020, 5:11 PM

Sep 2 2020

ZarkoCA requested review of D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Sep 2 2020, 10:46 AM · Restricted Project

Aug 31 2020

ZarkoCA accepted D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..

Looks good with minor nit.

Aug 31 2020, 7:34 AM · Restricted Project, Restricted Project

Aug 24 2020

ZarkoCA updated the summary of D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Aug 24 2020, 10:56 AM · Restricted Project
ZarkoCA requested review of D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Aug 24 2020, 10:33 AM · Restricted Project

Aug 14 2020

ZarkoCA added inline comments to D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..
Aug 14 2020, 10:14 AM · Restricted Project, Restricted Project

Jul 20 2020

ZarkoCA added a comment to D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values.

LGTM but I will leave it up for a bit so other reviewers have a chance to look at it.

Jul 20 2020, 6:03 AM · Restricted Project

Jun 26 2020

ZarkoCA accepted D82030: [PowerPC][AIX] Enable base-pointer..

I think this one is good. I wonder if there should be more tests to check corrected alignment of various allocations but that seems out of scope for the patch and the tests in https://reviews.llvm.org/D72454 covered that anyway.

Jun 26 2020, 10:55 AM · Restricted Project, Restricted Project

Jun 25 2020

ZarkoCA committed rGe504a23b634d: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp (authored by ZarkoCA).
[NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp
Jun 25 2020, 6:54 AM
ZarkoCA closed D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.
Jun 25 2020, 6:54 AM · Restricted Project, Restricted Project
ZarkoCA updated the summary of D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.
Jun 25 2020, 6:53 AM · Restricted Project, Restricted Project

Jun 24 2020

ZarkoCA updated the diff for D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.

Added High/Low Memory labels to diagram.

Jun 24 2020, 9:09 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.

Addressed Sean's comments:

Jun 24 2020, 8:36 AM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.
Jun 24 2020, 8:36 AM · Restricted Project, Restricted Project

Jun 23 2020

ZarkoCA created D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.
Jun 23 2020, 2:00 PM · Restricted Project, Restricted Project

May 22 2020

ZarkoCA added inline comments to D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions.
May 22 2020, 8:33 AM · Restricted Project
ZarkoCA added inline comments to D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions.
May 22 2020, 8:33 AM · Restricted Project

May 20 2020

ZarkoCA accepted D79252: [PowerPC][AIX] Spill CSRs to the ABI specified stack offsets..
May 20 2020, 12:03 PM · Restricted Project, Restricted Project