This is an archive of the discontinued LLVM Phabricator instance.

[Timer] On macOS count number of executed instructions
ClosedPublic

Authored by ahoppen on Feb 4 2021, 8:36 AM.

Details

Summary

In addition to wall time etc. this should allow us to get less noisy
values for time measurements.

Diff Detail

Event Timeline

ahoppen created this revision.Feb 4 2021, 8:36 AM
ahoppen requested review of this revision.Feb 4 2021, 8:36 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 4 2021, 8:36 AM
ahoppen updated this revision to Diff 321467.Feb 4 2021, 9:01 AM

Fixed an issue caused by me using an old revions as the commit's base.

JDevlieghere accepted this revision.Feb 8 2021, 1:24 PM

Seems useful! LGTM.

This revision is now accepted and ready to land.Feb 8 2021, 1:24 PM
This revision was landed with ongoing or failed builds.Feb 11 2021, 8:27 AM
This revision was automatically updated to reflect the committed changes.
thakis added a subscriber: thakis.Feb 11 2021, 8:50 AM
thakis added inline comments.
llvm/include/llvm/Config/config.h.cmake
356

Any reason to use #cmakedefine instead of cmakedefine01 here? This type of check usually uses #cmakedefine01 in this file.

thakis added inline comments.Feb 11 2021, 8:51 AM
llvm/CMakeLists.txt
656

also, any reason to not do this in llvm/cmake/config-ix.cmake where all the other checks like this are?

thakis added inline comments.Feb 11 2021, 8:53 AM
llvm/include/llvm/Config/config.h.cmake
356

Please ignore this, #cmakedefine is what most other HAVE_ things use. I misremembered this.

ahoppen added inline comments.Feb 11 2021, 10:12 AM
llvm/CMakeLists.txt
656

No, I just didn't know about llvm/cmake/config-ix.cmake. I’ll move it there. Thanks!