Page MenuHomePhabricator

ahoppen (Alex Hoppen)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2021, 8:24 AM (50 w, 4 d)

Recent Activity

Wed, Jan 19

ahoppen accepted D117566: [clang][lex] Introduce `SearchDirIterator`.
Wed, Jan 19, 6:09 AM · Restricted Project

Fri, Jan 14

ahoppen accepted D117312: [clang][lex] NFC: Simplify calls to `LookupFile`.

LGTM.

Fri, Jan 14, 10:09 AM · Restricted Project, Restricted Project
ahoppen accepted D117309: [clang] NFC: Remove unused `DirectoryLookup`.

LGTM.

Fri, Jan 14, 10:02 AM · Restricted Project

Tue, Jan 11

ahoppen accepted D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date.
Tue, Jan 11, 5:40 AM · Restricted Project

Mon, Jan 10

ahoppen added inline comments to D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date.
Mon, Jan 10, 10:26 AM · Restricted Project
ahoppen added a comment to D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date.

I like this a lot better. Some comments inline.

Mon, Jan 10, 7:50 AM · Restricted Project

Fri, Jan 7

ahoppen accepted D116751: [clang][lex] NFC: Extract module creation into function.

Ah, in that case it makes sense as-is. I just assumed they lived in the same library.

Fri, Jan 7, 5:36 AM · Restricted Project
ahoppen added a comment to D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date.

I would prefer to use std::shared_ptr<DirectoryLookup> instead of unsigned. IIUC we already basically have a level of indirection because if we want to get the DirectoryLookup, we need to find it by its index in SearchDirs. And updating the indices just seems like a hack to me that can be solved more cleanly.

Fri, Jan 7, 5:24 AM · Restricted Project
ahoppen added a comment to D116751: [clang][lex] NFC: Extract module creation into function.

I just want to make sure that we don’t accidentally introduce a new instantiation of a Module that doesn’t go through makeModule in the future.

Fri, Jan 7, 5:16 AM · Restricted Project
ahoppen added a comment to D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date.

Adjusting the indices seem pretty fragile to me. Any reason why you wanted to stick with indices as keys instead of switching to something else like I suggested here?

Fri, Jan 7, 3:57 AM · Restricted Project
ahoppen added a comment to D116751: [clang][lex] NFC: Extract module creation into function.

I suppose the idea is that all Module creations should go through makeModule, right? In that case I think we should either

  • make the Module constructor private and ModuleMap a friend of Module
  • or at least add a doc comment to the Module constructor that says Modules should only be created using ModuleMap::makeModule.
Fri, Jan 7, 3:53 AM · Restricted Project

Nov 17 2021

ahoppen added inline comments to D113676: [clang][lex] Fix search path usage remark with modules.
Nov 17 2021, 4:35 AM · Restricted Project

Nov 12 2021

ahoppen added inline comments to D113676: [clang][lex] Fix search path usage remark with modules.
Nov 12 2021, 7:57 AM · Restricted Project
ahoppen added a comment to D113676: [clang][lex] Fix search path usage remark with modules.

LGTM overall. I’ve got a few questions/remarks inline.

Nov 12 2021, 2:44 AM · Restricted Project

May 6 2021

ahoppen added a reviewer for D102001: [Index] Ignore nullptr decls for indexing: akyrtzi.
May 6 2021, 9:53 AM · Restricted Project
ahoppen requested review of D102001: [Index] Ignore nullptr decls for indexing.
May 6 2021, 9:52 AM · Restricted Project

Feb 18 2021

ahoppen added inline comments to D96713: [cmake] Move check for libproc to config-ix.cmake.
Feb 18 2021, 2:00 AM · Restricted Project

Feb 15 2021

ahoppen added a reviewer for D96713: [cmake] Move check for libproc to config-ix.cmake: thakis.
Feb 15 2021, 7:51 AM · Restricted Project
ahoppen requested review of D96713: [cmake] Move check for libproc to config-ix.cmake.
Feb 15 2021, 7:49 AM · Restricted Project

Feb 11 2021

ahoppen added inline comments to D96049: [Timer] On macOS count number of executed instructions.
Feb 11 2021, 10:12 AM · Restricted Project, Restricted Project

Feb 4 2021

ahoppen updated the diff for D96049: [Timer] On macOS count number of executed instructions.

Fixed an issue caused by me using an old revions as the commit's base.

Feb 4 2021, 9:01 AM · Restricted Project, Restricted Project
ahoppen added a reviewer for D96049: [Timer] On macOS count number of executed instructions: chandlerc.
Feb 4 2021, 8:48 AM · Restricted Project, Restricted Project
ahoppen requested review of D96049: [Timer] On macOS count number of executed instructions.
Feb 4 2021, 8:36 AM · Restricted Project, Restricted Project