Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

[AArch64] Enable stack clash protection for AArch64 linux in clang
Needs ReviewPublic
Actions

Authored by ostannard on Feb 4 2021, 2:31 AM.

Details

Reviewers

serge-sans-paille
• jnspaulsson
bzEq
tnfchris
aemerson

Summary

This allows the -fstack-clash-protection option to be used for AArch64
Linux.

Linux for AArch64 uses a 64k stack guard, instead of the 4k guard
assumed by the backend, so we set the stack-probe-size function
attribute to configure this, and the -mstack-probe-size= option can be
used to override this.

Diff Detail

Event Timeline

ostannard created this revision.Feb 4 2021, 2:31 AM

Herald added subscribers: danielkiss, kristof.beyls. · View Herald TranscriptFeb 4 2021, 2:31 AM

ostannard requested review of this revision.Feb 4 2021, 2:31 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2021, 2:31 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

ostannard added a parent revision: D96006: [AArch64] Stack probing for dynamic allocas in GlobalISel.Feb 4 2021, 2:31 AM

Harbormaster completed remote builds in B87857: Diff 321355.Feb 4 2021, 4:13 AM

lkail added a subscriber: lkail.Feb 5 2021, 2:14 AM

ostannard updated this revision to Diff 321689.Feb 5 2021, 2:38 AM

alex added a subscriber: alex.Feb 22 2021, 4:32 PM

lzutao added a subscriber: lzutao.Feb 22 2021, 7:21 PM

siddhesh added a subscriber: siddhesh.Feb 24 2021, 7:59 PM

emaste added a subscriber: emaste.Aug 23 2021, 11:51 AM

kawadakk added a subscriber: kawadakk.Oct 25 2021, 6:41 PM

samtebbs added a subscriber: samtebbs.Nov 3 2022, 4:57 AM

samtebbs added inline comments.

clang/lib/CodeGen/CodeGenModule.cpp
1669–1672	Would it be worth always setting the `stack-probe-size` attribute so that it is always correct and to avoid the risk of it going out-of-sync in case of changes to the assumed size in the backend?