Page MenuHomePhabricator

alex (Alex Gaynor)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2014, 7:57 AM (292 w, 5 d)

Recent Activity

Aug 5 2019

alex added a comment to D65782: [CompilerType] Simplify the interface a bit more...

I was marked as a review on this, but I suspect you intended to get some other Alex :-)

Aug 5 2019, 4:37 PM · Restricted Project, Restricted Project

Jul 30 2019

alex added a comment to D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin.

I had a patch to use posix_spawn on all posix platforms, but hit some issues I didn't quite have the time to debug all the way through. It's a good idea in my view.

Jul 30 2019, 6:54 PM · Restricted Project, Restricted Project

Nov 19 2018

alex added a comment to D54723: [COFF] Add exported functions to gfids table for /guard:cf.

I don't know this code very well at all, so just one small comment that jumped out to me. Conceptually it looks like this solves the problem we were seeing. Thanks for jumping on this so quickly!

Nov 19 2018, 2:12 PM

Jun 29 2018

alex added a comment to D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().

Do you need any additional changes from me?

Jun 29 2018, 10:21 AM

Jun 27 2018

alex updated the diff for D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().
  • Use at_scope_exit to simplify destroying the posix_spawn_file_actions
Jun 27 2018, 7:27 AM

Jun 26 2018

alex added a comment to D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().

Would you be ok landing this with the current approach (+/- any other feedback of course), and filing a follow-up bug to switch it to a runtime check?

Jun 26 2018, 2:05 PM
alex updated the diff for D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().
  • Simply use vfork everywhere, the macOS manpage does not describe it's semantics correctly.
  • Query for sysconf open max before vforking
  • Switch back to using posix_spawn everywhere but Android
  • Use posix_spawn based implementation on r28+ for Android
  • Destroy file_actions
Jun 26 2018, 10:35 AM
alex added inline comments to D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().
Jun 26 2018, 10:35 AM

Jun 25 2018

alex updated the diff for D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().
  • Use posix_spawn based implementation on r28+ for Android
Jun 25 2018, 7:33 AM

Jun 22 2018

alex added a comment to D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().

Yes, I imagine such a thing is possible. It may also be detect at compile time which version of the SDK it's targetting, but I don't know the Android SDK (NDK?) well enough to say how.

Jun 22 2018, 12:21 PM
alex updated the diff for D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().
  • Switch back to using posix_spawn everywhere but Android
Jun 22 2018, 10:53 AM
alex added a comment to D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().

Fantastic, thanks for the review. (As an FYI I'm not an llvm committer, so I can't land this myself).

Jun 22 2018, 9:11 AM
alex updated the diff for D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().
  • Query for sysconf open max before vforking
Jun 22 2018, 9:01 AM
alex updated the diff for D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().
  • Simply use vfork everywhere, the macOS manpage does not describe it's semantics correctly.
Jun 22 2018, 8:59 AM
alex added a comment to D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().

Good call actually checking the manpage... both dup2 and close seem to work perfectly fine in the child after vfork. I'll update the patch accordingly.

Jun 22 2018, 8:45 AM
alex added a comment to D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().

Sorry I did not notice this before. Try vfork?

Jun 22 2018, 8:09 AM

Jun 21 2018

alex created D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork().
Jun 21 2018, 12:51 PM

Jun 7 2018

alex added a comment to D47837: [libFuzzer] When printing NEW_FUNC, use 1-base indexing..

I'm not an llvm committer, what's the process for getting this landed from here?

Jun 7 2018, 6:16 AM

Jun 6 2018

alex created D47837: [libFuzzer] When printing NEW_FUNC, use 1-base indexing..
Jun 6 2018, 10:35 AM

Apr 6 2018

alex added a comment to D45322: [libFuzzer] Print a correct error message when a director can't be opened.

Thanks!

Apr 6 2018, 11:07 AM
alex added a comment to D45322: [libFuzzer] Print a correct error message when a director can't be opened.

@morehouse I'm not familiar with the LLVM development process, what's the next step now that this has been reviewed?

Apr 6 2018, 10:44 AM
alex added a reviewer for D45322: [libFuzzer] Print a correct error message when a director can't be opened: morehouse.
Apr 6 2018, 8:14 AM

Apr 5 2018

alex created D45322: [libFuzzer] Print a correct error message when a director can't be opened.
Apr 5 2018, 6:53 AM

Aug 14 2016

alex resigned from D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() ).
Aug 14 2016, 6:20 AM

May 9 2016

alex removed a reviewer for D20018: Support variables and functions types in misc-unused-using-decls.: alex.
May 9 2016, 5:15 AM