Page MenuHomePhabricator

siddhesh (Siddhesh Poyarekar)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2018, 11:34 AM (154 w, 5 d)

Recent Activity

Dec 21 2020

siddhesh added a comment to D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

Thanks! Can you please commit for me? I don't have write access to the repo.

Dec 21 2020, 5:52 AM · Restricted Project
siddhesh updated the diff for D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

Fixed clang-format-patch failure.

Dec 21 2020, 1:48 AM · Restricted Project

Dec 18 2020

siddhesh updated the diff for D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

I ended up putting the assumption before the ObjectSize. Here's an update that puts the assumption on the expression we built since that's what the comment says anyway. @serge-sans-paille your method of shadowing Builder and inserting after ObjectSize would work too (I should have looked carefully the first time, sorry) but I thought this way flows better with the rest of the code in that block. I'll be happy to use your approach if you think that's better.

Dec 18 2020, 9:32 PM · Restricted Project
siddhesh updated the diff for D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.
Dec 18 2020, 11:22 AM · Restricted Project
siddhesh updated the diff for D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

Updated patch. I'm not entirely sure if I 'fixed' the failing test case (limit-max-iterations.ll) correctly. Earlier it would reduce in two instcombine iterations but with this assumption, it reduces to its minimal form (i.e. with just the llvm.assume and ret) in just one iteration.

Dec 18 2020, 11:19 AM · Restricted Project
siddhesh added a comment to D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

@siddhesh what anout the following?

Dec 18 2020, 10:12 AM · Restricted Project

Dec 17 2020

siddhesh added inline comments to D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.
Dec 17 2020, 4:28 AM · Restricted Project
siddhesh updated the diff for D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

Updated version using Uses and getOperandNo as suggested. I have not used llvm.assume yet, more in another comment.

Dec 17 2020, 4:19 AM · Restricted Project

Dec 15 2020

siddhesh added a comment to D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

When __builtin_dynamic_object_size returns a non-constant expression, it cannot be -1 since that is an invalid return value for object size

I disagree with that statement. For instance

void copy_into_buffer(char* buffer) {
   __builtin___strlcpy_chk(buffer, "some string", strlen("some string"), __builtin_dynamic_object_size(buffer, 0))
 }

In that case, __builtin_dynamic_object_size may return -1, e.g. if copy_into_buffer has external linkage, and thus no information on buffer is available

Dec 15 2020, 2:21 AM · Restricted Project

Dec 10 2020

siddhesh updated the diff for D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

More formatting fixes, sorry for the noise.

Dec 10 2020, 3:44 AM · Restricted Project
siddhesh updated the diff for D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

Updated for coding style fixes.

Dec 10 2020, 3:09 AM · Restricted Project
siddhesh requested review of D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.
Dec 10 2020, 2:10 AM · Restricted Project

Dec 9 2020

siddhesh abandoned D43004: [LNT] Set the baseline run id in flask session and not baseline id.

I don't remember anymore why I needed this, so abandoning it.

Dec 9 2020, 2:08 AM

Dec 8 2020

siddhesh added a comment to D92914: Fix typo in llvm/lib/Target/README.txt.

I do not have commit access, so please commit the change for me. Thanks!

Dec 8 2020, 10:41 PM · Restricted Project
siddhesh updated the summary of D92914: Fix typo in llvm/lib/Target/README.txt.
Dec 8 2020, 10:40 PM · Restricted Project
siddhesh requested review of D92914: Fix typo in llvm/lib/Target/README.txt.
Dec 8 2020, 10:39 PM · Restricted Project

Nov 19 2020

siddhesh added inline comments to D91677: Avoid simplification of library functions when callee has an implementation.
Nov 19 2020, 5:54 AM · Restricted Project
siddhesh added a comment to D91677: Avoid simplification of library functions when callee has an implementation.

Interestingly, gcc and clang have different behavior here: https://godbolt.org/z/hdadhY

Nov 19 2020, 4:38 AM · Restricted Project

Nov 18 2020

siddhesh added a comment to D91677: Avoid simplification of library functions when callee has an implementation.

And by mark them, you could also use -fno-builtin=???, see D68028.

Nov 18 2020, 10:03 AM · Restricted Project
siddhesh added inline comments to D91677: Avoid simplification of library functions when callee has an implementation.
Nov 18 2020, 9:21 AM · Restricted Project
siddhesh updated the diff for D91677: Avoid simplification of library functions when callee has an implementation.

Made the change more generic, avoiding simplification if the callee has an implementation, i.e. its body is not empty.

Nov 18 2020, 9:01 AM · Restricted Project

Nov 17 2020

siddhesh added a comment to D91677: Avoid simplification of library functions when callee has an implementation.

The problem you're trying to solve doesn't seem specific to bcopy: any function with an inline definition should probably *not* be replaced, and the inlined definition should be favored. This was the spirit of that patch https://reviews.llvm.org/D71082. i wonder why your test case doesn't fall into that configuration.

Nov 17 2020, 11:08 PM · Restricted Project
siddhesh added a comment to D91677: Avoid simplification of library functions when callee has an implementation.

Sorry, I think I ran only check-llvm. I'll look at the test breakage.

Nov 17 2020, 8:49 PM · Restricted Project
siddhesh requested review of D91677: Avoid simplification of library functions when callee has an implementation.
Nov 17 2020, 8:12 PM · Restricted Project

Feb 6 2018

siddhesh updated the diff for D43004: [LNT] Set the baseline run id in flask session and not baseline id.

Sorry, the fix should have been in setting of baseline, not in the baseline menu itself. Fixed and tested.

Feb 6 2018, 11:58 PM
siddhesh created D43004: [LNT] Set the baseline run id in flask session and not baseline id.
Feb 6 2018, 11:39 PM

Feb 5 2018

siddhesh retitled D42894: [LNT] Use session saved baseline in run comparison report from Use session saved baseline in run comparison report to [LNT] Use session saved baseline in run comparison report.
Feb 5 2018, 11:50 PM · Restricted Project

Feb 4 2018

siddhesh created D42894: [LNT] Use session saved baseline in run comparison report.
Feb 4 2018, 11:41 AM · Restricted Project