- User Since
- Feb 4 2018, 11:34 AM (154 w, 5 d)
Dec 21 2020
Thanks! Can you please commit for me? I don't have write access to the repo.
Fixed clang-format-patch failure.
Dec 18 2020
I ended up putting the assumption before the ObjectSize. Here's an update that puts the assumption on the expression we built since that's what the comment says anyway. @serge-sans-paille your method of shadowing Builder and inserting after ObjectSize would work too (I should have looked carefully the first time, sorry) but I thought this way flows better with the rest of the code in that block. I'll be happy to use your approach if you think that's better.
Updated patch. I'm not entirely sure if I 'fixed' the failing test case (limit-max-iterations.ll) correctly. Earlier it would reduce in two instcombine iterations but with this assumption, it reduces to its minimal form (i.e. with just the llvm.assume and ret) in just one iteration.
Dec 17 2020
Updated version using Uses and getOperandNo as suggested. I have not used llvm.assume yet, more in another comment.
Dec 15 2020
Dec 10 2020
More formatting fixes, sorry for the noise.
Updated for coding style fixes.
Dec 9 2020
I don't remember anymore why I needed this, so abandoning it.
Dec 8 2020
I do not have commit access, so please commit the change for me. Thanks!
Nov 19 2020
Nov 18 2020
Made the change more generic, avoiding simplification if the callee has an implementation, i.e. its body is not empty.
Nov 17 2020
Sorry, I think I ran only check-llvm. I'll look at the test breakage.
Feb 6 2018
Sorry, the fix should have been in setting of baseline, not in the baseline menu itself. Fixed and tested.