Compiler Engineer at Arm Holdings
User Details
- User Since
- Oct 17 2019, 4:54 AM (141 w, 6 d)
May 23 2022
May 6 2022
ping
Apr 29 2022
change brace style
Apr 20 2022
Landed with dcf5fc3f60846b5d2e436befb934493f5132ffd9
Dec 3 2021
@kpdev42 it looks like @cmatthews left some comments for you that haven't been addressed yet. Would be good to address them so we can move this forward a bit.
Nov 29 2021
So by depending on objdump it does mean you can only really support one target at once (unless you have an objdump built with support for al bfd targets).
Looks like that's not a new change in this Diff. but something we might want to change in the future.
The code itself looks fine to me,
Nov 28 2021
Applying this locally, the regression triangles seem to be gone, was this intentionally?
Nov 9 2021
Yes this works fine and doesn't interfere with our approach.
Oct 22 2021
Oct 20 2021
Oct 13 2021
Sep 21 2021
This was already landed as part of D110141 :)
This is weird, your base commit is on https://reviews.llvm.org/rLNT6a3f7bbaa221aa13acb72947363acbc95a1bf583, but 6ba06570364b936c6bfb631e9d2e4f1374446bad was identical to this original change.
Hmm 6ba06570364b936c6bfb631e9d2e4f1374446bad is a very odd commit... why did that go in without any reviews..
Thanks! looks good to me but @thopre do you know what's up with the CI?
Sep 3 2021
Yes, thanks both!
Hmm the last time I upgraded pyyaml it started complaining about the interface we're using being insecure and a security issue. is that no longer the case?
Thanks! this looks complete now.
Ohh it's happening!
May 20 2021
The test HWAddressSanitizer-aarch64 :: TestCases/stack-uar-dynamic.c fails already at commit a647100b4320923b0e9d156cc3872b3be470ad98 which is before mine.
As such can't be caused by mine, I'll re-commit the patch.
Buildbot has shown a test failure in hwasan with reverting this. Investigating.
Ah I forgot the context.. Thanks @eugenis !
May 19 2021
Ping. Sorry for the early ping, but would be good to get bootstrap working again.
May 14 2021
reverted to diff that removed
May 13 2021
@MaskRay was that a you prefer it that way or?
May 10 2021
Update diff
May 7 2021
Mar 31 2021
For GCC this is guard-page - 1k. The reasoning is that with any outgoing argument larger than 1k we would probe such that we maintain the invariant, but probing that 1k means we have a whole guard-size -1k left that we can use without probing. These sizes were chose as they cover about 99% of all programs (for a subset of all :)).
Mar 16 2021
I don't know enough about LLVM to comment on the actual code so I will only comment on the output I see generated from the testcases.
Jan 16 2021
Aha thanks for the explanation
This commit adds the parameter and update call sites
accordingly, fixing one of Flake8's F821 warning (undefined name).
was it being indirectly imported before?
Jan 15 2021
This seems rather random compared with D94789... so the spacing rule isn't consistent for assignments?
Nice cleanup!
Jan 14 2021
I agree, this makes more sense so we don't break cPerf again.
Dec 13 2020
Dec 11 2020
use package relative import syntax
Updated comment
was landed in 60343998f7907b77e24f01c94c48ea6c753eca7e
Oct 14 2020
Aug 6 2020
Oct 17 2019
Add more context, to diff.