Page MenuHomePhabricator

tnfchris (Tamar Christina)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2019, 4:54 AM (141 w, 6 d)

Compiler Engineer at Arm Holdings

Recent Activity

May 23 2022

tnfchris committed rLNT77e0a25f996a: LNT: Only use text segment when isSO. (authored by tnfchris).
LNT: Only use text segment when isSO.
May 23 2022, 4:48 AM · Restricted Project
tnfchris closed D124663: LNT: Only use text segment when isSO.
May 23 2022, 3:55 AM · Restricted Project, Restricted Project

May 6 2022

tnfchris added a comment to D124663: LNT: Only use text segment when isSO.

ping

May 6 2022, 2:11 AM · Restricted Project, Restricted Project

Apr 29 2022

tnfchris updated the diff for D124663: LNT: Only use text segment when isSO.

change brace style

Apr 29 2022, 2:41 AM · Restricted Project, Restricted Project
tnfchris requested review of D124663: LNT: Only use text segment when isSO.
Apr 29 2022, 2:22 AM · Restricted Project, Restricted Project

Apr 20 2022

tnfchris committed rLNTdcf5fc3f6084: perf: Fix profile reading to correctly take segments into account. (authored by tnfchris).
perf: Fix profile reading to correctly take segments into account.
Apr 20 2022, 7:56 AM · Restricted Project
tnfchris closed D124088: perf: Fix profile reading to correctly take segments into account..

Landed with dcf5fc3f60846b5d2e436befb934493f5132ffd9

Apr 20 2022, 7:47 AM · Restricted Project, Restricted Project
tnfchris requested review of D124088: perf: Fix profile reading to correctly take segments into account..
Apr 20 2022, 6:11 AM · Restricted Project, Restricted Project

Dec 3 2021

tnfchris added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

@kpdev42 it looks like @cmatthews left some comments for you that haven't been addressed yet. Would be good to address them so we can move this forward a bit.

Dec 3 2021, 8:24 AM · Restricted Project

Nov 29 2021

tnfchris added a comment to D114641: [LNT] Remove `nm` dependency, used `objdump –t` instead.

So by depending on objdump it does mean you can only really support one target at once (unless you have an objdump built with support for al bfd targets).
Looks like that's not a new change in this Diff. but something we might want to change in the future.

Nov 29 2021, 8:01 AM · Restricted Project
tnfchris accepted D114641: [LNT] Remove `nm` dependency, used `objdump –t` instead.

The code itself looks fine to me,

Nov 29 2021, 12:27 AM · Restricted Project

Nov 28 2021

tnfchris added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

Applying this locally, the regression triangles seem to be gone, was this intentionally?

Nov 28 2021, 10:25 PM · Restricted Project

Nov 9 2021

tnfchris added a comment to D113470: Allow setting auth_token at 1st container startup.

Yes this works fine and doesn't interfere with our approach.

We took a different route here in that we COPY the lnt.cfg from outside the container into it to /etc/lnt-new.cfg and then restore it after the create command
but before the exec.

We do this since there are other settings we want to preserve, such as mail server settings etc.

Sounds like create-config should be modified to honor an existing config file so that you could just use a ADD in your Dockerfile

Nov 9 2021, 3:21 AM
tnfchris accepted D113470: Allow setting auth_token at 1st container startup.

Yes this works fine and doesn't interfere with our approach.

Nov 9 2021, 2:49 AM

Oct 22 2021

tnfchris accepted D112304: Fix flake8 failures.

Can we not run tox in the CI?

Oct 22 2021, 4:24 AM
tnfchris accepted D112182: Fix runtest/test_suite.shtest test.

Thanks!

Oct 22 2021, 1:45 AM

Oct 20 2021

tnfchris accepted D112148: Install future to run mypy on Python 3.

LGTM, thanks!

Oct 20 2021, 9:46 AM

Oct 13 2021

tnfchris added a comment to D96005: [AArch64] Stack probing for dynamic allocas in SelectionDAG.

Hi, does anyone have time to review the latest version of this patch?

Oct 13 2021, 3:49 PM · Restricted Project

Sep 21 2021

tnfchris added a comment to D110141: Fixed relative address in LNT profile control-flow graph..

I think it is no need to revert 6ba06570364b936c6bfb631e9d2e4f1374446bad - it looks like right solution
I've moved my changes to https://reviews.llvm.org/D110174

Argh sorry too late. Should I revert everything then or are we all good?

Sep 21 2021, 7:16 AM · Restricted Project
tnfchris added a comment to D110174: [LNT] Determine base for asm address.

This was already landed as part of D110141 :)

Sep 21 2021, 7:15 AM · Restricted Project
tnfchris added a comment to D110141: Fixed relative address in LNT profile control-flow graph..

This is weird, your base commit is on https://reviews.llvm.org/rLNT6a3f7bbaa221aa13acb72947363acbc95a1bf583, but 6ba06570364b936c6bfb631e9d2e4f1374446bad was identical to this original change.

Sep 21 2021, 6:50 AM · Restricted Project
tnfchris added a comment to D110141: Fixed relative address in LNT profile control-flow graph..

Hmm 6ba06570364b936c6bfb631e9d2e4f1374446bad is a very odd commit... why did that go in without any reviews..

Sep 21 2021, 6:41 AM · Restricted Project
tnfchris accepted D110141: Fixed relative address in LNT profile control-flow graph..

Thanks! looks good to me but @thopre do you know what's up with the CI?

Sep 21 2021, 4:36 AM · Restricted Project
tnfchris requested changes to D110141: Fixed relative address in LNT profile control-flow graph..
Sep 21 2021, 3:14 AM · Restricted Project

Sep 3 2021

tnfchris accepted D109226: Update pyyaml to fix build failure with Python 3.9.

Yes, thanks both!

Sep 3 2021, 7:34 AM
tnfchris accepted D109226: Update pyyaml to fix build failure with Python 3.9.

Hmm the last time I upgraded pyyaml it started complaining about the interface we're using being insecure and a security issue. is that no longer the case?

I remember it required slight tweaking.

I didn't get any warning, except for pip complaining about being run as root but that's a separate issue

Sep 3 2021, 4:53 AM
tnfchris added a comment to D109226: Update pyyaml to fix build failure with Python 3.9.

Hmm the last time I upgraded pyyaml it started complaining about the interface we're using being insecure and a security issue. is that no longer the case?

Sep 3 2021, 4:34 AM
tnfchris added a comment to D69056: [LNT] Remove Python2 support.

Thanks! this looks complete now.

I guess the only question is, should we bump up the version number? to make a clear line in the sand? otherwise it's hard to tell people which version supports python 2 (in case they need to run an older one for whatever reason)? or more importantly, tell which one is python 3.

Good point. We are currently in 0.4.2dev0 so perhaps we should tag a 0.4.2 first and then pass to 0.4.3dev0?

Sep 3 2021, 3:54 AM · Restricted Project
tnfchris added a comment to D69056: [LNT] Remove Python2 support.

Thanks! this looks complete now.

Sep 3 2021, 3:36 AM · Restricted Project
tnfchris added a comment to D69056: [LNT] Remove Python2 support.

Ohh it's happening!

This looks good but you've missed the cPerf stuff, https://github.com/llvm/llvm-lnt/blob/f48d431f44610e339d00a33d57564c6029c4ff43/lnt/testing/profile/cPerf.cpp#L827 and lnt/testing/profile/__init__.py

What's Python2 specific in lnt/testing/profile/__init__.py?

The futures import at the top https://github.com/llvm/llvm-lnt/blob/f48d431f44610e339d00a33d57564c6029c4ff43/lnt/testing/profile/__init__.py#L4

It's already there: https://reviews.llvm.org/D69056#change-H7ZXp1LFQQlR

Sep 3 2021, 3:30 AM · Restricted Project
tnfchris added a comment to D69056: [LNT] Remove Python2 support.

Ohh it's happening!

This looks good but you've missed the cPerf stuff, https://github.com/llvm/llvm-lnt/blob/f48d431f44610e339d00a33d57564c6029c4ff43/lnt/testing/profile/cPerf.cpp#L827 and lnt/testing/profile/__init__.py

What's Python2 specific in lnt/testing/profile/__init__.py?

Sep 3 2021, 3:23 AM · Restricted Project
tnfchris added a comment to D69056: [LNT] Remove Python2 support.

Ohh it's happening!

Sep 3 2021, 3:10 AM · Restricted Project

May 20 2021

tnfchris committed rG68d5235cb58f: libsanitizer: Remove cyclades inclusion in sanitizer (authored by tnfchris).
libsanitizer: Remove cyclades inclusion in sanitizer
May 20 2021, 10:57 AM
tnfchris closed D102059: libsanitizer: Guard cyclades inclusion in sanitizer.
May 20 2021, 10:56 AM · Restricted Project
tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

The test HWAddressSanitizer-aarch64 :: TestCases/stack-uar-dynamic.c fails already at commit a647100b4320923b0e9d156cc3872b3be470ad98 which is before mine.
As such can't be caused by mine, I'll re-commit the patch.

May 20 2021, 10:53 AM · Restricted Project
tnfchris reopened D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Buildbot has shown a test failure in hwasan with reverting this. Investigating.

May 20 2021, 6:46 AM · Restricted Project
tnfchris added a reverting change for D102059: libsanitizer: Guard cyclades inclusion in sanitizer: rG0d3619864c6f: Revert "libsanitizer: Guard cyclades inclusion in sanitizer".
May 20 2021, 6:44 AM · Restricted Project
tnfchris added a reverting change for rGf7c535155238: libsanitizer: Guard cyclades inclusion in sanitizer: rG0d3619864c6f: Revert "libsanitizer: Guard cyclades inclusion in sanitizer".
May 20 2021, 6:44 AM
tnfchris committed rG0d3619864c6f: Revert "libsanitizer: Guard cyclades inclusion in sanitizer" (authored by tnfchris).
Revert "libsanitizer: Guard cyclades inclusion in sanitizer"
May 20 2021, 6:44 AM
tnfchris committed rGf7c535155238: libsanitizer: Guard cyclades inclusion in sanitizer (authored by tnfchris).
libsanitizer: Guard cyclades inclusion in sanitizer
May 20 2021, 3:07 AM
tnfchris closed D102059: libsanitizer: Guard cyclades inclusion in sanitizer.
May 20 2021, 3:07 AM · Restricted Project
tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Ah I forgot the context.. Thanks @eugenis !

May 20 2021, 2:47 AM · Restricted Project

May 19 2021

tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Ping. Sorry for the early ping, but would be good to get bootstrap working again.

May 19 2021, 1:30 AM · Restricted Project

May 14 2021

tnfchris updated the diff for D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

reverted to diff that removed

May 14 2021, 3:54 AM · Restricted Project

May 13 2021

tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

@MaskRay was that a you prefer it that way or?

May 13 2021, 8:57 AM · Restricted Project

May 10 2021

tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

The Linux kernel has removed the interface to cyclades from the latest kernel headers[1] due to them being orphaned for the past 13 years.

libsanitizer uses this header when compiling against glibc, but glibcs itself doesn't seem to have any references to cyclades.

Sounds like cyclades interceptors should just be deleted?

May 10 2021, 11:44 PM · Restricted Project
tnfchris updated the diff for D102059: libsanitizer: Guard cyclades inclusion in sanitizer.
May 10 2021, 4:26 AM · Restricted Project
tnfchris added reviewers for D102059: libsanitizer: Guard cyclades inclusion in sanitizer: MaskRay, kcc, vitalybuka, eugenis.
May 10 2021, 3:50 AM · Restricted Project
tnfchris updated the diff for D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Update diff

May 10 2021, 3:48 AM · Restricted Project

May 7 2021

tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Alternative to this would be

#ifdef __has_include
# if __has_include(<linux/cyclades.h>)
#  include <linux/cyclades.h>
#  define SANITIZER_LINUX_CYCLADES 1
# endif
#endif
May 7 2021, 2:59 AM · Restricted Project
tnfchris requested review of D102059: libsanitizer: Guard cyclades inclusion in sanitizer.
May 7 2021, 2:36 AM · Restricted Project

Mar 31 2021

tnfchris added a comment to D96004: [AArch64] Stack probing for function prologues.

For GCC this is guard-page - 1k. The reasoning is that with any outgoing argument larger than 1k we would probe such that we maintain the invariant, but probing that 1k means we have a whole guard-size -1k left that we can use without probing. These sizes were chose as they cover about 99% of all programs (for a subset of all :)).

Mar 31 2021, 1:43 AM · Restricted Project

Mar 16 2021

tnfchris added a comment to D96004: [AArch64] Stack probing for function prologues.

I don't know enough about LLVM to comment on the actual code so I will only comment on the output I see generated from the testcases.

Mar 16 2021, 4:29 AM · Restricted Project

Jan 16 2021

tnfchris accepted D94837: Fix use of undefined session variable.

Aha thanks for the explanation

Jan 16 2021, 11:20 AM
tnfchris added a comment to D94837: Fix use of undefined session variable.

This commit adds the parameter and update call sites
accordingly, fixing one of Flake8's F821 warning (undefined name).

Jan 16 2021, 10:06 AM
tnfchris accepted D94840: Add import needed for typing hints.

was it being indirectly imported before?

Jan 16 2021, 5:29 AM
tnfchris accepted D94841: Fix line too long Flake8 warning.
Jan 16 2021, 5:28 AM
tnfchris accepted D94842: Extend mandatory Flake8 cleanness.

good job!

Jan 16 2021, 5:27 AM
tnfchris accepted D94839: Fix OrderField's copy constructor.
Jan 16 2021, 5:26 AM
tnfchris accepted D94838: Remove nonsensical fct definition.
Jan 16 2021, 5:25 AM

Jan 15 2021

tnfchris accepted D94791: Fix remaining Flake8 whitespace issues.

This seems rather random compared with D94789... so the spacing rule isn't consistent for assignments?

I'm not too familiar with the rules but I fail to see the inconsistency since this change does not modify any space around assignment, only spaces before parenthesis.

Jan 15 2021, 9:34 AM
tnfchris added inline comments to D94799: Fix ambiguous variable names.
Jan 15 2021, 9:33 AM
tnfchris accepted D94799: Fix ambiguous variable names.
Jan 15 2021, 9:27 AM
tnfchris accepted D94797: Fix bracket indentation in report.py.
Jan 15 2021, 9:17 AM
tnfchris accepted D94794: Fix over indentation.
Jan 15 2021, 9:17 AM
tnfchris accepted D94793: Fix redundant backslash.
Jan 15 2021, 9:16 AM
tnfchris accepted D94792: Fix blank line errors.
Jan 15 2021, 9:16 AM
tnfchris added a comment to D94791: Fix remaining Flake8 whitespace issues.

This seems rather random compared with D94789... so the spacing rule isn't consistent for assignments?

Jan 15 2021, 9:12 AM
tnfchris accepted D94790: Fix space before typing comments.
Jan 15 2021, 9:11 AM
tnfchris accepted D94789: Fix unexpected space around keyword/param equals.

LGTM

Jan 15 2021, 9:10 AM
tnfchris accepted D94757: F841: local variable assigned to but never used.

Nice cleanup!

Jan 15 2021, 8:12 AM

Jan 14 2021

tnfchris accepted D94715: Expect LNT to be installed in the tests.

I agree, this makes more sense so we don't break cPerf again.

Jan 14 2021, 1:08 PM

Dec 13 2020

tnfchris closed D93117: LNT: Fix Perf profiling support.
Dec 13 2020, 6:19 AM · Restricted Project
tnfchris closed D93114: LNT: fix broken relative redirect.
Dec 13 2020, 6:19 AM · Restricted Project
tnfchris closed D93115: LNT: Sort testsuites ascendingly.
Dec 13 2020, 6:19 AM · Restricted Project
tnfchris closed D93116: LNT: Use relative URLs for Javascript-based URLs..
Dec 13 2020, 6:18 AM · Restricted Project
tnfchris closed D93112: LNT: Fix large Mann-Whitney U Test..
Dec 13 2020, 6:18 AM · Restricted Project
tnfchris closed D93111: LNT: Fix baseline lookup in run view..
Dec 13 2020, 6:17 AM · Restricted Project

Dec 11 2020

tnfchris updated the diff for D93117: LNT: Fix Perf profiling support.
Dec 11 2020, 9:03 AM · Restricted Project
tnfchris updated the diff for D93114: LNT: fix broken relative redirect.
Dec 11 2020, 9:02 AM · Restricted Project
tnfchris updated the diff for D93117: LNT: Fix Perf profiling support.

use package relative import syntax

Dec 11 2020, 8:33 AM · Restricted Project
tnfchris updated the diff for D93114: LNT: fix broken relative redirect.

Updated comment

Dec 11 2020, 8:32 AM · Restricted Project
tnfchris added inline comments to D93117: LNT: Fix Perf profiling support.
Dec 11 2020, 8:24 AM · Restricted Project
tnfchris updated the summary of D93114: LNT: fix broken relative redirect.
Dec 11 2020, 8:14 AM · Restricted Project
tnfchris updated the summary of D93114: LNT: fix broken relative redirect.
Dec 11 2020, 8:05 AM · Restricted Project
tnfchris added inline comments to D93115: LNT: Sort testsuites ascendingly.
Dec 11 2020, 7:08 AM · Restricted Project
tnfchris added inline comments to D93117: LNT: Fix Perf profiling support.
Dec 11 2020, 6:48 AM · Restricted Project
tnfchris added inline comments to D93115: LNT: Sort testsuites ascendingly.
Dec 11 2020, 6:45 AM · Restricted Project
tnfchris updated the summary of D93114: LNT: fix broken relative redirect.
Dec 11 2020, 6:41 AM · Restricted Project
tnfchris requested review of D93117: LNT: Fix Perf profiling support.
Dec 11 2020, 6:02 AM · Restricted Project
tnfchris requested review of D93116: LNT: Use relative URLs for Javascript-based URLs..
Dec 11 2020, 6:00 AM · Restricted Project
tnfchris requested review of D93115: LNT: Sort testsuites ascendingly.
Dec 11 2020, 5:59 AM · Restricted Project
tnfchris requested review of D93114: LNT: fix broken relative redirect.
Dec 11 2020, 5:58 AM · Restricted Project
tnfchris requested review of D93112: LNT: Fix large Mann-Whitney U Test..
Dec 11 2020, 5:57 AM · Restricted Project
tnfchris requested review of D93111: LNT: Fix baseline lookup in run view..
Dec 11 2020, 5:56 AM · Restricted Project
tnfchris closed D89377: [LNT] Pin Python version in Dockerfile to 3.7 temporarily.

was landed in 60343998f7907b77e24f01c94c48ea6c753eca7e

Dec 11 2020, 5:48 AM · Restricted Project

Oct 14 2020

tnfchris requested review of D89377: [LNT] Pin Python version in Dockerfile to 3.7 temporarily.
Oct 14 2020, 2:27 AM · Restricted Project

Aug 6 2020

tnfchris requested review of D85425: Generate relative URLs instead of absolute urls for weburls..
Aug 6 2020, 5:04 AM
tnfchris requested review of D85422: Prevent page crash when using default comparer on Global Status page.
Aug 6 2020, 4:02 AM

Oct 17 2019

tnfchris updated the diff for D69104: [Arm][libsanitizer] Fix arm libsanitizer failure with bleeding edge glibc.

Add more context, to diff.

Oct 17 2019, 5:44 AM · Restricted Project, Restricted Project