Page MenuHomePhabricator

tnfchris (Tamar Christina)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2019, 4:54 AM (87 w, 17 h)

Compiler Engineer at Arm Holdings

Recent Activity

Thu, May 20

tnfchris committed rG68d5235cb58f: libsanitizer: Remove cyclades inclusion in sanitizer (authored by tnfchris).
libsanitizer: Remove cyclades inclusion in sanitizer
Thu, May 20, 10:57 AM
tnfchris closed D102059: libsanitizer: Guard cyclades inclusion in sanitizer.
Thu, May 20, 10:56 AM · Restricted Project
tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

The test HWAddressSanitizer-aarch64 :: TestCases/stack-uar-dynamic.c fails already at commit a647100b4320923b0e9d156cc3872b3be470ad98 which is before mine.
As such can't be caused by mine, I'll re-commit the patch.

Thu, May 20, 10:53 AM · Restricted Project
tnfchris reopened D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Buildbot has shown a test failure in hwasan with reverting this. Investigating.

Thu, May 20, 6:46 AM · Restricted Project
tnfchris added a reverting change for D102059: libsanitizer: Guard cyclades inclusion in sanitizer: rG0d3619864c6f: Revert "libsanitizer: Guard cyclades inclusion in sanitizer".
Thu, May 20, 6:44 AM · Restricted Project
tnfchris added a reverting change for rGf7c535155238: libsanitizer: Guard cyclades inclusion in sanitizer: rG0d3619864c6f: Revert "libsanitizer: Guard cyclades inclusion in sanitizer".
Thu, May 20, 6:44 AM
tnfchris committed rG0d3619864c6f: Revert "libsanitizer: Guard cyclades inclusion in sanitizer" (authored by tnfchris).
Revert "libsanitizer: Guard cyclades inclusion in sanitizer"
Thu, May 20, 6:44 AM
tnfchris committed rGf7c535155238: libsanitizer: Guard cyclades inclusion in sanitizer (authored by tnfchris).
libsanitizer: Guard cyclades inclusion in sanitizer
Thu, May 20, 3:07 AM
tnfchris closed D102059: libsanitizer: Guard cyclades inclusion in sanitizer.
Thu, May 20, 3:07 AM · Restricted Project
tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Ah I forgot the context.. Thanks @eugenis !

Thu, May 20, 2:47 AM · Restricted Project

Wed, May 19

tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Ping. Sorry for the early ping, but would be good to get bootstrap working again.

Wed, May 19, 1:30 AM · Restricted Project

May 14 2021

tnfchris updated the diff for D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

reverted to diff that removed

May 14 2021, 3:54 AM · Restricted Project

May 13 2021

tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

@MaskRay was that a you prefer it that way or?

May 13 2021, 8:57 AM · Restricted Project

May 10 2021

tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

The Linux kernel has removed the interface to cyclades from the latest kernel headers[1] due to them being orphaned for the past 13 years.

libsanitizer uses this header when compiling against glibc, but glibcs itself doesn't seem to have any references to cyclades.

Sounds like cyclades interceptors should just be deleted?

May 10 2021, 11:44 PM · Restricted Project
tnfchris updated the diff for D102059: libsanitizer: Guard cyclades inclusion in sanitizer.
May 10 2021, 4:26 AM · Restricted Project
tnfchris added reviewers for D102059: libsanitizer: Guard cyclades inclusion in sanitizer: MaskRay, kcc, vitalybuka, eugenis.
May 10 2021, 3:50 AM · Restricted Project
tnfchris updated the diff for D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Update diff

May 10 2021, 3:48 AM · Restricted Project

May 7 2021

tnfchris added a comment to D102059: libsanitizer: Guard cyclades inclusion in sanitizer.

Alternative to this would be

#ifdef __has_include
# if __has_include(<linux/cyclades.h>)
#  include <linux/cyclades.h>
#  define SANITIZER_LINUX_CYCLADES 1
# endif
#endif
May 7 2021, 2:59 AM · Restricted Project
tnfchris requested review of D102059: libsanitizer: Guard cyclades inclusion in sanitizer.
May 7 2021, 2:36 AM · Restricted Project

Mar 31 2021

tnfchris added a comment to D96004: [AArch64] Stack probing for function prologues.

For GCC this is guard-page - 1k. The reasoning is that with any outgoing argument larger than 1k we would probe such that we maintain the invariant, but probing that 1k means we have a whole guard-size -1k left that we can use without probing. These sizes were chose as they cover about 99% of all programs (for a subset of all :)).

Mar 31 2021, 1:43 AM · Restricted Project

Mar 16 2021

tnfchris added a comment to D96004: [AArch64] Stack probing for function prologues.

I don't know enough about LLVM to comment on the actual code so I will only comment on the output I see generated from the testcases.

Mar 16 2021, 4:29 AM · Restricted Project

Jan 16 2021

tnfchris accepted D94837: Fix use of undefined session variable.

Aha thanks for the explanation

Jan 16 2021, 11:20 AM
tnfchris added a comment to D94837: Fix use of undefined session variable.

This commit adds the parameter and update call sites
accordingly, fixing one of Flake8's F821 warning (undefined name).

Jan 16 2021, 10:06 AM
tnfchris accepted D94840: Add import needed for typing hints.

was it being indirectly imported before?

Jan 16 2021, 5:29 AM
tnfchris accepted D94841: Fix line too long Flake8 warning.
Jan 16 2021, 5:28 AM
tnfchris accepted D94842: Extend mandatory Flake8 cleanness.

good job!

Jan 16 2021, 5:27 AM
tnfchris accepted D94839: Fix OrderField's copy constructor.
Jan 16 2021, 5:26 AM
tnfchris accepted D94838: Remove nonsensical fct definition.
Jan 16 2021, 5:25 AM

Jan 15 2021

tnfchris accepted D94791: Fix remaining Flake8 whitespace issues.

This seems rather random compared with D94789... so the spacing rule isn't consistent for assignments?

I'm not too familiar with the rules but I fail to see the inconsistency since this change does not modify any space around assignment, only spaces before parenthesis.

Jan 15 2021, 9:34 AM
tnfchris added inline comments to D94799: Fix ambiguous variable names.
Jan 15 2021, 9:33 AM
tnfchris accepted D94799: Fix ambiguous variable names.
Jan 15 2021, 9:27 AM
tnfchris accepted D94797: Fix bracket indentation in report.py.
Jan 15 2021, 9:17 AM
tnfchris accepted D94794: Fix over indentation.
Jan 15 2021, 9:17 AM
tnfchris accepted D94793: Fix redundant backslash.
Jan 15 2021, 9:16 AM
tnfchris accepted D94792: Fix blank line errors.
Jan 15 2021, 9:16 AM
tnfchris added a comment to D94791: Fix remaining Flake8 whitespace issues.

This seems rather random compared with D94789... so the spacing rule isn't consistent for assignments?

Jan 15 2021, 9:12 AM
tnfchris accepted D94790: Fix space before typing comments.
Jan 15 2021, 9:11 AM
tnfchris accepted D94789: Fix unexpected space around keyword/param equals.

LGTM

Jan 15 2021, 9:10 AM
tnfchris accepted D94757: F841: local variable assigned to but never used.

Nice cleanup!

Jan 15 2021, 8:12 AM

Jan 14 2021

tnfchris accepted D94715: Expect LNT to be installed in the tests.

I agree, this makes more sense so we don't break cPerf again.

Jan 14 2021, 1:08 PM

Dec 13 2020

tnfchris closed D93117: LNT: Fix Perf profiling support.
Dec 13 2020, 6:19 AM · Restricted Project
tnfchris closed D93114: LNT: fix broken relative redirect.
Dec 13 2020, 6:19 AM · Restricted Project
tnfchris closed D93115: LNT: Sort testsuites ascendingly.
Dec 13 2020, 6:19 AM · Restricted Project
tnfchris closed D93116: LNT: Use relative URLs for Javascript-based URLs..
Dec 13 2020, 6:18 AM · Restricted Project
tnfchris closed D93112: LNT: Fix large Mann-Whitney U Test..
Dec 13 2020, 6:18 AM · Restricted Project
tnfchris closed D93111: LNT: Fix baseline lookup in run view..
Dec 13 2020, 6:17 AM · Restricted Project

Dec 11 2020

tnfchris updated the diff for D93117: LNT: Fix Perf profiling support.
Dec 11 2020, 9:03 AM · Restricted Project
tnfchris updated the diff for D93114: LNT: fix broken relative redirect.
Dec 11 2020, 9:02 AM · Restricted Project
tnfchris updated the diff for D93117: LNT: Fix Perf profiling support.

use package relative import syntax

Dec 11 2020, 8:33 AM · Restricted Project
tnfchris updated the diff for D93114: LNT: fix broken relative redirect.

Updated comment

Dec 11 2020, 8:32 AM · Restricted Project
tnfchris added inline comments to D93117: LNT: Fix Perf profiling support.
Dec 11 2020, 8:24 AM · Restricted Project
tnfchris updated the summary of D93114: LNT: fix broken relative redirect.
Dec 11 2020, 8:14 AM · Restricted Project
tnfchris updated the summary of D93114: LNT: fix broken relative redirect.
Dec 11 2020, 8:05 AM · Restricted Project
tnfchris added inline comments to D93115: LNT: Sort testsuites ascendingly.
Dec 11 2020, 7:08 AM · Restricted Project
tnfchris added inline comments to D93117: LNT: Fix Perf profiling support.
Dec 11 2020, 6:48 AM · Restricted Project
tnfchris added inline comments to D93115: LNT: Sort testsuites ascendingly.
Dec 11 2020, 6:45 AM · Restricted Project
tnfchris updated the summary of D93114: LNT: fix broken relative redirect.
Dec 11 2020, 6:41 AM · Restricted Project
tnfchris requested review of D93117: LNT: Fix Perf profiling support.
Dec 11 2020, 6:02 AM · Restricted Project
tnfchris requested review of D93116: LNT: Use relative URLs for Javascript-based URLs..
Dec 11 2020, 6:00 AM · Restricted Project
tnfchris requested review of D93115: LNT: Sort testsuites ascendingly.
Dec 11 2020, 5:59 AM · Restricted Project
tnfchris requested review of D93114: LNT: fix broken relative redirect.
Dec 11 2020, 5:58 AM · Restricted Project
tnfchris requested review of D93112: LNT: Fix large Mann-Whitney U Test..
Dec 11 2020, 5:57 AM · Restricted Project
tnfchris requested review of D93111: LNT: Fix baseline lookup in run view..
Dec 11 2020, 5:56 AM · Restricted Project
tnfchris closed D89377: [LNT] Pin Python version in Dockerfile to 3.7 temporarily.

was landed in 60343998f7907b77e24f01c94c48ea6c753eca7e

Dec 11 2020, 5:48 AM · Restricted Project

Oct 14 2020

tnfchris requested review of D89377: [LNT] Pin Python version in Dockerfile to 3.7 temporarily.
Oct 14 2020, 2:27 AM · Restricted Project

Aug 6 2020

tnfchris requested review of D85425: Generate relative URLs instead of absolute urls for weburls..
Aug 6 2020, 5:04 AM
tnfchris requested review of D85422: Prevent page crash when using default comparer on Global Status page.
Aug 6 2020, 4:02 AM

Oct 17 2019

tnfchris updated the diff for D69104: [Arm][libsanitizer] Fix arm libsanitizer failure with bleeding edge glibc.

Add more context, to diff.

Oct 17 2019, 5:44 AM · Restricted Project, Restricted Project
tnfchris created D69104: [Arm][libsanitizer] Fix arm libsanitizer failure with bleeding edge glibc.
Oct 17 2019, 5:07 AM · Restricted Project, Restricted Project