This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Define vsub/vrsub intrinsics and refine the multiclass/class.
AbandonedPublic

Authored by HsiangKai on Dec 10 2020, 9:04 AM.

Details

Summary

Define vsub/vrsub intrinsics and demonstrate the organization of multiclasses and classes for pseudo instructions and patterns.

The CodeGen strategy is designed by @rogfer01 from BSC.

Diff Detail

Event Timeline

HsiangKai created this revision.Dec 10 2020, 9:04 AM
HsiangKai requested review of this revision.Dec 10 2020, 9:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2020, 9:04 AM
Herald added a subscriber: MaskRay. · View Herald Transcript

Should I combine this one with D93048?

vsub only has .vv and .vx variants.
vrsub only has .vx and .vi variants.

I use these two instructions to reorganize multiclasses and classes in RISCVInstrInfoVPseudos.td.

These two patches are related. I am not sure whether I should combine them or not.

HsiangKai edited the summary of this revision. (Show Details)Dec 10 2020, 9:12 AM

Should I combine this one with D93048?

vsub only has .vv and .vx variants.
vrsub only has .vx and .vi variants.

I use these two instructions to reorganize multiclasses and classes in RISCVInstrInfoVPseudos.td.

These two patches are related. I am not sure whether I should combine them or not.

I vote to combine them since this redoes a lot of the tablegen classes. It would be better to only have one version to review

HsiangKai abandoned this revision.Dec 10 2020, 5:37 PM

Combined into D93013.