Explicitly opt-out llvm/test/Transforms/Attributor.
Verified by flipping the default value of allow-unused-prefixes and
observing that none of the failures were under llvm/test/Transforms.
Paths
| Differential D92404
[FileCheck] Enforce --allow-unused-prefixes=false for llvm/test/Transforms ClosedPublic Authored by mtrofin on Dec 1 2020, 10:02 AM.
Details Summary Explicitly opt-out llvm/test/Transforms/Attributor. Verified by flipping the default value of allow-unused-prefixes and
Diff Detail
Event Timeline
mtrofin marked an inline comment as done. mtrofin added inline comments.
Comment Actions Glad to see you are using the script. I'm not very sure its behavior. Please pay attention to its changes especially marked CHANGE
Comment Actions
Yup, the tool is super-useful, thanks again! Comment Actions
Comment Actions Cheers~
mtrofin marked an inline comment as done. Comment Actionsseparated change to update_test_prefix.py in D92542 Comment Actions I don't know anything about the Transform tests, so I don't feel qualified to further review whether what has been done is valid. Hopefully somebody else will be able to review. Comment Actions IMO this whole direction is wrong, but i'll guess i'll just have to suffer with new reality. Comment Actions
Not sure what direction you're referring to - if it's about handing unused prefixes, could you please contribute to the RFC thread (http://lists.llvm.org/pipermail/llvm-dev/2020-October/146162.html), it would be helpful to understand what tradeoffs we may have missed. Thanks! Comment Actions
Yep, precisely that direction.
I have not kept track of that RFC so i'm not sure if i'm just being picky because i'm not aware of a very good reasons pointed out there. Comment Actions
OK. Any pushback re. this patch? Thanks! Comment Actions Gentle reminder - @jdoerfert , is blank-allowing all the Transforms/Attributor to have unused prefixes "as intended"? (I remember you indicating that was the case) I intend to commit this on Wednesday, it's basically NFC. Thanks! Comment Actions
Yeah that's the case. This revision was landed with ongoing or failed builds. Closed by commit rGf9a27df16bc4: [FileCheck] Enforce --allow-unused-prefixes=false for llvm/test/Transforms (authored by mtrofin). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 308697 llvm/test/Transforms/ArgumentPromotion/crash.ll
llvm/test/Transforms/Attributor/lit.local.cfg
llvm/test/Transforms/HardwareLoops/scalar-while.ll
llvm/test/Transforms/Inline/inline_stats.ll
llvm/test/Transforms/Inline/noalias2.ll
llvm/test/Transforms/LICM/pr23608.ll
llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/merge-stores-private.ll
llvm/test/Transforms/LoopIdiom/X86/left-shift-until-bittest.ll
llvm/test/Transforms/LoopStrengthReduce/X86/lsr-insns-1.ll
llvm/test/Transforms/LowerTypeTests/export-inline.ll
llvm/test/Transforms/PhaseOrdering/ARM/arm_fill_q7.ll
llvm/test/Transforms/PhaseOrdering/X86/loop-idiom-vs-indvars.ll
llvm/test/Transforms/lit.local.cfg
llvm/test/lit.cfg.py
|
ALL%s? This doesn't look right to me...