Page MenuHomePhabricator
People kuter

kuter (Kuter Dinel)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2020, 1:46 PM (159 w, 5 d)

Recent Activity
View All

Jan 31 2022

kuter accepted D118669: [Attributor] Introduce the concept of query AAs.

LGTM

Jan 31 2022, 10:47 PM · Restricted Project
kuter accepted D118673: [Attributor] Introduce the `AA::isPotentiallyReachable` helper APIs.

LGTM

Jan 31 2022, 9:20 PM · Restricted Project
kuter added inline comments to D118673: [Attributor] Introduce the `AA::isPotentiallyReachable` helper APIs.
Jan 31 2022, 7:27 PM · Restricted Project
kuter added inline comments to D118673: [Attributor] Introduce the `AA::isPotentiallyReachable` helper APIs.
Jan 31 2022, 7:23 PM · Restricted Project
kuter added inline comments to D118669: [Attributor] Introduce the concept of query AAs.
Jan 31 2022, 5:57 PM · Restricted Project
kuter added inline comments to D118669: [Attributor] Introduce the concept of query AAs.
Jan 31 2022, 5:33 PM · Restricted Project

Sep 19 2021

kuter accepted D109662: [Attributor] Ensure store uses are correlated with reloads.

LGTM.

Sep 19 2021, 9:52 AM · Restricted Project

Sep 14 2021

kuter updated the diff for D106720: [Attributor] AAFunctionReachability, Instruction reachability..

Address review.

Sep 14 2021, 7:30 PM · Restricted Project
kuter updated the diff for D106720: [Attributor] AAFunctionReachability, Instruction reachability..

Address review.

Sep 14 2021, 2:42 PM · Restricted Project

Sep 12 2021

kuter committed rG9a193bdc81e1: [Attributor][FIX] AACallEdges, fix propagation error. (authored by kuter).
[Attributor][FIX] AACallEdges, fix propagation error.
Sep 12 2021, 5:46 PM
kuter committed rG66a0b3464ca8: [Attributor] AAFunctionReachability, Handle CallBase Reachability. (authored by kuter).
[Attributor] AAFunctionReachability, Handle CallBase Reachability.
Sep 12 2021, 3:36 PM
kuter closed D106402: [Attributor] AAFunctionReachability, Handle CallBase Reachability..
Sep 12 2021, 3:36 PM · Restricted Project
kuter committed rG2cc6f7c8e108: [Attributor] Create a call site position for AACalledges (authored by kuter).
[Attributor] Create a call site position for AACalledges
Sep 12 2021, 3:17 PM
kuter closed D106208: [Attributor] Create a call site position for AACalledges.
Sep 12 2021, 3:17 PM · Restricted Project
kuter accepted D109170: [Attributor] Look through allocated heap memory.

LGTM

Sep 12 2021, 2:16 PM · Restricted Project

Sep 11 2021

kuter updated the diff for D106402: [Attributor] AAFunctionReachability, Handle CallBase Reachability..

Use recordDependence

Sep 11 2021, 4:04 PM · Restricted Project
kuter updated the diff for D106402: [Attributor] AAFunctionReachability, Handle CallBase Reachability..

address review.

Sep 11 2021, 3:57 PM · Restricted Project
kuter updated the diff for D106402: [Attributor] AAFunctionReachability, Handle CallBase Reachability..
  • Use early increment iterator range rather than hacky code.
  • Fix the infinite loop issue.
  • Negative test case.
Sep 11 2021, 1:54 PM · Restricted Project
kuter added inline comments to D106720: [Attributor] AAFunctionReachability, Instruction reachability..
Sep 11 2021, 11:36 AM · Restricted Project

Sep 9 2021

kuter accepted D109552: AMDGPU: Rename attributor class for uniform-work-group-size.

LGTM.

Sep 9 2021, 5:29 PM · Restricted Project

Sep 7 2021

kuter added a comment to D109170: [Attributor] Look through allocated heap memory.

Note: Some tests seem broken (heap_to_stack.ll) and clang format is needed.

Sep 7 2021, 8:47 PM · Restricted Project

Aug 30 2021

kuter updated the diff for D108008: [WIP][Attributor] AAHotCold Use CFG to propagate hot cold..

Rebase

Aug 30 2021, 4:22 PM · Restricted Project

Aug 26 2021

kuter updated the diff for D107705: [Attributor] AAHotCold propagate to call sites in the same block..

Rebase (use the bitstate)

Aug 26 2021, 3:24 PM · Restricted Project

Aug 23 2021

kuter added inline comments to D106720: [Attributor] AAFunctionReachability, Instruction reachability..
Aug 23 2021, 8:42 PM · Restricted Project

Aug 22 2021

kuter retitled D106720: [Attributor] AAFunctionReachability, Instruction reachability. from [WIP][Attributor] AAFunctionReachability, Instruction reachability. to [Attributor] AAFunctionReachability, Instruction reachability..
Aug 22 2021, 4:28 PM · Restricted Project
kuter abandoned D86647: [Attributor] Add missing operators for ChangeStatus.

This feature was added by another patch.

Aug 22 2021, 4:01 PM · Restricted Project

Aug 19 2021

kuter updated the diff for D107409: [Attributor] Propagate Cold attribute inter procedurally.

Use a BitState instead of hacky Option<bool>
I will rebase the rest of the patch set.

Aug 19 2021, 9:51 PM · Restricted Project
kuter added inline comments to D107409: [Attributor] Propagate Cold attribute inter procedurally.
Aug 19 2021, 1:47 PM · Restricted Project
kuter updated the diff for D107705: [Attributor] AAHotCold propagate to call sites in the same block..

imlpement 'trackStatistics()` function for Function position.

Aug 19 2021, 1:32 PM · Restricted Project

Aug 18 2021

kuter updated the diff for D108008: [WIP][Attributor] AAHotCold Use CFG to propagate hot cold..

rebase, fix tests, change propagation technique.
I will add a test.

Aug 18 2021, 5:43 PM · Restricted Project
kuter updated the diff for D107705: [Attributor] AAHotCold propagate to call sites in the same block..

Fix wrapper.ll test.

Aug 18 2021, 5:37 PM · Restricted Project
kuter updated the diff for D107705: [Attributor] AAHotCold propagate to call sites in the same block..

Rebase, fix tests.

Aug 18 2021, 5:31 PM · Restricted Project
kuter updated the diff for D107409: [Attributor] Propagate Cold attribute inter procedurally.

Fix the depgraph.ll

Aug 18 2021, 5:26 PM · Restricted Project

Aug 17 2021

kuter accepted D108140: [Attributor][FIX] Do not treat byval args as local memory (for now).

LGTM

Aug 17 2021, 12:11 PM · Restricted Project
kuter accepted D108190: [Attributor][FIX] Recursion via memory needs to be tracked explicitly.

LGTM

Aug 17 2021, 11:59 AM · Restricted Project
kuter accepted D107974: AMDGPU: Remove hacky attribute deduction from AMDGPUAttributor.

LGTM

Aug 17 2021, 11:56 AM · Restricted Project

Aug 16 2021

kuter requested review of D108170: [Attributor][FIX] AAPointerInfo fix uninitialized usage..
Aug 16 2021, 4:31 PM · Restricted Project
kuter added inline comments to D108158: AMDGPU: Invert AMDGPUAttributor.
Aug 16 2021, 2:35 PM · Restricted Project
kuter added a comment to D108158: AMDGPU: Invert AMDGPUAttributor.

I think it makes sense to reverse the attributes.

Aug 16 2021, 2:28 PM · Restricted Project

Aug 15 2021

kuter added a comment to D108099: [WIP][Attributor] Run Attributor in stages..

With the patch:

$ time opt -attributor test-suite/CTMark/sqlite3/sqlite3.mem2reg.ll
Aug 15 2021, 9:36 PM · Restricted Project
kuter updated the diff for D108099: [WIP][Attributor] Run Attributor in stages..

Small Change.

Aug 15 2021, 9:28 PM · Restricted Project
kuter requested review of D108099: [WIP][Attributor] Run Attributor in stages..
Aug 15 2021, 7:51 PM · Restricted Project

Aug 12 2021

kuter requested review of D108008: [WIP][Attributor] AAHotCold Use CFG to propagate hot cold..
Aug 12 2021, 8:09 PM · Restricted Project
kuter accepted D107991: AMDGPU: Stop attributor adding attributes to intrinsic declarations.

LGTM. With a nit.

Aug 12 2021, 1:45 PM · Restricted Project

Aug 11 2021

kuter accepted D106397: [Attributor] Use CFG reasoning to filter potentially interfering writes.

LGTM, maybe a test could be great.

Aug 11 2021, 8:06 AM · Restricted Project

Aug 7 2021

kuter requested review of D107705: [Attributor] AAHotCold propagate to call sites in the same block..
Aug 7 2021, 5:46 PM · Restricted Project

Aug 4 2021

kuter updated the diff for D107409: [Attributor] Propagate Cold attribute inter procedurally.

small fix.

Aug 4 2021, 7:05 PM · Restricted Project

Aug 3 2021

kuter requested review of D107409: [Attributor] Propagate Cold attribute inter procedurally.
Aug 3 2021, 4:24 PM · Restricted Project

Jul 28 2021

kuter updated the diff for D106720: [Attributor] AAFunctionReachability, Instruction reachability..
  • Explicitly handle InvokeInst.
  • Add a option to note use backwards reachability.
  • Don't use backwards reachability for transative queries (fixes the fixme)
  • Address misc review.
Jul 28 2021, 3:37 PM · Restricted Project
kuter added a comment to D106931: [Attributor] Change function internalization to not replace uses in internalized callers.

Note: this seems to break some Attributor and AMDGPU Attributor tests. Attributor doesn't internalize by default. Maybe it is breaking that.
But I don't know why.

Jul 28 2021, 1:08 AM · Restricted Project

Jul 27 2021

kuter updated the diff for D106720: [Attributor] AAFunctionReachability, Instruction reachability..

Use the new |= operator for change tracking.

Jul 27 2021, 12:38 AM · Restricted Project
kuter updated the diff for D106402: [Attributor] AAFunctionReachability, Handle CallBase Reachability..

Use the new |= operator for change tracking.

Jul 27 2021, 12:35 AM · Restricted Project

Jul 26 2021

kuter added inline comments to D106720: [Attributor] AAFunctionReachability, Instruction reachability..
Jul 26 2021, 7:32 PM · Restricted Project
kuter accepted D106190: [Attributor] Utilize the InstSimplify interface to simplify instructions.

LGTM

Jul 26 2021, 3:20 PM · Restricted Project

Jul 25 2021

kuter added inline comments to D106397: [Attributor] Use CFG reasoning to filter potentially interfering writes.
Jul 25 2021, 11:54 PM · Restricted Project
kuter added inline comments to D106397: [Attributor] Use CFG reasoning to filter potentially interfering writes.
Jul 25 2021, 11:40 PM · Restricted Project

Jul 23 2021

kuter committed rG96709823ec37: [AMDGPU] Deduce attributes with the Attributor (authored by kuter).
[AMDGPU] Deduce attributes with the Attributor
Jul 23 2021, 8:07 PM
kuter closed D104997: [AMDGPU] Deduce attributes with the Attributor.
Jul 23 2021, 8:07 PM · Restricted Project
kuter committed rG0cd964ff2548: [Attributor][FIX] checkForAllInstructions, correctly handle declarations (authored by kuter).
[Attributor][FIX] checkForAllInstructions, correctly handle declarations
Jul 23 2021, 4:23 PM
kuter closed D106625: [Attributor][FIX] checkForAllInstructions, correctly handle declered functions.
Jul 23 2021, 4:23 PM · Restricted Project
kuter updated the diff for D106720: [Attributor] AAFunctionReachability, Instruction reachability..

Don't ignore the return value of checkForAllCallLikeInstructions

Jul 23 2021, 4:09 PM · Restricted Project
kuter requested review of D106720: [Attributor] AAFunctionReachability, Instruction reachability..
Jul 23 2021, 3:54 PM · Restricted Project

Jul 22 2021

kuter requested review of D106625: [Attributor][FIX] checkForAllInstructions, correctly handle declered functions.
Jul 22 2021, 6:07 PM · Restricted Project

Jul 20 2021

kuter updated the diff for D106402: [Attributor] AAFunctionReachability, Handle CallBase Reachability..

Fix issue with the unittest.
Change tracking issue.

Jul 20 2021, 3:03 PM · Restricted Project
kuter updated the diff for D106402: [Attributor] AAFunctionReachability, Handle CallBase Reachability..

Rmove useless comment.

Jul 20 2021, 2:51 PM · Restricted Project
kuter requested review of D106402: [Attributor] AAFunctionReachability, Handle CallBase Reachability..
Jul 20 2021, 2:48 PM · Restricted Project
kuter accepted D106185: [Attributor] Introduce getPotentialCopiesOfStoredValue and use it.

LGTM

Jul 20 2021, 9:59 AM · Restricted Project

Jul 19 2021

kuter accepted D106188: [Attributor] Delete dead stores.

LGTM.
Maybe we can explain why the bit state is needed.

Jul 19 2021, 4:18 PM · Restricted Project

Jul 16 2021

kuter added inline comments to D104997: [AMDGPU] Deduce attributes with the Attributor.
Jul 16 2021, 8:45 PM · Restricted Project
kuter updated the diff for D106208: [Attributor] Create a call site position for AACalledges.

Small fix with change tracking.

Jul 16 2021, 8:29 PM · Restricted Project
kuter requested review of D106208: [Attributor] Create a call site position for AACalledges.
Jul 16 2021, 6:56 PM · Restricted Project
kuter added inline comments to D106185: [Attributor] Introduce getPotentialCopiesOfStoredValue and use it.
Jul 16 2021, 4:48 PM · Restricted Project
kuter retitled D104997: [AMDGPU] Deduce attributes with the Attributor from [WIP][AMDGPU] Deduce attributes with the Attributor to [AMDGPU] Deduce attributes with the Attributor.
Jul 16 2021, 12:24 PM · Restricted Project
kuter updated the diff for D104997: [AMDGPU] Deduce attributes with the Attributor.

clang-format (sorry that I forgot)
Remove the WIP tag.

Jul 16 2021, 12:24 PM · Restricted Project

Jul 14 2021

kuter updated the diff for D104997: [AMDGPU] Deduce attributes with the Attributor.

Inline assembly call sites are no longer treated as unknown callees.
This fixes some differences in deduction.

Jul 14 2021, 8:41 PM · Restricted Project
kuter committed rGade190c5eabf: [Attributor] AACallEdges, Add a way to ask nonasm unknown callees (authored by kuter).
[Attributor] AACallEdges, Add a way to ask nonasm unknown callees
Jul 14 2021, 8:11 PM
kuter closed D105992: [Attributor] AACallEdges, Add a way to ask nonasm unknown callees.
Jul 14 2021, 8:11 PM · Restricted Project
kuter committed rGa7749c3f79a8: [AMDGPU] Use update_test_checks.py script for annotate kernel features tests. (authored by kuter).
[AMDGPU] Use update_test_checks.py script for annotate kernel features tests.
Jul 14 2021, 5:14 PM
kuter closed D105864: [AMDGPU] Use update_test_checks.py script for annotate kernel features tests..
Jul 14 2021, 5:13 PM · Restricted Project
kuter accepted D104432: [Attributor] Introduce AAPointerInfo.

LGTM as far as I can see. One small nit.

Jul 14 2021, 3:55 PM · Restricted Project, Restricted Project
kuter requested review of D105992: [Attributor] AACallEdges, Add a way to ask nonasm unknown callees.
Jul 14 2021, 8:48 AM · Restricted Project

Jul 13 2021

kuter updated the diff for D104997: [AMDGPU] Deduce attributes with the Attributor.

Small change.

Jul 13 2021, 7:50 PM · Restricted Project
kuter updated the diff for D104997: [AMDGPU] Deduce attributes with the Attributor.

Make the uniform-work-group-size deduction use the BooleanState.
Rebase.

Jul 13 2021, 7:45 PM · Restricted Project
kuter added inline comments to D104432: [Attributor] Introduce AAPointerInfo.
Jul 13 2021, 11:01 AM · Restricted Project, Restricted Project
kuter added inline comments to D104432: [Attributor] Introduce AAPointerInfo.
Jul 13 2021, 10:34 AM · Restricted Project, Restricted Project
kuter updated the diff for D105864: [AMDGPU] Use update_test_checks.py script for annotate kernel features tests..

Sorry I thought that the update script would remove old check lines.
I removed the old lines that where not removed. Tests pass now.

Jul 13 2021, 7:12 AM · Restricted Project

Jul 12 2021

kuter requested review of D105864: [AMDGPU] Use update_test_checks.py script for annotate kernel features tests..
Jul 12 2021, 7:21 PM · Restricted Project
kuter accepted D103862: [Attributor] Simplify loads.

LGTM

Jul 12 2021, 4:30 PM · Restricted Project
kuter updated the diff for D104997: [AMDGPU] Deduce attributes with the Attributor.
  • Added requested test.
  • Removed the check for linkage type
Jul 12 2021, 3:55 AM · Restricted Project

Jul 10 2021

kuter updated the diff for D104997: [AMDGPU] Deduce attributes with the Attributor.
  • Address review.
  • Small naming change.
Jul 10 2021, 3:33 PM · Restricted Project
kuter added inline comments to D104997: [AMDGPU] Deduce attributes with the Attributor.
Jul 10 2021, 3:21 PM · Restricted Project
kuter added inline comments to D104997: [AMDGPU] Deduce attributes with the Attributor.
Jul 10 2021, 3:15 PM · Restricted Project

Jul 9 2021

kuter updated the diff for D104997: [AMDGPU] Deduce attributes with the Attributor.
  • Add support for constant exploration
  • All tests are supported now
  • Bug fix
Jul 9 2021, 2:14 PM · Restricted Project

Jul 7 2021

kuter accepted D103858: [Attributor][FIX] Traverse uses even if a value is assumed constant.

LGTM

Jul 7 2021, 11:17 AM · Restricted Project

Jul 6 2021

kuter accepted D103857: [Attributor] Introduce a helper function to deal with undef + none.

LGTM

Jul 6 2021, 7:25 PM · Restricted Project

Jul 5 2021

kuter added a comment to D103862: [Attributor] Simplify loads.

Only this patch looks broken.
I think applying the D104432 in reverse should work.

Jul 5 2021, 11:53 AM · Restricted Project

Jul 4 2021

kuter added a comment to D103862: [Attributor] Simplify loads.

I think there was a mistake during rebase or we should abandon https://reviews.llvm.org/D104432

Jul 4 2021, 5:43 PM · Restricted Project

Jul 3 2021

kuter updated the diff for D104997: [AMDGPU] Deduce attributes with the Attributor.
  • Support more tests.
  • Fix the problem with existing tests.
  • Simplify logic.
  • Misc changes.
Jul 3 2021, 8:47 PM · Restricted Project
kuter added inline comments to D104997: [AMDGPU] Deduce attributes with the Attributor.
Jul 3 2021, 2:05 PM · Restricted Project

Jun 30 2021

kuter updated the diff for D104997: [AMDGPU] Deduce attributes with the Attributor.
  • Added Uniform Work Group deduction.
  • Addressed review.
Jun 30 2021, 12:20 PM · Restricted Project