Page MenuHomePhabricator

kuter (Kuter Dinel)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2020, 1:46 PM (38 w, 3 d)

Recent Activity

Aug 30 2020

kuter requested review of D86852: [Attributor] Split the runTillFixpoint function..
Aug 30 2020, 1:15 PM · Restricted Project

Aug 27 2020

kuter added inline comments to D86696: [Attributor][WIP] Introduce Loop AA.
Aug 27 2020, 5:34 AM · Restricted Project
kuter added inline comments to D86696: [Attributor][WIP] Introduce Loop AA.
Aug 27 2020, 5:16 AM · Restricted Project
kuter added a comment to D86678: [Attributor] Add a phase flag to Attributor.

Thank you for creating this. I was thinking of something like this rather than having multiple flags.
In D86587 I iterate on functions multiple times and I delete AAs early after manifesting them.
(Manifest happens multiple times).
I think most of the state change should happen in the ::run function.

OK, I'll move state changes into ::run

Aug 27 2020, 12:52 AM · Restricted Project

Aug 26 2020

kuter added a comment to D86678: [Attributor] Add a phase flag to Attributor.

Thank you for creating this. I was thinking of something like this rather than having multiple flags.
In D86587 I iterate on functions multiple times and I delete AAs early after manifesting them.
(Manifest happens multiple times).
I think most of the state change should happen in the ::run function.

Aug 26 2020, 11:56 PM · Restricted Project
kuter updated the diff for D86587: [WIP][Attributor] Per function iteration and memory tracking..

Split unrelated changes to another patch
Handle attibutes that are created after function delete.

Aug 26 2020, 1:02 PM · Restricted Project
kuter requested review of D86647: [Attributor] Add missing operators for ChangeStatus.
Aug 26 2020, 11:43 AM · Restricted Project
kuter added a comment to D86635: [Attributor] Guarantee getAAFor not to update AA in the manifestation stage.

I think rather than creating a new api function, it would be more robust if we had a flag as member of the attributor.
It would be similar to SeedingPeriod flag that I have added.

Aug 26 2020, 11:17 AM · Restricted Project
kuter added a comment to D86587: [WIP][Attributor] Per function iteration and memory tracking..

Thanks for the explanation. Since the patch is not small and it is a WIP, can you add some more information about the failing tests? Maybe some specific examples?

Merge checks are helpfull, but I guess if you give few specific examples with problems, it will be easier to focus. WDYT?

Aug 26 2020, 2:40 AM · Restricted Project

Aug 25 2020

kuter retitled D86587: [WIP][Attributor] Per function iteration and memory tracking. from wq[WIP][Attributor] Per function iteration and memory tracking. to [WIP][Attributor] Per function iteration and memory tracking..
Aug 25 2020, 9:21 PM · Restricted Project
kuter updated the summary of D86587: [WIP][Attributor] Per function iteration and memory tracking..
Aug 25 2020, 9:20 PM · Restricted Project
kuter added a comment to D86587: [WIP][Attributor] Per function iteration and memory tracking..

Thank you I will update the commit message.

Aug 25 2020, 9:16 PM · Restricted Project
kuter added a comment to D86587: [WIP][Attributor] Per function iteration and memory tracking..

I only updated the allow_list.ll. This brakes many tests and in some cases cause invalid IR (assertion gets trigered for a tail call).

Aug 25 2020, 8:46 PM · Restricted Project
kuter requested review of D86587: [WIP][Attributor] Per function iteration and memory tracking..
Aug 25 2020, 8:43 PM · Restricted Project

Aug 21 2020

kuter added a comment to rG72ddaedddafc: [Attributor][test] Add REQUIRES: asserts after D86129.

Thank you, I was about to commit this.
did a git pull and it just finished compiling.

Aug 21 2020, 4:37 PM
kuter committed rG65fcc0ee3185: [Attributor] Function seed allow list (authored by kuter).
[Attributor] Function seed allow list
Aug 21 2020, 1:57 PM
kuter closed D86129: [Attributor] Function seed allow list.
Aug 21 2020, 1:57 PM · Restricted Project

Aug 20 2020

kuter added a comment to D86319: [Attributor] Introduce module slice..

This is interesting, I thought you couldn't change the IR outside of the current SCC.
Was this intended to go on top of D86081 ?

Aug 20 2020, 6:39 PM · Restricted Project
kuter added inline comments to D86129: [Attributor] Function seed allow list.
Aug 20 2020, 5:09 PM · Restricted Project
kuter retitled D86129: [Attributor] Function seed allow list from [Attributor] Fucntion seed allow list to [Attributor] Function seed allow list.
Aug 20 2020, 5:07 PM · Restricted Project
kuter updated the diff for D86129: [Attributor] Function seed allow list.
  • Add negative test.
  • Fix clang-tidy error.
  • Make seed allow list only enabled for debug builds (assertions turned on).
Aug 20 2020, 5:06 PM · Restricted Project
kuter accepted D86266: [Attributor][NFC] Make "Attributor" the time scope and use "details".

LGTM

Aug 20 2020, 12:24 PM · Restricted Project

Aug 18 2020

kuter added a comment to D86145: [Attributor] Simplify comparison against constant null pointer.

I think the logic is correct, other people might want to check too.
Maybe we want to add more comments, it doesn't seem obvious what's happening here.

Aug 18 2020, 11:33 AM · Restricted Project
kuter requested review of D86129: [Attributor] Function seed allow list.
Aug 18 2020, 12:44 AM · Restricted Project

Aug 17 2020

kuter added a comment to D86018: [Attributor] fix AAValueConstantRange and IntegerRangeState implementation.

Hi can you try this on top of D86081

As I mentioned above, I will move this propagation into updateImpl. Therefore, I think the problem that you are concerned about will not occur.

Aug 17 2020, 6:46 PM · Restricted Project
kuter updated the diff for D86081: [Attributor] Restrict AA manifest to selected functions..

fix internalize.ll

Aug 17 2020, 9:47 AM · Restricted Project
kuter added a comment to D86018: [Attributor] fix AAValueConstantRange and IntegerRangeState implementation.

Hi can you try this on top of D86081

Aug 17 2020, 8:17 AM · Restricted Project
kuter updated the diff for D86081: [Attributor] Restrict AA manifest to selected functions..

fix style

Aug 17 2020, 8:16 AM · Restricted Project
kuter requested review of D86081: [Attributor] Restrict AA manifest to selected functions..
Aug 17 2020, 8:13 AM · Restricted Project

Aug 16 2020

kuter added inline comments to D86018: [Attributor] fix AAValueConstantRange and IntegerRangeState implementation.
Aug 16 2020, 5:55 PM · Restricted Project

Aug 3 2020

kuter added inline comments to D85131: [NFC][APInt][DenseMapInfo] Move DenseMapAPIntKeyInfo into DenseMap.h as DenseMapInfo<APInt>.
Aug 3 2020, 8:34 AM · Restricted Project
kuter added inline comments to D85131: [NFC][APInt][DenseMapInfo] Move DenseMapAPIntKeyInfo into DenseMap.h as DenseMapInfo<APInt>.
Aug 3 2020, 7:30 AM · Restricted Project

Aug 1 2020

kuter added a comment to D85065: [Attributor][NFC] Update description for the dependency graph.

Thank you.

Aug 1 2020, 6:01 AM · Restricted Project

Jul 30 2020

kuter committed rG49def10e02e3: [Attributor] Add time trace support. (authored by kuter).
[Attributor] Add time trace support.
Jul 30 2020, 5:19 PM
kuter closed D84980: [Attributor] Add time trace support..
Jul 30 2020, 5:18 PM · Restricted Project
kuter added a comment to D84980: [Attributor] Add time trace support..

Really cool :) LGTM

Jul 30 2020, 2:12 PM · Restricted Project
kuter requested review of D84980: [Attributor] Add time trace support..
Jul 30 2020, 1:38 PM · Restricted Project

Jul 29 2020

kuter added inline comments to D83738: [Attributor]Introduce call base context argument pathway..
Jul 29 2020, 9:19 PM · Restricted Project
kuter added inline comments to D83738: [Attributor]Introduce call base context argument pathway..
Jul 29 2020, 9:09 PM · Restricted Project
kuter added inline comments to D84722: [Attributor] Call site specific AAValueSimplification and AAIsDead..
Jul 29 2020, 4:48 AM · Restricted Project
kuter added a comment to D84722: [Attributor] Call site specific AAValueSimplification and AAIsDead..

Can you, maybe as a separate patch, run the update script with the call site deduction enabled *before* this patch and *after* to get the difference on all tests we have?

Jul 29 2020, 4:44 AM · Restricted Project
kuter updated the diff for D84751: [Attributor][Not for commit] Make call site specific deduction default..

add auto context injection.

Jul 29 2020, 4:39 AM · Restricted Project

Jul 28 2020

kuter planned changes to D84751: [Attributor][Not for commit] Make call site specific deduction default..

Some Attributes that have CBContext doesn't seem to be querying the CB specific attributes.
I will update this once I have a solution.

Jul 28 2020, 7:59 AM · Restricted Project
kuter requested review of D84751: [Attributor][Not for commit] Make call site specific deduction default..
Jul 28 2020, 6:55 AM · Restricted Project
kuter retitled D84722: [Attributor] Call site specific AAValueSimplification and AAIsDead. from Call site specific AAValueSimplification and AAIsDead. to [Attributor] Call site specific AAValueSimplification and AAIsDead..
Jul 28 2020, 5:02 AM · Restricted Project
kuter updated the diff for D83738: [Attributor]Introduce call base context argument pathway..

remove unused header.

Jul 28 2020, 5:00 AM · Restricted Project
kuter retitled D83738: [Attributor]Introduce call base context argument pathway. from [Attributor][WIP]Introduce call base context argument pathway. to [Attributor]Introduce call base context argument pathway..
Jul 28 2020, 4:57 AM · Restricted Project
kuter updated the diff for D83738: [Attributor]Introduce call base context argument pathway..

add unit test.
fix bug (😄)
fix typo.

Jul 28 2020, 4:56 AM · Restricted Project

Jul 27 2020

kuter requested review of D84722: [Attributor] Call site specific AAValueSimplification and AAIsDead..

Manually requesting review, since the Phabricator wasn't able to built this. From what I can see it was missing the parent revision with the last build.
Pre-merge checks should be ok now.

Jul 27 2020, 9:53 PM · Restricted Project
kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

bug fix.
add range contents as test.

Jul 27 2020, 7:25 PM · Restricted Project

Jul 25 2020

kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

fix tests.

Jul 25 2020, 4:53 PM · Restricted Project

Jul 24 2020

kuter added inline comments to D84532: [Attributor] Fix qualifier warning of the unittest.
Jul 24 2020, 8:25 PM · Restricted Project
kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

add missing code.
remove unneeded definies.
fix bug.

Jul 24 2020, 6:48 PM · Restricted Project
kuter added a comment to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

LGTM with nits.

Jul 24 2020, 4:37 PM · Restricted Project

Jul 23 2020

kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

fix styling.

Jul 23 2020, 5:21 PM · Restricted Project

Jul 20 2020

kuter retitled D81929: [Attributor] Introduce CallBaseContext to the IRPosition from [WIP][Attributor] Introduce CallBaseContext to the IRPosition to [Attributor] Introduce CallBaseContext to the IRPosition.
Jul 20 2020, 9:33 PM · Restricted Project
kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

Add unittest.

Jul 20 2020, 9:32 PM · Restricted Project
kuter added a comment to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

Memory usage for this patch:
comand: $LLVM_BIN/opt -S -attributor-cgscc test-suit/CTMark/SPASS/clause.ll
before:

calls to allocation functions: 78794 (82506/s)
temporary memory allocations: 3942 (4127/s)
peak heap memory consumption: 2.58MB
peak RSS (including heaptrack overhead): 355.73MB
total memory leaked: 140.33KB

after:

calls to allocation functions: 78802 (86977/s)
temporary memory allocations: 3942 (4350/s)
peak heap memory consumption: 2.59MB
peak RSS (including heaptrack overhead): 356.60MB
total memory leaked: 140.33KB

difference:

calls to allocation functions: 8 (-163/s)
temporary memory allocations: 0 (0/s)
peak heap memory consumption: 8.26KB
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Interesting, there doesn't seem to be much of a difference.

Jul 20 2020, 9:16 PM · Restricted Project

Jul 19 2020

kuter added a comment to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

All this is missing now is a test :). We can just check for the debug output.

Jul 19 2020, 5:32 PM · Restricted Project
kuter added inline comments to D83744: [Attributor] Attributor call site specific AAValueConstantRange.
Jul 19 2020, 11:31 AM · Restricted Project
kuter added inline comments to D83738: [Attributor]Introduce call base context argument pathway..
Jul 19 2020, 12:41 AM · Restricted Project
kuter updated the diff for D83738: [Attributor]Introduce call base context argument pathway..

fix wording. use pointer_iterator instead of for loop.
fix naming.

Jul 19 2020, 12:39 AM · Restricted Project

Jul 18 2020

kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

small improvements.

Jul 18 2020, 11:48 PM · Restricted Project
kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

add missing documentation.
improve formating and readability.
fix typos.
rename command line option

Jul 18 2020, 9:05 PM · Restricted Project
kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

fix run lines (there was a mistake in the earlier revision).

Jul 18 2020, 4:53 PM · Restricted Project
kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

Add test combinations.

Jul 18 2020, 4:23 PM · Restricted Project
kuter added a comment to D83744: [Attributor] Attributor call site specific AAValueConstantRange.

Some minor comments below.

Upload diffs with full context please.

Jul 18 2020, 3:29 PM · Restricted Project
kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

fix typo.
improve code readability.

Jul 18 2020, 3:28 PM · Restricted Project

Jul 17 2020

kuter added inline comments to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.
Jul 17 2020, 8:19 PM · Restricted Project

Jul 16 2020

kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

add attributor-enable-call-site-specific=false as a test.
fix the run lines.

Jul 16 2020, 4:29 PM · Restricted Project

Jul 15 2020

kuter added a comment to D83744: [Attributor] Attributor call site specific AAValueConstantRange.

Cool! As discussed, merge D83299 and add new call sites for test1.

Jul 15 2020, 2:33 PM · Restricted Project
kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

merge with D83299
add positive and negative tests.

Jul 15 2020, 8:25 AM · Restricted Project

Jul 14 2020

kuter abandoned D83299: [Attributor] [WIP] Introduce callbase context bridges..

merged with D83744

Jul 14 2020, 8:42 AM · Restricted Project

Jul 13 2020

kuter updated the summary of D83744: [Attributor] Attributor call site specific AAValueConstantRange.
Jul 13 2020, 11:08 PM · Restricted Project
kuter added a comment to D83299: [Attributor] [WIP] Introduce callbase context bridges..

Can we include some code that triggers this so we can tests it?

D83744 uses this and has tests.

Jul 13 2020, 11:07 PM · Restricted Project
kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

Fix typo

Jul 13 2020, 10:42 PM · Restricted Project
kuter planned changes to D83297: [Attributor][WIP] Attribute scheduling visualization..
Jul 13 2020, 10:31 PM · Restricted Project
kuter retitled D83744: [Attributor] Attributor call site specific AAValueConstantRange from [Attributor] Attributor call base specific AAValueConstantRange to [Attributor] Attributor call site specific AAValueConstantRange.
Jul 13 2020, 10:25 PM · Restricted Project
Herald added a project to D83744: [Attributor] Attributor call site specific AAValueConstantRange: Restricted Project.
Jul 13 2020, 10:16 PM · Restricted Project
kuter updated the summary of D83738: [Attributor]Introduce call base context argument pathway..
Jul 13 2020, 9:05 PM · Restricted Project
Herald added a project to D83738: [Attributor]Introduce call base context argument pathway.: Restricted Project.
Jul 13 2020, 9:03 PM · Restricted Project
kuter added a comment to D78861: [Attributor] Track AA dependency using dependency graph.

Hi @bbn when will commit this ?

Jul 13 2020, 5:16 PM · Restricted Project

Jul 12 2020

kuter added a comment to D82861: [Attributor] Add AAValueSimplifyCallSiteArgument::manifest.

Can you merge this?

Do I have a right to merge this by myself? I did arc patch and tried to git push https://github.com/llvm/llvm-project.git HEAD:master according to the document, but I failed to do that.

Did you get the commit access? If so, what problems did you have with git push?

I got the following message with git push

remote: Permission to llvm/llvm-project.git denied to okuraofvegetable.
fatal: unable to access 'https://github.com/llvm/llvm-project.git/': The requested URL returned error: 403

From this message, it seems to me that I don't have commit access.

Jul 12 2020, 4:58 AM · Restricted Project
kuter closed D83185: [Attributor] Introduce Attribute seed allow list..
Jul 12 2020, 4:32 AM · Restricted Project

Jul 11 2020

kuter committed rG4dbe82eef34e: [Attributor] Introudce attribute seed allow list. (authored by kuter).
[Attributor] Introudce attribute seed allow list.
Jul 11 2020, 4:42 PM
kuter updated the diff for D83185: [Attributor] Introduce Attribute seed allow list..
  1. Better comments.
  2. Remove unneeded lines from the test.
Jul 11 2020, 9:54 AM · Restricted Project

Jul 8 2020

kuter added inline comments to D83297: [Attributor][WIP] Attribute scheduling visualization..
Jul 8 2020, 2:18 PM · Restricted Project
kuter added a comment to D83297: [Attributor][WIP] Attribute scheduling visualization..
In D83297#2138744, @bbn wrote:

Can we just merge the dependency graph and the "SchedulingGraph" because I think they are quite similar.

Jul 8 2020, 2:14 PM · Restricted Project

Jul 7 2020

kuter updated the diff for D83299: [Attributor] [WIP] Introduce callbase context bridges..
Jul 7 2020, 5:17 AM · Restricted Project
Herald added a project to D83299: [Attributor] [WIP] Introduce callbase context bridges.: Restricted Project.
Jul 7 2020, 5:07 AM · Restricted Project
kuter updated the summary of D83297: [Attributor][WIP] Attribute scheduling visualization..
Jul 7 2020, 5:00 AM · Restricted Project
Herald added a project to D83297: [Attributor][WIP] Attribute scheduling visualization.: Restricted Project.
Jul 7 2020, 5:00 AM · Restricted Project

Jul 6 2020

kuter added a comment to D83185: [Attributor] Introduce Attribute seed allow list..

Either is fine but I think it is more natural to forbid an empty list.

Do you mean returning a error if a empty --attributor-seed-allow-list option is present ?
Currently the size of list is being used to tell if a list is present or not.
I think I can use getNumOccurrences() to replace this behaviour .

Yes, I think replacing ZeroOrMore with OneOrMore is enoguh

Jul 6 2020, 3:27 PM · Restricted Project
kuter added a comment to D83185: [Attributor] Introduce Attribute seed allow list..

Either is fine but I think it is more natural to forbid an empty list.

Jul 6 2020, 3:02 PM · Restricted Project
kuter added a comment to D78861: [Attributor] Track AA dependency using dependency graph.
In D78861#2133485, @bbn wrote:

This looks pretty good :). Nice active review :)

I have some minor comments below. We also should add a test for the print and dot output.

I need some help here:
Is there a way to test the dot output? I checked the .dot file and found it hard to write CHECK lines (see below) because we are interested in the link between different graph nodes (line 3 and line 4)

	Node0x55be15e4f7d0 [shape=record,label="{[AAValueSimplify] for CtxI '  %2 = load i32, i32* %0, align 4' at position \{arg: [@0]\} with state simplified\n}"];
	Node0x55be15e4f810 [shape=record,label="{[AANoUnwind] for CtxI '  %2 = load i32, i32* %0, align 4' at position \{fn:checkAndAdvance [checkAndAdvance@-1]\} with state nounwind\n}"];
	Node0x55be15e4f810 -> Node0x55be15e500b0;
	Node0x55be15e4f810 -> Node0x55be15e500b0;

I have referred to some other similar tests like the *cfg_deopt_unreach.ll*, but none of theme shows how to write check lines for such testcases.

Jul 6 2020, 2:48 PM · Restricted Project
kuter added inline comments to D83185: [Attributor] Introduce Attribute seed allow list..
Jul 6 2020, 5:59 AM · Restricted Project
kuter updated the diff for D83185: [Attributor] Introduce Attribute seed allow list..

Introduce test for the command line option

Jul 6 2020, 5:57 AM · Restricted Project

Jul 5 2020

kuter updated the diff for D83185: [Attributor] Introduce Attribute seed allow list..

Replace ternary expression with early return

Jul 5 2020, 5:35 PM · Restricted Project
Herald added a reviewer for D83185: [Attributor] Introduce Attribute seed allow list.: uenoku.
Jul 5 2020, 5:35 PM · Restricted Project
kuter added a comment to D83172: [Attributor] Create getter function for the ID of the abstract attribute.
In D83172#2131779, @bbn wrote:

Attributes are going to be decleared outside of the Attributor soon.

Do you mean that there might be other abstract attributes defined outside the AttributorAttributes.cpp ?

As of yesterday, there is an AA outside of AttributorAttributes :). You should rebase.

so I think we can have a macro like this:

#define ATTRIBUTE_BOILER(CLASS)                    \
    const char *getIdAddr() { return &ID}                 \
    const std::string getName() { return #CLASS;}   \
    static const char ID;

Yes this could work, but I am still unsure about it..... I'd also like to hear what others think about this.

I mean it is not that much code. Maybe I'm missing something, but why not just use ID directly?

Jul 5 2020, 5:19 AM · Restricted Project