Page MenuHomePhabricator

kuter (Kuter Dinel)
User

Projects

User does not belong to any projects.

User Details

User Since
Thu, Mar 5, 1:46 PM (4 w, 1 h)

Recent Activity

Thu, Mar 26

kuter updated the diff for D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..
Thu, Mar 26, 5:57 PM · Restricted Project

Wed, Mar 25

kuter updated the diff for D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

Simplfy accumulateConstantOffset

Wed, Mar 25, 2:38 PM · Restricted Project
kuter added inline comments to D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..
Wed, Mar 25, 8:37 AM · Restricted Project
kuter updated the diff for D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

Eliminated redundant debug messages, Style fixes, Added negative test case,
Don't use external analysis if the get operand is a struct type.

Wed, Mar 25, 8:04 AM · Restricted Project

Mon, Mar 23

kuter added a comment to D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

We could. What we want (regardless of how) is to track in AAConstantRange (conceptually) two ranges: (1) potential value range, (2) known value range. This is not the same as the assumed/known we track now. Right now bot track the potential value range, that is what value can this llvm::Value potentially have at runtime. I think tracking the second, thus, what value is this llvm::Value going to have at runtime (if it is executed) could be tracked in the same AA or a different one, depending on how much logic we can share. This is also a follow up patch (or two).

Agreed.

Mon, Mar 23, 11:21 PM · Restricted Project

Sat, Mar 21

kuter added inline comments to D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..
Sat, Mar 21, 5:53 AM · Restricted Project

Fri, Mar 20

kuter updated the diff for D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

Fixed styling, added FIXME, Sperated new code.

Fri, Mar 20, 10:11 PM · Restricted Project

Thu, Mar 19

kuter added a comment to D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

Can you explain why we need to catch overflows now but not before? I mean, the values determine by the external analysis are valid lower bounds, what is different from versioning on them and making them constant in one of the versions.

@jdoerfert

This patch is not complete yet.

Currently it can only use the known information. I would like to make it possible for it to use the assumed information as well.
The problem with that is:

We need to iterate over the uses and take the maximum of the current dereferancability that is indicated by that use.
this works fine for the known info. But since the lower bound of the assumed constant range can decrease over time,
taking max with existing state is a problem.

The way that the AAFromMustBeExecutedContext is wired makes things a bit tricky and
I would like to get your opinions on this before I proceed.

I think we should finish this one and then do the following:

We actually don't want the minimal offset but the maximal known offset, right? In addition to renaming the function we will check if the range from AAConstantRange is known, if so, we take the maximum instead.

Thu, Mar 19, 10:27 PM · Restricted Project
kuter added inline comments to D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..
Thu, Mar 19, 9:54 PM · Restricted Project
kuter added a comment to D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

This patch is not complete yet.

Thu, Mar 19, 4:49 AM · Restricted Project

Wed, Mar 18

kuter updated the diff for D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

Made the changes @jdoerfert asked for.

Wed, Mar 18, 10:15 PM · Restricted Project

Sun, Mar 15

kuter created D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..
Sun, Mar 15, 9:42 PM · Restricted Project