I took the "Permitted"/"Not Permitted" combo from the Tag_ARM_ISA_use case (GNU tools print "Yes").
Details
Diff Detail
Unit Tests
Time | Test | |
---|---|---|
410 ms | linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp |
Event Timeline
llvm/test/MC/ARM/directive-arch-armv8m.s | ||
---|---|---|
1 | Does this add additional coverage not available by other tests? |
llvm/test/MC/ARM/directive-arch-armv8m.s | ||
---|---|---|
1 | This tests that the THUMB_ISA_use=3 case round-trips correctly, llvm-mc emits it and llvm-readobj is able to read/interpret/dump it. |
Please give other reviewers some time to chime in
llvm/test/MC/ARM/directive-arch-armv8m.s | ||
---|---|---|
6 | Minor nit: in other places, | at the end of the previous line is more common |
I am once again asking for your financial support.
@MaskRay would you mind landing this now that it got another approval mark?
clang-tidy: warning: invalid case style for variable 'strings' [readability-identifier-naming]
not useful
clang-format: please reformat the code