This adds some initial support for regions and does not support formatting the specific arguments of a region. For now this can be achieved by using a custom directive that formats the arguments and then parses the region.
Depends On D86759
Paths
| Differential D86760
[mlir][OpFormatGen] Add initial support for regions in the custom op assembly format ClosedPublic Authored by rriddle on Aug 27 2020, 7:58 PM.
Details Summary This adds some initial support for regions and does not support formatting the specific arguments of a region. For now this can be achieved by using a custom directive that formats the arguments and then parses the region. Depends On D86759
Diff Detail
Event TimelineHerald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptAug 27 2020, 7:58 PM mehdi_amini added inline comments.
This revision is now accepted and ready to land.Aug 27 2020, 10:18 PM rriddle added inline comments.
Closed by commit rGeaeadce9bd11: [mlir][OpFormatGen] Add initial support for regions in the custom op assembly… (authored by rriddle). · Explain WhyAug 31 2020, 1:27 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 288754 mlir/docs/OpDefinitions.md
mlir/include/mlir/IR/OpImplementation.h
mlir/include/mlir/IR/OperationSupport.h
mlir/lib/IR/OperationSupport.cpp
mlir/lib/Parser/AttributeParser.cpp
mlir/lib/Parser/Parser.h
mlir/lib/Parser/Parser.cpp
mlir/test/lib/Dialect/Test/TestDialect.cpp
mlir/test/lib/Dialect/Test/TestOps.td
mlir/test/mlir-tblgen/op-format-spec.td
mlir/test/mlir-tblgen/op-format.mlir
mlir/tools/mlir-tblgen/OpFormatGen.cpp
|
Ah seems like you never intended to change this in the grandparent?