Page MenuHomePhabricator

[mlir][ODS] Add new SymbolNameAttr and add support for in assemblyFormat
ClosedPublic

Authored by rriddle on Aug 27 2020, 7:58 PM.

Details

Summary

Symbol names are a special form of StringAttr that get treated specially in certain areas, such as formatting. This revision adds a special derived attr for them in ODS and adds support in the assemblyFormat for formatting them properly.

Depends On D84719

Diff Detail

Event Timeline

rriddle created this revision.Aug 27 2020, 7:58 PM
Herald added a project: Restricted Project. · View Herald Transcript
rriddle requested review of this revision.Aug 27 2020, 7:58 PM
Harbormaster completed remote builds in B69879: Diff 288519.
mehdi_amini accepted this revision.Aug 27 2020, 9:49 PM
mehdi_amini added inline comments.
mlir/tools/mlir-tblgen/OpFormatGen.cpp
399

can->should?

This revision is now accepted and ready to land.Aug 27 2020, 9:49 PM
rriddle updated this revision to Diff 288722.Aug 28 2020, 3:49 PM
rriddle marked an inline comment as done.

Resolve comments