This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add error checking for extensions missing separating underscores
ClosedPublic

Authored by simoncook on Jul 14 2020, 2:55 PM.

Details

Summary

Currently if two multi-letter extensions are provided in a -march=
string, the verification code checks the version of the first and
consumes the second, resulting in that part of the architecture
string being ignored. This adds a test that when a version number has
been parsed for an extension, there are no subsequent characters.

Diff Detail

Event Timeline

simoncook created this revision.Jul 14 2020, 2:55 PM
asb accepted this revision.Jul 14 2020, 10:28 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 14 2020, 10:28 PM
This revision was automatically updated to reflect the committed changes.