Page MenuHomePhabricator

[OpenMP][NFC] Remove unused and untested code from the device runtime
ClosedPublic

Authored by jdoerfert on Jul 7 2020, 2:53 PM.

Details

Summary

We carried a lot of unused and untested code in the device runtime.
Among other reasons, we are planning major rewrites for which reduced
size is going to help a lot.

The number of code lines reduced by 14%!

Before:
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CUDA                            13            489            841           2454
C/C++ Header                    14            322            493           1377
C                               12            117            124            559
CMake                            4             64             64            262
C++                              1              6              6             39
-------------------------------------------------------------------------------
SUM:                            44            998           1528           4691
-------------------------------------------------------------------------------

After:
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CUDA                            13            366            733           1879
C/C++ Header                    14            317            484           1293
C                               12            117            124            559
CMake                            4             64             64            262
C++                              1              6              6             39
-------------------------------------------------------------------------------
SUM:                            44            870           1411           4032
-------------------------------------------------------------------------------

Diff Detail

Event Timeline

jdoerfert created this revision.Jul 7 2020, 2:53 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 7 2020, 2:53 PM

Please let me know if something slipped through my "clever" grep logic and is actually used.

jdoerfert edited the summary of this revision. (Show Details)Jul 7 2020, 2:55 PM
JonChesterfield accepted this revision.Jul 7 2020, 3:49 PM

Applied to the amdgcn implementation. Compiles fine, tests all passing. Seems likely that this lot really is dead.

Interesting that this removes*_data_sharing_environment. I think some of the allocated objects will be more obviously dead after this patch.

Love it. Thanks! We can have this as soon as we hit consensus on dropping the API stability aspiration

This revision is now accepted and ready to land.Jul 7 2020, 3:49 PM
This revision was automatically updated to reflect the committed changes.