User Details
- User Since
- Aug 8 2018, 8:02 AM (268 w, 3 d)
Mon, Sep 11
Aug 12 2023
Jul 25 2023
Glad to see more error traps.
Jul 24 2023
Jul 21 2023
Jul 11 2023
Jun 27 2023
Please also include the environment variable in the patch summary.
Jun 22 2023
Jun 9 2023
ping @arsenm could you finalize this patch and close https://github.com/llvm/llvm-project/issues/61083?
May 31 2023
I don't remember what workload was choked on this. My quick testing shows everything being fine. So let us just land this.
May 17 2023
May 3 2023
Updating the patch description is also needed.
Apr 26 2023
From the meeting discussion.
- default to active waiting rather than 0.
- Consider a single LIBOMPTARGET_AMDGPU_STREAM_BUSYWAIT.
Apr 25 2023
Apr 20 2023
Why separate KERNEL_BUSYWAIT and DATA_BUSYWAIT? I don't feel the need of two separate controls.
What are the units? Documentation?
Apr 12 2023
Apr 6 2023
Currently, we only load an image if its supported architecture matches all of the devices found.
Cannot understand
Apr 5 2023
Mar 27 2023
Unfortunately my original problem still persists with this patch. The active wait timed out and then still stuck in the blocking wait.
Tested 3, 30, 300, 3000, 30000, 300000, 3000000 on my W6800. I have to consider some software between hsa and the hardware is broken.
Got compiler warning.
/scratch3/opt/llvm-clang/llvm-project/openmp/libomptarget/src/omptarget.cpp: In lambda function: /scratch3/opt/llvm-clang/llvm-project/openmp/libomptarget/src/omptarget.cpp:1058:56: warning: cast from type 'void* const*' to type 'void*' casts away qualifiers [-Wcast-qual] 1058 | (void *)&ShadowPtr.TgtPtrVal, |
Mar 24 2023
Got test failure
Failed Tests (1): libomptarget :: x86_64-pc-linux-gnu :: offloading/barrier_fence.c
Mar 23 2023
Keep things moving.
Mar 22 2023
Mar 21 2023
@JonChesterfield is this patch good to go?
Mar 17 2023
Still prefer a more clear message.
Mar 13 2023
Mar 8 2023
Feb 17 2023
Feb 16 2023
Feb 12 2023
Jan 29 2023
Jan 25 2023
My understanding from the weekly call is that "locked" is for a device agent not the device.
It can be used in hsa memory copy calls but is_device_ptr is for device(kernel) access and thus incorrect.
Jan 24 2023
Jan 23 2023
It doesn't print well
$ OMP_TARGET_OFFLOAD=mandatory ./a.out Libomptarget error: Consult https://openmp.llvm.org/design/Runtimes.html for debugging options. Libomptarget error: None of the images ( gfx90a Libomptarget error: Source location information not present. Compile with -g or -gline-tables-only. Libomptarget fatal error 1: failure of target construct while offloading is mandatory
Ref-counting lock/unlock makes a lot sense.
When libomptarget failed to load the amd plugin due to missing hsa runtime so files.
I got
yeluo@epyc-server:~$ clang++ -fopenmp --offload-arch=gfx90a main.cpp yeluo@epyc-server:~$ OMP_TARGET_OFFLOAD=mandatory ./a.out Libomptarget error: Consult https://openmp.llvm.org/design/Runtimes.html for debugging options. Libomptarget error: None of the images found are compatible: gfx90a Libomptarget error: Source location information not present. Compile with -g or -gline-tables-only. Libomptarget fatal error 1: failure of target construct while offloading is mandatory
How does the above message behaves when there is no GPU on the node.
Jan 21 2023
This patch needs a rebase. Applying patch failed.
Ping. What is left before merging?
Jan 19 2023
Quite close to the release. Let's merge this and deal with the remaining issue in a later patch.
Jan 13 2023
Jan 10 2023
lock_memory and unlock_memory not symmetric.
I mean
lock_memory(ptr) # lock happens
lock_memory(ptr) # no-op
unlock_memory(ptr) # unlock happens
unlock_memory(ptr) # no-op
I still don't feel safe about the amd plugin implementation
- how is_locked handle error.
- lock_memory doesn't return error code
- lock_memory and unlock_memory behavior is not symmetric.
But that is only inside the plugin.
Jan 9 2023
Does this patch work when there are more than one level of inheritance? For example class B: public A; class C: public B
Jan 8 2023
Jan 6 2023
ping. I'm looking forward to the landing of this patch.
Jan 5 2023
All the lock functions should return pointers via an argument.
All the lock and unlock functions should return error codes.
Dec 28 2022
Got tons of runtime failure
target doesn't support jit UNREACHABLE executed at /gpfs/jlse-fs0/users/yeluo/opt/llvm-clang/llvm-project-nightly/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h:543!
on AMD GPU gfx906 when running miniqmc ctest
failure happens with
LIBOMPTARGET_NEXTGEN_PLUGINS=1
Dec 21 2022
Dec 19 2022
Dec 15 2022
My requests have been addressed.
Dec 12 2022
clang-formatting
Nov 29 2022
Seems fine in my builds of OpenMP as a project and a runtime.
Nov 25 2022
Nov 23 2022
Nov 14 2022
Pass tests on my side. Thanks