Page MenuHomePhabricator

ye-luo (Ye Luo)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 8 2018, 8:02 AM (204 w, 23 h)

Recent Activity

Mon, Jun 27

ye-luo added a comment to D128680: [SLP]Fix PR56251: Do not remove the reordering from the root node, being used as an operand..

Confirmed that this patch fixes https://github.com/llvm/llvm-project/issues/56251

Mon, Jun 27, 3:43 PM · Restricted Project, Restricted Project

Mon, Jun 20

ye-luo accepted D128206: [Clang] Allow multiple comma separated arguments to `--offload-arch=`.

LGTM. This allows me to write concise compile lines.

Mon, Jun 20, 7:28 AM · Restricted Project, Restricted Project
ye-luo committed rG4d9499e8cc39: [libomptarget] Make libomptarget.devicertl.a built in all cases. (authored by ye-luo).
[libomptarget] Make libomptarget.devicertl.a built in all cases.
Mon, Jun 20, 6:30 AM · Restricted Project, Restricted Project
ye-luo closed D128130: [libomptarget] Make libomptarget.devicertl.a built in all cases..
Mon, Jun 20, 6:30 AM · Restricted Project, Restricted Project

Sun, Jun 19

ye-luo updated the diff for D128130: [libomptarget] Make libomptarget.devicertl.a built in all cases..

Use -O3 in DeviceRTL static library build.

Sun, Jun 19, 2:11 PM · Restricted Project, Restricted Project

Sat, Jun 18

ye-luo added a comment to D128130: [libomptarget] Make libomptarget.devicertl.a built in all cases..

So this changes the compilation to just use the Clang binary found in the install directory and hope it works like we did previously.

We don't do "hope it works" but we are sure it works and I don't think we found undesired clang. If undesired clang gets picked up. Please report issues.
Actually in the case of ENABLE_PROJECTS=openmp, there is no clang binary searching but directly referencing the clang cmake target. The just-built clang is guaranteed to be picked up.
In the case of ENABLE_RUNTIMES=openmp, LLVM_DIR is passed in, I would consider it closer to "hope it works". Even relying on CMAKE_CXX_COMPILER in runtime builds, you actually hope the RUNTIMES setup passes in the desired compiler, it is just a different scripting magic managed by ENABLE_RUNTIMES.

Sat, Jun 18, 8:43 PM · Restricted Project, Restricted Project
ye-luo committed rG54b45afb599a: [libomptarget]Add a trap for external omptarget from LLVM (authored by ye-luo).
[libomptarget]Add a trap for external omptarget from LLVM
Sat, Jun 18, 7:10 PM · Restricted Project, Restricted Project
ye-luo closed D128129: [libomptarget]Add a trap for external omptarget from LLVM.
Sat, Jun 18, 7:10 PM · Restricted Project, Restricted Project
ye-luo retitled D128130: [libomptarget] Make libomptarget.devicertl.a built in all cases. from Make libomptarget.devicertl.a built in all cases. to [libomptarget] Make libomptarget.devicertl.a built in all cases..
Sat, Jun 18, 6:51 PM · Restricted Project, Restricted Project
ye-luo added reviewers for D128130: [libomptarget] Make libomptarget.devicertl.a built in all cases.: jhuber6, tianshilei1992.
Sat, Jun 18, 6:50 PM · Restricted Project, Restricted Project
ye-luo requested review of D128130: [libomptarget] Make libomptarget.devicertl.a built in all cases..
Sat, Jun 18, 6:48 PM · Restricted Project, Restricted Project
ye-luo retitled D128129: [libomptarget]Add a trap for external omptarget from LLVM from Add trap for external omptarget. to [libomptarget]Add a trap for external omptarget from LLVM.
Sat, Jun 18, 6:03 PM · Restricted Project, Restricted Project
ye-luo requested review of D128129: [libomptarget]Add a trap for external omptarget from LLVM.
Sat, Jun 18, 6:00 PM · Restricted Project, Restricted Project

May 16 2022

ye-luo added inline comments to D125698: [Libomptarget] Don't build the device runtime without a new Clang.
May 16 2022, 12:52 PM · Restricted Project, Restricted Project
ye-luo accepted D125698: [Libomptarget] Don't build the device runtime without a new Clang.

Restored gcc build in my tests.

May 16 2022, 12:47 PM · Restricted Project, Restricted Project
ye-luo added a comment to D125698: [Libomptarget] Don't build the device runtime without a new Clang.

LGTM.

We are using CMake's command to build the device runtime now. There is no way to tell CMake to use another compiler rather than CMake's compilers to build a specific target. As a result, we either disable it, or we are doomed.
Well, accurately speaking, there seems to be a way to do that, see https://stackoverflow.com/questions/27168094/cmake-how-to-change-compiler-for-individual-target, but I don't think manipulating CMake's internal variables is a good practice.

I didn't say to workaround CMake. I was saying it was working that clang builds DeviceRTL and gcc building all the rest and now it is broken. You can try it out yourself with the commit before D125315

I'll just guard the new code then. Even though it shouldn't break if you're using the standard builds it will probably make it less noisy for people currently using the other methods.

Eventually we will abandon the old method, no?

May 16 2022, 9:35 AM · Restricted Project, Restricted Project
ye-luo updated subscribers of D125698: [Libomptarget] Don't build the device runtime without a new Clang.
May 16 2022, 9:19 AM · Restricted Project, Restricted Project
ye-luo added a comment to D125698: [Libomptarget] Don't build the device runtime without a new Clang.

LGTM.

We are using CMake's command to build the device runtime now. There is no way to tell CMake to use another compiler rather than CMake's compilers to build a specific target. As a result, we either disable it, or we are doomed.
Well, accurately speaking, there seems to be a way to do that, see https://stackoverflow.com/questions/27168094/cmake-how-to-change-compiler-for-individual-target, but I don't think manipulating CMake's internal variables is a good practice.

May 16 2022, 9:19 AM · Restricted Project, Restricted Project
ye-luo added a comment to D125698: [Libomptarget] Don't build the device runtime without a new Clang.
This is either done with a two-step build, where OpenMP is built with
the Clang that was just installed, or through the
-DLLLVM_ENABLE_RUNTIMES=openmp option. This has always been the case,

This is not true. Even before D125315 breakage, all the host libraries can be built with GCC and DeviceRTL with just-built Clang via -DLLVM_ENABLE_PROJECTS=openmp
Maybe we should figure out why D125315 doesn't pick up clang when building DeviceRTL.

May 16 2022, 9:05 AM · Restricted Project, Restricted Project
ye-luo requested changes to D125698: [Libomptarget] Don't build the device runtime without a new Clang.
May 16 2022, 9:01 AM · Restricted Project, Restricted Project
ye-luo added a comment to D125698: [Libomptarget] Don't build the device runtime without a new Clang.

This is different from what I'm looking for. DeviceRTL should still be built as it was. Only the part added by D125315 should be disabled.

May 16 2022, 9:00 AM · Restricted Project, Restricted Project

Apr 28 2022

ye-luo added a comment to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

@qiongsiwu1 Tested the updated patch. Works fine now.

Apr 28 2022, 9:00 AM · Restricted Project, Restricted Project

Apr 23 2022

ye-luo committed rG38822b98fa3b: Revert "[clang] Adding Platform/Architecture Specific Resource Header… (authored by ye-luo).
Revert "[clang] Adding Platform/Architecture Specific Resource Header…
Apr 23 2022, 7:36 AM · Restricted Project, Restricted Project
ye-luo added a reverting change for rG2512a875ccac: [clang] Adding Platform/Architecture Specific Resource Header Installation…: rG38822b98fa3b: Revert "[clang] Adding Platform/Architecture Specific Resource Header….
Apr 23 2022, 7:36 AM · Restricted Project, Restricted Project
ye-luo added a reverting change for D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets: rG38822b98fa3b: Revert "[clang] Adding Platform/Architecture Specific Resource Header….
Apr 23 2022, 7:36 AM · Restricted Project, Restricted Project
ye-luo added a comment to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

Got some trouble. See https://github.com/llvm/llvm-project/issues/55002

Apr 23 2022, 7:21 AM · Restricted Project, Restricted Project

Apr 22 2022

ye-luo committed rG8a880db51929: [libomptarget] Make omp_target_is_present checks storage instead of zero length… (authored by ye-luo).
[libomptarget] Make omp_target_is_present checks storage instead of zero length…
Apr 22 2022, 3:37 PM · Restricted Project, Restricted Project
ye-luo closed D123891: [libomptarget] Make omp_target_is_present checks storage instead of zero length array..
Apr 22 2022, 3:37 PM · Restricted Project, Restricted Project
ye-luo committed rG91ccd8248c85: [Clang][OpenMP] libompd: get libomp hwloc includedir by target_link_libraries (authored by ye-luo).
[Clang][OpenMP] libompd: get libomp hwloc includedir by target_link_libraries
Apr 22 2022, 3:36 PM · Restricted Project, Restricted Project
ye-luo closed D123888: [Clang][OpenMP] libompd: get libomp hwloc includedir by target_link_libraries.
Apr 22 2022, 3:36 PM · Restricted Project, Restricted Project

Apr 19 2022

ye-luo added a comment to D123888: [Clang][OpenMP] libompd: get libomp hwloc includedir by target_link_libraries.

The debian failure seems unrelated. Let me know if you need me to commit the patch.

Apr 19 2022, 7:46 PM · Restricted Project, Restricted Project

Apr 17 2022

ye-luo accepted D123444: [OpenMP][FIX] Simplify the entry deletion scheme.
Apr 17 2022, 1:57 PM · Restricted Project, Restricted Project

Apr 16 2022

ye-luo updated the diff for D123891: [libomptarget] Make omp_target_is_present checks storage instead of zero length array..

Expand the test.

Apr 16 2022, 7:56 AM · Restricted Project, Restricted Project

Apr 15 2022

ye-luo added reviewers for D123892: [libomptarget] add a test mapping three chunks of the same array: jdoerfert, RaviNarayanaswamy.
Apr 15 2022, 9:13 PM · Restricted Project, Restricted Project
ye-luo requested review of D123892: [libomptarget] add a test mapping three chunks of the same array.
Apr 15 2022, 9:12 PM · Restricted Project, Restricted Project
ye-luo added a comment to D123888: [Clang][OpenMP] libompd: get libomp hwloc includedir by target_link_libraries.

check_include_file is like writing an empty main with one include line and gets it compiled. So it doesn't pull any dependency.
To test whether hwloc.h is a valid header file, you'd need to provide CMAKE_REQUIRED_INCLUDES pointing to hwloc.h.
So it is needed.

Apr 15 2022, 8:39 PM · Restricted Project, Restricted Project
ye-luo updated the summary of D123891: [libomptarget] Make omp_target_is_present checks storage instead of zero length array..
Apr 15 2022, 8:24 PM · Restricted Project, Restricted Project
ye-luo requested review of D123891: [libomptarget] Make omp_target_is_present checks storage instead of zero length array..
Apr 15 2022, 8:22 PM · Restricted Project, Restricted Project
ye-luo accepted D123888: [Clang][OpenMP] libompd: get libomp hwloc includedir by target_link_libraries.

One minor change requested. All the rest LGTM.

Apr 15 2022, 8:16 PM · Restricted Project, Restricted Project
ye-luo requested changes to D123888: [Clang][OpenMP] libompd: get libomp hwloc includedir by target_link_libraries.
Apr 15 2022, 7:42 PM · Restricted Project, Restricted Project

Apr 14 2022

ye-luo added inline comments to D123444: [OpenMP][FIX] Simplify the entry deletion scheme.
Apr 14 2022, 1:45 PM · Restricted Project, Restricted Project
ye-luo added inline comments to D123446: [OpenMP][FIX] Remove shadow pointer map and introduce consistent locking.
Apr 14 2022, 1:37 PM · Restricted Project, Restricted Project

Apr 13 2022

ye-luo added a comment to D123446: [OpenMP][FIX] Remove shadow pointer map and introduce consistent locking.

I'm afraid you are abusing existing mutex. Please be specific about what part of the Entry you are trying to protect with TPR lock/unlock.

Apr 13 2022, 10:35 PM · Restricted Project, Restricted Project
ye-luo requested changes to D123444: [OpenMP][FIX] Simplify the entry deletion scheme.
Apr 13 2022, 10:10 PM · Restricted Project, Restricted Project
ye-luo added a comment to D123446: [OpenMP][FIX] Remove shadow pointer map and introduce consistent locking.

The new scheme stores the shadow pointers inside the entries.

Makes a lot more sense now.

Apr 13 2022, 9:29 PM · Restricted Project, Restricted Project

Apr 12 2022

ye-luo accepted D123443: [OpenMP][NFCI] Cleanup APIs and improve object encapsulation.
Apr 12 2022, 7:05 AM · Restricted Project, Restricted Project

Apr 11 2022

ye-luo added inline comments to D123443: [OpenMP][NFCI] Cleanup APIs and improve object encapsulation.
Apr 11 2022, 8:26 PM · Restricted Project, Restricted Project
ye-luo added inline comments to D123443: [OpenMP][NFCI] Cleanup APIs and improve object encapsulation.
Apr 11 2022, 4:59 PM · Restricted Project, Restricted Project
ye-luo added inline comments to D123443: [OpenMP][NFCI] Cleanup APIs and improve object encapsulation.
Apr 11 2022, 1:48 PM · Restricted Project, Restricted Project

Apr 7 2022

ye-luo committed rGc1a6fe196d8c: [libomptarget] Implement pointer lookup as 5.1 spec. (authored by ye-luo).
[libomptarget] Implement pointer lookup as 5.1 spec.
Apr 7 2022, 9:02 PM · Restricted Project, Restricted Project
ye-luo closed D123093: [libomptarget] Implement pointer lookup as 5.1 spec..
Apr 7 2022, 9:01 PM · Restricted Project, Restricted Project

Apr 4 2022

ye-luo added a comment to D123093: [libomptarget] Implement pointer lookup as 5.1 spec..

Two tests array_section_use_device_ptr.c and array_section_implicit_capture.c are ported from https://reviews.llvm.org/D117997

Apr 4 2022, 3:48 PM · Restricted Project, Restricted Project
ye-luo updated the summary of D123093: [libomptarget] Implement pointer lookup as 5.1 spec..
Apr 4 2022, 3:46 PM · Restricted Project, Restricted Project
ye-luo requested review of D123093: [libomptarget] Implement pointer lookup as 5.1 spec..
Apr 4 2022, 3:45 PM · Restricted Project, Restricted Project

Mar 28 2022

ye-luo added a comment to D122592: [OpenMP] Fix library path missing when using OpenMP.

using the multiarch directory

If we can cross compile libomp and libomptarget to the target system. We may have
lib/x86_64-unknown-linux-gnu/libomp.so
lib/aarch64-unknown-linux-gnu/libomp.so
Compile clang once but compile runtime library for multiple architectures.

Mar 28 2022, 10:01 AM · Restricted Project, Restricted Project

Mar 18 2022

ye-luo added inline comments to D122014: [OpenMP][CUDA] Fix potential program crash caused by double free resources.
Mar 18 2022, 12:32 PM · Restricted Project, Restricted Project

Mar 6 2022

ye-luo added inline comments to D121056: [OpenMP][NFC] Extend the event introduction to allow wait event actions.
Mar 6 2022, 4:17 PM · Restricted Project, Restricted Project

Mar 5 2022

ye-luo requested changes to D121056: [OpenMP][NFC] Extend the event introduction to allow wait event actions.
Mar 5 2022, 6:52 PM · Restricted Project, Restricted Project

Feb 17 2022

ye-luo added a comment to D120106: [OpenMP] Add flag for disabling thread state in runtime.

Change title
threat state
to
thread state

Feb 17 2022, 10:01 PM · Restricted Project, Restricted Project

Feb 10 2022

ye-luo committed rG59ad9650cf66: [Libomptarget][AMDGCN] add gfx90c target (authored by ye-luo).
[Libomptarget][AMDGCN] add gfx90c target
Feb 10 2022, 1:56 PM
ye-luo closed D119478: [Libomptarget][AMDGCN] add gfx90c target.
Feb 10 2022, 1:56 PM · Restricted Project
ye-luo added a comment to D119478: [Libomptarget][AMDGCN] add gfx90c target.

I was using gfx902 in the past but after installing ROCm 5.0.0 today, I got a complaint and I have to use gfx90c by copying gfx902 bc files to gfx90c.
However it is better to do the right thing here.

Feb 10 2022, 1:52 PM · Restricted Project
ye-luo added a comment to D119478: [Libomptarget][AMDGCN] add gfx90c target.

ROCm 5.0.0 requires me to use this target on my 4700u

Feb 10 2022, 1:19 PM · Restricted Project
ye-luo added reviewers for D119478: [Libomptarget][AMDGCN] add gfx90c target: JonChesterfield, ronlieb.
Feb 10 2022, 1:19 PM · Restricted Project
ye-luo requested review of D119478: [Libomptarget][AMDGCN] add gfx90c target.
Feb 10 2022, 1:16 PM · Restricted Project

Jan 28 2022

ye-luo committed rGbafb6f3e9cc7: [OpenMP] disable build of old nvptx device runtime (authored by ye-luo).
[OpenMP] disable build of old nvptx device runtime
Jan 28 2022, 7:26 PM
ye-luo closed D118522: [OpenMP] disable build of old nvptx device runtime.
Jan 28 2022, 7:26 PM · Restricted Project
ye-luo added a reviewer for D118522: [OpenMP] disable build of old nvptx device runtime: JonChesterfield.
Jan 28 2022, 5:54 PM · Restricted Project
ye-luo requested review of D118522: [OpenMP] disable build of old nvptx device runtime.
Jan 28 2022, 5:53 PM · Restricted Project

Jan 24 2022

ye-luo added inline comments to D117997: [libomptarget] Correctly return the implicit device base address when the base itself has not been mapped..
Jan 24 2022, 3:00 PM · Restricted Project

Jan 23 2022

ye-luo added inline comments to D117997: [libomptarget] Correctly return the implicit device base address when the base itself has not been mapped..
Jan 23 2022, 2:02 PM · Restricted Project
ye-luo added inline comments to D117997: [libomptarget] Correctly return the implicit device base address when the base itself has not been mapped..
Jan 23 2022, 11:06 AM · Restricted Project

Jan 21 2022

ye-luo added a comment to D116908: [OpenMP][1/3] Introduce the KernelEnvironment into the device runtimes.

It sounds like such info will be passed from host to the device once per kernel and the performance impact is negligible. Right?

The information is directly baked into the device image (in form of globals).
The transfer happens as you load the image, basically a few extra bytes per kernel but we had most of the things before as separate globals already anyway.
There is no kernel start cost to speak of, at least I don't expect any.

Jan 21 2022, 5:12 PM · Restricted Project, Restricted Project
ye-luo added a comment to D116908: [OpenMP][1/3] Introduce the KernelEnvironment into the device runtimes.

It sounds like such info will be passed from host to the device once per kernel and the performance impact is negligible. Right?

Jan 21 2022, 4:19 PM · Restricted Project, Restricted Project

Jan 20 2022

ye-luo added inline comments to D113119: [OpenMP] Introduce asynchronous malloc and free.
Jan 20 2022, 1:18 PM · Restricted Project, Restricted Project
ye-luo requested changes to D113119: [OpenMP] Introduce asynchronous malloc and free.
Jan 20 2022, 10:18 AM · Restricted Project, Restricted Project

Jan 18 2022

ye-luo accepted D117627: [OpenMP] Introduce an environment variable to disable atomic map clauses.

Please update the allowed string values and also resolve conflict before landing.

Jan 18 2022, 7:33 PM · Restricted Project
ye-luo requested changes to D117627: [OpenMP] Introduce an environment variable to disable atomic map clauses.
Jan 18 2022, 6:39 PM · Restricted Project

Jan 10 2022

ye-luo accepted D116959: [DWARF] Try not to crash for codes with missing debug information.

Much appreciated. Allowing to debug the host code is already a huge plus.

Jan 10 2022, 10:40 AM · Restricted Project

Jan 8 2022

ye-luo accepted D116865: [OpenMP][FIX] Emit debug declares only if debug info is available.
Jan 8 2022, 1:59 PM · Restricted Project
ye-luo added a comment to D116865: [OpenMP][FIX] Emit debug declares only if debug info is available.

Confirm that #52938 is fixed by this patch.

Jan 8 2022, 1:59 PM · Restricted Project

Jan 4 2022

ye-luo added inline comments to D104418: [OpenMP][Offloading] Fixed data race in libomptarget caused by async data movement.
Jan 4 2022, 8:12 PM · Restricted Project
ye-luo added a comment to D104418: [OpenMP][Offloading] Fixed data race in libomptarget caused by async data movement.

add clear comments on how Event should be used in current situation.

Jan 4 2022, 7:48 PM · Restricted Project
ye-luo added inline comments to D104418: [OpenMP][Offloading] Fixed data race in libomptarget caused by async data movement.
Jan 4 2022, 7:47 PM · Restricted Project
ye-luo added inline comments to D104418: [OpenMP][Offloading] Fixed data race in libomptarget caused by async data movement.
Jan 4 2022, 6:29 PM · Restricted Project
ye-luo accepted D104418: [OpenMP][Offloading] Fixed data race in libomptarget caused by async data movement.

Renaming Event to EventH2D and also the corresponding functions are my last request. The rest looks good.

Jan 4 2022, 6:03 PM · Restricted Project
ye-luo added a comment to D104418: [OpenMP][Offloading] Fixed data race in libomptarget caused by async data movement.

I still think the new/old event exchange should be removed.
If T1 record an event for a D2H transfer and then T2 issues a H2D transfer and create an new event and then wait for the old event. the H2D or D2H may happen together when they are on two distinct streams.
This violates atomic data transfer behavior.
the solution is 1 persistent event per map and always check its status before issuing any transfer.

First, there is no event for D2H for now. This patch tries to make sure there is no race among H2D of the same memory from multiple target tasks, especially when they all read from that memory. D2H is out of the scope, and has nothing to do with the scenario mentioned in this patch. Without this patch, H2D and D2H can still happen at the same time on different streams.
Second, I think the case you describe is already data race caused by *user*. For two target tasks, if one task tries to move data in one direction while another task tries to move data in another direction, the two tasks should not run at the same time. That said, they should have dependency because one tries to read and another tries to write. Even with the "atomic" behavior you mentioned, which I didn't find it on the spec (maybe I missed it. could you pin point where it is?) it is still undetermined that which one comes first.
Third, using one event all the time sounds like a feasible solution. If an entry already has an event, we can reuse that one w/o the need to create a new one and destroy the old one, which can potentially save some overhead.

Jan 4 2022, 5:47 PM · Restricted Project
ye-luo added a comment to D104418: [OpenMP][Offloading] Fixed data race in libomptarget caused by async data movement.

I still think the new/old event exchange should be removed.
If T1 record an event for a D2H transfer and then T2 issues a H2D transfer and create an new event and then wait for the old event. the H2D or D2H may happen together when they are on two distinct streams.
This violates atomic data transfer behavior.
the solution is 1 persistent event per map and always check its status before issuing any transfer.

Jan 4 2022, 10:40 AM · Restricted Project

Jan 3 2022

ye-luo added a comment to D101109: [SLP]Improve multinode analysis..

This patch caused many test failure in my application on Power9. Although this patch sounds like affecting SLP, adding -fno-slp-vectorize doesn't improve the pass rate but changing -O3 to -O0 does.

Hi, do you have a reproducer?

Jan 3 2022, 3:21 PM · Restricted Project

Dec 29 2021

ye-luo added a comment to D101109: [SLP]Improve multinode analysis..

This patch caused many test failure in my application on Power9. Although this patch sounds like affecting SLP, adding -fno-slp-vectorize doesn't improve the pass rate but changing -O3 to -O0 does.

Dec 29 2021, 11:59 PM · Restricted Project

Dec 28 2021

ye-luo accepted D116315: [OpenMP][CUDA] Add resource pool for CUevent.

LGTM

Dec 28 2021, 2:26 PM · Restricted Project

Dec 27 2021

ye-luo added inline comments to D116315: [OpenMP][CUDA] Add resource pool for CUevent.
Dec 27 2021, 10:32 PM · Restricted Project
ye-luo added inline comments to D116315: [OpenMP][CUDA] Add resource pool for CUevent.
Dec 27 2021, 1:02 PM · Restricted Project
ye-luo added inline comments to D111954: [OpenMP][Plugin] Introduce generic resource pool.
Dec 27 2021, 8:32 AM · Restricted Project
ye-luo accepted D111954: [OpenMP][Plugin] Introduce generic resource pool.
Dec 27 2021, 8:05 AM · Restricted Project

Dec 26 2021

ye-luo added inline comments to D111954: [OpenMP][Plugin] Introduce generic resource pool.
Dec 26 2021, 7:42 PM · Restricted Project
ye-luo added inline comments to D111954: [OpenMP][Plugin] Introduce generic resource pool.
Dec 26 2021, 4:15 PM · Restricted Project

Dec 20 2021

ye-luo added inline comments to D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm.
Dec 20 2021, 12:01 AM · Restricted Project, Restricted Project, Restricted Project

Dec 16 2021

ye-luo added inline comments to D115823: [openmp][libomptarget] Introduce and call createAsyncInfo.
Dec 16 2021, 10:32 PM · Restricted Project
ye-luo added a comment to D115823: [openmp][libomptarget] Introduce and call createAsyncInfo.

I never liked init-if-passed-nullptr and prefer this explicit approach.

Dec 16 2021, 3:59 PM · Restricted Project