RWTH Aachen University
- User Since
- Apr 2 2015, 4:52 AM (229 w, 1 d)
Thu, Aug 15
LG, thanks for the changes.
Please submit the test changes unrelated to the code changes in a separate patch!
The code changes look good to me, but the test doesn't pass on x86. We've faced the same problem when clang-offload-bundler was initially committed and the current testing is the best we were able to do.
Can we close this after D65341 landed?
Wed, Aug 14
Okay, so I wasn't happy with the current explanations because I don't like "fixing" an issue without understanding the problem. Here's a small reproducer:
$ cat main.cpp #include "test.h"
Jon, please subscribe to openmp-commits so that commit emails get through immediately. Thanks!
Tue, Aug 13
Change check_c_compiler_flag() to check_cxx_compiler_flag().
Mon, Aug 12
Sun, Aug 11
Remove compiler check for -Wno-uninitialized.
Remove another unnecessary cast.
Sat, Aug 10
This test is also failing for me on CentOS 7, Intel x86. Any clues what's wrong here?
Fri, Aug 9
LG after addressing the last minor nits (comment + cast + check).
Can you please rebase on top of D66019? Sorry, that'll probably give you some conflicts :-/
Wed, Aug 7
Thanks, that's even easier than a pointer to NULL :)
Tue, Aug 6
Can you detail what "incorrect linking" means? AFAIK the additional sections were just bloating the executable, but how do they affect correctness?
The test will currently fail with older versions of Clang. It must at least be marked UNSUPPORTED for Clang versions older than what-will-be Clang 10.
Sat, Aug 3
Apologies, but I think my fix for -Wcast-qual is wrong and the code is still broken. Luckily, the latest Intel Compiler still warns about it which forced me to rethink what the pointers try to achieve.
Fri, Aug 2
I'd propose to mark the test close_modifier.c as unsupported with older compiler versions. Additionally, can you add a small, new test with manual calls to __tgt_target_data_begin / _end without relying on the compiler?
Oh, but the tests again look add. Please run them through clang-format.
Thu, Aug 1
I'm fine with the last update.
I think this still needs some work.
There's still no call to __tgt_register_requires in the two tests, so I guess they won't pass with older versions of Clang.
Wed, Jul 31
Tue, Jul 30
Mon, Jul 29
Oh, and there's still no test for use_device_ptr
I think this mostly looks good, but depends on D65001, right?
There's already D55892 with a better set of tests, including target enter data / target exit data.