Intern @ IBM Research
- User Since
- Apr 2 2015, 4:52 AM (133 w, 4 d)
Fri, Oct 20
Accepting to close
Thu, Oct 19
Abandoning as I lost interest in this.
Wed, Oct 18
Tue, Oct 17
Some more comments, there is still a lot of commented code that should be removed.
Another, higher level question: When should frame addresses be set? Currently, that's inconsistently guarded with OMPT_OPTIONAL. However, if I remember correctly this is mandatory?
Mon, Oct 16
Fri, Oct 13
Fix one more condition that checks for nvvm/libdevice and add a test.
Check that the user didn't specify a value lower than sm_30 and re-add some code as discussed.
GCC has none of these features?! I can't believe that, maybe only some older versions that don't implement OpenMP 4.x?
The changes look good, but title and summary don't describe then change?
LGTM with a comment about the error message
Thu, Oct 12
This might work for one patch but still doesn't solve the future problem, i.e. we don't want to be bound to 3.8.1 forever.
So maybe the reason for that is using different versions of clang-format? @jlpeyton can you share which version you have been using to initially format the source code?
Wed, Oct 4
Mon, Oct 2
Fri, Sep 29
Thu, Sep 28
The error with -DLLVM_USE_SANITIZER=Address is
-- Check if the system is big endian -- Searching 16 bit integer -- Looking for stddef.h -- Looking for stddef.h - not found -- Check size of unsigned short -- Check size of unsigned short - failed -- Check size of unsigned int -- Check size of unsigned int - failed -- Check size of unsigned long -- Check size of unsigned long - failed CMake Error at <...>/cmake/share/cmake-3.5/Modules/TestBigEndian.cmake:51 (message): no suitable type found Call Stack (most recent call first): projects/compiler-rt/cmake/base-config-ix.cmake:151 (TEST_BIG_ENDIAN) projects/compiler-rt/cmake/config-ix.cmake:138 (test_targets) projects/compiler-rt/CMakeLists.txt:99 (include)
Wed, Sep 27
Resigning as this isn't related to OpenMP anymore
Tue, Sep 26
Mon, Sep 25
Some remarks from a high-level look at this revision. Although it might not be possible to split the OMPT changes, any preparation change should go into separate commits.
- Separate out the changes that are not related to OMPT at all (.clang-format, kmp_task_reduction_nest.cpp)
- Deleting the old header files and restricting OMPT to OpenMP 5.0 should be doable in a separate change
- Are there any changes that are active when OMPT is disabled? We might want to discuss them on their own, all other changes are neatly hidden behind #defines
Sep 22 2017
Sep 21 2017
Aug 29 2017
- Is there as specific reason for using both puts and printf? There are also calls to printf without formatting arguments...
- Do these tests actually pass with a current version of clang?
Aug 14 2017
Aug 11 2017
Aug 10 2017
Aug 2 2017
Aug 1 2017
Given the lack of additional comments, LGTM. Please adapt the commit description to reflect the changes during review.
Jul 26 2017
I've committed the patch without an explicit answer from the IBM guys to unblock the release
Jul 23 2017
Disable building by default.