RWTH Aachen University
- User Since
- Apr 2 2015, 4:52 AM (211 w, 1 d)
So the scheme is: pow is defined in __clang_openmp_math.h to call __kmpc_pow. This lives in libomptarget-nvptx (both bc and static lib) and just calls pow which works because nvcc and Clang in CUDA mode make sure that the call gets routed into libdevice?
Why is it enough to have one counter per warp, what happens if threads within a warp diverge? Before D55773 we had a counter per thread...
Mon, Apr 15
Sat, Apr 13
Thu, Apr 11
Fri, Apr 5
Tue, Apr 2
AFAICS all comments were addressed and this looks good. Please wait a day or so in case I missed something
I guess that change makes sense overall, some comments from reading the code inline. I didn't apply the patch locally so I might be missing some context here...
Wed, Mar 27
Most of the changes look pretty straight forward to me, but I currently don't have time to read through the assembly implementation of __kmp_invoke_microtask. I left two comments inline to discuss compressed vs uncompressed encodings for testing OMPT.
Sun, Mar 24
The code in cmake/OpenMPTesting.cmake should also handle standalone builds of openmp.
Mar 17 2019
Mar 15 2019
Okay, the test failure is related to my Intel Westmere system (yeah, that's old, I know) where I see:
b = 0x13c0 kBmi12Mask = 0x108
Even the "corrected" code only checked that at least one bit is set :-(
Mar 13 2019
Mar 12 2019
Hi Doru, I think this patch is not yet in trunk? Additionally I'm seeing the same warnings when compiling with nvcc which doesn't seem addressed here. Should we pass -std=c++11 when compiling the CUDA code as well?
Ping. As I said I think the current approach with a fixed-size buffer makes sense because anything larger likely won't work anyhow.
Mar 11 2019
I think the change is correct, but I don't know enough of the code to feel confident.
Mar 10 2019
The added test is failing for me because I'm building (and testing) compiler-rt with Clang 7 which doesn't instrument BMI, and I'd assume the same with Clang 8 once released. Is that an oversight or is this configuration expected to break?
Mar 6 2019
Mar 5 2019
Mar 4 2019
Mar 3 2019
Move common ELF description to Inputs/.
Mar 2 2019
Replace llvm_unreachables in Object/ELF.cpp by break statements and add test to exercise this code path.
Mar 1 2019
I think this patch is right in also sorting the function names: AFAICS StringMap doesn't provide that guarantee.
Feb 28 2019
I don't care how this is solved, but it needs to be solved! And it's not getting easier with everyone saying something different
Feb 26 2019
Ping, that's now the only test that fails the reverse-iteration bot...
Feb 21 2019
Would it make sense to rename the builder? lldb-amd64-ninja-netbsd8 is just not true based on that list. IIRC there are other unified bots, that test a variety of projects?
Feb 19 2019
LG if that fixes the problem. For the record llvm/runtimes/ does the same.
Feb 17 2019
@phosek Sorry for the breakage. I guess there are just too many configurations for non-trivial changes to the build system :-/
I needed to push rCRT354231 to fix the sanitizer bots. Let me know if this change is appropriate or want me to revert. In that case we need to run another round of clobber builds to fix CMake configuration (needed because the patch changes the source directory for ExternalProject_Add).
Feb 16 2019
Feb 15 2019
Revert changes to CMAKE_THREAD_LIBS_INIT.
I had to revert this in r354153 because it breaks sanitizer-x86_64-linux: