Page MenuHomePhabricator

Hahnfeld (Jonas Hahnfeld)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 2 2015, 4:52 AM (211 w, 1 d)
RWTH Aachen University

Recent Activity

Today

Hahnfeld added a comment to D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading.

So the scheme is: pow is defined in __clang_openmp_math.h to call __kmpc_pow. This lives in libomptarget-nvptx (both bc and static lib) and just calls pow which works because nvcc and Clang in CUDA mode make sure that the call gets routed into libdevice?

Sat, Apr 20, 12:31 AM · Restricted Project
Hahnfeld added a comment to D60918: [OPENMP][NVPTX]Correctly handle L2 parallelism in SPMD mode..

Why is it enough to have one counter per warp, what happens if threads within a warp diverge? Before D55773 we had a counter per thread...

Sat, Apr 20, 12:20 AM · Restricted Project

Mon, Apr 15

Hahnfeld added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

So, the test is good or I should put it into some other directory?

@Hahnfeld , libomptarget/deviceRTLs/nvptx/test/parallel works for you for now, correct?

Mon, Apr 15, 12:57 PM · Restricted Project
Hahnfeld added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

In that case these tests need to be marked UNSUPPORTED for versions of Clang that will not pass them. There's infrastructure for that, but it's not applied in the current form of this patch.

Okay. This patch review is not the right place to discuss the libomptarget support for old Clang versions. We should have a separate thread on this subject.

In any case, let's move forward with adding this test in that directory, and then we'll address the infrastructure issue as follow-up work.

So put differently, you're proposing to land this in its current form (which will break for some users, including me) and wait for "somebody" to work on the infrastructure to fix things?

Of course I'm not. I'm proposing that we put the test in the nvptx directory and then address the fact that it should apply to other offloading targets as follow up.

Mon, Apr 15, 11:44 AM · Restricted Project
Hahnfeld added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

What check command do you run to run these nvptx tests?

Mon, Apr 15, 1:18 AM · Restricted Project

Sat, Apr 13

Hahnfeld added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

I think we need to be careful about adding nvptx tests to libomptarget/test: They can be executed using Clang later than 6.0.0, but that version wasn't able to offload to GPUs. Given that the changes are limited to libomptarget-nvptx (because its parallelism is kind of special), I think the new test should go to libomptarget/deviceRTLs/nvptx/test. Just my 2 cents...

I don't see anything in this test that is nvptx specific. Is there something about the semantics that make it specific to nvptx? We need to build of a suite of tests for accelerator offloading in general. We'll have other accelerator backends (e.g., for AMD GPUs), and the offloading tests should apply to them too.

Sat, Apr 13, 6:04 AM · Restricted Project
Hahnfeld added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

Our general policy is that all commits that can have tests, should have tests. We have OpenMP target tests in libomptarget/test -- and given that you've added tests there yourself, I assume that you know this ;) -- plus tests in libomptarget/deviceRTLs/nvptx/test - although it sounds like this situation can be triggered using portable code, so I'd prefer we add a test in libomptarget/test. Can you please do that?

Sure, if we have a testing infrastructure for this, I'll add the test. Just missed the tests for NVPTX, will definitely add it.

Sat, Apr 13, 2:02 AM · Restricted Project

Thu, Apr 11

Hahnfeld added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

Why don't we have unit tests here or in the llvm-test suite?

Because this is the library. Do you have an idea how to write the unit tests for it? It can be tested only with the executable tests. I know, that someone worked on the target-based testsuite, but don't know when it is going to be ready.

Thu, Apr 11, 11:22 PM · Restricted Project

Fri, Apr 5

Hahnfeld added inline comments to D59451: Fix gettid warnings and one test on FreeBSD.
Fri, Apr 5, 2:13 PM · Restricted Project, Restricted Project

Tue, Apr 2

Hahnfeld accepted D59451: Fix gettid warnings and one test on FreeBSD.

AFAICS all comments were addressed and this looks good. Please wait a day or so in case I missed something

Tue, Apr 2, 2:02 PM · Restricted Project, Restricted Project
Hahnfeld accepted D60114: [CMake] Differentiate between static and shared libc++abi.
Tue, Apr 2, 1:52 PM · Restricted Project
Hahnfeld added a comment to D60114: [CMake] Differentiate between static and shared libc++abi.

I guess that change makes sense overall, some comments from reading the code inline. I didn't apply the patch locally so I might be missing some context here...

Tue, Apr 2, 5:41 AM · Restricted Project
Hahnfeld added inline comments to D59451: Fix gettid warnings and one test on FreeBSD.
Tue, Apr 2, 5:31 AM · Restricted Project, Restricted Project

Wed, Mar 27

Hahnfeld added a comment to D59880: [OpenMP][WIP] RISCV64 port.

Most of the changes look pretty straight forward to me, but I currently don't have time to read through the assembly implementation of __kmp_invoke_microtask. I left two comments inline to discuss compressed vs uncompressed encodings for testing OMPT.

Wed, Mar 27, 8:20 AM · Restricted Project

Sun, Mar 24

Hahnfeld requested changes to D59451: Fix gettid warnings and one test on FreeBSD.

The code in cmake/OpenMPTesting.cmake should also handle standalone builds of openmp.

Sun, Mar 24, 9:49 AM · Restricted Project, Restricted Project

Mar 17 2019

Hahnfeld updated subscribers of D59451: Fix gettid warnings and one test on FreeBSD.

I'm not sure about OMP specifics, but in C++ threads we are allowed to use threading routines but in order to make them functional we must link final executable with libpthread.

On NetBSD threading is in a separate library out of libc.

So if a developer uses a feature from stdlib, they need to manually link libpthread? I always thought that the C++ standard guarantees you a fully working stdlib out of the box, but might be wrong here.

Mar 17 2019, 5:31 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D59451: Fix gettid warnings and one test on FreeBSD.

I'm not sure about OMP specifics, but in C++ threads we are allowed to use threading routines but in order to make them functional we must link final executable with libpthread.

On NetBSD threading is in a separate library out of libc.

Mar 17 2019, 4:42 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D59451: Fix gettid warnings and one test on FreeBSD.
In D59451#1432251, @dim wrote:

This code does not directly use pthreads, but uses C++11 threads.
Why does the compiler not link the necessary threading library, when using C++11 threads?

How would the compiler know up-front what is in the code? I have not often seen compilers that influence linking flags from the code that was compiled, unless maybe the Microsoft specific #pragma lib feature (which somebody is now adding to clang, I believe). Usually, these kinds of flags are specified by the user, and passed from the frontend to the linker.

Mar 17 2019, 4:36 AM · Restricted Project, Restricted Project
Hahnfeld updated subscribers of D57571: [clang-tidy] A new OpenMP module.
Mar 17 2019, 4:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 15 2019

Hahnfeld committed rG77eccf24d5c9: [msan] Fix BMI2 detection in msan tests, take 2. (authored by Hahnfeld).
[msan] Fix BMI2 detection in msan tests, take 2.
Mar 15 2019, 3:19 AM
Hahnfeld committed rCRT356242: [msan] Fix BMI2 detection in msan tests, take 2..
[msan] Fix BMI2 detection in msan tests, take 2.
Mar 15 2019, 3:19 AM
Hahnfeld committed rL356242: [msan] Fix BMI2 detection in msan tests, take 2..
[msan] Fix BMI2 detection in msan tests, take 2.
Mar 15 2019, 3:19 AM
Hahnfeld added a comment to D58858: [msan] Instrument x86 BMI intrinsics..

Okay, the test failure is related to my Intel Westmere system (yeah, that's old, I know) where I see:

b = 0x13c0
kBmi12Mask = 0x108

Even the "corrected" code only checked that at least one bit is set :-(

Mar 15 2019, 3:19 AM · Restricted Project, Restricted Project

Mar 13 2019

Hahnfeld added a comment to D45691: [mips] Use libatomic instead of GCC intrinsics for 64bit.

Please note this change set broke the following buildbot and has yet to be fixed: http://lab.llvm.org:8011/builders/openmp-clang-ppc64le-linux-rhel/builds/140

Mar 13 2019, 10:22 AM · Restricted Project
Hahnfeld added a comment to D58858: [msan] Instrument x86 BMI intrinsics..

I'm running that configuration for years and it always worked. Do you have a change at hand that did such compiler change?

Do you run msan lit tests? This is an example where new compiler behavior is tested the same change list, less than a year ago:
https://reviews.llvm.org/rL332761

Mar 13 2019, 3:53 AM · Restricted Project, Restricted Project
Hahnfeld committed rGc64d73cce240: [ELF] Fix GCC8 warnings about "fall through", NFCI (authored by Hahnfeld).
[ELF] Fix GCC8 warnings about "fall through", NFCI
Mar 13 2019, 3:39 AM
Hahnfeld committed rGe59746f8f823: [Support] Treat truncation of fullpath as error (authored by Hahnfeld).
[Support] Treat truncation of fullpath as error
Mar 13 2019, 3:39 AM
Hahnfeld committed rL356037: [ELF] Fix GCC8 warnings about "fall through", NFCI.
[ELF] Fix GCC8 warnings about "fall through", NFCI
Mar 13 2019, 3:38 AM
Hahnfeld closed D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI.
Mar 13 2019, 3:38 AM · Restricted Project
Hahnfeld committed rL356036: [Support] Treat truncation of fullpath as error.
[Support] Treat truncation of fullpath as error
Mar 13 2019, 3:38 AM
Hahnfeld closed D58835: [Support] Treat truncation of fullpath as error.
Mar 13 2019, 3:38 AM · Restricted Project

Mar 12 2019

Herald added a project to D55772: [OpenMP][libomptarget] Suppress C++ 11 related warnings when building libomptarget-nvptx bitcode library: Restricted Project.

Hi Doru, I think this patch is not yet in trunk? Additionally I'm seeing the same warnings when compiling with nvcc which doesn't seem addressed here. Should we pass -std=c++11 when compiling the CUDA code as well?

Mar 12 2019, 4:23 AM · Restricted Project
Hahnfeld added inline comments to D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI.
Mar 12 2019, 4:15 AM · Restricted Project
Hahnfeld added a comment to D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI.

Gentle ping

Mar 12 2019, 2:57 AM · Restricted Project
Hahnfeld added a comment to D58835: [Support] Treat truncation of fullpath as error.

Ping. As I said I think the current approach with a fixed-size buffer makes sense because anything larger likely won't work anyhow.

Mar 12 2019, 2:57 AM · Restricted Project
Hahnfeld added a comment to D58858: [msan] Instrument x86 BMI intrinsics..

This is expected to break. I'm surprised it did not break earlier - we often do a compiler change and corresponding integration tests in compiler-rt as a single commit, or two consecutive commits.

Mar 12 2019, 2:00 AM · Restricted Project, Restricted Project

Mar 11 2019

Hahnfeld added a comment to D58959: [DebugInfo][ExecutionEngine] follow up for "add SectionedAddress to DebugInfo interfaces".

I think the change is correct, but I don't know enough of the code to feel confident.

Mar 11 2019, 3:08 AM · Restricted Project

Mar 10 2019

Hahnfeld added a comment to D58858: [msan] Instrument x86 BMI intrinsics..

The added test is failing for me because I'm building (and testing) compiler-rt with Clang 7 which doesn't instrument BMI, and I'd assume the same with Clang 8 once released. Is that an oversight or is this configuration expected to break?

Mar 10 2019, 4:31 AM · Restricted Project, Restricted Project

Mar 6 2019

Hahnfeld added a comment to D58801: [Support] Implement is_local_impl with AIX mntctl.

Ping. I am looking for some input on whether we want to pursue additional testing.

Mar 6 2019, 11:33 AM · Restricted Project

Mar 5 2019

Hahnfeld added inline comments to D58959: [DebugInfo][ExecutionEngine] follow up for "add SectionedAddress to DebugInfo interfaces".
Mar 5 2019, 10:08 AM · Restricted Project

Mar 4 2019

Hahnfeld committed rG65a401f6a90f: [AArch64/ARM] Fix two compiler warnings in InstructionSelector, NFCI (authored by Hahnfeld).
[AArch64/ARM] Fix two compiler warnings in InstructionSelector, NFCI
Mar 4 2019, 12:51 AM
Hahnfeld committed rL355304: [AArch64/ARM] Fix two compiler warnings in InstructionSelector, NFCI.
[AArch64/ARM] Fix two compiler warnings in InstructionSelector, NFCI
Mar 4 2019, 12:51 AM
Hahnfeld closed D58834: [AArch64/ARM] Fix two compiler warnings in InstructionSelector, NFCI.
Mar 4 2019, 12:50 AM · Restricted Project

Mar 3 2019

Hahnfeld added inline comments to D58835: [Support] Treat truncation of fullpath as error.
Mar 3 2019, 12:44 PM · Restricted Project
Hahnfeld added inline comments to D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI.
Mar 3 2019, 7:11 AM · Restricted Project
Hahnfeld updated the diff for D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI.

Move common ELF description to Inputs/.

Mar 3 2019, 7:11 AM · Restricted Project
Hahnfeld added inline comments to D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI.
Mar 3 2019, 4:44 AM · Restricted Project

Mar 2 2019

Hahnfeld requested review of D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI.

I think we could just add a break and handle that case in the generic switch below. But I think you're right, the current patch would break for Hexagon, MIPS and PPC64. I tested with assertions enabled, but maybe there is no test case exercising this code path?

Yes. For this patch using break; should be good enough. There may not be tests for such corrupted binaries.

Mar 2 2019, 7:54 AM · Restricted Project
Hahnfeld updated the diff for D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI.

Replace llvm_unreachables in Object/ELF.cpp by break statements and add test to exercise this code path.

Mar 2 2019, 7:54 AM · Restricted Project
Hahnfeld added a comment to D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI.

getDynamicTagAsString is used by llvm-objdump and it'd be better if llvm-objdump can parse some malformed binaries (with bad .dynsym). If the tag is unknown, falling back to the default label (return "<unknown:>0x"...) may make more sense.

Mar 2 2019, 12:41 AM · Restricted Project

Mar 1 2019

Hahnfeld created D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI.
Mar 1 2019, 10:29 AM · Restricted Project
Hahnfeld created D58835: [Support] Treat truncation of fullpath as error.
Mar 1 2019, 10:26 AM · Restricted Project
Hahnfeld created D58834: [AArch64/ARM] Fix two compiler warnings in InstructionSelector, NFCI.
Mar 1 2019, 10:22 AM · Restricted Project
Hahnfeld committed rGe071cd86dfc7: Hide two unused debugging methods, NFCI. (authored by Hahnfeld).
Hide two unused debugging methods, NFCI.
Mar 1 2019, 9:17 AM
Hahnfeld committed rL355205: Hide two unused debugging methods, NFCI..
Hide two unused debugging methods, NFCI.
Mar 1 2019, 9:14 AM
Hahnfeld added a comment to D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism.

I think this patch is right in also sorting the function names: AFAICS StringMap doesn't provide that guarantee.

Mar 1 2019, 3:59 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D56286: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for PowerPC..

Is this STW instruction something that instruction scheduling might move? (@nemanjai ?)

I am fairly certain that the STW is the store of the value returned by the function so the scheduler should leave it alone. Perhaps @stefanp can verify this.

Mar 1 2019, 3:31 AM · Restricted Project, Restricted Project
Hahnfeld added inline comments to D58533: [hwasan, asan] Intercept vfork..
Mar 1 2019, 3:27 AM · Restricted Project, Restricted Project
Hahnfeld abandoned D58787: [ProfileData] Sort ProfilingData by hash.
Mar 1 2019, 1:21 AM · Restricted Project
Hahnfeld abandoned D58385: [tools] Rewrite tests for symbol remapping to FileCheck.
Mar 1 2019, 1:21 AM · Restricted Project

Feb 28 2019

Hahnfeld added a comment to D58787: [ProfileData] Sort ProfilingData by hash.

I don't care how this is solved, but it needs to be solved! And it's not getting easier with everyone saying something different

Feb 28 2019, 10:49 AM · Restricted Project
Hahnfeld added a comment to D58787: [ProfileData] Sort ProfilingData by hash.

The secondary map 'ProfileData' is needed occasionally (to use cfg hash). doing sorting with std::map is not needed strictly speaking, but it has the nice property of having fixed order.

Feb 28 2019, 9:17 AM · Restricted Project
Hahnfeld added a comment to D58787: [ProfileData] Sort ProfilingData by hash.

Have you considered only imposing the ordering/sorting where it matters,
i.e. i think where FunctionData is used in InstrProfWriter::writeImpl() and InstrProfWriter::writeText()?

Feb 28 2019, 9:08 AM · Restricted Project
Hahnfeld added a comment to D58385: [tools] Rewrite tests for symbol remapping to FileCheck.

Another approach would be to sort the output and make it independent from reverse-iteration. See D58631 for how this was done for ThinLTO. I'm fine with whatever unbreaks the tests, but I'm not familiar with the code so "fixing" the tests and getting review on this was easier for me.

Feb 28 2019, 8:41 AM · Restricted Project
Hahnfeld created D58787: [ProfileData] Sort ProfilingData by hash.
Feb 28 2019, 8:40 AM · Restricted Project
Hahnfeld added inline comments to D58533: [hwasan, asan] Intercept vfork..
Feb 28 2019, 6:52 AM · Restricted Project, Restricted Project

Feb 26 2019

Hahnfeld added a comment to D58385: [tools] Rewrite tests for symbol remapping to FileCheck.

Ping, that's now the only test that fails the reverse-iteration bot...

This seems to only shuffle the tests around.
Does this now pass in reverse-iteration config?

Yes, I've tested this locally. The idea for instr-remap.test is to invoke FileCheck three times, checking each function separately.

So then i think i'm missing the point..

If it currently passes without reverse iteration, and does not pass with reverse iteration,
then that means there is some nondeterminism, correct?

Feb 26 2019, 6:40 AM · Restricted Project
Hahnfeld added a comment to D58385: [tools] Rewrite tests for symbol remapping to FileCheck.

Ping, that's now the only test that fails the reverse-iteration bot...

This seems to only shuffle the tests around.
Does this now pass in reverse-iteration config?

Feb 26 2019, 6:23 AM · Restricted Project
Hahnfeld added a comment to D58385: [tools] Rewrite tests for symbol remapping to FileCheck.

Ping, that's now the only test that fails the reverse-iteration bot...

Feb 26 2019, 6:12 AM · Restricted Project
Hahnfeld abandoned D58384: [ThinLTO] Fix test with reverse-iteration.

Closing after D58631 landed which fixes both the bot and passes in my local build. Thanks @evgeny777!

Feb 26 2019, 6:09 AM · Restricted Project

Feb 21 2019

Hahnfeld added a comment to D58505: [zorg] netbsd: Update project list, rename and move to toolchain category.

Would it make sense to rename the builder? lldb-amd64-ninja-netbsd8 is just not true based on that list. IIRC there are other unified bots, that test a variety of projects?

Apparently Fuchsia has one, and puts it in 'toolchain' category. Maybe we should just name it 'amd64-ninja-netbsd8' or 'netbsd8-amd64-ninja'. Are you maybe aware if rename is something that can be done lightly in zorg, or does it require some extra work?

If we are going to rename it, we probably shall go for netbsd-amd64-tnf.

ninja` is just unimportant detail today it used to be interesting in the time of autoconf vs ninja option (and one worked better than the other), later we might switch to something else and just follow upstream without making non-default options.

netbsd8 soon won't be true once we will upgrade to the -9 branch (or 9.99.x).

tnf specifies hosting by The NetBSD Foundation and a magic shortcut to distinguish it from other potential bots hosted by someone else.

Feb 21 2019, 7:04 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D58505: [zorg] netbsd: Update project list, rename and move to toolchain category.

Would it make sense to rename the builder? lldb-amd64-ninja-netbsd8 is just not true based on that list. IIRC there are other unified bots, that test a variety of projects?

Apparently Fuchsia has one, and puts it in 'toolchain' category. Maybe we should just name it 'amd64-ninja-netbsd8' or 'netbsd8-amd64-ninja'. Are you maybe aware if rename is something that can be done lightly in zorg, or does it require some extra work?

Feb 21 2019, 6:59 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D58505: [zorg] netbsd: Update project list, rename and move to toolchain category.

Would it make sense to rename the builder? lldb-amd64-ninja-netbsd8 is just not true based on that list. IIRC there are other unified bots, that test a variety of projects?

Feb 21 2019, 6:35 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D58454: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures.

This should be fixed in rOMP354572. As a bot owner, could you please make sure that the bot lists the commits to openmp? Otherwise it's hard to detect broken bots without emails.

If I only knew how, I'd have fixed that long ago.

Feb 21 2019, 6:04 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D58454: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures.
Feb 21 2019, 5:46 AM · Restricted Project, Restricted Project
Hahnfeld committed rGdb3025ad57f1: [OpenMP] Fix check-openmp after r354553 (authored by Hahnfeld).
[OpenMP] Fix check-openmp after r354553
Feb 21 2019, 4:01 AM
Hahnfeld committed rOMP354572: [OpenMP] Fix check-openmp after r354553.
[OpenMP] Fix check-openmp after r354553
Feb 21 2019, 4:00 AM
Hahnfeld committed rL354572: [OpenMP] Fix check-openmp after r354553.
[OpenMP] Fix check-openmp after r354553
Feb 21 2019, 4:00 AM

Feb 19 2019

Herald added a project to D51470: Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files.: Restricted Project.

This commit made the reverse-iteration bot (http://lab.llvm.org:8011/builders/reverse-iteration) red (red since 6 months now) :

Feb 19 2019, 7:30 AM · Restricted Project
Hahnfeld created D58385: [tools] Rewrite tests for symbol remapping to FileCheck.
Feb 19 2019, 7:28 AM · Restricted Project
Hahnfeld created D58384: [ThinLTO] Fix test with reverse-iteration.
Feb 19 2019, 7:28 AM · Restricted Project
Hahnfeld accepted D58372: [compiler-rt][CMake] Set project for the custom libc++.

LG if that fixes the problem. For the record llvm/runtimes/ does the same.

Feb 19 2019, 12:04 AM · Restricted Project, Restricted Project

Feb 17 2019

Hahnfeld added a comment to D58333: [libcxxabi][CMake] Drop unused HandleOutOfTreeLLVM include.

This is an alternative to D58331 which is an attempt at resolving the breakage introduced in D58013. I think this is a better solution than D58331.

Feb 17 2019, 11:59 PM · Restricted Project
Hahnfeld added a comment to D58013: [compiler-rt] Build custom libcxx with libcxxabi.

@phosek Sorry for the breakage. I guess there are just too many configurations for non-trivial changes to the build system :-/

Feb 17 2019, 11:48 PM · Restricted Project, Restricted Project
Hahnfeld added a comment to D58013: [compiler-rt] Build custom libcxx with libcxxabi.

I needed to push rCRT354231 to fix the sanitizer bots. Let me know if this change is appropriate or want me to revert. In that case we need to run another round of clobber builds to fix CMake configuration (needed because the patch changes the source directory for ExternalProject_Add).

Feb 17 2019, 1:07 PM · Restricted Project, Restricted Project
Hahnfeld committed rG0a9cb239a6c9: [compiler-rt] Fix broken sanitizer bots (hopefully) (authored by Hahnfeld).
[compiler-rt] Fix broken sanitizer bots (hopefully)
Feb 17 2019, 10:48 AM
Hahnfeld committed rCRT354231: [compiler-rt] Fix broken sanitizer bots (hopefully).
[compiler-rt] Fix broken sanitizer bots (hopefully)
Feb 17 2019, 10:47 AM
Hahnfeld committed rL354231: [compiler-rt] Fix broken sanitizer bots (hopefully).
[compiler-rt] Fix broken sanitizer bots (hopefully)
Feb 17 2019, 10:47 AM
Hahnfeld committed rCXX354212: [compiler-rt] Build custom libcxx with libcxxabi.
[compiler-rt] Build custom libcxx with libcxxabi
Feb 17 2019, 4:32 AM
Hahnfeld committed rCXXA354212: [compiler-rt] Build custom libcxx with libcxxabi.
[compiler-rt] Build custom libcxx with libcxxabi
Feb 17 2019, 4:19 AM
Hahnfeld committed rG66c60d9d714b: [compiler-rt] Build custom libcxx with libcxxabi (authored by Hahnfeld).
[compiler-rt] Build custom libcxx with libcxxabi
Feb 17 2019, 4:17 AM
Hahnfeld committed rL354212: [compiler-rt] Build custom libcxx with libcxxabi.
[compiler-rt] Build custom libcxx with libcxxabi
Feb 17 2019, 4:16 AM
Hahnfeld committed rCRT354212: [compiler-rt] Build custom libcxx with libcxxabi.
[compiler-rt] Build custom libcxx with libcxxabi
Feb 17 2019, 4:16 AM
Hahnfeld closed D58013: [compiler-rt] Build custom libcxx with libcxxabi.
Feb 17 2019, 4:16 AM · Restricted Project, Restricted Project

Feb 16 2019

Hahnfeld committed rGa05d442391de: [compiler-rt] Cleanup usage of C++ ABI library (authored by Hahnfeld).
[compiler-rt] Cleanup usage of C++ ABI library
Feb 16 2019, 12:36 AM
Hahnfeld committed rCRT354198: [compiler-rt] Cleanup usage of C++ ABI library.
[compiler-rt] Cleanup usage of C++ ABI library
Feb 16 2019, 12:35 AM
Hahnfeld committed rL354198: [compiler-rt] Cleanup usage of C++ ABI library.
[compiler-rt] Cleanup usage of C++ ABI library
Feb 16 2019, 12:35 AM
Hahnfeld closed D58012: [compiler-rt] Cleanup usage of C++ ABI library.
Feb 16 2019, 12:35 AM · Restricted Project, Restricted Project

Feb 15 2019

Hahnfeld updated the diff for D58012: [compiler-rt] Cleanup usage of C++ ABI library.

Revert changes to CMAKE_THREAD_LIBS_INIT.

Feb 15 2019, 12:57 PM · Restricted Project, Restricted Project
Hahnfeld reopened D58012: [compiler-rt] Cleanup usage of C++ ABI library.

I had to revert this in r354153 because it breaks sanitizer-x86_64-linux:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/19915

Feb 15 2019, 10:27 AM · Restricted Project, Restricted Project