RWTH Aachen University
- User Since
- Apr 2 2015, 4:52 AM (159 w, 4 d)
Do we really want to call this tool Archer? I understand that it was written for that purpose but IMO this can serve a much more general purpose, even without the Archer "framework" around it.
Fri, Apr 20
Thu, Apr 19
Move module ID to corresponding else branch.
Move FunctionTypes to methods and change test prefixes.
Ideally, this problem was already solved by other standards. Can we reuse C11 or even C++ atomics? In the future this would also eliminate memory barriers, but such change will require some amount of thinking and testing.
Wed, Apr 18
Fri, Apr 13
Wed, Apr 11
Tue, Apr 10
Mon, Apr 9
Correct test check prefix.
Sorry for the long delay. This update rebases the patch against current trunk and adapts the regression test.
Sun, Apr 8
Sat, Apr 7
Can this revision be split further? The summary mentions many things that might make up multiple independent changes...
Thu, Apr 5
Some comments inline, mostly minor things.
Wed, Apr 4
Tue, Apr 3
I'm not sure what cases this helps as the code already uses CMAKE_CXX_COMPILER that the user specified. We had a very long discussion during the initial check-in of libomptarget, please do read that.
Post-commit because your commit didn't trigger an email (please subscribe to openmp-commits!).
Mar 21 2018
Hmm, that's basically duplicating the test case. Maybe you can #include "../throw_invoke_test.cc"?
Mar 15 2018
Will this be defined in the next revisions of the standard? I remember OpenMP 4.5 being unclear about these cases.
Mar 10 2018
Mar 9 2018
Mar 7 2018
These are two changes and need to be two patches.
Mar 5 2018
Mar 2 2018
Mar 1 2018
Feb 28 2018
Feb 24 2018
You should probably explain why each task is in its own single region and why that works as discussed internally.
Feb 23 2018
This test doesn't work if threads are not scheduled as expected: http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/58
I think in that case a worker thread started before the second master which makes sense as there is no synchronization between the two initial threads. We should be able to fix this by either starting a serialized region or calling an API function and putting an OMPT_WAIT before the real parallel region. Thoughts?
Move state change to omp_state_overhead as requested, collapse one if and add check for ompt_enabled.enabled to the other, drop argument checking from CHECK prefix.
Ping, anything else left?
Feb 22 2018
Feb 20 2018
Feb 19 2018
Feb 17 2018
Not needed anymore.
Let's start with the obvious points:
- The latest patch clearly wasn't run through clang-format.
- It only has some 90 lines of context which makes it look like you deleted quite some code when browsing through the history.
- This patch is still large, did you at least consider splitting it as I proposed some weeks ago?
Looking more closely at the patch, this doesn't seem to look into the lib / lib64 next to the compiler. I'm not sure if LIBRARY_PATH is set for every installation, so I think we should add this one to catch the obvious case. This probably needs some attention for the tests because they'll find the just-built libraries...