Page MenuHomePhabricator

Hahnfeld (Jonas Hahnfeld)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 2 2015, 4:52 AM (373 w, 2 d)

Recent Activity

Wed, May 11

Hahnfeld committed rGe451d552348b: [ORC] Fix sorting of contructors by priority (authored by Hahnfeld).
[ORC] Fix sorting of contructors by priority
Wed, May 11, 12:15 AM · Restricted Project, Restricted Project
Hahnfeld closed D123311: [ORC] Fix sorting of contructors by priority.
Wed, May 11, 12:14 AM · Restricted Project, Restricted Project

Apr 20 2022

Hahnfeld added a comment to D123311: [ORC] Fix sorting of contructors by priority.

ping @lhames

Apr 20 2022, 8:55 AM · Restricted Project, Restricted Project

Apr 9 2022

Hahnfeld committed rGe4903d8be399: [CUDA/HIP] Remove argument from module ctor/dtor signatures (authored by Hahnfeld).
[CUDA/HIP] Remove argument from module ctor/dtor signatures
Apr 9 2022, 3:39 AM · Restricted Project, Restricted Project
Hahnfeld closed D123370: [CUDA/HIP] Remove argument from module ctor/dtor signatures.
Apr 9 2022, 3:39 AM · Restricted Project, Restricted Project

Apr 8 2022

Hahnfeld requested review of D123370: [CUDA/HIP] Remove argument from module ctor/dtor signatures.
Apr 8 2022, 1:58 AM · Restricted Project, Restricted Project

Apr 7 2022

Hahnfeld requested review of D123311: [ORC] Fix sorting of contructors by priority.
Apr 7 2022, 7:24 AM · Restricted Project, Restricted Project

Mar 31 2022

Hahnfeld added a comment to D119096: [llvm] [Debuginfod] Remove `llvm-debuginfod-find` lit tests that used python http server..

I don't know if simply removing the tests is the right course of action, but yes I'd really love to get a clean check-all with Python 3.6

Mar 31 2022, 11:43 PM · Restricted Project, Restricted Project
Herald added a project to D112759: [llvm] [Debuginfo] Add llvm-debuginfod-find tool and end-to-end-tests.: Restricted Project.

The test still doesn't work for me on Python 3.6 because ThreadingHTTPServer was apparently introduced with Python 3.7.

Sorry again about this!
This will be fixed by D119096.

Mar 31 2022, 6:12 AM · Restricted Project, Restricted Project

Mar 11 2022

Herald added a project to D103052: Do not patch FDE symbols in RuntimeDyld, on targets that use non-absolute symbol relocations in `.eh_frame`: Restricted Project.

Any updates on this, do you plan to eventually land this change? FWIW this solves one third of https://github.com/llvm/llvm-project/issues/49036

Mar 11 2022, 7:35 AM · Restricted Project, Restricted Project, Restricted Project

Jan 26 2022

Hahnfeld added a comment to D112759: [llvm] [Debuginfo] Add llvm-debuginfod-find tool and end-to-end-tests..

The test still doesn't work for me on Python 3.6 because ThreadingHTTPServer was apparently introduced with Python 3.7.

Jan 26 2022, 1:05 AM · Restricted Project, Restricted Project

Nov 22 2021

Hahnfeld added reviewers for D114326: Update the list of CUDA versions up to 11.5: tra, Hahnfeld.
Nov 22 2021, 12:20 AM · Restricted Project

Nov 8 2021

Hahnfeld added a comment to D113249: [CUDA] Bump CUDA version to 11.5.

@Hahnfeld Are you satisfied with the replies to your questions? If so I can go ahead and merge.

Nov 8 2021, 11:49 PM · Restricted Project, Restricted Project

Nov 5 2021

Hahnfeld added a comment to D113249: [CUDA] Bump CUDA version to 11.5.

Experimental support for __int128 is new in CUDA 11.5, not sure if Clang enables this for CUDA. The release notes also specify

builtin_assume can now be used to specify address space to allow for efficient loads and stores.

Nov 5 2021, 10:44 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D113249: [CUDA] Bump CUDA version to 11.5.

I'm not sure if it's actually correct to advertise full support for CUDA 11.5, but I didn't look into exact changes since 11.4

Nov 5 2021, 2:24 AM · Restricted Project, Restricted Project

Oct 25 2021

Hahnfeld accepted D111895: [OpenMP][Tools] Add omp_all_memory support for Archer.

Sorry for the delay, looks good to me!

Oct 25 2021, 11:26 AM · Restricted Project

Sep 6 2021

Hahnfeld added a comment to D107049: [clang-repl] Re-implement clang-interpreter as a test case..
Sep 6 2021, 2:22 AM · Restricted Project

Aug 25 2021

Hahnfeld committed rGea08c4cd1c08: [CUDA] Fix static device variables with -fgpu-rdc (authored by Hahnfeld).
[CUDA] Fix static device variables with -fgpu-rdc
Aug 25 2021, 12:33 AM
Hahnfeld closed D108456: [CUDA] Fix static device variables with -fgpu-rdc.
Aug 25 2021, 12:32 AM · Restricted Project

Aug 21 2021

Hahnfeld added inline comments to D108456: [CUDA] Fix static device variables with -fgpu-rdc.
Aug 21 2021, 8:26 AM · Restricted Project

Aug 20 2021

Hahnfeld added a comment to D108404: [libomptarget][amdcgn] Add build dependency for llvm-link and opt.

Reading the ninja file to determine what cmake's dependency graph looked like is a great idea. Going to use that in future, thanks for the comment!

Aug 20 2021, 5:31 AM · Restricted Project, Restricted Project
Hahnfeld added inline comments to D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc.
Aug 20 2021, 4:33 AM · Restricted Project
Hahnfeld requested review of D108456: [CUDA] Fix static device variables with -fgpu-rdc.
Aug 20 2021, 4:32 AM · Restricted Project

Aug 19 2021

Hahnfeld added inline comments to D108247: [CUDA] Improve CUDA version detection and diagnostics..
Aug 19 2021, 10:46 AM · Restricted Project
Hahnfeld added inline comments to D108247: [CUDA] Improve CUDA version detection and diagnostics..
Aug 19 2021, 8:39 AM · Restricted Project

Aug 18 2021

Hahnfeld accepted D108239: [CUDA] Add support for CUDA-11.4..
Aug 18 2021, 11:38 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D108239: [CUDA] Add support for CUDA-11.4..

I didn't follow the recent CUDA support in Clang very closely, but this makes sense to me.

Aug 18 2021, 10:59 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D108235: [CUDA] Bump default GPU architecture to sm_35..

(might be good to have an entry in the release notes?)

Aug 18 2021, 10:56 AM · Restricted Project
Hahnfeld accepted D108247: [CUDA] Improve CUDA version detection and diagnostics..

Otherwise LGTM

Aug 18 2021, 10:55 AM · Restricted Project
Hahnfeld accepted D108248: [CUDA] Bump the latest supported CUDA version to 11.4..

LG, should land after the other revisions are in.

Aug 18 2021, 2:36 AM · Restricted Project
Hahnfeld added inline comments to D108247: [CUDA] Improve CUDA version detection and diagnostics..
Aug 18 2021, 2:35 AM · Restricted Project
Hahnfeld accepted D108235: [CUDA] Bump default GPU architecture to sm_35..

LGTM

Aug 18 2021, 2:26 AM · Restricted Project

Aug 13 2021

Hahnfeld added a comment to D77670: [CUDA] Add partial support for recent CUDA versions..
In D77670#2944192, @tra wrote:

@tra The split between LATEST and LATEST_SUPPORTED leads to very weird warning and error messages:

Agreed, it's far from ideal. There's also more than one issue involved.

Aug 13 2021, 1:38 PM · Restricted Project, Restricted Project
Herald added a project to D77670: [CUDA] Add partial support for recent CUDA versions.: Restricted Project.

@tra The split between LATEST and LATEST_SUPPORTED leads to very weird warning and error messages:

clang-14: warning: unknown CUDA version: cuda.h: CUDA_VERSION=11040.; assuming the latest supported version 10.1 [-Wunknown-cuda-version]
clang-14: error: cannot find libdevice for sm_20; provide path to different CUDA installation via '--cuda-path', or pass '-nocudalib' to build without linking with libdevice                                                                                                                    
clang-14: error: GPU arch sm_20 is supported by CUDA versions between 7.0 and 8.0 (inclusive), but installation at /usr/local/cuda-11.4 is 11.2; use '--cuda-path' to specify a different CUDA install, pass a different GPU arch with '--cuda-gpu-arch', or pass '--no-cuda-version-check'
Aug 13 2021, 7:26 AM · Restricted Project, Restricted Project

Jun 9 2021

Hahnfeld accepted D103606: [OpenMP][Tools] Cleanup memory pool used in Archer.

LG

Jun 9 2021, 3:08 AM · Restricted Project

Jun 8 2021

Hahnfeld accepted D103607: [OpenMP][Tools] Fix Archer for MACOS.

LG

Jun 8 2021, 11:21 PM · Restricted Project
Hahnfeld accepted D103608: [OpenMP][Tools] Fix Archer handling of task dependencies.

LGTM, thanks

Jun 8 2021, 11:17 PM · Restricted Project
Hahnfeld added inline comments to D103606: [OpenMP][Tools] Cleanup memory pool used in Archer.
Jun 8 2021, 11:15 PM · Restricted Project

Jun 7 2021

Hahnfeld added a comment to D103608: [OpenMP][Tools] Fix Archer handling of task dependencies.

I think at least this patch needs a clang-format, maybe also applies to the other recent patches.

Jun 7 2021, 1:05 AM · Restricted Project

Jun 6 2021

Hahnfeld added inline comments to D103606: [OpenMP][Tools] Cleanup memory pool used in Archer.
Jun 6 2021, 11:26 PM · Restricted Project
Hahnfeld added inline comments to D103607: [OpenMP][Tools] Fix Archer for MACOS.
Jun 6 2021, 11:12 PM · Restricted Project
Hahnfeld added inline comments to D103607: [OpenMP][Tools] Fix Archer for MACOS.
Jun 6 2021, 8:31 AM · Restricted Project

May 19 2021

Hahnfeld added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

We've started seeing LLVM ERROR: out of memory on our 2-stage LTO Linux builders after this change landed. It looks like linking clang-repl always fails on our bot, but I've also seen OOM when linking ClangCodeGenTests and FrontendTests. Do you have any idea why this could be happening? We'd appreciate any help since our bots have been broken for several days now.

Ouch. Are the bot logs public? If not maybe a stacktrace could be useful. clang-repl combines a lot of libraries across llvm and clang that usually are compiled separately. For instance we put in memory most of the clang frontend, the backend and the JIT. Could it be we are hitting some real limit?

Yes, they are, see https://luci-milo.appspot.com/p/fuchsia/builders/prod/clang-linux-x64, but there isn't much information in there unfortunately. It's possible that we're hitting some limit, but these bots use 32-core instances with 128GB RAM which I'd hope is enough even for the LTO build.

I think the specs are fine for just building with LTO, but I am not sure if that's enough to for the worst case when running ninja -j320 with an LTO build (which is what your job is doing). Can you try limiting your link jobs to something like 16 or 32 (e.g., -DLLVM_PARALLEL_LINK_JOBS=32)

May 19 2021, 3:40 AM · Restricted Project

Apr 7 2021

Hahnfeld committed rG6415f424bc2a: [AArch64] Materialize FP constant in code for large code model (authored by Hahnfeld).
[AArch64] Materialize FP constant in code for large code model
Apr 7 2021, 12:02 PM
Hahnfeld closed D99607: [AArch64] Materialize FP constant in code for large code model.
Apr 7 2021, 12:02 PM · Restricted Project
Hahnfeld added a comment to D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA.

Can we get this fixed somehow? It's annoying that there is a test failure in Clang without building the OpenMP runtime, just because I have CUDA installed on my machine...

Apr 7 2021, 12:00 PM · Restricted Project
Hahnfeld added reviewers for D99607: [AArch64] Materialize FP constant in code for large code model: aemerson, paquette.

friendly ping :)

Apr 7 2021, 12:27 AM · Restricted Project

Mar 30 2021

Hahnfeld removed a reviewer for D34701: [openmp-target-tests] OpenMP 4.5 Target data test cases: Hahnfeld.
Mar 30 2021, 10:14 AM
Hahnfeld removed a reviewer for D73657: [OPENMP] Load plugins from same directory as the libomptarget.so and quick fail mechanism for offloading plugins: Hahnfeld.

Superseded by D87413, I think.

Mar 30 2021, 10:12 AM · Restricted Project
Hahnfeld removed a reviewer for D94332: [OpenMP] Introduce a new parallel region entry point: Hahnfeld.
Mar 30 2021, 10:10 AM · Restricted Project
Hahnfeld removed a reviewer for D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.: Hahnfeld.
Mar 30 2021, 10:10 AM · Restricted Project, Restricted Project
Hahnfeld removed a reviewer for D87413: [OpenMP] Load plugins from same directory as the libomptarget.so: Hahnfeld.
Mar 30 2021, 10:10 AM · Restricted Project
Hahnfeld removed a reviewer for D85934: Enable OpenMP offloading to VE and enable tests for offloading to VE: Hahnfeld.
Mar 30 2021, 10:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Hahnfeld removed a reviewer for D71987: [OpenMP][NFC] Add a couple of TODOs to the runtime: Hahnfeld.
Mar 30 2021, 10:08 AM · Restricted Project
Hahnfeld removed a reviewer for D70412: [OpenMP][Tool] Runtime warning for missing TSan-option: Hahnfeld.

Long addressed by D72779, but I can't seem to be able to close this (?)

Mar 30 2021, 10:08 AM · Restricted Project
Hahnfeld removed a reviewer for D47224: [cmake] Guard another instance where symlinks are being created: Hahnfeld.
Mar 30 2021, 10:04 AM
Hahnfeld requested review of D99607: [AArch64] Materialize FP constant in code for large code model.
Mar 30 2021, 9:55 AM · Restricted Project

Feb 4 2021

Hahnfeld added inline comments to D95915: [clang][driver] Only warn once about invalid -stdlib value.
Feb 4 2021, 8:36 AM · Restricted Project

Feb 3 2021

Hahnfeld added a comment to D95915: [clang][driver] Only warn once about invalid -stdlib value.

That's what I was looking at right now as well, since using std::call_once() already means the methods can't be const anymore anyway. Might as well just cache the value.

Feb 3 2021, 11:49 PM · Restricted Project
Hahnfeld added a comment to D95915: [clang][driver] Only warn once about invalid -stdlib value.

My proposal would be to cache the return value of the three routines in ToolChain. This has the advantage that the values get parsed only once and there is at most one warning. I don't know how this plays with parallelization efforts, but I don't think we should worry about this right now, given the current code.

Feb 3 2021, 11:37 PM · Restricted Project

Jan 9 2021

Hahnfeld accepted D93169: [OpenMP] Added the support for cache line size 256 for A64FX.

LGTM, thanks for the changes!

Jan 9 2021, 8:55 AM · Restricted Project

Jan 7 2021

Hahnfeld added inline comments to D93169: [OpenMP] Added the support for cache line size 256 for A64FX.
Jan 7 2021, 11:30 PM · Restricted Project
Hahnfeld added a comment to D93169: [OpenMP] Added the support for cache line size 256 for A64FX.

Why is it necessary to write and compile a C program just to parse /proc/cpuinfo? Can this be done directly from CMake?

Unfortunately we can't. CMAKE_SYSTEM_PROCESSOR just reports aarch64.

Jan 7 2021, 1:20 PM · Restricted Project
Hahnfeld added a comment to D93169: [OpenMP] Added the support for cache line size 256 for A64FX.

Why is it necessary to write and compile a C program just to parse /proc/cpuinfo? Can this be done directly from CMake?

Jan 7 2021, 9:25 AM · Restricted Project

Dec 16 2020

Hahnfeld committed rG6e890ec7beb0: [CMake] Avoid __FakeVCSRevision.h with no git repository (authored by Hahnfeld).
[CMake] Avoid __FakeVCSRevision.h with no git repository
Dec 16 2020, 8:34 AM
Hahnfeld closed D92718: [CMake] Avoid __FakeVCSRevision.h with no git repository.
Dec 16 2020, 8:33 AM · Restricted Project

Dec 15 2020

Hahnfeld updated the diff for D92718: [CMake] Avoid __FakeVCSRevision.h with no git repository.

Add comment for find_first_existing_vc_file, thanks @scott.linder.

Dec 15 2020, 12:13 PM · Restricted Project

Dec 13 2020

Hahnfeld added reviewers for D92718: [CMake] Avoid __FakeVCSRevision.h with no git repository: vsapsai, scott.linder.

Ping

Dec 13 2020, 7:45 AM · Restricted Project

Dec 5 2020

Hahnfeld requested review of D92718: [CMake] Avoid __FakeVCSRevision.h with no git repository.
Dec 5 2020, 4:10 AM · Restricted Project

Nov 13 2020

Hahnfeld updated Hahnfeld.
Nov 13 2020, 6:48 AM

Oct 22 2020

Hahnfeld added a comment to D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path..
In D89974#2348176, @tra wrote:

CUDA path is sort of a global configuration parameter for all CUDA compilations. Perhaps we should consider allowing the user to specify a CUDA search path candidate via environment variable. This should allow transparently overriding preferred CUDA path without having to adjust all builds. I can't say I like it, but it seems to be the least bad way (that I can think of ATM) to address the dependency on something that only the end user would know for sure.

Oct 22 2020, 12:18 PM · Restricted Project, Restricted Project
Hahnfeld added a comment to D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path..

I thought, right now we would configure clang with a cuda path XYZ

Oct 22 2020, 11:52 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path..
In D89974#2347938, @tra wrote:

I think the default should still let clang search for CUDA or require the user to provide correct CUDA path. "Use CUDA path discovered by CMake at build time" should be a non-default configuration option if/when it's needed and appropriate.

I agree here. It's definitely surprising to make it the *first* path because module loading another CUDA version and putting it into PATH is not recognized anymore.

Oct 22 2020, 10:53 AM · Restricted Project, Restricted Project
Hahnfeld added a comment to D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path..
In D89974#2347938, @tra wrote:

One concern I have is that the path we configure during clang's build is not necessarily the right choice for the user of clang we build. It's likely that the clang in the end will be used on a completely different machine.
E.g. official clang builds can not ever provide the same CUDA path for *all* users who end up using them. Requiring the rest to use a special option to make clang work again looks like an overall usability regression to me.

Oct 22 2020, 10:50 AM · Restricted Project, Restricted Project
Hahnfeld updated subscribers of D89915: [compiler-rt] Don't include libc++ headers from the source tree in MSAN.

By the way, there's no commit list subscribed which sounds bad. Adding llvm-commits to give people a chance to be aware of this.

Oct 22 2020, 12:27 AM · Restricted Project
Hahnfeld added a comment to D89915: [compiler-rt] Don't include libc++ headers from the source tree in MSAN.

@Hahnfeld Can you advise on the proper way to fix this? From git blame, it seems like you might know.

Oct 22 2020, 12:23 AM · Restricted Project

Sep 17 2020

Hahnfeld resigned from D87841: [openmp][libomptarget] Include header from LLVM source tree.
Sep 17 2020, 10:45 AM · Restricted Project, Restricted Project

Sep 3 2020

Hahnfeld added a comment to D87084: [OpenMP][AMDGPU] Use DS_Max_Warp_Number instead of WARPSIZE.

Other places need to be updated too: data_sharing_init_stack_common for one.

Do we actually use this array? What happens if you make it a single element and update the function above?

Sep 3 2020, 10:29 AM · Restricted Project

Jul 8 2020

Hahnfeld removed a reviewer for D83062: [OpenMP] Implement TR8 `present` map type modifier in runtime (2/2): Hahnfeld.
Jul 8 2020, 11:50 PM · Restricted Project

Jul 7 2020

Hahnfeld added a comment to D83268: [OpenMP][NFC] Remove unused (always fixed) arguments.

Aside from the API stability concern this looks uncontentious. Removes dead arguments, generally makes things simpler. Thus LGTM.

@Hahnfeld @ABataev - are you sufficiently persuaded that preserving the current interface is not worth the development cost?

Jul 7 2020, 7:21 AM · Restricted Project, Restricted Project, Restricted Project
Hahnfeld added a comment to D83268: [OpenMP][NFC] Remove unused (always fixed) arguments.

This is definitely not NFC and breaks API compatibility (but apparently nobody cares anymore?).

Jul 7 2020, 12:10 AM · Restricted Project, Restricted Project, Restricted Project

Jul 6 2020

Hahnfeld accepted D82267: [OpenMP][Tests] Fix/Mark compatibilty for GCC.

LGTM

Jul 6 2020, 12:30 PM · Restricted Project

Jul 5 2020

Hahnfeld added a comment to D82267: [OpenMP][Tests] Fix/Mark compatibilty for GCC.

The summary also talks about tools/multiplex/tests/*, is that information obsolete?

Jul 5 2020, 11:43 AM · Restricted Project
Hahnfeld accepted D83077: [OpenMP][Tests] Flag compatibility of OpenMP runtime tests with GCC versions.

LGTM

Jul 5 2020, 11:43 AM · Restricted Project
Hahnfeld accepted D83171: [OpenMP][OMPT] Fix ifdefs for OMPT code.

LGTM

Jul 5 2020, 11:43 AM · Restricted Project

Jul 2 2020

Hahnfeld committed rG0e0483bf5c38: [OpenMP][CMake] Fix version detection of testing compiler (authored by Hahnfeld).
[OpenMP][CMake] Fix version detection of testing compiler
Jul 2 2020, 10:49 AM
Hahnfeld added a comment to D82963: [OpenMP] Temporarily disable failing runtime tests for OpenMP 5.0.

Thanks @Hahnfeld. I realized that LLVM_MAJOR_VERSION was neither getting set in OpenMPTesting.cmake nor was it
inheriting it from anywhere else. So, OPENMP_TEST_COMPILER_VERSION_MAJOR was also getting set as empty, which
was getting propagated to lit by config.test_compiler_features. That is why "clang-11" was not getting recognized
as a valid target by lit-unsupported (though clang-11.0.0 would have worked). This change should fix this issue.

Jul 2 2020, 10:47 AM · Restricted Project
Hahnfeld added inline comments to D82963: [OpenMP] Temporarily disable failing runtime tests for OpenMP 5.0.
Jul 2 2020, 6:57 AM · Restricted Project

Jun 29 2020

Hahnfeld added a comment to D82718: [OpenMP] Use primary context in CUDA plugin.

(In general, all patches must be sent to the respective -commits list. This also makes feedback more likely.)

Sorry, I was not aware of -commits list. What is it for exclusively? If there is policy or instruction , please point me.
I added OpenMP project tag. I you watch OpenMP project on differential. I expect you get notifications. Is it not the case?

Jun 29 2020, 10:48 AM · Restricted Project
Hahnfeld updated subscribers of D82718: [OpenMP] Use primary context in CUDA plugin.

(In general, all patches must be sent to the respective -commits list. This also makes feedback more likely.)

Jun 29 2020, 9:10 AM · Restricted Project

Jun 19 2020

Hahnfeld added a comment to D76012: [OpenMP][Tool] Header-only multiplexing of OMPT tools.

@protze.joachim @jdoerfert ompt-multiplex.h is installed by default in /usr/include/
others opemp headers are installed in /usr/include/openmp/

Jun 19 2020, 2:07 AM · Restricted Project
Hahnfeld added a comment to D82154: [OpenMP][Tool] Fix install directory of ompt-multiplex.h.

LIBOMP_HEADERS_INSTALL_PATH is the internal compiler where for example omp.h. I think the header tool is of relevance outside of Clang, so IMO it should go the general include/ directory.

Jun 19 2020, 2:07 AM · Restricted Project

May 18 2020

Hahnfeld resigned from D80040: [compiler-rt][CMake] Fix PowerPC runtime build.

I don't feel comfortable reviewing this change, maybe @phosek can take a look.

May 18 2020, 6:24 AM · Restricted Project

May 15 2020

Hahnfeld added a comment to D79944: [OpenMP] Fix for https://bugs.llvm.org/show_bug.cgi?id=45904..

Does -fopenmp-version work with the Intel Compiler? How will this work if the GCC eventually gets support for OpenMP 5.0?

May 15 2020, 12:08 AM · Restricted Project

Apr 21 2020

Hahnfeld accepted D78566: [OpenMP] Add scaffolding for negative runtime tests.

LGTM as well

Apr 21 2020, 1:33 PM · Restricted Project
Hahnfeld added a comment to D78566: [OpenMP] Add scaffolding for negative runtime tests.

I just noticed another issue: ompt tests are skipped if FileCheck is not available. This is configured in openmp/runtime/test/lit.cfg. However, other openmp test suites that use FileCheck don't bother. Why is ompt different?

Apr 21 2020, 12:26 PM · Restricted Project
Hahnfeld added a comment to D78566: [OpenMP] Add scaffolding for negative runtime tests.

This patch makes not visible in all of the openmp project's test
suites. In all but libomptarget/test, it should be possible for a
test author to insert not before a use of the lit substitution for
running a test program.

Apr 21 2020, 9:41 AM · Restricted Project

Apr 10 2020

Hahnfeld added inline comments to D76843: [Openmp] Libomptarget plugin for NEC SX-Aurora.
Apr 10 2020, 1:35 AM · Restricted Project, Restricted Project

Apr 9 2020

Hahnfeld added inline comments to D76843: [Openmp] Libomptarget plugin for NEC SX-Aurora.
Apr 9 2020, 7:34 AM · Restricted Project, Restricted Project

Mar 30 2020

Hahnfeld committed rGced99a1a6368: Fix comment for CLANG_SYSTEMZ_DEFAULT_ARCH (authored by Hahnfeld).
Fix comment for CLANG_SYSTEMZ_DEFAULT_ARCH
Mar 30 2020, 1:04 PM