Hahnfeld (Jonas Hahnfeld)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 2 2015, 4:52 AM (124 w, 1 d)
IT Center
Group: High Performance Computing
Division: Computational Science and Engineering
RWTH Aachen University

Recent Activity

Mon, Aug 14

Hahnfeld added inline comments to D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading.
Mon, Aug 14, 12:56 AM · Restricted Project
Hahnfeld added a comment to D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets.

Disabled openmp-offload.c on Linux again: https://reviews.llvm.org/rL310772

Mon, Aug 14, 12:53 AM
Hahnfeld committed rL310817: Fix memory leak in ToolChain::TranslateOpenMPTargetArgs.
Fix memory leak in ToolChain::TranslateOpenMPTargetArgs
Mon, Aug 14, 12:45 AM

Fri, Aug 11

Hahnfeld removed a reviewer for D34158: For Linux/gnu compatibility, preinclude <stdc-predef.h> if the file is available : Hahnfeld.
Fri, Aug 11, 7:11 AM

Thu, Aug 10

Hahnfeld resigned from D34158: For Linux/gnu compatibility, preinclude <stdc-predef.h> if the file is available .
Thu, Aug 10, 11:05 PM

Wed, Aug 2

Hahnfeld added a comment to D34701: [openmp-target-tests] OpenMP 4.5 Target data test cases.

Hi Jonas

Did you have further comments on this commit?

Thanks
Sunita

Wed, Aug 2, 12:13 AM

Tue, Aug 1

Hahnfeld accepted D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG.

Given the lack of additional comments, LGTM. Please adapt the commit description to reflect the changes during review.

Tue, Aug 1, 11:38 PM · Restricted Project

Wed, Jul 26

Hahnfeld added a comment to D35719: [CMake] Disable building libomptarget and add CMake switch.

I've committed the patch without an explicit answer from the IBM guys to unblock the release

Wed, Jul 26, 6:56 AM
Hahnfeld committed rL309115: [CMake] Disable building libomptarget and add CMake switch.
[CMake] Disable building libomptarget and add CMake switch
Wed, Jul 26, 6:55 AM
Hahnfeld closed D35719: [CMake] Disable building libomptarget and add CMake switch by committing rL309115: [CMake] Disable building libomptarget and add CMake switch.
Wed, Jul 26, 6:55 AM

Sun, Jul 23

Hahnfeld added inline comments to D35719: [CMake] Disable building libomptarget and add CMake switch.
Sun, Jul 23, 11:19 PM
Hahnfeld updated the diff for D35719: [CMake] Disable building libomptarget and add CMake switch.

Disable building by default.

Sun, Jul 23, 11:15 PM

Fri, Jul 21

Hahnfeld added inline comments to D35719: [CMake] Disable building libomptarget and add CMake switch.
Fri, Jul 21, 1:07 AM

Thu, Jul 20

Hahnfeld created D35719: [CMake] Disable building libomptarget and add CMake switch.
Thu, Jul 20, 11:44 PM

Jul 13 2017

Hahnfeld committed rL307899: [GOMP] Fix (un)tied tasks with the GCC.
[GOMP] Fix (un)tied tasks with the GCC
Jul 13 2017, 3:38 AM

Jul 12 2017

Hahnfeld added a comment to D34876: [asan] Remove check for stack size.
In D34876#806869, @kcc wrote:

This check is a sanity check, please keep it, but feel free to change the constant to e.g. 0x100000000 (16x increase)

Jul 12 2017, 11:04 PM

Jul 5 2017

Hahnfeld added inline comments to D29658: [OpenMP] Customize CUDA-based tool chain selection.
Jul 5 2017, 11:25 PM
Hahnfeld added a comment to D29905: [OpenMP] Pass argument to device kernel by reference when map is used. .

Does this also include the fixes in the following revision?

https://reviews.llvm.org/D29905

Jul 5 2017, 11:15 PM

Jul 4 2017

Hahnfeld committed rL307127: [asan] Remove check for stack size.
[asan] Remove check for stack size
Jul 4 2017, 11:55 PM
Hahnfeld closed D34876: [asan] Remove check for stack size by committing rL307127: [asan] Remove check for stack size.
Jul 4 2017, 11:55 PM

Jul 3 2017

Hahnfeld added a comment to D34158: For Linux/gnu compatibility, preinclude <stdc-predef.h> if the file is available .

The other test that fails is my own new test! It fails because I don't know how to set it up so the test thinks it has a gcc toolchain with version > 4.8. I tried using gcc-toolchain set to various other Linux toolchains that i see in the test/Driver/Inputs - none of them cause the gcc version to be in the range. I also tried using -ccc-installation=Inputs/ which I see being used for gcc version parsing. How can I set up the test so that the GCCInstallation has a Version >= 4.8? I test the new functionality from the console on Linux and can confirm it's working.

Jul 3 2017, 7:33 AM

Jul 1 2017

Hahnfeld added a comment to D34876: [asan] Remove check for stack size.

What's the stack size on CentOS? What was the point of the original check?

Jul 1 2017, 3:52 AM
Hahnfeld updated the summary of D34876: [asan] Remove check for stack size.
Jul 1 2017, 3:52 AM
Hahnfeld committed rL306956: [OpenMP] Fix mapping of scalars for combined directives.
[OpenMP] Fix mapping of scalars for combined directives
Jul 1 2017, 3:41 AM
Hahnfeld closed D34888: [OpenMP] Fix mapping of scalars for combined directives by committing rL306956: [OpenMP] Fix mapping of scalars for combined directives.
Jul 1 2017, 3:41 AM

Jun 30 2017

Hahnfeld created D34888: [OpenMP] Fix mapping of scalars for combined directives.
Jun 30 2017, 7:51 AM
Hahnfeld created D34876: [asan] Remove check for stack size.
Jun 30 2017, 5:14 AM

Jun 29 2017

Hahnfeld added a comment to D34701: [openmp-target-tests] OpenMP 4.5 Target data test cases.

Thank you for the comments. I generated again the patch following your comments.

Jun 29 2017, 4:11 AM

Jun 27 2017

Hahnfeld edited reviewers for D34701: [openmp-target-tests] OpenMP 4.5 Target data test cases, added: sfantao, grokos, Hahnfeld; removed: openmp-commits.

I don't see any new files...? I'm also not entirely sure that we should have Fortran tests? @jlpeyton

Jun 27 2017, 11:18 PM
Hahnfeld edited reviewers for D34158: For Linux/gnu compatibility, preinclude <stdc-predef.h> if the file is available , added: rsmith, rengolin; removed: cfe-commits.

Some comments inline. In general you should consider posting an RFC on cfe-dev because this change will basically affect all compilations on GNU/Linux if the file is present.
Adding Richard (general maintainer) and Renato (ARM Linux) so they are aware.

Jun 27 2017, 11:12 PM
Hahnfeld changed the visibility for D34158: For Linux/gnu compatibility, preinclude <stdc-predef.h> if the file is available .
Jun 27 2017, 10:53 PM

Jun 5 2017

Hahnfeld updated subscribers of D33851: [OpenMP] libomptarget: eliminate compiler warnings at build.

Because I've seen this on other revisions as well: Please always subscribe the relevant mailing list!

Jun 5 2017, 10:56 PM

May 31 2017

Hahnfeld added a comment to D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG.

I can change the name for this environment variable it as you suggested, but it will make it consistent with other environment variable's name that is already used by libomptarget - OMP_TARGET_OFFLOAD (look at openmp/libomptarget/src/omptarget.cpp, line 285).

May 31 2017, 11:04 PM · Restricted Project

May 10 2017

Hahnfeld updated subscribers of D33028: [OpenMP] Changes in the plugin interface.

Please always add the relevant -commits mailing list

May 10 2017, 5:43 AM · Restricted Project
Hahnfeld accepted D33028: [OpenMP] Changes in the plugin interface.

LGTM. Have you run clang-format on omptargetplugin.h? Some lines look weirdly wrapped...

May 10 2017, 5:42 AM · Restricted Project

May 8 2017

Hahnfeld added a comment to D32734: [CMake][runtimes] Set default directory for runtime libraries.

What is the problem you're trying to solve here? This seems odd to me.

May 8 2017, 11:12 PM

May 4 2017

Hahnfeld added a comment to D29647: [OpenMP] Extend CLANG target options with device offloading kind..

One minor drive-by comment. I think there is still one outstanding from Justin...

May 4 2017, 10:39 AM

May 3 2017

Hahnfeld committed rL302118: [libcxxabi][CMake] Set library dir when built under runtimes/.
[libcxxabi][CMake] Set library dir when built under runtimes/
May 3 2017, 11:17 PM
Hahnfeld closed D32735: [libcxxabi][CMake] Set library dir when built under runtimes/ by committing rL302118: [libcxxabi][CMake] Set library dir when built under runtimes/.
May 3 2017, 11:17 PM
Hahnfeld committed rL302117: [libcxx][CMake] Set library dir when built under runtimes/.
[libcxx][CMake] Set library dir when built under runtimes/
May 3 2017, 11:16 PM
Hahnfeld closed D32736: [libcxx][CMake] Set library dir when built under runtimes/ by committing rL302117: [libcxx][CMake] Set library dir when built under runtimes/.
May 3 2017, 11:16 PM

May 2 2017

Hahnfeld created D32736: [libcxx][CMake] Set library dir when built under runtimes/.
May 2 2017, 12:29 AM
Hahnfeld created D32735: [libcxxabi][CMake] Set library dir when built under runtimes/.
May 2 2017, 12:28 AM
Hahnfeld created D32734: [CMake][runtimes] Set default directory for runtime libraries.
May 2 2017, 12:28 AM

Apr 25 2017

Hahnfeld accepted D32321: [OpenMP] Optimized default kernel launch parameters in CUDA plugin.

LGTM

Apr 25 2017, 9:41 AM · Restricted Project

Apr 22 2017

Hahnfeld accepted D32326: [OpenMP] libomptarget: Set ref count for global objects to positive infinity.

LGTM

Apr 22 2017, 4:48 AM · Restricted Project

Apr 20 2017

Hahnfeld added a comment to D32321: [OpenMP] Optimized default kernel launch parameters in CUDA plugin.

Does this change result in a lower runtime? Last time I tested clang-ykt on Pascal GPUs, 1024 threads were really the best thing to do...

Apr 20 2017, 11:15 PM · Restricted Project
Hahnfeld added inline comments to D32326: [OpenMP] libomptarget: Set ref count for global objects to positive infinity.
Apr 20 2017, 11:08 PM · Restricted Project
Hahnfeld accepted D32325: [OpenMP] libomptarget: Remove obsolete negative device IDs -2/-3.

LGTM, not currently used in Clang.

Apr 20 2017, 10:55 PM · Restricted Project
Hahnfeld accepted D29658: [OpenMP] Customize CUDA-based tool chain selection.

LGTM with one small note

Apr 20 2017, 2:13 AM
Hahnfeld accepted D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices..

LGTM unless Alexey still has objections

Apr 20 2017, 1:57 AM

Apr 19 2017

Hahnfeld committed rL300689: [Driver] Unify linking of OpenMP runtime. NFCI..
[Driver] Unify linking of OpenMP runtime. NFCI.
Apr 19 2017, 7:08 AM
Hahnfeld closed D30087: [Driver] Unify linking of OpenMP runtime. NFCI. by committing rL300689: [Driver] Unify linking of OpenMP runtime. NFCI..
Apr 19 2017, 7:08 AM

Apr 18 2017

Hahnfeld added a comment to D30087: [Driver] Unify linking of OpenMP runtime. NFCI..

Ping

Apr 18 2017, 11:40 PM

Apr 13 2017

Hahnfeld added a comment to D29658: [OpenMP] Customize CUDA-based tool chain selection.

Is there a way to actually test the changed code? The current test changes seem unrelated...

Apr 13 2017, 8:09 AM

Apr 6 2017

Hahnfeld added inline comments to D30087: [Driver] Unify linking of OpenMP runtime. NFCI..
Apr 6 2017, 7:50 AM
Hahnfeld updated the diff for D30087: [Driver] Unify linking of OpenMP runtime. NFCI..
Apr 6 2017, 7:49 AM

Apr 3 2017

Hahnfeld added a comment to D30087: [Driver] Unify linking of OpenMP runtime. NFCI..

Ping!

Apr 3 2017, 11:17 PM
Hahnfeld committed rL299415: Align all scalar numbers to LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR.
Align all scalar numbers to LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR
Apr 3 2017, 11:15 PM
Hahnfeld closed D30508: Align all scalar numbers to LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR by committing rL299415: Align all scalar numbers to LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR.
Apr 3 2017, 11:15 PM
Hahnfeld added reviewers for D30508: Align all scalar numbers to LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR: sbc100, davide.

Ping! This gets pretty annoying...

Apr 3 2017, 12:23 AM
Hahnfeld updated the diff for D30508: Align all scalar numbers to LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR.

Catch one more occurence.

Apr 3 2017, 12:22 AM

Mar 31 2017

Hahnfeld requested changes to D29658: [OpenMP] Customize CUDA-based tool chain selection.
Mar 31 2017, 2:48 AM
Hahnfeld added a reviewer for D29654: [OpenMP] Integrate OpenMP target region cubin into host binary: rnk.

Please format all comments as full sentences.

Mar 31 2017, 2:33 AM
Hahnfeld accepted D29339: [OpenMP] Add support for auxiliary triple specification.

LGTM

Mar 31 2017, 1:37 AM
Hahnfeld requested changes to D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices..

Out of interest: This is a limition of the implementation, right? Because the standard only says: A throw executed inside a target region must cause execution to resume within the same target region, and the same thread that threw the exception must catch it.

Mar 31 2017, 12:07 AM

Mar 30 2017

Hahnfeld added a comment to D29644: [OpenMP] Pass -v to PTXAS if it was passed to the driver..

Just noticed that this isn't specific to OpenMP. Could you move the test to Driver/cuda-external-tools.cu where the rest of ptxas is tested?

Mar 30 2017, 11:34 PM
Hahnfeld accepted D29642: [OpenMP] Make OpenMP generated code for the NVIDIA device relocatable by default.

LGTM after fixing the check-prefix

Mar 30 2017, 11:25 PM

Mar 29 2017

Hahnfeld added a comment to D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices..

LGTM. Please run clang-format before committing!

Mar 29 2017, 11:08 AM
Hahnfeld added a comment to D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs..

Having something with dashes behind other used prefixes (CHK-PTXAS, CHK-PTXAS-C, CHK-PTXAS-C-RELO) might not be optimal and break when other suffixes like -NOT or -SAME are added to lit. Please see inline about my suggestions but feel free to use others...

Mar 29 2017, 11:03 AM
Hahnfeld added inline comments to D29644: [OpenMP] Pass -v to PTXAS if it was passed to the driver..
Mar 29 2017, 11:02 AM
Hahnfeld accepted D29645: [OpenMP] Pass -fopenmp-is-device to preprocessing and machine specific code generation stages.

LGTM

Mar 29 2017, 10:45 AM
Hahnfeld added inline comments to D29642: [OpenMP] Make OpenMP generated code for the NVIDIA device relocatable by default.
Mar 29 2017, 10:42 AM

Mar 27 2017

Hahnfeld updated the diff for D30508: Align all scalar numbers to LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR.

Rebase and ping!

Mar 27 2017, 11:39 PM
Hahnfeld updated the diff for D30087: [Driver] Unify linking of OpenMP runtime. NFCI..

Rebase and ping.

Mar 27 2017, 11:38 PM

Mar 23 2017

Hahnfeld added inline comments to D31071: GOMP compatibility: add missing OMP4.0 taskdeps handling code.
Mar 23 2017, 4:08 AM

Mar 22 2017

Hahnfeld accepted D31206: [OpenMP] CUDA plugin: More descriptive error messages.

LGTM

Mar 22 2017, 10:41 AM · Restricted Project
Hahnfeld accepted D31205: [OpenMP] Allow multiple weak symbols to be loaded from the fat binary.

LGTM

Mar 22 2017, 12:53 AM · Restricted Project
Hahnfeld added inline comments to D31206: [OpenMP] CUDA plugin: More descriptive error messages.
Mar 22 2017, 12:52 AM · Restricted Project
Hahnfeld accepted D31207: [OpenMP] CUDA plugin: add include directory for libelf.

LGTM

Mar 22 2017, 12:49 AM · Restricted Project

Mar 21 2017

Hahnfeld accepted D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..

AFAIK, none of the machinery required in LLVM to expose the mangled names in the vectorizer is present in trunk. There is a patch for x86 under review that does that: https://reviews.llvm.org/D22792

Mar 21 2017, 6:18 AM
Hahnfeld added a comment to D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD..

In principal looks good to me although I'm not really familiar with this part. Does that work for you if you have the declare simd in a header file and the implementation in another file? On x86_64 I currently get:

remark: loop not vectorized: call instruction cannot be vectorized
Mar 21 2017, 5:48 AM
Hahnfeld accepted D31055: [OpenMP] libomptarget: Disable on MacOS X.

I thought the library would just compile fine and that the CUDA plugin should work without ELF support - turns out both don't because the CUDA plugin uses ELF to verify the binary header. This could certainly be solved differently but that's future work if someone is interested.

Mar 21 2017, 12:18 AM

Mar 20 2017

Hahnfeld added a comment to D30508: Align all scalar numbers to LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR.

Ping

Mar 20 2017, 2:13 AM
Hahnfeld added a comment to D30087: [Driver] Unify linking of OpenMP runtime. NFCI..

Another ping

Mar 20 2017, 2:13 AM
Hahnfeld abandoned D30733: [Driver] Add arch-specific rpath for libc++.
Mar 20 2017, 12:10 AM
Hahnfeld requested changes to D31055: [OpenMP] libomptarget: Disable on MacOS X.
Mar 20 2017, 12:09 AM

Mar 17 2017

Hahnfeld added a comment to D31055: [OpenMP] libomptarget: Disable on MacOS X.

Ideally, we should check if the linker supports --version-script, but currently this yields no benefit.

Mar 17 2017, 12:09 AM

Mar 9 2017

Hahnfeld added a comment to D30733: [Driver] Add arch-specific rpath for libc++.

As I said on D30214, it is inappropriate to be installing libc++ in the resource directory... please do not do that.

Mar 9 2017, 10:55 PM

Mar 8 2017

Hahnfeld created D30733: [Driver] Add arch-specific rpath for libc++.
Mar 8 2017, 4:32 AM
Hahnfeld added a comment to D30700: [Driver] Add flag to request arch-specific-subdir in -rpath.

No build system will ever set -frtlib-add-rpath to enable this "feature". I'm for keeping this opt-out until we have configuration files to set this by default. Making it opt-in would weaken its main reason of existence: Not to break simple binaries for the user, and we can just drop it.

Mar 8 2017, 4:31 AM
Hahnfeld committed rL297271: [XRay] Use AddCXXStdlibLibArgs. NFCI..
[XRay] Use AddCXXStdlibLibArgs. NFCI.
Mar 8 2017, 4:18 AM
Hahnfeld updated the diff for D30087: [Driver] Unify linking of OpenMP runtime. NFCI..

Rebase for recent refactoring and ping.

Mar 8 2017, 1:50 AM
Hahnfeld committed rL297264: [test] Unbreak OpenMP/linking.c with arch-specific libdir.
[test] Unbreak OpenMP/linking.c with arch-specific libdir
Mar 8 2017, 1:19 AM
Hahnfeld updated the diff for D30508: Align all scalar numbers to LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR.

Rebase and adapt test added meanwhile.

Mar 8 2017, 12:55 AM
Hahnfeld committed rL297260: [Support] Remove unit test for fs::is_local.
[Support] Remove unit test for fs::is_local
Mar 8 2017, 12:48 AM

Mar 7 2017

Hahnfeld added a comment to D30470: [cmake] Include openmp with add_llvm_external_project.

Yes, OpenMP would be under the runtimes/ directory.

Mar 7 2017, 11:13 PM

Mar 2 2017

Hahnfeld abandoned D30214: [Driver] Search for libc++ headers in ResourceDir.

http://lists.llvm.org/pipermail/cfe-dev/2017-January/052512.html suggested to install runtime libraries (like libomp, but I think libc++ in certain cases may fall under the same category) to ResourceDir and I wanted the headers to be co-located. However, I can live with installing them to normal include

Mar 2 2017, 11:21 PM
Hahnfeld updated the diff for D30214: [Driver] Search for libc++ headers in ResourceDir.

Adapt and add tests.

Mar 2 2017, 1:03 AM
Hahnfeld updated the diff for D30087: [Driver] Unify linking of OpenMP runtime. NFCI..

Reword comment

Mar 2 2017, 1:01 AM