IT Center Group: High Performance Computing Division: Computational Science and Engineering RWTH Aachen University
- User Since
- Apr 2 2015, 4:52 AM (124 w, 1 d)
Mon, Aug 14
Fri, Aug 11
Thu, Aug 10
Wed, Aug 2
Tue, Aug 1
Given the lack of additional comments, LGTM. Please adapt the commit description to reflect the changes during review.
Wed, Jul 26
I've committed the patch without an explicit answer from the IBM guys to unblock the release
Sun, Jul 23
Disable building by default.
Fri, Jul 21
Thu, Jul 20
Jul 13 2017
Jul 12 2017
Jul 5 2017
Jul 4 2017
Jul 3 2017
Jul 1 2017
Jun 30 2017
Jun 29 2017
Jun 27 2017
I don't see any new files...? I'm also not entirely sure that we should have Fortran tests? @jlpeyton
Some comments inline. In general you should consider posting an RFC on cfe-dev because this change will basically affect all compilations on GNU/Linux if the file is present.
Adding Richard (general maintainer) and Renato (ARM Linux) so they are aware.
Jun 5 2017
Because I've seen this on other revisions as well: Please always subscribe the relevant mailing list!
May 31 2017
May 10 2017
Please always add the relevant -commits mailing list
LGTM. Have you run clang-format on omptargetplugin.h? Some lines look weirdly wrapped...
May 8 2017
May 4 2017
One minor drive-by comment. I think there is still one outstanding from Justin...
May 3 2017
May 2 2017
Apr 25 2017
Apr 22 2017
Apr 20 2017
Does this change result in a lower runtime? Last time I tested clang-ykt on Pascal GPUs, 1024 threads were really the best thing to do...
LGTM, not currently used in Clang.
LGTM with one small note
LGTM unless Alexey still has objections
Apr 19 2017
Apr 18 2017
Apr 13 2017
Is there a way to actually test the changed code? The current test changes seem unrelated...
Apr 6 2017
Apr 3 2017
Ping! This gets pretty annoying...
Catch one more occurence.
Mar 31 2017
Please format all comments as full sentences.
Out of interest: This is a limition of the implementation, right? Because the standard only says: A throw executed inside a target region must cause execution to resume within the same target region, and the same thread that threw the exception must catch it.
Mar 30 2017
Just noticed that this isn't specific to OpenMP. Could you move the test to Driver/cuda-external-tools.cu where the rest of ptxas is tested?
LGTM after fixing the check-prefix
Mar 29 2017
LGTM. Please run clang-format before committing!
Having something with dashes behind other used prefixes (CHK-PTXAS, CHK-PTXAS-C, CHK-PTXAS-C-RELO) might not be optimal and break when other suffixes like -NOT or -SAME are added to lit. Please see inline about my suggestions but feel free to use others...
Mar 27 2017
Rebase and ping!
Rebase and ping.
Mar 23 2017
Mar 22 2017
Mar 21 2017
In principal looks good to me although I'm not really familiar with this part. Does that work for you if you have the declare simd in a header file and the implementation in another file? On x86_64 I currently get:
remark: loop not vectorized: call instruction cannot be vectorized
I thought the library would just compile fine and that the CUDA plugin should work without ELF support - turns out both don't because the CUDA plugin uses ELF to verify the binary header. This could certainly be solved differently but that's future work if someone is interested.
Mar 20 2017
Mar 17 2017
Ideally, we should check if the linker supports --version-script, but currently this yields no benefit.
Mar 9 2017
Mar 8 2017
No build system will ever set -frtlib-add-rpath to enable this "feature". I'm for keeping this opt-out until we have configuration files to set this by default. Making it opt-in would weaken its main reason of existence: Not to break simple binaries for the user, and we can just drop it.
Rebase for recent refactoring and ping.
Rebase and adapt test added meanwhile.
Mar 7 2017
Mar 2 2017
http://lists.llvm.org/pipermail/cfe-dev/2017-January/052512.html suggested to install runtime libraries (like libomp, but I think libc++ in certain cases may fall under the same category) to ResourceDir and I wanted the headers to be co-located. However, I can live with installing them to normal include
Adapt and add tests.