This is an archive of the discontinued LLVM Phabricator instance.

Add diagnostic option backing field for -fansi-escape-codes

Authored by dang on Jun 30 2020, 6:26 AM.



Keep track of -fansi-escape-codes in DiagnosticOptions and move the option to the new option parsing system.

Depends on D82860

Diff Detail

Event Timeline

dang created this revision.Jun 30 2020, 6:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2020, 6:26 AM
dang edited the summary of this revision. (Show Details)Jun 30 2020, 6:27 AM
Bigcheese accepted this revision.Jun 30 2020, 10:50 AM

lgtm with the fix I mentioned.


This should probably be moved out so that this function only parses args and doesn't modify outside state.

This revision is now accepted and ready to land.Jun 30 2020, 10:50 AM
dang updated this revision to Diff 274541.Jun 30 2020, 10:53 AM

Move the call to UseANSIEscapeCodes to CreateFromArgs

dang marked an inline comment as done.Jun 30 2020, 10:54 AM
dang updated this revision to Diff 275187.Jul 2 2020, 11:55 AM

Make the tablegen description of the new option more consistent with other flags.

This revision was automatically updated to reflect the committed changes.