This is an archive of the discontinued LLVM Phabricator instance.

Enable FileCheck -enable-var-scope by default in MLIR test
ClosedPublic

Authored by mehdi_amini on Jun 9 2020, 9:44 PM.

Details

Summary

This option avoids to accidentally reuse variable across -LABEL match,
it can be explicitly opted-in by prefixing the variable name with $

Diff Detail

Event Timeline

mehdi_amini created this revision.Jun 9 2020, 9:44 PM
silvas accepted this revision.Jun 10 2020, 9:58 AM

Thanks! For some reason I was assuming we already had this, so seeing it turned on is great!

We might want to consider doing the same for -dump-input=fail?

This revision is now accepted and ready to land.Jun 10 2020, 9:58 AM

We might want to consider doing the same for -dump-input=fail?

Landed yesterday: https://reviews.llvm.org/D81422

jpienaar accepted this revision.Jun 10 2020, 10:01 AM
rriddle accepted this revision.Jun 11 2020, 3:40 PM

Remove dump-input=fail

This revision was automatically updated to reflect the committed changes.