This is an archive of the discontinued LLVM Phabricator instance.

[OPENMP]Consider 'omp_null_allocator' as a predefined allocator.
ClosedPublic

Authored by ABataev on Apr 30 2020, 10:52 AM.

Details

Summary

omp.h header file defines omp_null_allocator as a predefined allocator,
need to consider it also as a predefined allocator.

Diff Detail

Event Timeline

ABataev created this revision.Apr 30 2020, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2020, 10:52 AM

What would you think about moving the allocator definitions to OMPKinds.def instead of listing them explicitly? As far as I can tell we really only distinguish between predefined and user allocators, right?

What would you think about moving the allocator definitions to OMPKinds.def instead of listing them explicitly? As far as I can tell we really only distinguish between predefined and user allocators, right?

They also are used to find the base type 'omp_allocator_handle_t`. Also, what do you mean saying instead of listing them explicitly? Anyway, you will need to list all the predefined allocators to be able to distinguish predefined and user-defined allocators.

What would you think about moving the allocator definitions to OMPKinds.def instead of listing them explicitly? As far as I can tell we really only distinguish between predefined and user allocators, right?

They also are used to find the base type 'omp_allocator_handle_t`. Also, what do you mean saying instead of listing them explicitly? Anyway, you will need to list all the predefined allocators to be able to distinguish predefined and user-defined allocators.

Sure. But we can list them once in OMPKinds.def and the use a macro wherever we need all their names (or other information).

What would you think about moving the allocator definitions to OMPKinds.def instead of listing them explicitly? As far as I can tell we really only distinguish between predefined and user allocators, right?

They also are used to find the base type 'omp_allocator_handle_t`. Also, what do you mean saying instead of listing them explicitly? Anyway, you will need to list all the predefined allocators to be able to distinguish predefined and user-defined allocators.

Sure. But we can list them once in OMPKinds.def and the use a macro wherever we need all their names (or other information).

It should be a different patch.

jdoerfert accepted this revision.May 6 2020, 11:57 AM

LGTM.

What would you think about moving the allocator definitions to OMPKinds.def instead of listing them explicitly? As far as I can tell we really only distinguish between predefined and user allocators, right?

They also are used to find the base type 'omp_allocator_handle_t`. Also, what do you mean saying instead of listing them explicitly? Anyway, you will need to list all the predefined allocators to be able to distinguish predefined and user-defined allocators.

Sure. But we can list them once in OMPKinds.def and the use a macro wherever we need all their names (or other information).

It should be a different patch.

Sure. You want to look into this?

This revision is now accepted and ready to land.May 6 2020, 11:57 AM

LGTM.

What would you think about moving the allocator definitions to OMPKinds.def instead of listing them explicitly? As far as I can tell we really only distinguish between predefined and user allocators, right?

They also are used to find the base type 'omp_allocator_handle_t`. Also, what do you mean saying instead of listing them explicitly? Anyway, you will need to list all the predefined allocators to be able to distinguish predefined and user-defined allocators.

Sure. But we can list them once in OMPKinds.def and the use a macro wherever we need all their names (or other information).

It should be a different patch.

Sure. You want to look into this?

Nope, not now at least. Busy with scan directive

This revision was automatically updated to reflect the committed changes.