jkorous (Jan Korous)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2018, 2:22 AM (25 w, 6 d)

Recent Activity

Yesterday

jkorous created D53290: [WIP] clangd Transport layer.
Mon, Oct 15, 7:42 AM

Wed, Sep 26

jkorous created D52554: [WIP] [clangd] Tests for special methods code-completion.
Wed, Sep 26, 8:03 AM · Restricted Project

Tue, Sep 25

jkorous created D52495: [WIP][Sema][CodeCompletion] Add base type for double colon member completion results.
Tue, Sep 25, 7:35 AM

Fri, Sep 21

jkorous abandoned D52308: [Sema][CodeCompletion] Fix return type of C++ destructors in code completion.

Allright, I will remove destructor from clangd completion results which solves this particular issue.

Fri, Sep 21, 7:06 AM · Restricted Project

Thu, Sep 20

jkorous added a comment to D52308: [Sema][CodeCompletion] Fix return type of C++ destructors in code completion.

Sorry my bad. You are right, we aren't showing destructors in clangd for normal classes. The case where I noticed is kind of a corner case with template class.

Thu, Sep 20, 9:11 AM · Restricted Project
jkorous added a comment to D52308: [Sema][CodeCompletion] Fix return type of C++ destructors in code completion.

You might be right - I am assuming here that we want consistent behaviour between constructors and destructors.

Thu, Sep 20, 8:59 AM · Restricted Project
jkorous created D52308: [Sema][CodeCompletion] Fix return type of C++ destructors in code completion.
Thu, Sep 20, 8:38 AM · Restricted Project

Mon, Sep 17

jkorous added a comment to D51867: [Diagnostics] Add error handling to FormatDiagnostic().

Hi Volodymyr, do you think you might take another look?

Mon, Sep 17, 7:11 AM · Restricted Project

Sep 12 2018

jkorous added a comment to D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?.

I got some test failure with the patch, still investigating the issue.

Sep 12 2018, 7:57 AM · Restricted Project

Sep 10 2018

jkorous requested review of D51867: [Diagnostics] Add error handling to FormatDiagnostic().
Sep 10 2018, 2:55 PM · Restricted Project
jkorous added a comment to D51867: [Diagnostics] Add error handling to FormatDiagnostic().

I tried to come up with some input that breaks current implementation so I could add the test. Problem is that invalid memory read doesn't guarantee deterministic crash.
E. g. with this input the current implementation is definitely reading way past the buffer:

SmallVector<char, 1> IgnoreMe;
const char* Foo = "foo%";
const char* FooEnd = Foo + 4;
Diag.FormatDiagnostic(Foo, FooEnd, IgnoreMe);
Sep 10 2018, 2:55 PM · Restricted Project
jkorous retitled D51867: [Diagnostics] Add error handling to FormatDiagnostic() from [Diagnostics][NFC] Add error handling to FormatDiagnostic() to [Diagnostics] Add error handling to FormatDiagnostic().
Sep 10 2018, 11:36 AM · Restricted Project
jkorous planned changes to D51867: [Diagnostics] Add error handling to FormatDiagnostic().

Hi Volodymyr,
Thanks for the feedback - interesting points!

Sep 10 2018, 11:36 AM · Restricted Project
jkorous created D51867: [Diagnostics] Add error handling to FormatDiagnostic().
Sep 10 2018, 10:02 AM · Restricted Project
jkorous added a comment to D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?.

Sorry for the delay - I was busy with other things for past two weeks.

Sep 10 2018, 6:54 AM · Restricted Project

Aug 31 2018

jkorous created D51543: [Sema] Fix uninitialized OverloadCandidate::FoundDecl member.
Aug 31 2018, 8:16 AM · Restricted Project

Aug 30 2018

jkorous created D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?.
Aug 30 2018, 7:59 AM · Restricted Project
jkorous committed rC341074: [Sema][NFC] Trivial cleanup in ActOnCallExpr.
[Sema][NFC] Trivial cleanup in ActOnCallExpr
Aug 30 2018, 7:48 AM
jkorous committed rL341074: [Sema][NFC] Trivial cleanup in ActOnCallExpr.
[Sema][NFC] Trivial cleanup in ActOnCallExpr
Aug 30 2018, 7:47 AM
jkorous closed D51485: [Sema][NFC] Trivial cleanup in ActOnCallExpr.
Aug 30 2018, 7:47 AM · Restricted Project
jkorous created D51485: [Sema][NFC] Trivial cleanup in ActOnCallExpr.
Aug 30 2018, 4:48 AM · Restricted Project

Aug 16 2018

jkorous added a comment to D50785: [clangd][tests] Add exit(EXIT_FAILURE) in case of JSON parsing failure in TestMode.

Oh, I thought that what everyone wanted was test-specific behaviour. I like both approaches you propose much more!
If we go for the generic option we can effectively start "checking stderr" in tests by using the flag. That would be nice.

Aug 16 2018, 5:52 AM · Restricted Project
jkorous added a comment to D50740: [SourceManager] isPointWithin: avoid using isBeforeInTranslationUnit, compare buffer offsets directly for lexical correctness.

Hi Alex, nice work!

Aug 16 2018, 4:02 AM
jkorous added a reviewer for D50462: Try building complete AST after a fatal error was emitted if further diagnostics are expected: vsapsai.

Adding Volodymyr who landed related patch recently.

Aug 16 2018, 3:30 AM

Aug 15 2018

jkorous created D50785: [clangd][tests] Add exit(EXIT_FAILURE) in case of JSON parsing failure in TestMode.
Aug 15 2018, 9:16 AM · Restricted Project
jkorous committed rL339782: [clangd][tests] Rename tests of clangd instance termination.
[clangd][tests] Rename tests of clangd instance termination
Aug 15 2018, 8:59 AM
jkorous committed rCTE339782: [clangd][tests] Rename tests of clangd instance termination.
[clangd][tests] Rename tests of clangd instance termination
Aug 15 2018, 8:59 AM
jkorous committed rCTE339781: [clangd][tests] Fix typo in tests - invalid LSP exit message.
[clangd][tests] Fix typo in tests - invalid LSP exit message
Aug 15 2018, 8:53 AM
jkorous committed rL339781: [clangd][tests] Fix typo in tests - invalid LSP exit message.
[clangd][tests] Fix typo in tests - invalid LSP exit message
Aug 15 2018, 8:51 AM
jkorous closed D50641: [clangd][test] Fix exit messages in tests.
Aug 15 2018, 8:51 AM · Restricted Project

Aug 14 2018

jkorous added a comment to D50641: [clangd][test] Fix exit messages in tests.

I can see the value of getting more information in case of unexpected test behaviour but I still don't really like to have separate codepath for testing purposes.

Aug 14 2018, 10:42 AM · Restricted Project
jkorous added a comment to D50641: [clangd][test] Fix exit messages in tests.

I think that by introducing different codepath for testing purposes we might end up with fewer bugs in tests but the actual production code could become less tested. Actually, even the -lit-test itself might be not the theoretically most correct approach but I do see the practical reason for it. In general I'd rather keep the testing specific code to a minimum though.

Aug 14 2018, 3:37 AM · Restricted Project

Aug 13 2018

jkorous created D50641: [clangd][test] Fix exit messages in tests.
Aug 13 2018, 9:06 AM · Restricted Project

Aug 10 2018

jkorous planned changes to D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one.
Aug 10 2018, 9:40 AM

Aug 8 2018

jkorous added a comment to D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol.

Hi Greg, this looks interesting! I got curious about your patch since I am dealing with another protocol from the same "family" - LSP.

Aug 8 2018, 9:25 AM
jkorous abandoned D48562: [clangd] XPC transport layer.

We decided to go with a different solution:
https://reviews.llvm.org/D50452

Aug 8 2018, 8:24 AM · Restricted Project
jkorous added a comment to D48559: [clangd] refactoring for XPC transport layer [NFCI].

Hi, we decided to go with a different solution:
https://reviews.llvm.org/D50452

Aug 8 2018, 8:23 AM · Restricted Project
jkorous abandoned D49548: [clangd] XPC WIP.

We decided to abandon this direction in favor of simpler solution.
https://reviews.llvm.org/D50452

Aug 8 2018, 8:22 AM
jkorous created D50452: [WIP] clangd XPC adapter.
Aug 8 2018, 8:20 AM

Jul 26 2018

jkorous added a comment to D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one.

I like that idea! It looks like it's living in a wrong place anyway as it doesn't need access to any of implementation details (private members) of DiagnosticID. I would still like to preserve it as a function so this block of code has clear semantics and interface.
How about I refactor it to a static free function in Warnings.cpp?

Jul 26 2018, 3:50 AM

Jul 25 2018

jkorous planned changes to D48562: [clangd] XPC transport layer.
Jul 25 2018, 6:41 AM · Restricted Project
jkorous planned changes to D48560: [clangd] JSON <-> XPC conversions.
Jul 25 2018, 6:41 AM · Restricted Project
jkorous planned changes to D49548: [clangd] XPC WIP.
Jul 25 2018, 6:41 AM
jkorous planned changes to D48559: [clangd] refactoring for XPC transport layer [NFCI].

Hi Sam, we are still discussing internally how to fit clangd and XPC together. Please bear with us and ignore our patches until we decide.

Jul 25 2018, 6:39 AM · Restricted Project

Jul 24 2018

jkorous retitled D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one from [Basic] Emit warning flag suggestion only in case there's *similar* existing flag for given unknown one to [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one.
Jul 24 2018, 8:24 AM
jkorous created D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one.
Jul 24 2018, 8:24 AM

Jul 20 2018

jkorous added a comment to D49523: [clangd] Add support for per-file override compilation command.

BTW it looks like we already had kind of support for compilation command before (extra flags).

Jul 20 2018, 7:48 AM · Restricted Project
jkorous added a comment to D48562: [clangd] XPC transport layer.

BTW Just for the record - I put the rebased & updated patch here: [clangd] XPC WIP https://reviews.llvm.org/D49548

Jul 20 2018, 6:04 AM · Restricted Project
jkorous added a comment to D48560: [clangd] JSON <-> XPC conversions.

BTW Just for the record - I put the rebased & updated patch here: [clangd] XPC WIP https://reviews.llvm.org/D49548

Jul 20 2018, 6:04 AM · Restricted Project
jkorous added a comment to D48559: [clangd] refactoring for XPC transport layer [NFCI].

BTW Just for the record - I put the rebased & updated patch here: [clangd] XPC WIP https://reviews.llvm.org/D49548

Jul 20 2018, 6:03 AM · Restricted Project
jkorous added a comment to D48559: [clangd] refactoring for XPC transport layer [NFCI].

Hi Sam, we discussed a bit more with Alex offline. Ultimately we don't mind using JSON as part of the generic interface but we'd like to optimize specific cases in the future (thinking only about code completion so far) which might need to "work-around" the abstraction. What is your opinion about this - does it ruin the whole point of having the abstraction or do you consider pragmatic to have abstraction covering most of the functionality with maybe couple exceptions? I kind of assume (please correct me if I am wrong) that you might have done something similar with profobuf interface so we're definitely happy to discuss.

Jul 20 2018, 6:02 AM · Restricted Project
jkorous added a comment to D49523: [clangd] Add support for per-file override compilation command.

Alex, I am just wondering if we shouldn't rather create another implementation of GlobalCompilationDatabase interface (something like InMemoryGlobalCompilationDatabase), add it to ClangdServer and use it as the first place to be searched in ClangdServer::getCompileCommand(PathRef File). What do you think?

Jul 20 2018, 5:53 AM · Restricted Project
jkorous added a comment to D49523: [clangd] Add support for per-file override compilation command.

Hi Marc-Andre, what is a structure of data you are passing as parameter of didChangeConfiguration message? All we need is to pass per-file compilation command to clangd. Maybe we could send didChangeConfiguration message right after didOpen.

Jul 20 2018, 5:48 AM · Restricted Project

Jul 19 2018

jkorous added a comment to D48559: [clangd] refactoring for XPC transport layer [NFCI].

Sam, just out of curiosity - would it be possible for you to share any relevant experience gained by using porting clangd to protobuf-based transport layer?

Jul 19 2018, 8:48 AM · Restricted Project
jkorous created D49548: [clangd] XPC WIP.
Jul 19 2018, 8:34 AM
jkorous added inline comments to D48562: [clangd] XPC transport layer.
Jul 19 2018, 8:14 AM · Restricted Project
jkorous added inline comments to D48560: [clangd] JSON <-> XPC conversions.
Jul 19 2018, 7:50 AM · Restricted Project
jkorous accepted D48786: [Preprocessor] Stop entering included files after hitting a fatal error..

LGTM with just a nit about comment wording.

Jul 19 2018, 4:02 AM

Jul 18 2018

jkorous added a reviewer for D48786: [Preprocessor] Stop entering included files after hitting a fatal error.: jkorous.
Jul 18 2018, 2:20 AM

Jul 17 2018

jkorous added a reviewer for D48562: [clangd] XPC transport layer: sammccall.

Hi Sam, I am definitely open to discussion about the right abstraction.

Jul 17 2018, 10:21 AM · Restricted Project
jkorous added a comment to D48559: [clangd] refactoring for XPC transport layer [NFCI].

Hi Sam, thanks for your feedback!

Jul 17 2018, 9:03 AM · Restricted Project

Jul 16 2018

jkorous added a comment to D48560: [clangd] JSON <-> XPC conversions.

Hi Sam, no worries! Thanks for making time to take a look! I am going to rebase all my patches on top of JSON library moved to llvm/Support and process your comments.

Jul 16 2018, 1:47 PM · Restricted Project

Jul 13 2018

Herald updated subscribers of D38708: [AST] Flag the typo-corrected nodes for better tooling.
Jul 13 2018, 3:45 AM

Jul 11 2018

jkorous added a reviewer for D48560: [clangd] JSON <-> XPC conversions: arphaman.
Jul 11 2018, 8:50 AM · Restricted Project
jkorous added a comment to D48559: [clangd] refactoring for XPC transport layer [NFCI].

Ping. Added reviewers suggestion.

Jul 11 2018, 8:49 AM · Restricted Project
jkorous added reviewers for D48559: [clangd] refactoring for XPC transport layer [NFCI]: ilya-biryukov, sammccall, malaperle.
Jul 11 2018, 8:48 AM · Restricted Project

Jun 26 2018

jkorous updated the diff for D48562: [clangd] XPC transport layer.

Two changes in test client based on internal review by XPC folks:

  • Removed cleanup code at the end of main() as dispatch_main() never returns.
  • Removed check for conn as xpc_connection_create() is guaranteed to succeed.
Jun 26 2018, 7:35 AM · Restricted Project
jkorous added inline comments to D48562: [clangd] XPC transport layer.
Jun 26 2018, 7:31 AM · Restricted Project

Jun 25 2018

jkorous added a comment to D48559: [clangd] refactoring for XPC transport layer [NFCI].

Followed by these two patches:
[clangd] JSON <-> XPC conversions
https://reviews.llvm.org/D48560
[clangd] XPC transport layer
https://reviews.llvm.org/D48562

Jun 25 2018, 1:30 PM · Restricted Project
jkorous created D48562: [clangd] XPC transport layer.
Jun 25 2018, 1:09 PM · Restricted Project
jkorous created D48560: [clangd] JSON <-> XPC conversions.
Jun 25 2018, 1:05 PM · Restricted Project
jkorous created D48559: [clangd] refactoring for XPC transport layer [NFCI].
Jun 25 2018, 1:02 PM · Restricted Project

Jun 5 2018

jkorous committed rL334062: [Sema] Fix parsing of anonymous union in language linkage specification.
[Sema] Fix parsing of anonymous union in language linkage specification
Jun 5 2018, 10:21 PM
jkorous committed rC334062: [Sema] Fix parsing of anonymous union in language linkage specification.
[Sema] Fix parsing of anonymous union in language linkage specification
Jun 5 2018, 10:20 PM
jkorous closed D45884: [Sema] Fix parsing of anonymous union in language linkage specification.
Jun 5 2018, 10:20 PM · Restricted Project

Jun 4 2018

jkorous accepted D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer.

Thank you for the explanation!

Jun 4 2018, 4:48 PM

May 31 2018

jkorous added a reviewer for D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer: jkorous.
May 31 2018, 9:52 AM
jkorous added a comment to D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer.

I don't particularly like that between setting the DeclContext (SemaTemplateDeduction.cpp:3814) and actually using it (CheckAccess() in SemaAccess.cpp:1459) are some 20 stack frames but it looks like you already tried fixing this "locally" in your initial approach.

May 31 2018, 9:52 AM

May 17 2018

jkorous committed rC332598: Use dotted format of version tuple for availability diagnostics.
Use dotted format of version tuple for availability diagnostics
May 17 2018, 4:56 AM
jkorous committed rL332598: Use dotted format of version tuple for availability diagnostics.
Use dotted format of version tuple for availability diagnostics
May 17 2018, 4:55 AM
jkorous closed D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.
May 17 2018, 4:55 AM · Restricted Project

May 16 2018

jkorous updated the diff for D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

After some internal discussion we agreed that we can simplify things and get consistent behaviour by using dot everywhere in diagnostics.

May 16 2018, 2:36 PM · Restricted Project
jkorous added a comment to D46485: Add python tool to dump and construct header maps.

LGTM but my review was fairly superficial.

May 16 2018, 1:26 PM
jkorous abandoned D46834: [Sema][Cxx17] Error message for C++17 static_assert(pred) without string literal.

We reconsidered this in light of the policy - thanks for pointing that out Richard!
Just to be sure that I understand it - the policy is meant for CLI and not serialized diagnostics, right?

May 16 2018, 10:12 AM · Restricted Project
jkorous added a comment to D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

Eric, thanks for the context. I am now clarifying internally and if possible would like to simplify the whole format business by using just one delimiter everywhere. Would that make sense to you or do you think we should respect delimiter used in sources?

May 16 2018, 4:51 AM · Restricted Project

May 15 2018

jkorous planned changes to D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

Sorry for me being dense here - since the output format is determined by input source code there's more work to do.

May 15 2018, 10:19 AM · Restricted Project
jkorous planned changes to D46834: [Sema][Cxx17] Error message for C++17 static_assert(pred) without string literal.
May 15 2018, 6:33 AM · Restricted Project
jkorous added a comment to D46485: Add python tool to dump and construct header maps.

Hi Bruno, I just noticed couple of implementation details.

May 15 2018, 3:30 AM

May 14 2018

jkorous created D46834: [Sema][Cxx17] Error message for C++17 static_assert(pred) without string literal.
May 14 2018, 9:07 AM · Restricted Project
jkorous added a comment to D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

I am not 100% sure it's the best thing to set printing style at the point of parsing version tuples but I am not sure it's bad either. Unless someone convinces me otherwise I would rather not do any major changes.

May 14 2018, 7:32 AM · Restricted Project
jkorous updated the diff for D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

Fixed the test. It turned out that version component separator for availability is set during parsing which is why all other tests (including my bad one) are passing.

May 14 2018, 7:31 AM · Restricted Project

May 11 2018

jkorous planned changes to D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

Sorry, my bad. I tried to get rid of dependency on Foundation.h and didn't check the test is relevant for the fix after that.

May 11 2018, 8:47 AM · Restricted Project
jkorous created D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.
May 11 2018, 4:46 AM · Restricted Project

May 1 2018

jkorous added inline comments to D45884: [Sema] Fix parsing of anonymous union in language linkage specification.
May 1 2018, 8:11 AM · Restricted Project
jkorous added a comment to D45884: [Sema] Fix parsing of anonymous union in language linkage specification.

Volodymyr, could you please confirm that the non-anonymous vs non-inline logic makes sense to you?

May 1 2018, 8:08 AM · Restricted Project

Apr 24 2018

jkorous updated the diff for D45884: [Sema] Fix parsing of anonymous union in language linkage specification.

Addressed comments + proposal for refactoring of the namespace-related logic.

Apr 24 2018, 7:00 AM · Restricted Project

Apr 23 2018

jkorous closed D45763: [clangd][tests] Fix handling of EOF in delimited input.

I forgot to mention review in commit message.

Apr 23 2018, 9:03 AM · Restricted Project
jkorous committed rCTE330609: [clangd][tests] Fix delimiter handling.
[clangd][tests] Fix delimiter handling
Apr 23 2018, 9:02 AM
jkorous committed rL330609: [clangd][tests] Fix delimiter handling.
[clangd][tests] Fix delimiter handling
Apr 23 2018, 9:02 AM
jkorous closed D45764: [clangd][tests] Fix delimiter handling.
Apr 23 2018, 9:02 AM · Restricted Project