- User Since
- Apr 18 2018, 2:22 AM (65 w, 5 d)
Mon, Jul 15
I'd add a test with non-empty non-LSP dictionary to specifically test that we're ignoring the content. I like const-correctness but that's up to you. Otherwise LGTM.
Fri, Jul 12
Thu, Jul 11
Tue, Jul 9
Thanks for the revert.
Mon, Jul 8
Fri, Jun 28
Jun 20 2019
I don't have the insight to LGTM the whole change - just a nit about implementation detail.
Jun 19 2019
Jun 5 2019
Jun 3 2019
- factory method for SemaphorePipe
- *_CLOEXEC flags
I fixed the rest.
Thanks, I didn't know it's generated.
Fix in the header file from which the documentation is actually generated.
May 31 2019
You're right, thanks for letting me know.
May 30 2019
May 29 2019
May 28 2019
One more thing.
May 24 2019
- simplify link libraries in cmake
- fix Release build (messed-up asserts)
Specify what "file modified" means and add a test for metadata change
May 23 2019
Reimplemented tests with std::futures which allowed to use more generous timeout while not slowing down the happy paths.
May 22 2019
Thanks for taking a look Kadir!
After yesterday's discussion with Dmitri I removed all those busy waits. Seems like the code is not much more complex now. I am going to update the diff and off to fixing the tests.
Remove busy waits.
May 20 2019
Changed semantics of one of std::atomic<bool> in linux implementation.
I addressed most of the comments.
Thanks for taking a look @gribozavr!
May 17 2019
fix link libraries in cmake
May 15 2019
A major clean-up.
May 13 2019
May 6 2019
Hi @VelocityRa, just FYI - it's considered fine to ping your reviewers once per week here if you've addressed their comments and there's no activity in the review. Sometimes people just get distracted by other things.
May 3 2019
May 2 2019
May 1 2019
@gribozavr thanks for the feedback. I'm rewriting the patch now as I figured out my detection of comments preceding declarations is unsound.
Apr 29 2019
Patch with fix for XPC tests https://reviews.llvm.org/D61271
Apr 26 2019
- moved assert
Apr 25 2019
- if => assert
Also, IIUC the test case that I deleted wasn't actually supposed to produce any diagnostics and the fact that it did was a bug. We could keep it as a regression test but I think it has a rather low value. WDYT?
Abandonned in favor of https://reviews.llvm.org/D61103