- User Since
- Apr 18 2018, 2:22 AM (214 w, 3 d)
Wed, May 18
Tue, May 10
Reverting for now. Will take a look.
Mon, May 9
Mon, May 2
Apr 22 2022
Made the tests consistent with other pre-existing tests.
Apr 7 2022
Sure, will do! I intended to keep the tests simple but understand the desire for consistency.
Apr 6 2022
Feb 16 2022
Feb 15 2022
Feb 14 2022
I noticed ReadVBR64 method below does the same arithmetics and keeping the implementation in sync seems like a no-brainer.
switched to assert
added the assert also to ReadVBR64
Feb 11 2022
@nikic Sorry, my statement was incorrect. What I meant is that the method doesn't prevent UB via assert or runtime check of NumBits value.
I'm happy to go with assert if that'd be a better fit.
rebased + improved error messages
Feb 8 2022
Jan 28 2022
I verified locally that reverting this patch fixes the build.
Reverted in fad7e491a0770ac4336934030ac67d77e7af5520 to unblock Green Dragon, etc.
@aaron.ballman Please take a look when you get a chance.
@aaron.ballman I believe this change broke the build starting with:
Jan 24 2022
Jan 21 2022
Nov 15 2021
Nov 11 2021
LGTM if we have test coverage for all the cases.
Nov 4 2021
Hi! Thank you for the clean-up :)
Apr 29 2021
I will send an email to llvm-dev@ and add a release note once I finish that.
I just realized that for -fsanitize-recover the logic is inverted - it's actually -fno-sanitize-recover that's an explicit change from the default.
I will probably need to do the same thing I do for traps.
Apr 28 2021
Mar 4 2021
Adding the comment would be great.
Dec 14 2020
Thanks for working on this!
Oct 29 2020
Oct 22 2020
Oct 17 2020
Sep 29 2020
Sep 28 2020
Sounds interesting but I lack context to imagine the details. Would the map be still initialized by some ASTVisitor? Do you think there'd be any noticeable performance hit?
Had to fix the order of expected warnings in warning-wall.c
6fd8c69049a8 [clang] Update warning-wall.c test
I'd like to land this sooner than later - I agree it'd be great to have a regression test but my (possibly biased) opinion is that the change is also simple and obvious enough that we could land it without a test.
Sep 25 2020
Sep 22 2020
Created this for eventual post-commit review.
I made a typo in the commit message reference so this revision didn't get closed automatically.
Thank you Artem!
Sep 21 2020
Thank you both for all the hints!
Simply check memory regions of LHS and RHS in assignments instead of AST pattern matching.
Nits were addressed (hopefully).
Sep 18 2020
Attempt to write a unit test - so far can't reproduce even with unpatched master :(
Sep 16 2020
Sep 15 2020
Sep 14 2020
Sep 8 2020
Sep 4 2020
- added tests
Sorry to bother you @NoQ - it'd be awesome if you could take a look!