- User Since
- Apr 18 2018, 2:22 AM (74 w, 1 d)
Wed, Sep 18
Tue, Sep 17
Good point! Thanks.
Fri, Sep 13
Thu, Sep 12
Wed, Sep 11
Abandoned in favor of: https://reviews.llvm.org/D67475
I realized there was an issue with adding the -o /dev/null to arguemnts in case when there was a -MD flag as Driver later adds -MT with the last -o value in case there's no -MT or -MQ. That means that for headers the target would always be /dev/null.
@dexonsmith pointed out that we could just conditionally add -MT in the adjustment. Also, we can use build directory instead of CDB index.
Tue, Sep 10
Mon, Sep 9
- prefix dependency targets with CDB index
- updated tests
Fri, Sep 6
- renamed functions to suggest their limitations
- added one more test
Rebased on TOT and removed noise from the patch as I've already landed couple refactoring patches.
Thu, Sep 5
Wed, Sep 4
Thanks for polishing this!
Tue, Sep 3
There are actually couple other fatal-error-handling strategies. But all the other I've seen raise a signal (mostly SIGABRT; SIGILL in case of LLVM_BUILTIN_TRAP). For the purpose of having a way how to ask libclang to crash in a way that might lead to core dump this seems fine. Uninstalling the handler doesn't lead to libclang just calling exit in case of any crash though. Maybe I should rename the functions? Open to suggestions...
It turned out that recovery context matters as it messes with signals.
Added a proper test.
Wed, Aug 28
How to minimize a patch to nothing:
Hmm, actually if we replace Buffer in the interface with a llvm::function_ref<void(llvm::raw_ostream &)> callback it would cover couple other existing uses of createUniqueFile.
Good points as always. Thanks!
Otherwise LGTM. Thanks for refactoring this!
Tue, Aug 27
- Split off change to IndexDataConsumer.
I'll start splitting off some self-standing parts that won't be affected by hypothetical changes at the FrontendAction/ASTConsumer level.