jkorous (Jan Korous)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2018, 2:22 AM (5 w, 18 h)

Recent Activity

Thu, May 17

jkorous committed rC332598: Use dotted format of version tuple for availability diagnostics.
Use dotted format of version tuple for availability diagnostics
Thu, May 17, 4:56 AM
jkorous committed rL332598: Use dotted format of version tuple for availability diagnostics.
Use dotted format of version tuple for availability diagnostics
Thu, May 17, 4:55 AM
jkorous closed D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.
Thu, May 17, 4:55 AM · Restricted Project

Wed, May 16

jkorous updated the diff for D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

After some internal discussion we agreed that we can simplify things and get consistent behaviour by using dot everywhere in diagnostics.

Wed, May 16, 2:36 PM · Restricted Project
jkorous added a comment to D46485: Add python tool to dump and construct header maps.

LGTM but my review was fairly superficial.

Wed, May 16, 1:26 PM
jkorous abandoned D46834: [Sema][Cxx17] Error message for C++17 static_assert(pred) without string literal.

We reconsidered this in light of the policy - thanks for pointing that out Richard!
Just to be sure that I understand it - the policy is meant for CLI and not serialized diagnostics, right?

Wed, May 16, 10:12 AM · Restricted Project
jkorous added a comment to D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

Eric, thanks for the context. I am now clarifying internally and if possible would like to simplify the whole format business by using just one delimiter everywhere. Would that make sense to you or do you think we should respect delimiter used in sources?

Wed, May 16, 4:51 AM · Restricted Project

Tue, May 15

jkorous planned changes to D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

Sorry for me being dense here - since the output format is determined by input source code there's more work to do.

Tue, May 15, 10:19 AM · Restricted Project
jkorous planned changes to D46834: [Sema][Cxx17] Error message for C++17 static_assert(pred) without string literal.
Tue, May 15, 6:33 AM · Restricted Project
jkorous added a comment to D46485: Add python tool to dump and construct header maps.

Hi Bruno, I just noticed couple of implementation details.

Tue, May 15, 3:30 AM

Mon, May 14

jkorous created D46834: [Sema][Cxx17] Error message for C++17 static_assert(pred) without string literal.
Mon, May 14, 9:07 AM · Restricted Project
jkorous added a comment to D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

I am not 100% sure it's the best thing to set printing style at the point of parsing version tuples but I am not sure it's bad either. Unless someone convinces me otherwise I would rather not do any major changes.

Mon, May 14, 7:32 AM · Restricted Project
jkorous updated the diff for D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

Fixed the test. It turned out that version component separator for availability is set during parsing which is why all other tests (including my bad one) are passing.

Mon, May 14, 7:31 AM · Restricted Project

Fri, May 11

jkorous planned changes to D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.

Sorry, my bad. I tried to get rid of dependency on Foundation.h and didn't check the test is relevant for the fix after that.

Fri, May 11, 8:47 AM · Restricted Project
jkorous created D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts.
Fri, May 11, 4:46 AM · Restricted Project

Tue, May 1

jkorous added inline comments to D45884: [Sema] Fix parsing of anonymous union in language linkage specification.
Tue, May 1, 8:11 AM · Restricted Project
jkorous added a comment to D45884: [Sema] Fix parsing of anonymous union in language linkage specification.

Volodymyr, could you please confirm that the non-anonymous vs non-inline logic makes sense to you?

Tue, May 1, 8:08 AM · Restricted Project

Tue, Apr 24

jkorous updated the diff for D45884: [Sema] Fix parsing of anonymous union in language linkage specification.

Addressed comments + proposal for refactoring of the namespace-related logic.

Tue, Apr 24, 7:00 AM · Restricted Project

Apr 23 2018

jkorous closed D45763: [clangd][tests] Fix handling of EOF in delimited input.

I forgot to mention review in commit message.

Apr 23 2018, 9:03 AM · Restricted Project
jkorous committed rCTE330609: [clangd][tests] Fix delimiter handling.
[clangd][tests] Fix delimiter handling
Apr 23 2018, 9:02 AM
jkorous committed rL330609: [clangd][tests] Fix delimiter handling.
[clangd][tests] Fix delimiter handling
Apr 23 2018, 9:02 AM
jkorous closed D45764: [clangd][tests] Fix delimiter handling.
Apr 23 2018, 9:02 AM · Restricted Project
jkorous committed rL330608: [clangd][tests] Fix handling of EOF in delimited input.
[clangd][tests] Fix handling of EOF in delimited input
Apr 23 2018, 8:58 AM
jkorous committed rCTE330608: [clangd][tests] Fix handling of EOF in delimited input.
[clangd][tests] Fix handling of EOF in delimited input
Apr 23 2018, 8:58 AM
jkorous added a reviewer for D45884: [Sema] Fix parsing of anonymous union in language linkage specification: doug.gregor.
Apr 23 2018, 7:35 AM · Restricted Project

Apr 20 2018

jkorous created D45884: [Sema] Fix parsing of anonymous union in language linkage specification.
Apr 20 2018, 8:07 AM · Restricted Project

Apr 19 2018

jkorous added a comment to D45764: [clangd][tests] Fix delimiter handling.

[ultranit] Sorry, just to be sure - did you really mean any number of dashes

Apr 19 2018, 6:20 AM · Restricted Project
jkorous added a comment to D45763: [clangd][tests] Fix handling of EOF in delimited input.

By "Comments should be allowed at the end of test files." I meant that we shouldn't log it as an exceptional state. Should've worded that better.

Apr 19 2018, 6:10 AM · Restricted Project
jkorous updated the diff for D45763: [clangd][tests] Fix handling of EOF in delimited input.

Include the correct test.

Apr 19 2018, 6:05 AM · Restricted Project

Apr 18 2018

jkorous committed rL330254: [Sema] Disable built-in increment operator for bool in overload resolution in….
[Sema] Disable built-in increment operator for bool in overload resolution in…
Apr 18 2018, 6:43 AM
jkorous committed rC330254: [Sema] Disable built-in increment operator for bool in overload resolution in….
[Sema] Disable built-in increment operator for bool in overload resolution in…
Apr 18 2018, 6:43 AM
jkorous closed D45569: [Sema] Disable built-in increment operator for bool in overload resolution in C++17.
Apr 18 2018, 6:43 AM
jkorous added a reviewer for D45764: [clangd][tests] Fix delimiter handling: sammccall.

Hi Sam, could you please take a look at this minor fix?

Apr 18 2018, 5:46 AM · Restricted Project
jkorous added a reviewer for D45763: [clangd][tests] Fix handling of EOF in delimited input: sammccall.

Hi Sam, could you please take a look at this minor fix?

Apr 18 2018, 5:46 AM · Restricted Project
jkorous created D45764: [clangd][tests] Fix delimiter handling.
Apr 18 2018, 5:44 AM · Restricted Project
jkorous created D45763: [clangd][tests] Fix handling of EOF in delimited input.
Apr 18 2018, 5:42 AM · Restricted Project