Page MenuHomePhabricator

jkorous (Jan Korous)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2018, 2:22 AM (91 w, 3 d)

Recent Activity

Thu, Jan 16

jkorous updated the summary of D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS.
Thu, Jan 16, 5:28 PM · Restricted Project
jkorous committed rG42b3c38903c9: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when… (authored by jkorous).
[clangd][test] Disable a particular testcase in FindExplicitReferencesTest when…
Thu, Jan 16, 3:15 PM
jkorous closed D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS.
Thu, Jan 16, 3:13 PM · Restricted Project
jkorous created D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS.
Thu, Jan 16, 3:04 PM · Restricted Project

Wed, Jan 15

jkorous added a comment to D72729: [clang][test] Use more widely supported sanitizer for file dependency tests.

This was meant as a post-commit review
https://github.com/llvm/llvm-project/commit/986202fad41529af8288aca54f2ff62d4c501d71

Wed, Jan 15, 1:49 PM

Tue, Jan 14

jkorous committed rG986202fad415: [clang][test][NFC] Use more widely supported sanitizer for file dependency tests (authored by jkorous).
[clang][test][NFC] Use more widely supported sanitizer for file dependency tests
Tue, Jan 14, 12:59 PM
jkorous created D72729: [clang][test] Use more widely supported sanitizer for file dependency tests.
Tue, Jan 14, 12:50 PM

Fri, Jan 10

jkorous committed rGf28972facc1f: [clang] Fix out-of-bounds memory access in ComputeLineNumbers (authored by jkorous).
[clang] Fix out-of-bounds memory access in ComputeLineNumbers
Fri, Jan 10, 11:27 AM
jkorous closed D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.
Fri, Jan 10, 11:27 AM · Restricted Project

Thu, Jan 9

jkorous updated the diff for D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

polish test

Thu, Jan 9, 3:24 PM · Restricted Project
jkorous updated the diff for D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

test

Thu, Jan 9, 2:28 PM · Restricted Project
jkorous added a comment to D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

(and a delete[])

Thu, Jan 9, 2:28 PM · Restricted Project
jkorous added a comment to D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

Oh, I will just add some ASSERT to the test and a comment on what it actually tests.

Thu, Jan 9, 2:28 PM · Restricted Project
jkorous added a comment to D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

Ok, seems such test fails reliably (on macOS).

Thu, Jan 9, 2:28 PM · Restricted Project

Wed, Jan 8

jkorous updated the diff for D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

calculate the size of the buffer upfront

Wed, Jan 8, 4:14 PM · Restricted Project
jkorous added a comment to D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.

I tried but couldn't reproduce a segfault. Do you have any suggestion on how to reasonably reliably (TM) reproduce it?

Wed, Jan 8, 4:14 PM · Restricted Project
jkorous created D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers.
Wed, Jan 8, 12:41 PM · Restricted Project

Dec 12 2019

jkorous committed rGffbca84f6813: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:52 PM
jkorous committed rGf3a25928a172: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:51 PM
jkorous committed rGf85af0d4fdac: Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift
Dec 12 2019, 2:50 PM
jkorous committed rGa0f879077039: [indexstore] Add INDEXSTORE_SYMBOL_ROLE_NAMEREFERENCE (authored by jkorous).
[indexstore] Add INDEXSTORE_SYMBOL_ROLE_NAMEREFERENCE
Dec 12 2019, 2:46 PM
jkorous committed rGf3e88483aa80: [indexstore] Handle enum value SymbolRole::NameReference (authored by jkorous).
[indexstore] Handle enum value SymbolRole::NameReference
Dec 12 2019, 2:46 PM
jkorous committed rG4b5a39a09051: Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift
Dec 12 2019, 2:44 PM
jkorous committed rG4ab21f75f7c5: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:42 PM
jkorous committed rG2b2c20fb1757: [clang][Index] Replace CodegenNameGenerator with ASTNameGenerator vol. III (authored by jkorous).
[clang][Index] Replace CodegenNameGenerator with ASTNameGenerator vol. III
Dec 12 2019, 2:42 PM
jkorous committed rG0972e5e1b3e2: Revert "Revert a commit series that leads to a tricky merge until Jan can take… (authored by jkorous).
Revert "Revert a commit series that leads to a tricky merge until Jan can take…
Dec 12 2019, 2:40 PM
jkorous committed rG38811eed731a: [DirectoryWatcher][NFC] Remove dead-code (authored by jkorous).
[DirectoryWatcher][NFC] Remove dead-code
Dec 12 2019, 2:19 PM
jkorous committed rG6107c172e1f3: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:15 PM
jkorous committed rG431d3324ada6: Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift
Dec 12 2019, 2:13 PM
jkorous committed rGdcdc1f485e06: [IndexStore] Remove modification time (authored by jkorous).
[IndexStore] Remove modification time
Dec 12 2019, 2:13 PM
jkorous committed rG3dab785d525e: [IndexStore] Changed enum values (authored by jkorous).
[IndexStore] Changed enum values
Dec 12 2019, 2:13 PM
jkorous committed rG08d7efb59c9b: Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org-proper/master' into upstream-with-swift
Dec 12 2019, 2:12 PM
jkorous committed rGf9ba6ea709c4: Merge remote-tracking branch 'llvm.org/master' into HEAD (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into HEAD
Dec 12 2019, 12:51 PM
jkorous committed rG1797ada246b3: Merge remote-tracking branch 'github/master' into HEAD (authored by jkorous).
Merge remote-tracking branch 'github/master' into HEAD
Dec 12 2019, 12:48 PM
jkorous committed rG01adc36b7fd4: Merge remote-tracking branch 'github/upstream-with-swift' into HEAD (authored by jkorous).
Merge remote-tracking branch 'github/upstream-with-swift' into HEAD
Dec 12 2019, 12:48 PM
jkorous committed rGd564605c3d80: Revert "Merge remote-tracking branch 'github/upstream-with-swift' into HEAD" (authored by jkorous).
Revert "Merge remote-tracking branch 'github/upstream-with-swift' into HEAD"
Dec 12 2019, 12:48 PM
jkorous committed rG7c104527dea9: Merge remote-tracking branch 'llvm.org/master' into HEAD (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into HEAD
Dec 12 2019, 12:21 PM
jkorous committed rGb50764c6ace8: Merge remote-tracking branch 'llvm.org/master' into HEAD (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into HEAD
Dec 12 2019, 12:21 PM
jkorous committed rG1e5a69077811: Fix incorrect merge conflict resolution from 68571b25294 (authored by jkorous).
Fix incorrect merge conflict resolution from 68571b25294
Dec 12 2019, 12:18 PM
jkorous committed rG7535d57c3c6b: Merge remote-tracking branch 'llvm.org/master' into 'upstream-with-swift' (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into 'upstream-with-swift'
Dec 12 2019, 12:18 PM
jkorous committed rG67dac80a6e69: Merge remote-tracking branch 'llvm.org/master' into 'github/upstream-with-swift' (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into 'github/upstream-with-swift'
Dec 12 2019, 12:18 PM
jkorous committed rG2b4e6c67d56a: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:16 PM
jkorous committed rG81a64df93a15: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:15 PM
jkorous committed rG9c637eafad10: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:15 PM
jkorous committed rGcb5481575515: Merge remote-tracking branch 'llvm.org/master' into HEAD (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into HEAD
Dec 12 2019, 12:15 PM

Dec 4 2019

jkorous added a comment to D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac..

The use of xcrun looks sound to me.

Dec 4 2019, 11:47 AM · Restricted Project

Dec 2 2019

jkorous added a comment to D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface.

Hi @arthurp, I can review the libclang part of the patch.

Dec 2 2019, 11:29 AM · Restricted Project

Nov 21 2019

jkorous added inline comments to D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC.
Nov 21 2019, 2:03 PM

Nov 19 2019

jkorous added inline comments to D70440: [Driver] Use VFS to check if sanitizer blacklists exist.
Nov 19 2019, 11:29 AM · Restricted Project, Restricted Project
jkorous awarded D70288: [ADT][Expensive checks] Create a /dev/random seed only once when shuffling the range before sorting it to avoid bot timeouts a Like token.
Nov 19 2019, 11:27 AM · Restricted Project
jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

Ahh, right. I originally wanted to support -ivfsoverlay in Driver as it seemed reasonable to check the existence of blacklist in Driver and open it in cc1 using the same fs. I got talked out of it and I didn't touch the Driver but seems like I should've replaced the calls to native fs with VFS to keep things consistent. Thanks for picking this up!

Nov 19 2019, 11:11 AM · Restricted Project, Restricted Project

Nov 8 2019

jkorous committed rG99e2cba219ae: Reland "[compiler-rt] Fix tests after 03b84e4f6d0" (authored by jkorous).
Reland "[compiler-rt] Fix tests after 03b84e4f6d0"
Nov 8 2019, 2:34 PM
jkorous added a reverting change for rGd6be9273c603: Revert "[compiler-rt] Fix tests after 03b84e4f6d0": rG99e2cba219ae: Reland "[compiler-rt] Fix tests after 03b84e4f6d0".
Nov 8 2019, 2:34 PM
jkorous added a reverting change for rGcae4a28864f4: Reland "[clang] Report sanitizer blacklist as a dependency in cc1": rGd52cff88367d: Revert "Reland "[clang] Report sanitizer blacklist as a dependency in cc1"".
Nov 8 2019, 2:34 PM
jkorous committed rGd52cff88367d: Revert "Reland "[clang] Report sanitizer blacklist as a dependency in cc1"" (authored by jkorous).
Revert "Reland "[clang] Report sanitizer blacklist as a dependency in cc1""
Nov 8 2019, 2:34 PM
jkorous committed rG555c6be041d4: [clang] Fix -fsanitize-system-blacklist processing in cc1 (authored by jkorous).
[clang] Fix -fsanitize-system-blacklist processing in cc1
Nov 8 2019, 2:06 PM
jkorous committed rGcae4a28864f4: Reland "[clang] Report sanitizer blacklist as a dependency in cc1" (authored by jkorous).
Reland "[clang] Report sanitizer blacklist as a dependency in cc1"
Nov 8 2019, 2:06 PM
jkorous committed rG6d28588cc0f2: Reland "[clang] Report sanitizer blacklist as a dependency in cc1" (authored by jkorous).
Reland "[clang] Report sanitizer blacklist as a dependency in cc1"
Nov 8 2019, 2:06 PM
jkorous added a reverting change for rG3182027282c5: Revert "Revert "[clang] Report sanitizer blacklist as a dependency in cc1"": rGcae4a28864f4: Reland "[clang] Report sanitizer blacklist as a dependency in cc1".
Nov 8 2019, 2:06 PM
jkorous added a reverting change for rG9b8413ac6e56: Revert "Revert "Revert "[clang] Report sanitizer blacklist as a dependency in…: rG6d28588cc0f2: Reland "[clang] Report sanitizer blacklist as a dependency in cc1".
Nov 8 2019, 2:06 PM
jkorous committed rG590f279c456b: [clang] Add VFS support for sanitizers' blacklists (authored by jkorous).
[clang] Add VFS support for sanitizers' blacklists
Nov 8 2019, 11:03 AM
jkorous closed D69648: Add VFS support for sanitizers' blacklist' 2.
Nov 8 2019, 11:03 AM · Restricted Project, Restricted Project

Nov 7 2019

jkorous committed rGbdeb2724f0aa: [compiler-rt] Fix tests after 03b84e4f6d0 (authored by jkorous).
[compiler-rt] Fix tests after 03b84e4f6d0
Nov 7 2019, 2:45 PM
jkorous committed rG03b84e4f6d0e: [clang] Report sanitizer blacklist as a dependency in cc1 (authored by jkorous).
[clang] Report sanitizer blacklist as a dependency in cc1
Nov 7 2019, 2:08 PM
jkorous closed D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.
Nov 7 2019, 2:08 PM · Restricted Project
jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

@pcc Could you please take a look?

Nov 7 2019, 10:47 AM · Restricted Project
jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

I am in no particular rush and happy to help you as much as I can but at some point not too far in the future I just want this to land and not get reverted.

Nov 7 2019, 10:38 AM · Restricted Project, Restricted Project

Nov 6 2019

jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

The test seems to be fine (fails on master, passes with the patch). I most probably just forgot to run it.

Nov 6 2019, 11:13 AM · Restricted Project, Restricted Project
jkorous updated the diff for D69648: Add VFS support for sanitizers' blacklist' 2.

Actually use the VFS that got passed.

Nov 6 2019, 11:13 AM · Restricted Project, Restricted Project
jkorous added inline comments to D69648: Add VFS support for sanitizers' blacklist' 2.
Nov 6 2019, 11:13 AM · Restricted Project, Restricted Project

Oct 31 2019

jkorous updated the diff for D69648: Add VFS support for sanitizers' blacklist' 2.
Oct 31 2019, 5:03 PM · Restricted Project, Restricted Project
jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

I see what you mean - I didn't realize I could use the real fs as the default arg.
I still feel that handling files is out of scope for SpecialCaseList but I don't think those couple lines are a big deal either way - updating the patch now.

Oct 31 2019, 4:08 PM · Restricted Project, Restricted Project
jkorous updated the diff for D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

Added a cc1 command line option -fsanitize-system-blacklist so driver can tell cc1 which blacklists are user-specified and which are system ones.

Oct 31 2019, 4:07 PM · Restricted Project
jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

@eugenis Does this make your workaround obsolete?

Oct 31 2019, 4:07 PM · Restricted Project
jkorous added inline comments to D69648: Add VFS support for sanitizers' blacklist' 2.
Oct 31 2019, 12:10 PM · Restricted Project, Restricted Project

Oct 30 2019

jkorous added inline comments to D69648: Add VFS support for sanitizers' blacklist' 2.
Oct 30 2019, 3:54 PM · Restricted Project, Restricted Project
jkorous created D69648: Add VFS support for sanitizers' blacklist' 2.
Oct 30 2019, 3:48 PM · Restricted Project, Restricted Project

Oct 29 2019

jkorous committed rG071567bc7e78: Merge branch 'conflict_resolution' into upstream-with-swift (authored by jkorous).
Merge branch 'conflict_resolution' into upstream-with-swift
Oct 29 2019, 4:00 PM
jkorous committed rG14152fd55ee4: Merge remote-tracking branch 'llvm.org/master' into 'upstream-with-swift' (authored by jkorous).
Merge remote-tracking branch 'llvm.org/master' into 'upstream-with-swift'
Oct 29 2019, 4:00 PM
jkorous committed rG241651beca5b: [clang-apply-replacements] Fix missing dependency - clangToolingRefactoring (authored by jkorous).
[clang-apply-replacements] Fix missing dependency - clangToolingRefactoring
Oct 29 2019, 12:19 PM
jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

Ping.

Oct 29 2019, 10:36 AM · Restricted Project

Oct 21 2019

jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

I am trying to solve two different things here.

Oct 21 2019, 6:20 PM · Restricted Project
jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

@pcc since you reviewed the above-mentioned patch - could you please take a look at this one too?

Oct 21 2019, 5:48 PM · Restricted Project
jkorous created D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.
Oct 21 2019, 5:39 PM · Restricted Project

Oct 17 2019

jkorous added inline comments to D69122: Add support to find out resource dir and add it as compilation args.
Oct 17 2019, 3:25 PM · Restricted Project
jkorous added a comment to D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output.

I think you could've just used CHECK-DAG to fix the tests. It *might* be a bit more robust. Although just reordering checks seems perfectly fine too.
https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-dag-directive

Oct 17 2019, 11:40 AM · Restricted Project

Oct 16 2019

jkorous accepted D69017: Include sanitize blacklist and other extra deps as part of scan-deps output.

Looks great! Thanks!

Oct 16 2019, 4:41 PM · Restricted Project

Oct 15 2019

jkorous committed rG9e49adc97574: Fix Driver/working-directory.c test (authored by jkorous).
Fix Driver/working-directory.c test
Oct 15 2019, 11:08 AM
jkorous committed rL374929: Fix Driver/working-directory.c test.
Fix Driver/working-directory.c test
Oct 15 2019, 11:08 AM
jkorous committed rGf8907fa6f4b7: Reland [Driver] Fix -working-directory issues (authored by jkorous).
Reland [Driver] Fix -working-directory issues
Oct 15 2019, 10:58 AM
jkorous added a reverting change for rG999f8a7416f8: Revert r361885 "[Driver] Fix -working-directory issues": rGf8907fa6f4b7: Reland [Driver] Fix -working-directory issues.
Oct 15 2019, 10:58 AM
jkorous committed rL374926: Reland [Driver] Fix -working-directory issues.
Reland [Driver] Fix -working-directory issues
Oct 15 2019, 10:58 AM

Oct 14 2019

jkorous committed rG9d0a84f5f3d3: [NFC] Fix ClangScanDeps/static-analyzer.c test on Windows (authored by jkorous).
[NFC] Fix ClangScanDeps/static-analyzer.c test on Windows
Oct 14 2019, 2:12 PM
jkorous committed rL374821: [NFC] Fix ClangScanDeps/static-analyzer.c test on Windows.
[NFC] Fix ClangScanDeps/static-analyzer.c test on Windows
Oct 14 2019, 2:04 PM
jkorous committed rGc5d14b5c6fa9: [clang-scan-deps] Support for clang --analyze in clang-scan-deps (authored by jkorous).
[clang-scan-deps] Support for clang --analyze in clang-scan-deps
Oct 14 2019, 1:16 PM
jkorous closed D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.
Oct 14 2019, 1:16 PM · Restricted Project, Restricted Project
jkorous committed rL374815: [clang-scan-deps] Support for clang --analyze in clang-scan-deps.
[clang-scan-deps] Support for clang --analyze in clang-scan-deps
Oct 14 2019, 1:16 PM

Oct 8 2019

jkorous added a comment to D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.

@NoQ , @hiraditya any suggestions for the option name and/or description?

Oct 8 2019, 3:28 PM · Restricted Project, Restricted Project
jkorous committed rG135f2f01a2d9: [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows (authored by jkorous).
[NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows
Oct 8 2019, 11:16 AM
jkorous committed rL374098: [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows.
[NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows
Oct 8 2019, 11:16 AM