Page MenuHomePhabricator

jkorous (Jan Korous)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2018, 2:22 AM (65 w, 5 d)

Recent Activity

Mon, Jul 15

jkorous added a comment to D63961: [clangd][xpc] pass the LSP value using data instead of string.

I'd add a test with non-empty non-LSP dictionary to specifically test that we're ignoring the content. I like const-correctness but that's up to you. Otherwise LGTM.

Mon, Jul 15, 4:31 PM · Restricted Project
jkorous committed rG60a0d49e77cf: [DirectoryWatcher][linux] Fix for older kernels (authored by jkorous).
[DirectoryWatcher][linux] Fix for older kernels
Mon, Jul 15, 4:15 PM
jkorous committed rL366152: [DirectoryWatcher][linux] Fix for older kernels.
[DirectoryWatcher][linux] Fix for older kernels
Mon, Jul 15, 4:13 PM
jkorous closed D64764: [DirectoryWatcher][linux] Fix build for older kernels.
Mon, Jul 15, 4:13 PM · Restricted Project
jkorous committed rGc5e7a3d71009: [DirectoryWatcher][test] Relax test assumptions (authored by jkorous).
[DirectoryWatcher][test] Relax test assumptions
Mon, Jul 15, 3:14 PM
jkorous committed rG5076038bb00d: [DirectoryWatcher][NFC][test] Add typedef for enum (authored by jkorous).
[DirectoryWatcher][NFC][test] Add typedef for enum
Mon, Jul 15, 3:13 PM
jkorous committed rL366138: [DirectoryWatcher][test] Relax test assumptions.
[DirectoryWatcher][test] Relax test assumptions
Mon, Jul 15, 3:13 PM
jkorous committed rL366137: [DirectoryWatcher][NFC][test] Add typedef for enum.
[DirectoryWatcher][NFC][test] Add typedef for enum
Mon, Jul 15, 3:13 PM
jkorous created D64764: [DirectoryWatcher][linux] Fix build for older kernels.
Mon, Jul 15, 11:25 AM · Restricted Project

Fri, Jul 12

jkorous committed rG4765aa14ff42: [DirectoryWatcher][test][NFC] Add information to test failure reports (authored by jkorous).
[DirectoryWatcher][test][NFC] Add information to test failure reports
Fri, Jul 12, 5:09 PM
jkorous committed rL365976: [DirectoryWatcher][test][NFC] Add information to test failure reports.
[DirectoryWatcher][test][NFC] Add information to test failure reports
Fri, Jul 12, 5:09 PM
jkorous committed rG000ba715ddbd: [DirectoryWatcher][NFC] Silence warnings in release build (authored by jkorous).
[DirectoryWatcher][NFC] Silence warnings in release build
Fri, Jul 12, 3:27 PM
jkorous committed rL365968: [DirectoryWatcher][NFC] Silence warnings in release build.
[DirectoryWatcher][NFC] Silence warnings in release build
Fri, Jul 12, 3:27 PM
jkorous committed rGec2abbafda62: [DirectoryWatcher][linux] Fix use of uninitialized value (authored by jkorous).
[DirectoryWatcher][linux] Fix use of uninitialized value
Fri, Jul 12, 3:13 PM
jkorous committed rL365966: [DirectoryWatcher][linux] Fix use of uninitialized value.
[DirectoryWatcher][linux] Fix use of uninitialized value
Fri, Jul 12, 3:13 PM
jkorous committed rG77dd8a79286d: Reland [clang] DirectoryWatcher (authored by jkorous).
Reland [clang] DirectoryWatcher
Fri, Jul 12, 1:36 PM
jkorous added a reverting change for rGf561227d1332: Revert "Reland [clang] DirectoryWatcher": rG77dd8a79286d: Reland [clang] DirectoryWatcher.
Fri, Jul 12, 1:36 PM
jkorous committed rL365954: Reland [clang] DirectoryWatcher.
Reland [clang] DirectoryWatcher
Fri, Jul 12, 1:35 PM
jkorous committed rGf561227d1332: Revert "Reland [clang] DirectoryWatcher" (authored by jkorous).
Revert "Reland [clang] DirectoryWatcher"
Fri, Jul 12, 12:55 PM
jkorous added a reverting change for rGfdcb7f47e783: Reland [clang] DirectoryWatcher: rGf561227d1332: Revert "Reland [clang] DirectoryWatcher".
Fri, Jul 12, 12:55 PM
jkorous committed rL365948: Revert "Reland [clang] DirectoryWatcher".
Revert "Reland [clang] DirectoryWatcher"
Fri, Jul 12, 12:55 PM
jkorous committed rGfdcb7f47e783: Reland [clang] DirectoryWatcher (authored by jkorous).
Reland [clang] DirectoryWatcher
Fri, Jul 12, 12:49 PM
jkorous added a reverting change for rGabce8c457dd3: Revert [clang] DirectoryWatcher: rGfdcb7f47e783: Reland [clang] DirectoryWatcher.
Fri, Jul 12, 12:49 PM
jkorous committed rL365947: Reland [clang] DirectoryWatcher.
Reland [clang] DirectoryWatcher
Fri, Jul 12, 12:48 PM

Thu, Jul 11

jkorous committed rGa286aae4d818: [clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test (authored by jkorous).
[clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test
Thu, Jul 11, 11:24 AM
jkorous committed rL365804: [clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test.
[clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test
Thu, Jul 11, 11:21 AM

Tue, Jul 9

jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Thanks for the revert.

Tue, Jul 9, 5:07 PM · Restricted Project, Restricted Project
jkorous committed rG31babea94a3e: [clang] DirectoryWatcher (authored by jkorous).
[clang] DirectoryWatcher
Tue, Jul 9, 3:46 PM
jkorous committed rL365574: [clang] DirectoryWatcher.
[clang] DirectoryWatcher
Tue, Jul 9, 3:44 PM
jkorous closed D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Tue, Jul 9, 3:44 PM · Restricted Project, Restricted Project

Mon, Jul 8

jkorous created D64384: [WIP] Index-while-building.
Mon, Jul 8, 8:22 PM · Restricted Project

Fri, Jun 28

jkorous committed rGcaf4cee6fe8e: [clang][test][NFC] Explicitly specify clang ABI in AST Dumper test (authored by jkorous).
[clang][test][NFC] Explicitly specify clang ABI in AST Dumper test
Fri, Jun 28, 3:40 PM
jkorous committed rL364690: [clang][test][NFC] Explicitly specify clang ABI in AST Dumper test.
[clang][test][NFC] Explicitly specify clang ABI in AST Dumper test
Fri, Jun 28, 3:39 PM

Jun 20 2019

jkorous accepted D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c.

LGTM

Jun 20 2019, 2:20 PM · Restricted Project, Restricted Project
jkorous added a comment to D63603: [ASTImporter] Propagate error from ImportDeclContext.

I don't have the insight to LGTM the whole change - just a nit about implementation detail.

Jun 20 2019, 2:04 PM · Restricted Project, Restricted Project
jkorous accepted D63597: [binutils] Add response file option to help and docs.

LGTM

Jun 20 2019, 1:26 PM · Restricted Project
jkorous accepted D63613: [clang-tidy] Fail gracefully upon empty database fields.

LGTM

Jun 20 2019, 12:43 PM · Restricted Project, Restricted Project

Jun 19 2019

jkorous accepted rGff384a2d1c07: [clang][test] Add missing LambdaTemplateParams test and migrate from getLocStart.

LGMT

Jun 19 2019, 11:06 AM

Jun 5 2019

jkorous committed rGa3701caad826: [clang-format][NFC] Fix BS_Allman style example in the header docs are… (authored by jkorous).
[clang-format][NFC] Fix BS_Allman style example in the header docs are…
Jun 5 2019, 2:01 PM
jkorous committed rL362646: [clang-format][NFC] Fix BS_Allman style example in the header docs are….
[clang-format][NFC] Fix BS_Allman style example in the header docs are…
Jun 5 2019, 2:01 PM
jkorous closed D61729: [docs] Fix example for Allman brace breaking style.
Jun 5 2019, 2:01 PM · Restricted Project, Restricted Project

Jun 3 2019

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

linux implementation

  • factory method for SemaphorePipe
  • *_CLOEXEC flags
Jun 3 2019, 6:01 PM · Restricted Project, Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

I fixed the rest.

Jun 3 2019, 5:56 PM · Restricted Project, Restricted Project
jkorous added a comment to D61729: [docs] Fix example for Allman brace breaking style.

Thanks, I didn't know it's generated.

Jun 3 2019, 5:05 PM · Restricted Project, Restricted Project
jkorous updated the diff for D61729: [docs] Fix example for Allman brace breaking style.

Fix in the header file from which the documentation is actually generated.

Jun 3 2019, 5:05 PM · Restricted Project, Restricted Project
jkorous commandeered D61729: [docs] Fix example for Allman brace breaking style.
Jun 3 2019, 5:05 PM · Restricted Project, Restricted Project

May 31 2019

jkorous edited reviewers for D61729: [docs] Fix example for Allman brace breaking style, added: owenpan; removed: llvm-commits.

You're right, thanks for letting me know.

May 31 2019, 5:43 PM · Restricted Project, Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Addressed comments.

May 31 2019, 12:23 PM · Restricted Project, Restricted Project
jkorous added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
May 31 2019, 12:20 PM · Restricted Project, Restricted Project

May 30 2019

jkorous committed rG2980f3c18f98: [NFC] Fix SmallVector::append comments (authored by jkorous).
[NFC] Fix SmallVector::append comments
May 30 2019, 11:14 AM
jkorous committed rL362120: [NFC] Fix SmallVector::append comments.
[NFC] Fix SmallVector::append comments
May 30 2019, 11:13 AM

May 29 2019

jkorous committed rG158875ce0c95: [BitstreamWriter][NFC] Remove obsolete comment. (authored by jkorous).
[BitstreamWriter][NFC] Remove obsolete comment.
May 29 2019, 6:10 PM
jkorous committed rL362046: [BitstreamWriter][NFC] Remove obsolete comment..
[BitstreamWriter][NFC] Remove obsolete comment.
May 29 2019, 6:09 PM

May 28 2019

jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

One more thing.

May 28 2019, 1:38 PM · Restricted Project, Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Remove DirectoryWatcher::Event::EventKind::Added

May 28 2019, 12:44 PM · Restricted Project, Restricted Project

May 24 2019

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
  • simplify link libraries in cmake
  • fix Release build (messed-up asserts)
May 24 2019, 2:40 PM · Restricted Project, Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Specify what "file modified" means and add a test for metadata change

May 24 2019, 1:25 PM · Restricted Project, Restricted Project

May 23 2019

jkorous added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
May 23 2019, 6:49 PM · Restricted Project, Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Reimplemented tests with std::futures which allowed to use more generous timeout while not slowing down the happy paths.

May 23 2019, 6:45 PM · Restricted Project, Restricted Project

May 22 2019

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
May 22 2019, 12:52 PM · Restricted Project, Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Thanks for taking a look Kadir!
After yesterday's discussion with Dmitri I removed all those busy waits. Seems like the code is not much more complex now. I am going to update the diff and off to fixing the tests.

May 22 2019, 12:51 PM · Restricted Project, Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Remove busy waits.

May 22 2019, 12:51 PM · Restricted Project, Restricted Project

May 20 2019

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Addressed comments.
Changed semantics of one of std::atomic<bool> in linux implementation.

May 20 2019, 7:52 PM · Restricted Project, Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

I addressed most of the comments.

May 20 2019, 7:51 PM · Restricted Project, Restricted Project
jkorous added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Thanks for taking a look @gribozavr!

May 20 2019, 1:00 PM · Restricted Project, Restricted Project

May 17 2019

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

fix link libraries in cmake

May 17 2019, 5:54 PM · Restricted Project, Restricted Project

May 15 2019

jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

A major clean-up.

May 15 2019, 7:02 PM · Restricted Project, Restricted Project

May 13 2019

jkorous committed rG1652d8140191: [clang][ASTContext] Call setAttached for comments attached to a declaration (authored by jkorous).
[clang][ASTContext] Call setAttached for comments attached to a declaration
May 13 2019, 10:53 AM
jkorous committed rC360607: [clang][ASTContext] Call setAttached for comments attached to a declaration.
[clang][ASTContext] Call setAttached for comments attached to a declaration
May 13 2019, 10:52 AM
jkorous committed rL360607: [clang][ASTContext] Call setAttached for comments attached to a declaration.
[clang][ASTContext] Call setAttached for comments attached to a declaration
May 13 2019, 10:52 AM
jkorous closed D61538: [clang][ASTContext] Call setAttached for comments attached to a declaration.
May 13 2019, 10:52 AM · Restricted Project

May 6 2019

jkorous added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Hi @VelocityRa, just FYI - it's considered fine to ping your reviewers once per week here if you've addressed their comments and there's no activity in the review. Sometimes people just get distracted by other things.

May 6 2019, 3:48 PM · Restricted Project, Restricted Project

May 3 2019

jkorous created D61538: [clang][ASTContext] Call setAttached for comments attached to a declaration.
May 3 2019, 2:25 PM · Restricted Project

May 2 2019

jkorous committed rGf90458b3895c: [clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching (authored by jkorous).
[clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching
May 2 2019, 1:31 PM
jkorous committed rCTE359824: [clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching.
[clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching
May 2 2019, 1:30 PM
jkorous committed rL359824: [clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching.
[clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching
May 2 2019, 1:30 PM

May 1 2019

jkorous planned changes to D61104: [clang][ASTContext] Try to avoid sorting comments for code completion.

@gribozavr thanks for the feedback. I'm rewriting the patch now as I figured out my detection of comments preceding declarations is unsound.

May 1 2019, 2:53 PM · Restricted Project

Apr 29 2019

jkorous committed rGfd76383d761c: [clangd][xpc] Fix XPC unittests (authored by jkorous).
[clangd][xpc] Fix XPC unittests
Apr 29 2019, 12:40 PM
jkorous committed rL359489: [clangd][xpc] Fix XPC unittests.
[clangd][xpc] Fix XPC unittests
Apr 29 2019, 12:39 PM
jkorous committed rCTE359489: [clangd][xpc] Fix XPC unittests.
[clangd][xpc] Fix XPC unittests
Apr 29 2019, 12:39 PM
jkorous closed D61271: [clangd][xpc] Fix XPC unittests.
Apr 29 2019, 12:39 PM · Restricted Project
jkorous added a comment to D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools..

Patch with fix for XPC tests https://reviews.llvm.org/D61271

Apr 29 2019, 11:19 AM · Restricted Project, Restricted Project
jkorous created D61271: [clangd][xpc] Fix XPC unittests.
Apr 29 2019, 11:19 AM · Restricted Project
jkorous added a comment to D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools..

@MaskRay @juliehockett I'll take a look.

Apr 29 2019, 10:23 AM · Restricted Project, Restricted Project

Apr 26 2019

jkorous updated the diff for D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
  • moved assert
Apr 26 2019, 10:29 AM · Restricted Project

Apr 25 2019

jkorous added inline comments to D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
Apr 25 2019, 5:30 PM · Restricted Project
jkorous updated the diff for D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
  • renames
  • if => assert
Apr 25 2019, 5:09 PM · Restricted Project
jkorous abandoned D60432: [clang][ASTContext] Simplify caching for declaration-related comments.
Apr 25 2019, 4:05 PM · Restricted Project
jkorous added a comment to D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.

Also, IIUC the test case that I deleted wasn't actually supposed to produce any diagnostics and the fact that it did was a bug. We could keep it as a regression test but I think it has a rather low value. WDYT?

Apr 25 2019, 3:52 PM · Restricted Project
jkorous updated the diff for D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.
  • clang-format
  • comments
Apr 25 2019, 3:50 PM · Restricted Project
jkorous added inline comments to D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.
Apr 25 2019, 3:46 PM · Restricted Project
jkorous abandoned D60494: [clang][ASTContext] Don't load external comments from Sema::ActOnDocumentableDecls.

Abandonned in favor of https://reviews.llvm.org/D61103

Apr 25 2019, 1:24 PM

Apr 24 2019

jkorous added a parent revision for D61104: [clang][ASTContext] Try to avoid sorting comments for code completion: D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
Apr 24 2019, 4:43 PM · Restricted Project
jkorous added a child revision for D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache: D61104: [clang][ASTContext] Try to avoid sorting comments for code completion.
Apr 24 2019, 4:43 PM · Restricted Project
jkorous added a child revision for D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache: D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.
Apr 24 2019, 4:42 PM · Restricted Project
jkorous added a parent revision for D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext: D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
Apr 24 2019, 4:42 PM · Restricted Project
jkorous updated the summary of D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
Apr 24 2019, 4:42 PM · Restricted Project
jkorous created D61104: [clang][ASTContext] Try to avoid sorting comments for code completion.
Apr 24 2019, 4:42 PM · Restricted Project
jkorous created D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext.
Apr 24 2019, 4:33 PM · Restricted Project
jkorous created D61102: [clang][ASTContext][NFCi] Refactor ASTContext::getRawCommentForDeclNoCache.
Apr 24 2019, 4:32 PM · Restricted Project