Page MenuHomePhabricator

jkorous (Jan Korous)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2018, 2:22 AM (74 w, 1 d)

Recent Activity

Wed, Sep 18

jkorous added a reviewer for D67742: [WIP] Add VFS support for sanitizers' blacklist: JDevlieghere.
Wed, Sep 18, 5:34 PM
jkorous created D67742: [WIP] Add VFS support for sanitizers' blacklist.
Wed, Sep 18, 5:31 PM

Tue, Sep 17

jkorous created D67682: [WIP] Add support for preprocessing sources for analyzer.
Tue, Sep 17, 3:34 PM
jkorous committed rG1b87364f511a: [clang-scan-deps] Add verbose mode (authored by jkorous).
[clang-scan-deps] Add verbose mode
Tue, Sep 17, 12:45 PM
jkorous committed rL372174: [clang-scan-deps] Add verbose mode.
[clang-scan-deps] Add verbose mode
Tue, Sep 17, 12:45 PM
jkorous closed D67522: [clang-scan-deps] Verbose mode.
Tue, Sep 17, 12:45 PM · Restricted Project
jkorous added inline comments to D67668: [ADT] Add StringMap::insert_or_assign.
Tue, Sep 17, 10:45 AM · Restricted Project
jkorous accepted D67584: [Support] Replace function with function_ref in writeFileAtomically. NFC.

Good point! Thanks.

Tue, Sep 17, 10:43 AM · Restricted Project

Fri, Sep 13

jkorous committed rGf69c91780fbb: [Support] Add overload writeFileAtomically(std::function Writer) (authored by jkorous).
[Support] Add overload writeFileAtomically(std::function Writer)
Fri, Sep 13, 1:10 PM
jkorous committed rL371890: [Support] Add overload writeFileAtomically(std::function Writer).
[Support] Add overload writeFileAtomically(std::function Writer)
Fri, Sep 13, 1:07 PM
jkorous closed D67424: [Support] Add overload writeFileAtomically(std::function Writer).
Fri, Sep 13, 1:07 PM · Restricted Project

Thu, Sep 12

jkorous committed rG5e4a03f03775: [libclang] Fix UninstallAbortingLLVMFatalErrorHandler test (authored by jkorous).
[libclang] Fix UninstallAbortingLLVMFatalErrorHandler test
Thu, Sep 12, 4:51 PM
jkorous committed rL371794: [libclang] Fix UninstallAbortingLLVMFatalErrorHandler test.
[libclang] Fix UninstallAbortingLLVMFatalErrorHandler test
Thu, Sep 12, 4:51 PM
jkorous committed rGf7d2376b9872: [libclang] Expose abort()-ing LLVM fatal error handler (authored by jkorous).
[libclang] Expose abort()-ing LLVM fatal error handler
Thu, Sep 12, 3:56 PM
jkorous committed rL371787: [libclang] Expose abort()-ing LLVM fatal error handler.
[libclang] Expose abort()-ing LLVM fatal error handler
Thu, Sep 12, 3:56 PM
jkorous closed D66775: [libclang] Expose abort()-ing fatal error handler.
Thu, Sep 12, 3:56 PM · Restricted Project
jkorous added inline comments to D67424: [Support] Add overload writeFileAtomically(std::function Writer).
Thu, Sep 12, 2:12 PM · Restricted Project
jkorous created D67522: [clang-scan-deps] Verbose mode.
Thu, Sep 12, 2:07 PM · Restricted Project

Wed, Sep 11

jkorous committed rGb51a285c4c89: [clang-scan-deps] Add dependency targets (authored by jkorous).
[clang-scan-deps] Add dependency targets
Wed, Sep 11, 5:48 PM
jkorous committed rL371697: [clang-scan-deps] Add dependency targets.
[clang-scan-deps] Add dependency targets
Wed, Sep 11, 5:48 PM
jkorous closed D67475: [clang-scan-deps] Add even proper-er dependency targets.
Wed, Sep 11, 5:48 PM · Restricted Project
jkorous added inline comments to D67475: [clang-scan-deps] Add even proper-er dependency targets.
Wed, Sep 11, 5:39 PM · Restricted Project
jkorous abandoned D67197: [clang-scan-deps] Add proper dependency targets.

Abandoned in favor of: https://reviews.llvm.org/D67475

Wed, Sep 11, 5:33 PM
jkorous added a comment to D67197: [clang-scan-deps] Add proper dependency targets.

I realized there was an issue with adding the -o /dev/null to arguemnts in case when there was a -MD flag as Driver later adds -MT with the last -o value in case there's no -MT or -MQ. That means that for headers the target would always be /dev/null.
@dexonsmith pointed out that we could just conditionally add -MT in the adjustment. Also, we can use build directory instead of CDB index.

Wed, Sep 11, 5:31 PM
jkorous created D67475: [clang-scan-deps] Add even proper-er dependency targets.
Wed, Sep 11, 5:26 PM · Restricted Project

Tue, Sep 10

jkorous added a comment to D67197: [clang-scan-deps] Add proper dependency targets.

Thanks for doing that! But it looks odd to attach the dependencies to the output file.

clang -MD -c foo.c -o foo.o

will attach the headers/dependencies to foo.c. foo.c includes the headers. It does not attach the headers to foo.o
It will work for make-like build systems, but it looks odd.

Tue, Sep 10, 6:29 PM
jkorous committed rG9607f5d80202: [clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir path (authored by jkorous).
[clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir path
Tue, Sep 10, 5:30 PM
jkorous committed rL371578: [clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir path.
[clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir path
Tue, Sep 10, 5:29 PM
jkorous closed D67379: [clang-scan-deps] Fix tests - prevent FileCheck matching temp dir path.
Tue, Sep 10, 5:29 PM · Restricted Project
jkorous created D67424: [Support] Add overload writeFileAtomically(std::function Writer).
Tue, Sep 10, 5:23 PM · Restricted Project

Mon, Sep 9

jkorous committed rG79707ecd7d91: [llvm][ADT][NFC] Add test for makeArrayRef(std::array) (authored by jkorous).
[llvm][ADT][NFC] Add test for makeArrayRef(std::array)
Mon, Sep 9, 5:30 PM
jkorous committed rL371475: [llvm][ADT][NFC] Add test for makeArrayRef(std::array).
[llvm][ADT][NFC] Add test for makeArrayRef(std::array)
Mon, Sep 9, 5:28 PM
jkorous updated the diff for D67197: [clang-scan-deps] Add proper dependency targets.
  • prefix dependency targets with CDB index
Mon, Sep 9, 5:13 PM
jkorous updated the diff for D67197: [clang-scan-deps] Add proper dependency targets.
  • rebased
  • updated tests
Mon, Sep 9, 4:34 PM
jkorous retitled D67197: [clang-scan-deps] Add proper dependency targets from [RFC][clang-scan-deps] Fix dependency targets to [clang-scan-deps] Add proper dependency targets.
Mon, Sep 9, 4:30 PM
jkorous added a parent revision for D67197: [clang-scan-deps] Add proper dependency targets: D67379: [clang-scan-deps] Fix tests - prevent FileCheck matching temp dir path.
Mon, Sep 9, 4:29 PM
jkorous added a child revision for D67379: [clang-scan-deps] Fix tests - prevent FileCheck matching temp dir path: D67197: [clang-scan-deps] Add proper dependency targets.
Mon, Sep 9, 4:29 PM · Restricted Project
jkorous created D67379: [clang-scan-deps] Fix tests - prevent FileCheck matching temp dir path.
Mon, Sep 9, 4:20 PM · Restricted Project

Fri, Sep 6

jkorous added inline comments to D67197: [clang-scan-deps] Add proper dependency targets.
Fri, Sep 6, 6:01 PM
jkorous committed rG0aee38732146: [clang][DependencyFileGenerator] Fix missing -MT option handling (authored by jkorous).
[clang][DependencyFileGenerator] Fix missing -MT option handling
Fri, Sep 6, 6:00 PM
jkorous committed rL371279: [clang][DependencyFileGenerator] Fix missing -MT option handling.
[clang][DependencyFileGenerator] Fix missing -MT option handling
Fri, Sep 6, 5:59 PM
jkorous closed D67308: [clang][DependencyFileGenerator] Fix missing -MT option handling.
Fri, Sep 6, 5:59 PM · Restricted Project
jkorous added a comment to D67197: [clang-scan-deps] Add proper dependency targets.

Instead of basing the new -MT name off the output, can you base it on the name of the input filename instead to simplify this logic?

Fri, Sep 6, 5:59 PM
jkorous updated the diff for D66775: [libclang] Expose abort()-ing fatal error handler.
  • renamed functions to suggest their limitations
  • added one more test
Fri, Sep 6, 5:51 PM · Restricted Project
jkorous added inline comments to D66775: [libclang] Expose abort()-ing fatal error handler.
Fri, Sep 6, 5:40 PM · Restricted Project
jkorous updated the summary of D67308: [clang][DependencyFileGenerator] Fix missing -MT option handling.
Fri, Sep 6, 4:45 PM · Restricted Project
jkorous updated the summary of D67308: [clang][DependencyFileGenerator] Fix missing -MT option handling.
Fri, Sep 6, 4:45 PM · Restricted Project
jkorous updated the summary of D67308: [clang][DependencyFileGenerator] Fix missing -MT option handling.
Fri, Sep 6, 4:45 PM · Restricted Project
jkorous created D67308: [clang][DependencyFileGenerator] Fix missing -MT option handling.
Fri, Sep 6, 4:45 PM · Restricted Project
jkorous updated the diff for D64384: [WIP] Index-while-building.

Rebased on TOT and removed noise from the patch as I've already landed couple refactoring patches.

Fri, Sep 6, 1:18 PM · Restricted Project
jkorous committed rG4b5542f29d79: [clang][Index][NFC] Put IndexingOptions to a separate header (authored by jkorous).
[clang][Index][NFC] Put IndexingOptions to a separate header
Fri, Sep 6, 1:09 PM
jkorous committed rL371250: [clang][Index][NFC] Put IndexingOptions to a separate header.
[clang][Index][NFC] Put IndexingOptions to a separate header
Fri, Sep 6, 1:07 PM

Thu, Sep 5

jkorous committed rG995ff8a77e41: [ADT] Add makeArrayRef(std::array<>) template specialization (authored by jkorous).
[ADT] Add makeArrayRef(std::array<>) template specialization
Thu, Sep 5, 2:29 PM
jkorous committed rGe9a78e992ba5: [Bitstream] Add BitCodeAbbrev(std::initializer_list) constructor (authored by jkorous).
[Bitstream] Add BitCodeAbbrev(std::initializer_list) constructor
Thu, Sep 5, 2:26 PM
jkorous committed rL371129: [ADT] Add makeArrayRef(std::array<>) template specialization.
[ADT] Add makeArrayRef(std::array<>) template specialization
Thu, Sep 5, 2:26 PM
jkorous committed rL371128: [Bitstream] Add BitCodeAbbrev(std::initializer_list) constructor.
[Bitstream] Add BitCodeAbbrev(std::initializer_list) constructor
Thu, Sep 5, 2:26 PM
jkorous committed rG7e36ecd66dbe: [clang][Index] Replace CodegenNameGenerator with ASTNameGenerator (authored by jkorous).
[clang][Index] Replace CodegenNameGenerator with ASTNameGenerator
Thu, Sep 5, 1:35 PM
jkorous committed rL371117: [clang][Index] Replace CodegenNameGenerator with ASTNameGenerator.
[clang][Index] Replace CodegenNameGenerator with ASTNameGenerator
Thu, Sep 5, 1:32 PM
jkorous committed rGafd82492782f: [AST][NFC] Doc comments for ASTNameGenerator (authored by jkorous).
[AST][NFC] Doc comments for ASTNameGenerator
Thu, Sep 5, 1:04 PM
jkorous committed rL371112: [AST][NFC] Doc comments for ASTNameGenerator.
[AST][NFC] Doc comments for ASTNameGenerator
Thu, Sep 5, 1:03 PM
jkorous committed rG00e04b0a6d51: [Support] Add writeFileAtomically() to FileUtilities (authored by jkorous).
[Support] Add writeFileAtomically() to FileUtilities
Thu, Sep 5, 11:10 AM
jkorous committed rL371103: [Support] Add writeFileAtomically() to FileUtilities.
[Support] Add writeFileAtomically() to FileUtilities
Thu, Sep 5, 11:09 AM
jkorous closed D66859: [index-while-buildling] FSUtil.
Thu, Sep 5, 11:09 AM · Restricted Project

Wed, Sep 4

jkorous accepted D67077: [libclang] Refactored SharedParsedRegionsStorage.

Thanks for polishing this!

Wed, Sep 4, 5:03 PM · Restricted Project, Restricted Project
jkorous updated the diff for D66859: [index-while-buildling] FSUtil.

Add test.

Wed, Sep 4, 4:48 PM · Restricted Project
jkorous added a comment to D66859: [index-while-buildling] FSUtil.

Hmm, actually if we replace Buffer in the interface with a llvm::function_ref<void(llvm::raw_ostream &)> callback it would cover couple other existing uses of createUniqueFile.

That would make a lot of sense if you're going to do the cleanup and refactor those callers to use new API. Good idea!

However, I think just from the API simplicity perspective, it would make sense to have two overloaded APIs if calling this function with a precomputed buffer is common.

Wed, Sep 4, 4:48 PM · Restricted Project
jkorous added inline comments to D66775: [libclang] Expose abort()-ing fatal error handler.
Wed, Sep 4, 3:56 PM · Restricted Project
jkorous committed rL370995: Request commit access for jkorous.
Request commit access for jkorous
Wed, Sep 4, 3:48 PM
jkorous created D67197: [clang-scan-deps] Add proper dependency targets.
Wed, Sep 4, 3:32 PM

Tue, Sep 3

jkorous requested review of D66775: [libclang] Expose abort()-ing fatal error handler.
Tue, Sep 3, 4:18 PM · Restricted Project
jkorous planned changes to D66775: [libclang] Expose abort()-ing fatal error handler.
Tue, Sep 3, 3:48 PM · Restricted Project
jkorous updated the diff for D66775: [libclang] Expose abort()-ing fatal error handler.

There are actually couple other fatal-error-handling strategies. But all the other I've seen raise a signal (mostly SIGABRT; SIGILL in case of LLVM_BUILTIN_TRAP). For the purpose of having a way how to ask libclang to crash in a way that might lead to core dump this seems fine. Uninstalling the handler doesn't lead to libclang just calling exit in case of any crash though. Maybe I should rename the functions? Open to suggestions...

Tue, Sep 3, 3:20 PM · Restricted Project
jkorous added a comment to D66775: [libclang] Expose abort()-ing fatal error handler.

It turned out that recovery context matters as it messes with signals.

Tue, Sep 3, 3:05 PM · Restricted Project
jkorous updated the diff for D66775: [libclang] Expose abort()-ing fatal error handler.

Added a proper test.

Tue, Sep 3, 3:02 PM · Restricted Project
jkorous committed rGa6fcadd0f037: [libclang][test][NFC] Split off fixture from tests. (authored by jkorous).
[libclang][test][NFC] Split off fixture from tests.
Tue, Sep 3, 3:01 PM
jkorous committed rL370825: [libclang][test][NFC] Split off fixture from tests..
[libclang][test][NFC] Split off fixture from tests.
Tue, Sep 3, 3:00 PM
jkorous reclaimed D66775: [libclang] Expose abort()-ing fatal error handler.
Tue, Sep 3, 2:02 PM · Restricted Project

Wed, Aug 28

jkorous abandoned D66775: [libclang] Expose abort()-ing fatal error handler.

How to minimize a patch to nothing:

Wed, Aug 28, 4:01 PM · Restricted Project
jkorous added a comment to D66859: [index-while-buildling] FSUtil.

Hmm, actually if we replace Buffer in the interface with a llvm::function_ref<void(llvm::raw_ostream &)> callback it would cover couple other existing uses of createUniqueFile.

Wed, Aug 28, 2:01 PM · Restricted Project
jkorous updated the diff for D66859: [index-while-buildling] FSUtil.

Addressed comments.

Wed, Aug 28, 1:46 PM · Restricted Project
jkorous added a comment to D66859: [index-while-buildling] FSUtil.

Good points as always. Thanks!

Wed, Aug 28, 1:46 PM · Restricted Project
jkorous added inline comments to D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution.
Wed, Aug 28, 12:25 PM · Restricted Project, Restricted Project
jkorous accepted D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution.
Wed, Aug 28, 10:46 AM · Restricted Project, Restricted Project
jkorous added a comment to D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution.

Otherwise LGTM. Thanks for refactoring this!

Wed, Aug 28, 10:46 AM · Restricted Project, Restricted Project
jkorous added inline comments to D66877: Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction.
Wed, Aug 28, 10:37 AM · Restricted Project
jkorous added inline comments to D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution.
Wed, Aug 28, 10:37 AM · Restricted Project, Restricted Project

Tue, Aug 27

jkorous added a parent revision for D64384: [WIP] Index-while-building: D66859: [index-while-buildling] FSUtil.
Tue, Aug 27, 6:44 PM · Restricted Project
jkorous created D66859: [index-while-buildling] FSUtil.
Tue, Aug 27, 6:44 PM · Restricted Project
jkorous added a child revision for D66859: [index-while-buildling] FSUtil: D64384: [WIP] Index-while-building.
Tue, Aug 27, 6:44 PM · Restricted Project
jkorous added a child revision for D66854: [index-while-building] PathIndexer: D64384: [WIP] Index-while-building.
Tue, Aug 27, 6:14 PM
jkorous added a parent revision for D64384: [WIP] Index-while-building: D66854: [index-while-building] PathIndexer.
Tue, Aug 27, 6:14 PM · Restricted Project
jkorous removed a parent revision for D66854: [index-while-building] PathIndexer: D64384: [WIP] Index-while-building.
Tue, Aug 27, 6:14 PM
jkorous removed a child revision for D64384: [WIP] Index-while-building: D66854: [index-while-building] PathIndexer.
Tue, Aug 27, 6:14 PM · Restricted Project
jkorous added a child revision for D64384: [WIP] Index-while-building: D66854: [index-while-building] PathIndexer.
Tue, Aug 27, 6:10 PM · Restricted Project
jkorous added a parent revision for D66854: [index-while-building] PathIndexer: D64384: [WIP] Index-while-building.
Tue, Aug 27, 6:10 PM
jkorous created D66854: [index-while-building] PathIndexer.
Tue, Aug 27, 6:10 PM
jkorous updated the diff for D64384: [WIP] Index-while-building.
  • Split off change to IndexDataConsumer.
  • Rebase.
Tue, Aug 27, 3:07 PM · Restricted Project
jkorous added a comment to D64384: [WIP] Index-while-building.

I'll start splitting off some self-standing parts that won't be affected by hypothetical changes at the FrontendAction/ASTConsumer level.

Tue, Aug 27, 3:04 PM · Restricted Project
jkorous committed rGcfd641d84a5e: [clang][Index][NFC] Move IndexDataConsumer default implementation (authored by jkorous).
[clang][Index][NFC] Move IndexDataConsumer default implementation
Tue, Aug 27, 2:54 PM
jkorous committed rL370116: [clang][Index][NFC] Move IndexDataConsumer default implementation.
[clang][Index][NFC] Move IndexDataConsumer default implementation
Tue, Aug 27, 2:48 PM