Ahh, right. I originally wanted to support -ivfsoverlay in Driver as it seemed reasonable to check the existence of blacklist in Driver and open it in cc1 using the same fs. I got talked out of it and I didn't touch the Driver but seems like I should've replaced the calls to native fs with VFS to keep things consistent. Thanks for picking this up!

Nov 19 2019, 11:11 AM · Restricted Project, Restricted Project

Nov 8 2019

jkorous committed rG99e2cba219ae: Reland "[compiler-rt] Fix tests after 03b84e4f6d0" (authored by jkorous).

Reland "[compiler-rt] Fix tests after 03b84e4f6d0"

Nov 8 2019, 2:34 PM

jkorous added a reverting change for rGd6be9273c603: Revert "[compiler-rt] Fix tests after 03b84e4f6d0": rG99e2cba219ae: Reland "[compiler-rt] Fix tests after 03b84e4f6d0".

Nov 8 2019, 2:34 PM

jkorous added a reverting change for rGcae4a28864f4: Reland "[clang] Report sanitizer blacklist as a dependency in cc1": rGd52cff88367d: Revert "Reland "[clang] Report sanitizer blacklist as a dependency in cc1"".

Nov 8 2019, 2:34 PM

jkorous committed rGd52cff88367d: Revert "Reland "[clang] Report sanitizer blacklist as a dependency in cc1"" (authored by jkorous).

Revert "Reland "[clang] Report sanitizer blacklist as a dependency in cc1""

Nov 8 2019, 2:34 PM

jkorous committed rG555c6be041d4: [clang] Fix -fsanitize-system-blacklist processing in cc1 (authored by jkorous).

[clang] Fix -fsanitize-system-blacklist processing in cc1

Nov 8 2019, 2:06 PM

jkorous committed rGcae4a28864f4: Reland "[clang] Report sanitizer blacklist as a dependency in cc1" (authored by jkorous).

Reland "[clang] Report sanitizer blacklist as a dependency in cc1"

Nov 8 2019, 2:06 PM

jkorous committed rG6d28588cc0f2: Reland "[clang] Report sanitizer blacklist as a dependency in cc1" (authored by jkorous).

Reland "[clang] Report sanitizer blacklist as a dependency in cc1"

Nov 8 2019, 2:06 PM

jkorous added a reverting change for rG3182027282c5: Revert "Revert "[clang] Report sanitizer blacklist as a dependency in cc1"": rGcae4a28864f4: Reland "[clang] Report sanitizer blacklist as a dependency in cc1".

Nov 8 2019, 2:06 PM

jkorous added a reverting change for rG9b8413ac6e56: Revert "Revert "Revert "[clang] Report sanitizer blacklist as a dependency in…: rG6d28588cc0f2: Reland "[clang] Report sanitizer blacklist as a dependency in cc1".

Nov 8 2019, 2:06 PM

jkorous committed rG590f279c456b: [clang] Add VFS support for sanitizers' blacklists (authored by jkorous).

[clang] Add VFS support for sanitizers' blacklists

Nov 8 2019, 11:03 AM

jkorous closed D69648: Add VFS support for sanitizers' blacklist' 2.

Nov 8 2019, 11:03 AM · Restricted Project, Restricted Project

Nov 7 2019

jkorous committed rGbdeb2724f0aa: [compiler-rt] Fix tests after 03b84e4f6d0 (authored by jkorous).

[compiler-rt] Fix tests after 03b84e4f6d0

Nov 7 2019, 2:45 PM

jkorous committed rG03b84e4f6d0e: [clang] Report sanitizer blacklist as a dependency in cc1 (authored by jkorous).

[clang] Report sanitizer blacklist as a dependency in cc1

Nov 7 2019, 2:08 PM

jkorous closed D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

Nov 7 2019, 2:08 PM · Restricted Project

jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

@pcc Could you please take a look?

Nov 7 2019, 10:47 AM · Restricted Project

jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

I am in no particular rush and happy to help you as much as I can but at some point not too far in the future I just want this to land and not get reverted.

Nov 7 2019, 10:38 AM · Restricted Project, Restricted Project

Nov 6 2019

jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

The test seems to be fine (fails on master, passes with the patch). I most probably just forgot to run it.

Nov 6 2019, 11:13 AM · Restricted Project, Restricted Project

jkorous updated the diff for D69648: Add VFS support for sanitizers' blacklist' 2.

Actually use the VFS that got passed.

Nov 6 2019, 11:13 AM · Restricted Project, Restricted Project

jkorous added inline comments to D69648: Add VFS support for sanitizers' blacklist' 2.

Nov 6 2019, 11:13 AM · Restricted Project, Restricted Project

Oct 31 2019

jkorous updated the diff for D69648: Add VFS support for sanitizers' blacklist' 2.

Oct 31 2019, 5:03 PM · Restricted Project, Restricted Project

jkorous added a comment to D69648: Add VFS support for sanitizers' blacklist' 2.

I see what you mean - I didn't realize I could use the real fs as the default arg.
I still feel that handling files is out of scope for SpecialCaseList but I don't think those couple lines are a big deal either way - updating the patch now.

Oct 31 2019, 4:08 PM · Restricted Project, Restricted Project

jkorous updated the diff for D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

Added a cc1 command line option -fsanitize-system-blacklist so driver can tell cc1 which blacklists are user-specified and which are system ones.

Oct 31 2019, 4:07 PM · Restricted Project

jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

@eugenis Does this make your workaround obsolete?

Oct 31 2019, 4:07 PM · Restricted Project

jkorous added inline comments to D69648: Add VFS support for sanitizers' blacklist' 2.

Oct 31 2019, 12:10 PM · Restricted Project, Restricted Project

Oct 30 2019

jkorous added inline comments to D69648: Add VFS support for sanitizers' blacklist' 2.

Oct 30 2019, 3:54 PM · Restricted Project, Restricted Project

jkorous created D69648: Add VFS support for sanitizers' blacklist' 2.

Oct 30 2019, 3:48 PM · Restricted Project, Restricted Project

Oct 29 2019

jkorous committed rG071567bc7e78: Merge branch 'conflict_resolution' into upstream-with-swift (authored by jkorous).

Merge branch 'conflict_resolution' into upstream-with-swift

Oct 29 2019, 4:00 PM

jkorous committed rG14152fd55ee4: Merge remote-tracking branch 'llvm.org/master' into 'upstream-with-swift' (authored by jkorous).

Merge remote-tracking branch 'llvm.org/master' into 'upstream-with-swift'

Oct 29 2019, 4:00 PM

jkorous committed rG241651beca5b: [clang-apply-replacements] Fix missing dependency - clangToolingRefactoring (authored by jkorous).

[clang-apply-replacements] Fix missing dependency - clangToolingRefactoring

Oct 29 2019, 12:19 PM

jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

Ping.

Oct 29 2019, 10:36 AM · Restricted Project

Oct 21 2019

jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

I am trying to solve two different things here.

Oct 21 2019, 6:20 PM · Restricted Project

jkorous added a comment to D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

@pcc since you reviewed the above-mentioned patch - could you please take a look at this one too?

Oct 21 2019, 5:48 PM · Restricted Project

jkorous created D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver.

Oct 21 2019, 5:39 PM · Restricted Project

Oct 17 2019

jkorous added inline comments to D69122: Add support to find out resource dir and add it as compilation args.

Oct 17 2019, 3:25 PM · Restricted Project

jkorous added a comment to D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output.

I think you could've just used CHECK-DAG to fix the tests. It *might* be a bit more robust. Although just reordering checks seems perfectly fine too.
https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-dag-directive

Oct 17 2019, 11:40 AM · Restricted Project