Page MenuHomePhabricator

jkorous (Jan Korous)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2018, 2:22 AM (214 w, 3 d)

Recent Activity

Wed, May 18

jkorous added a comment to D125349: [Sema] Fix crash for C11 atomic in gnu++ mode.

It's interesting to note that an_atomic_uint = an_atomic_uint + an_enum_value works correctly: https://godbolt.org/z/cvP9e6nh7. I was trying to figure out whether the atomic qualifier is properly stripped for the compound operator. When I run under a debugger and dump the AST for Args[0], I get: DeclRefExpr 0x26efcf87f88 '_Atomic(unsigned int)' lvalue Var 0x26efcf44cb8 'an_atomic_uint' '_Atomic(unsigned int)' which seems like it may be the root cause of the problem here (tough to say given that this is a C extension in C++ though). The lvalue conversion that takes place for an_atomic_uint should drop the atomic qualifier per C2x 6.3.2.1p2.

Wed, May 18, 3:30 PM · Restricted Project
jkorous added a comment to D125349: [Sema] Fix crash for C11 atomic in gnu++ mode.

Is it not possible to handle this similarly to volatile unsigned? If I replace _Atomic unsigned with volatile unsigned, I see LookupOverloadedBinOp succeed without having to strip volatile because addAssignmentArithmeticOverloads adds candidates with volatile types.

Wed, May 18, 3:29 PM · Restricted Project

Tue, May 10

jkorous updated the summary of D125349: [Sema] Fix crash for C11 atomic in gnu++ mode.
Tue, May 10, 5:47 PM · Restricted Project
jkorous added a reviewer for D125349: [Sema] Fix crash for C11 atomic in gnu++ mode: aaron.ballman.
Tue, May 10, 5:40 PM · Restricted Project
jkorous added reviewers for D125349: [Sema] Fix crash for C11 atomic in gnu++ mode: rsmith, ahatanak, rjmccall.
Tue, May 10, 5:34 PM · Restricted Project
jkorous requested review of D125349: [Sema] Fix crash for C11 atomic in gnu++ mode.
Tue, May 10, 5:32 PM · Restricted Project
jkorous added a reverting change for rGce583b14b2ec: [utils] Avoid hardcoding metadata ids in update_cc_test_checks: rG0376c0f27139: Revert "[utils] Avoid hardcoding metadata ids in update_cc_test_checks".
Tue, May 10, 2:05 PM · Restricted Project, Restricted Project, Restricted Project
jkorous added a reverting change for D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks: rG0376c0f27139: Revert "[utils] Avoid hardcoding metadata ids in update_cc_test_checks".
Tue, May 10, 2:05 PM · Restricted Project, Restricted Project, Restricted Project
jkorous committed rG0376c0f27139: Revert "[utils] Avoid hardcoding metadata ids in update_cc_test_checks" (authored by jkorous).
Revert "[utils] Avoid hardcoding metadata ids in update_cc_test_checks"
Tue, May 10, 2:05 PM · Restricted Project, Restricted Project, Restricted Project
jkorous added a comment to D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.

Reverting for now. Will take a look.

Tue, May 10, 2:03 PM · Restricted Project, Restricted Project, Restricted Project
jkorous committed rGce583b14b2ec: [utils] Avoid hardcoding metadata ids in update_cc_test_checks (authored by jkorous).
[utils] Avoid hardcoding metadata ids in update_cc_test_checks
Tue, May 10, 10:18 AM · Restricted Project, Restricted Project, Restricted Project
jkorous closed D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.
Tue, May 10, 10:18 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 9

jkorous added a comment to D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.

Ping.

Mon, May 9, 7:00 PM · Restricted Project, Restricted Project, Restricted Project

Mon, May 2

jkorous added a comment to D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.

Friendly ping.

Mon, May 2, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

jkorous updated the diff for D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.

Made the tests consistent with other pre-existing tests.

Apr 22 2022, 7:03 PM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2022

jkorous planned changes to D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.

Sure, will do! I intended to keep the tests simple but understand the desire for consistency.

Apr 7 2022, 1:25 PM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

jkorous requested review of D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.
Apr 6 2022, 7:45 PM · Restricted Project, Restricted Project, Restricted Project

Feb 16 2022

jkorous added a comment to rGb223e5f8468c: [Bitstream] Remove pessimizing move.

Thanks @jansvoboda11!

Feb 16 2022, 12:19 PM

Feb 15 2022

jkorous committed rG4a794d848ce8: [Bitstream] Improve error propagation from ReadVBR (authored by jkorous).
[Bitstream] Improve error propagation from ReadVBR
Feb 15 2022, 5:13 PM
jkorous committed rG6280c29a8701: [Bitstream] Add assert to ReadVBR and ReadVBR64 (authored by jkorous).
[Bitstream] Add assert to ReadVBR and ReadVBR64
Feb 15 2022, 5:13 PM
jkorous closed D119307: [Bitstream] Fix UB in left-shift in ReadVBR.
Feb 15 2022, 5:12 PM · Restricted Project

Feb 14 2022

jkorous added a comment to D119307: [Bitstream] Fix UB in left-shift in ReadVBR.

I noticed ReadVBR64 method below does the same arithmetics and keeping the implementation in sync seems like a no-brainer.

Feb 14 2022, 6:28 PM · Restricted Project
jkorous updated the diff for D119307: [Bitstream] Fix UB in left-shift in ReadVBR.

switched to assert
added the assert also to ReadVBR64

Feb 14 2022, 6:24 PM · Restricted Project

Feb 11 2022

jkorous added a comment to D119307: [Bitstream] Fix UB in left-shift in ReadVBR.

@nikic Sorry, my statement was incorrect. What I meant is that the method doesn't prevent UB via assert or runtime check of NumBits value.
I'm happy to go with assert if that'd be a better fit.

Feb 11 2022, 5:33 PM · Restricted Project
jkorous added inline comments to D119307: [Bitstream] Fix UB in left-shift in ReadVBR.
Feb 11 2022, 5:22 PM · Restricted Project
jkorous updated the diff for D119307: [Bitstream] Fix UB in left-shift in ReadVBR.

clang-format

Feb 11 2022, 5:21 PM · Restricted Project
jkorous updated the diff for D119307: [Bitstream] Fix UB in left-shift in ReadVBR.
Feb 11 2022, 5:20 PM · Restricted Project
jkorous updated the diff for D119307: [Bitstream] Fix UB in left-shift in ReadVBR.

rebased + improved error messages

Feb 11 2022, 5:08 PM · Restricted Project

Feb 8 2022

jkorous requested review of D119307: [Bitstream] Fix UB in left-shift in ReadVBR.
Feb 8 2022, 6:15 PM · Restricted Project

Jan 28 2022

jkorous added a comment to D117238: [C2x] Add BITINT_MAXWIDTH support.

I verified locally that reverting this patch fixes the build.
Reverted in fad7e491a0770ac4336934030ac67d77e7af5520 to unblock Green Dragon, etc.
@aaron.ballman Please take a look when you get a chance.

Jan 28 2022, 3:21 PM · Restricted Project
jkorous added a reverting change for rG86797fdb6f51: Add BITINT_MAXWIDTH support: rGfad7e491a077: Revert "Add BITINT_MAXWIDTH support".
Jan 28 2022, 3:19 PM
jkorous committed rGfad7e491a077: Revert "Add BITINT_MAXWIDTH support" (authored by jkorous).
Revert "Add BITINT_MAXWIDTH support"
Jan 28 2022, 3:19 PM
jkorous added a comment to D117238: [C2x] Add BITINT_MAXWIDTH support.

@aaron.ballman I believe this change broke the build starting with:

Jan 28 2022, 3:01 PM · Restricted Project

Jan 24 2022

jkorous committed rGdd01d971aa2c: [clang][dataflow] Avoid MaxIterations overflow (authored by jkorous).
[clang][dataflow] Avoid MaxIterations overflow
Jan 24 2022, 3:59 PM
jkorous closed D117938: [clang][dataflow] Avoid MaxIterations overflow.
Jan 24 2022, 3:59 PM · Restricted Project

Jan 21 2022

jkorous requested review of D117938: [clang][dataflow] Avoid MaxIterations overflow.
Jan 21 2022, 5:21 PM · Restricted Project
jkorous resigned from D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.
Jan 21 2022, 3:56 PM · Restricted Project, Restricted Project
jkorous resigned from D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName.
Jan 21 2022, 3:55 PM · Restricted Project
jkorous resigned from D63961: [clangd][xpc] pass the LSP value using data instead of string.
Jan 21 2022, 3:54 PM · Restricted Project, Restricted Project
jkorous resigned from D54047: Check TUScope is valid before use.
Jan 21 2022, 3:54 PM
jkorous resigned from D50814: [clangd] transfer the fixits with the notes instead of adding them to the main diagnostic if request by the client.
Jan 21 2022, 3:52 PM
jkorous abandoned D89638: [Analyzer][WebKit] Add attributes to suppress specific checkers.
Jan 21 2022, 3:51 PM
jkorous abandoned D67682: [WIP] Add support for preprocessing sources for analyzer.
Jan 21 2022, 3:51 PM
jkorous abandoned D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?.
Jan 21 2022, 3:50 PM · Restricted Project
jkorous resigned from D96196: [Sema][NFC] Create Sema::BuildImplicitCast.
Jan 21 2022, 3:49 PM · Restricted Project
jkorous resigned from D102555: [libclang] Enhance support for source-to-source rewriting.
Jan 21 2022, 3:48 PM · Restricted Project

Nov 15 2021

jkorous accepted D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/.

LGTM

Nov 15 2021, 1:56 PM · Restricted Project

Nov 11 2021

jkorous accepted D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty.

LGTM if we have test coverage for all the cases.

Nov 11 2021, 3:29 PM · Restricted Project

Nov 4 2021

jkorous requested changes to D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/.

Hi! Thank you for the clean-up :)

Nov 4 2021, 4:11 PM · Restricted Project

Apr 29 2021

jkorous added a comment to D101505: [Driver][sanitizers] Warn about ignored -fsanitize-trap or -fsanitize-recover.

I will send an email to llvm-dev@ and add a release note once I finish that.

Apr 29 2021, 12:50 PM
jkorous planned changes to D101505: [Driver][sanitizers] Warn about ignored -fsanitize-trap or -fsanitize-recover.

I just realized that for -fsanitize-recover the logic is inverted - it's actually -fno-sanitize-recover that's an explicit change from the default.
I will probably need to do the same thing I do for traps.

Apr 29 2021, 12:48 PM
jkorous updated the diff for D101505: [Driver][sanitizers] Warn about ignored -fsanitize-trap or -fsanitize-recover.

improved tests

Apr 29 2021, 11:03 AM
jkorous added inline comments to D101505: [Driver][sanitizers] Warn about ignored -fsanitize-trap or -fsanitize-recover.
Apr 29 2021, 11:02 AM

Apr 28 2021

jkorous requested review of D101505: [Driver][sanitizers] Warn about ignored -fsanitize-trap or -fsanitize-recover.
Apr 28 2021, 6:10 PM

Mar 4 2021

jkorous added a comment to D97878: [DirectoryWatcher] Increase timeout to make test less flaky.

Adding the comment would be great.

Mar 4 2021, 11:18 AM · Restricted Project

Dec 14 2020

jkorous added a comment to D93110: [analyzer] Implement fine-grained suppressions via attributes.

Thanks for working on this!

Dec 14 2020, 11:15 AM · Restricted Project

Oct 29 2020

jkorous added a comment to D89959: UBSAN: emit distinctive traps in trapping mode.

Friendly ping

Oct 29 2020, 8:58 AM · Restricted Project

Oct 22 2020

jkorous committed rG8277a513c74b: [SourceManager] Avoid copying SLocEntry in computeMacroArgsCache (authored by jkorous).
[SourceManager] Avoid copying SLocEntry in computeMacroArgsCache
Oct 22 2020, 2:19 PM
jkorous committed rGe7870223d8b5: [SourceManager] Skip module maps when searching files for macro arguments (authored by jkorous).
[SourceManager] Skip module maps when searching files for macro arguments
Oct 22 2020, 12:37 PM
jkorous closed D86230: [SourceManager] Skip module maps when searching files for macro arguments.
Oct 22 2020, 12:37 PM · Restricted Project

Oct 17 2020

jkorous requested review of D89638: [Analyzer][WebKit] Add attributes to suppress specific checkers.
Oct 17 2020, 8:35 PM

Sep 29 2020

jkorous added a comment to D88332: [WIP][Analyzer] PtrToIntegCastLibcChecker.

I would even go further. Why Clang Static Analyzer? I see nothing path-sensitive here. IMHO a better place to implement this functionality is Clang-Tidy.

Sep 29 2020, 12:01 AM

Sep 28 2020

jkorous added a comment to D88332: [WIP][Analyzer] PtrToIntegCastLibcChecker.
In D88332#2297374, @NoQ wrote:

Hmm, if we could add an interface to CallDescriptionMap to accept AnyCall instead of CallEvent then we could use it for path-insensitive checkers as well. That'd have saved some lines of code.

Sounds interesting but I lack context to imagine the details. Would the map be still initialized by some ASTVisitor? Do you think there'd be any noticeable performance hit?

Sep 28 2020, 11:43 PM
jkorous added a comment to D87176: [clang] Enable selectively turning on/off format-insufficient-args warning.

Had to fix the order of expected warnings in warning-wall.c
6fd8c69049a8 [clang] Update warning-wall.c test

Sep 28 2020, 5:22 PM · Restricted Project
jkorous committed rG6fd8c69049a8: [clang] Update warning-wall.c test (authored by jkorous).
[clang] Update warning-wall.c test
Sep 28 2020, 5:20 PM
jkorous committed rG1e86d637eb4f: [clang] Selectively ena/disa-ble format-insufficient-args warning (authored by jkorous).
[clang] Selectively ena/disa-ble format-insufficient-args warning
Sep 28 2020, 4:25 PM
jkorous closed D87176: [clang] Enable selectively turning on/off format-insufficient-args warning.
Sep 28 2020, 4:25 PM · Restricted Project
jkorous added a comment to D86230: [SourceManager] Skip module maps when searching files for macro arguments.

Friendly ping.
I'd like to land this sooner than later - I agree it'd be great to have a regression test but my (possibly biased) opinion is that the change is also simple and obvious enough that we could land it without a test.

Sep 28 2020, 9:06 AM · Restricted Project
jkorous added a comment to D87176: [clang] Enable selectively turning on/off format-insufficient-args warning.

Friendly ping

Sep 28 2020, 9:04 AM · Restricted Project
jkorous added a comment to D87800: [WIP][Analyzer] find stack addresses leaked via out-params.

Friendly ping

Sep 28 2020, 9:04 AM

Sep 25 2020

jkorous added inline comments to D88332: [WIP][Analyzer] PtrToIntegCastLibcChecker.
Sep 25 2020, 4:19 PM
jkorous requested review of D88332: [WIP][Analyzer] PtrToIntegCastLibcChecker.
Sep 25 2020, 12:43 PM

Sep 22 2020

jkorous added a comment to D88133: [Analyzer][WebKit] Use tri-state types for relevant predicates.

Created this for eventual post-commit review.

Sep 22 2020, 9:58 PM · Restricted Project
jkorous committed rG47e6851423fd: [Analyzer][WebKit] Use tri-state types for relevant predicates (authored by jkorous).
[Analyzer][WebKit] Use tri-state types for relevant predicates
Sep 22 2020, 9:57 PM
jkorous closed D88133: [Analyzer][WebKit] Use tri-state types for relevant predicates.
Sep 22 2020, 9:57 PM · Restricted Project
jkorous requested review of D88133: [Analyzer][WebKit] Use tri-state types for relevant predicates.
Sep 22 2020, 9:56 PM · Restricted Project
jkorous closed D83259: [Analyzer][WebKit] UncountedLocalVarsChecker.

I made a typo in the commit message reference so this revision didn't get closed automatically.

Sep 22 2020, 12:03 PM
jkorous added a comment to D83259: [Analyzer][WebKit] UncountedLocalVarsChecker.

Thank you Artem!

Sep 22 2020, 11:05 AM
jkorous committed rG8a64689e264c: [Analyzer][WebKit] UncountedLocalVarsChecker (authored by jkorous).
[Analyzer][WebKit] UncountedLocalVarsChecker
Sep 22 2020, 11:05 AM

Sep 21 2020

jkorous added inline comments to D87800: [WIP][Analyzer] find stack addresses leaked via out-params.
Sep 21 2020, 11:19 PM
jkorous added a comment to D87800: [WIP][Analyzer] find stack addresses leaked via out-params.

Thank you both for all the hints!

Sep 21 2020, 11:18 PM
jkorous requested review of D88070: [WIP][Analyzer] find stack addresses leaked via out-params - in checkEndFunction.
Sep 21 2020, 10:59 PM
jkorous updated the diff for D87800: [WIP][Analyzer] find stack addresses leaked via out-params.

Simply check memory regions of LHS and RHS in assignments instead of AST pattern matching.

Sep 21 2020, 10:56 PM
jkorous updated the diff for D83259: [Analyzer][WebKit] UncountedLocalVarsChecker.

Nits were addressed (hopefully).

Sep 21 2020, 10:38 AM
jkorous added inline comments to D83259: [Analyzer][WebKit] UncountedLocalVarsChecker.
Sep 21 2020, 10:35 AM

Sep 18 2020

jkorous updated the diff for D86230: [SourceManager] Skip module maps when searching files for macro arguments.

Attempt to write a unit test - so far can't reproduce even with unpatched master :(

Sep 18 2020, 6:05 PM · Restricted Project
jkorous updated the diff for D87176: [clang] Enable selectively turning on/off format-insufficient-args warning.

Added test

Sep 18 2020, 12:54 PM · Restricted Project

Sep 16 2020

jkorous requested review of D87800: [WIP][Analyzer] find stack addresses leaked via out-params.
Sep 16 2020, 3:14 PM

Sep 15 2020

jkorous committed rGae726fecae9a: [SourceManager] Explicitly check for potential iterator underflow (authored by jkorous).
[SourceManager] Explicitly check for potential iterator underflow
Sep 15 2020, 3:55 PM
jkorous closed D86231: [SourceManager] Explicitly check for potential iterator underflow.
Sep 15 2020, 3:54 PM · Restricted Project

Sep 14 2020

jkorous added a comment to D83259: [Analyzer][WebKit] UncountedLocalVarsChecker.

Friendly ping

Sep 14 2020, 10:18 AM

Sep 8 2020

jkorous updated subscribers of D83814: [clangd] Add Random Forest runtime for code completion..

Hi @usaxena95 and @sammccall,

Sep 8 2020, 10:38 AM · Restricted Project

Sep 4 2020

jkorous requested review of D87176: [clang] Enable selectively turning on/off format-insufficient-args warning.
Sep 4 2020, 6:32 PM · Restricted Project
jkorous committed rG7cfc8f0c7c24: [libclang] Add missing dependency on clangRewrite lib (authored by jkorous).
[libclang] Add missing dependency on clangRewrite lib
Sep 4 2020, 3:00 PM
jkorous committed rG69e5abb57b70: [libclang] Add CXRewriter to libclang API (authored by jkorous).
[libclang] Add CXRewriter to libclang API
Sep 4 2020, 2:17 PM
jkorous closed D86992: [libclang] Expose Rewriter in libclang API.
Sep 4 2020, 2:17 PM · Restricted Project
jkorous committed rG052f83890349: [libclang] Expose couple more AST details via cursors (authored by jkorous).
[libclang] Expose couple more AST details via cursors
Sep 4 2020, 1:41 PM
jkorous closed D86991: [libclang] Expose couple AST details.
Sep 4 2020, 1:41 PM · Restricted Project
jkorous updated the diff for D86991: [libclang] Expose couple AST details.
  • renamed
  • added tests
Sep 4 2020, 12:23 PM · Restricted Project
jkorous added a comment to D83259: [Analyzer][WebKit] UncountedLocalVarsChecker.

Sorry to bother you @NoQ - it'd be awesome if you could take a look!

Sep 4 2020, 10:58 AM