ModulePass doesn't provide any special utilities and thus doesn't give enough benefit to warrant a special pass class. This revision replaces all usages with the more general OperationPass.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D77339
[mlir][Pass][NFC] Replace usages of ModulePass with OperationPass<ModuleOp> ClosedPublic Authored by rriddle on Apr 2 2020, 2:44 PM.
Details Summary ModulePass doesn't provide any special utilities and thus doesn't give enough benefit to warrant a special pass class. This revision replaces all usages with the more general OperationPass.
Diff Detail
Event Timelinerriddle added a child revision: D77350: [mlir][Pass] Remove the use of CRTP from the Pass classes.Apr 2 2020, 5:12 PM This revision is now accepted and ready to land.Apr 2 2020, 5:21 PM Closed by commit rG722f909f7aa1: [mlir][Pass][NFC] Replace usages of ModulePass with OperationPass<ModuleOp> (authored by rriddle). · Explain WhyApr 7 2020, 2:11 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 254654 mlir/docs/Tutorials/Toy/Ch-6.md
mlir/examples/toy/Ch6/mlir/LowerToLLVM.cpp
mlir/examples/toy/Ch7/mlir/LowerToLLVM.cpp
mlir/include/mlir/Pass/Pass.h
mlir/lib/Conversion/AVX512ToLLVM/ConvertAVX512ToLLVM.cpp
mlir/lib/Conversion/GPUToCUDA/ConvertLaunchFuncToCudaCalls.cpp
mlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRVPass.cpp
mlir/lib/Conversion/GPUToVulkan/ConvertGPULaunchFuncToVulkanLaunchFunc.cpp
mlir/lib/Conversion/GPUToVulkan/ConvertLaunchFuncToVulkanCalls.cpp
mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp
mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRVPass.cpp
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRVPass.cpp
mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp
mlir/lib/Dialect/SPIRV/Transforms/DecorateSPIRVCompositeTypeLayoutPass.cpp
mlir/lib/Quantizer/Transforms/InferQuantizedTypesPass.cpp
mlir/lib/Transforms/OpStats.cpp
mlir/lib/Transforms/ViewOpGraph.cpp
mlir/test/lib/Dialect/Test/TestPatterns.cpp
mlir/test/lib/IR/TestFunc.cpp
mlir/test/lib/IR/TestSideEffects.cpp
mlir/test/lib/IR/TestSymbolUses.cpp
mlir/test/lib/Pass/TestPassManager.cpp
mlir/test/lib/Transforms/TestAllReduceLowering.cppmlir/test/lib/Transforms/TestCallGraph.cppmlir/test/lib/Transforms/TestOpaqueLoc.cpp
|
clang-format-diff not found in user's PATH; not linting file.