Page MenuHomePhabricator

[hip] Revise `GlobalDecl` constructors. NFC.
ClosedPublic

Authored by hliao on Mar 17 2020, 10:51 PM.

Details

Summary
  • https://reviews.llvm.org/D68578 revises the GlobalDecl constructors to ensure all GPU kernels have ReferenceKenelKind initialized properly with an explicit constructor and static one. But, there are lots of places using the implicit constructor triggering the assertion on non-GPU kernels. That's found in compilation of many tests and workloads.
  • Fixing all of them may change more code and, more importantly, all of them assumes the default kernel reference kind. This patch changes that constructor to tell CUDAGlobalAttr and construct GlobalDecl properly.

Diff Detail

Event Timeline

hliao created this revision.Mar 17 2020, 10:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2020, 10:51 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
yaxunl accepted this revision.Mar 18 2020, 3:49 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 18 2020, 3:49 AM
This revision was automatically updated to reflect the committed changes.