Page MenuHomePhabricator

hliao (Michael Liao)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 7 2014, 12:01 PM (249 w, 3 d)

Recent Activity

Fri, May 17

hliao committed rG63621832da65: Suppress false-positive GCC -Wreturn-type warning. (authored by hliao).
Suppress false-positive GCC -Wreturn-type warning.
Fri, May 17, 11:34 PM
hliao committed rL361094: Suppress false-positive GCC -Wreturn-type warning..
Suppress false-positive GCC -Wreturn-type warning.
Fri, May 17, 11:34 PM
hliao committed rLLD361094: Suppress false-positive GCC -Wreturn-type warning..
Suppress false-positive GCC -Wreturn-type warning.
Fri, May 17, 11:34 PM

Fri, May 10

hliao committed rGb284414a1bf1: [InferAddressSpaces] Enhance the handling of cosntexpr. (authored by hliao).
[InferAddressSpaces] Enhance the handling of cosntexpr.
Fri, May 10, 7:56 AM
hliao committed rL360431: [InferAddressSpaces] Enhance the handling of cosntexpr..
[InferAddressSpaces] Enhance the handling of cosntexpr.
Fri, May 10, 7:56 AM
hliao closed D61760: [InferAddressSpaces] Enhance the handling of cosntexpr..
Fri, May 10, 7:56 AM · Restricted Project

Thu, May 9

hliao created D61760: [InferAddressSpaces] Enhance the handling of cosntexpr..
Thu, May 9, 2:29 PM · Restricted Project

Tue, May 7

hliao committed rG0fb707b93b93: [hip] Fix ambiguity from `>>>` of CUDA. (authored by hliao).
[hip] Fix ambiguity from `>>>` of CUDA.
Tue, May 7, 5:52 PM
hliao committed rC360214: [hip] Fix ambiguity from `>>>` of CUDA..
[hip] Fix ambiguity from `>>>` of CUDA.
Tue, May 7, 5:52 PM
hliao committed rL360214: [hip] Fix ambiguity from `>>>` of CUDA..
[hip] Fix ambiguity from `>>>` of CUDA.
Tue, May 7, 5:52 PM
hliao closed D61396: [hip] Fix ambiguity from `>>>` of CUDA..
Tue, May 7, 5:52 PM · Restricted Project, Restricted Project
hliao added a comment to D61396: [hip] Fix ambiguity from `>>>` of CUDA..

done

Tue, May 7, 3:14 PM · Restricted Project, Restricted Project
hliao updated the diff for D61396: [hip] Fix ambiguity from `>>>` of CUDA..

Add one unrealistic case for test purpose only.

Tue, May 7, 3:13 PM · Restricted Project, Restricted Project
hliao added a comment to D61396: [hip] Fix ambiguity from `>>>` of CUDA..

done

Tue, May 7, 2:24 PM · Restricted Project, Restricted Project
hliao updated the diff for D61396: [hip] Fix ambiguity from `>>>` of CUDA..

revise following reviewer's suggestion.

Tue, May 7, 2:20 PM · Restricted Project, Restricted Project
hliao added a comment to D61396: [hip] Fix ambiguity from `>>>` of CUDA..

@rsmith Do you have the chance to review this patch?

Tue, May 7, 5:24 AM · Restricted Project, Restricted Project

Mon, May 6

hliao added a comment to D61396: [hip] Fix ambiguity from `>>>` of CUDA..

@rsmith Do you have the chance to review this patch?

Mon, May 6, 9:54 AM · Restricted Project, Restricted Project

Fri, May 3

hliao added a comment to D61396: [hip] Fix ambiguity from `>>>` of CUDA..

ping

Fri, May 3, 5:53 AM · Restricted Project, Restricted Project
hliao added inline comments to D61458: [hip] Relax CUDA call restriction within `decltype` context..
Fri, May 3, 5:50 AM · Restricted Project
hliao added a comment to D61458: [hip] Relax CUDA call restriction within `decltype` context..

Here's one for you:

__host__ float bar();
__device__ int bar();
__host__ __device__ auto foo() -> decltype(bar()) {}

What is the return type of foo? :)

I don't believe the right answer is, "float when compiling for host, int when compiling for device."

I'd be happy if we said this was an error, so long as it's well-defined what exactly we're disallowing. But I bet @rsmith can come up with substantially more evil testcases than this.

Fri, May 3, 5:43 AM · Restricted Project
hliao added a comment to D61458: [hip] Relax CUDA call restriction within `decltype` context..

Here's one for you:

__host__ float bar();
__device__ int bar();
__host__ __device__ auto foo() -> decltype(bar()) {}

What is the return type of foo? :)

I don't believe the right answer is, "float when compiling for host, int when compiling for device."

So, actually, I wonder if that's not the right answer. We generally allow different overloads to have different return types.

Only if they also differ in some other way. C++ does not (generally) have return-type-based overloading. The two functions described would even mangle the same way if CUDA didn't include host/device in the mangling.

(Function templates can differ only by return type, but if both return types successfully instantiate for a given set of (possibly inferred) template arguments then the templates can only be distinguished when taking their address, not when calling.)

I think I've said before that adding this kind of overloading is not a good idea, but since it's apparently already there, you should consult the specification (or at least existing practice) to figure out what you're supposed to do.

Fri, May 3, 5:37 AM · Restricted Project
hliao added a comment to D61458: [hip] Relax CUDA call restriction within `decltype` context..

Here's one for you:

__host__ float bar();
__device__ int bar();
__host__ __device__ auto foo() -> decltype(bar()) {}

What is the return type of foo? :)

I don't believe the right answer is, "float when compiling for host, int when compiling for device."

I'd be happy if we said this was an error, so long as it's well-defined what exactly we're disallowing. But I bet @rsmith can come up with substantially more evil testcases than this.

Fri, May 3, 5:26 AM · Restricted Project

Thu, May 2

hliao updated the diff for D61458: [hip] Relax CUDA call restriction within `decltype` context..

simplify the logic using llvm::any_of.

Thu, May 2, 1:57 PM · Restricted Project
hliao added a comment to D61458: [hip] Relax CUDA call restriction within `decltype` context..
In D61458#1488523, @tra wrote:

Perhaps we should allow this in all unevaluated contexts?
I.e. int s = sizeof(foo(x)); should also work.

Thu, May 2, 1:49 PM · Restricted Project
hliao created D61458: [hip] Relax CUDA call restriction within `decltype` context..
Thu, May 2, 1:03 PM · Restricted Project
hliao added a comment to D61396: [hip] Fix ambiguity from `>>>` of CUDA..

@rsmith do you have the chance to review this simple fix?

Thu, May 2, 7:33 AM · Restricted Project, Restricted Project

Wed, May 1

hliao added a comment to D61396: [hip] Fix ambiguity from `>>>` of CUDA..
In D61396#1486706, @tra wrote:

LGTM, but I've added @rsmith who is way more familiar with this code.

Wed, May 1, 1:26 PM · Restricted Project, Restricted Project
hliao created D61396: [hip] Fix ambiguity from `>>>` of CUDA..
Wed, May 1, 1:12 PM · Restricted Project, Restricted Project

Fri, Apr 26

hliao committed rG3820506960e0: [HIP] Fix visibility of `__constant__` variables. (authored by hliao).
[HIP] Fix visibility of `__constant__` variables.
Fri, Apr 26, 12:31 PM
hliao committed rL359344: [HIP] Fix visibility of `__constant__` variables..
[HIP] Fix visibility of `__constant__` variables.
Fri, Apr 26, 12:30 PM
hliao committed rC359344: [HIP] Fix visibility of `__constant__` variables..
[HIP] Fix visibility of `__constant__` variables.
Fri, Apr 26, 12:30 PM
hliao closed D61194: [HIP] Fix visibility of `__constant__` variables..
Fri, Apr 26, 12:30 PM · Restricted Project
hliao added inline comments to D61194: [HIP] Fix visibility of `__constant__` variables..
Fri, Apr 26, 11:44 AM · Restricted Project
hliao added inline comments to D61194: [HIP] Fix visibility of `__constant__` variables..
Fri, Apr 26, 11:41 AM · Restricted Project
hliao created D61194: [HIP] Fix visibility of `__constant__` variables..
Fri, Apr 26, 8:27 AM · Restricted Project

Mon, Apr 22

hliao committed rG389d5a3474eb: [AMDGPU] Fix an issue in `op_sel_hi` skipping. (authored by hliao).
[AMDGPU] Fix an issue in `op_sel_hi` skipping.
Mon, Apr 22, 3:06 PM
hliao committed rL358922: [AMDGPU] Fix an issue in `op_sel_hi` skipping..
[AMDGPU] Fix an issue in `op_sel_hi` skipping.
Mon, Apr 22, 3:05 PM
hliao closed D60978: [AMDGPU] Fix an issue in `op_sel_hi` skipping..
Mon, Apr 22, 3:05 PM · Restricted Project
hliao created D60978: [AMDGPU] Fix an issue in `op_sel_hi` skipping..
Mon, Apr 22, 2:01 PM · Restricted Project

Apr 9 2019

hliao abandoned D60478: [InstCombine] Fix canonicalization of (-X s/ Y) to -(X s/ Y)..
Apr 9 2019, 12:09 PM · Restricted Project
hliao added reviewers for D60478: [InstCombine] Fix canonicalization of (-X s/ Y) to -(X s/ Y).: lebedev.ri, RKSimon.
Apr 9 2019, 11:31 AM · Restricted Project
hliao added a comment to D60478: [InstCombine] Fix canonicalization of (-X s/ Y) to -(X s/ Y)..

Hi Chen

Apr 9 2019, 11:23 AM · Restricted Project
hliao created D60478: [InstCombine] Fix canonicalization of (-X s/ Y) to -(X s/ Y)..
Apr 9 2019, 11:22 AM · Restricted Project

Apr 2 2019

hliao committed rGdeef72091a3b: [ObjectYAML] Fix build issue (authored by hliao).
[ObjectYAML] Fix build issue
Apr 2 2019, 6:01 AM
hliao committed rL357471: [ObjectYAML] Fix build issue.
[ObjectYAML] Fix build issue
Apr 2 2019, 6:00 AM

Apr 1 2019

hliao committed rG9bef688bc29f: [AMDGPU] Add more test cases of D59608. (authored by hliao).
[AMDGPU] Add more test cases of D59608.
Apr 1 2019, 5:37 PM
hliao committed rL357442: [AMDGPU] Add more test cases of D59608..
[AMDGPU] Add more test cases of D59608.
Apr 1 2019, 5:35 PM
hliao added a comment to D60071: [AMDGPU] Add more test cases of D59608..

LGTM

Apr 1 2019, 5:35 PM · Restricted Project
hliao closed D60071: [AMDGPU] Add more test cases of D59608..
Apr 1 2019, 5:35 PM · Restricted Project
hliao updated the diff for D60071: [AMDGPU] Add more test cases of D59608..

revise again

Apr 1 2019, 5:30 PM · Restricted Project
hliao added inline comments to D60071: [AMDGPU] Add more test cases of D59608..
Apr 1 2019, 5:19 PM · Restricted Project
hliao updated the diff for D60071: [AMDGPU] Add more test cases of D59608..

more revising

Apr 1 2019, 1:25 PM · Restricted Project
hliao updated the diff for D60071: [AMDGPU] Add more test cases of D59608..

revise more

Apr 1 2019, 1:21 PM · Restricted Project
hliao updated the diff for D60071: [AMDGPU] Add more test cases of D59608..

Add tests for DS addressing mode.

Apr 1 2019, 12:45 PM · Restricted Project
hliao added a comment to D59608: [AMDGPU] Fix clamp bit DAG operand.

sorry, saw this too late, will address in another patch

ping

Apr 1 2019, 9:11 AM · Restricted Project
hliao created D60071: [AMDGPU] Add more test cases of D59608..
Apr 1 2019, 9:10 AM · Restricted Project

Mar 28 2019

hliao committed rGce38992a3079: [Sema] Fix a crash when nonnull checking (authored by hliao).
[Sema] Fix a crash when nonnull checking
Mar 28 2019, 8:55 PM
hliao committed rC357236: [Sema] Fix a crash when nonnull checking.
[Sema] Fix a crash when nonnull checking
Mar 28 2019, 8:55 PM
hliao committed rL357236: [Sema] Fix a crash when nonnull checking.
[Sema] Fix a crash when nonnull checking
Mar 28 2019, 8:54 PM
hliao closed D59900: [Sema] Fix a crash when nonnull checking.
Mar 28 2019, 8:54 PM · Restricted Project, Restricted Project
hliao added a comment to D59900: [Sema] Fix a crash when nonnull checking.

just search bugzilla and, fortunately, found this issue is reported 2+ years ago @ https://bugs.llvm.org/show_bug.cgi?id=30559. I will revise the test case to PR30559 and move it into test/SemaCXX/nonnull.cpp

Mar 28 2019, 7:03 PM · Restricted Project, Restricted Project
hliao added a comment to D59900: [Sema] Fix a crash when nonnull checking.

just explain what's the issue is and hope that help reviewers to get this fix quick.

Mar 28 2019, 5:50 AM · Restricted Project, Restricted Project

Mar 27 2019

hliao created D59900: [Sema] Fix a crash when nonnull checking.
Mar 27 2019, 1:39 PM · Restricted Project, Restricted Project

Mar 20 2019

hliao committed rGbbcb95a64e18: [AMDGPU] Fix dependency on `BinaryFormat` (authored by hliao).
[AMDGPU] Fix dependency on `BinaryFormat`
Mar 20 2019, 2:24 PM
hliao committed rL356617: [AMDGPU] Fix dependency on `BinaryFormat`.
[AMDGPU] Fix dependency on `BinaryFormat`
Mar 20 2019, 2:24 PM
hliao closed D59610: [AMDGPU] Fix dependency on `BinaryFormat`.
Mar 20 2019, 2:24 PM · Restricted Project
hliao accepted D59613: [AMDGPU] Do not generate spurious PAL metadata.

LGTM

Mar 20 2019, 2:24 PM · Restricted Project
hliao added reviewers for D59610: [AMDGPU] Fix dependency on `BinaryFormat`: rampitec, arsenm.
Mar 20 2019, 1:41 PM · Restricted Project
hliao created D59610: [AMDGPU] Fix dependency on `BinaryFormat`.
Mar 20 2019, 1:40 PM · Restricted Project
hliao committed rGeea5177d3084: [AMDGPU] Fix clamp bit DAG operand (authored by hliao).
[AMDGPU] Fix clamp bit DAG operand
Mar 20 2019, 1:21 PM
hliao committed rL356608: [AMDGPU] Fix clamp bit DAG operand.
[AMDGPU] Fix clamp bit DAG operand
Mar 20 2019, 1:21 PM
hliao closed D59608: [AMDGPU] Fix clamp bit DAG operand.
Mar 20 2019, 1:21 PM · Restricted Project
hliao added a comment to D59608: [AMDGPU] Fix clamp bit DAG operand.

Thanks. Done!

Mar 20 2019, 1:20 PM · Restricted Project
hliao added a comment to D59608: [AMDGPU] Fix clamp bit DAG operand.

sorry, saw this too late, will address in another patch

Mar 20 2019, 1:20 PM · Restricted Project
hliao added a comment to D59608: [AMDGPU] Fix clamp bit DAG operand.

Ah, yes, but this patch covers more cases. Shall we merge them together.

Mar 20 2019, 1:09 PM · Restricted Project
hliao added reviewers for D59608: [AMDGPU] Fix clamp bit DAG operand: rampitec, arsenm, tpr.
Mar 20 2019, 12:42 PM · Restricted Project
hliao created D59608: [AMDGPU] Fix clamp bit DAG operand.
Mar 20 2019, 12:42 PM · Restricted Project

Mar 18 2019

hliao committed rGefb4f9e568bf: [AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`. (authored by hliao).
[AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`.
Mar 18 2019, 1:41 PM
hliao committed rL356405: [AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`..
[AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`.
Mar 18 2019, 1:41 PM
hliao closed D59501: [AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`..
Mar 18 2019, 1:40 PM · Restricted Project
hliao updated the diff for D59501: [AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`..

revise again

Mar 18 2019, 1:29 PM · Restricted Project
hliao updated the diff for D59501: [AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`..

Update the test case following reviewers' comments.

Mar 18 2019, 12:13 PM · Restricted Project
hliao added inline comments to D59501: [AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`..
Mar 18 2019, 11:31 AM · Restricted Project
hliao added reviewers for D59501: [AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`.: rampitec, arsenm.
Mar 18 2019, 11:21 AM · Restricted Project
hliao created D59501: [AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`..
Mar 18 2019, 11:20 AM · Restricted Project
hliao committed rG3c2aadbe6703: [AMDGPU] Add the missing clang change of the experimental buffer fat pointer (authored by hliao).
[AMDGPU] Add the missing clang change of the experimental buffer fat pointer
Mar 18 2019, 11:14 AM
hliao committed rC356385: [AMDGPU] Add the missing clang change of the experimental buffer fat pointer.
[AMDGPU] Add the missing clang change of the experimental buffer fat pointer
Mar 18 2019, 11:14 AM
hliao committed rL356385: [AMDGPU] Add the missing clang change of the experimental buffer fat pointer.
[AMDGPU] Add the missing clang change of the experimental buffer fat pointer
Mar 18 2019, 11:14 AM
hliao committed rGc131e0e2ae54: [MVT] Fix typos in comment. NFC. (authored by hliao).
[MVT] Fix typos in comment. NFC.
Mar 18 2019, 9:59 AM
hliao committed rL356381: [MVT] Fix typos in comment. NFC..
[MVT] Fix typos in comment. NFC.
Mar 18 2019, 9:59 AM

Mar 15 2019

hliao committed rG6883d7e192fc: [AMDGPU] Fix SGPR fixing through SCC chaining (authored by hliao).
[AMDGPU] Fix SGPR fixing through SCC chaining
Mar 15 2019, 5:43 AM
hliao committed rL356258: [AMDGPU] Fix SGPR fixing through SCC chaining.
[AMDGPU] Fix SGPR fixing through SCC chaining
Mar 15 2019, 5:43 AM
hliao closed D59362: [AMDGPU] Fix SGPR fixing through SCC chaining.
Mar 15 2019, 5:43 AM · Restricted Project

Mar 14 2019

hliao edited reviewers for D59362: [AMDGPU] Fix SGPR fixing through SCC chaining, added: rampitec; removed: stanblesk.
Mar 14 2019, 10:03 AM · Restricted Project
hliao added inline comments to D59362: [AMDGPU] Fix SGPR fixing through SCC chaining.
Mar 14 2019, 9:37 AM · Restricted Project
hliao updated the diff for D59362: [AMDGPU] Fix SGPR fixing through SCC chaining.

Add minimal MIR test

Mar 14 2019, 9:37 AM · Restricted Project
hliao added inline comments to D59362: [AMDGPU] Fix SGPR fixing through SCC chaining.
Mar 14 2019, 7:55 AM · Restricted Project
hliao added reviewers for D59362: [AMDGPU] Fix SGPR fixing through SCC chaining: arsenm, stanblesk.
Mar 14 2019, 6:39 AM · Restricted Project
hliao created D59362: [AMDGPU] Fix SGPR fixing through SCC chaining.
Mar 14 2019, 6:39 AM · Restricted Project

Mar 6 2019

hliao committed rG982cbb623251: [CUDA][HIP][DebugInfo] Skip reference device function (authored by hliao).
[CUDA][HIP][DebugInfo] Skip reference device function
Mar 6 2019, 1:16 PM