Page MenuHomePhabricator

hliao (Michael Liao)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 7 2014, 12:01 PM (411 w, 6 d)

Recent Activity

Apr 21 2022

hliao committed rG036aeac36c00: [Testing] Fix the shared build. NFC. (authored by hliao).
[Testing] Fix the shared build. NFC.
Apr 21 2022, 11:47 PM · Restricted Project, Restricted Project

Apr 14 2022

hliao committed rGf9486f213975: [LoongArch] Fix shared build. NFC. (authored by hliao).
[LoongArch] Fix shared build. NFC.
Apr 14 2022, 9:22 PM · Unknown Object (Project), Restricted Project

Mar 30 2022

hliao committed rG73ab5fd17b57: [clang] Fix shared build. NFC. (authored by hliao).
[clang] Fix shared build. NFC.
Mar 30 2022, 11:05 AM · Restricted Project, Restricted Project

Jan 4 2022

hliao committed rG56ec762a76cb: [regalloc] Fix GCC warning `-Wattributes`. NFC. (authored by hliao).
[regalloc] Fix GCC warning `-Wattributes`. NFC.
Jan 4 2022, 9:06 AM

Jan 3 2022

hliao committed rG7505aeefc4e6: [clang] Pacify GCC warning. NFC. (authored by hliao).
[clang] Pacify GCC warning. NFC.
Jan 3 2022, 8:07 AM
hliao added a reverting change for rGd677a7cb056b: [clang] Remove redundant member initialization (NFC): rG7505aeefc4e6: [clang] Pacify GCC warning. NFC..
Jan 3 2022, 8:07 AM

Dec 26 2021

hliao updated the diff for D115976: [clang] Fix a crash case when reporting an uninitialized field..

Rebase

Dec 26 2021, 9:13 AM · Restricted Project

Dec 17 2021

hliao updated the diff for D115976: [clang] Fix a crash case when reporting an uninitialized field..

Revise the formatting.

Dec 17 2021, 6:11 PM · Restricted Project
hliao requested review of D115976: [clang] Fix a crash case when reporting an uninitialized field..
Dec 17 2021, 3:06 PM · Restricted Project

Dec 10 2021

hliao committed rG17414b61245d: Fix shared build of unittests. (authored by hliao).
Fix shared build of unittests.
Dec 10 2021, 12:34 PM

Dec 5 2021

hliao committed rGb6ccca217c35: Fix `-Wunused-variable` warning. NFC. (authored by hliao).
Fix `-Wunused-variable` warning. NFC.
Dec 5 2021, 10:44 AM

Dec 4 2021

hliao committed rG53fc971a4b79: Fix `-Wunused-variable` warning. NFC. (authored by hliao).
Fix `-Wunused-variable` warning. NFC.
Dec 4 2021, 8:42 PM

Nov 17 2021

hliao committed rGb861c3600c4a: Fix -Wparentheses warnings. NFC. (authored by hliao).
Fix -Wparentheses warnings. NFC.
Nov 17 2021, 12:32 PM

Nov 11 2021

hliao abandoned D87858: [hip] Add HIP scope atomic ops..
Nov 11 2021, 1:22 PM · Restricted Project
hliao added a comment to D87858: [hip] Add HIP scope atomic ops..

Hi Michael, would you like to continue working on this, or let someone from AMD to take over? Thanks.

Nov 11 2021, 1:22 PM · Restricted Project

Nov 8 2021

hliao committed rGbf225939bc3a: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates. (authored by hliao).
[InferAddressSpaces] Support assumed addrspaces from addrspace predicates.
Nov 8 2021, 1:52 PM
hliao closed D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..
Nov 8 2021, 1:52 PM · Unknown Object (Project), Restricted Project
hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Rebase and kindly PING for review.

Nov 8 2021, 6:52 AM · Unknown Object (Project), Restricted Project

Nov 7 2021

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Rebase and ping for further review.

Nov 7 2021, 4:43 PM · Unknown Object (Project), Restricted Project

Nov 5 2021

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Rebase to the main branch.

Nov 5 2021, 8:22 AM · Unknown Object (Project), Restricted Project
hliao committed rGaf2ae2cf42a0: [BranchRelaxation] Fix warning on unused variable. NFC. (authored by hliao).
[BranchRelaxation] Fix warning on unused variable. NFC.
Nov 5 2021, 8:18 AM

Nov 4 2021

hliao added inline comments to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..
Nov 4 2021, 7:49 AM · Unknown Object (Project), Restricted Project
hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Rebase and kindly ping for review.

Nov 4 2021, 7:48 AM · Unknown Object (Project), Restricted Project

Nov 3 2021

hliao added a comment to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

I'd still like an answer to:

Is it actually necessary to thread this through AssumptionCache, given how InferAddressSpaces is the only place that looks at these assumes?

I'd prefer not to infect AC with TTI if not necessary.

Nov 3 2021, 11:40 AM · Unknown Object (Project), Restricted Project
hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Updated.

Nov 3 2021, 11:29 AM · Unknown Object (Project), Restricted Project
hliao added a comment to D112466: [NVPTX] Drop memory references of LDG/LDU.

These machine instruction should be marked with mayLoad as they are really load instructions. Check the attached patch fixing the machine verifier.

This is where we started from in this review request (see the revision 382033).
I think the consensus is that LDU is not a load, because it operates on read-only memory (and therefore can be safely excluded from memory-related analysis).
I'm not sure about LDG though.

Nov 3 2021, 11:27 AM · Restricted Project, Unknown Object (Project)
hliao added a comment to D112466: [NVPTX] Drop memory references of LDG/LDU.

These machine instruction should be marked with mayLoad as they are really load instructions. Check the attached patch fixing the machine verifier.

Nov 3 2021, 8:12 AM · Restricted Project, Unknown Object (Project)
hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Move the updating action into updateAddrSpace and return a boolean true if it's really updated.

Nov 3 2021, 7:46 AM · Unknown Object (Project), Restricted Project
hliao added a comment to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Sorry for the late reply.

Nov 3 2021, 7:33 AM · Unknown Object (Project), Restricted Project

Oct 27 2021

hliao committed rGe6a4ba3aa603: [amdgpu] Handle the case where there is no scavenged register. (authored by hliao).
[amdgpu] Handle the case where there is no scavenged register.
Oct 27 2021, 3:38 PM
hliao closed D106449: [amdgpu] Handle the case where there is no scavenged register..
Oct 27 2021, 3:37 PM · Unknown Object (Project)
hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Update non-kernel test case

Oct 27 2021, 3:08 PM · Unknown Object (Project)
hliao added inline comments to D106449: [amdgpu] Handle the case where there is no scavenged register..
Oct 27 2021, 12:56 PM · Unknown Object (Project)
hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Add a non-kernel function case.

Oct 27 2021, 12:51 PM · Unknown Object (Project)
hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Revise following reviewers' comment.

Oct 27 2021, 12:38 PM · Unknown Object (Project)
hliao committed rG6c9f207826ef: [cmake] Surpress cmake warning on that EH requires RTTI. NFC. (authored by hliao).
[cmake] Surpress cmake warning on that EH requires RTTI. NFC.
Oct 27 2021, 9:56 AM

Oct 25 2021

hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Rebase and kingly PING for review.

Oct 25 2021, 8:29 AM · Unknown Object (Project)
hliao added a comment to D106449: [amdgpu] Handle the case where there is no scavenged register..

Kingly PING for review

Oct 25 2021, 8:22 AM · Unknown Object (Project)

Oct 19 2021

hliao added a comment to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Is there anything to remove assume() call after address space is inferred? We do not need it anymore.

along with a few other intrinsics, assume intrinsic is discarded in SDAG and GISel.

We may want to discard these earlier for the sake of Value::hasOneUse(). These are really not needed after casts are inserted.

Oct 19 2021, 10:43 PM · Unknown Object (Project), Restricted Project
hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Revise commit message.

Oct 19 2021, 4:00 PM · Unknown Object (Project), Restricted Project
hliao added inline comments to D112053: [cuda] Add address space predicate funuctions..
Oct 19 2021, 3:30 PM · Restricted Project
hliao added inline comments to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..
Oct 19 2021, 3:26 PM · Unknown Object (Project), Restricted Project
hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Revise following reviewers' feedback.

Oct 19 2021, 3:21 PM · Unknown Object (Project), Restricted Project
hliao added a comment to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Is there anything to remove assume() call after address space is inferred? We do not need it anymore.

Oct 19 2021, 1:32 PM · Unknown Object (Project), Restricted Project
hliao added inline comments to D112053: [cuda] Add address space predicate funuctions..
Oct 19 2021, 1:23 PM · Restricted Project
hliao added inline comments to D112053: [cuda] Add address space predicate funuctions..
Oct 19 2021, 1:22 PM · Restricted Project
hliao committed rG6fe902daf931: [cuda] Add address space predicate funuctions. (authored by hliao).
[cuda] Add address space predicate funuctions.
Oct 19 2021, 1:20 PM
hliao closed D112053: [cuda] Add address space predicate funuctions..
Oct 19 2021, 1:20 PM · Restricted Project
hliao added a watcher for debug-info: hliao.
Oct 19 2021, 8:31 AM

Oct 18 2021

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Fix formatting again following clang-format.

Oct 18 2021, 9:33 PM · Unknown Object (Project), Restricted Project
hliao added a comment to D112053: [cuda] Add address space predicate funuctions..

With this patch, the following code could be compiled into the same PTX as NVCC. Check https://godbolt.org/z/q6EYE1q1o for the difference between NVCC and the current Clang output.

Oct 18 2021, 9:24 PM · Restricted Project
hliao requested review of D112053: [cuda] Add address space predicate funuctions..
Oct 18 2021, 9:17 PM · Restricted Project
hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Fix formatting.

Oct 18 2021, 8:27 PM · Unknown Object (Project), Restricted Project
hliao updated the summary of D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..
Oct 18 2021, 5:45 PM · Unknown Object (Project), Restricted Project
hliao requested review of D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..
Oct 18 2021, 5:39 PM · Unknown Object (Project), Restricted Project

Oct 15 2021

hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Rebase and kindly PING for review.

Oct 15 2021, 10:36 AM · Unknown Object (Project)
hliao committed rGbacddf47a838: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow (authored by hliao).
[amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow
Oct 15 2021, 10:23 AM
hliao closed D111831: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow.
Oct 15 2021, 10:22 AM · Unknown Object (Project)
hliao abandoned D111834: Clean up test case..
Oct 15 2021, 6:04 AM · Unknown Object (Project)

Oct 14 2021

hliao updated the diff for D111831: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow.

Remove '!llvm.ident' in that test triggering crash.

Oct 14 2021, 1:28 PM · Unknown Object (Project)
hliao requested review of D111834: Clean up test case..
Oct 14 2021, 1:28 PM · Unknown Object (Project)
hliao updated the diff for D111831: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow.

Revise the comment.

Oct 14 2021, 1:22 PM · Unknown Object (Project)
hliao updated the diff for D111831: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow.

Fix typo.

Oct 14 2021, 1:21 PM · Unknown Object (Project)
hliao requested review of D111831: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow.
Oct 14 2021, 1:15 PM · Unknown Object (Project)

Oct 12 2021

hliao accepted D111464: [AMDGPU] Promote generic pointer kernel arguments into global.

LGTM

Oct 12 2021, 5:55 AM · Unknown Object (Project)

Sep 29 2021

hliao added inline comments to D106449: [amdgpu] Handle the case where there is no scavenged register..
Sep 29 2021, 7:31 PM · Unknown Object (Project)
hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Fix typos and remove dead code.

Sep 29 2021, 7:23 PM · Unknown Object (Project)

Sep 21 2021

hliao accepted D110089: [CUDA] Implement experimental support for texture lookups..

Cool! I like the idea of *compile-time* dispatch. LGTM except minor warnings from clang-tidy. Could you fix them before committing this change?

Sep 21 2021, 1:16 PM · Restricted Project
hliao committed rG2d1ffad01074: [IR] Re-group AAMDNodes relevant interfaces. NFC. (authored by hliao).
[IR] Re-group AAMDNodes relevant interfaces. NFC.
Sep 21 2021, 11:31 AM
hliao committed rG5fb3ae525ffa: [SelectionDAG] Re-calculate scoped AA metadata when merging stores. (authored by hliao).
[SelectionDAG] Re-calculate scoped AA metadata when merging stores.
Sep 21 2021, 8:50 AM
hliao closed D102821: [SelectionDAG] Re-calculate scoped AA metadata when merging stores..
Sep 21 2021, 8:50 AM · Unknown Object (Project)

Sep 20 2021

hliao updated the diff for D102821: [SelectionDAG] Re-calculate scoped AA metadata when merging stores..

Add concat to replace merge, which overlapping locations are expected.

Sep 20 2021, 12:43 PM · Unknown Object (Project)
hliao updated the diff for D102821: [SelectionDAG] Re-calculate scoped AA metadata when merging stores..

Rebase after metadata interfaces are already revised in D109852

Sep 20 2021, 11:57 AM · Unknown Object (Project)

Sep 16 2021

hliao committed rGffa5c3a555a8: Fix warning on `llvm-else-after-return`. NFC. (authored by hliao).
Fix warning on `llvm-else-after-return`. NFC.
Sep 16 2021, 8:26 AM

Sep 15 2021

hliao abandoned D104863: [LSV] Teach LSV to handle atomic ops..

obsoleted by D109020

Sep 15 2021, 2:59 PM · Unknown Object (Project)

Sep 7 2021

hliao added a comment to D109159: [amdgpu] Enable selection of `s_cselect_b64`..

Just for the record, see also this comment from D82370:

Additionally, remove pattern for selects with 64-bit
inputs, which are rare, because handling them properly
requires more thought.

This reverted part of D81925, which originally added both 32- and 64-bit patterns.

Sep 7 2021, 8:07 AM · Unknown Object (Project)
hliao committed rG640beb38e771: [amdgpu] Enable selection of `s_cselect_b64`. (authored by hliao).
[amdgpu] Enable selection of `s_cselect_b64`.
Sep 7 2021, 7:45 AM
hliao closed D109159: [amdgpu] Enable selection of `s_cselect_b64`..
Sep 7 2021, 7:45 AM · Unknown Object (Project)

Sep 2 2021

hliao updated the diff for D109159: [amdgpu] Enable selection of `s_cselect_b64`..

Update another test where s_cselect is moved to VALU

Sep 2 2021, 11:59 AM · Unknown Object (Project)
hliao added a comment to D109159: [amdgpu] Enable selection of `s_cselect_b64`..

Can you add a gfx90a test where it ends up needing to be moved to the VALU to make sure that works? I think you can get away with using the unaligned class here as is

Sep 2 2021, 11:44 AM · Unknown Object (Project)
hliao updated the diff for D109159: [amdgpu] Enable selection of `s_cselect_b64`..

Revise select64.ll test

Sep 2 2021, 11:43 AM · Unknown Object (Project)
hliao requested review of D109159: [amdgpu] Enable selection of `s_cselect_b64`..
Sep 2 2021, 7:56 AM · Unknown Object (Project)

Aug 9 2021

hliao committed rG6ec36d18ec7b: [cuda] Mark builtin texture/surface reference variable as… (authored by hliao).
[cuda] Mark builtin texture/surface reference variable as…
Aug 9 2021, 10:28 AM
hliao closed D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'..
Aug 9 2021, 10:27 AM · Restricted Project
hliao added inline comments to D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'..
Aug 9 2021, 9:05 AM · Restricted Project

Aug 8 2021

hliao committed rGb5e470aa2e97: [LowerMemIntrinsics] Typo fix. (authored by hliao).
[LowerMemIntrinsics] Typo fix.
Aug 8 2021, 7:40 PM
hliao requested review of D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'..
Aug 8 2021, 10:14 AM · Restricted Project

Aug 6 2021

hliao committed rG05783e1cfe40: [amdgpu] Revise the conversion from i64 to f32. (authored by hliao).
[amdgpu] Revise the conversion from i64 to f32.
Aug 6 2021, 2:02 PM
hliao closed D107507: [amdgpu] Revise the conversion from i64 to f32..
Aug 6 2021, 2:02 PM · Unknown Object (Project)
hliao committed rGd1cacd592819: [MemCpyOpt] Teach memcpyopt to handle loads from the constant memory. (authored by hliao).
[MemCpyOpt] Teach memcpyopt to handle loads from the constant memory.
Aug 6 2021, 9:44 AM
hliao closed D107605: [MemCpyOpt] Teach memcpyopt to handle loads from the constant memory..
Aug 6 2021, 9:44 AM · Unknown Object (Project)
hliao added inline comments to D107605: [MemCpyOpt] Teach memcpyopt to handle loads from the constant memory..
Aug 6 2021, 7:58 AM · Unknown Object (Project)

Aug 5 2021

hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Rebase

Aug 5 2021, 8:44 PM · Unknown Object (Project)
hliao added inline comments to D107507: [amdgpu] Revise the conversion from i64 to f32..
Aug 5 2021, 8:13 PM · Unknown Object (Project)
hliao updated the diff for D107507: [amdgpu] Revise the conversion from i64 to f32..

Fix the calculation of MaxShAmt.

Aug 5 2021, 8:12 PM · Unknown Object (Project)
hliao added inline comments to D107605: [MemCpyOpt] Teach memcpyopt to handle loads from the constant memory..
Aug 5 2021, 7:34 PM · Restricted Project
hliao updated the diff for D107605: [MemCpyOpt] Teach memcpyopt to handle loads from the constant memory..

Check isModSet instead.

Aug 5 2021, 7:34 PM · Restricted Project
hliao requested review of D107605: [MemCpyOpt] Teach memcpyopt to handle loads from the constant memory..
Aug 5 2021, 2:55 PM · Restricted Project
hliao accepted D107546: [AMDGPU][SDag] Better lowering for 64-bit ctlz/cttz.

LGTM

Aug 5 2021, 7:52 AM · Restricted Project
hliao accepted D107566: [AMDGPU][SDag] Better lowering for 32-bit ctlz/cttz.

LGTM

Aug 5 2021, 7:51 AM · Restricted Project