Page MenuHomePhabricator

hliao (Michael Liao)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 7 2014, 12:01 PM (461 w, 2 d)

Recent Activity

Wed, Jun 7

hliao committed rGdcc8f9490f79: [TableGen] Add !setdagarg and !setdagname (authored by hliao).
[TableGen] Add !setdagarg and !setdagname
Wed, Jun 7, 6:38 AM · Restricted Project, Restricted Project
hliao closed D151842: [TableGen] Add !setdagarg and !setdagname.
Wed, Jun 7, 6:37 AM · Restricted Project, Restricted Project

Tue, Jun 6

hliao updated the diff for D151842: [TableGen] Add !setdagarg and !setdagname.

Revise the statement on !setdagname

Tue, Jun 6, 11:51 AM · Restricted Project, Restricted Project
hliao updated the diff for D151842: [TableGen] Add !setdagarg and !setdagname.

My bad. Add the missing period.

Tue, Jun 6, 11:50 AM · Restricted Project, Restricted Project
hliao updated the diff for D151842: [TableGen] Add !setdagarg and !setdagname.

Revise documentation

Tue, Jun 6, 11:33 AM · Restricted Project, Restricted Project
hliao updated subscribers of D151999: [llvm-tblgen] Fix parser error when using generic used as index.

I don't see this issue from the main branch. In fact, https://reviews.llvm.org/D149016 solves the issue and should not be "fixed". Could you double-check whether the main branch could reproduce this issue?

Tue, Jun 6, 7:41 AM · Restricted Project, Restricted Project

Mon, Jun 5

hliao updated the diff for D151842: [TableGen] Add !setdagarg and !setdagname.

Add a common helper for !getdagarg, !setdagarg, and !setdagname

Mon, Jun 5, 11:57 AM · Restricted Project, Restricted Project
hliao committed rGe7c9481b7094: [TableGen] Fix indentation. NFC (authored by hliao).
[TableGen] Fix indentation. NFC
Mon, Jun 5, 9:22 AM · Restricted Project, Restricted Project

Sun, Jun 4

hliao updated the diff for D151842: [TableGen] Add !setdagarg and !setdagname.

Revise following reviewer's comments. Now, !setdagname also accepts name to lookup arguments

Sun, Jun 4, 10:48 PM · Restricted Project, Restricted Project

Thu, Jun 1

hliao added a comment to D151842: [TableGen] Add !setdagarg and !setdagname.

I wonder if it might make sense to allow !setdagname to take a string name argument, like !setdagarg and !getdagarg do?

Obviously, it makes no sense for !getdagname, because if you're trying to find the name of the argument called "foo", you already know the answer is "foo" (unless there isn't one at all, I suppose). But I can imagine that you might want to rename the "foo" argument to "bar", without first having to find out where it is.

If you abstract out the "look up by index or name" functionality as I suggest, then this wouldn't even be difficult to implement – just add another call to the same function.

Thu, Jun 1, 5:55 PM · Restricted Project, Restricted Project
hliao updated the diff for D151842: [TableGen] Add !setdagarg and !setdagname.

Revise the commit message, which has different markdown syntax from rst.

Thu, Jun 1, 8:52 AM · Restricted Project, Restricted Project
hliao updated the summary of D151842: [TableGen] Add !setdagarg and !setdagname.
Thu, Jun 1, 8:50 AM · Restricted Project, Restricted Project
hliao updated the summary of D151842: [TableGen] Add !setdagarg and !setdagname.
Thu, Jun 1, 8:49 AM · Restricted Project, Restricted Project
hliao updated the summary of D151842: [TableGen] Add !setdagarg and !setdagname.
Thu, Jun 1, 8:49 AM · Restricted Project, Restricted Project
hliao updated the summary of D151842: [TableGen] Add !setdagarg and !setdagname.
Thu, Jun 1, 8:48 AM · Restricted Project, Restricted Project
hliao updated the diff for D151842: [TableGen] Add !setdagarg and !setdagname.

Revise the documentation

Thu, Jun 1, 8:47 AM · Restricted Project, Restricted Project

Wed, May 31

hliao added a comment to D151842: [TableGen] Add !setdagarg and !setdagname.

I don't understand the descriptions of these new operators. I don't think you mean that it replaces the argument value with the key.

Wed, May 31, 5:54 PM · Restricted Project, Restricted Project
hliao requested review of D151842: [TableGen] Add !setdagarg and !setdagname.
Wed, May 31, 2:06 PM · Restricted Project, Restricted Project
hliao abandoned D151457: [TableGen] Add !getdagargs and !getdagnames.

As getdagargs and getdagnames could be implemented upon getdagarg and getdagname, this patch is redundant.

Wed, May 31, 8:36 AM · Restricted Project, Restricted Project
hliao added a comment to D151457: [TableGen] Add !getdagargs and !getdagnames.

Hey @hliao - thank you for this patch. Apparently we had a similar idea D151702 :)

I just have a couple of comments.

Thanks!

Francesco

I proposed another change introducing !getdagarg and !getdagname to access individual arguments instead of a list of them. Personally, I thought that should be more convenient.

Does it mean that you want to abandon this change?

Wed, May 31, 8:35 AM · Restricted Project, Restricted Project
hliao committed rG26d7b7bb8ff9: [TableGen] Add !getdagarg and !getdagname (authored by hliao).
[TableGen] Add !getdagarg and !getdagname
Wed, May 31, 7:55 AM · Restricted Project, Restricted Project
hliao closed D151602: [TableGen] Add !getdagarg and !getdagname.
Wed, May 31, 7:55 AM · Restricted Project, Restricted Project
hliao updated the diff for D151602: [TableGen] Add !getdagarg and !getdagname.

Revise error message following reviewer's comment

Wed, May 31, 7:12 AM · Restricted Project, Restricted Project

Tue, May 30

hliao committed rGa33099f0fef9: [mlir] Add the missing non-member operator decl in the same namesapce. NFC (authored by hliao).
[mlir] Add the missing non-member operator decl in the same namesapce. NFC
Tue, May 30, 10:42 PM · Restricted Project, Restricted Project
hliao added a comment to D151457: [TableGen] Add !getdagargs and !getdagnames.

Hey @hliao - thank you for this patch. Apparently we had a similar idea D151702 :)

I just have a couple of comments.

Thanks!

Francesco

Tue, May 30, 1:27 PM · Restricted Project, Restricted Project
hliao updated the diff for D151602: [TableGen] Add !getdagarg and !getdagname.

Revise the out-of-range error message. Now, the range is from 0 to (numargs-1).

Tue, May 30, 1:22 PM · Restricted Project, Restricted Project
hliao updated the diff for D151602: [TableGen] Add !getdagarg and !getdagname.

More tests

Tue, May 30, 11:04 AM · Restricted Project, Restricted Project
hliao added inline comments to D151602: [TableGen] Add !getdagarg and !getdagname.
Tue, May 30, 9:14 AM · Restricted Project, Restricted Project
hliao added a comment to D151602: [TableGen] Add !getdagarg and !getdagname.

It's not quite clear whether you mean this patch to be an alternative to D151457, or to go together with it. The two changes would clearly conflict, but one of your comments in the other change (https://reviews.llvm.org/D151457#4374848) made it sound as if you meant to do both?

If they're alternatives, then I prefer this one, because I love the extra feature of looking up a dag argument by its name instead of its index. I can see that being really useful.

Tue, May 30, 9:11 AM · Restricted Project, Restricted Project

Mon, May 29

hliao updated the diff for D151457: [TableGen] Add !getdagargs and !getdagnames.

Rebase and ping for review. The alternative approach is posted @ https://reviews.llvm.org/D151602

Mon, May 29, 10:27 AM · Restricted Project, Restricted Project
hliao updated the diff for D151602: [TableGen] Add !getdagarg and !getdagname.

Rebase and ping for review

Mon, May 29, 8:01 AM · Restricted Project, Restricted Project

Fri, May 26

hliao updated the diff for D151457: [TableGen] Add !getdagargs and !getdagnames.

Fix clang-format issue

Fri, May 26, 6:26 PM · Restricted Project, Restricted Project
hliao added a comment to D151457: [TableGen] Add !getdagargs and !getdagnames.

The alternative approach is uploaded @ https://reviews.llvm.org/D151602

Fri, May 26, 6:25 PM · Restricted Project, Restricted Project
hliao requested review of D151602: [TableGen] Add !getdagarg and !getdagname.
Fri, May 26, 6:24 PM · Restricted Project, Restricted Project
hliao updated the diff for D151457: [TableGen] Add !getdagargs and !getdagnames.

Allow convertible types and update tests

Fri, May 26, 2:23 PM · Restricted Project, Restricted Project
hliao updated the diff for D151457: [TableGen] Add !getdagargs and !getdagnames.

Rebase

Fri, May 26, 10:33 AM · Restricted Project, Restricted Project

Thu, May 25

hliao updated the diff for D151457: [TableGen] Add !getdagargs and !getdagnames.

Now return ? if an argument has unmatching type. Tests are updated.

Thu, May 25, 8:04 PM · Restricted Project, Restricted Project
hliao added inline comments to D151457: [TableGen] Add !getdagargs and !getdagnames.
Thu, May 25, 6:52 PM · Restricted Project, Restricted Project
hliao requested review of D151457: [TableGen] Add !getdagargs and !getdagnames.
Thu, May 25, 8:40 AM · Restricted Project, Restricted Project

Wed, May 24

hliao committed rG2daf91dae3bc: Fix shared library build again from 1c9a800. NFC (authored by hliao).
Fix shared library build again from 1c9a800. NFC
Wed, May 24, 11:10 AM · Restricted Project, Restricted Project

May 6 2023

hliao committed rG7a23e6b38023: [GlobalISel] Fix typo. NFC (authored by hliao).
[GlobalISel] Fix typo. NFC
May 6 2023, 7:08 AM · Restricted Project, Restricted Project

May 4 2023

hliao committed rG058f04ea7dcb: [clang] Fix another case where CPlusPlus2b is still used. (authored by hliao).
[clang] Fix another case where CPlusPlus2b is still used.
May 4 2023, 11:28 AM · Restricted Project, Restricted Project
hliao committed rGb323b407f76d: [clang] Fix build after https://reviews.llvm.org/D149553 (authored by hliao).
[clang] Fix build after https://reviews.llvm.org/D149553
May 4 2023, 11:26 AM · Restricted Project, Restricted Project

Apr 11 2023

hliao committed rG72fc08a5412e: [InstCombine] Teach alloca replacement to handle `addrspacecast` (authored by hliao).
[InstCombine] Teach alloca replacement to handle `addrspacecast`
Apr 11 2023, 8:55 AM · Restricted Project, Restricted Project
hliao closed D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.
Apr 11 2023, 8:55 AM · Restricted Project, Restricted Project

Apr 10 2023

hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Rebase and kindly PING for review

Apr 10 2023, 11:37 AM · Restricted Project, Restricted Project

Apr 9 2023

hliao committed rG3c83480ae95d: [clang][AST] Fix `-Wuninitialized`. NFC (authored by hliao).
[clang][AST] Fix `-Wuninitialized`. NFC
Apr 9 2023, 12:59 PM · Restricted Project, Restricted Project

Apr 6 2023

hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Rebase and kindly PING for review

Apr 6 2023, 10:24 AM · Restricted Project, Restricted Project

Apr 5 2023

hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Revise following comments from reviewers

Apr 5 2023, 7:40 PM · Restricted Project, Restricted Project
hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Rebase and kindly PING for review

Apr 5 2023, 8:29 AM · Restricted Project, Restricted Project

Apr 4 2023

hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Rebase and kindly PING review. Please let me know any pending issue to be addressed.

Apr 4 2023, 7:50 AM · Restricted Project, Restricted Project

Apr 3 2023

hliao added inline comments to D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.
Apr 3 2023, 10:57 AM · Restricted Project, Restricted Project
hliao added inline comments to D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.
Apr 3 2023, 8:52 AM · Restricted Project, Restricted Project
hliao added inline comments to D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.
Apr 3 2023, 8:37 AM · Restricted Project, Restricted Project
hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.
  • Update TTI hook isValidAddrSpaceCast to be consistent with LLVM IR verifier
  • Check the equal case in instcombine
  • Add other valid cases in AMDGPU
Apr 3 2023, 8:32 AM · Restricted Project, Restricted Project

Apr 2 2023

hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Rebase and kindly PING for review

Apr 2 2023, 7:19 AM · Restricted Project, Restricted Project

Apr 1 2023

hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Rebase and kindling PING for review

Apr 1 2023, 7:18 AM · Restricted Project, Restricted Project

Mar 31 2023

hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Fix clang-format

Mar 31 2023, 10:18 AM · Restricted Project, Restricted Project
hliao added a comment to D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Kindly PING for review

Mar 31 2023, 9:29 AM · Restricted Project, Restricted Project

Mar 30 2023

hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Add the target-specific usage

Mar 30 2023, 12:34 PM · Restricted Project, Restricted Project
hliao added a comment to D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

As far as I can tell, your motivating test cases do not require the TTI hook. They only need trivial address space casts (to the same address space).

Using TTI inside InstCombine is forbidden as a matter of policy. You would need to make an argument for why this exception should be allowed (it would probably go along the lines of "this should really be part of data layout"), so I would recommend to only handle this trivial case first and bypass the TTI issue.

Mar 30 2023, 11:19 AM · Restricted Project, Restricted Project

Mar 29 2023

hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Revise following reviewer's comment

Mar 29 2023, 5:50 PM · Restricted Project, Restricted Project
hliao added a comment to D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Ping for review

Mar 29 2023, 9:36 AM · Restricted Project, Restricted Project

Mar 28 2023

hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Fix typos

Mar 28 2023, 9:18 AM · Restricted Project, Restricted Project
hliao added a comment to D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

a new keep test is added.

Mar 28 2023, 8:19 AM · Restricted Project, Restricted Project
hliao updated the diff for D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.

Add one more keep test

Mar 28 2023, 8:19 AM · Restricted Project, Restricted Project

Mar 27 2023

hliao requested review of D147025: [InstCombine] Teach alloca replacement to handle `addrspacecast`.
Mar 27 2023, 9:25 PM · Restricted Project, Restricted Project

Feb 23 2023

hliao committed rGfe6ca5468253: [LangRef] Correct value ranges for address space, vector, and float bit sizes. (authored by hliao).
[LangRef] Correct value ranges for address space, vector, and float bit sizes.
Feb 23 2023, 6:55 PM · Restricted Project, Restricted Project
hliao closed D144685: [LangRef] Correct value ranges for address space, vector, and float bit sizes..
Feb 23 2023, 6:54 PM · Restricted Project, Restricted Project
hliao requested review of D144685: [LangRef] Correct value ranges for address space, vector, and float bit sizes..
Feb 23 2023, 4:35 PM · Restricted Project, Restricted Project

Feb 22 2023

hliao committed rGe80d2cad3491: [TableGen] Emit static const globals in getOperandType (authored by hliao).
[TableGen] Emit static const globals in getOperandType
Feb 22 2023, 12:57 AM · Restricted Project, Restricted Project

Jan 25 2023

hliao committed rGcd61d2abe0fd: [clang][CodeGen][NFC] Fix `llvm-else-after-return` (authored by hliao).
[clang][CodeGen][NFC] Fix `llvm-else-after-return`
Jan 25 2023, 10:54 AM · Restricted Project, Restricted Project

Jan 3 2023

Herald added a project to D67258: Out-of-tree machine IR passes: Restricted Project.
Jan 3 2023, 4:41 PM · Restricted Project, Restricted Project

Oct 23 2022

hliao committed rG81ad624b1a11: [llvm-debuginfo-analyzer] Fix shared build. NFC. (authored by hliao).
[llvm-debuginfo-analyzer] Fix shared build. NFC.
Oct 23 2022, 10:33 PM · Restricted Project, Restricted Project

Aug 26 2022

hliao committed rGe84784e4ae80: [CSKY] Fix warnings on the use of deprecated methods. NFC. (authored by hliao).
[CSKY] Fix warnings on the use of deprecated methods. NFC.
Aug 26 2022, 7:28 AM · Restricted Project, Restricted Project

Aug 24 2022

hliao committed rGdda38786534a: [LoongArch] Fix build due to TLI interface changes. NFC. (authored by hliao).
[LoongArch] Fix build due to TLI interface changes. NFC.
Aug 24 2022, 12:18 PM · Restricted Project, Restricted Project

Aug 23 2022

hliao committed rG796124f00468: [SPIRV] Fix the wrong patch from https://reviews.llvm.org/D131886 (authored by hliao).
[SPIRV] Fix the wrong patch from https://reviews.llvm.org/D131886
Aug 23 2022, 8:27 AM · Restricted Project, Restricted Project

Apr 21 2022

hliao committed rG036aeac36c00: [Testing] Fix the shared build. NFC. (authored by hliao).
[Testing] Fix the shared build. NFC.
Apr 21 2022, 11:47 PM · Restricted Project, Restricted Project

Apr 14 2022

hliao committed rGf9486f213975: [LoongArch] Fix shared build. NFC. (authored by hliao).
[LoongArch] Fix shared build. NFC.
Apr 14 2022, 9:22 PM · Restricted Project, Restricted Project

Mar 30 2022

hliao committed rG73ab5fd17b57: [clang] Fix shared build. NFC. (authored by hliao).
[clang] Fix shared build. NFC.
Mar 30 2022, 11:05 AM · Restricted Project, Restricted Project

Jan 4 2022

hliao committed rG56ec762a76cb: [regalloc] Fix GCC warning `-Wattributes`. NFC. (authored by hliao).
[regalloc] Fix GCC warning `-Wattributes`. NFC.
Jan 4 2022, 9:06 AM

Jan 3 2022

hliao committed rG7505aeefc4e6: [clang] Pacify GCC warning. NFC. (authored by hliao).
[clang] Pacify GCC warning. NFC.
Jan 3 2022, 8:07 AM
hliao added a reverting change for rGd677a7cb056b: [clang] Remove redundant member initialization (NFC): rG7505aeefc4e6: [clang] Pacify GCC warning. NFC..
Jan 3 2022, 8:07 AM

Dec 26 2021

hliao updated the diff for D115976: [clang] Fix a crash case when reporting an uninitialized field..

Rebase

Dec 26 2021, 9:13 AM · Restricted Project

Dec 17 2021

hliao updated the diff for D115976: [clang] Fix a crash case when reporting an uninitialized field..

Revise the formatting.

Dec 17 2021, 6:11 PM · Restricted Project
hliao requested review of D115976: [clang] Fix a crash case when reporting an uninitialized field..
Dec 17 2021, 3:06 PM · Restricted Project

Dec 10 2021

hliao committed rG17414b61245d: Fix shared build of unittests. (authored by hliao).
Fix shared build of unittests.
Dec 10 2021, 12:34 PM

Dec 5 2021

hliao committed rGb6ccca217c35: Fix `-Wunused-variable` warning. NFC. (authored by hliao).
Fix `-Wunused-variable` warning. NFC.
Dec 5 2021, 10:44 AM

Dec 4 2021

hliao committed rG53fc971a4b79: Fix `-Wunused-variable` warning. NFC. (authored by hliao).
Fix `-Wunused-variable` warning. NFC.
Dec 4 2021, 8:42 PM

Nov 17 2021

hliao committed rGb861c3600c4a: Fix -Wparentheses warnings. NFC. (authored by hliao).
Fix -Wparentheses warnings. NFC.
Nov 17 2021, 12:32 PM

Nov 11 2021

hliao abandoned D87858: [hip] Add HIP scope atomic ops..
Nov 11 2021, 1:22 PM · Restricted Project
hliao added a comment to D87858: [hip] Add HIP scope atomic ops..

Hi Michael, would you like to continue working on this, or let someone from AMD to take over? Thanks.

Nov 11 2021, 1:22 PM · Restricted Project

Nov 8 2021

hliao committed rGbf225939bc3a: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates. (authored by hliao).
[InferAddressSpaces] Support assumed addrspaces from addrspace predicates.
Nov 8 2021, 1:52 PM
hliao closed D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..
Nov 8 2021, 1:52 PM · Restricted Project, Restricted Project
hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Rebase and kindly PING for review.

Nov 8 2021, 6:52 AM · Restricted Project, Restricted Project

Nov 7 2021

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Rebase and ping for further review.

Nov 7 2021, 4:43 PM · Restricted Project, Restricted Project

Nov 5 2021

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Rebase to the main branch.

Nov 5 2021, 8:22 AM · Restricted Project, Restricted Project
hliao committed rGaf2ae2cf42a0: [BranchRelaxation] Fix warning on unused variable. NFC. (authored by hliao).
[BranchRelaxation] Fix warning on unused variable. NFC.
Nov 5 2021, 8:18 AM

Nov 4 2021

hliao added inline comments to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..
Nov 4 2021, 7:49 AM · Restricted Project, Restricted Project
hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Rebase and kindly ping for review.

Nov 4 2021, 7:48 AM · Restricted Project, Restricted Project