In D112041#3106936, @nikic wrote:

I'd still like an answer to:

In D112041#3073464, @nikic wrote:

Is it actually necessary to thread this through AssumptionCache, given how InferAddressSpaces is the only place that looks at these assumes?

I'd prefer not to infect AC with TTI if not necessary.

Nov 3 2021, 11:40 AM · Unknown Object (Project), Restricted Project

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Updated.

Nov 3 2021, 11:29 AM · Unknown Object (Project), Restricted Project

hliao added a comment to D112466: [NVPTX] Drop memory references of LDG/LDU.

In D112466#3106496, @asavonic wrote:

In D112466#3106139, @hliao wrote:

These machine instruction should be marked with mayLoad as they are really load instructions. Check the attached patch fixing the machine verifier.

0001-nvptx-Mark-LDG-LDU-mayLoad.patch7 KBDownload

This is where we started from in this review request (see the revision 382033).
I think the consensus is that LDU is not a load, because it operates on read-only memory (and therefore can be safely excluded from memory-related analysis).
I'm not sure about LDG though.

Nov 3 2021, 11:27 AM · Restricted Project, Unknown Object (Project)

hliao added a comment to D112466: [NVPTX] Drop memory references of LDG/LDU.

These machine instruction should be marked with mayLoad as they are really load instructions. Check the attached patch fixing the machine verifier.

0001-nvptx-Mark-LDG-LDU-mayLoad.patch7 KBDownload

Nov 3 2021, 8:12 AM · Restricted Project, Unknown Object (Project)

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Move the updating action into updateAddrSpace and return a boolean true if it's really updated.

Nov 3 2021, 7:46 AM · Unknown Object (Project), Restricted Project

hliao added a comment to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Sorry for the late reply.

Nov 3 2021, 7:33 AM · Unknown Object (Project), Restricted Project

Oct 27 2021

hliao committed rGe6a4ba3aa603: [amdgpu] Handle the case where there is no scavenged register. (authored by hliao).

[amdgpu] Handle the case where there is no scavenged register.

Oct 27 2021, 3:38 PM

hliao closed D106449: [amdgpu] Handle the case where there is no scavenged register..

Oct 27 2021, 3:37 PM · Unknown Object (Project)

hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Update non-kernel test case

Oct 27 2021, 3:08 PM · Unknown Object (Project)

hliao added inline comments to D106449: [amdgpu] Handle the case where there is no scavenged register..

Oct 27 2021, 12:56 PM · Unknown Object (Project)

hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Add a non-kernel function case.

Oct 27 2021, 12:51 PM · Unknown Object (Project)

hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Revise following reviewers' comment.

Oct 27 2021, 12:38 PM · Unknown Object (Project)

hliao committed rG6c9f207826ef: [cmake] Surpress cmake warning on that EH requires RTTI. NFC. (authored by hliao).

[cmake] Surpress cmake warning on that EH requires RTTI. NFC.

Oct 27 2021, 9:56 AM

Oct 25 2021

hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Rebase and kingly PING for review.

Oct 25 2021, 8:29 AM · Unknown Object (Project)

hliao added a comment to D106449: [amdgpu] Handle the case where there is no scavenged register..

Kingly PING for review

Oct 25 2021, 8:22 AM · Unknown Object (Project)

Oct 19 2021

hliao added a comment to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

In D112041#3073676, @rampitec wrote:

In D112041#3073637, @hliao wrote:

In D112041#3073560, @rampitec wrote:

Is there anything to remove assume() call after address space is inferred? We do not need it anymore.

along with a few other intrinsics, assume intrinsic is discarded in SDAG and GISel.

We may want to discard these earlier for the sake of Value::hasOneUse(). These are really not needed after casts are inserted.

Oct 19 2021, 10:43 PM · Unknown Object (Project), Restricted Project

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Revise commit message.

Oct 19 2021, 4:00 PM · Unknown Object (Project), Restricted Project

hliao added inline comments to D112053: [cuda] Add address space predicate funuctions..

Oct 19 2021, 3:30 PM · Restricted Project

hliao added inline comments to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Oct 19 2021, 3:26 PM · Unknown Object (Project), Restricted Project

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Revise following reviewers' feedback.

Oct 19 2021, 3:21 PM · Unknown Object (Project), Restricted Project

hliao added a comment to D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

In D112041#3073560, @rampitec wrote:

Is there anything to remove assume() call after address space is inferred? We do not need it anymore.

Oct 19 2021, 1:32 PM · Unknown Object (Project), Restricted Project

hliao added inline comments to D112053: [cuda] Add address space predicate funuctions..

Oct 19 2021, 1:23 PM · Restricted Project

hliao added inline comments to D112053: [cuda] Add address space predicate funuctions..

Oct 19 2021, 1:22 PM · Restricted Project

hliao committed rG6fe902daf931: [cuda] Add address space predicate funuctions. (authored by hliao).

[cuda] Add address space predicate funuctions.

Oct 19 2021, 1:20 PM

hliao closed D112053: [cuda] Add address space predicate funuctions..

Oct 19 2021, 1:20 PM · Restricted Project

hliao added a watcher for debug-info: hliao.

Oct 19 2021, 8:31 AM

Oct 18 2021

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Fix formatting again following clang-format.

Oct 18 2021, 9:33 PM · Unknown Object (Project), Restricted Project

hliao added a comment to D112053: [cuda] Add address space predicate funuctions..

With this patch, the following code could be compiled into the same PTX as NVCC. Check https://godbolt.org/z/q6EYE1q1o for the difference between NVCC and the current Clang output.

Oct 18 2021, 9:24 PM · Restricted Project

hliao requested review of D112053: [cuda] Add address space predicate funuctions..

Oct 18 2021, 9:17 PM · Restricted Project

hliao updated the diff for D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Fix formatting.

Oct 18 2021, 8:27 PM · Unknown Object (Project), Restricted Project

hliao updated the summary of D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Oct 18 2021, 5:45 PM · Unknown Object (Project), Restricted Project

hliao requested review of D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates..

Oct 18 2021, 5:39 PM · Unknown Object (Project), Restricted Project

Oct 15 2021

hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Rebase and kindly PING for review.

Oct 15 2021, 10:36 AM · Unknown Object (Project)

hliao committed rGbacddf47a838: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow (authored by hliao).

[amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow

Oct 15 2021, 10:23 AM

hliao closed D111831: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow.

Oct 15 2021, 10:22 AM · Unknown Object (Project)

hliao abandoned D111834: Clean up test case..

Oct 15 2021, 6:04 AM · Unknown Object (Project)

Oct 14 2021

hliao updated the diff for D111831: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow.

Remove '!llvm.ident' in that test triggering crash.

Oct 14 2021, 1:28 PM · Unknown Object (Project)

hliao requested review of D111834: Clean up test case..

Oct 14 2021, 1:28 PM · Unknown Object (Project)

hliao updated the diff for D111831: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow.

Revise the comment.

Oct 14 2021, 1:22 PM · Unknown Object (Project)

hliao updated the diff for D111831: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow.

Fix typo.

Oct 14 2021, 1:21 PM · Unknown Object (Project)

hliao requested review of D111831: [amdgpu] Fix a crash case when preserving MDT in SILowerControlFlow.

Oct 14 2021, 1:15 PM · Unknown Object (Project)

Oct 12 2021

hliao accepted D111464: [AMDGPU] Promote generic pointer kernel arguments into global.

LGTM

Oct 12 2021, 5:55 AM · Unknown Object (Project)

Sep 29 2021

hliao added inline comments to D106449: [amdgpu] Handle the case where there is no scavenged register..

Sep 29 2021, 7:31 PM · Unknown Object (Project)

hliao updated the diff for D106449: [amdgpu] Handle the case where there is no scavenged register..

Fix typos and remove dead code.

Sep 29 2021, 7:23 PM · Unknown Object (Project)

Sep 21 2021

hliao accepted D110089: [CUDA] Implement experimental support for texture lookups..

Cool! I like the idea of *compile-time* dispatch. LGTM except minor warnings from clang-tidy. Could you fix them before committing this change?

Sep 21 2021, 1:16 PM · Restricted Project

hliao committed rG2d1ffad01074: [IR] Re-group AAMDNodes relevant interfaces. NFC. (authored by hliao).

[IR] Re-group AAMDNodes relevant interfaces. NFC.

Sep 21 2021, 11:31 AM

hliao committed rG5fb3ae525ffa: [SelectionDAG] Re-calculate scoped AA metadata when merging stores. (authored by hliao).

[SelectionDAG] Re-calculate scoped AA metadata when merging stores.

Sep 21 2021, 8:50 AM

hliao closed D102821: [SelectionDAG] Re-calculate scoped AA metadata when merging stores..

Sep 21 2021, 8:50 AM · Unknown Object (Project)

Sep 20 2021

hliao updated the diff for D102821: [SelectionDAG] Re-calculate scoped AA metadata when merging stores..

Add concat to replace merge, which overlapping locations are expected.

Sep 20 2021, 12:43 PM · Unknown Object (Project)

hliao updated the diff for D102821: [SelectionDAG] Re-calculate scoped AA metadata when merging stores..

Rebase after metadata interfaces are already revised in D109852

Sep 20 2021, 11:57 AM · Unknown Object (Project)

Sep 16 2021

hliao committed rGffa5c3a555a8: Fix warning on `llvm-else-after-return`. NFC. (authored by hliao).

Fix warning on `llvm-else-after-return`. NFC.

Sep 16 2021, 8:26 AM

Sep 15 2021

hliao abandoned D104863: [LSV] Teach LSV to handle atomic ops..

obsoleted by D109020

Sep 15 2021, 2:59 PM · Unknown Object (Project)

Sep 7 2021

hliao added a comment to D109159: [amdgpu] Enable selection of `s_cselect_b64`..

In D109159#2986862, @foad wrote:

Just for the record, see also this comment from D82370:

Additionally, remove pattern for selects with 64-bit
inputs, which are rare, because handling them properly
requires more thought.

This reverted part of D81925, which originally added both 32- and 64-bit patterns.

Sep 7 2021, 8:07 AM · Unknown Object (Project)

hliao committed rG640beb38e771: [amdgpu] Enable selection of `s_cselect_b64`. (authored by hliao).

[amdgpu] Enable selection of `s_cselect_b64`.

Sep 7 2021, 7:45 AM

hliao closed D109159: [amdgpu] Enable selection of `s_cselect_b64`..

Sep 7 2021, 7:45 AM · Unknown Object (Project)

Sep 2 2021

hliao updated the diff for D109159: [amdgpu] Enable selection of `s_cselect_b64`..

Update another test where s_cselect is moved to VALU

Sep 2 2021, 11:59 AM · Unknown Object (Project)

hliao added a comment to D109159: [amdgpu] Enable selection of `s_cselect_b64`..

In D109159#2980148, @arsenm wrote:

Can you add a gfx90a test where it ends up needing to be moved to the VALU to make sure that works? I think you can get away with using the unaligned class here as is

Sep 2 2021, 11:44 AM · Unknown Object (Project)

hliao updated the diff for D109159: [amdgpu] Enable selection of `s_cselect_b64`..

Revise select64.ll test

Sep 2 2021, 11:43 AM · Unknown Object (Project)

hliao requested review of D109159: [amdgpu] Enable selection of `s_cselect_b64`..

Sep 2 2021, 7:56 AM · Unknown Object (Project)