This is an archive of the discontinued LLVM Phabricator instance.

Differential D74031

Update for Clang 10 release notes in order to have reference to D66404.
ClosedPublic

Authored by Abpostelnicu on Feb 5 2020, 2:22 AM.

Details

Reviewers
hans
Commits
rGb4efc29f1ccb: Update for Clang 10 release notes in order to have reference to D66404.
Summary

Since D66404 adds some significant modifications to the CFG we should include it in the release notes.

Diff Detail

Event Timeline

Abpostelnicu created this revision.Feb 5 2020, 2:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2020, 2:22 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Abpostelnicu edited the summary of this revision. (Show Details)Feb 5 2020, 2:24 AM
Abpostelnicu edited the summary of this revision. (Show Details)
Abpostelnicu added a subscriber: sylvestre.ledru.
Harbormaster completed remote builds in B45752: Diff 242537.Feb 5 2020, 2:30 AM
hans added a comment.Feb 5 2020, 4:48 AM

lgtm, but if you want it wouldn't hurt to include even more details from the commit message.

Abpostelnicu updated this revision to Diff 242562.Feb 5 2020, 5:06 AM

Adding extra comments to the release patch.

Abpostelnicu added a comment.Feb 5 2020, 5:07 AM
In D74031#1859084, @hans wrote:

lgtm, but if you want it wouldn't hurt to include even more details from the commit message.

This is a good idea, in my latest patch you will see that I've added more context present in D66404.

Harbormaster completed remote builds in B45757: Diff 242562.Feb 5 2020, 5:07 AM
hans accepted this revision.Feb 5 2020, 5:56 AM

Looks great, thanks!

Do you have commit access? If so, go ahead and push directly to the 10.x branch, otherwise let me know and I'll do it for you.

This revision is now accepted and ready to land.Feb 5 2020, 5:56 AM
Abpostelnicu added a comment.Feb 5 2020, 6:01 AM
In D74031#1859231, @hans wrote:

Looks great, thanks!

Do you have commit access? If so, go ahead and push directly to the 10.x branch, otherwise let me know and I'll do it for you.

Yes I have commit access, pushing it directly to 10.x then.

Abpostelnicu added a comment.Feb 5 2020, 6:10 AM

done

DavidSpickett closed this revision.Sep 21 2023, 1:35 AM
DavidSpickett added a subscriber: DavidSpickett.

Was landed on 10.x as https://github.com/llvm/llvm-project/commit/b4efc29f1ccbc03453590bf7aae337853c91c91f.

Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2023, 1:35 AM

Revision Contents

PathSize
clang/
docs/
3 lines

Diff 242537

clang/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines
- Option ``InsertTrailingCommas`` can be set to ``TCS_Wrapped`` to insert - Option ``InsertTrailingCommas`` can be set to ``TCS_Wrapped`` to insert
trailing commas in container literals (arrays and objects) that wrap across trailing commas in container literals (arrays and objects) that wrap across
multiple lines. It is currently only available for JavaScript and disabled by multiple lines. It is currently only available for JavaScript and disabled by
default (``TCS_None``). default (``TCS_None``).
libclang libclang
-------- --------
- ... - Various changes to reduce discrepancies in destructor calls between the
generated ``CFG`` and the actual ``codegen``.
Static Analyzer Static Analyzer
--------------- ---------------
- ... - ...
.. _release-notes-ubsan: .. _release-notes-ubsan:
Show All 37 Lines