- User Since
- Jul 27 2016, 4:23 AM (216 w, 2 d)
Tue, Sep 15
Has been pushed to the 11.x branch https://github.com/llvm/llvm-project/commit/1596c2dfd548b21cf33ad3353882ac465d78c1bb
Jul 2 2020
@njames93 wdyt if we add another parameter to distinguish if we want to use regex or not, and if not we escape the paths?
Also thank you so much for catching this up!
Jun 29 2020
Jun 16 2020
May 19 2020
Let's first see we don't break anything on mozilla.
May 15 2020
@MyDeveloperDay thanks for the patch, I'm gonna run it agains mozilla to see if there is any fallout.
May 12 2020
Sorry, totally forgot about this, thank you!
May 3 2020
As per what @sammccall said.
Apr 28 2020
Just to clarify something here, for me the patch looks good but until I will accept the revision I want to test it on the mozilla codebase.
Apr 27 2020
I've cherry-picked D76850 to 10.x and see if this fixes the issue.
I think we are on the right track with this but what if we are dealing with tok::amp in a context similar to operator const FallibleTArray<E>&(); I can speculate that the outcome will be operator const FallibleTArray<E> &(); which is wrong.
Apr 11 2020
Add release notes.
Apr 10 2020
Feb 24 2020
Feb 5 2020
Yes I have commit access, pushing it directly to 10.x then.
Adding extra comments to the release patch.
Jan 9 2020
Jan 8 2020
Will push shortly an update.
I think the best approach here is to remove the tests that don’t have template instantiation.
Added more tesst for templa functions that are not instantiated.
Jan 7 2020
Updated test with match without compound statement.
Updated the test case to better reflect the changes.
Sep 5 2019
I think the auto usage improves and simplifies the code, however, as I would really like to see this code landed, I would be ok to help Stephen to finish this work and replace auto by the "old" way. Do you think we can have this approved if we make the changes mentioned earlier?
Sep 3 2019
Apr 9 2019
Jan 16 2019
Sep 19 2018
Aug 24 2018
I can confirm tested on:
Aug 16 2018
Strangely I haven't had those kind of issues but since you propose those modifications I would do one more modification, let's output everything to stdout and not stderr by doing:
Aug 10 2018
Aug 7 2018
Did you notice any significant speed degradation?
Regarding the time penalty it depends very much on how many files you have. But I would choose anytime to have this in the detriment of having "obfuscated" output.
Jul 26 2018
Jan 3 2018
Nov 3 2017
I can test this on our repo, Mozilla, since it's a large code-base I think we will have a better understanding of the false-positive ratio.
Sep 25 2017
Sep 18 2017
Mar 10 2017
Fixed two spell errors.