Page MenuHomePhabricator

Abpostelnicu (Andi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 27 2016, 4:23 AM (216 w, 2 d)

Recent Activity

Tue, Sep 15

Abpostelnicu added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

Has been pushed to the 11.x branch https://github.com/llvm/llvm-project/commit/1596c2dfd548b21cf33ad3353882ac465d78c1bb

Tue, Sep 15, 9:28 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=47512

Can you take a look?

Tue, Sep 15, 8:29 AM · Restricted Project, Restricted Project

Jul 2 2020

Abpostelnicu added a comment to D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis..

@njames93 wdyt if we add another parameter to distinguish if we want to use regex or not, and if not we escape the paths?
Also thank you so much for catching this up!

As the argument is documented as being a regex string, we shouldn't really try to escape it, and users should be expected escape any file names themselves before invoking the script.
If for whatever reason you want to use .c++ as your file extension. then you should pass r'*\.c\+\+' to the script.

Can I ask what the specific use case you have that is causing the issue? Are you invoking run-clang-tidy from a script that generates the list of files to search for?

Jul 2 2020, 5:20 AM · Restricted Project, Restricted Project
Abpostelnicu abandoned D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis..
Jul 2 2020, 5:20 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis..

@njames93 wdyt if we add another parameter to distinguish if we want to use regex or not, and if not we escape the paths?
Also thank you so much for catching this up!

Jul 2 2020, 2:38 AM · Restricted Project, Restricted Project

Jun 29 2020

Abpostelnicu updated the summary of D82784: [clang-tidy] For `run-clang-tidy.py` do not treat `allow_enabling_alpha_checkers` as a none value..
Jun 29 2020, 9:42 AM · Restricted Project
Abpostelnicu created D82784: [clang-tidy] For `run-clang-tidy.py` do not treat `allow_enabling_alpha_checkers` as a none value..
Jun 29 2020, 9:42 AM · Restricted Project

Jun 16 2020

Abpostelnicu reopened D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis..
Jun 16 2020, 3:17 AM · Restricted Project, Restricted Project
Abpostelnicu edited reviewers for D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis., added: JonasToth; removed: sylvestre.ledru.
Jun 16 2020, 2:43 AM · Restricted Project, Restricted Project
Abpostelnicu created D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis..
Jun 16 2020, 2:43 AM · Restricted Project, Restricted Project

May 19 2020

Abpostelnicu accepted D80008: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators.
May 19 2020, 8:41 AM · Restricted Project, Restricted Project
Abpostelnicu accepted D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon.
May 19 2020, 8:41 AM · Restricted Project, Restricted Project
Abpostelnicu accepted D75791: [clang-format] Added new option IndentExternBlock.
May 19 2020, 8:41 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Let's first see we don't break anything on mozilla.

May 19 2020, 8:10 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu added a reviewer for D75791: [clang-format] Added new option IndentExternBlock: Abpostelnicu.
May 19 2020, 8:08 AM · Restricted Project, Restricted Project, Restricted Project

May 15 2020

Abpostelnicu added a comment to D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon.

Please see https://firefox-source-docs.mozilla.org/code-quality/coding-style/format_cpp_code_with_clang-format.html

May 15 2020, 7:34 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon.

@MyDeveloperDay thanks for the patch, I'm gonna run it agains mozilla to see if there is any fallout.

May 15 2020, 3:46 AM · Restricted Project, Restricted Project

May 12 2020

Abpostelnicu accepted D79201: [clang-format] : Fix additional pointer alignment for overloaded operators.

Sorry, totally forgot about this, thank you!

May 12 2020, 1:02 AM · Restricted Project, Restricted Project

May 3 2020

Abpostelnicu requested changes to D79201: [clang-format] : Fix additional pointer alignment for overloaded operators.

As per what @sammccall said.

May 3 2020, 11:19 PM · Restricted Project, Restricted Project

Apr 28 2020

Abpostelnicu accepted D78879: [clang-format] [PR45357] Fix issue found with operator spacing.
Apr 28 2020, 2:39 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.

Just to clarify something here, for me the patch looks good but until I will accept the revision I want to test it on the mozilla codebase.

Apr 28 2020, 2:39 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.

@sylvestre.ledru , @Abpostelnicu

I believe to fix your original request you need a combination of D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107) and this fix (this fix will handle the * * issue in gecko-dev/ipc/mscom/Ptr.h

I've run this new binary over gecko-dev/ipc/mscom and gecko-dev/xpcom/ds and it shows no clang-format warnings

I hope this helps

Apr 28 2020, 2:07 AM · Restricted Project, Restricted Project

Apr 27 2020

Abpostelnicu accepted D78909: [clang-format] NFC clang-format the clang-format sources.
Apr 27 2020, 4:47 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.

I've cherry-picked D76850 to 10.x and see if this fixes the issue.

Apr 27 2020, 2:38 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.

@sylvestre.ledru

I'm taking a quick look at formatting the original bug in gecko and whilst the last windows snapshot (Feb 2020) shows the bug

$ clang-format --version
clang-format version 11.0.0

nsTArray.h:939:29: warning: code should be clang-formatted [-Wclang-format-violations]
  operator const nsTArray<E>&() {
                            ^
nsTArray.h:946:35: warning: code should be clang-formatted [-Wclang-format-violations]
  operator const FallibleTArray<E>&() {
                                  ^
nsTArray.h:1147:59: warning: code should be clang-formatted [-Wclang-format-violations]
  [[nodiscard]] operator const nsTArray_Impl<E, Allocator>&() const& {
                                                          ^
nsTArray.h:1151:43: warning: code should be clang-formatted [-Wclang-format-violations]
  [[nodiscard]] operator const nsTArray<E>&() const& {
                                          ^
nsTArray.h:1154:49: warning: code should be clang-formatted [-Wclang-format-violations]
  [[nodiscard]] operator const FallibleTArray<E>&() const& {

The current trunk does not

$ clang-format --version
clang-format version 11.0.0 (https://github.com/llvm/llvm-project 1956a8a7cb79e94dbe073e36eba2d6b003f91046)

clang-format -n nsTArray.h

Is Mozilla toolchain using LLVM from the v10 branch?

I think this is fixed by D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107)

Apr 27 2020, 2:38 AM · Restricted Project, Restricted Project
Abpostelnicu requested changes to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.
Apr 27 2020, 1:33 AM · Restricted Project, Restricted Project
Abpostelnicu added a reviewer for D78879: [clang-format] [PR45357] Fix issue found with operator spacing: Abpostelnicu.
Apr 27 2020, 1:33 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.

I think we are on the right track with this but what if we are dealing with tok::amp in a context similar to operator const FallibleTArray<E>&(); I can speculate that the outcome will be operator const FallibleTArray<E> &(); which is wrong.

Apr 27 2020, 12:29 AM · Restricted Project, Restricted Project

Apr 11 2020

Abpostelnicu added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

please add this to the release notes too :)
something like "new option -allow-enabling-alpha-checkers added to run-clang-tidy to enable alpha checkers"

Apr 11 2020, 10:56 PM · Restricted Project, Restricted Project
Abpostelnicu updated the diff for D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

Add release notes.

Apr 11 2020, 10:56 PM · Restricted Project, Restricted Project

Apr 10 2020

Abpostelnicu edited projects for D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`, added: Restricted Project; removed Restricted Project.
Apr 10 2020, 11:04 AM · Restricted Project, Restricted Project
Abpostelnicu updated the summary of D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.
Apr 10 2020, 9:44 AM · Restricted Project, Restricted Project
Abpostelnicu updated the summary of D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.
Apr 10 2020, 9:44 AM · Restricted Project, Restricted Project
Abpostelnicu created D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.
Apr 10 2020, 9:44 AM · Restricted Project, Restricted Project

Feb 24 2020

Abpostelnicu added inline comments to D52136: [clang-tidy] Add modernize-concat-nested-namespaces check.
Feb 24 2020, 2:39 AM · Restricted Project, Restricted Project

Feb 5 2020

Abpostelnicu added a comment to D74031: Update for Clang 10 release notes in order to have reference to D66404..

done

Feb 5 2020, 6:11 AM · Restricted Project
Abpostelnicu added a comment to D74031: Update for Clang 10 release notes in order to have reference to D66404..

Looks great, thanks!

Do you have commit access? If so, go ahead and push directly to the 10.x branch, otherwise let me know and I'll do it for you.

Yes I have commit access, pushing it directly to 10.x then.

Feb 5 2020, 6:02 AM · Restricted Project
Abpostelnicu updated the diff for D74031: Update for Clang 10 release notes in order to have reference to D66404..

Adding extra comments to the release patch.

Feb 5 2020, 5:07 AM · Restricted Project
Abpostelnicu added a comment to D74031: Update for Clang 10 release notes in order to have reference to D66404..

lgtm, but if you want it wouldn't hurt to include even more details from the commit message.

Feb 5 2020, 5:07 AM · Restricted Project
Abpostelnicu created D74031: Update for Clang 10 release notes in order to have reference to D66404..
Feb 5 2020, 2:29 AM · Restricted Project
Abpostelnicu updated the summary of D74031: Update for Clang 10 release notes in order to have reference to D66404..
Feb 5 2020, 2:29 AM · Restricted Project
Abpostelnicu updated subscribers of D74031: Update for Clang 10 release notes in order to have reference to D66404..
Feb 5 2020, 2:29 AM · Restricted Project
Abpostelnicu updated the summary of D74031: Update for Clang 10 release notes in order to have reference to D66404..
Feb 5 2020, 2:29 AM · Restricted Project

Jan 9 2020

Abpostelnicu added a comment to D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests..

Hm, didn't clang gain such a diagnostic itself recently? https://godbolt.org/z/MYJTvw
Wouldn't it make sense to migrate everything into it, and drop this now-duplicating check?

Jan 9 2020, 1:31 AM · Restricted Project, Restricted Project
Abpostelnicu added a project to D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests.: Restricted Project.
Jan 9 2020, 12:06 AM · Restricted Project, Restricted Project
Abpostelnicu updated the summary of D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests..
Jan 9 2020, 12:06 AM · Restricted Project, Restricted Project
Abpostelnicu created D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests..
Jan 9 2020, 12:06 AM · Restricted Project, Restricted Project

Jan 8 2020

Abpostelnicu added a comment to D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Will push shortly an update.

Jan 8 2020, 10:02 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

I think the best approach here is to remove the tests that don’t have template instantiation.

Jan 8 2020, 8:00 AM · Restricted Project, Restricted Project
Abpostelnicu added a project to D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.: Restricted Project.
Jan 8 2020, 6:44 AM · Restricted Project, Restricted Project
Abpostelnicu updated the summary of D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..
Jan 8 2020, 6:25 AM · Restricted Project, Restricted Project
Abpostelnicu updated the diff for D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Added more tesst for templa functions that are not instantiated.

Jan 8 2020, 4:53 AM · Restricted Project, Restricted Project

Jan 7 2020

Abpostelnicu updated the diff for D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Updated test with match without compound statement.

Jan 7 2020, 8:21 AM · Restricted Project, Restricted Project
Abpostelnicu updated the diff for D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Updated the test case to better reflect the changes.

Jan 7 2020, 7:14 AM · Restricted Project, Restricted Project
Abpostelnicu created D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..
Jan 7 2020, 6:37 AM · Restricted Project, Restricted Project

Sep 5 2019

Herald added a project to D54408: [ASTMatchers] Add matchers available through casting to derived: Restricted Project.

@aaron.ballman
I think the auto usage improves and simplifies the code, however, as I would really like to see this code landed, I would be ok to help Stephen to finish this work and replace auto by the "old" way. Do you think we can have this approved if we make the changes mentioned earlier?

Sep 5 2019, 6:51 AM · Restricted Project

Sep 3 2019

Abpostelnicu committed rL370742: Request commit access for abpostelnicu.
Request commit access for abpostelnicu
Sep 3 2019, 4:09 AM

Apr 9 2019

Abpostelnicu committed rG965c5812f438: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number… (authored by Abpostelnicu).
ClangTidy: Avoid mixing stdout with stderror when dealing with a large number…
Apr 9 2019, 4:16 AM
Abpostelnicu committed rCTE357994: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number….
ClangTidy: Avoid mixing stdout with stderror when dealing with a large number…
Apr 9 2019, 4:16 AM
Abpostelnicu committed rL357994: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number….
ClangTidy: Avoid mixing stdout with stderror when dealing with a large number…
Apr 9 2019, 4:16 AM
Abpostelnicu closed D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..
Apr 9 2019, 4:16 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu updated the summary of D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..
Apr 9 2019, 3:40 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu updated the summary of D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..
Apr 9 2019, 3:40 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu added a project to D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.: Restricted Project.
Apr 9 2019, 3:36 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu added a reviewer for D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.: JonasToth.
Apr 9 2019, 3:36 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu created D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..
Apr 9 2019, 3:33 AM · Restricted Project, Restricted Project, Restricted Project

Jan 16 2019

Abpostelnicu abandoned D29987: Modify Mozilla - break before binary operator.
Jan 16 2019, 11:56 PM

Sep 19 2018

Abpostelnicu committed rCTE342540: [clang-tidy] run-clang-tidy.py - fails using python 3.7.
[clang-tidy] run-clang-tidy.py - fails using python 3.7
Sep 19 2018, 4:55 AM
Abpostelnicu committed rL342540: [clang-tidy] run-clang-tidy.py - fails using python 3.7.
[clang-tidy] run-clang-tidy.py - fails using python 3.7
Sep 19 2018, 4:55 AM
Abpostelnicu closed D51220: [clang-tidy] run-clang-tidy fails using python 3.7.
Sep 19 2018, 4:55 AM
Abpostelnicu updated the diff for D51220: [clang-tidy] run-clang-tidy fails using python 3.7.
Sep 19 2018, 4:48 AM

Aug 24 2018

Abpostelnicu added a comment to D51220: [clang-tidy] run-clang-tidy fails using python 3.7.

I can confirm tested on:
2.7.15
3.7.0

Aug 24 2018, 9:08 AM
Abpostelnicu added a comment to D51220: [clang-tidy] run-clang-tidy fails using python 3.7.

I don't know a lot about how to write portable code!

But wouldn't this be out usecase? http://python-future.org/compatible_idioms.html#file-io-with-open
Using the decode is supposed to work in both pythons

Aug 24 2018, 9:05 AM
Abpostelnicu updated the diff for D51220: [clang-tidy] run-clang-tidy fails using python 3.7.
Aug 24 2018, 9:05 AM
Abpostelnicu added a reviewer for D51220: [clang-tidy] run-clang-tidy fails using python 3.7: alexfh.
Aug 24 2018, 8:43 AM
Abpostelnicu updated the summary of D51220: [clang-tidy] run-clang-tidy fails using python 3.7.
Aug 24 2018, 8:43 AM
Abpostelnicu created D51220: [clang-tidy] run-clang-tidy fails using python 3.7.
Aug 24 2018, 8:42 AM
Abpostelnicu updated the diff for D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.
Aug 24 2018, 8:34 AM · Restricted Project
Abpostelnicu added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

Strangely I haven't had those kind of issues but since you propose those modifications I would do one more modification, let's output everything to stdout and not stderr by doing:

if err:
  sys.stdout.write(str(err) + '\n')

You can make this a new revision, fixing the byte and str issues would be more important now.

The byte and str thingie is since the whole python3 releases or did it change?

Aug 24 2018, 8:31 AM · Restricted Project

Aug 16 2018

Abpostelnicu added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

Strangely I haven't had those kind of issues but since you propose those modifications I would do one more modification, let's output everything to stdout and not stderr by doing:

Aug 16 2018, 10:33 AM · Restricted Project

Aug 10 2018

Abpostelnicu committed rCTE339427: [clang-tidy] run-clang-tidy.py - add synchronisation to the output.
[clang-tidy] run-clang-tidy.py - add synchronisation to the output
Aug 10 2018, 4:51 AM
Abpostelnicu committed rL339427: [clang-tidy] run-clang-tidy.py - add synchronisation to the output.
[clang-tidy] run-clang-tidy.py - add synchronisation to the output
Aug 10 2018, 4:51 AM
Abpostelnicu closed D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.
Aug 10 2018, 4:51 AM · Restricted Project

Aug 7 2018

Abpostelnicu added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

Did you notice any significant speed degradation?

Aug 7 2018, 10:17 AM · Restricted Project
Abpostelnicu added a reviewer for D49851: [clang-tidy] run-clang-tidy add synchronisation to the output: JonasToth.
Aug 7 2018, 7:55 AM · Restricted Project
Abpostelnicu added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

Regarding the time penalty it depends very much on how many files you have. But I would choose anytime to have this in the detriment of having "obfuscated" output.

Aug 7 2018, 7:55 AM · Restricted Project
Abpostelnicu updated the diff for D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.
Aug 7 2018, 7:53 AM · Restricted Project

Jul 26 2018

Abpostelnicu added a reviewer for D49851: [clang-tidy] run-clang-tidy add synchronisation to the output: aaron.ballman.
Jul 26 2018, 6:01 AM · Restricted Project
Abpostelnicu created D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.
Jul 26 2018, 6:00 AM · Restricted Project

Jan 3 2018

Abpostelnicu added inline comments to D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons.
Jan 3 2018, 7:50 AM · Restricted Project

Nov 3 2017

Abpostelnicu added a comment to D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc.

I can test this on our repo, Mozilla, since it's a large code-base I think we will have a better understanding of the false-positive ratio.

Nov 3 2017, 1:13 AM · Restricted Project

Sep 25 2017

Abpostelnicu added a comment to D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. .

Can you point out where that's spelled out in the style guide? I can't find a reference to it (searching for "{}" or "{ }" doesn't provide any hits).
I'm slightly opposed to this, given that so far I haven't heard a convincing argument why this makes any difference to readability.

Sep 25 2017, 5:16 AM
Abpostelnicu added a reviewer for D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. : klimek.
Sep 25 2017, 5:03 AM

Sep 18 2017

Abpostelnicu added a reviewer for D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. : djasper.
Sep 18 2017, 8:29 AM
Abpostelnicu updated the diff for D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. .
Sep 18 2017, 8:28 AM
Abpostelnicu created D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. .
Sep 18 2017, 8:27 AM

Mar 10 2017

Abpostelnicu committed rL297467: [clang-format] Add option to break before inheritance separation operator in….
[clang-format] Add option to break before inheritance separation operator in…
Mar 10 2017, 7:22 AM
Abpostelnicu closed D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration by committing rL297467: [clang-format] Add option to break before inheritance separation operator in….
Mar 10 2017, 7:22 AM · Restricted Project
Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Fixed two spell errors.

Mar 10 2017, 6:58 AM · Restricted Project
Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 10 2017, 6:48 AM · Restricted Project