Page MenuHomePhabricator

Abpostelnicu (Andi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 27 2016, 4:23 AM (185 w, 4 d)

Recent Activity

Wed, Feb 5

Abpostelnicu added a comment to D74031: Update for Clang 10 release notes in order to have reference to D66404..

done

Wed, Feb 5, 6:11 AM · Restricted Project
Abpostelnicu added a comment to D74031: Update for Clang 10 release notes in order to have reference to D66404..

Looks great, thanks!

Do you have commit access? If so, go ahead and push directly to the 10.x branch, otherwise let me know and I'll do it for you.

Yes I have commit access, pushing it directly to 10.x then.

Wed, Feb 5, 6:02 AM · Restricted Project
Abpostelnicu updated the diff for D74031: Update for Clang 10 release notes in order to have reference to D66404..

Adding extra comments to the release patch.

Wed, Feb 5, 5:07 AM · Restricted Project
Abpostelnicu added a comment to D74031: Update for Clang 10 release notes in order to have reference to D66404..

lgtm, but if you want it wouldn't hurt to include even more details from the commit message.

Wed, Feb 5, 5:07 AM · Restricted Project
Abpostelnicu created D74031: Update for Clang 10 release notes in order to have reference to D66404..
Wed, Feb 5, 2:29 AM · Restricted Project
Abpostelnicu updated the summary of D74031: Update for Clang 10 release notes in order to have reference to D66404..
Wed, Feb 5, 2:29 AM · Restricted Project
Abpostelnicu updated subscribers of D74031: Update for Clang 10 release notes in order to have reference to D66404..
Wed, Feb 5, 2:29 AM · Restricted Project
Abpostelnicu updated the summary of D74031: Update for Clang 10 release notes in order to have reference to D66404..
Wed, Feb 5, 2:29 AM · Restricted Project

Jan 9 2020

Abpostelnicu added a comment to D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests..

Hm, didn't clang gain such a diagnostic itself recently? https://godbolt.org/z/MYJTvw
Wouldn't it make sense to migrate everything into it, and drop this now-duplicating check?

Jan 9 2020, 1:31 AM · Restricted Project, Restricted Project
Abpostelnicu added a project to D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests.: Restricted Project.
Jan 9 2020, 12:06 AM · Restricted Project, Restricted Project
Abpostelnicu updated the summary of D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests..
Jan 9 2020, 12:06 AM · Restricted Project, Restricted Project
Abpostelnicu created D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests..
Jan 9 2020, 12:06 AM · Restricted Project, Restricted Project

Jan 8 2020

Abpostelnicu added a comment to D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Will push shortly an update.

Jan 8 2020, 10:02 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

I think the best approach here is to remove the tests that don’t have template instantiation.

Jan 8 2020, 8:00 AM · Restricted Project, Restricted Project
Abpostelnicu added a project to D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.: Restricted Project.
Jan 8 2020, 6:44 AM · Restricted Project, Restricted Project
Abpostelnicu updated the summary of D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..
Jan 8 2020, 6:25 AM · Restricted Project, Restricted Project
Abpostelnicu updated the diff for D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Added more tesst for templa functions that are not instantiated.

Jan 8 2020, 4:53 AM · Restricted Project, Restricted Project

Jan 7 2020

Abpostelnicu updated the diff for D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Updated test with match without compound statement.

Jan 7 2020, 8:21 AM · Restricted Project, Restricted Project
Abpostelnicu updated the diff for D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Updated the test case to better reflect the changes.

Jan 7 2020, 7:14 AM · Restricted Project, Restricted Project
Abpostelnicu created D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..
Jan 7 2020, 6:37 AM · Restricted Project, Restricted Project

Sep 5 2019

Herald added a project to D54408: [ASTMatchers] Add matchers available through casting to derived: Restricted Project.

@aaron.ballman
I think the auto usage improves and simplifies the code, however, as I would really like to see this code landed, I would be ok to help Steven to finish this work and replace auto by the "old" way. Do you think we can have this approved if we make the changes mentioned earlier?

Sep 5 2019, 6:51 AM · Restricted Project

Sep 3 2019

Abpostelnicu committed rL370742: Request commit access for abpostelnicu.
Request commit access for abpostelnicu
Sep 3 2019, 4:09 AM

Apr 9 2019

Abpostelnicu committed rG965c5812f438: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number… (authored by Abpostelnicu).
ClangTidy: Avoid mixing stdout with stderror when dealing with a large number…
Apr 9 2019, 4:16 AM
Abpostelnicu committed rCTE357994: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number….
ClangTidy: Avoid mixing stdout with stderror when dealing with a large number…
Apr 9 2019, 4:16 AM
Abpostelnicu committed rL357994: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number….
ClangTidy: Avoid mixing stdout with stderror when dealing with a large number…
Apr 9 2019, 4:16 AM
Abpostelnicu closed D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..
Apr 9 2019, 4:16 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu updated the summary of D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..
Apr 9 2019, 3:40 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu updated the summary of D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..
Apr 9 2019, 3:40 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu added a project to D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.: Restricted Project.
Apr 9 2019, 3:36 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu added a reviewer for D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.: JonasToth.
Apr 9 2019, 3:36 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu created D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..
Apr 9 2019, 3:33 AM · Restricted Project, Restricted Project, Restricted Project

Jan 16 2019

Abpostelnicu abandoned D29987: Modify Mozilla - break before binary operator.
Jan 16 2019, 11:56 PM

Sep 19 2018

Abpostelnicu committed rCTE342540: [clang-tidy] run-clang-tidy.py - fails using python 3.7.
[clang-tidy] run-clang-tidy.py - fails using python 3.7
Sep 19 2018, 4:55 AM
Abpostelnicu committed rL342540: [clang-tidy] run-clang-tidy.py - fails using python 3.7.
[clang-tidy] run-clang-tidy.py - fails using python 3.7
Sep 19 2018, 4:55 AM
Abpostelnicu closed D51220: [clang-tidy] run-clang-tidy fails using python 3.7.
Sep 19 2018, 4:55 AM
Abpostelnicu updated the diff for D51220: [clang-tidy] run-clang-tidy fails using python 3.7.
Sep 19 2018, 4:48 AM

Aug 24 2018

Abpostelnicu added a comment to D51220: [clang-tidy] run-clang-tidy fails using python 3.7.

I can confirm tested on:
2.7.15
3.7.0

Aug 24 2018, 9:08 AM
Abpostelnicu added a comment to D51220: [clang-tidy] run-clang-tidy fails using python 3.7.

I don't know a lot about how to write portable code!

But wouldn't this be out usecase? http://python-future.org/compatible_idioms.html#file-io-with-open
Using the decode is supposed to work in both pythons

Aug 24 2018, 9:05 AM
Abpostelnicu updated the diff for D51220: [clang-tidy] run-clang-tidy fails using python 3.7.
Aug 24 2018, 9:05 AM
Abpostelnicu added a reviewer for D51220: [clang-tidy] run-clang-tidy fails using python 3.7: alexfh.
Aug 24 2018, 8:43 AM
Abpostelnicu updated the summary of D51220: [clang-tidy] run-clang-tidy fails using python 3.7.
Aug 24 2018, 8:43 AM
Abpostelnicu created D51220: [clang-tidy] run-clang-tidy fails using python 3.7.
Aug 24 2018, 8:42 AM
Abpostelnicu updated the diff for D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.
Aug 24 2018, 8:34 AM · Restricted Project
Abpostelnicu added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

Strangely I haven't had those kind of issues but since you propose those modifications I would do one more modification, let's output everything to stdout and not stderr by doing:

if err:
  sys.stdout.write(str(err) + '\n')

You can make this a new revision, fixing the byte and str issues would be more important now.

The byte and str thingie is since the whole python3 releases or did it change?

Aug 24 2018, 8:31 AM · Restricted Project

Aug 16 2018

Abpostelnicu added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

Strangely I haven't had those kind of issues but since you propose those modifications I would do one more modification, let's output everything to stdout and not stderr by doing:

Aug 16 2018, 10:33 AM · Restricted Project

Aug 10 2018

Abpostelnicu committed rCTE339427: [clang-tidy] run-clang-tidy.py - add synchronisation to the output.
[clang-tidy] run-clang-tidy.py - add synchronisation to the output
Aug 10 2018, 4:51 AM
Abpostelnicu committed rL339427: [clang-tidy] run-clang-tidy.py - add synchronisation to the output.
[clang-tidy] run-clang-tidy.py - add synchronisation to the output
Aug 10 2018, 4:51 AM
Abpostelnicu closed D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.
Aug 10 2018, 4:51 AM · Restricted Project

Aug 7 2018

Abpostelnicu added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

Did you notice any significant speed degradation?

Aug 7 2018, 10:17 AM · Restricted Project
Abpostelnicu added a reviewer for D49851: [clang-tidy] run-clang-tidy add synchronisation to the output: JonasToth.
Aug 7 2018, 7:55 AM · Restricted Project
Abpostelnicu added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

Regarding the time penalty it depends very much on how many files you have. But I would choose anytime to have this in the detriment of having "obfuscated" output.

Aug 7 2018, 7:55 AM · Restricted Project
Abpostelnicu updated the diff for D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.
Aug 7 2018, 7:53 AM · Restricted Project

Jul 26 2018

Abpostelnicu added a reviewer for D49851: [clang-tidy] run-clang-tidy add synchronisation to the output: aaron.ballman.
Jul 26 2018, 6:01 AM · Restricted Project
Abpostelnicu created D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.
Jul 26 2018, 6:00 AM · Restricted Project

Jan 3 2018

Abpostelnicu added inline comments to D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons.
Jan 3 2018, 7:50 AM · Restricted Project

Nov 3 2017

Abpostelnicu added a comment to D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc.

I can test this on our repo, Mozilla, since it's a large code-base I think we will have a better understanding of the false-positive ratio.

Nov 3 2017, 1:13 AM · Restricted Project

Sep 25 2017

Abpostelnicu added a comment to D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. .

Can you point out where that's spelled out in the style guide? I can't find a reference to it (searching for "{}" or "{ }" doesn't provide any hits).
I'm slightly opposed to this, given that so far I haven't heard a convincing argument why this makes any difference to readability.

Sep 25 2017, 5:16 AM
Abpostelnicu added a reviewer for D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. : klimek.
Sep 25 2017, 5:03 AM

Sep 18 2017

Abpostelnicu added a reviewer for D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. : djasper.
Sep 18 2017, 8:29 AM
Abpostelnicu updated the diff for D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. .
Sep 18 2017, 8:28 AM
Abpostelnicu created D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. .
Sep 18 2017, 8:27 AM

Mar 10 2017

Abpostelnicu committed rL297467: [clang-format] Add option to break before inheritance separation operator in….
[clang-format] Add option to break before inheritance separation operator in…
Mar 10 2017, 7:22 AM
Abpostelnicu closed D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration by committing rL297467: [clang-format] Add option to break before inheritance separation operator in….
Mar 10 2017, 7:22 AM · Restricted Project
Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Fixed two spell errors.

Mar 10 2017, 6:58 AM · Restricted Project
Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 10 2017, 6:48 AM · Restricted Project
Abpostelnicu added inline comments to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 10 2017, 6:33 AM · Restricted Project
Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 10 2017, 6:29 AM · Restricted Project

Mar 9 2017

Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Yes that's a better name :)

Mar 9 2017, 8:11 AM · Restricted Project
Abpostelnicu added a comment to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Daniel what do you think about the last version of the patch? I don't want to have this stalled since we really need this modifications in order to be able to run clang-format on our repository.

Mar 9 2017, 5:32 AM · Restricted Project

Mar 7 2017

Abpostelnicu added a comment to D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.

Pushed a new change since the test case was broken, and broke the build.

Mar 7 2017, 7:38 AM · Restricted Project
Abpostelnicu committed rL297148: [clang-format] Followup of D30646 - unbreak the build.
[clang-format] Followup of D30646 - unbreak the build
Mar 7 2017, 7:32 AM
Abpostelnicu committed rL297143: [clang-format] Fixed indent issue when adding a comment at the end of a return….
[clang-format] Fixed indent issue when adding a comment at the end of a return…
Mar 7 2017, 7:00 AM
Abpostelnicu closed D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented by committing rL297143: [clang-format] Fixed indent issue when adding a comment at the end of a return….
Mar 7 2017, 6:59 AM · Restricted Project
Abpostelnicu updated the diff for D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.
Mar 7 2017, 12:51 AM · Restricted Project
Abpostelnicu updated the diff for D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.
Mar 7 2017, 12:43 AM · Restricted Project

Mar 6 2017

Abpostelnicu added inline comments to D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.
Mar 6 2017, 8:36 AM · Restricted Project
Abpostelnicu added a comment to D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.

Thanks for catching and fixing this.
Generally, please upload diffs with the full file as context. That way, phabricator allows expanding the code around your changes.

Mar 6 2017, 8:18 AM · Restricted Project
Abpostelnicu added a reviewer for D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented: djasper.
Mar 6 2017, 7:38 AM · Restricted Project
Abpostelnicu added a project to D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented: Restricted Project.
Mar 6 2017, 6:24 AM · Restricted Project
Abpostelnicu updated the diff for D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.

test attached

Mar 6 2017, 6:23 AM · Restricted Project
Abpostelnicu updated the summary of D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.
Mar 6 2017, 6:13 AM · Restricted Project
Abpostelnicu updated the summary of D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.
Mar 6 2017, 5:40 AM · Restricted Project
Abpostelnicu updated the summary of D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.
Mar 6 2017, 5:40 AM · Restricted Project
Abpostelnicu updated subscribers of D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.
Mar 6 2017, 5:39 AM · Restricted Project
Abpostelnicu created D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.
Mar 6 2017, 5:35 AM · Restricted Project

Mar 3 2017

Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

corrected some format issues.

Mar 3 2017, 7:21 AM · Restricted Project
Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 3 2017, 7:14 AM · Restricted Project
Abpostelnicu added a comment to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Hm. Unfortunately, this seems to have been implemented to support Webkit style and Webkit style is explicit about wanting this (https://webkit.org/code-style-guidelines/) :(.

But maybe the solution to that is to add an extra flag like AlwaysWrapInitializerList. Really not sure how best to organize this. Any thoughts? (I personally care about neither of these styles, so maybe I am not the best to judge)

At any rate, to move forward, could you remove the hasMultipleInheritance function and instead use the alternative approach discussed?

Mar 3 2017, 5:35 AM · Restricted Project
Abpostelnicu added a comment to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Do you know whether that is intentional? The style guide isn't really conclusive.

Mar 3 2017, 5:01 AM · Restricted Project
Abpostelnicu added a comment to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Before '? Can you give an example?

Mar 3 2017, 4:51 AM · Restricted Project
Abpostelnicu added inline comments to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 3 2017, 4:24 AM · Restricted Project
Abpostelnicu added inline comments to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 3 2017, 1:05 AM · Restricted Project

Mar 2 2017

Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Updated patch with the proposed modifications.

Mar 2 2017, 1:52 AM · Restricted Project
Abpostelnicu added inline comments to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 2 2017, 1:51 AM · Restricted Project

Mar 1 2017

Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

added patch against the updated repo.

Mar 1 2017, 6:47 AM · Restricted Project
Abpostelnicu updated the diff for D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Also added tests.

Mar 1 2017, 5:59 AM · Restricted Project
Abpostelnicu updated the summary of D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 1 2017, 12:08 AM · Restricted Project
Abpostelnicu created D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 1 2017, 12:02 AM · Restricted Project

Feb 16 2017

Abpostelnicu added a reviewer for D29987: Modify Mozilla - break before binary operator: sylvestre.ledru.
Feb 16 2017, 12:36 AM

Feb 15 2017

Abpostelnicu updated the summary of D29987: Modify Mozilla - break before binary operator.
Feb 15 2017, 7:26 AM