Page MenuHomePhabricator

Abpostelnicu (Andi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 27 2016, 4:23 AM (255 w, 4 d)

Recent Activity

Thu, Jun 3

Abpostelnicu added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

http://sprunge.us/FJzZXL is a file from harfbuzz and it warns

a.cc:28670:32: error: variable 'supp_size' set but not used [-Werror,-Wunused-but-set-variable]
    unsigned int size0, size1, supp_size = 0;

You have, with pragma gcc error, look at hb.hh. The problem is that clang has an error dealing with cascading pragma when setting different levels.

Thu, Jun 3, 10:05 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 1

Abpostelnicu added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

I think there is a false positive with this @george.burgess.iv:
In [this)(https://searchfox.org/mozilla-central/source/mozglue/baseprofiler/core/platform-linux-android.cpp#222-227) we have the warning triggered:
mozglue/baseprofiler/core/platform-linux-android.cpp:216:9: error: variable 'r' set but not used [-Werror,-Wunused-but-set-variable]

Tue, Jun 1, 10:23 PM · Restricted Project, Restricted Project, Restricted Project

May 6 2021

Abpostelnicu abandoned D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`.

Apparently Phabricator detected the presence of "revert D100625" in my alternative D101851's description and marked that as reverting this one. Of course, as this hadn't been committed, it cannot have been reverted either. Could you confirm that things work for you now, @Abpostelnicu?

Do you mind taking a look at fix proposed in:

https://bugs.llvm.org/show_bug.cgi?id=49990#c3

Sorry for not noticing this before, this is pretty much what I came up with too and what's committed now.

May 6 2021, 1:51 AM · Restricted Project

May 3 2021

Abpostelnicu added a comment to D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634).

I'm seeing here something very strange, if the user provided copy assignment operator is provided but is = delete and the copy constructor is default this warning will still trigger. Is this something expected?
I'm referring at this issue from the mozilla code-base.

May 3 2021, 9:41 PM · Restricted Project

Apr 28 2021

Abpostelnicu accepted D101480: Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable".

Thank you for this! Also I think it’s very well that you want to implement this warning in clang, with a little bit of more polish it will be up for merger!

Apr 28 2021, 12:20 PM · Restricted Project
Abpostelnicu added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

Also I don’t remember seeing this proposed on cfe dev mailing list.

There is no such requirement. I don't recall that happening basically ever, actually.

Apr 28 2021, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

Please revert this. This change hasn’t been tested nor reviewed enough. Also I don’t remember seeing this proposed on cfe dev mailing list.

Apr 28 2021, 11:26 AM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2021

Abpostelnicu added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

I think this added a regression, where you have this context:

Apr 27 2021, 1:35 AM · Restricted Project, Restricted Project, Restricted Project

Apr 16 2021

Abpostelnicu added a comment to D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`.

As you can see I don't specify LLVM_ENABLE_PROJECTS but still looking at the build failure, it seems that clang-tools-extra is being built, or parts of it are:

because I don't specify LLVM_ENABLE_PROJECTS so the set will not occur.

but the sample you provided has -DLLVM_ENABLE_PROJECTS=clang;compiler-rt in it, hence it doesn't really reproduce the issue.

Apr 16 2021, 3:38 AM · Restricted Project
Abpostelnicu added a comment to D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`.

In my case, this will never be true but, because I don't specify LLVM_ENABLE_PROJECTS so the set will not occur.

Apr 16 2021, 3:26 AM · Restricted Project
Abpostelnicu added a comment to D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`.

If you don't specify LLVM_ENABLE_PROJECTS clang-tools-extra will still be built but without having set LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR.

This feels like the failure of the first case i mentioned, i.e. some cmake file under CTE being executed even though it is disabled. Can you provide some repro steps? For example when I do:

git clone git@github.com:llvm/llvm-project.git
cd llvm-project && mkdir build_test && cd build_test
cmake -G Ninja ../llvm/ -DCMAKE_BUILD_TYPE="RELEASE"
ninja all

this finishes without any errors. as expected clang-tools-extra/clangd/quality/CompletionModel.cmake doesn't interfere with the build when clang-tools-extra is not mentioned in LLVM_ENABLE_PROJECTS.


also there are lots of build bots building different subsets of LLVM in different configurations and none of them have been broken by this change. so it would be great to understand the reason behind the breakage you are experiencing.

Apr 16 2021, 2:13 AM · Restricted Project
Abpostelnicu updated the summary of D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`.
Apr 16 2021, 1:54 AM · Restricted Project
Abpostelnicu added a comment to D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`.

I am not an expert on Cmake nor understand what is going on here fully, but here are my 2 cents.

D58157 didn't remove LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR, it just stopped enabling CTE whenever clang was enabled.
All of LLVM_EXTERNAL_$PROJECT variables are set based on the values passed into LLVM_ENABLE_PROJECTS in https://github.com/llvm/llvm-project/blob/main/llvm/CMakeLists.txt#L105.

So in theory this cmake file should only be evaluated when CTE is enabled and LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR should always be set when CTE is enabled.
The correct fix would be to figure out why one of the above statements are not holding, i.e.:

  • This cmake file is evaluated/executed despite CTE being off (this shouldn't be the case)
  • LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR is not set, even though CTE is part of LLVM_ENABLE_PROJECTS.
Apr 16 2021, 1:51 AM · Restricted Project
Abpostelnicu added a reviewer for D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`: glandium.
Apr 16 2021, 1:11 AM · Restricted Project
Abpostelnicu requested review of D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`.
Apr 16 2021, 1:09 AM · Restricted Project

Apr 12 2021

Abpostelnicu retitled D93543: clang-tidy: Add `-use-color` for `run-clang-tidy.py` in order to make it sane with `clang-tidy` coloring argument from clang-tidy: Leave the possibility of opting out having coloured diagnostic messages. to clang-tidy: Add `-use-color` for `run-clang-tidy.py` in order to make it sane with `clang-tidy` coloring argument.
Apr 12 2021, 4:05 AM · Restricted Project, Restricted Project
Abpostelnicu updated the diff for D93543: clang-tidy: Add `-use-color` for `run-clang-tidy.py` in order to make it sane with `clang-tidy` coloring argument.

Add -use-color argument to make it sane with clang-tidy --use-color argument.

Apr 12 2021, 4:03 AM · Restricted Project, Restricted Project
Abpostelnicu abandoned D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. .
Apr 12 2021, 3:44 AM

Feb 12 2021

Abpostelnicu abandoned D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS.

This has landed and trunk is already fixed.

Feb 12 2021, 1:26 AM · Restricted Project

Feb 8 2021

Abpostelnicu added a comment to D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS.

Landed in 11.1 https://github.com/llvm/llvm-project/commit/1fdec59bffc11ae37eb51a1b9869f0696bfd5312#diff-2fa23ad0cf1839955ddaf4a0d78a9d9b5fd9b88933f82f6433035916a2655c6c.
Patch needs to be rebased for trunk now.

Feb 8 2021, 10:55 AM · Restricted Project

Feb 4 2021

Abpostelnicu added a comment to D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS.

The failure is wrong.

Feb 4 2021, 3:42 AM · Restricted Project

Feb 3 2021

Abpostelnicu updated the diff for D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS.

rebased on 11.1rc2

Feb 3 2021, 8:31 AM · Restricted Project

Jan 30 2021

Abpostelnicu added a comment to D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS.

@tstellar what do you suggest to do here?

Jan 30 2021, 1:29 AM · Restricted Project

Jan 29 2021

Abpostelnicu added a comment to D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.

Oh, I see. I made this change in the master branch and then ported it to the release/11.x branch. It changed the signature of a virtual method, which had a couple more overrides in the release/11.x branch, and when I ported the change I didn't realize those other overrides existed. So now the release/11.x builds that include those overrides (btw, what build flags are needed to include those?) are broken. I'm not sure what the options are now that 11.0.1 has been released and 11.1.0 is at rc2 -- @tstellar, thoughts?

I have a fix for this ready, I can push it to 11.0.1.

Can you file a bug for this or re-open the merge request bug?

Jan 29 2021, 9:02 AM · Restricted Project
Abpostelnicu added inline comments to D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS.
Jan 29 2021, 8:13 AM · Restricted Project
Abpostelnicu updated the diff for D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS.

Update for plularization of variables name.

Jan 29 2021, 8:12 AM · Restricted Project
Abpostelnicu updated the diff for D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS.

Update with format

Jan 29 2021, 8:05 AM · Restricted Project
Abpostelnicu requested review of D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS.
Jan 29 2021, 8:00 AM · Restricted Project
Abpostelnicu added a comment to D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.

And there are more issues like: https://github.com/llvm/llvm-project/blob/llvmorg-11.0.1/lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp#L733. old_module_sp_ptr is nowhere declared.

Jan 29 2021, 7:51 AM · Restricted Project
Abpostelnicu added a comment to D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.

Oh, I see. I made this change in the master branch and then ported it to the release/11.x branch. It changed the signature of a virtual method, which had a couple more overrides in the release/11.x branch, and when I ported the change I didn't realize those other overrides existed. So now the release/11.x builds that include those overrides (btw, what build flags are needed to include those?) are broken. I'm not sure what the options are now that 11.0.1 has been released and 11.1.0 is at rc2 -- @tstellar, thoughts?

Jan 29 2021, 7:44 AM · Restricted Project
Abpostelnicu added a comment to D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.

Shouldn't this also update PlatformiOSSimulator.h?

There is no PlatformOSSimulator.h file (or I can't find it). There is a type PlatformiOSSumulator, but it doesn't have its own GetSharedModule method. Its CreateInstance method returns a PlatformAppleSimulator[1], and this change does update PlatformAppleSimulator. So unless I'm misunderstanding your point, I don't think any changes specific to PlatformiOSSimulator are needed

1 - https://github.com/llvm/llvm-project/blob/82847436e9258a12503dcfadb5dc373cb42fea43/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp#L538

Jan 29 2021, 7:14 AM · Restricted Project
Abpostelnicu added a comment to D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.

Shouldn't this also update PlatformiOSSimulator.h?

Jan 29 2021, 3:19 AM · Restricted Project

Dec 18 2020

Abpostelnicu edited reviewers for D93543: clang-tidy: Add `-use-color` for `run-clang-tidy.py` in order to make it sane with `clang-tidy` coloring argument, added: njames93; removed: sylvestre.ledru.
Dec 18 2020, 11:26 AM · Restricted Project, Restricted Project
Abpostelnicu added a reviewer for D93543: clang-tidy: Add `-use-color` for `run-clang-tidy.py` in order to make it sane with `clang-tidy` coloring argument: sylvestre.ledru.
Dec 18 2020, 9:55 AM · Restricted Project, Restricted Project
Abpostelnicu added a reviewer for D93543: clang-tidy: Add `-use-color` for `run-clang-tidy.py` in order to make it sane with `clang-tidy` coloring argument: aaron.ballman.
Dec 18 2020, 7:35 AM · Restricted Project, Restricted Project
Abpostelnicu added a project to D93543: clang-tidy: Add `-use-color` for `run-clang-tidy.py` in order to make it sane with `clang-tidy` coloring argument: Restricted Project.
Dec 18 2020, 7:34 AM · Restricted Project, Restricted Project
Abpostelnicu requested review of D93543: clang-tidy: Add `-use-color` for `run-clang-tidy.py` in order to make it sane with `clang-tidy` coloring argument.
Dec 18 2020, 7:33 AM · Restricted Project, Restricted Project

Oct 9 2020

Abpostelnicu added a comment to D79388: [clang-format] Fix AlignConsecutive on PP blocks.

Not to my knowledge, if we are not going to fix it we should probably revert it for now, we can bring it back later

Oct 9 2020, 5:30 AM · Restricted Project, Restricted Project

Sep 15 2020

Abpostelnicu added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

Has been pushed to the 11.x branch https://github.com/llvm/llvm-project/commit/1596c2dfd548b21cf33ad3353882ac465d78c1bb

Sep 15 2020, 9:28 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=47512

Can you take a look?

Sep 15 2020, 8:29 AM · Restricted Project, Restricted Project

Jul 2 2020

Abpostelnicu added a comment to D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis..

@njames93 wdyt if we add another parameter to distinguish if we want to use regex or not, and if not we escape the paths?
Also thank you so much for catching this up!

As the argument is documented as being a regex string, we shouldn't really try to escape it, and users should be expected escape any file names themselves before invoking the script.
If for whatever reason you want to use .c++ as your file extension. then you should pass r'*\.c\+\+' to the script.

Can I ask what the specific use case you have that is causing the issue? Are you invoking run-clang-tidy from a script that generates the list of files to search for?

Jul 2 2020, 5:20 AM · Restricted Project, Restricted Project
Abpostelnicu abandoned D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis..
Jul 2 2020, 5:20 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis..

@njames93 wdyt if we add another parameter to distinguish if we want to use regex or not, and if not we escape the paths?
Also thank you so much for catching this up!

Jul 2 2020, 2:38 AM · Restricted Project, Restricted Project

Jun 29 2020

Abpostelnicu updated the summary of D82784: [clang-tidy] For `run-clang-tidy.py` do not treat `allow_enabling_alpha_checkers` as a none value..
Jun 29 2020, 9:42 AM · Restricted Project
Abpostelnicu created D82784: [clang-tidy] For `run-clang-tidy.py` do not treat `allow_enabling_alpha_checkers` as a none value..
Jun 29 2020, 9:42 AM · Restricted Project

Jun 16 2020

Abpostelnicu reopened D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis..
Jun 16 2020, 3:17 AM · Restricted Project, Restricted Project
Abpostelnicu edited reviewers for D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis., added: JonasToth; removed: sylvestre.ledru.
Jun 16 2020, 2:43 AM · Restricted Project, Restricted Project
Abpostelnicu created D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis..
Jun 16 2020, 2:43 AM · Restricted Project, Restricted Project

May 19 2020

Abpostelnicu accepted D80008: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators.
May 19 2020, 8:41 AM · Restricted Project, Restricted Project
Abpostelnicu accepted D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon.
May 19 2020, 8:41 AM · Restricted Project, Restricted Project
Abpostelnicu accepted D75791: [clang-format] Added new option IndentExternBlock.
May 19 2020, 8:41 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Let's first see we don't break anything on mozilla.

May 19 2020, 8:10 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu added a reviewer for D75791: [clang-format] Added new option IndentExternBlock: Abpostelnicu.
May 19 2020, 8:08 AM · Restricted Project, Restricted Project, Restricted Project

May 15 2020

Abpostelnicu added a comment to D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon.

Please see https://firefox-source-docs.mozilla.org/code-quality/coding-style/format_cpp_code_with_clang-format.html

May 15 2020, 7:34 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon.

@MyDeveloperDay thanks for the patch, I'm gonna run it agains mozilla to see if there is any fallout.

May 15 2020, 3:46 AM · Restricted Project, Restricted Project

May 12 2020

Abpostelnicu accepted D79201: [clang-format] : Fix additional pointer alignment for overloaded operators.

Sorry, totally forgot about this, thank you!

May 12 2020, 1:02 AM · Restricted Project, Restricted Project

May 3 2020

Abpostelnicu requested changes to D79201: [clang-format] : Fix additional pointer alignment for overloaded operators.

As per what @sammccall said.

May 3 2020, 11:19 PM · Restricted Project, Restricted Project

Apr 28 2020

Abpostelnicu accepted D78879: [clang-format] [PR45357] Fix issue found with operator spacing.
Apr 28 2020, 2:39 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.

Just to clarify something here, for me the patch looks good but until I will accept the revision I want to test it on the mozilla codebase.

Apr 28 2020, 2:39 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.

@sylvestre.ledru , @Abpostelnicu

I believe to fix your original request you need a combination of D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107) and this fix (this fix will handle the * * issue in gecko-dev/ipc/mscom/Ptr.h

I've run this new binary over gecko-dev/ipc/mscom and gecko-dev/xpcom/ds and it shows no clang-format warnings

I hope this helps

Apr 28 2020, 2:07 AM · Restricted Project, Restricted Project

Apr 27 2020

Abpostelnicu accepted D78909: [clang-format] NFC clang-format the clang-format sources.
Apr 27 2020, 4:47 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.

I've cherry-picked D76850 to 10.x and see if this fixes the issue.

Apr 27 2020, 2:38 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.

@sylvestre.ledru

I'm taking a quick look at formatting the original bug in gecko and whilst the last windows snapshot (Feb 2020) shows the bug

$ clang-format --version
clang-format version 11.0.0

nsTArray.h:939:29: warning: code should be clang-formatted [-Wclang-format-violations]
  operator const nsTArray<E>&() {
                            ^
nsTArray.h:946:35: warning: code should be clang-formatted [-Wclang-format-violations]
  operator const FallibleTArray<E>&() {
                                  ^
nsTArray.h:1147:59: warning: code should be clang-formatted [-Wclang-format-violations]
  [[nodiscard]] operator const nsTArray_Impl<E, Allocator>&() const& {
                                                          ^
nsTArray.h:1151:43: warning: code should be clang-formatted [-Wclang-format-violations]
  [[nodiscard]] operator const nsTArray<E>&() const& {
                                          ^
nsTArray.h:1154:49: warning: code should be clang-formatted [-Wclang-format-violations]
  [[nodiscard]] operator const FallibleTArray<E>&() const& {

The current trunk does not

$ clang-format --version
clang-format version 11.0.0 (https://github.com/llvm/llvm-project 1956a8a7cb79e94dbe073e36eba2d6b003f91046)

clang-format -n nsTArray.h

Is Mozilla toolchain using LLVM from the v10 branch?

I think this is fixed by D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107)

Apr 27 2020, 2:38 AM · Restricted Project, Restricted Project
Abpostelnicu requested changes to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.
Apr 27 2020, 1:33 AM · Restricted Project, Restricted Project
Abpostelnicu added a reviewer for D78879: [clang-format] [PR45357] Fix issue found with operator spacing: Abpostelnicu.
Apr 27 2020, 1:33 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D78879: [clang-format] [PR45357] Fix issue found with operator spacing.

I think we are on the right track with this but what if we are dealing with tok::amp in a context similar to operator const FallibleTArray<E>&(); I can speculate that the outcome will be operator const FallibleTArray<E> &(); which is wrong.

Apr 27 2020, 12:29 AM · Restricted Project, Restricted Project

Apr 11 2020

Abpostelnicu added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

please add this to the release notes too :)
something like "new option -allow-enabling-alpha-checkers added to run-clang-tidy to enable alpha checkers"

Apr 11 2020, 10:56 PM · Restricted Project, Restricted Project
Abpostelnicu updated the diff for D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

Add release notes.

Apr 11 2020, 10:56 PM · Restricted Project, Restricted Project

Apr 10 2020

Abpostelnicu edited projects for D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`, added: Restricted Project; removed Restricted Project.
Apr 10 2020, 11:04 AM · Restricted Project, Restricted Project
Abpostelnicu updated the summary of D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.
Apr 10 2020, 9:44 AM · Restricted Project, Restricted Project
Abpostelnicu updated the summary of D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.
Apr 10 2020, 9:44 AM · Restricted Project, Restricted Project
Abpostelnicu created D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.
Apr 10 2020, 9:44 AM · Restricted Project, Restricted Project

Feb 24 2020

Abpostelnicu added inline comments to D52136: [clang-tidy] Add modernize-concat-nested-namespaces check.
Feb 24 2020, 2:39 AM · Restricted Project, Restricted Project

Feb 5 2020

Abpostelnicu added a comment to D74031: Update for Clang 10 release notes in order to have reference to D66404..

done

Feb 5 2020, 6:11 AM · Restricted Project
Abpostelnicu added a comment to D74031: Update for Clang 10 release notes in order to have reference to D66404..

Looks great, thanks!

Do you have commit access? If so, go ahead and push directly to the 10.x branch, otherwise let me know and I'll do it for you.

Yes I have commit access, pushing it directly to 10.x then.

Feb 5 2020, 6:02 AM · Restricted Project
Abpostelnicu updated the diff for D74031: Update for Clang 10 release notes in order to have reference to D66404..

Adding extra comments to the release patch.

Feb 5 2020, 5:07 AM · Restricted Project
Abpostelnicu added a comment to D74031: Update for Clang 10 release notes in order to have reference to D66404..

lgtm, but if you want it wouldn't hurt to include even more details from the commit message.

Feb 5 2020, 5:07 AM · Restricted Project
Abpostelnicu created D74031: Update for Clang 10 release notes in order to have reference to D66404..
Feb 5 2020, 2:29 AM · Restricted Project
Abpostelnicu updated the summary of D74031: Update for Clang 10 release notes in order to have reference to D66404..
Feb 5 2020, 2:29 AM · Restricted Project
Abpostelnicu updated subscribers of D74031: Update for Clang 10 release notes in order to have reference to D66404..
Feb 5 2020, 2:29 AM · Restricted Project
Abpostelnicu updated the summary of D74031: Update for Clang 10 release notes in order to have reference to D66404..
Feb 5 2020, 2:29 AM · Restricted Project

Jan 9 2020

Abpostelnicu added a comment to D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests..

Hm, didn't clang gain such a diagnostic itself recently? https://godbolt.org/z/MYJTvw
Wouldn't it make sense to migrate everything into it, and drop this now-duplicating check?

Jan 9 2020, 1:31 AM · Restricted Project, Restricted Project
Abpostelnicu added a project to D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests.: Restricted Project.
Jan 9 2020, 12:06 AM · Restricted Project, Restricted Project
Abpostelnicu updated the summary of D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests..
Jan 9 2020, 12:06 AM · Restricted Project, Restricted Project
Abpostelnicu created D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests..
Jan 9 2020, 12:06 AM · Restricted Project, Restricted Project

Jan 8 2020

Abpostelnicu added a comment to D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Will push shortly an update.

Jan 8 2020, 10:02 AM · Restricted Project, Restricted Project
Abpostelnicu added a comment to D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

I think the best approach here is to remove the tests that don’t have template instantiation.

Jan 8 2020, 8:00 AM · Restricted Project, Restricted Project
Abpostelnicu added a project to D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.: Restricted Project.
Jan 8 2020, 6:44 AM · Restricted Project, Restricted Project
Abpostelnicu updated the summary of D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..
Jan 8 2020, 6:25 AM · Restricted Project, Restricted Project
Abpostelnicu updated the diff for D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Added more tesst for templa functions that are not instantiated.

Jan 8 2020, 4:53 AM · Restricted Project, Restricted Project

Jan 7 2020

Abpostelnicu updated the diff for D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Updated test with match without compound statement.

Jan 7 2020, 8:21 AM · Restricted Project, Restricted Project
Abpostelnicu updated the diff for D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..

Updated the test case to better reflect the changes.

Jan 7 2020, 7:14 AM · Restricted Project, Restricted Project
Abpostelnicu created D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check..
Jan 7 2020, 6:37 AM · Restricted Project, Restricted Project

Sep 5 2019

Herald added a project to D54408: [ASTMatchers] Add matchers available through casting to derived: Restricted Project.

@aaron.ballman
I think the auto usage improves and simplifies the code, however, as I would really like to see this code landed, I would be ok to help Stephen to finish this work and replace auto by the "old" way. Do you think we can have this approved if we make the changes mentioned earlier?

Sep 5 2019, 6:51 AM · Restricted Project

Sep 3 2019

Abpostelnicu committed rL370742: Request commit access for abpostelnicu.
Request commit access for abpostelnicu
Sep 3 2019, 4:09 AM

Apr 9 2019

Abpostelnicu committed rG965c5812f438: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number… (authored by Abpostelnicu).
ClangTidy: Avoid mixing stdout with stderror when dealing with a large number…
Apr 9 2019, 4:16 AM
Abpostelnicu committed rCTE357994: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number….
ClangTidy: Avoid mixing stdout with stderror when dealing with a large number…
Apr 9 2019, 4:16 AM
Abpostelnicu committed rL357994: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number….
ClangTidy: Avoid mixing stdout with stderror when dealing with a large number…
Apr 9 2019, 4:16 AM
Abpostelnicu closed D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..
Apr 9 2019, 4:16 AM · Restricted Project, Restricted Project, Restricted Project
Abpostelnicu updated the summary of D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..
Apr 9 2019, 3:40 AM · Restricted Project, Restricted Project, Restricted Project