[clang-tidy] Add clang-tidy headers to clang distribution

[DmitryPolukhin]

Summary

Clang releases include static libraries for clang-tidy but corresponding
headers are missing in the tarball so these libraries are almost useless.
Clang-tidy libraries can be useful for build custom clang-tidy with
custom checks outside of llvm repo.

List of clang-tidy libraries included in clang 9.0.1 release:

lib/libclangTidyMPIModule.a
lib/libclangTidyPlugin.a
lib/libclangTidyBoostModule.a
lib/libclangTidyCERTModule.a
lib/libclangTidyAndroidModule.a
lib/libclangTidyPortabilityModule.a
lib/libclangTidyPerformanceModule.a
lib/libclangTidyOpenMPModule.a
lib/libclangTidyBugproneModule.a
lib/libclangTidyZirconModule.a
lib/libclangTidyCppCoreGuidelinesModule.a
lib/libclangTidyGoogleModule.a
lib/libclangTidyUtils.a
lib/libclangTidyHICPPModule.a
lib/libclangTidyModernizeModule.a
lib/libclangTidyLLVMModule.a
lib/libclangTidyAbseilModule.a
lib/libclangTidyReadabilityModule.a
lib/libclangTidyFuchsiaModule.a
lib/libclangTidyMiscModule.a
lib/libclangTidy.a
lib/libclangTidyObjCModule.a

[smeenai]

Can you upload the patch with context (git diff -U9999 if you're using the web interface or via arcanist)?

You'll want to add install targets for this, by adding a COMPONENT to the install command and referencing that in the target. See https://reviews.llvm.org/source/llvm-github/browse/master/clang/CMakeLists.txt;b4a99a061f517e60985667e39519f60186cbb469$438-446 for an example, though in your case the custom target doesn't need any dependencies.

clang-tools-extra/CMakeLists.txt

37 ↗

(On Diff #239711)

Is it possible to set this to include/clang-tidy and then move the block into clang-tidy/CMakeLists.txt?

[DmitryPolukhin]

• moved header installation to clang-tidy cmake file

[DmitryPolukhin]

• added clang-tidy-header component

[smeenai]

This LGTM, but I'll give the clang-tidy developers some time to weigh in.

clang-tools-extra/clang-tidy/CMakeLists.txt

106

You don't need the DEPENDS clang-headers

[DmitryPolukhin]

• removed DEPENDS

[alexfh]

LG with an outstanding comment.

clang-tools-extra/clang-tidy/CMakeLists.txt

104

Is this still relevant?

[DmitryPolukhin]

clang-tools-extra/clang-tidy/CMakeLists.txt

104

Perhaps no, but I still see it in number of case. I'll remove it here.

[DmitryPolukhin]

remove PATTERN ".svn" EXCLUDE

clang-tools-extra/clang-tidy/CMakeLists.txt

 endif()
 set(ALL_CLANG_TIDY_CHECKS ${ALL_CLANG_TIDY_CHECKS} PARENT_SCOPE)
 
 # Other subtargets. These may reference ALL_CLANG_TIDY_CHECKS
 # and must be below its definition.
 add_subdirectory(plugin)
 add_subdirectory(tool)
 add_subdirectory(utils)
+
+if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
+  install(DIRECTORY .
+    DESTINATION include/clang-tidy
+    COMPONENT clang-tidy-headers
+    FILES_MATCHING
+    PATTERN "*.h"
+    PATTERN ".svn" EXCLUDE
+    )
+  add_custom_target(clang-tidy-headers)
+  set_target_properties(clang-tidy-headers PROPERTIES FOLDER "Misc")
+  if(NOT LLVM_ENABLE_IDE)
+    add_llvm_install_targets(install-clang-tidy-headers
+                             DEPENDS clang-tidy-headers
+                             COMPONENT clang-tidy-headers)
+  endif()
+endif()