- User Since
- Sep 28 2015, 1:40 PM (198 w, 3 d)
Tue, Jul 16
Thank you for the review, Aaron!
Sun, Jul 14
- Don't crash when pretty-printing an Attribute with optional type argument
- Don't crash AST dump when Owner/Pointer has no Type argument
- gsl::Owner/gsl::Pointer: Make DerefType parameter optional
- Unify type and non-type attribute parsing; don't add OwnerAttr/PointerAttr twice
- Improve documentation
Thu, Jul 11
I didn't know whether they would differ, but the test tells me that they don't differ significantly (i.e. in introducing new techniques).
Would you like me to test with other standard libraries (besides MSVC, which I already planned)?
- Implement comments
This should address all remaining comments.
I believed that I had written a test for inline namespaces, but seems that I shouldn't be working in the middle of the night.
I will add one.
Tue, Jul 9
Move checks into AST matchers
Mon, Jul 8
- Address review comments
Tue, Jul 2
Friendly ping. Are there outstanding concerns that I could address?
- Make the list of attribute properties more consistent.
Mon, Jul 1
- Add newline at end of file
I understand that putting types on forward declared header (standard libraries / third party libraries) is not a approach we should favor.
Thank you for your good arguments.
API notes seems like a really good approach for this (I would like to help with the upstreaming), and in the meanwhile
I will work on hard-coding attributes for standard library types in clang for a follow-up PR. I think we could have them always attached (I will measure performance),
so that -Wlifetime will not change the AST.
- Address more review comments.
Sun, Jun 30
Address some review comments.
We can and should explore both options and see what works best.
Fri, Jun 28
We can try to add the annotations to libcxx (which will still take time),
but there are also other standard libraries (libstdc++, MSVC) that
can be used with clang.
Eventually everybody will have lifetime annotations (of course ;-) ),
but in the meantime there seems to be no other way to enable
the analysis on unmodified STL.
Fri, Jun 21
Jun 16 2019
Jun 10 2019
Fix rewrapped comment
May 23 2019
May 14 2019
May 13 2019
Fix wrong merge of ReleaseNotes
Remove `const` part from this PR. Address comments.
Do I wait for @alexfh to turn his red into a green, too?
May 12 2019
May 10 2019
I have thought about splitting the check into separate static & const, but kept it together because
the analysis for both cases is very similar, i.e. finding the usage of this.
May 9 2019
May 8 2019
Implement review comments
Thank you for the review input! After learning about inlinehint, I don't feel its worthwhile for me to continue this check.
Jul 27 2018
Does it also work with lambdas (being implicitly auto) that return pointers? A test case for that would be nice.
Nov 10 2017
I would be against make this the default. Maybe provide it as an option?
Jul 20 2017
Implemented all review comments
Use global settings "UseAssignment"
Jul 12 2017
Jun 23 2017
Please consider also https://reviews.llvm.org/D15031
It already handles all possible control flows. Instead of ScopeBegin and ScopeEnd,
it introduces LifetimeEnds elements. It's a more specific in that is also
correctly models the order of lifetime expiry of variables and the order
or destructor calls / lifetime ending.
Jun 2 2017
Please have a look at the discussion in https://reviews.llvm.org/D18914 (which is for a similar check)
It turns out that an inline specifier which is redundant for deciding linkage is still
used to drive the inliner. Basically, the inliner will consider larger function bodies for inlining
if the have an explicit inline specifier.
Apr 19 2017
Did you run this check over the llvm/clang code base?
Apr 12 2017
Apr 4 2017
Mar 30 2017
only check C++ code; only match operators that can have alternative representations
Put 'u' and 'l' on integer literals
Updated for comments
Mar 28 2017
Improved diagnostic; updated documentation; added test for overloaded operator
Mar 27 2017
Mar 25 2017
Rename check to readability-operators-representation
Add suffix for floating point literals; clang-format
Added test to misc; minor wording
Mar 24 2017
Thank you for the comments; all of them have been addressed.
Thanks for your feedback, Eugene!