Page MenuHomePhabricator

mgehre (Matthias Gehre)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2015, 1:40 PM (190 w, 5 d)

Recent Activity

Thu, May 23

mgehre committed rGb087129b5d3b: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type… (authored by mgehre).
[clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type…
Thu, May 23, 10:48 PM
mgehre committed rCTE361601: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type….
[clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type…
Thu, May 23, 10:48 PM
mgehre committed rL361601: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type….
[clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type…
Thu, May 23, 10:48 PM
mgehre closed D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init.
Thu, May 23, 10:48 PM · Restricted Project, Restricted Project

Tue, May 14

mgehre committed rCTE360698: [clang-tidy] Fix invalid fixit for readability-static-accessed-through-instance….
[clang-tidy] Fix invalid fixit for readability-static-accessed-through-instance…
Tue, May 14, 11:22 AM
mgehre committed rG094584cd522b: [clang-tidy] Fix invalid fixit for readability-static-accessed-through-instance… (authored by mgehre).
[clang-tidy] Fix invalid fixit for readability-static-accessed-through-instance…
Tue, May 14, 11:21 AM
mgehre committed rL360698: [clang-tidy] Fix invalid fixit for readability-static-accessed-through-instance….
[clang-tidy] Fix invalid fixit for readability-static-accessed-through-instance…
Tue, May 14, 11:21 AM
mgehre closed D61874: [clang-tidy] Fix invalid fixit for readability-static-accessed-through-instance (bug 40544).
Tue, May 14, 11:21 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 13

mgehre created D61874: [clang-tidy] Fix invalid fixit for readability-static-accessed-through-instance (bug 40544).
Mon, May 13, 2:44 PM · Restricted Project, Restricted Project, Restricted Project
mgehre updated the diff for D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init.

Fix wrong merge of ReleaseNotes

Mon, May 13, 2:38 PM · Restricted Project, Restricted Project
mgehre updated the diff for D61749: [clang-tidy] initial version of readability-static-const-method.

Remove `const` part from this PR. Address comments.

Mon, May 13, 2:33 PM · Restricted Project, Restricted Project
mgehre added inline comments to D61749: [clang-tidy] initial version of readability-static-const-method.
Mon, May 13, 2:33 PM · Restricted Project, Restricted Project
mgehre abandoned D22476: [AST] Make MemberExpr non-dependent according to core issue 224.
Mon, May 13, 12:37 PM
mgehre added a comment to D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init.

Do I wait for @alexfh to turn his red into a green, too?

Mon, May 13, 12:37 PM · Restricted Project, Restricted Project
mgehre requested changes to D43745: Fix cppcoreguidelines-pro-bounds-pointer-arithmetic not working for functions with auto return specifier..
Mon, May 13, 12:26 PM · Restricted Project, Restricted Project
mgehre committed rG5f9afe953dea: [clang-tidy] readability-redundant-declaration: fix false positive with C… (authored by mgehre).
[clang-tidy] readability-redundant-declaration: fix false positive with C…
Mon, May 13, 12:20 PM
mgehre committed rL360613: [clang-tidy] readability-redundant-declaration: fix false positive with C….
[clang-tidy] readability-redundant-declaration: fix false positive with C…
Mon, May 13, 12:19 PM
mgehre committed rCTE360613: [clang-tidy] readability-redundant-declaration: fix false positive with C….
[clang-tidy] readability-redundant-declaration: fix false positive with C…
Mon, May 13, 12:19 PM
mgehre closed D61700: [clang-tidy] readability-redundant-declaration: fix false positive with C "extern inline".
Mon, May 13, 12:19 PM · Restricted Project, Restricted Project

Sun, May 12

mgehre added inline comments to D61749: [clang-tidy] initial version of readability-static-const-method.
Sun, May 12, 11:21 PM · Restricted Project, Restricted Project

Fri, May 10

mgehre added a comment to D61749: [clang-tidy] initial version of readability-static-const-method.

I have thought about splitting the check into separate static & const, but kept it together because
the analysis for both cases is very similar, i.e. finding the usage of this.

Fri, May 10, 1:39 PM · Restricted Project, Restricted Project

Thu, May 9

mgehre added a reviewer for D61700: [clang-tidy] readability-redundant-declaration: fix false positive with C "extern inline": aaron.ballman.
Thu, May 9, 12:19 PM · Restricted Project, Restricted Project
mgehre created D61749: [clang-tidy] initial version of readability-static-const-method.
Thu, May 9, 12:06 PM · Restricted Project, Restricted Project

Wed, May 8

mgehre created D61700: [clang-tidy] readability-redundant-declaration: fix false positive with C "extern inline".
Wed, May 8, 2:09 PM · Restricted Project, Restricted Project
mgehre updated the diff for D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init.

Implement review comments

Wed, May 8, 1:24 PM · Restricted Project, Restricted Project
mgehre added a comment to D18914: [clang-tidy] new readability-redundant-inline.

Thank you for the review input! After learning about inlinehint, I don't feel its worthwhile for me to continue this check.

Wed, May 8, 12:01 PM
mgehre abandoned D18914: [clang-tidy] new readability-redundant-inline.
Wed, May 8, 12:01 PM

Jul 27 2018

mgehre resigned from D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros.
Jul 27 2018, 12:18 PM
mgehre added a comment to D43745: Fix cppcoreguidelines-pro-bounds-pointer-arithmetic not working for functions with auto return specifier..

Does it also work with lambdas (being implicitly auto) that return pointers? A test case for that would be nice.

Jul 27 2018, 12:12 PM · Restricted Project, Restricted Project

Nov 10 2017

mgehre added a comment to D39815: [clang-tidy] Improve the commented out variable in UnusedParametersCheck.

I would be against make this the default. Maybe provide it as an option?

Nov 10 2017, 1:07 PM · Restricted Project

Jul 20 2017

mgehre updated the diff for D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init.

Implemented all review comments
Use global settings "UseAssignment"

Jul 20 2017, 10:43 PM · Restricted Project, Restricted Project

Jul 12 2017

mgehre committed rL307759: CFG: Add CFGElement for automatic variables that leave the scope.
CFG: Add CFGElement for automatic variables that leave the scope
Jul 12 2017, 12:05 AM
mgehre closed D15031: CFG: Add CFGElement for automatic variables that leave the scope by committing rL307759: CFG: Add CFGElement for automatic variables that leave the scope.
Jul 12 2017, 12:04 AM

Jun 23 2017

mgehre added a comment to D16403: Add scope information to CFG.

Please consider also https://reviews.llvm.org/D15031
It already handles all possible control flows. Instead of ScopeBegin and ScopeEnd,
it introduces LifetimeEnds elements. It's a more specific in that is also
correctly models the order of lifetime expiry of variables and the order
or destructor calls / lifetime ending.

Jun 23 2017, 6:25 AM · Restricted Project

Jun 2 2017

mgehre added a comment to D33841: [clang-tidy] redundant keyword check.

Please have a look at the discussion in https://reviews.llvm.org/D18914 (which is for a similar check)
It turns out that an inline specifier which is redundant for deciding linkage is still
used to drive the inliner. Basically, the inliner will consider larger function bodies for inlining
if the have an explicit inline specifier.

Jun 2 2017, 10:49 AM · Restricted Project

Apr 19 2017

mgehre added inline comments to D32222: [clang-tidy] Add misc-for-loop-iterator-invalidation check..
Apr 19 2017, 12:06 PM · Restricted Project
mgehre added a comment to D32222: [clang-tidy] Add misc-for-loop-iterator-invalidation check..

Did you run this check over the llvm/clang code base?

Apr 19 2017, 11:59 AM · Restricted Project

Apr 12 2017

mgehre added inline comments to D31887: [clangd] Add documentation page.
Apr 12 2017, 3:11 PM · Restricted Project

Apr 4 2017

mgehre committed rL299465: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438).
[clang-format] fix crash in NamespaceEndCommentsFixer (PR32438)
Apr 4 2017, 1:23 PM
mgehre closed D31441: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438) by committing rL299465: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438).
Apr 4 2017, 1:23 PM

Mar 30 2017

mgehre updated the diff for D31308: [clang-tidy] new check readability-no-alternative-tokens.

only check C++ code; only match operators that can have alternative representations

Mar 30 2017, 12:10 PM
mgehre added a comment to D15031: CFG: Add CFGElement for automatic variables that leave the scope.

Friendly ping

Mar 30 2017, 11:40 AM
mgehre updated the diff for D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init.

Put 'u' and 'l' on integer literals

Mar 30 2017, 11:39 AM · Restricted Project, Restricted Project
mgehre updated the diff for D31441: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438).

Updated for comments

Mar 30 2017, 11:10 AM

Mar 28 2017

mgehre added inline comments to D31308: [clang-tidy] new check readability-no-alternative-tokens.
Mar 28 2017, 3:07 PM
mgehre updated the diff for D31308: [clang-tidy] new check readability-no-alternative-tokens.

Improved diagnostic; updated documentation; added test for overloaded operator

Mar 28 2017, 3:07 PM
mgehre created D31441: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438).
Mar 28 2017, 2:13 PM

Mar 27 2017

mgehre added inline comments to D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros.
Mar 27 2017, 1:08 PM
mgehre committed rL298880: Add [[clang::suppress(rule, ...)]] attribute.
Add [[clang::suppress(rule, ...)]] attribute
Mar 27 2017, 12:58 PM
mgehre closed D24886: Add [[clang::suppress(rule, ...)]] attribute by committing rL298880: Add [[clang::suppress(rule, ...)]] attribute.
Mar 27 2017, 12:57 PM

Mar 25 2017

mgehre added inline comments to D31370: [clang-tidy] Prototype to check for exception specification.
Mar 25 2017, 2:45 PM
mgehre added a comment to D18914: [clang-tidy] new readability-redundant-inline.

Friendly ping

Mar 25 2017, 2:27 PM
mgehre updated the diff for D31308: [clang-tidy] new check readability-no-alternative-tokens.

Rename check to readability-operators-representation

Mar 25 2017, 2:24 PM
mgehre added inline comments to D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init.
Mar 25 2017, 2:20 PM · Restricted Project, Restricted Project
mgehre updated the diff for D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init.

Add suffix for floating point literals; clang-format

Mar 25 2017, 2:19 PM · Restricted Project, Restricted Project
mgehre updated the diff for D24886: Add [[clang::suppress(rule, ...)]] attribute.

Added test to misc; minor wording

Mar 25 2017, 2:18 PM

Mar 24 2017

mgehre updated the diff for D24886: Add [[clang::suppress(rule, ...)]] attribute.

Thank you for the comments; all of them have been addressed.

Mar 24 2017, 4:55 AM
mgehre added a comment to D31308: [clang-tidy] new check readability-no-alternative-tokens.

Thanks for your feedback, Eugene!

Mar 24 2017, 4:17 AM
mgehre added a comment to D22476: [AST] Make MemberExpr non-dependent according to core issue 224.

Friendly ping

Mar 24 2017, 3:57 AM

Mar 23 2017

mgehre created D31308: [clang-tidy] new check readability-no-alternative-tokens.
Mar 23 2017, 2:15 PM

Mar 17 2017

mgehre updated the diff for D24886: Add [[clang::suppress(rule, ...)]] attribute.

Update for review comments

Mar 17 2017, 3:19 PM
mgehre committed rL298126: Implement DR 373 "Lookup on namespace qualified name in using-directive".
Implement DR 373 "Lookup on namespace qualified name in using-directive"
Mar 17 2017, 2:53 PM
mgehre closed D30848: Implement DR 373 "Lookup on namespace qualified name in using-directive" by committing rL298126: Implement DR 373 "Lookup on namespace qualified name in using-directive".
Mar 17 2017, 2:53 PM

Mar 15 2017

mgehre updated the diff for D30848: Implement DR 373 "Lookup on namespace qualified name in using-directive".

Improve diagnostics and add tests for them.

Mar 15 2017, 4:16 PM

Mar 10 2017

mgehre updated the diff for D30848: Implement DR 373 "Lookup on namespace qualified name in using-directive".

Added clang version to test and regenerated cxx_dr_status.html

Mar 10 2017, 3:00 PM
mgehre updated the diff for D30848: Implement DR 373 "Lookup on namespace qualified name in using-directive".

clang-format

Mar 10 2017, 2:33 PM
mgehre created D30848: Implement DR 373 "Lookup on namespace qualified name in using-directive".
Mar 10 2017, 2:27 PM
mgehre added a comment to D15031: CFG: Add CFGElement for automatic variables that leave the scope.

I'm sorry for the long delay!

Mar 10 2017, 10:59 AM
mgehre updated the diff for D15031: CFG: Add CFGElement for automatic variables that leave the scope.

Handle back-patches gotos and add test case
Turned LocalScope::const_iterator::shared_parent from O(N^2) into O(N) time
The combination with AddImplicitDtors will be added in a separate patch

Mar 10 2017, 10:44 AM

Mar 8 2017

mgehre added inline comments to D30746: [clang-tidy] new check for throw expressions in destructors.
Mar 8 2017, 1:06 PM

Mar 4 2017

mgehre updated the diff for D22476: [AST] Make MemberExpr non-dependent according to core issue 224.

Updated fix for the crash in SemaChecking::RefersToMemberWithReducedAlignment,
so it also works for C code.

Mar 4 2017, 2:59 PM
mgehre added inline comments to D22476: [AST] Make MemberExpr non-dependent according to core issue 224.
Mar 4 2017, 2:15 PM
mgehre updated the diff for D22476: [AST] Make MemberExpr non-dependent according to core issue 224.

Thanks for your comments! I'm very sorry for the huge delay. I have now more time to work on this.
I added all your comments to the commit
and fixed a crash in SemaChecking::RefersToMemberWithReducedAlignment,
when the base is an InjectedClassNameType (because it assumed that it can only be a RecordType).

Mar 4 2017, 2:15 PM

Mar 1 2017

mgehre abandoned D22587: [ASTContext] Fix part of DR224 for nontype template arguments.
Mar 1 2017, 12:39 PM

Jan 24 2017

mgehre added a comment to D22587: [ASTContext] Fix part of DR224 for nontype template arguments.

Ping

Jan 24 2017, 2:34 PM

Jan 6 2017

mgehre added a comment to D20693: [clang-tidy] New checker to replace dynamic exception specifications.

I'm working on code bases where their is no manually written noexcept(false) anywhere,
and I don't think the FixIt should look different than manually written code.
At least a configuration option for the check would be nice.

Jan 6 2017, 12:44 PM
mgehre added a comment to D20693: [clang-tidy] New checker to replace dynamic exception specifications.

Hi,
this is a good idea for a check.

Jan 6 2017, 11:22 AM

Oct 30 2016

mgehre added a comment to D26125: [clang-tidy] Fixed readability-else-after-return for cascade statements.

With this fix, is there still a warning on the following code?

if(b) {
   ...
   if(c)
    return;
   else
    doSomething()
   ...
}

I would expect that the check still warns on it.

Oct 30 2016, 12:26 PM

Oct 23 2016

mgehre added inline comments to D24886: Add [[clang::suppress(rule, ...)]] attribute.
Oct 23 2016, 3:19 PM

Oct 20 2016

mgehre added inline comments to D24888: [clang-tidy] Use [[clang::suppress]] with cppcoreguidelines-pro-type-reinterpret-cast.
Oct 20 2016, 10:56 AM

Sep 29 2016

mgehre updated the diff for D24886: Add [[clang::suppress(rule, ...)]] attribute.

Add additional gsl::suppress spelling, add test, add documentation

Sep 29 2016, 10:37 PM

Sep 28 2016

mgehre added a comment to D24886: Add [[clang::suppress(rule, ...)]] attribute.

My main goal is to be able to suppress any clang-tidy warning through an attribute. Initially, I though we could reuse the C++ Core Guidelines attribute for that,
(because I though it was plain [[suppress]]). As a bonus (not more), we would have interoperability with other C++ Core Guideline checkers.

Sep 28 2016, 2:31 PM
mgehre committed rL282625: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init….
[clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init…
Sep 28 2016, 1:15 PM
mgehre closed D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers by committing rL282625: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init….
Sep 28 2016, 1:15 PM
mgehre added a comment to D24886: Add [[clang::suppress(rule, ...)]] attribute.

In the C++ Core Guidelines issue on namespaceing of the [[suppress]], it was state that Microsoft uses
[[gsl::suppress]] and it is the intent to update the C++ Core Guidelines to [[gsl::suppress]].

Sep 28 2016, 11:30 AM
mgehre added inline comments to D24888: [clang-tidy] Use [[clang::suppress]] with cppcoreguidelines-pro-type-reinterpret-cast.
Sep 28 2016, 11:23 AM
mgehre added a comment to D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers.

I would like to close that particular bug report, and thus I would like to have the reproducer of that bug as part of the test case.
The PositivePartiallyInClassInitialized is also a good test, but I fail to see how it is proves that that particular bug is solved.

Sep 28 2016, 10:48 AM

Sep 27 2016

mgehre updated the diff for D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers.

Rename the struct that was introduced in the test. Note that I need to keep the function Bug30487,
because that is where the false-positive warning was emitted.

Sep 27 2016, 11:05 AM
mgehre added a comment to D24886: Add [[clang::suppress(rule, ...)]] attribute.

Thank your very much for your comments!
Let me try to give me reasoning for those points:

Sep 27 2016, 10:55 AM

Sep 24 2016

mgehre updated the diff for D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init.

Extend test to negative case

Sep 24 2016, 3:04 PM · Restricted Project, Restricted Project
mgehre retitled D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init from to [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init.
Sep 24 2016, 2:56 PM · Restricted Project, Restricted Project
mgehre added a comment to D22587: [ASTContext] Fix part of DR224 for nontype template arguments.

I'm sorry if this sounds dumb, but is there a way for me to follow that particular discussion?

Sep 24 2016, 2:20 PM
mgehre committed rL282330: [clang-tidy] fix for NOLINT after macro expansion.
[clang-tidy] fix for NOLINT after macro expansion
Sep 24 2016, 9:15 AM
mgehre closed D24845: [clang-tidy] fix for NOLINT after macro expansion by committing rL282330: [clang-tidy] fix for NOLINT after macro expansion.
Sep 24 2016, 9:15 AM

Sep 23 2016

mgehre updated D24886: Add [[clang::suppress(rule, ...)]] attribute.
Sep 23 2016, 2:58 PM
mgehre updated the diff for D24886: Add [[clang::suppress(rule, ...)]] attribute.

Include link to corresponding clang-tidy patch

Sep 23 2016, 2:58 PM
mgehre updated the diff for D24888: [clang-tidy] Use [[clang::suppress]] with cppcoreguidelines-pro-type-reinterpret-cast.

Minor fix

Sep 23 2016, 2:57 PM
mgehre retitled D24888: [clang-tidy] Use [[clang::suppress]] with cppcoreguidelines-pro-type-reinterpret-cast from to [clang-tidy] Use [[clang::suppress]] with cppcoreguidelines-pro-type-reinterpret-cast.
Sep 23 2016, 2:54 PM
mgehre retitled D24886: Add [[clang::suppress(rule, ...)]] attribute from to Add [[clang::suppress(rule, ...)]] attribute.
Sep 23 2016, 2:39 PM

Sep 22 2016

mgehre retitled D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers from to [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers.
Sep 22 2016, 2:45 PM