Page MenuHomePhabricator

DmitryPolukhin (Dmitry Polukhin)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 13 2015, 7:20 AM (253 w, 15 h)

Recent Activity

Jul 29 2020

DmitryPolukhin accepted D84850: [clang-tidy] Fix module options being registered with different priorities.

Thank you for identifying and fixing!

Jul 29 2020, 8:09 AM · Restricted Project
DmitryPolukhin added inline comments to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .
Jul 29 2020, 5:56 AM · Restricted Project, Restricted Project

Jul 9 2020

DmitryPolukhin added a comment to D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

@aaron.ballman - thank you for the review!

Jul 9 2020, 2:43 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin committed rG9e7fddbd36f5: [yaml][clang-tidy] Fix multiline YAML serialization (authored by DmitryPolukhin).
[yaml][clang-tidy] Fix multiline YAML serialization
Jul 9 2020, 2:42 AM
DmitryPolukhin closed D80301: [yaml][clang-tidy] Fix multiline YAML serialization.
Jul 9 2020, 2:42 AM · Restricted Project, Restricted Project, Restricted Project

Jul 8 2020

DmitryPolukhin added a comment to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.

I don't understand what do you mean by "not idempotent" behavior in this case. As far as I can see GlobalIFunc doesn't implement own getBaseObject (and it is not virtual) so calling getBaseObject on the IFunc should return null same as calling it on Alias-to-IFunc. Calling getbaseObject on Alias-to-IFunc will recursively call it on IFunc that will return null that will be propagated, isn't it? So in my opinion computeAliasSummary should handle null without crash because other places have checks for null returned from getBaseObject.

Jul 8 2020, 4:20 AM · Restricted Project

Jul 7 2020

DmitryPolukhin added a comment to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.

I did a bit of archeology and it turns out that getBaseObejct was part of moved from GlobalAlias to GlobalIndirectSymbol in https://github.com/llvm/llvm-project/commit/95549497ec8b5269f0439f12859537b7371b7c90
It looks like the simplest solution is to handle nullptr from getBaseObejct in computeAliasSummary...

Jul 7 2020, 1:20 PM · Restricted Project
DmitryPolukhin added inline comments to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.
Jul 7 2020, 12:38 PM · Restricted Project
DmitryPolukhin added a comment to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.

getBaseObject is only small part of code sharing, the majority of the code is outside the class in common code that handles both GlobalIFunc and GlobalAliases in the same way. Here they should be treated differently so, IMHO, there is no need in changing the inheritance but GlobalIFunc should be handles as a special case here.

Jul 7 2020, 12:33 PM · Restricted Project

Jul 6 2020

DmitryPolukhin added a comment to D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

@njames93 and @aaron.ballman - please take a look to this diff. Multiline replacements in YAML are broken and cannot be applied correctly.

Jul 6 2020, 3:03 AM · Restricted Project, Restricted Project, Restricted Project

Jun 24 2020

DmitryPolukhin added a comment to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.

Doesn't that mean that GlobalIFunc shouldn't really inherit from GlobalIndirectSymbol (and then GlobalIndirectSymbol loses the justification for its existence)?
I get the feeling like there's an expectation for getBaseObject to be idempotent (since it pierces through ConstantExprs and GlobalAliases), but GlobalIndirectSymbol::getBaseObject takes the resolver (getOperand(0)) and performs the lookup on it.

Jun 24 2020, 5:54 AM · Restricted Project
DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Fix test

Jun 24 2020, 5:54 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a comment to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.

I added a test case that exercises the crash before the fix.
However, your comment made me realize that there are two separate issues + one question here:

  1. getBaseObject() is currently unable to indirect through GlobalIFuncs (as the current fix tries to address).
  2. computeAliasSummary() assumes that getBaseObject() can never return nullptr, while it has potential flows that return nullptr. In Verifier::visitGlobalAlias() I see that aliases-to-ConstantExpr-s are valid, but in Verifier::visitAliaseeSubExpr I see that alias cycles are invalid. If we assume that the module for which we generate a summary is valid, this question amounts to whether it is valid for the ConstantExpr case of an alias to ever return nullptr there. I can add an assert(Aliasee) / fatal(..) in computeAliasSummary.
  3. Is it valid for a GlobalIFunc to have an alias as its resolver function operand? It sounds contrived, but valid nonetheless (e.g. if the resolver is in a different translation unit and they end up getting merged in LTO?). A GlobalIFunc with a resolver that is itself a GlobalIFunc sounds like an invalid construction to me, though. I don't see references to GlobalIFunc in Verifier.cpp to use as guiding principles for what would be considered valid. So, it sounds to me that with respect to module validity, in an alias-...-alias-ifunc-alias-...-resolverfunc chain there should only ever be a single ifunc at most.

Regardless, changing the findBaseObject implementation to take a set of GlobalIndirectSymbols and uniformizing that handling sounds like a fine alternative to the currently proposed fix, depending (?) on the points I raised above.

My knowledge of IFunc details is pretty thin. Adding @DmitryPolukhin who ported over ifunc support from gcc and might be able to provide some guidance. I agree it makes sense to have the use in computeAliasSummary check for the null with an assert. And if the usage you describe in 3 is illegal, it would be good to have the verifier check for this.

Jun 24 2020, 4:17 AM · Restricted Project
DmitryPolukhin retitled D80301: [yaml][clang-tidy] Fix multiline YAML serialization from [yaml][clang-tidy] Fix new line YAML serialization to [yaml][clang-tidy] Fix multiline YAML serialization.
Jun 24 2020, 3:12 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the summary of D80301: [yaml][clang-tidy] Fix multiline YAML serialization.
Jun 24 2020, 3:12 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Use double quotation for multiline strings. It solves problems with internal newlines because now they are escaped. Also double quotation solves the problem with leading whitespace after newline. In case of single quotation YAML parsers should remove leading whitespace according to specification. In case of double quotation these leading are internal space and they are preserved. There is no way to instruct YAML parsers to preserve leading whitespaces after newline so double quotation is the only viable option that solves all problems at once.

Jun 24 2020, 3:12 AM · Restricted Project, Restricted Project, Restricted Project

Jun 19 2020

DmitryPolukhin added a comment to D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

It looks like there is no support for the proposed solution so I found alternative solution that might be even better. We can use double quotation " for multiline strings. It solves problem because in case of double quotation LLVM escapes new line like \n so there is no need to double newlines. Escaped newlines can be parsed correctly by other YAML parsers like pyyaml. BTW, LLVM YAML reading also has issue with not removing leading spaces for multiline strings so multiline strings serialised by pyyaml with single quotation cannot be parsed correctly by clang-apply-replacements. With double quotation it seems to work fine in both directions.

Jun 19 2020, 9:12 AM · Restricted Project, Restricted Project, Restricted Project

Jun 18 2020

DmitryPolukhin added a comment to D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

@njames93 - friendly ping, could you please take another look.

Jun 18 2020, 10:18 AM · Restricted Project, Restricted Project, Restricted Project

Jun 16 2020

DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Rebase

Jun 16 2020, 3:28 PM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin accepted D81949: [clang-tidy] Extend InheritParentConfig to CommandLineConfig.

LGTM

Jun 16 2020, 3:23 PM · Restricted Project

Jun 15 2020

DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

As an afterthought, Would you think it a good idea to extend this logic to the ConfigOptionsProvider That way you can use something along the lines of:

clang-tidy --config='{InheritParentConfig: true, CheckOptions: [<Options overriding/complimenting .clang-tidy files>]}'

clang-tidy would then go to read the .clang-tidy configuration files in much the same was as is done here. This would let you set custom configuration options on the command line on top of whats in configuration files.
Obviously is InheritParentConfig is unset or false then we wouldn't go looking for .clang-tidy files.

Jun 15 2020, 10:23 AM · Restricted Project, Restricted Project
DmitryPolukhin committed rGc98c94d85f85: [clang-tidy] Add diagnostics level to YAML output (authored by DmitryPolukhin).
[clang-tidy] Add diagnostics level to YAML output
Jun 15 2020, 8:08 AM
DmitryPolukhin closed D79285: [clang-tidy] Add diagnostics level to YAML output.
Jun 15 2020, 8:07 AM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D79285: [clang-tidy] Add diagnostics level to YAML output.

@aaron.ballman thank you for review and quick response!

Jun 15 2020, 8:07 AM · Restricted Project, Restricted Project
DmitryPolukhin added inline comments to D79285: [clang-tidy] Add diagnostics level to YAML output.
Jun 15 2020, 5:56 AM · Restricted Project, Restricted Project
DmitryPolukhin added a reviewer for D79285: [clang-tidy] Add diagnostics level to YAML output: aaron.ballman.

@alexfh, @gribozavr2, @aaron.ballman - friendly ping, please take a look to this diff. It is just trivial implementation of TODO in the code.

Jun 15 2020, 3:46 AM · Restricted Project, Restricted Project

Jun 12 2020

DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Rebase

Jun 12 2020, 3:45 AM · Restricted Project, Restricted Project, Restricted Project

Jun 11 2020

DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Fix single new line handling, it should be replace with space

Jun 11 2020, 12:40 PM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2020

DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Fix spelling

Jun 5 2020, 4:22 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added inline comments to D80301: [yaml][clang-tidy] Fix multiline YAML serialization.
Jun 5 2020, 4:22 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Rewrite input string split too

Jun 5 2020, 4:22 AM · Restricted Project, Restricted Project, Restricted Project

Jun 4 2020

DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Apply suggested changes with string split

Jun 4 2020, 1:51 PM · Restricted Project, Restricted Project, Restricted Project

Jun 2 2020

DmitryPolukhin added reviewers for D80301: [yaml][clang-tidy] Fix multiline YAML serialization: Eugene.Zelenko, thegameg.

+ @gribozavr, @Eugene.Zelenko, @thegameg who touched/reviewed this code, please take a look.

Jun 2 2020, 3:19 AM · Restricted Project, Restricted Project, Restricted Project

May 20 2020

DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Fixed second string after new line + more test case

May 20 2020, 1:11 PM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Fix clang-tidy warnings

May 20 2020, 10:22 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a comment to D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value.

Sent D80301 for review.

May 20 2020, 9:16 AM · Restricted Project
DmitryPolukhin updated the summary of D80301: [yaml][clang-tidy] Fix multiline YAML serialization.
May 20 2020, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin created D80301: [yaml][clang-tidy] Fix multiline YAML serialization.
May 20 2020, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a comment to D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value.

@mgehre @yvvan it seems that the issue still not fixed and '\n' gets duplicated in the replacements. Are you going to fix this issue or I should create a patch to fix it?
Before this change '\n' was actually processed correctly ReplacementText: '#include <utility>\n\n' is actually replacement text with two new lines in standard YAML deserialiser.

May 20 2020, 6:29 AM · Restricted Project

May 15 2020

DmitryPolukhin added a comment to D79285: [clang-tidy] Add diagnostics level to YAML output.

@alexfh and @gribozavr2 friendly ping could you please take a look

May 15 2020, 3:02 AM · Restricted Project, Restricted Project

May 2 2020

DmitryPolukhin created D79285: [clang-tidy] Add diagnostics level to YAML output.
May 2 2020, 3:08 AM · Restricted Project, Restricted Project

Apr 17 2020

DmitryPolukhin committed rGa7afb211dc46: [clang][AST] Support AST files larger than 512M (authored by DmitryPolukhin).
[clang][AST] Support AST files larger than 512M
Apr 17 2020, 6:28 AM
DmitryPolukhin closed D76594: [clang][AST] Support AST files larger than 512M.
Apr 17 2020, 6:27 AM · Restricted Project

Apr 16 2020

DmitryPolukhin updated the diff for D76594: [clang][AST] Support AST files larger than 512M.

Comments resolved

Apr 16 2020, 4:10 PM · Restricted Project
DmitryPolukhin added inline comments to D76594: [clang][AST] Support AST files larger than 512M.
Apr 16 2020, 4:10 PM · Restricted Project
DmitryPolukhin updated the diff for D76594: [clang][AST] Support AST files larger than 512M.

Split TypeOffsets to low/high parts too

Apr 16 2020, 11:08 AM · Restricted Project
DmitryPolukhin reopened D76594: [clang][AST] Support AST files larger than 512M.
Apr 16 2020, 10:35 AM · Restricted Project
DmitryPolukhin added a reverting change for rG30d5946db95f: [clang][AST] Support AST files larger than 512M: rGa8f85da9f538: Revert "[clang][AST] Support AST files larger than 512M".
Apr 16 2020, 9:29 AM
DmitryPolukhin committed rGa8f85da9f538: Revert "[clang][AST] Support AST files larger than 512M" (authored by DmitryPolukhin).
Revert "[clang][AST] Support AST files larger than 512M"
Apr 16 2020, 9:29 AM
DmitryPolukhin added a comment to D76594: [clang][AST] Support AST files larger than 512M.

I am not sure, but maybe this patch causes an undefined behavior?
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/40472/steps/check-clang%20ubsan/logs/stdio

/b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:6327:28: runtime error: load of misaligned address 0x7feac40a55bc for type 'const uint64_t' (aka 'const unsigned long'), which requires 8 byte alignment
0x7feac40a55bc: note: pointer points here
  00 00 00 00 a3 c7 01 00  00 00 00 00 0c c8 01 00  00 00 00 00 29 c8 01 00  00 00 00 00 7a cc 01 00
              ^ 
    #0 0x3be2fe4 in clang::ASTReader::TypeCursorForIndex(unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:6327:28
    #1 0x3be30a0 in clang::ASTReader::readTypeRecord(unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:6348:24
    #2 0x3bd3d4a in clang::ASTReader::GetType(unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:6985:26
    ...

(I am in the blamelist too of that build, so that's why I am sniffing.)

Apr 16 2020, 9:27 AM · Restricted Project
DmitryPolukhin committed rG30d5946db95f: [clang][AST] Support AST files larger than 512M (authored by DmitryPolukhin).
[clang][AST] Support AST files larger than 512M
Apr 16 2020, 7:49 AM
DmitryPolukhin closed D76594: [clang][AST] Support AST files larger than 512M.
Apr 16 2020, 7:49 AM · Restricted Project

Apr 15 2020

DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

@thakis, I don't see this bot on LLVM http://lab.llvm.org:8011/console
Windows bots there still fail due to cmake issues. The issue is very real and thank you for pointing out but how should I find the bot?

Apr 15 2020, 12:36 PM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

@thakis sorry, I didn't notice the issue because of massive breakage with diff landed just be bore mine and also cmake issues on Windows bots. Thank you for trying to fix it.

Apr 15 2020, 12:36 PM · Restricted Project, Restricted Project
DmitryPolukhin committed rGcb1ee34e9d32: [clang-tidy] Optional inheritance of file configs from parent directories  (authored by DmitryPolukhin).
[clang-tidy] Optional inheritance of file configs from parent directories 
Apr 15 2020, 7:07 AM
DmitryPolukhin closed D75184: [clang-tidy] Optional inheritance of file configs from parent directories .
Apr 15 2020, 7:06 AM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D76594: [clang][AST] Support AST files larger than 512M.

@sammccall thank you for review!
I'll wait for one more day for additional feedback if any, and land this diff.

Apr 15 2020, 2:41 AM · Restricted Project
DmitryPolukhin updated the diff for D76594: [clang][AST] Support AST files larger than 512M.

Fix nit

Apr 15 2020, 2:41 AM · Restricted Project
DmitryPolukhin updated the diff for D76594: [clang][AST] Support AST files larger than 512M.

Split BitOffset in DeclOffset in high/low parts; rebase

Apr 15 2020, 2:41 AM · Restricted Project
DmitryPolukhin updated the diff for D76594: [clang][AST] Support AST files larger than 512M.

Split BitOffset in DeclOffset in high/low parts; rebase

Apr 15 2020, 2:41 AM · Restricted Project

Apr 14 2020

DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

And one more time :(

Apr 14 2020, 10:44 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

One more try to remove useless lint issues

Apr 14 2020, 8:32 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Remove clang-format errors in diff

Apr 14 2020, 8:00 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Comments resolved + rebase

Apr 14 2020, 8:00 AM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

@alexfh thank you for review!

Apr 14 2020, 8:00 AM · Restricted Project, Restricted Project

Apr 13 2020

DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

@alexfh friend ping, please take a look.

Apr 13 2020, 3:44 AM · Restricted Project, Restricted Project

Apr 2 2020

DmitryPolukhin added a comment to D76594: [clang][AST] Support AST files larger than 512M.

@rsmith, @dexonsmith, @jdoerfert could you please take a look to this diff?
If you think that there are other reviewers who might have more context AST persistence, please add them.

Apr 2 2020, 9:44 AM · Restricted Project
DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

@alexfh friendly ping
I implemented solution with priorities to resolve your concerns about get() vs getLocalOrGlobal()
Could you please take another look to this diff?

Apr 2 2020, 9:12 AM · Restricted Project, Restricted Project

Apr 1 2020

DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Use options priority instead of overriding local options by global

Apr 1 2020, 10:26 AM · Restricted Project, Restricted Project

Mar 30 2020

DmitryPolukhin added inline comments to D76594: [clang][AST] Support AST files larger than 512M.
Mar 30 2020, 12:30 PM · Restricted Project

Mar 29 2020

DmitryPolukhin updated the diff for D76594: [clang][AST] Support AST files larger than 512M.

Rebase, all tests passes locally

Mar 29 2020, 6:54 AM · Restricted Project

Mar 28 2020

DmitryPolukhin updated the diff for D76594: [clang][AST] Support AST files larger than 512M.

Resolve merge conflict, revert clang-format for ASTBitCodes.h to avoid further conflicts, use C++ cast

Mar 28 2020, 11:49 AM · Restricted Project
DmitryPolukhin updated the diff for D76594: [clang][AST] Support AST files larger than 512M.

Use 64-bit offsets for TypesOffsests and DeclOffsests

Mar 28 2020, 8:04 AM · Restricted Project
DmitryPolukhin retitled D76594: [clang][AST] Support AST files larger than 512M from [clang][AST] User relative offsets inside AST file to [clang][AST] Support AST files larger than 512M.
Mar 28 2020, 8:04 AM · Restricted Project

Mar 23 2020

DmitryPolukhin added a comment to D76594: [clang][AST] Support AST files larger than 512M.

This looks reasonable to me, though I'm not familiar enough with the code to do a good review.

Just wanted to confirm my understanding: the problematic offsets that are now section-relative instead of file-relative are only used in two sections of the file (macro directives and sloc entries). These sections seem likely to be small relative to others that hold e.g. the AST. So this should raise the effective size limit by a lot, more likely 100x than 5?

Mar 23 2020, 12:00 PM · Restricted Project
DmitryPolukhin updated the diff for D76594: [clang][AST] Support AST files larger than 512M.

clang-format for ASTBitCodes.h

Mar 23 2020, 3:15 AM · Restricted Project
DmitryPolukhin abandoned D76295: [clang][AST] Use 64 bit integers for bit offsets inside AST file.

Relative 32-bit offsets in https://reviews.llvm.org/D76594

Mar 23 2020, 2:10 AM · Restricted Project
DmitryPolukhin created D76594: [clang][AST] Support AST files larger than 512M.
Mar 23 2020, 2:10 AM · Restricted Project

Mar 20 2020

DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

There's one more thing to consider: just by looking at the name of a local option we don't know whether it will be read using get() or getLocalOrGlobal(). By removing local options we may introduce an even more surprising behavior than without this special treatment. WDYT?

Mar 20 2020, 3:46 AM · Restricted Project, Restricted Project

Mar 17 2020

DmitryPolukhin added a comment to D76295: [clang][AST] Use 64 bit integers for bit offsets inside AST file.

Hello Dmitry! Could we use varints instead of uint64_t if size on disk is a concern?

Mar 17 2020, 11:16 AM · Restricted Project
DmitryPolukhin created D76295: [clang][AST] Use 64 bit integers for bit offsets inside AST file.
Mar 17 2020, 10:10 AM · Restricted Project

Mar 16 2020

DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

@alexfh could you please take another look to the diff?
All comments resolved.

Mar 16 2020, 5:52 AM · Restricted Project, Restricted Project

Mar 10 2020

DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Applied suggested changes

Mar 10 2020, 9:46 AM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

How are local and global options handled.
From what I can gather it will read the value as 1 as the local option is checked first no matter which file it was defined in.

Mar 10 2020, 8:06 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Handle global options

Mar 10 2020, 8:06 AM · Restricted Project, Restricted Project

Mar 9 2020

DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Also updated rst file

Mar 9 2020, 5:20 AM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

@alexfh could you please take another look, I added more tests and updated the doc.

Mar 9 2020, 5:20 AM · Restricted Project, Restricted Project

Mar 5 2020

DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Comments resolved, please take another look.

Mar 5 2020, 6:01 AM · Restricted Project, Restricted Project

Mar 4 2020

DmitryPolukhin added a comment to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Friendly ping, please take a look.

Mar 4 2020, 4:02 AM · Restricted Project, Restricted Project
DmitryPolukhin added reviewers for D75184: [clang-tidy] Optional inheritance of file configs from parent directories : klimek, hokein.
Mar 4 2020, 3:59 AM · Restricted Project, Restricted Project

Feb 27 2020

DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Fix issue with config inheritance and caching configs

Feb 27 2020, 7:48 AM · Restricted Project, Restricted Project

Feb 26 2020

DmitryPolukhin updated the diff for D75184: [clang-tidy] Optional inheritance of file configs from parent directories .

Rebase on top of master

Feb 26 2020, 9:12 AM · Restricted Project, Restricted Project
DmitryPolukhin created D75184: [clang-tidy] Optional inheritance of file configs from parent directories .
Feb 26 2020, 8:23 AM · Restricted Project, Restricted Project

Jan 29 2020

DmitryPolukhin added a comment to D73300: [clang-tidy] Add library for clang-tidy main function.

@thakis I'm sorry sorry if it was not clear. Please let me know if you still prefer to have separate directory for clangTidyMain to have only one target per CMakeLists.txt.

Jan 29 2020, 8:07 AM · Restricted Project, Restricted Project

Jan 27 2020

DmitryPolukhin added inline comments to D73300: [clang-tidy] Add library for clang-tidy main function.
Jan 27 2020, 7:43 AM · Restricted Project, Restricted Project

Jan 24 2020

DmitryPolukhin committed rG3f8b100e94b5: [clang-tidy] Add library for clang-tidy main function (authored by DmitryPolukhin).
[clang-tidy] Add library for clang-tidy main function
Jan 24 2020, 1:04 PM
DmitryPolukhin closed D73300: [clang-tidy] Add library for clang-tidy main function.
Jan 24 2020, 1:04 PM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D73300: [clang-tidy] Add library for clang-tidy main function.

Added #include "ClangTidyMain.h" in ClangTidyMain.cpp

Jan 24 2020, 10:13 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D73300: [clang-tidy] Add library for clang-tidy main function.

Updated comment per review suggestion.

Jan 24 2020, 9:37 AM · Restricted Project, Restricted Project

Jan 23 2020

DmitryPolukhin committed rG301a437250b0: [clang-tidy] Add clang-tidy headers to clang distribution (authored by DmitryPolukhin).
[clang-tidy] Add clang-tidy headers to clang distribution
Jan 23 2020, 4:31 PM