Page MenuHomePhabricator

DmitryPolukhin (Dmitry Polukhin)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 13 2015, 7:20 AM (385 w, 1 d)

Recent Activity

Fri, Mar 17

DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@dyung I cannot reproduce this issue on two different machines in both cases tests work fine. For clang and llvm-jitlink binaries (the only binaries used in the tests) my changes are non-functional and I didn't change anything in compiler-rt or ORC. Are you able to reproduce the crashes locally?

Fri, Mar 17, 3:31 PM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or revert if you need time to investigate?

Fri, Mar 17, 12:33 PM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a comment to rG482d22d05a4a: [clang][test] Fix -DBUILD_SHARED_LIBS build by adding depency on MC from….

@asb thank you for fixing it!

Fri, Mar 17, 8:50 AM · Restricted Project, Restricted Project
DmitryPolukhin committed rGd60d3455eb2b: [clangd] Move standard options adaptor to CommandMangler (authored by DmitryPolukhin).
[clangd] Move standard options adaptor to CommandMangler
Fri, Mar 17, 3:27 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin closed D143436: [clangd] Move standard options adaptor to CommandMangler.
Fri, Mar 17, 3:26 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 16

DmitryPolukhin committed rGb293c6280d06: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth (authored by DmitryPolukhin).
[clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth
Thu, Mar 16, 2:32 AM · Restricted Project, Restricted Project
DmitryPolukhin closed D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth.
Thu, Mar 16, 2:31 AM · Restricted Project, Restricted Project

Wed, Mar 15

DmitryPolukhin updated the summary of D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth.
Wed, Mar 15, 3:54 PM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth.

Is there a way to test this?

Wed, Mar 15, 3:52 PM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth.

Test added

Wed, Mar 15, 3:48 PM · Restricted Project, Restricted Project
DmitryPolukhin updated the summary of D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth.
Wed, Mar 15, 10:56 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the summary of D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth.
Wed, Mar 15, 10:56 AM · Restricted Project, Restricted Project
DmitryPolukhin requested review of D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth.
Wed, Mar 15, 10:53 AM · Restricted Project, Restricted Project

Tue, Mar 14

DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@kadircet could you please take another look?
I had to update diff to make it work when LLVM is configured without X86 targets so they are not valid and thus not injected into the command line.

Tue, Mar 14, 11:17 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Update test to use any available target

Tue, Mar 14, 4:35 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin reopened D143436: [clangd] Move standard options adaptor to CommandMangler.
Tue, Mar 14, 4:35 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 13

DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

Had to revert this diff temporary due to broken ARM builds. It seems that X86 targets are disabled for that bots so tests are not passing. I'll fix upload new version for review.

Mon, Mar 13, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a reverting change for rG34de7da6246c: [clangd] Move standard options adaptor to CommandMangler: rG2a84c53ccdc0: Revert "[clangd] Move standard options adaptor to CommandMangler".
Mon, Mar 13, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin committed rG2a84c53ccdc0: Revert "[clangd] Move standard options adaptor to CommandMangler" (authored by DmitryPolukhin).
Revert "[clangd] Move standard options adaptor to CommandMangler"
Mon, Mar 13, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a reverting change for D143436: [clangd] Move standard options adaptor to CommandMangler: rG2a84c53ccdc0: Revert "[clangd] Move standard options adaptor to CommandMangler".
Mon, Mar 13, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin committed rG34de7da6246c: [clangd] Move standard options adaptor to CommandMangler (authored by DmitryPolukhin).
[clangd] Move standard options adaptor to CommandMangler
Mon, Mar 13, 6:11 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin closed D143436: [clangd] Move standard options adaptor to CommandMangler.
Mon, Mar 13, 6:10 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Mar 10

DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Fix test on Windows

Fri, Mar 10, 1:54 PM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@kadircet thank you for the review! Please take another look.

Fri, Mar 10, 8:06 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Comments resolved

Fri, Mar 10, 8:05 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 8

DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@kadircet it is obvious that there is something in this diff that causes this hesitancy in accepting it. I'm ready to keep iterating on the solution but I need a clue what needs the improvement. Please comment.

Wed, Mar 8, 1:09 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 6

DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@kadircet and @nridge friendly ping could you please accept this diff or let me know if you would like to change anything here?
I moved addTargetAndModeForProgramName after SystemIncludeExtractor as was suggested.

Mon, Mar 6, 1:59 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a reviewer for D143436: [clangd] Move standard options adaptor to CommandMangler: nridge.
Mon, Mar 6, 1:57 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a comment to D145228: [clangd] Add clangd headers to install targets.

The install target for clang distributes the clangd static libs

I don't think this was ever intended, looks like an accidental side-effect of using LLVM's many cmake macros.
Can we fix this instead?

Mon, Mar 6, 1:56 AM · Restricted Project, Restricted Project

Fri, Mar 3

DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Rebase

Fri, Mar 3, 5:32 AM · Restricted Project, Restricted Project, Restricted Project

Feb 27 2023

DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@kadircet friendly ping, could you please take a look to this diff?

Feb 27 2023, 2:00 AM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2023

DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

rebase

Feb 26 2023, 1:28 PM · Restricted Project, Restricted Project, Restricted Project

Feb 25 2023

DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Rebase

Feb 25 2023, 1:29 PM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2023

DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Failing tests seems to be just flacky, I was not able to reprocuce any issue with them locally in stress runs and under ASan and TSan

Feb 23 2023, 1:20 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2023

DmitryPolukhin updated the summary of D143436: [clangd] Move standard options adaptor to CommandMangler.
Feb 22 2023, 2:38 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin retitled D143436: [clangd] Move standard options adaptor to CommandMangler from [clangd] Apply standard adaptors to CDBs pushed from LSP to [clangd] Move standard options adaptor to CommandMangler.
Feb 22 2023, 2:36 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Move call addTargetAndModeForProgramName after SystemIncludeExtractor

Feb 22 2023, 2:34 AM · Restricted Project, Restricted Project, Restricted Project

Feb 21 2023

DmitryPolukhin added inline comments to D143436: [clangd] Move standard options adaptor to CommandMangler.
Feb 21 2023, 5:50 AM · Restricted Project, Restricted Project, Restricted Project

Feb 20 2023

DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@nridge @kadircet please take another look, all tests now pass. As for the location of inserting driver mode please see my previous comment about MSVC CL check.

Feb 20 2023, 1:00 PM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Rebase and retest, cannot reproduce test failure locally

Feb 20 2023, 8:49 AM · Restricted Project, Restricted Project, Restricted Project

Feb 16 2023

DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Update test

Feb 16 2023, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@nridge I'm sorry, I pushed version without all tests. Now I added test case for response files, it seems that clangd hasn't had it before this patch.

Feb 16 2023, 2:03 PM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Add test for expanded response files

Feb 16 2023, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Move standard adaptors to CommandMangler

Feb 16 2023, 8:36 AM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2023

DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

That's actually because we model compile commands pushed via LSP as a "fixed compilation database" rather than a json compilation database (you can check the code in parseFixed, near parseJson).
The reason behind the discrepancy between fixed and json compilation databases mostly arises from the fact that the former is written by people specifically to be used by clang-tooling, whereas the latter is usually provided by build system and doesn't necessarily have the same concerns as clang-tooling hence requires certain modifications.

Feb 14 2023, 8:36 AM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2023

DmitryPolukhin added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

Note that D138546 is removing the call to inferTargetAndDriverMode() from GlobalCompilationDatabase.cpp. It adds equivalent logic too CommandMangler which is used for CDBs pushed from LSP as well, so it accomplishes objective of this patch with respect to inferTargetAndDriverMode (but not inferMissingCompileCommands).

Feb 13 2023, 3:49 AM · Restricted Project, Restricted Project, Restricted Project

Feb 7 2023

DmitryPolukhin updated the diff for D143436: [clangd] Move standard options adaptor to CommandMangler.

Fix clang-format sources

Feb 7 2023, 1:57 AM · Restricted Project, Restricted Project, Restricted Project

Feb 6 2023

DmitryPolukhin requested review of D143436: [clangd] Move standard options adaptor to CommandMangler.
Feb 6 2023, 2:39 PM · Restricted Project, Restricted Project, Restricted Project

Oct 12 2022

DmitryPolukhin committed rG5d12b13b0b26: [clang-tidy] Dump effective diagnostics level in YAML output (authored by DmitryPolukhin).
[clang-tidy] Dump effective diagnostics level in YAML output
Oct 12 2022, 2:04 AM · Restricted Project, Restricted Project
DmitryPolukhin closed D135367: [clang-tidy] Dump effective diagnostics level in YAML output.
Oct 12 2022, 2:04 AM · Restricted Project, Restricted Project

Oct 11 2022

DmitryPolukhin added a comment to D135367: [clang-tidy] Dump effective diagnostics level in YAML output.

LGTM, just maybe include a test case where a warning from a clang-tidy check is promoted to an error as well.

Oct 11 2022, 4:28 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D135367: [clang-tidy] Dump effective diagnostics level in YAML output.

Added testcase for clang-tidy diagnostics as with --warnings-as-errors

Oct 11 2022, 4:26 AM · Restricted Project, Restricted Project

Oct 7 2022

DmitryPolukhin added a reviewer for D135367: [clang-tidy] Dump effective diagnostics level in YAML output: aaron.ballman.
Oct 7 2022, 6:15 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D135367: [clang-tidy] Dump effective diagnostics level in YAML output.

Rebase

Oct 7 2022, 4:30 AM · Restricted Project, Restricted Project

Oct 6 2022

DmitryPolukhin requested review of D135367: [clang-tidy] Dump effective diagnostics level in YAML output.
Oct 6 2022, 8:02 AM · Restricted Project, Restricted Project

Sep 20 2022

DmitryPolukhin committed rG41dbee1e6693: [clang] Update ReleaseNotes about a crash fix (Issue 53628) (authored by DmitryPolukhin).
[clang] Update ReleaseNotes about a crash fix (Issue 53628)
Sep 20 2022, 2:07 AM · Restricted Project, Restricted Project
DmitryPolukhin closed D134112: [clang] Update ReleaseNotes about a crash fix (Issue 53628).
Sep 20 2022, 2:07 AM · Restricted Project, Restricted Project

Sep 17 2022

DmitryPolukhin added a comment to D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors.

LGTM! Please add a release note for the fix when you land the changes.

Sep 17 2022, 8:39 AM · Restricted Project, Restricted Project
DmitryPolukhin requested review of D134112: [clang] Update ReleaseNotes about a crash fix (Issue 53628).
Sep 17 2022, 8:35 AM · Restricted Project, Restricted Project
DmitryPolukhin committed rG133b6d7db90d: [clang][C++20] Fix clang/clangd assert/crash after compilation errors (authored by DmitryPolukhin).
[clang][C++20] Fix clang/clangd assert/crash after compilation errors
Sep 17 2022, 7:54 AM · Restricted Project, Restricted Project
DmitryPolukhin closed D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors.
Sep 17 2022, 7:54 AM · Restricted Project, Restricted Project

Sep 15 2022

DmitryPolukhin updated the diff for D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors.

clang-format

Sep 15 2022, 9:03 AM · Restricted Project, Restricted Project
DmitryPolukhin requested review of D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors.
Sep 15 2022, 8:41 AM · Restricted Project, Restricted Project

Feb 3 2022

DmitryPolukhin added a comment to D118755: [clangd] Crash in __memcmp_avx2_movbe.

Overall looks good to me but please re-upload patch on top of some stable revision where failed test passes (it seems unrelated to your changes).

Feb 3 2022, 12:15 PM · Restricted Project, Restricted Project

Jul 30 2021

DmitryPolukhin committed rG8eaa05d06161: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch (authored by ivanmurashko).
[clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch
Jul 30 2021, 2:41 AM
DmitryPolukhin closed D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch.
Jul 30 2021, 2:41 AM · Restricted Project

Jun 30 2021

DmitryPolukhin committed rGfceaf8621179: [clang] Fix UB when string.front() is used for the empty string (authored by DmitryPolukhin).
[clang] Fix UB when string.front() is used for the empty string
Jun 30 2021, 1:16 AM
DmitryPolukhin closed D105120: [clang] Fix UB when string.front() is used for the empty string.
Jun 30 2021, 1:16 AM · Restricted Project, Restricted Project

Jun 29 2021

DmitryPolukhin updated the diff for D105120: [clang] Fix UB when string.front() is used for the empty string.

Fix clang-tidy style warning

Jun 29 2021, 8:48 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D105120: [clang] Fix UB when string.front() is used for the empty string.

Replace tab with spaces

Jun 29 2021, 7:35 AM · Restricted Project, Restricted Project
DmitryPolukhin requested review of D105120: [clang] Fix UB when string.front() is used for the empty string.
Jun 29 2021, 7:34 AM · Restricted Project, Restricted Project

Jun 11 2021

DmitryPolukhin committed rG47d138c93992: [clang-tidy] LIT test fix for Remark diagnostic (authored by ivanmurashko).
[clang-tidy] LIT test fix for Remark diagnostic
Jun 11 2021, 2:04 AM
DmitryPolukhin closed D104021: [clang-tidy] LIT test fix for Remark diagnostic.
Jun 11 2021, 2:03 AM · Restricted Project, Restricted Project

Jun 10 2021

DmitryPolukhin accepted D104021: [clang-tidy] LIT test fix for Remark diagnostic.
LGTM
Jun 10 2021, 4:56 AM · Restricted Project, Restricted Project

Jun 9 2021

DmitryPolukhin added a comment to D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

This needs to explain why the existing functionality isn't sufficient - if the header is really not from this project,
then it should be included via -isystem, and that will naturally suppress all diagnostics from it.

Jun 9 2021, 8:28 AM · Restricted Project, Restricted Project, Restricted Project

Jun 7 2021

DmitryPolukhin committed rGaa0d7179bbb3: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText() (authored by DmitryPolukhin).
[clang] NFC: test for undefined behaviour in RawComment::getFormattedText()
Jun 7 2021, 3:06 AM
DmitryPolukhin closed D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText().
Jun 7 2021, 3:05 AM · Restricted Project
DmitryPolukhin updated the diff for D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText().

Fix clang-tidy warning

Jun 7 2021, 2:12 AM · Restricted Project

Jun 4 2021

DmitryPolukhin requested review of D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText().
Jun 4 2021, 2:54 PM · Restricted Project

Jun 3 2021

DmitryPolukhin added a comment to D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

@bruno and @dexonsmith thank you for the review!

Jun 3 2021, 1:40 AM · Restricted Project
DmitryPolukhin committed rG178ad93e3f1f: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics (authored by DmitryPolukhin).
[clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics
Jun 3 2021, 1:38 AM
DmitryPolukhin closed D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
Jun 3 2021, 1:38 AM · Restricted Project

Jun 2 2021

DmitryPolukhin added inline comments to D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
Jun 2 2021, 2:08 AM · Restricted Project
DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Updated HeaderMapImpl::reverseLookupFilename according to the review comment

Jun 2 2021, 2:06 AM · Restricted Project

Jun 1 2021

DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Rebase + try build on Windows again

Jun 1 2021, 7:05 AM · Restricted Project
DmitryPolukhin added inline comments to D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
Jun 1 2021, 12:55 AM · Restricted Project
DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Resolved comments

Jun 1 2021, 12:54 AM · Restricted Project

May 31 2021

DmitryPolukhin committed rG37b530a2ea8b: [clang] NFC: split HeaderMapTest to have re-usable header map implementation… (authored by DmitryPolukhin).
[clang] NFC: split HeaderMapTest to have re-usable header map implementation…
May 31 2021, 1:58 AM
DmitryPolukhin closed D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing.
May 31 2021, 1:58 AM · Restricted Project

May 27 2021

DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Fix forgotten comment

May 27 2021, 7:42 AM · Restricted Project
DmitryPolukhin updated the summary of D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
May 27 2021, 2:01 AM · Restricted Project
DmitryPolukhin updated subscribers of D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Naively, this sounds like it could be a non-trivial tax on build times. But it looks like it's only called in Clang from Sema::diagnoseMissingImport, which only happens on error anyway.

May 27 2021, 2:00 AM · Restricted Project
DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Split changes into NFC https://reviews.llvm.org/D103229 and the rest

May 27 2021, 1:29 AM · Restricted Project
DmitryPolukhin requested review of D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing.
May 27 2021, 1:17 AM · Restricted Project

May 26 2021

DmitryPolukhin added a comment to D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

@alexfh, @njames93 and @thakis please take a look! I added all tests cases and put new logic behind a flag to make it as safe as possible.
Issue with diagnostics from macro expansion from third-party headers is the one of the biggest problem with deployment that we have and it cannot be properly fixed with wrappers around clang-tidy.

May 26 2021, 8:25 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

Added test for system like object macro

May 26 2021, 8:18 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Fix linter

May 26 2021, 1:54 AM · Restricted Project
DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Fix clang-format issue

May 26 2021, 1:52 AM · Restricted Project
DmitryPolukhin requested review of D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
May 26 2021, 1:50 AM · Restricted Project

May 21 2021

DmitryPolukhin added inline comments to D102906: [clang-tidy] Remark was added to clang tooling Diagnostic.
May 21 2021, 3:23 AM · Restricted Project, Restricted Project