- User Since
- Nov 13 2015, 7:20 AM (187 w, 2 d)
Sep 30 2018
May 17 2017
David, could you please take a look to this patch. It fixes potential issue and should have no side effects. If you have no objections, I'll commit it for Serge.
Apr 24 2017
Oct 5 2016
I think we need to fix this regression.
Sep 26 2016
LGTM, added Richard in case he has something to add.
Sep 21 2016
Committed as rL282059
Sep 20 2016
Richard, please take another look.
Sep 19 2016
Sep 18 2016
Jul 19 2016
Committed as rL275970
Hi Hans, it seems that you've just created release branch for 3.9 and this patch should go directly to the branch, right? If so could you please commit this patch for me because I'm working with git-svn and there is no instruction how to work with release LLVM branches from git so I'm worry that my setup could break things. I'm absolutely fine with moving abi_tag above --build-id. Thanks!
Jul 14 2016
- defer var generation if their type is class with dllimport.
Jul 13 2016
Sorry for delay with patch rework, PTAL!
- added local vftable for constexpr
- added use of imported vftable
Jul 12 2016
Friendly ping, PTAL!
Jul 7 2016
Jul 6 2016
I found the patch that prevents using imported vftable, http://llvm.org/viewvc/llvm-project?view=revision&revision=260548 but the patch has no examples of constexpr + dllimport.
David, do you know real programs that relay on constexpr and dllexport semantic that doesn't work on MSVC? If not, I think we might want to report error message instead of miss-compile it as MSVC does. Anyway current implementation is not compatible with MSVC in much more common case without constexp. At the moment my patch works with your example just because it only changes mangling but don't use imported vftable that seems to be wrong. Is it you changes somewhere that prevent using imported vftable?
Jul 4 2016
Jun 30 2016
Richard, thank you for the review!
Jun 29 2016
Use SmallVector instead of SmallSetVector and sort the vector when needed.
Jun 22 2016
Fixed issue with substitution from function name used in bare type encoding and added test. With this patch Clang passes self build with GCC 5.3.1 headers and C++ libraries so it gives some level of confidence that it works on real apps.
Jun 21 2016
- removed wrong asserts that I used for an experiment
This patch set contains serious refactoring to make it closer to what Richard suggested. Unfortunately there is no way to fully implement Richard's idea because we have to mangle twice name of functions and variables. But this patch reuse mangled bare function type generated during tags calculation.
Jun 7 2016
Jun 3 2016
May 26 2016
It seems that there is no interest in this patch, abandon.
May 23 2016
- drop dllexport for trivial defaulted x-tors for compatibility with MSVC2015
- move checks to CheckCompletedCXXClass because completed class definition is required to detect if x-tor is trivial
Fix test/PCH/attrs.c failure due to warning about unsupported abi_tag attribute (committed in rL269869).
This patch implements abi_tag so the warning is not expected with this patch.
May 19 2016
Comments resolved, PTAL.
One more friendly ping...... :(
May 13 2016
Committed as rL269400
May 12 2016
May 10 2016
Richard, friendly ping. It seems that your counterexample cause no issue with this patch. I added tests to prove it. Could you please take another look?
May 9 2016
- fixed tests for i686 when function may have hidden parameter
May 7 2016
Thank you for reporting this issue, I'll take a look.
I'm mostly testing on x86_64 so I may not notice the problem.
May 6 2016
May 4 2016
+ added testcase with Richard's example
May 3 2016
Richard, could you please share your counterexample so I could test it on my patch and GCC?
Apr 27 2016
Apr 26 2016
Richard, friendly ping, PTAL!
Thank you for the review!
Apr 25 2016
Apr 22 2016
Weekly friendly ping, PTAL!
Apr 15 2016
Richard, this is just weekly friendly ping about abi_tag support.
Apr 14 2016
I added few more negative tests. Thank you for the review!
Apr 13 2016
Apr 11 2016
The patch itself looks good to me but the main question do we want to support VLA in C++ in GNU extension mode.
Sorry, I was out for couple days.
Apr 7 2016
Committed as rL265770
Richard, Reid and David,
- rebase after committing llvm patch
Apr 6 2016
- fixed comments
Committed as rL265530
Apr 5 2016
- fixed all comments
Alexey, please review OpenMP specific things.
Rebased on top of D18754
Apr 4 2016
Apr 1 2016
- implemented ad hoc solution for printing
- added documentation for the attrbute
Mar 31 2016
- rebease on top of GlobalIndirectSymbol committed to LLVM
- removed C interface for ifunc, it seems that it is not required for now
Could you please take a look to OMPDeclareTargetDecl attribute implementation and printPrettyEnd approach in general?
For post print mechanism alternative approach is to use ad hoc solution in DeclPrinter.
Mar 30 2016
- Added test for templates in declare target region
Friendly ping, please take a look! This patch is relatively short and has no functional changes, just class hierarchy preparation.
Friendly ping, please take a look!
Mar 29 2016
Mar 24 2016
Extracted GlobalIndirectSymbol creation to separate patch http://reviews.llvm.org/D18433
Mar 23 2016
Eric, that you for looking to the code! I'll split the patch and send first part for review ASAP.
Mar 14 2016
All comments resolved.
Mar 11 2016
Re-base to resolve merge conflicts with r263109.
Mar 10 2016
Mar 9 2016
Thank you for the comments!
- fixed comments
- rebase with resolving conflicts
Mar 2 2016
Aaron, friendly ping, please take a look!