Page MenuHomePhabricator

DmitryPolukhin (Dmitry Polukhin)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 13 2015, 7:20 AM (341 w, 1 d)

Recent Activity

Feb 3 2022

DmitryPolukhin added a comment to D118755: [clangd] Crash in __memcmp_avx2_movbe.

Overall looks good to me but please re-upload patch on top of some stable revision where failed test passes (it seems unrelated to your changes).

Feb 3 2022, 12:15 PM · Restricted Project, Restricted Project

Jul 30 2021

DmitryPolukhin committed rG8eaa05d06161: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch (authored by ivanmurashko).
[clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch
Jul 30 2021, 2:41 AM
DmitryPolukhin closed D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch.
Jul 30 2021, 2:41 AM · Restricted Project

Jun 30 2021

DmitryPolukhin committed rGfceaf8621179: [clang] Fix UB when string.front() is used for the empty string (authored by DmitryPolukhin).
[clang] Fix UB when string.front() is used for the empty string
Jun 30 2021, 1:16 AM
DmitryPolukhin closed D105120: [clang] Fix UB when string.front() is used for the empty string.
Jun 30 2021, 1:16 AM · Restricted Project, Restricted Project

Jun 29 2021

DmitryPolukhin updated the diff for D105120: [clang] Fix UB when string.front() is used for the empty string.

Fix clang-tidy style warning

Jun 29 2021, 8:48 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D105120: [clang] Fix UB when string.front() is used for the empty string.

Replace tab with spaces

Jun 29 2021, 7:35 AM · Restricted Project, Restricted Project
DmitryPolukhin requested review of D105120: [clang] Fix UB when string.front() is used for the empty string.
Jun 29 2021, 7:34 AM · Restricted Project, Restricted Project

Jun 11 2021

DmitryPolukhin committed rG47d138c93992: [clang-tidy] LIT test fix for Remark diagnostic (authored by ivanmurashko).
[clang-tidy] LIT test fix for Remark diagnostic
Jun 11 2021, 2:04 AM
DmitryPolukhin closed D104021: [clang-tidy] LIT test fix for Remark diagnostic.
Jun 11 2021, 2:03 AM · Restricted Project, Restricted Project

Jun 10 2021

DmitryPolukhin accepted D104021: [clang-tidy] LIT test fix for Remark diagnostic.
LGTM
Jun 10 2021, 4:56 AM · Restricted Project, Restricted Project

Jun 9 2021

DmitryPolukhin added a comment to D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

This needs to explain why the existing functionality isn't sufficient - if the header is really not from this project,
then it should be included via -isystem, and that will naturally suppress all diagnostics from it.

Jun 9 2021, 8:28 AM · Restricted Project, Restricted Project, Restricted Project

Jun 7 2021

DmitryPolukhin committed rGaa0d7179bbb3: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText() (authored by DmitryPolukhin).
[clang] NFC: test for undefined behaviour in RawComment::getFormattedText()
Jun 7 2021, 3:06 AM
DmitryPolukhin closed D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText().
Jun 7 2021, 3:05 AM · Restricted Project
DmitryPolukhin updated the diff for D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText().

Fix clang-tidy warning

Jun 7 2021, 2:12 AM · Restricted Project

Jun 4 2021

DmitryPolukhin requested review of D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText().
Jun 4 2021, 2:54 PM · Restricted Project

Jun 3 2021

DmitryPolukhin added a comment to D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

@bruno and @dexonsmith thank you for the review!

Jun 3 2021, 1:40 AM · Restricted Project
DmitryPolukhin committed rG178ad93e3f1f: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics (authored by DmitryPolukhin).
[clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics
Jun 3 2021, 1:38 AM
DmitryPolukhin closed D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
Jun 3 2021, 1:38 AM · Restricted Project

Jun 2 2021

DmitryPolukhin added inline comments to D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
Jun 2 2021, 2:08 AM · Restricted Project
DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Updated HeaderMapImpl::reverseLookupFilename according to the review comment

Jun 2 2021, 2:06 AM · Restricted Project

Jun 1 2021

DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Rebase + try build on Windows again

Jun 1 2021, 7:05 AM · Restricted Project
DmitryPolukhin added inline comments to D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
Jun 1 2021, 12:55 AM · Restricted Project
DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Resolved comments

Jun 1 2021, 12:54 AM · Restricted Project

May 31 2021

DmitryPolukhin committed rG37b530a2ea8b: [clang] NFC: split HeaderMapTest to have re-usable header map implementation… (authored by DmitryPolukhin).
[clang] NFC: split HeaderMapTest to have re-usable header map implementation…
May 31 2021, 1:58 AM
DmitryPolukhin closed D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing.
May 31 2021, 1:58 AM · Restricted Project

May 27 2021

DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Fix forgotten comment

May 27 2021, 7:42 AM · Restricted Project
DmitryPolukhin updated the summary of D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
May 27 2021, 2:01 AM · Restricted Project
DmitryPolukhin updated subscribers of D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Naively, this sounds like it could be a non-trivial tax on build times. But it looks like it's only called in Clang from Sema::diagnoseMissingImport, which only happens on error anyway.

May 27 2021, 2:00 AM · Restricted Project
DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Split changes into NFC https://reviews.llvm.org/D103229 and the rest

May 27 2021, 1:29 AM · Restricted Project
DmitryPolukhin requested review of D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing.
May 27 2021, 1:17 AM · Restricted Project

May 26 2021

DmitryPolukhin added a comment to D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

@alexfh, @njames93 and @thakis please take a look! I added all tests cases and put new logic behind a flag to make it as safe as possible.
Issue with diagnostics from macro expansion from third-party headers is the one of the biggest problem with deployment that we have and it cannot be properly fixed with wrappers around clang-tidy.

May 26 2021, 8:25 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

Added test for system like object macro

May 26 2021, 8:18 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Fix linter

May 26 2021, 1:54 AM · Restricted Project
DmitryPolukhin updated the diff for D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Fix clang-format issue

May 26 2021, 1:52 AM · Restricted Project
DmitryPolukhin requested review of D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
May 26 2021, 1:50 AM · Restricted Project

May 21 2021

DmitryPolukhin added inline comments to D102906: [clang-tidy] Remark was added to clang tooling Diagnostic.
May 21 2021, 3:23 AM · Restricted Project, Restricted Project

Apr 19 2021

DmitryPolukhin retitled D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers from [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers to [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.
Apr 19 2021, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

Fix wrong character

Apr 19 2021, 7:32 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

Put feature behind flag

Apr 19 2021, 7:29 AM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2021

DmitryPolukhin added a comment to D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

I think there is no sense to invent another HeaderFilterRegex like option to control which headers should be excluded. HeaderFilterRegex should be good enough because if you would like to see warning from the header, most probably you can fix code in the header or at least add a suppression.

Apr 12 2021, 3:31 AM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2021

DmitryPolukhin committed rG338d16275571: [clang-tidy] Ignore all spaces in the list of checks (authored by DmitryPolukhin).
[clang-tidy] Ignore all spaces in the list of checks
Mar 24 2021, 6:44 AM
DmitryPolukhin closed D99180: [clang-tidy] Ignore all spaces in the list of checks.
Mar 24 2021, 6:43 AM · Restricted Project, Restricted Project

Mar 23 2021

DmitryPolukhin updated the diff for D99180: [clang-tidy] Ignore all spaces in the list of checks.

Check exact list of enabled checks

Mar 23 2021, 6:22 AM · Restricted Project, Restricted Project
DmitryPolukhin requested review of D99180: [clang-tidy] Ignore all spaces in the list of checks.
Mar 23 2021, 5:30 AM · Restricted Project, Restricted Project

Mar 15 2021

DmitryPolukhin committed rGda55af7f1d34: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers (authored by DmitryPolukhin).
[clang-tidy] Enable modernize-concat-nested-namespaces also on headers
Mar 15 2021, 7:38 AM
DmitryPolukhin closed D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers.
Mar 15 2021, 7:37 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers.

Rebase again

Mar 15 2021, 3:41 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin added a comment to D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers.

Is DAG required because the header file warnings are printed in a different order depending on things like platform?

Mar 15 2021, 3:23 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers.

Rebase

Mar 15 2021, 2:01 AM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2021

DmitryPolukhin added a comment to D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers.

@aaron.ballman @alexfh @njames93 - friendly ping, please take a look!

Mar 9 2021, 1:17 AM · Restricted Project, Restricted Project, Restricted Project

Feb 27 2021

DmitryPolukhin updated the diff for D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers.

Use -DAG checks to make test stable

Feb 27 2021, 3:53 AM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2021

DmitryPolukhin added a comment to D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers.

@njames93 thank you for quick response and good suggestion!

Feb 26 2021, 10:18 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers.

Comments resolved

Feb 26 2021, 10:15 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin requested review of D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers.
Feb 26 2021, 9:31 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2021

DmitryPolukhin added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

@shixiao do you have plans to keep working on this diff? If not, do you have any objections if I send for review a similar diff that will eliminate the check Sources.isInMainFile and will rely on generic header filtration mechanism in clang-tidy?

Feb 22 2021, 5:25 AM · Restricted Project

Feb 10 2021

DmitryPolukhin added inline comments to D76594: [clang][AST] Support AST files larger than 512M.
Feb 10 2021, 9:26 AM · Restricted Project

Jan 10 2021

DmitryPolukhin added a comment to D94166: Make the recursive behavior of getBaseObject uniform for GlobalIndirectSymbols.

I investigated this issue a bit under debugger. It seems that there are multiple places where resolver is used as "base" object for ifunc and resolver attributes like comdat are applied to ifunc itself. It is reasonable for aliases but not for ifunc. Unfortunately it is not something that can be changed easily. The proposal with deriving GlobalIFunc from GlobalObject makes more sense to me now.

Jan 10 2021, 1:11 PM · Restricted Project

Jan 9 2021

DmitryPolukhin requested changes to D94166: Make the recursive behavior of getBaseObject uniform for GlobalIndirectSymbols.

Oh, it seems that LTO is already relay on getBaseObject from ifunc :(

Jan 9 2021, 12:01 PM · Restricted Project

Jan 6 2021

DmitryPolukhin accepted D94166: Make the recursive behavior of getBaseObject uniform for GlobalIndirectSymbols.

I think it should fix immediate problem that we have and makes things more consistent in general.

Jan 6 2021, 3:20 AM · Restricted Project

Nov 18 2020

DmitryPolukhin added a comment to D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

@njames93 thank you for the feedback!

Nov 18 2020, 4:23 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.
  • addressed comments in the diff
  • stop ignoring system macro
Nov 18 2020, 4:19 AM · Restricted Project, Restricted Project, Restricted Project

Nov 5 2020

DmitryPolukhin updated the diff for D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.

Fix clang-tidy warning

Nov 5 2020, 7:40 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin requested review of D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers.
Nov 5 2020, 3:23 AM · Restricted Project, Restricted Project, Restricted Project

Nov 4 2020

DmitryPolukhin added a comment to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..

Sorry, I don't think it's worth reverting and resubmitting the same changes in such a case. Commit attribution is correct and there is link to this code review.
After all, most clang-tidy users will never read commit messages and will only use --help for discovering this feature.

Nov 4 2020, 4:35 AM · Restricted Project, Restricted Project

Nov 3 2020

DmitryPolukhin added a comment to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..

Hello @@DmitryPolukhin ,

When I submitted latest via 'arc diff' my commit-message was...
Can you please help to have following commit message? Below commit message is more clear and helpful.
Sorry for inconvenience caused!

Nov 3 2020, 8:59 AM · Restricted Project, Restricted Project
DmitryPolukhin committed rGd6a468d622b2: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file. (authored by Hiralo).
[clang-tidy] adding "--config-file=<file-path>" to specify custom config file.
Nov 3 2020, 4:02 AM
DmitryPolukhin closed D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..
Nov 3 2020, 4:01 AM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..

When this patch will be merged and available in master?

Nov 3 2020, 1:40 AM · Restricted Project, Restricted Project

Oct 30 2020

DmitryPolukhin accepted D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..

Looks good to me.

Oct 30 2020, 8:27 AM · Restricted Project, Restricted Project

Oct 29 2020

DmitryPolukhin added inline comments to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..
Oct 29 2020, 4:52 AM · Restricted Project, Restricted Project
DmitryPolukhin added inline comments to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..
Oct 29 2020, 4:37 AM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..

It's also be nice if --config-file would also support being passed a directory. If a directory was passed it would append ".clang-tidy" to the path and load that file, WDYT?

Oct 29 2020, 4:35 AM · Restricted Project, Restricted Project
DmitryPolukhin added inline comments to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..
Oct 29 2020, 3:13 AM · Restricted Project, Restricted Project

Oct 28 2020

DmitryPolukhin added a comment to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..

I think this diff looks very close to what we need. I hope it will be the last iteration.

Oct 28 2020, 3:29 AM · Restricted Project, Restricted Project

Oct 27 2020

DmitryPolukhin added inline comments to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..
Oct 27 2020, 10:17 AM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..

Yes, it is what I meant as a simpler solution. But please add Lit test even for such trivial option.

Oct 27 2020, 8:38 AM · Restricted Project, Restricted Project
DmitryPolukhin added a comment to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..

@Hiralo, it looks like you uploaded wrong diff because your previous revision is shown as "base" version. Base revision should be clang-tidy sources without your changes.

Oct 27 2020, 3:57 AM · Restricted Project, Restricted Project

Oct 26 2020

DmitryPolukhin added a comment to D89936: [clang-tidy] adding "--config-file=<file-path>" to specify custom config file..

I'm not sure that we need additional option to read configuration from file but, if we do need, I think this diff needs some improvements + test for new option.

Oct 26 2020, 3:15 AM · Restricted Project, Restricted Project

Oct 23 2020

DmitryPolukhin committed rG55a2deed075b: [clang-tidy] Fix redefinition of module in the same module.modulemap file (authored by DmitryPolukhin).
[clang-tidy] Fix redefinition of module in the same module.modulemap file
Oct 23 2020, 5:21 AM
DmitryPolukhin closed D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file.
Oct 23 2020, 5:20 AM · Restricted Project, Restricted Project

Oct 22 2020

DmitryPolukhin added a comment to D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file.

Ah, btw, any chance of adding a test for this?

Oct 22 2020, 7:56 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file.

Added all module map file names

Oct 22 2020, 7:54 AM · Restricted Project, Restricted Project
DmitryPolukhin added a reviewer for D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file: benlangmuir.
Oct 22 2020, 6:58 AM · Restricted Project, Restricted Project

Oct 21 2020

DmitryPolukhin added a reviewer for D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file: bruno.
Oct 21 2020, 9:22 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file.

And one more time linting

Oct 21 2020, 8:09 AM · Restricted Project, Restricted Project
DmitryPolukhin updated the diff for D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file.

Linting diff

Oct 21 2020, 8:07 AM · Restricted Project, Restricted Project
DmitryPolukhin requested review of D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file.
Oct 21 2020, 7:59 AM · Restricted Project, Restricted Project

Jul 29 2020

DmitryPolukhin accepted D84850: [clang-tidy] Fix module options being registered with different priorities.

Thank you for identifying and fixing!

Jul 29 2020, 8:09 AM · Restricted Project
DmitryPolukhin added inline comments to D75184: [clang-tidy] Optional inheritance of file configs from parent directories .
Jul 29 2020, 5:56 AM · Restricted Project, Restricted Project

Jul 9 2020

DmitryPolukhin added a comment to D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

@aaron.ballman - thank you for the review!

Jul 9 2020, 2:43 AM · Restricted Project, Restricted Project, Restricted Project
DmitryPolukhin committed rG9e7fddbd36f5: [yaml][clang-tidy] Fix multiline YAML serialization (authored by DmitryPolukhin).
[yaml][clang-tidy] Fix multiline YAML serialization
Jul 9 2020, 2:42 AM
DmitryPolukhin closed D80301: [yaml][clang-tidy] Fix multiline YAML serialization.
Jul 9 2020, 2:42 AM · Restricted Project, Restricted Project, Restricted Project

Jul 8 2020

DmitryPolukhin added a comment to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.

I don't understand what do you mean by "not idempotent" behavior in this case. As far as I can see GlobalIFunc doesn't implement own getBaseObject (and it is not virtual) so calling getBaseObject on the IFunc should return null same as calling it on Alias-to-IFunc. Calling getbaseObject on Alias-to-IFunc will recursively call it on IFunc that will return null that will be propagated, isn't it? So in my opinion computeAliasSummary should handle null without crash because other places have checks for null returned from getBaseObject.

Jul 8 2020, 4:20 AM · Restricted Project

Jul 7 2020

DmitryPolukhin added a comment to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.

I did a bit of archeology and it turns out that getBaseObejct was part of moved from GlobalAlias to GlobalIndirectSymbol in https://github.com/llvm/llvm-project/commit/95549497ec8b5269f0439f12859537b7371b7c90
It looks like the simplest solution is to handle nullptr from getBaseObejct in computeAliasSummary...

Jul 7 2020, 1:20 PM · Restricted Project
DmitryPolukhin added inline comments to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.
Jul 7 2020, 12:38 PM · Restricted Project
DmitryPolukhin added a comment to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.

getBaseObject is only small part of code sharing, the majority of the code is outside the class in common code that handles both GlobalIFunc and GlobalAliases in the same way. Here they should be treated differently so, IMHO, there is no need in changing the inheritance but GlobalIFunc should be handles as a special case here.

Jul 7 2020, 12:33 PM · Restricted Project

Jul 6 2020

DmitryPolukhin added a comment to D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

@njames93 and @aaron.ballman - please take a look to this diff. Multiline replacements in YAML are broken and cannot be applied correctly.

Jul 6 2020, 3:03 AM · Restricted Project, Restricted Project, Restricted Project

Jun 24 2020

DmitryPolukhin added a comment to D81911: [ThinLTO] Work around getBaseObject returning null for alias-to-ifunc.

Doesn't that mean that GlobalIFunc shouldn't really inherit from GlobalIndirectSymbol (and then GlobalIndirectSymbol loses the justification for its existence)?
I get the feeling like there's an expectation for getBaseObject to be idempotent (since it pierces through ConstantExprs and GlobalAliases), but GlobalIndirectSymbol::getBaseObject takes the resolver (getOperand(0)) and performs the lookup on it.

Jun 24 2020, 5:54 AM · Restricted Project
DmitryPolukhin updated the diff for D80301: [yaml][clang-tidy] Fix multiline YAML serialization.

Fix test

Jun 24 2020, 5:54 AM · Restricted Project, Restricted Project, Restricted Project