Page MenuHomePhabricator

[FPEnv] Divide macro INSTRUCTION into INSTRUCTION and DAG_INSTRUCTION, and macro FUNCTION likewise. NFCI.
ClosedPublic

Authored by pengfei on Jan 16 2020, 1:13 PM.

Details

Summary

Some functions like fmuladd don't really have a node, we should divide the declaration form those have node to avoid introducing fake nodes.

Diff Detail

Event Timeline

craig.topper created this revision.Jan 16 2020, 1:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2020, 1:13 PM

Could you make this a standalone patch that only modifies the table without adding the FP_CONTRACT support? Then the other patch can just be refactored to use this.

pengfei commandeered this revision.Jan 16 2020, 6:43 PM
pengfei edited reviewers, added: craig.topper; removed: pengfei.
pengfei updated this revision to Diff 238682.Jan 16 2020, 6:46 PM

Removed the FP_CONTRACT support code.

pengfei retitled this revision from [FPEnv] Alternative implementation of constrained fmuladd that avoids fmuladd ISD opcodes to [FPEnv] Divide macro INSTRUCTION into INSTRUCTION and DAG_INSTRUCTION, and macro FUNCTION likewise. NFCI..Jan 16 2020, 6:49 PM
pengfei edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jan 23 2020, 9:53 PM
This revision was automatically updated to reflect the committed changes.