Page MenuHomePhabricator

LiuChen3 (LiuChen)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 9 2019, 7:00 PM (12 w, 2 d)

Recent Activity

Sun, Dec 1

LiuChen3 updated the diff for D68757: [X86] Add strict fp support for instructions fadd/fsub/fmul/fdiv.

Adding testcase for scalar_math_patterns and AVX512_scalar_math_fp_patterns.
Moving setOperationAction(ISD::STRICT_FADD/STRICT_FSUB/STRICT_FDIV/STRICT_FMUL, MVT::v2f64, Legal) into SSE2 judgment statement.

Sun, Dec 1, 9:49 PM · Restricted Project

Tue, Nov 26

LiuChen3 updated the diff for D68757: [X86] Add strict fp support for instructions fadd/fsub/fmul/fdiv.

Rebase.
Add option to the tests.

Tue, Nov 26, 9:46 PM · Restricted Project
LiuChen3 commandeered D68757: [X86] Add strict fp support for instructions fadd/fsub/fmul/fdiv.
Tue, Nov 26, 9:46 PM · Restricted Project
LiuChen3 updated the diff for D70706: [X86][NFC] Modify the testcase name.
Tue, Nov 26, 1:29 AM · Restricted Project
LiuChen3 created D70706: [X86][NFC] Modify the testcase name.
Tue, Nov 26, 1:29 AM · Restricted Project
LiuChen3 added inline comments to D68857: [X86] Add strict fp support for operations of X87 instructions.
Tue, Nov 26, 1:02 AM · Restricted Project

Mon, Nov 25

LiuChen3 added inline comments to D68857: [X86] Add strict fp support for operations of X87 instructions.
Mon, Nov 25, 11:39 PM · Restricted Project
LiuChen3 updated the diff for D68857: [X86] Add strict fp support for operations of X87 instructions.

Pengfei has helped me commit the test cases.
I rebase and add the option "-disable-strictnode-mutation" to the test case.

Mon, Nov 25, 11:20 PM · Restricted Project
LiuChen3 added a comment to D68857: [X86] Add strict fp support for operations of X87 instructions.

Please pre-commit the test modifications with the old codegen and rebase this patch.

Mon, Nov 25, 9:06 PM · Restricted Project
LiuChen3 added inline comments to D68857: [X86] Add strict fp support for operations of X87 instructions.
Mon, Nov 25, 9:00 PM · Restricted Project
LiuChen3 updated the diff for D68857: [X86] Add strict fp support for operations of X87 instructions.

Rebase.
STRICT_FP_ROUND has been set as custom so I remove setting it as legal. When entering the custom processing function, if the operand type is legal,the function behaves the same as setOperationAction(ISD:STRICT_FP_ROUND, TYPE, legal)
Modify the test case. Since we do not disable sse, we can pass float-pointer value by register instead of passing by pointer.

Mon, Nov 25, 8:38 PM · Restricted Project
LiuChen3 added inline comments to D68857: [X86] Add strict fp support for operations of X87 instructions.
Mon, Nov 25, 4:37 PM · Restricted Project
LiuChen3 added a comment to D68857: [X86] Add strict fp support for operations of X87 instructions.

The new tests and test renames can be done as an NFC commit - then please rebase this patch

Sorry, I am not clear of what you mean. Do you mean I should make a new patch to add these tests? The tests in my current patch is not just renamed, but also doing functional test. I think it's better to keep them together.
And I think make a new patch to rename the tests is reasonable.

I've updated/added the tests in rG5aaca2355ec2 (matching Craig's changes in rG0cc12b8a8310) - the changes were an NFC cleanup and don't require a new patch. Please can you now rebase?

Mon, Nov 25, 12:05 AM · Restricted Project
LiuChen3 updated the diff for D68857: [X86] Add strict fp support for operations of X87 instructions.

Rebase

Mon, Nov 25, 12:05 AM · Restricted Project

Thu, Nov 21

LiuChen3 added a comment to D68857: [X86] Add strict fp support for operations of X87 instructions.

The new tests and test renames can be done as an NFC commit - then please rebase this patch

Thu, Nov 21, 11:19 PM · Restricted Project
LiuChen3 added a comment to D70226: Add an option to disable strict float node mutating to an normal float node.

Thanks for all of your help.

Thu, Nov 21, 4:37 PM · Restricted Project

Wed, Nov 20

LiuChen3 added a comment to D70226: Add an option to disable strict float node mutating to an normal float node.

@uweigand Thank you, now I get clear of the logic there. I add some of your comment to the original comments in the code, I think it may helps us understand this code better. Or we still keep the previous comments?

Wed, Nov 20, 8:32 PM · Restricted Project
LiuChen3 updated the diff for D70226: Add an option to disable strict float node mutating to an normal float node.

update comments and fix a bug

Wed, Nov 20, 8:23 PM · Restricted Project
LiuChen3 added inline comments to D70226: Add an option to disable strict float node mutating to an normal float node.
Wed, Nov 20, 7:28 AM · Restricted Project
LiuChen3 updated the diff for D70226: Add an option to disable strict float node mutating to an normal float node.

update the comments

Wed, Nov 20, 7:08 AM · Restricted Project
LiuChen3 added a comment to D70226: Add an option to disable strict float node mutating to an normal float node.
Wed, Nov 20, 7:08 AM · Restricted Project

Tue, Nov 19

LiuChen3 added a comment to D70226: Add an option to disable strict float node mutating to an normal float node.

@uweigand Thanks for your help.

Tue, Nov 19, 4:32 PM · Restricted Project
LiuChen3 updated the diff for D70226: Add an option to disable strict float node mutating to an normal float node.

Modify comment

Tue, Nov 19, 4:32 PM · Restricted Project

Mon, Nov 18

LiuChen3 updated the diff for D70226: Add an option to disable strict float node mutating to an normal float node.

Fix format problem.

Mon, Nov 18, 6:46 PM · Restricted Project
LiuChen3 updated the diff for D70226: Add an option to disable strict float node mutating to an normal float node.

Update as comments.

Mon, Nov 18, 6:37 PM · Restricted Project
LiuChen3 added inline comments to D70226: Add an option to disable strict float node mutating to an normal float node.
Mon, Nov 18, 5:09 AM · Restricted Project
LiuChen3 added a comment to D70226: Add an option to disable strict float node mutating to an normal float node.

I'm not sure if there's a possibility: some normal float operations of a backend is not Expand,
but they may think expanding strict-float operation can meet their requirements.
Although I haven't found a case yet.

Mon, Nov 18, 4:25 AM · Restricted Project
LiuChen3 added inline comments to D70226: Add an option to disable strict float node mutating to an normal float node.
Mon, Nov 18, 4:17 AM · Restricted Project
LiuChen3 updated the diff for D70226: Add an option to disable strict float node mutating to an normal float node.

Binding the value of DisableStrictNodeMutation to flag IsStrictFPEnabled, updating as comments.

Mon, Nov 18, 4:08 AM · Restricted Project

Sun, Nov 17

LiuChen3 updated subscribers of D70226: Add an option to disable strict float node mutating to an normal float node.
Sun, Nov 17, 9:25 PM · Restricted Project

Fri, Nov 15

LiuChen3 added a comment to D70226: Add an option to disable strict float node mutating to an normal float node.

@uweigand Thanks for your review. I have added information to see if the target supports strict float, so systemZ can disable strictnode mutation as default.

Fri, Nov 15, 12:55 AM · Restricted Project
LiuChen3 updated the diff for D70226: Add an option to disable strict float node mutating to an normal float node.

This patch add an variable EnableStrictNode to the TargetLoweringBase to determine whether the target already supports the strict float operation.
Modify the patch @uweigand's suggestion.

Fri, Nov 15, 12:46 AM · Restricted Project

Thu, Nov 14

LiuChen3 created D70226: Add an option to disable strict float node mutating to an normal float node.
Thu, Nov 14, 2:40 AM · Restricted Project

Wed, Nov 13

LiuChen3 added a comment to D70214: [X86] Add custom type legalization and lowering for scalar STRICT_FP_TO_SINT/UINT.

I am working on STRICT_FP_TO_SINT/UINT, too. For now, Pengfei and I thought we can set promotion as custom so we can promote the type in x86 without affecting other backend. What do you think?

Wed, Nov 13, 5:53 PM · Restricted Project

Tue, Nov 12

LiuChen3 added a comment to D68857: [X86] Add strict fp support for operations of X87 instructions.

OK, I 'll make a try.

Tue, Nov 12, 9:50 PM · Restricted Project
LiuChen3 updated the diff for D68857: [X86] Add strict fp support for operations of X87 instructions.

Modify the name of tests

Tue, Nov 12, 6:26 PM · Restricted Project
LiuChen3 updated the diff for D68857: [X86] Add strict fp support for operations of X87 instructions.

Modify the name of tests and delete some RUN line in fp80-strict-scalar.ll.

Tue, Nov 12, 6:17 PM · Restricted Project

Mon, Nov 11

LiuChen3 added inline comments to D68857: [X86] Add strict fp support for operations of X87 instructions.
Mon, Nov 11, 9:21 PM · Restricted Project
LiuChen3 updated the diff for D68857: [X86] Add strict fp support for operations of X87 instructions.

Rebase and change the name of tests in fp-strict-scalar.ll . Add a test file which only process 80-bit long double type, because tests for 80-bit FP is complex to put into fp-strict-scalar.ll without changing the '–check-prefix'.

Mon, Nov 11, 8:57 PM · Restricted Project

Nov 3 2019

LiuChen3 added a reviewer for D69784: Set the floating point status register as reserved: RKSimon.
Nov 3 2019, 11:38 PM · Restricted Project
LiuChen3 created D69784: Set the floating point status register as reserved.
Nov 3 2019, 10:52 PM · Restricted Project

Oct 31 2019

LiuChen3 updated the diff for D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions.

This patch fix the broken test: CodeGen/ms-inline-asm.c.

Oct 31 2019, 10:38 PM · Restricted Project, Restricted Project
LiuChen3 commandeered D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions.
Oct 31 2019, 10:34 PM · Restricted Project, Restricted Project
LiuChen3 reopened D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions.
Oct 31 2019, 10:10 PM · Restricted Project, Restricted Project

Oct 29 2019

LiuChen3 added a comment to D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions.

I am sorry I updated two wrong versions. The Diff 226862 is right version.

Oct 29 2019, 3:09 AM · Restricted Project, Restricted Project
LiuChen3 updated the diff for D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions.
Oct 29 2019, 3:09 AM · Restricted Project, Restricted Project
LiuChen3 updated the diff for D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions.

The Diff 226855 has some problems. This one adds testcase to verify if x87 instructions use/def fpcw and fpcw registers.

Oct 29 2019, 3:00 AM · Restricted Project, Restricted Project
LiuChen3 updated the diff for D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions.

Add testcase to verify if x87 instructions use/def fpcw and fpcw registers.

Oct 29 2019, 2:13 AM · Restricted Project, Restricted Project

Oct 28 2019

LiuChen3 added inline comments to D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions.
Oct 28 2019, 8:11 PM · Restricted Project, Restricted Project

Oct 11 2019

LiuChen3 updated the diff for D68857: [X86] Add strict fp support for operations of X87 instructions.
Oct 11 2019, 1:55 AM · Restricted Project

Oct 10 2019

LiuChen3 added inline comments to D68857: [X86] Add strict fp support for operations of X87 instructions.
Oct 10 2019, 10:42 PM · Restricted Project
LiuChen3 added inline comments to D68857: [X86] Add strict fp support for operations of X87 instructions.
Oct 10 2019, 10:23 PM · Restricted Project
LiuChen3 added reviewers for D68857: [X86] Add strict fp support for operations of X87 instructions: cameron.mcinally, craig.topper, RKSimon, andrew.w.kaylor, uweigand, kpn, spatel.
Oct 10 2019, 8:16 PM · Restricted Project
LiuChen3 added reviewers for D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions: craig.topper, RKSimon, andrew.w.kaylor, uweigand, kpn, spatel, cameron.mcinally.
Oct 10 2019, 8:12 PM · Restricted Project, Restricted Project
LiuChen3 created D68857: [X86] Add strict fp support for operations of X87 instructions.
Oct 10 2019, 8:07 PM · Restricted Project
LiuChen3 added a reviewer for D68857: [X86] Add strict fp support for operations of X87 instructions: pengfei.
Oct 10 2019, 8:07 PM · Restricted Project
LiuChen3 retitled D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions from add mayRaiseFPException flag and FPCW registers for X87 instructions to [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions.
Oct 10 2019, 7:53 PM · Restricted Project, Restricted Project
LiuChen3 created D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions.
Oct 10 2019, 7:49 PM · Restricted Project, Restricted Project

Sep 29 2019

LiuChen3 added a comment to D60748: Fix i386 struct and union parameter alignment.
In D60748#1681178, @kib wrote:

In fact, can we have an option controlling this ? Does it have anything to do with -malign-data gcc switch ?

We do want to be able to optionally generate code ABI-compatible with modern gcc, per user discretion.

Sep 29 2019, 12:09 AM · Restricted Project

Sep 18 2019

LiuChen3 commandeered D60748: Fix i386 struct and union parameter alignment.
Sep 18 2019, 8:04 PM · Restricted Project
LiuChen3 updated the diff for D60748: Fix i386 struct and union parameter alignment.
Sep 18 2019, 8:04 PM · Restricted Project