Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Paths

Table of Contentst

[RISCV] Pass target-abi via module flag metadata
ClosedPublic
Actions

Authored by khchen on Jan 15 2020, 2:00 AM.

Details

Reviewers

lenary
asb

Commits

rG01fd650ba3d2: [RISCV] Pass target-abi via module flag metadata
rGe15fb06e2d0a: [RISCV] Pass target-abi via module flag metadata

Summary

in D71387, and this we agree encoding target-abi in module would make sense.
This patch only emit target-abi for RISCV because the first user is probably only the RISC-V target.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

khchen created this revision.Jan 15 2020, 2:00 AM

Herald added subscribers: cfe-commits, luismarques, apazos and 23 others. · View Herald TranscriptJan 15 2020, 2:00 AM

Please can you also add code for ensuring that the target-abi module flag matches the -target-abi command line flag in llvm?

khchen mentioned this in D72768: [RISCV] Check the target-abi module flag matches the -target-abi option.Jan 15 2020, 6:59 AM

In D72755#1821540, @lenary wrote:

Please can you also add code for ensuring that the target-abi module flag matches the -target-abi command line flag in llvm?

please see D72768, thanks!

lenary added a child revision: D72768: [RISCV] Check the target-abi module flag matches the -target-abi option.Jan 20 2020, 5:47 AM

LGTM, Thank You!

This revision is now accepted and ready to land.Jan 20 2020, 7:11 AM

Closed by commit rGe15fb06e2d0a: [RISCV] Pass target-abi via module flag metadata (authored by khchen). · Explain WhyJan 20 2020, 11:46 PM

This revision was automatically updated to reflect the committed changes.

kito-cheng mentioned this in D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V.Sep 5 2022, 8:20 AM

sunshaoce mentioned this in D144330: [MLIR][RISCV] Emit target-abi info for RISC-V.Feb 22 2023, 11:26 PM