Page MenuHomePhabricator

[AMDGPU] Update AMDGPUUsage with DWARF proposal
ClosedPublic

Authored by t-tye on Nov 20 2019, 6:25 PM.

Diff Detail

Event Timeline

t-tye created this revision.Nov 20 2019, 6:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 20 2019, 6:25 PM
t-tye retitled this revision from Update AMDGPUUsage with AMDGPU DWARF proposal and other fixes to [AMDGPU] Update AMDGPUUsage with DWARF proposal and other fixes.Nov 20 2019, 6:44 PM
t-tye updated this revision to Diff 230753.EditedNov 23 2019, 12:16 AM

Add rule for DW_OP_stack_value applied to an implicit pointer value to push an implicit pointer location description.

t-tye updated this revision to Diff 230754.EditedNov 23 2019, 12:32 AM

Move note on supporting any integral value to be implicitly converted to a location description.

Can you split this up?

t-tye updated this revision to Diff 233504.Dec 11 2019, 10:48 PM

Split non-DWARF changes into D71392.

Can you split this up?

@echristo I split the non-DWARF changes into D71392.

t-tye retitled this revision from [AMDGPU] Update AMDGPUUsage with DWARF proposal and other fixes to [AMDGPU] Update AMDGPUUsage with DWARF proposal.Dec 11 2019, 10:54 PM
t-tye edited the summary of this revision. (Show Details)

The proposal seems interesting, but needs some more review.

In the meantime, have you sent it to http://dwarfstd.org/Issues.php ?

t-tye updated this revision to Diff 245473.Wed, Feb 19, 10:59 AM

Add DW_OP_LLVM_call_frame_entry_reg and fix typos

  • Add DW_OP_LLVM_call_frame_entry_reg needed for CFI unwinding of VGPRs that are spilled using the EXEC mask on entry.
  • Remove mention of DW_OP_* that are no longer part of the proposal.
  • Correct some names and other minor typos.
scott.linder accepted this revision.Wed, Feb 19, 12:26 PM

I think this is at a stage where it is OK to commit it to AMDGPUUsage as a draft proposal, to let us iterate on it before actually proposing it to DWARF proper. It is harder to start a discussion about it without a public document describing it, and it seems easier to refer to it in AMDGPUUsage than to refer to a Phabricator review.

This revision is now accepted and ready to land.Wed, Feb 19, 12:26 PM
This revision was automatically updated to reflect the committed changes.

Fair enough. The DWARF committee has a different set of write-up requirements. Let me, aprantl, probinson, or others know if you have issues.