- User Since
- Jan 15 2018, 8:31 AM (66 w, 7 h)
Fri, Apr 19
Wed, Apr 17
Thu, Apr 4
Fri, Mar 29
Thu, Mar 28
Add a test to confirm split-dwarf is supported for the amdhsa OS in the driver.
Mon, Mar 25
Mar 20 2019
LGTM, thanks! One small change to a comment.
Mar 19 2019
LGTM, thanks! I think you can also drop "provides a method for use by LLPC to write metadata into LLVM IR" from the commit message.
Mar 18 2019
Mar 5 2019
Mar 4 2019
Feb 27 2019
After digging a bit more into how we parse/print operands for sopp_br I think there are some more fundamental decisions to make beyond just "do we support signed integers", so I want to avoid changing anything in this patch. I will revisit how we treat them in the future and make any breaking changes all at once, rather than spreading them out.
Feb 22 2019
LGTM then, but like I said I'm not very familiar with GlobalISel so more eyes might be good
Feb 21 2019
Does anyone have an opinion on returning negative branch targets (e.g. <keep_symbol+0xfffffffffffe0018>)? I don't know how this would ever come up in hardware anyway, or what the hardware would do, but it doesn't seem very helpful in the disassembly.
Feb 20 2019
Improved error message.
Address feedback. Sign-extend all s_branch immediates and change the assembler syntax to represent these as true negative numbers.
Feb 19 2019
Feb 12 2019
Feb 11 2019
Feb 8 2019
Feb 5 2019
I think MIR is the best place to look; this now tests that the right pseudo is produced and that spills don't interleave the terminators.
Feb 4 2019
I agree the test does not test much at all, it was just the minimum I could think of considering none of our existing tests notice the change. I'm not sure what pass you mean by 'isel', but 'stop-after=amdgpu-isel' is too early to see the SI_INDIRECT_SRC_* psuedo expanded.
Feb 1 2019
The code looks good to me, but I'm wondering why the move from doing this in AsmPrinter::EmitEndOfAsmFile to TargetStreamer::finish? It seems like it is fine to emit directives in either, but I don't understand why the change here.
Add test for tail call through GOT
LGTM, pending parents of course.
Thank you for updating this! I only have one small suggestion, but otherwise it LGTM.
LGTM, sorry for the delay in reviewing this.
Jan 31 2019
I've tried to implement carrying a copy of the function global through the DAG from the beginning, rather than recovering it after legalizing the GlobalAddress. I don't know if this is a reasonable approach, but I figured I would post something and see what you think.
Jan 30 2019
Jan 29 2019
Jan 28 2019
Jan 18 2019
Update option name
No worries, I agree that we don't gain much with a shorter flag here; explicit seems preferable.
Update option name
Update the -cc1 option name and docs; also update the LangOpt and docs.
Jan 17 2019
Add missing flag to tests
Remove driver options
That sounds reasonable to me. I had already posted a patch with the Driver options, but I will update it to only include the -cc1 version.
Rebase and ping