scott.linder (Scott Linder)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2018, 8:31 AM (30 w, 5 d)

Recent Activity

Mon, Aug 13

scott.linder created D50659: [CodeGen] Fix remaining zext() assertions in SelectionDAG.
Mon, Aug 13, 12:05 PM
scott.linder committed rL339600: [CodeGen] Fix assert in SelectionDAG::computeKnownBits.
[CodeGen] Fix assert in SelectionDAG::computeKnownBits
Mon, Aug 13, 11:45 AM
scott.linder closed D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits.
Mon, Aug 13, 11:45 AM

Wed, Aug 8

scott.linder committed rC339265: [DebugInfo][OpenCL] Address post-commit review for r338299.
[DebugInfo][OpenCL] Address post-commit review for r338299
Wed, Aug 8, 8:56 AM
scott.linder committed rL339265: [DebugInfo][OpenCL] Address post-commit review for r338299.
[DebugInfo][OpenCL] Address post-commit review for r338299
Wed, Aug 8, 8:56 AM
scott.linder closed D50099: [DebugInfo][OpenCL] Address post-commit review of D49930.
Wed, Aug 8, 8:56 AM

Tue, Aug 7

scott.linder updated the diff for D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits.

That sounds fine to me; here is the original patch, with the updated test.

Tue, Aug 7, 1:29 PM
scott.linder committed rL339150: [OpenCL] Restore r338899 (reverted in r338904), fixing stack-use-after-return.
[OpenCL] Restore r338899 (reverted in r338904), fixing stack-use-after-return
Tue, Aug 7, 8:53 AM
scott.linder committed rC339150: [OpenCL] Restore r338899 (reverted in r338904), fixing stack-use-after-return.
[OpenCL] Restore r338899 (reverted in r338904), fixing stack-use-after-return
Tue, Aug 7, 8:53 AM
scott.linder updated the diff for D50099: [DebugInfo][OpenCL] Address post-commit review of D49930.

Address feedback

Tue, Aug 7, 7:57 AM

Mon, Aug 6

scott.linder added inline comments to D50099: [DebugInfo][OpenCL] Address post-commit review of D49930.
Mon, Aug 6, 11:26 AM
scott.linder added a comment to D50099: [DebugInfo][OpenCL] Address post-commit review of D49930.

When I went to mark these as static I noticed they use CGDebugInfo::CreateMemberType which uses a couple other non-static member functions, and it starts to become difficult to tease things out into nice clean static functions.

Mon, Aug 6, 11:14 AM

Fri, Aug 3

scott.linder committed rC338899: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin.
[OpenCL] Always emit alloca in entry block for enqueue_kernel builtin
Fri, Aug 3, 8:51 AM
scott.linder committed rL338899: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin.
[OpenCL] Always emit alloca in entry block for enqueue_kernel builtin
Fri, Aug 3, 8:51 AM
scott.linder closed D50104: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin.
Fri, Aug 3, 8:51 AM

Thu, Aug 2

scott.linder updated the diff for D50104: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin.

Emit lifetime intrinsics for the sizes temp, and update test

Thu, Aug 2, 12:29 PM
scott.linder added a comment to D50104: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin.

I still don't quite see what you describe; with that change all of the lifetime.end calls pile up just before the enclosing function returns, not after each call to enqueue_kernel. Looking at https://clang.llvm.org/doxygen/EHScopeStack_8h_source.html#l00078 I don't see any option which isn't based on scope. The lifetime.start calls do occur where I would expect, though, so I will update the patch.

Thu, Aug 2, 9:41 AM

Wed, Aug 1

scott.linder updated the diff for D50104: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin.

Update test

Wed, Aug 1, 1:31 PM
scott.linder added a comment to D44429: [BinaryFormat] MessagePack reader/writer.

I have the library in BinaryFormat because it is used outside of the AMDGPU backend in tools (currently just llvm-readobj) in https://reviews.llvm.org/D48179

Wed, Aug 1, 12:09 PM
scott.linder updated the diff for D44429: [BinaryFormat] MessagePack reader/writer.

Address feedback

Wed, Aug 1, 12:06 PM
scott.linder added inline comments to D44429: [BinaryFormat] MessagePack reader/writer.
Wed, Aug 1, 12:05 PM
scott.linder updated the diff for D50104: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin.

Address feedback; I hope I understood correctly what debug info to check for.

Wed, Aug 1, 8:27 AM
scott.linder updated the diff for D50099: [DebugInfo][OpenCL] Address post-commit review of D49930.

Add comments to explain OpenCL case

Wed, Aug 1, 6:54 AM

Tue, Jul 31

scott.linder created D50104: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin.
Tue, Jul 31, 2:25 PM
scott.linder created D50099: [DebugInfo][OpenCL] Address post-commit review of D49930.
Tue, Jul 31, 12:43 PM
scott.linder updated the diff for D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits.

I noticed I had assumed AArch64 was available in the unittests, so I updated those to be skipped in the case where it isn't.

Tue, Jul 31, 8:55 AM

Mon, Jul 30

scott.linder committed rC338321: Fix use of uninitialized variable in r338299.
Fix use of uninitialized variable in r338299
Mon, Jul 30, 3:52 PM
scott.linder committed rL338321: Fix use of uninitialized variable in r338299.
Fix use of uninitialized variable in r338299
Mon, Jul 30, 3:52 PM
scott.linder added a comment to D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL.

Sorry, I didn't see the additional comments until after I committed. I will make those changes; is it OK to update this review, or should I create a new one?

Mon, Jul 30, 1:36 PM
scott.linder committed rC338299: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL.
[DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL
Mon, Jul 30, 1:31 PM
scott.linder committed rL338299: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL.
[DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL
Mon, Jul 30, 1:31 PM
scott.linder closed D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL.
Mon, Jul 30, 1:31 PM
scott.linder updated the diff for D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object.

Rebase and ping

Mon, Jul 30, 11:01 AM
scott.linder updated the diff for D48175: [BinaryFormat] Add MsgPackTypes.

Rebase and ping

Mon, Jul 30, 11:01 AM
scott.linder updated the diff for D48144: [Support] Teach YAMLIO about polymorphic types.

Rebase and ping

Mon, Jul 30, 10:59 AM
scott.linder updated the diff for D44429: [BinaryFormat] MessagePack reader/writer.

Rebase and ping

Mon, Jul 30, 10:58 AM
scott.linder added a comment to D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL.

Thank you for taking a look @yaxunl. Should I wait for another reviewer or can I commit this?

Mon, Jul 30, 9:24 AM

Fri, Jul 27

scott.linder created D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL.
Fri, Jul 27, 12:21 PM

Thu, Jul 26

scott.linder committed rL338060: [AMDGPU] Fix VGPR spills where offset doesn't fit in 12 bits.
[AMDGPU] Fix VGPR spills where offset doesn't fit in 12 bits
Thu, Jul 26, 12:48 PM
scott.linder closed D49448: [AMDGPU] Fix VGPR spills where offset doesn't fit in 12 bits.
Thu, Jul 26, 12:48 PM
scott.linder updated the diff for D49448: [AMDGPU] Fix VGPR spills where offset doesn't fit in 12 bits.

Address feedback

Thu, Jul 26, 9:42 AM

Tue, Jul 24

scott.linder updated the diff for D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits.

I have updated the lit test with update_llc_test_checks, updated the condition in TargetLowering to allow for the case where DemandedElts is already wide enough, and added unittests for the cases which trigger the ICE in each function. This is still dependent on my assumptions about the exact semantics of EXTRACT_SUBVECTOR being correct.

Tue, Jul 24, 12:30 PM
scott.linder added inline comments to D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits.
Tue, Jul 24, 9:25 AM

Fri, Jul 20

scott.linder added a comment to D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits.

I can update the test with update_llc_checks, but I'm not sure about testing the other functions. This test case is a minimized version of a test which happened to trigger the assert; to test the others would it be reasonable to use unit tests instead of LLVM IR?

Fri, Jul 20, 12:07 PM
scott.linder updated the diff for D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits.

Addressed feedback; updated other places where DemandedElts is zero extended to the source vector width.

Fri, Jul 20, 10:23 AM

Thu, Jul 19

scott.linder created D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits.
Thu, Jul 19, 3:46 PM
scott.linder updated the diff for D49448: [AMDGPU] Fix VGPR spills where offset doesn't fit in 12 bits.

Add tests for the the boundary condition for subregs.

Thu, Jul 19, 1:23 PM

Jul 19 2018

scott.linder updated the diff for D49448: [AMDGPU] Fix VGPR spills where offset doesn't fit in 12 bits.

Address some more feedback; use -stress-regalloc to cut down on the clobbers needed, add non-kernel tests, explicitly test the increment/decrement case, including the scratch offset SGPR.

Jul 19 2018, 10:23 AM
scott.linder added inline comments to D49448: [AMDGPU] Fix VGPR spills where offset doesn't fit in 12 bits.
Jul 19 2018, 9:57 AM

Jul 18 2018

scott.linder updated the diff for D49448: [AMDGPU] Fix VGPR spills where offset doesn't fit in 12 bits.

Addressed feedback, and added at least one test to exercise the fix and the condition for putting the offset in an SGPR.

Jul 18 2018, 11:56 AM

Jul 17 2018

scott.linder created D49448: [AMDGPU] Fix VGPR spills where offset doesn't fit in 12 bits.
Jul 17 2018, 1:23 PM

Jul 13 2018

scott.linder added a comment to D44429: [BinaryFormat] MessagePack reader/writer.

Ping; the use in AMDGPU's backend is now up on Phabricator.

Jul 13 2018, 2:24 PM
scott.linder retitled D44429: [BinaryFormat] MessagePack reader/writer from [BinaryFormat][RFC] MessagePack reader/writer to [BinaryFormat] MessagePack reader/writer.
Jul 13 2018, 2:23 PM
scott.linder updated the diff for D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object.

Rebase

Jul 13 2018, 2:21 PM
scott.linder abandoned D44806: [AMDGPU] MessagePack reader/writer.

See https://reviews.llvm.org/D44429

Jul 13 2018, 12:57 PM

Jul 10 2018

scott.linder committed rL336722: [AMDGPU] Fix layering issue with AMDGPUHSAMetadataStreamer (NFC).
[AMDGPU] Fix layering issue with AMDGPUHSAMetadataStreamer (NFC)
Jul 10 2018, 1:12 PM
scott.linder committed rL336707: [AMDGPU] Refactor HSAMetadataStream::emitKernel (NFC).
[AMDGPU] Refactor HSAMetadataStream::emitKernel (NFC)
Jul 10 2018, 10:36 AM
scott.linder closed D48176: [AMDGPU] Refactor HSAMetadataStream::emitKernel (NFC).
Jul 10 2018, 10:36 AM

Jun 28 2018

scott.linder added a comment to D26359: Use LiveRangeCalc to extend live ranges in shrinkToUses.

Yes, I had misplaced 10000B.

Jun 28 2018, 2:41 PM
scott.linder added a comment to D26359: Use LiveRangeCalc to extend live ranges in shrinkToUses.

Here is the simplified LIS in my case just before the assert. The failing SubRange is %8273.L00000001 which I believe is %8273.sub0

Jun 28 2018, 12:41 PM

Jun 26 2018

scott.linder added a comment to D26359: Use LiveRangeCalc to extend live ranges in shrinkToUses.

I think I am running into the same bug. I do not have a reduced test case yet, because it appears the bug is triggered due to spilling in my case.

Jun 26 2018, 3:30 PM

Jun 22 2018

scott.linder accepted D48497: AMDHSA: Put old assembler docs back.

LGTM

Jun 22 2018, 10:59 AM

Jun 21 2018

scott.linder committed rL335302: [AMDGPU] Fix lit failures introduced in r335281.
[AMDGPU] Fix lit failures introduced in r335281
Jun 21 2018, 3:34 PM
scott.linder committed rL335281: [AMDGPU] Update assembler for HSA Code Object v3.
[AMDGPU] Update assembler for HSA Code Object v3
Jun 21 2018, 12:43 PM
scott.linder closed D47736: AMDHSA Code Object v3 assembler syntax update.
Jun 21 2018, 12:43 PM
scott.linder committed rL335268: [AMDGPU] Fix bug with tracking processed blocks in SIInsertWaitcnts.
[AMDGPU] Fix bug with tracking processed blocks in SIInsertWaitcnts
Jun 21 2018, 11:53 AM
scott.linder closed D48391: [AMDGPU] Fix bug with tracking processed blocks in SIInsertWaitcnts.
Jun 21 2018, 11:53 AM
scott.linder accepted D48191: AMDGPU/AMDHSA: Remove GridWorkGroupCountX/Y/Z.

LGTM

Jun 21 2018, 11:03 AM

Jun 20 2018

scott.linder created D48391: [AMDGPU] Fix bug with tracking processed blocks in SIInsertWaitcnts.
Jun 20 2018, 1:08 PM

Jun 15 2018

scott.linder added inline comments to D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object.
Jun 15 2018, 10:39 AM
scott.linder updated the diff for D47736: AMDHSA Code Object v3 assembler syntax update.

Address feedback

Jun 15 2018, 9:51 AM
scott.linder updated the diff for D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object.

Address feedback

Jun 15 2018, 9:13 AM

Jun 14 2018

scott.linder added reviewers for D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object: arsenm, t-tye, tpr.
Jun 14 2018, 1:46 PM
scott.linder added a reviewer for D48176: [AMDGPU] Refactor HSAMetadataStream::emitKernel (NFC): arsenm.
Jun 14 2018, 1:46 PM
scott.linder added reviewers for D48175: [BinaryFormat] Add MsgPackTypes: chandlerc, dblaikie.
Jun 14 2018, 1:42 PM
scott.linder added reviewers for D48144: [Support] Teach YAMLIO about polymorphic types: chandlerc, davide.
Jun 14 2018, 1:37 PM
scott.linder added a dependent revision for D47549: [AMDGPU] Update code object metadata format documentation: D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object.
Jun 14 2018, 10:03 AM
scott.linder added dependencies for D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object: D48176: [AMDGPU] Refactor HSAMetadataStream::emitKernel (NFC), D47549: [AMDGPU] Update code object metadata format documentation.
Jun 14 2018, 10:03 AM
scott.linder added a dependent revision for D48176: [AMDGPU] Refactor HSAMetadataStream::emitKernel (NFC): D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object.
Jun 14 2018, 10:03 AM
scott.linder created D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object.
Jun 14 2018, 10:03 AM
scott.linder added a dependency for D48176: [AMDGPU] Refactor HSAMetadataStream::emitKernel (NFC): D48175: [BinaryFormat] Add MsgPackTypes.
Jun 14 2018, 9:44 AM
scott.linder added a dependent revision for D48175: [BinaryFormat] Add MsgPackTypes: D48176: [AMDGPU] Refactor HSAMetadataStream::emitKernel (NFC).
Jun 14 2018, 9:44 AM
scott.linder created D48176: [AMDGPU] Refactor HSAMetadataStream::emitKernel (NFC).
Jun 14 2018, 9:44 AM
scott.linder added a dependent revision for D44429: [BinaryFormat] MessagePack reader/writer: D48144: [Support] Teach YAMLIO about polymorphic types.
Jun 14 2018, 9:41 AM
scott.linder edited dependencies for D48144: [Support] Teach YAMLIO about polymorphic types, added: 1; removed: 1.
Jun 14 2018, 9:41 AM
scott.linder removed a dependent revision for D44806: [AMDGPU] MessagePack reader/writer: D48144: [Support] Teach YAMLIO about polymorphic types.
Jun 14 2018, 9:41 AM
scott.linder added a dependency for D48175: [BinaryFormat] Add MsgPackTypes: D48144: [Support] Teach YAMLIO about polymorphic types.
Jun 14 2018, 9:41 AM
scott.linder added a dependent revision for D48144: [Support] Teach YAMLIO about polymorphic types: D48175: [BinaryFormat] Add MsgPackTypes.
Jun 14 2018, 9:41 AM
scott.linder created D48175: [BinaryFormat] Add MsgPackTypes.
Jun 14 2018, 9:41 AM
scott.linder updated the diff for D47736: AMDHSA Code Object v3 assembler syntax update.

Don't emit v2 kernel symbol type

Jun 14 2018, 9:10 AM

Jun 13 2018

scott.linder added a dependency for D48144: [Support] Teach YAMLIO about polymorphic types: D44806: [AMDGPU] MessagePack reader/writer.
Jun 13 2018, 12:51 PM
scott.linder added a dependent revision for D44806: [AMDGPU] MessagePack reader/writer: D48144: [Support] Teach YAMLIO about polymorphic types.
Jun 13 2018, 12:51 PM
scott.linder created D48144: [Support] Teach YAMLIO about polymorphic types.
Jun 13 2018, 12:50 PM
scott.linder updated the diff for D44429: [BinaryFormat] MessagePack reader/writer.

Style fixes

Jun 13 2018, 12:31 PM

Jun 12 2018

scott.linder updated the diff for D47736: AMDHSA Code Object v3 assembler syntax update.

Rebase, update syntax, expand tests

Jun 12 2018, 1:25 PM
scott.linder added inline comments to D47566: AMDHSA: Code object v3 updates.
Jun 12 2018, 9:08 AM

Jun 7 2018

scott.linder added inline comments to D47566: AMDHSA: Code object v3 updates.
Jun 7 2018, 12:31 PM

Jun 5 2018

scott.linder updated the diff for D47736: AMDHSA Code Object v3 assembler syntax update.

Address feedback

Jun 5 2018, 12:57 PM
scott.linder updated the diff for D47736: AMDHSA Code Object v3 assembler syntax update.

I missed reverting to the original AMDHSAKernelDescriptor.h

Jun 5 2018, 12:23 PM
scott.linder updated the diff for D47736: AMDHSA Code Object v3 assembler syntax update.

Do not output default values when printing .amdhsa_kernel directives

Jun 5 2018, 12:12 PM