Page MenuHomePhabricator

scott.linder (Scott Linder)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2018, 8:31 AM (233 w, 1 d)

Recent Activity

Tue, Jun 28

scott.linder added a comment to D123878: [AMDGPU] Add remarks to output some resource usage.

I will let others comment, but I think this is a perfectly reasonable alternative, and I much prefer using indentation over the delimiter-remark approach. LGTM, assuming nobody else objects

Tue, Jun 28, 10:01 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 23

scott.linder accepted D128210: [AMDGPU][NFC] Correct typo in DWARF Extensions For Heterogeneous Debugging.
Thu, Jun 23, 10:16 AM · Restricted Project, Restricted Project

Fri, Jun 17

scott.linder added inline comments to D127923: [Diagnostics] Accept newline and format diag opts on first line.
Fri, Jun 17, 11:25 AM · Restricted Project, Restricted Project
scott.linder added a comment to D127923: [Diagnostics] Accept newline and format diag opts on first line.

Thank you for the patch! I will leave it to others with more knowledge of the history of diagnostics to comment on whether the premise is acceptable, but I have a few technical comments

Fri, Jun 17, 11:24 AM · Restricted Project, Restricted Project

Thu, Jun 16

scott.linder added reviewers for D128014: [AMDGPU] Improve assembler + disassembler handling of kernel descriptors: kzhuravl, rampitec, rochauha, laurentm0.
Thu, Jun 16, 3:03 PM · Restricted Project, Restricted Project
scott.linder requested review of D128014: [AMDGPU] Improve assembler + disassembler handling of kernel descriptors.
Thu, Jun 16, 3:02 PM · Restricted Project, Restricted Project

Tue, Jun 14

scott.linder added inline comments to D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.
Tue, Jun 14, 10:16 AM · Restricted Project, Restricted Project

Jun 1 2022

scott.linder committed rG2d43955cece3: [AMDGPU][NFC] Refactor AMDGPUCallingConv.td (authored by scott.linder).
[AMDGPU][NFC] Refactor AMDGPUCallingConv.td
Jun 1 2022, 9:25 AM · Restricted Project, Restricted Project
scott.linder closed D109008: [AMDGPU][NFC] Refactor AMDGPUCallingConv.td.
Jun 1 2022, 9:25 AM · Restricted Project, Restricted Project

May 13 2022

scott.linder added a comment to D123878: [AMDGPU] Add remarks to output some resource usage.

I am not sure if allowing clang to accept newlines is a good idea. It seems like clang wants to know what type of message is being outputted. For example whether this is a remark, warning, etc. but allowing for a diagnostic to output their own newline makes it ambiguous where exactly that output is coming from.

May 13 2022, 6:27 PM · Restricted Project, Restricted Project, Restricted Project

May 11 2022

scott.linder added a comment to D123878: [AMDGPU] Add remarks to output some resource usage.

If possible, I would like to keep some kind of delimiter. I like the idea of having it at the beginning and at the end of the section. The best option would be to convince clang to print new lines.

May 11 2022, 1:11 PM · Restricted Project, Restricted Project, Restricted Project

May 2 2022

scott.linder added a comment to D123878: [AMDGPU] Add remarks to output some resource usage.

Even with newlines forced via extra remarks, I'm not a big fan of the "-----------------------" remark; it doesn't interact well with other random remarks in the output, for example when I enable all remarks using the pattern '.*' I see:

remark: foo.cl:27:0: AMDGPU DAG->DAG Pattern Instruction Selection: Function: test_kernel: MI Instruction count changed from 0 to 6; Delta: 6
remark: foo.cl:27:0: 0 stack bytes in function
remark: foo.cl:42:0: AMDGPU DAG->DAG Pattern Instruction Selection: Function: test_func: MI Instruction count changed from 0 to 4; Delta: 4
remark: foo.cl:42:0: 0 stack bytes in function
remark: foo.cl:42:0: SI insert wait instructions: Function: test_func: MI Instruction count changed from 4 to 5; Delta: 1
remark: foo.cl:8:0: AMDGPU DAG->DAG Pattern Instruction Selection: Function: empty_kernel: MI Instruction count changed from 0 to 1; Delta: 1
remark: foo.cl:8:0: 0 stack bytes in function
remark: foo.cl:52:0: AMDGPU DAG->DAG Pattern Instruction Selection: Function: empty_func: MI Instruction count changed from 0 to 1; Delta: 1
remark: foo.cl:52:0: 0 stack bytes in function
remark: foo.cl:52:0: SI insert wait instructions: Function: empty_func: MI Instruction count changed from 1 to 2; Delta: 1
remark: <unknown>:0:0: BasicBlock:
: 2
May 2 2022, 10:53 AM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

scott.linder added inline comments to D123878: [AMDGPU] Add remarks to output some resource usage.
Apr 26 2022, 10:45 AM · Restricted Project, Restricted Project, Restricted Project

Apr 18 2022

scott.linder added inline comments to D123878: [AMDGPU] Add remarks to output some resource usage.
Apr 18 2022, 3:48 PM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2022

scott.linder updated the diff for D109008: [AMDGPU][NFC] Refactor AMDGPUCallingConv.td.

Rebase

Apr 12 2022, 12:56 PM · Restricted Project, Restricted Project

Apr 5 2022

scott.linder committed rG09f33a430b72: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic (authored by scott.linder).
[AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic
Apr 5 2022, 12:11 PM · Restricted Project, Restricted Project, Restricted Project
scott.linder closed D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.
Apr 5 2022, 12:11 PM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

scott.linder added a comment to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

@yaxunl Does excluding device-libs via COV_None make sense?

@sameerds Would you still rather we just not add this attribute in the frontend at all? I'm OK with it if that is the consensus

Yes, I still think there is no need to emit that attribute in the frontend. It will always be inferred by the Attributor when optimization is enabled. This also eliminates the check for COV_None and there seems to be some uncertainty about COV_None anyway. This also eliminates the updates to all the tests where the no-hostcall-ptr attribute does not actually matter. If ever we need to check if hostcall is being used on OpenCL and COV < 5, we should do it per feature and inform the user appropriately.

Mar 29 2022, 10:30 AM · Restricted Project, Restricted Project, Restricted Project
scott.linder updated the diff for D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

Remove frontend changes, and just drop the diagnostic in the backend. Update
some comments and naming.

Mar 29 2022, 10:29 AM · Restricted Project, Restricted Project, Restricted Project
scott.linder abandoned D122669: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.
Mar 29 2022, 10:26 AM · Restricted Project, Restricted Project, Restricted Project
scott.linder requested review of D122669: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.
Mar 29 2022, 10:25 AM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2022

scott.linder accepted D122607: AMDGPU: Delete spills of undef values.

LGTM

Mar 28 2022, 3:37 PM · Restricted Project, Restricted Project
scott.linder added inline comments to D122607: AMDGPU: Delete spills of undef values.
Mar 28 2022, 2:33 PM · Restricted Project, Restricted Project
scott.linder added a comment to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

@yaxunl Does excluding device-libs via COV_None make sense?

Mar 28 2022, 10:20 AM · Restricted Project, Restricted Project, Restricted Project
scott.linder updated the diff for D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

Do not add the no-hostcall attribute for "COV_None" modules, to allow for
the OpenCL implementation of hostcall in the device-libs.

Mar 28 2022, 10:17 AM · Restricted Project, Restricted Project, Restricted Project

Mar 25 2022

scott.linder added inline comments to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.
Mar 25 2022, 11:03 AM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2022

scott.linder updated the diff for D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

Eliminate diagnostic, and instead add function attribute in Clang for pre-COV_5
OpenCL codegen.

Mar 24 2022, 10:54 PM · Restricted Project, Restricted Project, Restricted Project

Mar 22 2022

scott.linder added a comment to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

The check for "__ockl_hostcall_internal" is not longer relevant with the new hostcall attribute. Can we simply remove this check? What is the situation where the warning is still useful?

I wasn't aware of the new attribute, I'm happy to just delete it.

Yeah, it happened in D119216.

But I am still curious about the check itself. Do we need to worry about a situation where it is important to check whether OpenCL printf (non-hostcall) and some other hostcall service are active in the same application?

Mar 22 2022, 3:52 PM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2022

scott.linder added a comment to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.

The check for "__ockl_hostcall_internal" is not longer relevant with the new hostcall attribute. Can we simply remove this check? What is the situation where the warning is still useful?

Mar 18 2022, 8:20 AM · Restricted Project, Restricted Project, Restricted Project

Mar 17 2022

scott.linder added inline comments to D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.
Mar 17 2022, 2:16 PM · Restricted Project, Restricted Project, Restricted Project
scott.linder added reviewers for D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic: sameerds, arsenm, rampitec, b-sumner, kzhuravl, yaxunl.

For reference, the error I'm changing to a warning was added as part of https://reviews.llvm.org/D70038, and the issue that made me consider this approach appears when building OCL conformance tests at -O0

Mar 17 2022, 2:12 PM · Restricted Project, Restricted Project, Restricted Project
scott.linder requested review of D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic.
Mar 17 2022, 2:05 PM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2022

scott.linder added a comment to D121242: [AMDGPU] gfx940 memory model.

Scott, I appreciate your doc review. It is a lot of work. Do you mind to fix doc typos in a followup change? It is a real pain to maintain the downstream merge, it will be easier to fix when it is merged back.

Mar 10 2022, 9:07 AM · Restricted Project, Restricted Project

Mar 9 2022

scott.linder added a comment to D121242: [AMDGPU] gfx940 memory model.

I noted some small nits, but otherwise LGTM. I won't accept, as there are others who should probably review.

Mar 9 2022, 2:01 PM · Restricted Project, Restricted Project
scott.linder added inline comments to D121242: [AMDGPU] gfx940 memory model.
Mar 9 2022, 11:40 AM · Restricted Project, Restricted Project

Mar 8 2022

scott.linder added a comment to D121067: [YAMLParser] Refactor BlockStyle and BlockChomping type.

Thank you for following up! The change looks correct, but I have some nits about the general approach. Let me know what you think.

Mar 8 2022, 10:26 AM · Restricted Project, Restricted Project

Feb 28 2022

scott.linder committed rGf3487c7be977: [YAMLParser] Add multi-line literal folding support (authored by scott.linder).
[YAMLParser] Add multi-line literal folding support
Feb 28 2022, 1:04 PM
scott.linder closed D102590: [YAMLParser] Add multi-line literal folding support.
Feb 28 2022, 1:04 PM · Restricted Project
scott.linder added a comment to D102590: [YAMLParser] Add multi-line literal folding support.

@scott.linder I don’t have a commit permission so I’d love it if you can commit it on my behalf. Thanks!

Feb 28 2022, 12:19 PM · Restricted Project
scott.linder accepted D102590: [YAMLParser] Add multi-line literal folding support.

LGTM, thank you!

Feb 28 2022, 11:54 AM · Restricted Project

Feb 22 2022

scott.linder added inline comments to D120265: AMDGPU: Use the implicit kernargs for code object version 5.
Feb 22 2022, 1:11 PM · Restricted Project, Restricted Project, Restricted Project

Jan 18 2022

scott.linder accepted D117572: [AMDGPU][NFC] Add DWARF extension support for SIMD execution.

LGTM, thank you!

Jan 18 2022, 9:30 AM · Restricted Project

Jan 7 2022

scott.linder updated the diff for D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Implement explicit return version of llvm::visit

Jan 7 2022, 1:53 PM · Restricted Project

Dec 16 2021

scott.linder added a comment to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

No worries, I understand the patch is pretty big and the template code is (unfortunately) dense.

Dec 16 2021, 10:44 AM · Restricted Project
scott.linder updated the diff for D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Rebase, ping

Dec 16 2021, 10:13 AM · Restricted Project

Dec 15 2021

scott.linder accepted D115762: AMDGPU: Remove AMDGPUFixFunctionBitcasts pass.
Dec 15 2021, 11:34 AM · Restricted Project
scott.linder committed rG78a26c7dafc9: [ADT] Add new type traits for type pack indexes (authored by scott.linder).
[ADT] Add new type traits for type pack indexes
Dec 15 2021, 11:26 AM
scott.linder closed D100672: [ADT] Add new type traits for type pack indexes.
Dec 15 2021, 11:26 AM · Restricted Project
scott.linder updated the diff for D100672: [ADT] Add new type traits for type pack indexes.

Rebase

Dec 15 2021, 8:55 AM · Restricted Project

Dec 14 2021

scott.linder added a comment to D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

Is this moving in the right direction? Does the restriction on DIArgList seem
reasonable, and if so does it need more explicit documentation or more thorough
enforcement?

I pushed this before looking at the intervening comments, so the last bit is a bit redundant; it sounds like the restriction on DIArgList was intended and makes sense, so I think the remaining question is whether the Verifier check is sufficient.

It seems like DIArgList is very similar to LocalAsMetadata. I feel like it'd be less error-prone for it to use/inherit-from ReplaceableMetadataImpl, just like ValueAsMetadata does. Then it has the machinery to RAUW/delete itself when necessary.

(Moreover, given that it doesn't have any operands, I find it suspicious that it inherits (albeit indirectly) from MDNode. It should probably be a direct subclass of Metadata. This would mean it couldn't inherit from DINode which might complicate some debug info code; if you're going to clean that up I suggest doing it later as a separate patch.)

I looked into deriving DIArgList from ReplaceableMetadataImpl, and it does get awkward quickly that it is an MDNode. It seems like there is a fair amount of code around tracking/RAUW which relies on MDNodes being eventually "resolveable". The result is that I don't think I can inherit from ReplaceableMetadataImpl without also changing the inheritence from MDNode to Metadata as you suggest.

I'll look at what effect that has on any debug-info related code, but I do worry that no matter what there will be a fair amount of special-casing.

Dec 14 2021, 3:43 PM · Restricted Project

Dec 13 2021

scott.linder accepted D115587: [AMDGPU][NFC] Add documentation for location description DWARF extension.
Dec 13 2021, 4:12 PM · Restricted Project
scott.linder added a comment to D115587: [AMDGPU][NFC] Add documentation for location description DWARF extension.

LGTM, with only typos and minor nits around wording.

Dec 13 2021, 2:42 PM · Restricted Project
scott.linder updated the diff for D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

I went ahead with just leaving DIArgList alone, let me know what you think

Dec 13 2021, 1:12 PM · Restricted Project
scott.linder updated the diff for D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

I'm pushing the (rough) patch which tries to make the switch from inheriting
DIArglist from MDNode to ReplaceableMetadataImpl.

Dec 13 2021, 10:36 AM · Restricted Project

Nov 29 2021

scott.linder added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Nov 29 2021, 3:22 PM · Restricted Project, Restricted Project

Nov 19 2021

scott.linder accepted D114273: [AMDGPU] Do not generate ELF symbols for the local branch target labels.
Nov 19 2021, 1:14 PM · Restricted Project

Nov 18 2021

scott.linder added a comment to D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

Is this moving in the right direction? Does the restriction on DIArgList seem
reasonable, and if so does it need more explicit documentation or more thorough
enforcement?

I pushed this before looking at the intervening comments, so the last bit is a bit redundant; it sounds like the restriction on DIArgList was intended and makes sense, so I think the remaining question is whether the Verifier check is sufficient.

It seems like DIArgList is very similar to LocalAsMetadata. I feel like it'd be less error-prone for it to use/inherit-from ReplaceableMetadataImpl, just like ValueAsMetadata does. Then it has the machinery to RAUW/delete itself when necessary.

(Moreover, given that it doesn't have any operands, I find it suspicious that it inherits (albeit indirectly) from MDNode. It should probably be a direct subclass of Metadata. This would mean it couldn't inherit from DINode which might complicate some debug info code; if you're going to clean that up I suggest doing it later as a separate patch.)

Nov 18 2021, 12:16 PM · Restricted Project

Nov 17 2021

scott.linder added a comment to D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

Add enforcement of the always-owned-by-MetadataAsValue property of DIArgList to
the metadata verifier. I'm not sure this is sufficient, but at least it is a
start.

Fixed the handling of the uniquify()!=this case in
DIArgList::handleChangedOperand to assert if the above property doesn't hold.

Add unittests for both changes above; the reproducers for this in IR rely on
specific sequences of optimizations, and would be much more fragile.

Is this moving in the right direction? Does the restriction on DIArgList seem
reasonable, and if so does it need more explicit documentation or more thorough
enforcement?

Nov 17 2021, 8:25 AM · Restricted Project

Nov 16 2021

scott.linder updated the diff for D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

Add enforcement of the always-owned-by-MetadataAsValue property of DIArgList to
the metadata verifier. I'm not sure this is sufficient, but at least it is a
start.

Nov 16 2021, 10:22 PM · Restricted Project

Nov 15 2021

scott.linder added inline comments to D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.
Nov 15 2021, 3:51 PM · Restricted Project

Nov 12 2021

scott.linder added reviewers for D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes: tejohnson, alexfh.

Update DIArgList::handleChangedOperand to propagate in-place changes which
would require the DIArgList become distinct up to the owning MetadataAsValue.

This feels a bit odd, but so does allowing DIArgList to be distinct as an
implementation detail, while never serializing that fact (and so making a
round-trip lossy). Semantically this may be OK, but unless we have a good
reason not to I feel like finding a way to ensure these "inline" nodes are
always uniqued will make the relationship between IR/bitcode and the in-memory
representation more obvious.

Nov 12 2021, 2:39 PM · Restricted Project
scott.linder updated the diff for D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

Update DIArgList::handleChangedOperand to propagate in-place changes which
would require the DIArgList become distinct up to the owning MetadataAsValue.

Nov 12 2021, 2:37 PM · Restricted Project
scott.linder reopened D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.
Nov 12 2021, 2:37 PM · Restricted Project

Nov 9 2021

scott.linder added a comment to D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

hi, this is causing crashes

$ build/rel/bin/opt -passes='thinlto-pre-link<O2>' /tmp/a.ll -o /dev/null
opt: ../../llvm/include/llvm/IR/Metadata.def:180: void (anonymous namespace)::ModuleBitcodeWriter::writeMetadataRecords(ArrayRef<const llvm::Metadata *>, SmallVectorImpl<uint64_t> &, std::vector<
unsigned int> *, std::vector<uint64_t> *): Assertion `!N->isDistinct() && "Expected non-distinct " "DIArgList"' failed.                                                                            
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace.                                                                                                              
Stack dump:                                                                                                                                                                                        
0.      Program arguments: build/rel/bin/opt -passes=thinlto-pre-link<O2> /tmp/a.ll -o /dev/null                                                                                                   
 #0 0x0000000001f37a13 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /usr/local/google/home/aeubanks/repos/llvm-project/build/rel/../../llvm/lib/Support/Unix/Signals.inc:565:13             
 #1 0x0000000001f3588e llvm::sys::RunSignalHandlers() /usr/local/google/home/aeubanks/repos/llvm-project/build/rel/../../llvm/lib/Support/Signals.cpp:98:18                                        
 #2 0x0000000001f37d7f SignalHandler(int) /usr/local/google/home/aeubanks/repos/llvm-project/build/rel/../../llvm/lib/Support/Unix/Signals.inc:407:1                                               
 #3 0x00007f2003b8e8e0 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x138e0)                                                                                                                
 #4 0x00007f2003668e71 raise ./signal/../sysdeps/unix/sysv/linux/raise.c:50:1                                                                                                                      
 #5 0x00007f2003652536 abort ./stdlib/abort.c:81:7                                                                                                                                                 
 #6 0x00007f200365241f get_sysdep_segment_value ./intl/loadmsgcat.c:509:8                                                                                                                          
 #7 0x00007f200365241f _nl_load_domain ./intl/loadmsgcat.c:970:34                                                                                                                                  
 #8 0x00007f20036617f2 (/lib/x86_64-linux-gnu/libc.so.6+0x357f2)                                                                                                                                   
 #9 0x000000000168e506 (anonymous namespace)::ModuleBitcodeWriter::writeMetadataRecords(llvm::ArrayRef<llvm::Metadata const*>, llvm::SmallVectorImpl<unsigned long>&, std::vector<unsigned int, std::allocator<unsigned int> >*, std::vector<unsigned long, std::allocator<unsigned long> >*) /usr/local/google/home/aeubanks/repos/llvm-project/build/rel/../../llvm/include/llvm/IR/Metadata.def:0:0
#10 0x000000000167df15 writeFunctionMetadata /usr/local/google/home/aeubanks/repos/llvm-project/build/rel/../../llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:2303:3
#11 0x000000000167df15 writeFunction /usr/local/google/home/aeubanks/repos/llvm-project/build/rel/../../llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:3351:3
#12 0x000000000167df15 (anonymous namespace)::ModuleBitcodeWriter::write() /usr/local/google/home/aeubanks/repos/llvm-project/build/rel/../../llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4448:7
#13 0x0000000001677d32 ~ModuleBitcodeWriterBase /usr/local/google/home/aeubanks/repos/llvm-project/build/rel/../../llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:155:7
#14 0x0000000001677d32 llvm::BitcodeWriter::writeModule(llvm::Module const&, bool, llvm::ModuleSummaryIndex const*, bool, std::array<unsigned int, 5ul>*) /usr/local/google/home/aeubanks/repos/llvm-project/build/rel/../../llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4626:1
#15 0x00000000016813cb llvm::WriteBitcodeToFile(llvm::Module const&, llvm::raw_ostream&, bool, llvm::ModuleSummaryIndex const*, bool, std::array<unsigned int, 5ul>*) /usr/local/google/home/aeubanks/repos/llvm-project/build/rel/../../llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4653:10

(I tried reducing as much as possible but there's still a lot of debug info)

Nov 9 2021, 4:44 PM · Restricted Project
scott.linder added a comment to D100672: [ADT] Add new type traits for type pack indexes.

Ping, @dblaikie are you OK with the patch as-is? I think it is likely not worth the effort of tracking down what MSVC configurations will accept the constexpr version.

Fair enough. I really don't like to workaround unknown issues (ends up with a form of "fear based programming" - "let's not write code that looks like that because there are issues /somewhere/ in there" - haunted graveyards ( https://www.usenix.org/sites/default/files/conference/protected-files/srecon17americas_slides_reese.pdf ) , etc) - so I think there's significant value in figuring out exactly what the limitations are/what's being worked around - but I won't insist on it.

Nov 9 2021, 3:45 PM · Restricted Project
scott.linder added a comment to D100672: [ADT] Add new type traits for type pack indexes.

Ping, @dblaikie are you OK with the patch as-is? I think it is likely not worth the effort of tracking down what MSVC configurations will accept the constexpr version.

Nov 9 2021, 2:12 PM · Restricted Project
scott.linder committed rGee7652569854: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes (authored by scott.linder).
[DebugInfo] Enforce implicit constraints on `distinct` MDNodes
Nov 9 2021, 10:19 AM
scott.linder closed D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.
Nov 9 2021, 10:19 AM · Restricted Project

Nov 5 2021

scott.linder committed rGf82bdf0fccb7: [NFC][Verifier] Remove redundant Module parameters (authored by scott.linder).
[NFC][Verifier] Remove redundant Module parameters
Nov 5 2021, 2:31 PM
scott.linder closed D106474: [NFC][Verifier] Remove redundant Module parameters.
Nov 5 2021, 2:30 PM · Restricted Project

Nov 4 2021

scott.linder updated the diff for D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

I believe the only pending issue is resolved, so I plan to land this tomorrow
if nobody has any objections.

Nov 4 2021, 12:50 PM · Restricted Project
scott.linder updated the diff for D109008: [AMDGPU][NFC] Refactor AMDGPUCallingConv.td.

Remove misleading comment headers, strip "CSR_" prefix from regmask identifiers.

Nov 4 2021, 9:45 AM · Restricted Project, Restricted Project

Nov 3 2021

scott.linder accepted D113100: [AMDGPU] Do not add debug locations to the code inside prologue.
Nov 3 2021, 9:03 AM · Restricted Project

Sep 28 2021

scott.linder added a comment to D110276: Clean up large copies of binaries copied into temp directories in tests.

Is it possible to use soft links instead of copies? It would still be good to clean up afterwards, but if the host won't allow that cleanup in some cases at least we aren't leaving a big file around.

Sep 28 2021, 10:16 AM · Restricted Project

Sep 16 2021

scott.linder accepted D109743: [NFC][MachineRegisterInfo] Fix typo in comments of getLiveInVirtReg() function.

LGTM thank you!

Sep 16 2021, 10:38 AM · Restricted Project

Sep 2 2021

scott.linder retitled D109187: [Transforms] Remove dead ModuleLevelChanges parameters from CloneAndPrune functions from [Transforms] Remove ModuleLevelChanges parameter from Clone functions to [Transforms] Remove dead ModuleLevelChanges parameters from CloneAndPrune functions.
Sep 2 2021, 1:30 PM · Restricted Project
scott.linder requested review of D109187: [Transforms] Remove dead ModuleLevelChanges parameters from CloneAndPrune functions.
Sep 2 2021, 1:21 PM · Restricted Project
scott.linder updated the summary of D109008: [AMDGPU][NFC] Refactor AMDGPUCallingConv.td.
Sep 2 2021, 12:45 PM · Restricted Project, Restricted Project

Sep 1 2021

scott.linder added inline comments to D109008: [AMDGPU][NFC] Refactor AMDGPUCallingConv.td.
Sep 1 2021, 1:17 PM · Restricted Project, Restricted Project
scott.linder committed rG0022426917e3: [AMDGPU] Update Call Convention docs for GFX90A (authored by scott.linder).
[AMDGPU] Update Call Convention docs for GFX90A
Sep 1 2021, 1:03 PM
scott.linder closed D109009: [AMDGPU] Update Call Convention docs for GFX90A.
Sep 1 2021, 1:03 PM · Restricted Project
scott.linder added inline comments to D109008: [AMDGPU][NFC] Refactor AMDGPUCallingConv.td.
Sep 1 2021, 12:43 PM · Restricted Project, Restricted Project

Aug 31 2021

scott.linder added reviewers for D109009: [AMDGPU] Update Call Convention docs for GFX90A: arsenm, kzhuravl, rampitec, t-tye.
Aug 31 2021, 11:32 AM · Restricted Project
scott.linder added reviewers for D109008: [AMDGPU][NFC] Refactor AMDGPUCallingConv.td: arsenm, kzhuravl, rampitec.
Aug 31 2021, 11:31 AM · Restricted Project, Restricted Project
scott.linder requested review of D109009: [AMDGPU] Update Call Convention docs for GFX90A.
Aug 31 2021, 11:29 AM · Restricted Project
scott.linder requested review of D109008: [AMDGPU][NFC] Refactor AMDGPUCallingConv.td.
Aug 31 2021, 11:29 AM · Restricted Project, Restricted Project

Aug 30 2021

scott.linder added a comment to D102590: [YAMLParser] Add multi-line literal folding support.

@scott.linder Thank you so much for the review!

  1. I made the changes you pointed out regarding defining a new scanBlockScalarIndicators method.
  2. I think the idea of enum BlockStyle and enum BlockChomping is really good. I will definitely implement it but maybe in another PR/diff. -- if that's okay :)
Aug 30 2021, 2:21 PM · Restricted Project

Aug 20 2021

scott.linder added a comment to D102590: [YAMLParser] Add multi-line literal folding support.

So, I tried to work out the behavior of the spec parser, and I think my understanding of empty is faulty. Compare http://ben-kiki.org/ypaste/data/26953/index.html (all content is non-space characters) with http://ben-kiki.org/ypaste/data/26954/index.html (the middle line content is a single space).

Aug 20 2021, 1:08 PM · Restricted Project
scott.linder added a comment to D102590: [YAMLParser] Add multi-line literal folding support.

I'm not sure I'm the best person for the job, but I tried to give my thoughts.

Aug 20 2021, 12:40 PM · Restricted Project

Aug 17 2021

scott.linder updated the diff for D106474: [NFC][Verifier] Remove redundant Module parameters.

Rebase

Aug 17 2021, 2:42 PM · Restricted Project

Aug 11 2021

scott.linder updated the diff for D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

Eliminate the getDistinct method entirely from DIExpression and DIArgList. I
went about this by splitting up the DEFINE_MDNODE_* macros so each MDNode
class can use an appropriate version based on their distinct/uniqued
properties.

Aug 11 2021, 11:20 AM · Restricted Project

Aug 2 2021

scott.linder committed rG635c5ba45bae: [AMDGPU][HIP] Switch default DWARF version to 5 (authored by scott.linder).
[AMDGPU][HIP] Switch default DWARF version to 5
Aug 2 2021, 11:05 AM
scott.linder closed D107190: [AMDGPU][HIP] Switch default DWARF version to 5.
Aug 2 2021, 11:05 AM · Restricted Project

Jul 30 2021

scott.linder updated the summary of D107190: [AMDGPU][HIP] Switch default DWARF version to 5.
Jul 30 2021, 12:15 PM · Restricted Project
scott.linder requested review of D107190: [AMDGPU][HIP] Switch default DWARF version to 5.
Jul 30 2021, 12:13 PM · Restricted Project

Jul 28 2021

scott.linder accepted D106926: [DebugInfo][docs] Fix DISubprogram fields.

LGTM, thank you for catching these!

Jul 28 2021, 10:44 AM · Restricted Project

Jul 26 2021

scott.linder added a comment to D106736: Minor Sphinx documentation generation improvements.

LGTM, as long as @MaskRay is satisfied with the changes around easy_install. If MacOS still uses it but we want to discourage it on Linux then I like the current wording.

Jul 26 2021, 12:52 PM · Restricted Project, Restricted Project
scott.linder added a comment to D106338: Use GNUInstallDirs to define install locations for documentation.

I think the change itself LGTM, but I did a grep for GNUInstallDirs and it it only used in two other places currently. I suppose that means it is OK to use, but it does seem to imply there can be cases where we install to inconsistent locations. I don't know who to add to get more info on this, though?

Jul 26 2021, 12:48 PM · Restricted Project
scott.linder accepted D106734: Eliminate clang man page generation warning for missing .rst files.

LGTM, I see no reason why this shouldn't apply for all generators.

Jul 26 2021, 12:45 PM · Restricted Project, Restricted Project

Jul 23 2021

scott.linder requested review of D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.
Jul 23 2021, 11:05 AM · Restricted Project