Page MenuHomePhabricator

scott.linder (Scott Linder)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2018, 8:31 AM (178 w, 3 d)

Recent Activity

Yesterday

scott.linder updated the diff for D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Add an extra function makeThunkForSameAlternative to force old versions of
gcc to deduce the return value of the overloaded "thunk" being instantiated
before deducing the template arguments for make_array.

Wed, Jun 16, 11:34 AM · Restricted Project

Mon, Jun 14

scott.linder added a comment to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

I did try to write an offsetof-based version using inheritance instead of the "common initial sequence" rule, but I am not sure how to do the necessary checks statically. The best I can see to do would be to have some dynamic ASSERTs to confirm that casting the alternative type to the base type does not change the underlying representation (i.e. if both pointers are cast to uintptr_t they are equal).

Mon, Jun 14, 4:29 PM · Restricted Project
scott.linder added a comment to D100672: [ADT] Add new type traits for type pack indexes.

@stella.stamenova do you still think you'd be able to test this before it lands, to see if the current version of the patch works on the MSVC build bots?

Mon, Jun 14, 4:26 PM · Restricted Project
scott.linder added a comment to D100670: [ADT] Add makeVisitor to STLExtras.h.

Ping

Mon, Jun 14, 4:25 PM · Restricted Project

Fri, Jun 4

scott.linder updated the diff for D103223: [ADT][WIP] Proof of concept impl of generic visit for PointerUnion.

Rebase

Fri, Jun 4, 5:08 PM · Restricted Project
scott.linder updated the diff for D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.
  • Clean up, rename, and document the VariantTraits interfaces
  • Expose IntrusiveVariant::index() as it is already available through the traits
  • Fix a bug in IntrusiveVariant comparison functions
Fri, Jun 4, 5:08 PM · Restricted Project
scott.linder committed rGe17610cf9627: [ADT] Refactor enumerate unit tests (authored by scott.linder).
[ADT] Refactor enumerate unit tests
Fri, Jun 4, 3:30 PM
scott.linder closed D103206: [ADT] Refactor enumerate unit tests.
Fri, Jun 4, 3:29 PM · Restricted Project
scott.linder added a comment to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Side thought: If this is going to use a prefix for the discriminator - could that be a base class that all types being used as union members have to derive from? No need for a macro, etc. Could use an offsetof comparison to make sure that not only is it a base class, but the first non-empty base class.

(still haven't been able to easily apply this locally - looks like it hit a conflict with c6f20d70a8c93ab3d50c9777c477fe040460a664 - though I thought arc would sync to the right version to apply the patch... not sure what's going on - might just wait to try that until the other patches have been committed)

Unfortunately having any non-static data members as part of a base class will make the alternative types non-standard-layout, which means we can't use the "common initial sequence" rule to pack them.

But would we need to use the common initial sequence rule? If the base object was at the start of the layout - a pointer to the start of the layout would be a valid pointer to the base object, yeah?

AFAIK that isn't true: we can't assume the base subobject is at the start of the layout of the derived object unless both are standard-layout.

My hope/thought was/is to use offsetof to check that the member is at the start of the object. Though, yes, for maximal portability, offsetof does require standard layout (though it seems both clang and gcc support it at least in some more cases than that: https://godbolt.org/z/Pjr6YEqMq )

In any case - even if it still leaves us with the standard layout restriction - using a base class rather than a macro+member seems like a nicer/more usable solution?

Fri, Jun 4, 2:45 PM · Restricted Project
scott.linder added inline comments to D103223: [ADT][WIP] Proof of concept impl of generic visit for PointerUnion.
Fri, Jun 4, 9:45 AM · Restricted Project
scott.linder updated the diff for D103206: [ADT] Refactor enumerate unit tests.

Make Counted::~Counted non-virtual

Fri, Jun 4, 9:29 AM · Restricted Project
scott.linder added inline comments to D103206: [ADT] Refactor enumerate unit tests.
Fri, Jun 4, 9:29 AM · Restricted Project
scott.linder updated the diff for D100672: [ADT] Add new type traits for type pack indexes.

Rebase and fix uses in PointerUnion.h

Fri, Jun 4, 9:16 AM · Restricted Project

Thu, Jun 3

scott.linder added a comment to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Side thought: If this is going to use a prefix for the discriminator - could that be a base class that all types being used as union members have to derive from? No need for a macro, etc. Could use an offsetof comparison to make sure that not only is it a base class, but the first non-empty base class.

(still haven't been able to easily apply this locally - looks like it hit a conflict with c6f20d70a8c93ab3d50c9777c477fe040460a664 - though I thought arc would sync to the right version to apply the patch... not sure what's going on - might just wait to try that until the other patches have been committed)

Unfortunately having any non-static data members as part of a base class will make the alternative types non-standard-layout, which means we can't use the "common initial sequence" rule to pack them.

But would we need to use the common initial sequence rule? If the base object was at the start of the layout - a pointer to the start of the layout would be a valid pointer to the base object, yeah?

Thu, Jun 3, 12:22 PM · Restricted Project

Thu, May 27

scott.linder added a reviewer for D103223: [ADT][WIP] Proof of concept impl of generic visit for PointerUnion: bakhtiyarneyman.
Thu, May 27, 8:00 AM · Restricted Project

Wed, May 26

scott.linder updated the summary of D103223: [ADT][WIP] Proof of concept impl of generic visit for PointerUnion.
Wed, May 26, 9:18 PM · Restricted Project
scott.linder requested review of D103223: [ADT][WIP] Proof of concept impl of generic visit for PointerUnion.
Wed, May 26, 9:16 PM · Restricted Project
scott.linder added a reviewer for D103206: [ADT] Refactor enumerate unit tests: bakhtiyarneyman.
Wed, May 26, 2:46 PM · Restricted Project
scott.linder added reviewers for D103206: [ADT] Refactor enumerate unit tests: dblaikie, mehdi_amini.
Wed, May 26, 2:46 PM · Restricted Project
scott.linder added a comment to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Side thought: If this is going to use a prefix for the discriminator - could that be a base class that all types being used as union members have to derive from? No need for a macro, etc. Could use an offsetof comparison to make sure that not only is it a base class, but the first non-empty base class.

(still haven't been able to easily apply this locally - looks like it hit a conflict with c6f20d70a8c93ab3d50c9777c477fe040460a664 - though I thought arc would sync to the right version to apply the patch... not sure what's going on - might just wait to try that until the other patches have been committed)

Wed, May 26, 2:11 PM · Restricted Project
scott.linder updated the diff for D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Try to factor out the implementation of visit to be based on specializations
of a type VariantTraits. This should make it possible to share one
implementation with other variant-like types, for example PointerUnion.

Wed, May 26, 2:08 PM · Restricted Project
scott.linder updated the diff for D100670: [ADT] Add makeVisitor to STLExtras.h.

Rebase and remove incorrect comments

Wed, May 26, 1:57 PM · Restricted Project
scott.linder requested review of D103206: [ADT] Refactor enumerate unit tests.
Wed, May 26, 1:55 PM · Restricted Project
scott.linder added inline comments to D100670: [ADT] Add makeVisitor to STLExtras.h.
Wed, May 26, 1:06 PM · Restricted Project
scott.linder updated the diff for D100672: [ADT] Add new type traits for type pack indexes.

Rebase

Wed, May 26, 1:06 PM · Restricted Project

Mon, May 24

scott.linder added a comment to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Could you reupload this (or maybe you can handle this just by editing the revision here on the web UI?) using arc/phab's ability to flag dependent patches/part of a series, hopefully that'll make it easier to apply the patch to test things? (tried just applying this patch and of course no template named 'TypeAtIndex')

Mon, May 24, 9:48 AM · Restricted Project
scott.linder added inline comments to D100670: [ADT] Add makeVisitor to STLExtras.h.
Mon, May 24, 6:57 AM · Restricted Project

Fri, May 21

scott.linder added inline comments to D100670: [ADT] Add makeVisitor to STLExtras.h.
Fri, May 21, 2:12 PM · Restricted Project

Thu, May 20

scott.linder added a comment to D100672: [ADT] Add new type traits for type pack indexes.

I'm not sure what to make of it now, and I'm not particularly familiar with Windows or MSVC. I'm still amenable to changing the code, but I also fear the changes I made won't actually fix the issue as I am only testing on godbolt. Is there any shortcut to testing with the Windows buildbots? Or do I have to install Windows somewhere and try to reproduce it?

There is no way to test on the official buildbots, you'd have to install Windows. If you have a change that's ready to test, I could run it locally for you.

Thu, May 20, 2:06 PM · Restricted Project

Wed, May 19

scott.linder updated the diff for D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Rebase and do some cleanup

Wed, May 19, 2:37 PM · Restricted Project
scott.linder added a comment to D102754: [unittests][CodeGen] Mark tests that cannot be executed with GTEST_SKIP().

I see // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0 show up in llvm/unittests/CodeGen/DIEHashTest.cpp, llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp and clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp; would you consider updating those at the same time?

Wed, May 19, 10:24 AM · Restricted Project
scott.linder added a comment to D100672: [ADT] Add new type traits for type pack indexes.

@dblaikie @scott.linder I updated VS on both the mlir and lldb windows buildbots (from 15.9.30 to 15.9.36), but this update does not have an update to the compiler and indeed the compiler version was already `Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27045```. You can see from the logs of the broken builds as well:

-- The C compiler identification is MSVC 19.16.27045.0
-- The CXX compiler identification is MSVC 19.16.27045.0

I think the issue is rather C++ 14 vs. C++ 17. It is my understanding that C++ 14 is required for LLVM, but not C++ 17, is that the case?

Wed, May 19, 9:46 AM · Restricted Project
scott.linder updated subscribers of D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Sorry for the delay in replying, you pose some very good questions and I wanted to revisit the reasoning that led me to my current approach in as thorough a way as possible (which meant it took some time, and I didn't get around to it right away).

Wed, May 19, 9:10 AM · Restricted Project

May 18 2021

scott.linder requested review of D100672: [ADT] Add new type traits for type pack indexes.
May 18 2021, 3:43 PM · Restricted Project
scott.linder updated the diff for D100672: [ADT] Add new type traits for type pack indexes.

Replace constexpr functions with recursively defined templates, working around
an MSVC bug.

May 18 2021, 3:42 PM · Restricted Project
scott.linder reopened D100672: [ADT] Add new type traits for type pack indexes.
May 18 2021, 3:42 PM · Restricted Project
scott.linder added a comment to D100672: [ADT] Add new type traits for type pack indexes.

This seems like a bug in parameter pack expansion in older versions of MSVC, compare 19.10 https://godbolt.org/z/TMd3K8WoK with 19.14 https://godbolt.org/z/9c9TT8bnb

May 18 2021, 10:32 AM · Restricted Project
scott.linder added a comment to D100672: [ADT] Add new type traits for type pack indexes.

I also neglected to move the extra element to the end of the array, so I'll make that change when I fix the build failure on Windows

May 18 2021, 9:54 AM · Restricted Project
scott.linder added a comment to D100672: [ADT] Add new type traits for type pack indexes.
May 18 2021, 9:38 AM · Restricted Project

May 17 2021

scott.linder updated the diff for D100670: [ADT] Add makeVisitor to STLExtras.h.
May 17 2021, 3:38 PM · Restricted Project
scott.linder committed rGa6d3987b8ef3: [ADT] Add new type traits for type pack indexes (authored by scott.linder).
[ADT] Add new type traits for type pack indexes
May 17 2021, 3:29 PM
scott.linder closed D100672: [ADT] Add new type traits for type pack indexes.
May 17 2021, 3:29 PM · Restricted Project
scott.linder committed rGaf5247c9347d: [ADT] Factor out in_place_t and expose in Optional ctor (authored by scott.linder).
[ADT] Factor out in_place_t and expose in Optional ctor
May 17 2021, 3:27 PM
scott.linder closed D100671: [ADT] Factor out in_place_t and expose in Optional ctor.
May 17 2021, 3:27 PM · Restricted Project, Restricted Project

May 14 2021

scott.linder added inline comments to D100672: [ADT] Add new type traits for type pack indexes.
May 14 2021, 12:16 PM · Restricted Project
scott.linder updated the diff for D100671: [ADT] Factor out in_place_t and expose in Optional ctor.

Add constexpr convenience variables

May 14 2021, 9:55 AM · Restricted Project, Restricted Project

May 12 2021

scott.linder added inline comments to D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.
May 12 2021, 8:39 AM · Restricted Project

May 11 2021

scott.linder added a comment to D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.

Would it be reasonable to just clean up all the types in these functions? I noted the ones I identified.

May 11 2021, 2:20 PM · Restricted Project

Apr 30 2021

scott.linder committed rGf3026d8b8d72: [ADT] Add llvm::remove_cvref and llvm::remove_cvref_t (authored by scott.linder).
[ADT] Add llvm::remove_cvref and llvm::remove_cvref_t
Apr 30 2021, 11:23 AM
scott.linder closed D100669: [ADT] Add llvm::remove_cvref and llvm::remove_cvref_t.
Apr 30 2021, 11:23 AM · Restricted Project
scott.linder added inline comments to D100669: [ADT] Add llvm::remove_cvref and llvm::remove_cvref_t.
Apr 30 2021, 11:10 AM · Restricted Project
scott.linder committed rGc6f20d70a8c9: [ADT] Add STLForwardCompat.h and llvm::disjunction (authored by scott.linder).
[ADT] Add STLForwardCompat.h and llvm::disjunction
Apr 30 2021, 10:30 AM
scott.linder closed D100668: [ADT] Add STLForwardCompat.h and llvm::disjunction.
Apr 30 2021, 10:30 AM · Restricted Project
scott.linder committed rGcab19d84ce85: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp (authored by scott.linder).
[NFC] Refactor ExecuteAssembler in cc1as_main.cpp
Apr 30 2021, 10:13 AM
scott.linder closed D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp.
Apr 30 2021, 10:13 AM · Restricted Project

Apr 29 2021

scott.linder added reviewers for D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp: MaskRay, dineshkb-amd, aykevl.

I'm not sure who else to add, please feel free to update the reviewers

Apr 29 2021, 9:14 AM · Restricted Project
scott.linder requested review of D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp.
Apr 29 2021, 9:11 AM · Restricted Project

Apr 19 2021

scott.linder added inline comments to D100668: [ADT] Add STLForwardCompat.h and llvm::disjunction.
Apr 19 2021, 11:01 AM · Restricted Project
scott.linder added a comment to D100672: [ADT] Add new type traits for type pack indexes.

Are there (future) STL equivalents of TypesAreDistinct or FirsntIndexOfType?

Apr 19 2021, 10:18 AM · Restricted Project

Apr 16 2021

scott.linder added inline comments to D100669: [ADT] Add llvm::remove_cvref and llvm::remove_cvref_t.
Apr 16 2021, 3:48 PM · Restricted Project
scott.linder updated the diff for D100669: [ADT] Add llvm::remove_cvref and llvm::remove_cvref_t.
  • Rebase
  • Change title, "std::" -> "llvm::"
  • Use TYPED_TEST instead of a bespoke macro
Apr 16 2021, 3:47 PM · Restricted Project
scott.linder updated the diff for D100668: [ADT] Add STLForwardCompat.h and llvm::disjunction.

Fix a typo in the description

Apr 16 2021, 3:42 PM · Restricted Project
scott.linder updated the diff for D100668: [ADT] Add STLForwardCompat.h and llvm::disjunction.
  • Rename STLShims -> STLForwardCompat
  • Change "STL types" -> "STL features"
Apr 16 2021, 3:42 PM · Restricted Project
scott.linder added a comment to D100671: [ADT] Factor out in_place_t and expose in Optional ctor.

This usage doesn't seem to quite match the standard - which provides an existing instance of in_place_t for callers to use:

std::optional<std::string> o4(std::in_place, {'a', 'b', 'c'});

(to quote https://en.cppreference.com/w/cpp/utility/optional/optional )

Probably good to match this sort of behavior.

Apr 16 2021, 3:31 PM · Restricted Project, Restricted Project
scott.linder added a comment to D100668: [ADT] Add STLForwardCompat.h and llvm::disjunction.

I don't think "shim" is the right term here - if anything I'd think things like our range-based adapters to standard algorithms (llvm::sort(R, C) -> std::sort(R.begin(), R.end(), C)) is a "shim" in the sense of the word that I know of - a thin adapter ( https://en.wikipedia.org/wiki/Shim_(computing) - "a shim is a library that transparently intercepts API calls and changes the arguments passed, handles the operation itself or redirects the operation elsewhere.").

These are STL reimplementations, though that's a bit of a mouthful. STLCompat.h, perhaps?

Apr 16 2021, 2:25 PM · Restricted Project
scott.linder updated the diff for D100668: [ADT] Add STLForwardCompat.h and llvm::disjunction.

Remove SHIM macro; it wasn't actually doing anything (there was a typo in the
lint identifier), it seems like clang-tidy just ignored the identifier when it
was wrapped in a macro.

Apr 16 2021, 2:02 PM · Restricted Project
scott.linder added reviewers for D100672: [ADT] Add new type traits for type pack indexes: dblaikie, mehdi_amini.
Apr 16 2021, 11:47 AM · Restricted Project
scott.linder added reviewers for D100671: [ADT] Factor out in_place_t and expose in Optional ctor: dblaikie, mehdi_amini.
Apr 16 2021, 11:47 AM · Restricted Project, Restricted Project
scott.linder added reviewers for D100670: [ADT] Add makeVisitor to STLExtras.h: dblaikie, mehdi_amini, bakhtiyarneyman.
Apr 16 2021, 11:46 AM · Restricted Project
scott.linder added reviewers for D100669: [ADT] Add llvm::remove_cvref and llvm::remove_cvref_t: bakhtiyarneyman, mehdi_amini, dblaikie.
Apr 16 2021, 11:45 AM · Restricted Project
scott.linder added reviewers for D100668: [ADT] Add STLForwardCompat.h and llvm::disjunction: bakhtiyarneyman, mehdi_amini, dblaikie, zturner.
Apr 16 2021, 11:45 AM · Restricted Project
scott.linder added a comment to D99560: Utility to construct visitors from lambdas..

I tried to write a version in https://reviews.llvm.org/D100670 that perfectly-forwards each argument to the (overload resolution selected) constructor of the remove_cvref type of the argument. I ended up doing this after I had already started moving some other things out of STLExtras.h, so the patch currently depends on https://reviews.llvm.org/D100670 and https://reviews.llvm.org/D100669 but you can equally well ignore those and makeVisitor can land first.

Apr 16 2021, 11:43 AM · Restricted Project
scott.linder updated the diff for D100672: [ADT] Add new type traits for type pack indexes.

Moved tests to STLExtrasTest.cpp from STLShimsTest.cpp

Apr 16 2021, 11:37 AM · Restricted Project
scott.linder requested review of D100672: [ADT] Add new type traits for type pack indexes.
Apr 16 2021, 11:32 AM · Restricted Project
scott.linder requested review of D100671: [ADT] Factor out in_place_t and expose in Optional ctor.
Apr 16 2021, 11:32 AM · Restricted Project, Restricted Project
scott.linder requested review of D100670: [ADT] Add makeVisitor to STLExtras.h.
Apr 16 2021, 11:32 AM · Restricted Project
scott.linder requested review of D100669: [ADT] Add llvm::remove_cvref and llvm::remove_cvref_t.
Apr 16 2021, 11:32 AM · Restricted Project
scott.linder requested review of D100668: [ADT] Add STLForwardCompat.h and llvm::disjunction.
Apr 16 2021, 11:31 AM · Restricted Project

Apr 14 2021

scott.linder added a comment to D99560: Utility to construct visitors from lambdas..

I think I ran into a reason to require the visitor we create be able to derive from all of its Callables: it makes it possible to transparently select the correct overload via the normal overload resolution rules, which as of C++14 and the addition of generic lambdas gives the user a way to naturally describe a "default" case.

Apr 14 2021, 1:32 PM · Restricted Project

Apr 9 2021

scott.linder accepted D99269: [AMDGPU] Unify spill code.

LGTM, thank you for bearing with me!

Apr 9 2021, 9:45 AM · Restricted Project

Apr 8 2021

scott.linder added a comment to D99269: [AMDGPU] Unify spill code.

Thank you, I have one remaining nit concerning RS and LiveRegs, but otherwise everything LGTM.

Apr 8 2021, 9:36 AM · Restricted Project

Apr 7 2021

scott.linder added inline comments to D99561: Support visitor pattern by PointerUnion..
Apr 7 2021, 9:59 AM · Restricted Project
scott.linder added a comment to D99561: Support visitor pattern by PointerUnion..

To chime in on the spelling of things relative to std, I had similar questions for IntrusiveVariant in https://reviews.llvm.org/D98477

A natural question that might help with deciding how to handle visit is: how should we spell alternative type access? std uses the free function std::get. It makes sense, as that same free function is overloaded for e.g. std::tuple, std::pair, std::variant, etc. but we don't currently have anything similar in ADT.

I think my leaning would be to go all-in on the std approach by doing the following:

  • Add an llvm::adt namespace (or something similar) containing things which are "designed to fulfill the same roles as the identically-named member of the std namespace, but for whatever reason we cannot actually use that member directly". Generally the reason will be: that thing is not an extension point, and it is forbidden to re-open std to overload that thing.

Oh - what would happen if the name went in llvm directly and we called it via adl? ie: made the call unqualified & let ADL+overload resolution sort it out?

I hadn't thought too much about using ADL, as pre-C++20 there is a subtle issue with ADL when the function is a template, see http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0846r0.html

Apr 7 2021, 9:36 AM · Restricted Project

Apr 6 2021

scott.linder added a comment to D99560: Utility to construct visitors from lambdas..

std::forward with inheritance does not remove a need to invoke a copy constructors, I managed to implement overloaded using a struct member and super ugly SFINAE that does properly captures lambdas by reference when lambda is a lvalue, however it still does need to copy when lambda is rvalue: https://godbolt.org/z/dqshPW6h1 (top most example, I just count the number of HeavyStuff::HeavyStuff(HeavyStuff const&) copy constructor calls in the generated code). But it does look much worse than inheritance.

Apr 6 2021, 3:30 PM · Restricted Project

Apr 5 2021

scott.linder added a comment to D99561: Support visitor pattern by PointerUnion..

To chime in on the spelling of things relative to std, I had similar questions for IntrusiveVariant in https://reviews.llvm.org/D98477

Apr 5 2021, 10:39 PM · Restricted Project

Apr 2 2021

scott.linder added inline comments to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.
Apr 2 2021, 3:42 PM · Restricted Project
scott.linder added inline comments to D99269: [AMDGPU] Unify spill code.
Apr 2 2021, 10:37 AM · Restricted Project

Apr 1 2021

scott.linder added a comment to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Perhaps PointerUnion could be implemented as a derivation from this intrusive variant in a follow-up change, subsuming D99561

Apr 1 2021, 8:06 AM · Restricted Project
scott.linder added a comment to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Looks like this visitor infrastructure has some overlap with D99560 and D99561 - be good to deduplicate some work here, perhaps.

Apr 1 2021, 8:03 AM · Restricted Project
scott.linder added a comment to D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space.

Is this still needed?

Apr 1 2021, 7:23 AM · Restricted Project

Mar 24 2021

scott.linder added inline comments to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.
Mar 24 2021, 4:42 PM · Restricted Project
scott.linder updated the diff for D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.
  • Address feedback
  • Fix bug where last alternative type could not be emplaced
  • Misc cleanup
Mar 24 2021, 4:39 PM · Restricted Project

Mar 19 2021

scott.linder added a comment to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

Thank you for taking a look @whisperity! I'm glad there is interest from others in the new type, I was worried at first it may be too niche of a use.

Mar 19 2021, 3:14 PM · Restricted Project

Mar 15 2021

scott.linder accepted D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.
Mar 15 2021, 3:51 PM · Restricted Project
scott.linder added a comment to D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.

This LGTM, thank you!

Mar 15 2021, 3:51 PM · Restricted Project

Mar 11 2021

scott.linder added reviewers for D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat: t-tye, laurentm0, kzhuravl, RamNalamothu.
Mar 11 2021, 9:06 PM · Restricted Project
scott.linder requested review of D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.
Mar 11 2021, 9:05 PM · Restricted Project
scott.linder accepted D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax.
Mar 11 2021, 10:31 AM · Restricted Project
scott.linder added inline comments to D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax.
Mar 11 2021, 10:31 AM · Restricted Project

Mar 10 2021

scott.linder accepted D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax.

Thank you for coming up with a way to test the change! It LGTM.

Mar 10 2021, 9:08 AM · Restricted Project