Page MenuHomePhabricator

scott.linder (Scott Linder)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2018, 8:31 AM (66 w, 7 h)

Recent Activity

Today

scott.linder created D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes.
Mon, Apr 22, 9:06 AM · Restricted Project

Fri, Apr 19

scott.linder created D60915: [AMDGPU] Fix hidden argument metadata duplication for V3.
Fri, Apr 19, 1:00 PM · Restricted Project

Wed, Apr 17

scott.linder added a comment to D60682: [AMDGPU] Fixed +DumpCode.

Mesa uses +DumpCode as well. Do we have a good solution for generation both ELF and textual output?

Wed, Apr 17, 7:42 AM · Restricted Project

Thu, Apr 4

scott.linder committed rGce2b61b2994b: Fix some MCTargetOptions Doxygen comments (NFC) (authored by scott.linder).
Fix some MCTargetOptions Doxygen comments (NFC)
Thu, Apr 4, 1:38 PM
scott.linder committed rL357723: Fix some MCTargetOptions Doxygen comments (NFC).
Fix some MCTargetOptions Doxygen comments (NFC)
Thu, Apr 4, 1:38 PM

Fri, Mar 29

scott.linder committed rG0bc9f15ddd1e: [AMDGPU] Add an additional Code Object V3 assembler example (authored by scott.linder).
[AMDGPU] Add an additional Code Object V3 assembler example
Fri, Mar 29, 10:49 AM
scott.linder committed rL357289: [AMDGPU] Add an additional Code Object V3 assembler example.
[AMDGPU] Add an additional Code Object V3 assembler example
Fri, Mar 29, 10:48 AM
scott.linder closed D59949: [AMDGPU] Add an additional Code Object V3 assembler example.
Fri, Mar 29, 10:48 AM · Restricted Project
scott.linder committed rGa377be6eb655: [AMDGPU] Switch default DWARF version to 5 (authored by scott.linder).
[AMDGPU] Switch default DWARF version to 5
Fri, Mar 29, 10:45 AM
scott.linder committed rC357285: [AMDGPU] Switch default DWARF version to 5.
[AMDGPU] Switch default DWARF version to 5
Fri, Mar 29, 10:45 AM
scott.linder committed rL357285: [AMDGPU] Switch default DWARF version to 5.
[AMDGPU] Switch default DWARF version to 5
Fri, Mar 29, 10:45 AM
scott.linder closed D59008: [AMDGPU] Switch default dwarf version to 5.
Fri, Mar 29, 10:45 AM · Restricted Project

Thu, Mar 28

scott.linder updated the diff for D59008: [AMDGPU] Switch default dwarf version to 5.

Add a test to confirm split-dwarf is supported for the amdhsa OS in the driver.

Thu, Mar 28, 11:19 AM · Restricted Project
scott.linder created D59949: [AMDGPU] Add an additional Code Object V3 assembler example.
Thu, Mar 28, 10:44 AM · Restricted Project
scott.linder committed rGac20b745735e: [AMDGPU] Clarify Code Object V2/V3 differences in AMDGPUUsage (authored by scott.linder).
[AMDGPU] Clarify Code Object V2/V3 differences in AMDGPUUsage
Thu, Mar 28, 8:09 AM
scott.linder committed rL357176: [AMDGPU] Clarify Code Object V2/V3 differences in AMDGPUUsage.
[AMDGPU] Clarify Code Object V2/V3 differences in AMDGPUUsage
Thu, Mar 28, 8:09 AM
scott.linder closed D59782: [AMDGPU] Clarify Code Object V2/V3 differences in AMDGPUUsage.
Thu, Mar 28, 8:09 AM · Restricted Project

Mon, Mar 25

scott.linder created D59782: [AMDGPU] Clarify Code Object V2/V3 differences in AMDGPUUsage.
Mon, Mar 25, 10:48 AM · Restricted Project
scott.linder added a comment to D59008: [AMDGPU] Switch default dwarf version to 5.

Ping

Mon, Mar 25, 10:44 AM · Restricted Project

Mar 20 2019

scott.linder accepted D57028: [AMDGPU] Added MsgPack format PAL metadata.

LGTM, thanks! One small change to a comment.

Mar 20 2019, 7:57 AM · Restricted Project

Mar 19 2019

scott.linder added inline comments to D57028: [AMDGPU] Added MsgPack format PAL metadata.
Mar 19 2019, 8:25 AM · Restricted Project
scott.linder accepted D57027: [AMDGPU] Factored PAL metadata handling out into its own class.

LGTM, thanks! I think you can also drop "provides a method for use by LLPC to write metadata into LLVM IR" from the commit message.

Mar 19 2019, 7:37 AM · Restricted Project

Mar 18 2019

scott.linder added inline comments to D57027: [AMDGPU] Factored PAL metadata handling out into its own class.
Mar 18 2019, 4:14 PM · Restricted Project

Mar 5 2019

scott.linder created D59008: [AMDGPU] Switch default dwarf version to 5.
Mar 5 2019, 5:11 PM · Restricted Project

Mar 4 2019

scott.linder committed rGefec1396accb: [AMDGPU] Implement AMDGPUMCInstrAnalysis (authored by scott.linder).
[AMDGPU] Implement AMDGPUMCInstrAnalysis
Mar 4 2019, 7:01 PM
scott.linder committed rL355373: [AMDGPU] Implement AMDGPUMCInstrAnalysis.
[AMDGPU] Implement AMDGPUMCInstrAnalysis
Mar 4 2019, 7:01 PM
scott.linder closed D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis.
Mar 4 2019, 7:01 PM · Restricted Project

Feb 27 2019

scott.linder added a comment to D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis.

I'm not sure how the question is whether signed integers are supported. The instruction does treat the offset as signed

Feb 27 2019, 2:12 PM · Restricted Project
scott.linder updated the diff for D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis.

After digging a bit more into how we parse/print operands for sopp_br I think there are some more fundamental decisions to make beyond just "do we support signed integers", so I want to avoid changing anything in this patch. I will revisit how we treat them in the future and make any breaking changes all at once, rather than spreading them out.

Feb 27 2019, 12:56 PM · Restricted Project

Feb 22 2019

scott.linder accepted D58512: AMDGPU/GlobalISel: Insert waterfall loop for vector indexing.

LGTM then, but like I said I'm not very familiar with GlobalISel so more eyes might be good

Feb 22 2019, 9:31 AM
scott.linder added inline comments to D58512: AMDGPU/GlobalISel: Insert waterfall loop for vector indexing.
Feb 22 2019, 8:49 AM
scott.linder added a comment to D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis.

Does anyone have an opinion on returning negative branch targets (e.g. <keep_symbol+0xfffffffffffe0018>)? I don't know how this would ever come up in hardware anyway, or what the hardware would do, but it doesn't seem very helpful in the disassembly.

The hardware doesn't know about the symbol? Do you mean for overflow?

Feb 22 2019, 7:55 AM · Restricted Project

Feb 21 2019

scott.linder added a comment to D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis.

Does anyone have an opinion on returning negative branch targets (e.g. <keep_symbol+0xfffffffffffe0018>)? I don't know how this would ever come up in hardware anyway, or what the hardware would do, but it doesn't seem very helpful in the disassembly.

Feb 21 2019, 9:19 AM · Restricted Project

Feb 20 2019

scott.linder updated the diff for D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis.

Improved error message.

Feb 20 2019, 2:25 PM · Restricted Project
scott.linder added inline comments to D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis.
Feb 20 2019, 2:24 PM · Restricted Project
scott.linder updated the diff for D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis.

Address feedback. Sign-extend all s_branch immediates and change the assembler syntax to represent these as true negative numbers.

Feb 20 2019, 1:54 PM · Restricted Project
scott.linder added inline comments to D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis.
Feb 20 2019, 8:01 AM · Restricted Project

Feb 19 2019

scott.linder created D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis.
Feb 19 2019, 11:39 AM · Restricted Project

Feb 12 2019

scott.linder committed rG80a1ee46d87b: [AMDGPU] Require at least protected visibility for certain symbols (authored by scott.linder).
[AMDGPU] Require at least protected visibility for certain symbols
Feb 12 2019, 10:31 AM
scott.linder committed rC353870: [AMDGPU] Require at least protected visibility for certain symbols.
[AMDGPU] Require at least protected visibility for certain symbols
Feb 12 2019, 10:31 AM
scott.linder committed rL353870: [AMDGPU] Require at least protected visibility for certain symbols.
[AMDGPU] Require at least protected visibility for certain symbols
Feb 12 2019, 10:31 AM
scott.linder closed D56871: [AMDGPU] Require at least protected visibility for certain symbols.
Feb 12 2019, 10:31 AM · Restricted Project

Feb 11 2019

scott.linder committed rG72a0f4e8db40: [IRReader] Expose getLazyIRModule (authored by scott.linder).
[IRReader] Expose getLazyIRModule
Feb 11 2019, 2:01 PM
scott.linder committed rL353755: [IRReader] Expose getLazyIRModule.
[IRReader] Expose getLazyIRModule
Feb 11 2019, 2:01 PM
scott.linder closed D56203: [IRReader] Expose getLazyIRModule.
Feb 11 2019, 2:01 PM · Restricted Project
scott.linder added a comment to D56203: [IRReader] Expose getLazyIRModule.

Ping

Feb 11 2019, 9:50 AM · Restricted Project
scott.linder added a comment to D56871: [AMDGPU] Require at least protected visibility for certain symbols.

Ping

Feb 11 2019, 9:48 AM · Restricted Project

Feb 8 2019

Herald added a project to D57028: [AMDGPU] Added MsgPack format PAL metadata: Restricted Project.
Feb 8 2019, 8:16 AM · Restricted Project

Feb 5 2019

scott.linder committed rGe2c584741469: [AMDGPU] Consider XOR in waterfall loop as a terminator (authored by scott.linder).
[AMDGPU] Consider XOR in waterfall loop as a terminator
Feb 5 2019, 11:51 AM
scott.linder committed rL353207: [AMDGPU] Consider XOR in waterfall loop as a terminator.
[AMDGPU] Consider XOR in waterfall loop as a terminator
Feb 5 2019, 11:50 AM
scott.linder closed D57703: [AMDGPU] Consider XOR in waterfall loop as a terminator.
Feb 5 2019, 11:50 AM · Restricted Project
scott.linder updated the diff for D57703: [AMDGPU] Consider XOR in waterfall loop as a terminator.

I think MIR is the best place to look; this now tests that the right pseudo is produced and that spills don't interleave the terminators.

Feb 5 2019, 7:35 AM · Restricted Project

Feb 4 2019

scott.linder updated the diff for D57703: [AMDGPU] Consider XOR in waterfall loop as a terminator.

I agree the test does not test much at all, it was just the minimum I could think of considering none of our existing tests notice the change. I'm not sure what pass you mean by 'isel', but 'stop-after=amdgpu-isel' is too early to see the SI_INDIRECT_SRC_* psuedo expanded.

Feb 4 2019, 12:47 PM · Restricted Project
scott.linder added a comment to D57027: [AMDGPU] Factored PAL metadata handling out into its own class.
In D57027#1383432, @tpr wrote:

The code looks good to me, but I'm wondering why the move from doing this in AsmPrinter::EmitEndOfAsmFile to TargetStreamer::finish? It seems like it is fine to emit directives in either, but I don't understand why the change here.

The idea was so that a disassembler disassembling into a TargetStreamer would go through the same code to emit the directives.

Feb 4 2019, 12:09 PM · Restricted Project
scott.linder committed rGd19d1972217b: [AMDGPU] Support emitting GOT relocations for function calls (authored by scott.linder).
[AMDGPU] Support emitting GOT relocations for function calls
Feb 4 2019, 12:00 PM
scott.linder committed rL353083: [AMDGPU] Support emitting GOT relocations for function calls.
[AMDGPU] Support emitting GOT relocations for function calls
Feb 4 2019, 12:00 PM
scott.linder closed D57416: [AMDGPU] Support emitting GOT relocations for function calls.
Feb 4 2019, 11:59 AM · Restricted Project
scott.linder accepted D57024: [AMDGPU] Switched HSA metadata to use MsgPackDocument.

LGTM

Feb 4 2019, 11:55 AM · Restricted Project
scott.linder created D57703: [AMDGPU] Consider XOR in waterfall loop as a terminator.
Feb 4 2019, 11:50 AM · Restricted Project
scott.linder removed a parent revision for D57416: [AMDGPU] Support emitting GOT relocations for function calls: D57605: [AMDGPU] Mark test functions with hidden visibility.
Feb 4 2019, 8:43 AM · Restricted Project
scott.linder removed a child revision for D57605: [AMDGPU] Mark test functions with hidden visibility: D57416: [AMDGPU] Support emitting GOT relocations for function calls.
Feb 4 2019, 8:43 AM · Restricted Project

Feb 1 2019

scott.linder abandoned D53153: [OpenCL] Mark kernel functions with default visibility.

See https://reviews.llvm.org/D56871

Feb 1 2019, 2:02 PM
scott.linder added a child revision for D57605: [AMDGPU] Mark test functions with hidden visibility: D57416: [AMDGPU] Support emitting GOT relocations for function calls.
Feb 1 2019, 2:00 PM · Restricted Project
scott.linder added a parent revision for D57416: [AMDGPU] Support emitting GOT relocations for function calls: D57605: [AMDGPU] Mark test functions with hidden visibility.
Feb 1 2019, 2:00 PM · Restricted Project
scott.linder removed a child revision for D53153: [OpenCL] Mark kernel functions with default visibility: D57416: [AMDGPU] Support emitting GOT relocations for function calls.
Feb 1 2019, 1:58 PM
scott.linder removed a parent revision for D57416: [AMDGPU] Support emitting GOT relocations for function calls: D53153: [OpenCL] Mark kernel functions with default visibility.
Feb 1 2019, 1:58 PM · Restricted Project
scott.linder added inline comments to D57027: [AMDGPU] Factored PAL metadata handling out into its own class.
Feb 1 2019, 1:55 PM · Restricted Project
Herald added a project to D57027: [AMDGPU] Factored PAL metadata handling out into its own class: Restricted Project.

The code looks good to me, but I'm wondering why the move from doing this in AsmPrinter::EmitEndOfAsmFile to TargetStreamer::finish? It seems like it is fine to emit directives in either, but I don't understand why the change here.

Feb 1 2019, 1:48 PM · Restricted Project
scott.linder committed rL352920: [AMDGPU] Mark test functions with hidden visibility.
[AMDGPU] Mark test functions with hidden visibility
Feb 1 2019, 1:23 PM
scott.linder closed D57605: [AMDGPU] Mark test functions with hidden visibility.
Feb 1 2019, 1:23 PM · Restricted Project
scott.linder updated the diff for D57416: [AMDGPU] Support emitting GOT relocations for function calls.

Add test for tail call through GOT

Feb 1 2019, 12:20 PM · Restricted Project
scott.linder accepted D57025: [MsgPack] Removed MsgPackTypes.

LGTM, pending parents of course.

Feb 1 2019, 11:51 AM · Restricted Project
Herald added a project to D57024: [AMDGPU] Switched HSA metadata to use MsgPackDocument: Restricted Project.

Thank you for updating this! I only have one small suggestion, but otherwise it LGTM.

Feb 1 2019, 11:50 AM · Restricted Project
scott.linder accepted D57023: [MsgPack] New MsgPackDocument class.

LGTM, sorry for the delay in reviewing this.

Feb 1 2019, 11:42 AM · Restricted Project
scott.linder added a parent revision for D57416: [AMDGPU] Support emitting GOT relocations for function calls: D53153: [OpenCL] Mark kernel functions with default visibility.
Feb 1 2019, 11:10 AM · Restricted Project
scott.linder added a child revision for D53153: [OpenCL] Mark kernel functions with default visibility: D57416: [AMDGPU] Support emitting GOT relocations for function calls.
Feb 1 2019, 11:10 AM
scott.linder added inline comments to D57416: [AMDGPU] Support emitting GOT relocations for function calls.
Feb 1 2019, 11:09 AM · Restricted Project
scott.linder updated the diff for D57416: [AMDGPU] Support emitting GOT relocations for function calls.

Address feedback

Feb 1 2019, 11:08 AM · Restricted Project
scott.linder created D57605: [AMDGPU] Mark test functions with hidden visibility.
Feb 1 2019, 11:08 AM · Restricted Project

Jan 31 2019

scott.linder updated the diff for D57416: [AMDGPU] Support emitting GOT relocations for function calls.

I've tried to implement carrying a copy of the function global through the DAG from the beginning, rather than recovering it after legalizing the GlobalAddress. I don't know if this is a reasonable approach, but I figured I would post something and see what you think.

Jan 31 2019, 1:54 PM · Restricted Project

Jan 30 2019

scott.linder added inline comments to D57416: [AMDGPU] Support emitting GOT relocations for function calls.
Jan 30 2019, 1:49 PM · Restricted Project

Jan 29 2019

scott.linder added inline comments to D57416: [AMDGPU] Support emitting GOT relocations for function calls.
Jan 29 2019, 3:09 PM · Restricted Project
scott.linder created D57416: [AMDGPU] Support emitting GOT relocations for function calls.
Jan 29 2019, 2:14 PM · Restricted Project

Jan 28 2019

scott.linder added a comment to D56871: [AMDGPU] Require at least protected visibility for certain symbols.

Ping

Jan 28 2019, 2:08 PM · Restricted Project
scott.linder committed rL352414: [MC] Do not consider .ifdef/.ifndef as a use.
[MC] Do not consider .ifdef/.ifndef as a use
Jan 28 2019, 11:33 AM
scott.linder closed D55439: [MC] Do not consider .ifdef/.ifndef as a use.
Jan 28 2019, 11:33 AM
scott.linder committed rC352391: Add -fapply-global-visibility-to-externs for -cc1.
Add -fapply-global-visibility-to-externs for -cc1
Jan 28 2019, 9:12 AM
scott.linder committed rL352391: Add -fapply-global-visibility-to-externs for -cc1.
Add -fapply-global-visibility-to-externs for -cc1
Jan 28 2019, 9:12 AM
scott.linder closed D56868: Add -fapply-global-visibility-to-externs for -cc1.
Jan 28 2019, 9:12 AM
scott.linder added a comment to D55439: [MC] Do not consider .ifdef/.ifndef as a use.

Ping

Jan 28 2019, 8:33 AM

Jan 18 2019

scott.linder updated the diff for D56871: [AMDGPU] Require at least protected visibility for certain symbols.

Update option name

Jan 18 2019, 10:47 AM · Restricted Project
scott.linder updated the diff for D56868: Add -fapply-global-visibility-to-externs for -cc1.

No worries, I agree that we don't gain much with a shorter flag here; explicit seems preferable.

Jan 18 2019, 10:46 AM
scott.linder updated the diff for D56871: [AMDGPU] Require at least protected visibility for certain symbols.

Update option name

Jan 18 2019, 8:51 AM · Restricted Project
scott.linder updated the diff for D56868: Add -fapply-global-visibility-to-externs for -cc1.

Update the -cc1 option name and docs; also update the LangOpt and docs.

Jan 18 2019, 8:47 AM

Jan 17 2019

scott.linder updated the diff for D56871: [AMDGPU] Require at least protected visibility for certain symbols.

Add missing flag to tests

Jan 17 2019, 1:55 PM · Restricted Project
scott.linder updated the diff for D56868: Add -fapply-global-visibility-to-externs for -cc1.

Remove driver options

Jan 17 2019, 1:47 PM
scott.linder added a comment to D53153: [OpenCL] Mark kernel functions with default visibility.

That sounds reasonable to me. I had already posted a patch with the Driver options, but I will update it to only include the -cc1 version.

Jan 17 2019, 1:30 PM
scott.linder abandoned D52891: [AMDGPU] Add -fvisibility-amdgpu-non-kernel-functions.

Will be superseded by either https://reviews.llvm.org/D53153 or https://reviews.llvm.org/D56871

Jan 17 2019, 11:45 AM
scott.linder updated the diff for D56203: [IRReader] Expose getLazyIRModule.

Rebase and ping

Jan 17 2019, 11:44 AM · Restricted Project
scott.linder added a parent revision for D56871: [AMDGPU] Require at least protected visibility for certain symbols: D56868: Add -fapply-global-visibility-to-externs for -cc1.
Jan 17 2019, 11:37 AM · Restricted Project