Comments emission in ASM for macinfo section. completed! + Rebase.
Sat, Jan 25
Fri, Jan 24
- Add an explanatory comment to the test.
I do not have commit access.
can someone commit this?
LGTM but give @dblaikie a chance to say whether he accepts my explanation.
@aprantl thanks for the review! Are you okay with this test?
Address review comments. Reword a test description slightly.
I agree, we must pay attention and address the bitcode compatibility.
Is it necessary to use DIFlags? I am willing to do that but generally, it is not welcomed because we have a limited number of DIFlags and most of them are currently in use.
- Rebase, Update;
- Add a test.
Hi @probinson, I have changed the patch according to your comments.
Thu, Jan 23
-Update the RUN line
-Add the line for dwarf5 without LLDB tuning
Thanks Daniel. If it's safe not to mark dbg values for removal here, that seems like the best option.
This is looking really nice. Thanks!
I put in a lot of comments about spelling for the new parameter (constExpr, isConstexpr, isConstExpr) which should be named consistently throughout. Please do not use Constant or any variant, as that tends to mean something else.
@JDevlieghere Jonas, Thank you for reviewing this set of patches for dsymutil!