Page MenuHomePhabricator

debug-infoProject
ActivePublic

Recent Activity

Yesterday

dschuff added a comment to D52634: [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass.

@aprantl Is the advantage of your suggested approach just that we don't have to define a new expression type? Obviously the interpretation is not the same as DW_OP_breg on other targets so as you say, either way there would have to be special logic in all the tools that consume it. Is this kind of repurposing of builtin primitives common?

Tue, Dec 18, 8:43 PM · debug-info
Diffusion closed D55756: [DebugInfo] Make AsmPrinter struct HandlerInfo and Handlers protected.
Tue, Dec 18, 8:11 PM · debug-info
Diffusion closed D55755: [DebugInfo] Move several private headers to include directory.
Tue, Dec 18, 3:14 PM · debug-info
echristo accepted D55755: [DebugInfo] Move several private headers to include directory.

Thanks for the split! LGTM.

Tue, Dec 18, 2:35 PM · debug-info
echristo accepted D55756: [DebugInfo] Make AsmPrinter struct HandlerInfo and Handlers protected.

Thanks for the split. LGTM!

Tue, Dec 18, 2:35 PM · debug-info
echristo accepted D55752: [BPF] Add BTF DebugInfo under BPF target.

Thanks so much for the split!

Tue, Dec 18, 2:35 PM · debug-info
yurydelendik added reviewers for D52634: [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass: aprantl, dschuff.
Tue, Dec 18, 1:57 PM · debug-info
yurydelendik updated the diff for D52634: [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass.

Replace DW_OP_wasm_location with DW_OP_breg

Tue, Dec 18, 1:55 PM · debug-info
yurydelendik added a comment to D52634: [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass.
I also found that the tools (e.g. LLVM or LLDB) are eager to know about number of registers (which we cannot determine) to allocate internal structures.

What I was thinking of was to define exactly three WASM DWARF register numbers: wasm_reg_local, wasm_reg_global, wasm_reg_stack and use DW_OP_breg regnum offset like you would use the new special operation introduced by this patch.

Tue, Dec 18, 9:30 AM · debug-info
aprantl added a comment to D52634: [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass.
I also found that the tools (e.g. LLVM or LLDB) are eager to know about number of registers (which we cannot determine) to allocate internal structures.
Tue, Dec 18, 9:11 AM · debug-info
yurydelendik added a comment to D52634: [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass.

Can you explain how this new operation is meant to work?

@aprantl, here is some description of what we are trying to achieve: https://github.com/WebAssembly/debugging/issues/1#issuecomment-448237641

In the nutshell, the WebAssembly extensions for the DWARF expression will allow us to express WebAssembly specific locations such as for locals, globals and operands stack. The consumers of this information will be limited to LLVM tools, web browser debuggers and AOT/JIT WebAssembly compilers.

Does WebAssembly have a concept of registers? You could just define three additional register numbers for WebAssembly and address a stack slot as DW_OP_breg [wasm_stack_register] + 3 etc.. This would need less support in all the involved tools. The link says that it was considered, but rejected, but there is no mention as to why.

Tue, Dec 18, 9:02 AM · debug-info
aprantl added a comment to D52634: [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass.

Can you explain how this new operation is meant to work?

@aprantl, here is some description of what we are trying to achieve: https://github.com/WebAssembly/debugging/issues/1#issuecomment-448237641

In the nutshell, the WebAssembly extensions for the DWARF expression will allow us to express WebAssembly specific locations such as for locals, globals and operands stack. The consumers of this information will be limited to LLVM tools, web browser debuggers and AOT/JIT WebAssembly compilers.

Tue, Dec 18, 8:40 AM · debug-info
yurydelendik retitled D52634: [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass from [WIP] [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass to [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass.
Tue, Dec 18, 6:38 AM · debug-info
yurydelendik added a comment to D52634: [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass.

Can you explain how this new operation is meant to work?

Tue, Dec 18, 6:37 AM · debug-info
hans added a comment to D54187: Add debuginfo-tests that use cdb on Windows.

This seems to be stuck. Is there some way we can get incremental progress on this?

Tue, Dec 18, 1:35 AM · debug-info

Mon, Dec 17

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Mon, Dec 17, 7:01 PM · debug-info
dstenb added inline comments to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Mon, Dec 17, 1:23 AM · debug-info

Sun, Dec 16

yonghong-song added a comment to D55756: [DebugInfo] Make AsmPrinter struct HandlerInfo and Handlers protected.

@echristo @aprantl @dblaikie
This patch and two other patches (D55755, D55752) implemented a different mechanism
to generate BTF than patch D53736. D53736 has its most implementation under
lib/CodeGen/AsmPrinter. The new mechanism put most implementation under BTF target.

Sun, Dec 16, 10:03 PM · debug-info
yonghong-song added a comment to D55755: [DebugInfo] Move several private headers to include directory.

@echristo @aprantl @dblaikie
This patch and two other patches (D55756, D55752) implemented a different mechanism
to generate BTF than patch D53736. D53736 has its most implementation under
lib/CodeGen/AsmPrinter. The new mechanism put most implementation under BTF target.

(1) https://reviews.llvm.org/D55755, moving header files
(2) https://reviews.llvm.org/D55756, changes some fields from private to protected
(3) https://reviews.llvm.org/D55752, changes only under target BPF

It will be good if you can help review all related patches and provide your opinions soon.
Thanks! Real appreciated.

Sun, Dec 16, 10:02 PM · debug-info
yonghong-song added a comment to D53736: [BTF] Add BTF DebugInfo.

@echristo @aprantl @dblaikie This patch has stuck in this state for more than one month and did not make progress.
I have suggested a possible way to move some header files to include directory and then we will be
able to move BTFDebug.{cpp,h} under BPF directory. I have implemented this approach with the
following three patches for easy to see pro and cons of two approaches:

(1) https://reviews.llvm.org/D55755, moving header files
(2) https://reviews.llvm.org/D55756, changes some fields from private to protected
(3) https://reviews.llvm.org/D55752, changes only under target BPF
Sun, Dec 16, 9:56 PM · debug-info
yonghong-song updated the diff for D55752: [BPF] Add BTF DebugInfo under BPF target.

refactor the previous change to separate Debug info changes into
https://reviews.llvm.org/D55755 (for moving related header files into include directory)
and
https://reviews.llvm.org/D55756 (for exposing some private fields as protected)

Sun, Dec 16, 9:43 PM · debug-info
yonghong-song created D55756: [DebugInfo] Make AsmPrinter struct HandlerInfo and Handlers protected.
Sun, Dec 16, 9:39 PM · debug-info
yonghong-song created D55755: [DebugInfo] Move several private headers to include directory.
Sun, Dec 16, 9:36 PM · debug-info
HsiangKai added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

Ping.

Sun, Dec 16, 6:20 PM · debug-info
yonghong-song added a comment to D53736: [BTF] Add BTF DebugInfo.

In one of my earlier comments, I mentioned it is possible to push the implementation into BPF target directory with the need
moving three private headers to include/llvm/CodeGen directory.
I did not get opinion whether that implementation is preferred or not, but I feel that maybe it is a good idea just to go ahead
with a diff which may facilitate discussion and move review/discussion faster.
I created another diff, https://reviews.llvm.org/D55752, which did this implementation.

Sun, Dec 16, 4:37 PM · debug-info

Sat, Dec 15

yonghong-song updated subscribers of D53736: [BTF] Add BTF DebugInfo.
Sat, Dec 15, 11:24 PM · debug-info
yonghong-song updated the diff for D53736: [BTF] Add BTF DebugInfo.
Sat, Dec 15, 11:18 PM · debug-info
vsk added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

@aprantl It looks like the percentage of variables with location went up right after this patch landed:

Sat, Dec 15, 11:35 AM · debug-info

Fri, Dec 14

vsk added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).
Fri, Dec 14, 4:09 PM · debug-info
Diffusion closed D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).
Fri, Dec 14, 4:07 PM · debug-info
dstenb added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

I do not find the test file on trunk. Also, git log -- test/Transforms/Util/dbg-user-of-aext.ll in the git mirror does not yield anything, so it seems like the file has not previously existed either.

Is it perhaps something that is only available downstream, or am I overlooking something?

Fri, Dec 14, 7:39 AM · debug-info
dstenb added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

I do not find the test file on trunk. Also, git log -- test/Transforms/Util/dbg-user-of-aext.ll in the git mirror does not yield anything, so it seems like the file has not previously existed either.

Fri, Dec 14, 7:21 AM · debug-info

Thu, Dec 13

davide accepted D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

LGTM.

Thu, Dec 13, 3:30 PM · debug-info
aprantl added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

Can you watch http://lnt.llvm.org/db_default/v4/nts/117379 (http://lnt.llvm.org/db_default/v4/nts/graph?plot.0=1357.1607042.4 and http://lnt.llvm.org/db_default/v4/nts/graph?plot.0=1357.1607043.4) after landing this?

Thu, Dec 13, 11:14 AM · debug-info
davide added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

OK, I'll try to review it later today. Will you have time to commit this or you want any of us to do it on your behalf?

Thu, Dec 13, 10:42 AM · debug-info
vsk added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

I think this patch is complete, it just needs review.

Thu, Dec 13, 10:33 AM · debug-info
davide added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

So, is there anything remaining before we can merge this patch?

Thu, Dec 13, 10:23 AM · debug-info
vsk updated subscribers of D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

Apologies, I haven't been able to get back to this. I'd be happy to have someone commandeer this.

Thu, Dec 13, 10:21 AM · debug-info
aprantl added a comment to D55519: Reuse code from CGDebugInfo::getOrCreateFile() when creating the file for the DICompileUnit.

I believe I fixed this in r349065. (The DIFile used by the CU is special and distinct from the main source file. Its directory part specifies what becomes the DW_AT_comp_dir (the compilation directory), even if the source file was specified with an absolute path.)

Thu, Dec 13, 9:57 AM · debug-info
labath added a comment to D55519: Reuse code from CGDebugInfo::getOrCreateFile() when creating the file for the DICompileUnit.

I am sorry about the late notice Adrian, but it looks like this patch completely breaks DWO file lookup. I think the search for the common prefix of compilation directory and file path is somehow broken. For example this is what I get when compiling a file from /tmp with PWD=/home/pavel (so, these paths only share / as a prefix):

~ $ /tmp/clang.bad  -g -gsplit-dwarf  -c -o foo.o /tmp/foo.cpp 
~ $ llvm-dwarfdump foo.o 
foo.o:	file format ELF64-x86-64
Thu, Dec 13, 8:22 AM · debug-info
dsanders closed D55243: [mir] Serialize DILocation inline when not possible to use a metadata reference.
Thu, Dec 13, 6:28 AM · debug-info

Wed, Dec 12

uabelho added a comment to D55519: Reuse code from CGDebugInfo::getOrCreateFile() when creating the file for the DICompileUnit.

Great, thanks!

Wed, Dec 12, 12:30 AM · debug-info

Tue, Dec 11

wolfgangp closed D55396: [DebugInfo] Make sure CodeGenPrepare does not drop MD references to locals..
Tue, Dec 11, 1:17 PM · debug-info
Diffusion closed D55519: Reuse code from CGDebugInfo::getOrCreateFile() when creating the file for the DICompileUnit.
Tue, Dec 11, 9:03 AM · debug-info
aprantl added a comment to D55519: Reuse code from CGDebugInfo::getOrCreateFile() when creating the file for the DICompileUnit.

I also removed the other references to DIBuilder::createFile() in r348866.

Tue, Dec 11, 9:03 AM · debug-info
dstenb closed D55513: [DeadArgElim] Fixes for dbg.values using dead arg/return values.
Tue, Dec 11, 2:36 AM · debug-info

Mon, Dec 10

dstenb added a comment to D55513: [DeadArgElim] Fixes for dbg.values using dead arg/return values.

Thanks for the reviews! I'm planning on submitting this shortly then.

Mon, Dec 10, 11:55 PM · debug-info
djtodoro added a comment to D55513: [DeadArgElim] Fixes for dbg.values using dead arg/return values.

LGTM as well! Thanks!

Mon, Dec 10, 11:48 PM · debug-info
uabelho added a comment to D55519: Reuse code from CGDebugInfo::getOrCreateFile() when creating the file for the DICompileUnit.

If I change what I think is two typos, then the patch compiles for me and solves the issue I had.

Mon, Dec 10, 10:48 PM · debug-info
aprantl accepted D55396: [DebugInfo] Make sure CodeGenPrepare does not drop MD references to locals..

LGTM with outstanding comment addressed.

Mon, Dec 10, 5:09 PM · debug-info