debug-infoProject
ActivePublic

Recent Activity

Today

yonghong-song added a comment to D53261: [BPF] Add BTF generation for BPF target.

pending Eric's review, I just updated another revision to fix the format issue mentioned by Adrian in the previous comments.

Tue, Oct 16, 5:21 PM · debug-info
yonghong-song updated the diff for D53261: [BPF] Add BTF generation for BPF target.

Address a few more format-related changes.

Tue, Oct 16, 5:19 PM · debug-info
aprantl added a comment to D53261: [BPF] Add BTF generation for BPF target.

Thanks! Stylistically this looks good now.
@echristo may have an opinion on the integration with MC and DwarfDebug?

Tue, Oct 16, 4:31 PM · debug-info
yonghong-song added a comment to D53261: [BPF] Add BTF generation for BPF target.

@aprantl, just addressed your comments. Indeed enum/strings definition is much cleaner.
I did not add packed attributes to BTFHeader and BTFExtHeader
as the data structure is designed not to have holes based on C standard. Please take a look. Thanks!

Tue, Oct 16, 4:22 PM · debug-info
yonghong-song updated the diff for D53261: [BPF] Add BTF generation for BPF target.

Addressed Adrian's comments:

  • introduced include/llvm/MC/MCBTF.def to better sync enum and strings which are related to enum
  • added some file level descripts in include/llvm/MC/MCBTFContext.h
  • some other minor format fixes
Tue, Oct 16, 4:21 PM · debug-info
yonghong-song added inline comments to D53261: [BPF] Add BTF generation for BPF target.
Tue, Oct 16, 2:58 PM · debug-info
aprantl added inline comments to D53261: [BPF] Add BTF generation for BPF target.
Tue, Oct 16, 1:59 PM · debug-info
aprantl added inline comments to D53261: [BPF] Add BTF generation for BPF target.
Tue, Oct 16, 1:58 PM · debug-info
yonghong-song added inline comments to D53261: [BPF] Add BTF generation for BPF target.
Tue, Oct 16, 11:31 AM · debug-info
aprantl added a reviewer for D53329: Generate DIFile with main program if source is not available: dblaikie.
Tue, Oct 16, 10:27 AM · debug-info
yonghong-song updated subscribers of D53329: Generate DIFile with main program if source is not available.
Tue, Oct 16, 10:21 AM · debug-info
yonghong-song added a comment to D53329: Generate DIFile with main program if source is not available.

In the above /virtual/main.c is a memory mapped file. The invocation0.getPreprocessorOpts().addRemappedFile(...) adds the mapping
for the compilation.

Tue, Oct 16, 10:21 AM · debug-info
yonghong-song added a comment to D53329: Generate DIFile with main program if source is not available.

We already have -main-file-name in cc1.
clang -cc1 -triple x86_64-unknown-linux-gnu ... -main-file-name main.c ... -o main.bc -x c /virtual/main.c -faddrsig
Is this expected?

Tue, Oct 16, 10:18 AM · debug-info
aprantl added a comment to D53329: Generate DIFile with main program if source is not available.

Couldn't you just pass -main-file-name to cc1 instead?

Tue, Oct 16, 10:08 AM · debug-info
yonghong-song added a comment to D53329: Generate DIFile with main program if source is not available.

Hi, @vsk @HsiangKai @ABataev I found a bug in clang when trying to use "-g -gdwarf-5 -gembed-source" for
bcc MCJIT based clang/llvm compilation. This patch fixed the issue but I am not sure whether this is the
correct fix or not. Please help take a look and advise if the fix is not correct and there is a better one. Thanks!

Tue, Oct 16, 10:01 AM · debug-info
yonghong-song created D53329: Generate DIFile with main program if source is not available.
Tue, Oct 16, 9:56 AM · debug-info
aprantl accepted D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Tue, Oct 16, 8:46 AM · debug-info
aprantl added a comment to D53261: [BPF] Add BTF generation for BPF target.

Thanks!

Tue, Oct 16, 8:45 AM · debug-info
CarlosAlbertoEnciso added inline comments to D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Tue, Oct 16, 7:09 AM · debug-info
CarlosAlbertoEnciso updated the diff for D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by @aprantl.

Tue, Oct 16, 7:08 AM · debug-info

Yesterday

yonghong-song added a comment to D53261: [BPF] Add BTF generation for BPF target.

Hi, @aprantl, thanks a lot for the review! I just updated the patch which I hope addressed all your comments. Please take a look and let
me know whether I missed something or there are additional changes are needed. Thanks again!

Mon, Oct 15, 10:50 PM · debug-info
yonghong-song updated the diff for D53261: [BPF] Add BTF generation for BPF target.

Address comments raised by Adrian Prantl and a few other changes:

  • variable names confirms to llvm coding standard
  • adding doxygen comments for certain data structures, all classes and some methods
  • removed a few unused routines (forgot to remove last time) and I double checked that for this veresion I did not have any unused routines
  • a few code improvement (better C++ styple implementation, for example, "for (auto &TypeEntry : TypeEntries) ..." instead of old way "for (uint32_t I = 0; I < TypeEntries.size(); I++) ...".
  • removed dead codes in Die2BTFEntry constructor
Mon, Oct 15, 10:41 PM · debug-info
aprantl accepted D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Mon, Oct 15, 9:05 AM · debug-info
aprantl added inline comments to D53261: [BPF] Add BTF generation for BPF target.
Mon, Oct 15, 8:48 AM · debug-info
aprantl added inline comments to D53261: [BPF] Add BTF generation for BPF target.
Mon, Oct 15, 8:46 AM · debug-info
CarlosAlbertoEnciso abandoned D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

This revision caused builbot failures.

Mon, Oct 15, 7:16 AM · debug-info
CarlosAlbertoEnciso created D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Mon, Oct 15, 7:13 AM · debug-info

Sun, Oct 14

yonghong-song created D53261: [BPF] Add BTF generation for BPF target.
Sun, Oct 14, 12:20 PM · debug-info

Fri, Oct 12

MaskRay added a comment to D52950: [BPF] Add BTF generation for BPF target.

Reverted in r344405.

Please review the developer policy again before you commit patches in the future. Committing patches without review is not allowed except in narrow cases. And adding new features without tests is not allowed.

Fri, Oct 12, 2:03 PM · debug-info
efriedma reopened D52950: [BPF] Add BTF generation for BPF target.

Reverted in r344405.

Fri, Oct 12, 12:48 PM · debug-info
Diffusion closed D52950: [BPF] Add BTF generation for BPF target.
Fri, Oct 12, 10:03 AM · debug-info
ast accepted D52950: [BPF] Add BTF generation for BPF target.

we will be landing this shortly.
BTF side was thoroughly tested and kernel support was there for some time.
If there is a better way to integrate BTF with MC please let us know.

Fri, Oct 12, 9:19 AM · debug-info

Thu, Oct 11

CarlosAlbertoEnciso reopened D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

The patch caused some assertions. For more details see PR39243.

Thu, Oct 11, 11:52 AM · debug-info

Wed, Oct 10

yonghong-song added a comment to D52950: [BPF] Add BTF generation for BPF target.

@chandlerc @echristo Any comments?

Wed, Oct 10, 3:32 PM · debug-info
CarlosAlbertoEnciso added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

@mstorsjo, The change has been reverted. Thanks for creating the bugzilla.

Wed, Oct 10, 5:16 AM · debug-info
CarlosAlbertoEnciso added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

This broke compilation for me, compiling some source files now fail due to triggered assertions, see PR39243 for details. I guess I'll revert this in a while unless there's someone to fix it soon.

Wed, Oct 10, 5:05 AM · debug-info
mstorsjo added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

This broke compilation for me, compiling some source files now fail due to triggered assertions, see PR39243 for details. I guess I'll revert this in a while unless there's someone to fix it soon.

Wed, Oct 10, 5:00 AM · debug-info
Diffusion closed D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Wed, Oct 10, 1:32 AM · debug-info
CarlosAlbertoEnciso added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Thanks very much to all the reviewers for your valuable comments and suggestions.

Wed, Oct 10, 12:56 AM · debug-info

Tue, Oct 9

vsk accepted D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Thank you, lgtm.

Tue, Oct 9, 2:27 PM · debug-info
Chirag updated the diff for D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..
  • clang-format
Tue, Oct 9, 7:28 AM · debug-info
Chirag updated the diff for D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..
  • Added DW_AT_binary_scale attribute.
  • Fixed llvm type code formatting
  • Fixed minor typos.
Tue, Oct 9, 5:38 AM · debug-info
CarlosAlbertoEnciso updated the diff for D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by the reviewers.

Tue, Oct 9, 3:39 AM · debug-info

Mon, Oct 8

vsk added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

The logic looks fine, but the comment in hoistAllInstructionsInto should be shorter. One or two sentences would be ideal. Readers can look at the test case for more context. Thanks!

Mon, Oct 8, 11:53 AM · debug-info
CarlosAlbertoEnciso updated the diff for D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by the reviewers.

Mon, Oct 8, 7:27 AM · debug-info
CarlosAlbertoEnciso added inline comments to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Mon, Oct 8, 7:18 AM · debug-info

Sun, Oct 7

yonghong-song updated the diff for D52950: [BPF] Add BTF generation for BPF target.

remove unneeded header files.

Sun, Oct 7, 11:42 PM · debug-info

Fri, Oct 5

aprantl added a project to D52950: [BPF] Add BTF generation for BPF target: debug-info.
Fri, Oct 5, 3:30 PM · debug-info
Diffusion closed D49887: [DebugInfo] Add support for DWARF5 call site-related attributes.
Fri, Oct 5, 1:39 PM · debug-info
aprantl accepted D49887: [DebugInfo] Add support for DWARF5 call site-related attributes.
Fri, Oct 5, 12:55 PM · debug-info