Page MenuHomePhabricator

debug-infoProject
ActivePublic

Recent Activity

Yesterday

aprantl added a comment to D61062: Keep call site info valid through the backend.

looks good!

Mon, Jun 24, 4:07 PM · Restricted Project, debug-info
aprantl added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

A rebase shouldn't affect the spirit of the change :-)

Mon, Jun 24, 4:06 PM · Restricted Project, debug-info

Fri, Jun 21

probinson closed D63573: Fix a crash with assembler source and -g..
Fri, Jun 21, 6:09 AM · Restricted Project, debug-info

Thu, Jun 20

djtodoro added a comment to D61062: Keep call site info valid through the backend.

@aprantl The comment looks OK? :)

Thu, Jun 20, 11:14 PM · Restricted Project, debug-info
djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

@aprantl This still looks OK after the rebasing? :)

Thu, Jun 20, 11:14 PM · Restricted Project, debug-info
dblaikie accepted D63573: Fix a crash with assembler source and -g..

Sounds alright to me

Thu, Jun 20, 3:05 PM · Restricted Project, debug-info
akhuang closed D63361: Pretend NRVO variables are references so they can be found by debug info.
Thu, Jun 20, 10:13 AM · debug-info, Restricted Project, Restricted Project
rnk accepted D63361: Pretend NRVO variables are references so they can be found by debug info.

lgtm, thanks!

Thu, Jun 20, 9:00 AM · debug-info, Restricted Project, Restricted Project
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Rebase

Thu, Jun 20, 6:38 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Rebase

Thu, Jun 20, 6:37 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Rebase

Thu, Jun 20, 6:35 AM · Restricted Project, debug-info
djtodoro updated the diff for D61062: Keep call site info valid through the backend.

-Rebase
-Add the comment explaining the assertion when deleting instructions

Thu, Jun 20, 6:35 AM · Restricted Project, debug-info

Wed, Jun 19

akhuang added inline comments to D63361: Pretend NRVO variables are references so they can be found by debug info.
Wed, Jun 19, 4:54 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D63361: Pretend NRVO variables are references so they can be found by debug info.
  • fix alignment of pointer in inalloca case
  • make existing tests stop failing by changing some and adding a check for existing return value alloca (I think?) before adding the ReturnValuePointer alloca
Wed, Jun 19, 4:52 PM · debug-info, Restricted Project, Restricted Project
probinson added a comment to D63573: Fix a crash with assembler source and -g..

We do not precisely match gcc/gas behavior in some more-peculiar cases, but my assertion is that those should not occur "naturally" and so it's okay. For example:

foo:
    nop
    .file 1 "a.c"

This will cause gcc/gas to emit an error to the effect that file number 1 is already defined (implicitly, because of the line-table record for the first instruction). Clang/llvm-mc will not, we'll just emit an odd-looking line table. I can see how to cause clang/llvm-mc to emit this error, but it feels like it would be a hack done just to match gcc's (likely unintentional) error-detection behavior for an ill-formed assembler file.

Wed, Jun 19, 2:36 PM · Restricted Project, debug-info
probinson created D63573: Fix a crash with assembler source and -g..
Wed, Jun 19, 2:25 PM · Restricted Project, debug-info
rnk added a comment to D63361: Pretend NRVO variables are references so they can be found by debug info.

I see we don't have any tests for inalloca to model this on, so I think we should skip that for this change. I'll add one later that handles arguments as well, since those are interesting.

Wed, Jun 19, 11:56 AM · debug-info, Restricted Project, Restricted Project
akhuang added inline comments to D63361: Pretend NRVO variables are references so they can be found by debug info.
Wed, Jun 19, 11:25 AM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D63361: Pretend NRVO variables are references so they can be found by debug info.
  • Add clang and llvm tests, and windows debuginfo test
  • Use GEP as returnValuePointer in inalloca case
  • Add bool parameter for EmitDeclare when pointer is being used
Wed, Jun 19, 11:25 AM · debug-info, Restricted Project, Restricted Project
akhuang added a reviewer for D63361: Pretend NRVO variables are references so they can be found by debug info: inglorion.
Wed, Jun 19, 11:07 AM · debug-info, Restricted Project, Restricted Project
rnk added inline comments to D63361: Pretend NRVO variables are references so they can be found by debug info.
Wed, Jun 19, 9:58 AM · debug-info, Restricted Project, Restricted Project
akhuang added inline comments to D63361: Pretend NRVO variables are references so they can be found by debug info.
Wed, Jun 19, 9:44 AM · debug-info, Restricted Project, Restricted Project
aprantl added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

Thanks for your help!

Wed, Jun 19, 6:26 AM · debug-info, Restricted Project
Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

Thanks, I've now resubmitted this patch (1251cac62af5).

Wed, Jun 19, 4:03 AM · debug-info, Restricted Project

Tue, Jun 18

Diffusion closed D63499: Add debug location verification for !llvm.loop attachments.
Tue, Jun 18, 12:41 PM · Restricted Project, debug-info
Orlando accepted D63499: Add debug location verification for !llvm.loop attachments.

LGTM. Thanks for doing this!

Tue, Jun 18, 11:33 AM · Restricted Project, debug-info
aprantl added a comment to D63361: Pretend NRVO variables are references so they can be found by debug info.

Thanks, this addresses my concern!

Tue, Jun 18, 11:03 AM · debug-info, Restricted Project, Restricted Project
rnk added a comment to D63361: Pretend NRVO variables are references so they can be found by debug info.

This needs two unit tests:

  • A clang test at clang/test/CodeGenCXX/debug-info-nrvo.cpp similar to other debug-info-* tests there. This test should have a second RUN line and extra checks for -fno-elide-constructors.
  • An LLVM test at llvm/test/DebugInfo/COFF/nrvo.ll to show that we handle dbg.declare + deref
Tue, Jun 18, 10:17 AM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D63361: Pretend NRVO variables are references so they can be found by debug info.
  • add semicolon
Tue, Jun 18, 9:58 AM · debug-info, Restricted Project, Restricted Project
akhuang added inline comments to D63361: Pretend NRVO variables are references so they can be found by debug info.
Tue, Jun 18, 9:57 AM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D63361: Pretend NRVO variables are references so they can be found by debug info.

Now creates a pointer to the return location in the function prolog, whenever sret is being used.

Tue, Jun 18, 9:57 AM · debug-info, Restricted Project, Restricted Project
aprantl added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

I put up a Verifier patch at https://reviews.llvm.org/D63499. Once that patch has landed, this patch should be safe to re-apply.

Tue, Jun 18, 9:52 AM · debug-info, Restricted Project
aprantl created D63499: Add debug location verification for !llvm.loop attachments.
Tue, Jun 18, 9:52 AM · Restricted Project, debug-info
Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

There is one thing I don't understand:
It looks like !680 is only used in the !llvm.loop !679 metadata. How can that trigger a !dbg attachment points at wrong subprogram for function verifier failure?

Tue, Jun 18, 2:24 AM · debug-info, Restricted Project

Mon, Jun 17

djtodoro added inline comments to D58033: Add option for emitting dbg info for call site parameters.
Mon, Jun 17, 11:22 PM · debug-info
probinson added inline comments to D58033: Add option for emitting dbg info for call site parameters.
Mon, Jun 17, 11:39 AM · debug-info
probinson added a comment to D54348: Permit multiple .file directives with -g.

As I mentioned in PR38449, I plan to look at this starting this week. Even benign situations such as

foo:
.file 1 "a.c"

are tripping over the assertion. I think the correct tactic is not to remove the places that are doing the checks, but make those places do a better job of tidying up anything that had been done in response to the command-line -g in favor of allowing the embedded directives to DTRT.

Mon, Jun 17, 10:21 AM · Restricted Project, debug-info
aprantl added a project to D63387: clang: Promote -fdebug-compilation-dir from cc1 flag to driver-level flag: debug-info.
Mon, Jun 17, 10:07 AM · debug-info, Restricted Project
aprantl added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

This seems to be a case of having old, incorrect, metadata baked into the test.
The 'startLoc' (!680) and 'endLoc' (!681) in loop metadta for loop !679 are both
missing an 'inlinedAt' node.

Mon, Jun 17, 10:02 AM · debug-info, Restricted Project
Orlando added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

Hi Adrian.

Mon, Jun 17, 2:36 AM · debug-info, Restricted Project

Fri, Jun 14

aprantl requested changes to D63361: Pretend NRVO variables are references so they can be found by debug info.
Fri, Jun 14, 4:25 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D63361: Pretend NRVO variables are references so they can be found by debug info.
  • fix test case
Fri, Jun 14, 4:21 PM · debug-info, Restricted Project, Restricted Project
aprantl added a project to D63361: Pretend NRVO variables are references so they can be found by debug info: debug-info.
Fri, Jun 14, 4:21 PM · debug-info, Restricted Project, Restricted Project
aprantl accepted D61062: Keep call site info valid through the backend.
Fri, Jun 14, 1:09 PM · Restricted Project, debug-info
NikolaPrica added a comment to D61062: Keep call site info valid through the backend.

Ping. Do we need to explain our concern more precisely?

Fri, Jun 14, 1:25 AM · Restricted Project, debug-info

Thu, Jun 13

MaskRay added a member for debug-info: MaskRay.
Thu, Jun 13, 8:21 PM
ychen added a member for debug-info: ychen.
Thu, Jun 13, 7:37 PM
aemerson closed D63286: [GlobalISel][IRTranslator] Don't add debug info to constants emitted into the entry block.
Thu, Jun 13, 3:12 PM · debug-info, Restricted Project
dsanders accepted D63286: [GlobalISel][IRTranslator] Don't add debug info to constants emitted into the entry block.

LGTM

Thu, Jun 13, 2:55 PM · debug-info, Restricted Project
aemerson updated the diff for D63286: [GlobalISel][IRTranslator] Don't add debug info to constants emitted into the entry block.

Use a debug loc with line 0 instead, fix a test that should have been using fastisel.

Thu, Jun 13, 1:03 PM · debug-info, Restricted Project