Page MenuHomePhabricator

debug-infoProject
ActivePublic

Recent Activity

Today

dstenb closed D73167: Don't separate imp/expl def handling for call site params.
Mon, Jan 27, 2:34 AM · Restricted Project, debug-info
jhenderson added inline comments to D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..
Mon, Jan 27, 1:34 AM · Restricted Project, debug-info

Yesterday

SouraVX updated the diff for D72828: [DWARF5] Added support for emission of debug_macro section..

Comments emission in ASM for macinfo section. completed! + Rebase.

Sun, Jan 26, 4:38 AM · Restricted Project, debug-info

Sat, Jan 25

dblaikie added inline comments to D72900: [DebugInfo] Support 64-bit DWARF for .debug_names..
Sat, Jan 25, 12:12 AM · Restricted Project, debug-info
dblaikie added inline comments to D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..
Sat, Jan 25, 12:03 AM · Restricted Project, debug-info

Fri, Jan 24

dblaikie accepted D73264: [DWARF] Do not pass Version to DWARFExpression..
Fri, Jan 24, 7:53 PM · Restricted Project, debug-info
dblaikie added inline comments to D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name.
Fri, Jan 24, 7:53 PM · debug-info
ikudrin added a comment to D72900: [DebugInfo] Support 64-bit DWARF for .debug_names..

Ping.

Fri, Jan 24, 5:48 PM · Restricted Project, debug-info
ikudrin updated the diff for D73264: [DWARF] Do not pass Version to DWARFExpression..
  • Add an explanatory comment to the test.
Fri, Jan 24, 5:39 PM · Restricted Project, debug-info
aprantl added inline comments to D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name.
Fri, Jan 24, 4:36 PM · debug-info
aprantl added a reviewer for D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name: dblaikie.
Fri, Jan 24, 4:36 PM · debug-info
kamleshbhalui added a comment to D73159: ARM64: Debug info for structure argument missing DW_AT_location.

I do not have commit access.
can someone commit this?

Fri, Jan 24, 4:09 PM · Restricted Project, debug-info
aprantl accepted D73054: Prevent explosion of debug intrinsics during jump threading.
Fri, Jan 24, 2:36 PM · debug-info, Restricted Project
aprantl accepted D73004: llvm-dwarfdump][Statistics] Make calculations of vars in global scope more accurate.

Nice.

Fri, Jan 24, 2:26 PM · Restricted Project, debug-info
aprantl accepted D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

Hmm.. it looks lika a bug.

@aprantl What do you think?

Fri, Jan 24, 2:26 PM · debug-info, Restricted Project
vsk added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Thanks @djtodoro for looking at this. Sorry for this really delayed response!

This was initially going to be a ping, but as a result of some light offline
discussion I have a few questions. For clarification an "overlap" here refers to
a partial overlap between fragments in DIExpressions.

Fri, Jan 24, 2:17 PM · Restricted Project, debug-info
probinson accepted D73264: [DWARF] Do not pass Version to DWARFExpression..

LGTM but give @dblaikie a chance to say whether he accepts my explanation.

Fri, Jan 24, 1:04 PM · Restricted Project, debug-info
dblaikie added inline comments to D73264: [DWARF] Do not pass Version to DWARFExpression..
Fri, Jan 24, 11:57 AM · Restricted Project, debug-info
dsanders accepted D73159: ARM64: Debug info for structure argument missing DW_AT_location.

LGTM

Fri, Jan 24, 10:43 AM · Restricted Project, debug-info
vsk accepted D73168: Improvements to call site register worklist.

Lgtm!

Fri, Jan 24, 10:41 AM · Restricted Project, debug-info
krisb added a comment to D73002: [llvm-dwarfdump][Statistics] Count more than one concrete out-of-line instance of a function.

@aprantl thanks for the review! Are you okay with this test?

Fri, Jan 24, 10:13 AM · Restricted Project, debug-info
TWeaver closed D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.
Fri, Jan 24, 8:32 AM · Restricted Project, debug-info
dstenb added inline comments to D73168: Improvements to call site register worklist.
Fri, Jan 24, 7:27 AM · Restricted Project, debug-info
dstenb added inline comments to D73168: Improvements to call site register worklist.
Fri, Jan 24, 7:26 AM · Restricted Project, debug-info
dstenb updated the diff for D73168: Improvements to call site register worklist.

Address review comments. Reword a test description slightly.

Fri, Jan 24, 7:17 AM · Restricted Project, debug-info
djtodoro added a comment to D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions.

I agree, we must pay attention and address the bitcode compatibility.

Fri, Jan 24, 7:00 AM · Restricted Project, Restricted Project, debug-info
probinson added a comment to D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions.

Is it necessary to use DIFlags? I am willing to do that but generally, it is not welcomed because we have a limited number of DIFlags and most of them are currently in use.

Are there any flags within DIFlags that could be applied only to functions? If so, we should move them in to the DISPFlags in order to make some space within the DIFlags.

Fri, Jan 24, 6:58 AM · Restricted Project, Restricted Project, debug-info
djtodoro added a comment to D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions.

Is it necessary to use DIFlags? I am willing to do that but generally, it is not welcomed because we have a limited number of DIFlags and most of them are currently in use.

Fri, Jan 24, 5:28 AM · Restricted Project, Restricted Project, debug-info
ikudrin updated the diff for D73264: [DWARF] Do not pass Version to DWARFExpression..
  • Rebase, Update;
  • Add a test.
Fri, Jan 24, 2:46 AM · Restricted Project, debug-info
awpandey updated the diff for D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions.

Hi @probinson, I have changed the patch according to your comments.

Fri, Jan 24, 1:59 AM · Restricted Project, Restricted Project, debug-info
djtodoro closed D73266: [DWARF][test] Test all the call-site realted attrs.
Fri, Jan 24, 1:55 AM · Restricted Project, debug-info
jhenderson added inline comments to D70720: [llvm-objdump] Display locations of variables alongside disassembly.
Fri, Jan 24, 1:06 AM · debug-info, Restricted Project
dstenb accepted D73266: [DWARF][test] Test all the call-site realted attrs.

LGTM. Thanks!

Fri, Jan 24, 12:57 AM · Restricted Project, debug-info

Thu, Jan 23

djtodoro added inline comments to D73168: Improvements to call site register worklist.
Thu, Jan 23, 11:54 PM · Restricted Project, debug-info
djtodoro added inline comments to D73167: Don't separate imp/expl def handling for call site params.
Thu, Jan 23, 11:28 PM · Restricted Project, debug-info
djtodoro accepted D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.
Thu, Jan 23, 11:28 PM · Restricted Project, debug-info
djtodoro updated the diff for D73266: [DWARF][test] Test all the call-site realted attrs.

-Update the RUN line
-Add the line for dwarf5 without LLDB tuning

Thu, Jan 23, 11:19 PM · Restricted Project, debug-info
djtodoro added a comment to D73266: [DWARF][test] Test all the call-site realted attrs.

@vsk @dstenb Thanks!

Thu, Jan 23, 11:19 PM · Restricted Project, debug-info
kamleshbhalui updated the diff for D73159: ARM64: Debug info for structure argument missing DW_AT_location.

rebased and updated diff to original patch.
Thanks @vsk and @dsanders for reviewing.

Thu, Jan 23, 5:00 PM · Restricted Project, debug-info
vsk added a comment to D73159: ARM64: Debug info for structure argument missing DW_AT_location.

Thanks Daniel. If it's safe not to mark dbg values for removal here, that seems like the best option.

Thu, Jan 23, 3:41 PM · Restricted Project, debug-info
dsanders added inline comments to D73159: ARM64: Debug info for structure argument missing DW_AT_location.
Thu, Jan 23, 3:21 PM · Restricted Project, debug-info
aprantl added a reviewer for D73283: Handle complex DWARF expressions in combination with "complex" registers: probinson.
Thu, Jan 23, 1:43 PM · Restricted Project, debug-info
aprantl added inline comments to D73283: Handle complex DWARF expressions in combination with "complex" registers.
Thu, Jan 23, 1:43 PM · Restricted Project, debug-info
vsk added a comment to D73168: Improvements to call site register worklist.

This is looking really nice. Thanks!

Thu, Jan 23, 1:43 PM · Restricted Project, debug-info
aprantl added inline comments to D73283: Handle complex DWARF expressions in combination with "complex" registers.
Thu, Jan 23, 1:42 PM · Restricted Project, debug-info
probinson added a comment to D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions.

I put in a lot of comments about spelling for the new parameter (constExpr, isConstexpr, isConstExpr) which should be named consistently throughout. Please do not use Constant or any variant, as that tends to mean something else.

Thu, Jan 23, 12:47 PM · Restricted Project, Restricted Project, debug-info
avl added a comment to D72915: [Dsymutil][Debuginfo][NFC] #4 Refactor dsymutil to separate DWARF optimizing part..

@JDevlieghere Jonas, Thank you for reviewing this set of patches for dsymutil!

Thu, Jan 23, 11:41 AM · debug-info, Restricted Project
aprantl updated the diff for D73283: Handle complex DWARF expressions in combination with "complex" registers.
Thu, Jan 23, 10:58 AM · Restricted Project, debug-info
aprantl added a parent revision for D73283: Handle complex DWARF expressions in combination with "complex" registers: D72938: Fix an assertion failure in DwarfExpression's subregister composition.
Thu, Jan 23, 10:55 AM · Restricted Project, debug-info
aprantl added a child revision for D72938: Fix an assertion failure in DwarfExpression's subregister composition: D73283: Handle complex DWARF expressions in combination with "complex" registers.
Thu, Jan 23, 10:55 AM · Restricted Project, debug-info