Page MenuHomePhabricator

[clang-format] [NFC] add recent changes to release notes

Authored by MyDeveloperDay on Nov 16 2019, 4:08 AM.



clang-tidy keeps nice release notes of what is added, have clang-format do the same.

Diff Detail

Event Timeline

MyDeveloperDay created this revision.Nov 16 2019, 4:08 AM

@Eugene.Zelenko I've noticed you are always giving excellent review feedback in clang-tidy especially around the documentation, I'd appreciate your eyes on finding the right level of documentation here.

Build result: pass - 60143 tests passed, 0 failed and 729 were skipped.
Log files: console-log.txt, CMakeCache.txt

General comments:

  • Isn't Option(s) ... was/were added or Option(s) ... had been added are more correct from from point of view of English grammar? Same for older entries.
  • It'll be great to nag developers to expand Release Notes when relevant code changes are made.

and between Options and DeriveLineEnding are not necessary.


I would suggest to use dot after newlines.


UseCRLF should be enclosed in double back-ticks.


to insert?

Address review comments
Remove excessive newlines
Remove trailing whitespace

MyDeveloperDay marked 4 inline comments as done.Nov 16 2019, 6:16 AM
MyDeveloperDay edited the summary of this revision. (Show Details)Nov 18 2019, 12:28 AM
This revision is now accepted and ready to land.Nov 18 2019, 10:06 AM
This revision was automatically updated to reflect the committed changes.