Page MenuHomePhabricator

mitchell-stellar (Mitchell)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 1 2019, 1:21 PM (6 w, 6 h)

Recent Activity

Fri, Nov 8

mitchell-stellar accepted D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst.

LGTM

Fri, Nov 8, 11:21 AM · Restricted Project, Restricted Project
mitchell-stellar added inline comments to D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst.
Fri, Nov 8, 9:58 AM · Restricted Project, Restricted Project
mitchell-stellar added inline comments to D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst.
Fri, Nov 8, 6:43 AM · Restricted Project, Restricted Project
mitchell-stellar added inline comments to D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst.
Fri, Nov 8, 6:25 AM · Restricted Project, Restricted Project
mitchell-stellar accepted D70003: [clang-format] Ensure dump_format_style.py can generate ClangFormatStyleOptions.rst without manual intervention.

LGTM

Fri, Nov 8, 6:25 AM · Restricted Project, Restricted Project

Wed, Nov 6

mitchell-stellar accepted D56345: [clang-format] Assert that filenames are not empty.

LGTM

Wed, Nov 6, 5:29 AM · Restricted Project, Restricted Project

Thu, Oct 31

mitchell-stellar committed rG8d7bd5752648: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref"… (authored by mitchell-stellar).
[clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref"…
Thu, Oct 31, 8:18 AM
mitchell-stellar closed D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref" Parameter.
Thu, Oct 31, 8:18 AM · Restricted Project, Restricted Project
mitchell-stellar added a comment to D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref" Parameter.

Never mind, I got it resolved and pushed. Sorry for the noise.

Thu, Oct 31, 8:18 AM · Restricted Project, Restricted Project
mitchell-stellar added a comment to D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref" Parameter.

Thanks. Would you mind committing this on my behalf? It seems I wasn't migrated from SVN access to git access. It may take some time to sort out.

Thu, Oct 31, 7:13 AM · Restricted Project, Restricted Project

Wed, Oct 30

mitchell-stellar created D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref" Parameter.
Wed, Oct 30, 4:04 PM · Restricted Project, Restricted Project

Tue, Oct 29

mitchell-stellar added a comment to D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2).

Sounds like you know what you're doing.

Tue, Oct 29, 7:30 AM · Restricted Project, Restricted Project
mitchell-stellar accepted D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2).
Tue, Oct 29, 7:30 AM · Restricted Project, Restricted Project

Fri, Oct 25

mitchell-stellar added inline comments to D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2).
Fri, Oct 25, 2:01 PM · Restricted Project, Restricted Project
mitchell-stellar added inline comments to D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2).
Fri, Oct 25, 8:43 AM · Restricted Project, Restricted Project
mitchell-stellar accepted D69404: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct..

LGTM.

Fri, Oct 25, 6:31 AM · Restricted Project, Restricted Project

Thu, Oct 17

mitchell-stellar accepted D68346: [clang-format] Add new option to add spaces around conditions.

LGTM

Thu, Oct 17, 6:52 AM · Restricted Project, Restricted Project

Tue, Oct 15

mitchell-stellar requested changes to D68346: [clang-format] Add new option to add spaces around conditions.
Tue, Oct 15, 11:45 AM · Restricted Project, Restricted Project

Oct 9 2019

mitchell-stellar accepted D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl.

Okay.

Oct 9 2019, 11:08 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar added a comment to D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl.

To me, whether or not the assertion was valid is irrelevant. That assertion was intentionally added, and its replacement with an if() statement materially changes the inputs and outputs of the function. I'm questioning whether the input of a "while" token within a preprocessor statement should output true or false. (Before, it didn't output anything; it errored.) Does this make sense? I'm just asking for clarification on this change.

Oct 9 2019, 9:59 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar added inline comments to D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl.
Oct 9 2019, 8:44 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay awarded rG791b0e416016: [NFC] Test commit. Testing llvm commit access only. a Like token.
Oct 9 2019, 8:20 AM
mitchell-stellar committed rG77c9736ef3e0: [NFC] Reverting changes from test commit. llvm commit access test succeeded. (authored by mitchell-stellar).
[NFC] Reverting changes from test commit. llvm commit access test succeeded.
Oct 9 2019, 8:17 AM
mitchell-stellar committed rG791b0e416016: [NFC] Test commit. Testing llvm commit access only. (authored by mitchell-stellar).
[NFC] Test commit. Testing llvm commit access only.
Oct 9 2019, 8:17 AM

Oct 7 2019

mitchell-stellar added a comment to D68554: [clang-format] Proposal for clang-format to give compiler style warnings.

I don't care for the command line switches that try to emulate compiler flags. I am also of the opinion that external scripts should be used for this functionality. git for Windows gives you a full set of bash utilities to utilize, so doing stuff like this on Windows is much easier now.

Oct 7 2019, 9:51 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar updated subscribers of D29039: [clang-format] Proposal for clang-format -r option.

I agree with @djasper that this is outside the scope of clang-format. git for Windows gives you a full set of bash utilities to utilize, so doing stuff like this on Windows is much easier now.

Oct 7 2019, 9:45 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar accepted D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted..

I agree that a system in place that either enforces clang-formatting on commit or after the fact would be ideal. Otherwise, I don't see a need to have to approve these NFC commits.

Oct 7 2019, 9:34 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar accepted D68481: [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete().

LGTM

Oct 7 2019, 9:27 AM · Restricted Project, Restricted Project, Restricted Project

Oct 4 2019

mitchell-stellar requested changes to D68481: [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete().
Oct 4 2019, 2:30 PM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar added a comment to D68473: [clang-format] SpacesInSquareBrackets should affect lambdas with parameters too.

Thanks, please commit on my behalf.

Oct 4 2019, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar created D68473: [clang-format] SpacesInSquareBrackets should affect lambdas with parameters too.
Oct 4 2019, 10:26 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar requested changes to D67773: [clang-format[PR43144] Add support for SpaceAroundBraces style .

This needs to be more thought out. At the very least it needs to cover more keywords like do, switch, try, and catch. There may be more. Consideration also needs to be made for class, functions, namespace, etc. Otherwise this is an experimental feature at best. There is also confusion with how it may interact with SpaceBeforeCpp11BracedList. The name SpacesAroundBraces is just too generic in that regard considering the fact that braces play multiple roles in C++.

Oct 4 2019, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar accepted D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators.

LGTM

Oct 4 2019, 7:12 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar updated the diff for D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting.

Fixed empty parentheses unit test for C++11 braced initializer list.

Oct 4 2019, 7:02 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar added a comment to D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting.

You are correct. I'll work on this.

Oct 4 2019, 6:59 AM · Restricted Project, Restricted Project, Restricted Project

Oct 3 2019

mitchell-stellar added a comment to D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting.

Thanks. Please commit on my behalf when you have a chance.

Oct 3 2019, 1:23 PM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar added a comment to D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting.

If you want spaces in your C++11 initializers and nothing else, then you don't want the Cpp11BracedListStyle setting enabled. Turning it off gives you spaces inside without affecting anything else.

Oct 3 2019, 1:07 PM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar requested changes to D68346: [clang-format] Add new option to add spaces around conditions.
Oct 3 2019, 1:02 PM · Restricted Project, Restricted Project
mitchell-stellar updated the diff for D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting.

Added additional unit tests to verify that the SpaceInEmptyParentheses setting is also correctly adhered to.

Oct 3 2019, 12:55 PM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar added a comment to D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting.

I don't think that's a good idea, considering the fact that braces can mean different things in different contexts, and it would cause trouble for existing clang-format settings.

Oct 3 2019, 12:45 PM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar requested changes to D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators.
Oct 3 2019, 12:36 PM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar created D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting.
Oct 3 2019, 12:13 PM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar accepted D67629: [clang-format] [PR43333] Fix C# breaking before function name when using Attributes.

LGTM

Oct 3 2019, 12:04 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mitchell-stellar accepted D67660: [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords.

LGTM

Oct 3 2019, 11:48 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar added a comment to D68242: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading.

LGTM

Oct 3 2019, 11:33 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar accepted D68242: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading.
Oct 3 2019, 11:33 AM · Restricted Project, Restricted Project, Restricted Project
mitchell-stellar updated the diff for D68296: [clang-format] Add ability to wrap braces after multi-line control statements.

Rebased against master, and also added test case for 'do' statements.

Oct 3 2019, 11:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 2 2019

mitchell-stellar added inline comments to D68296: [clang-format] Add ability to wrap braces after multi-line control statements.
Oct 2 2019, 2:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mitchell-stellar updated the summary of D68296: [clang-format] Add ability to wrap braces after multi-line control statements.
Oct 2 2019, 1:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mitchell-stellar updated the diff for D68296: [clang-format] Add ability to wrap braces after multi-line control statements.

Renamed "OnlyMultiLine" option to "MultiLine", per reviewer request.

Oct 2 2019, 1:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mitchell-stellar added a comment to D68296: [clang-format] Add ability to wrap braces after multi-line control statements.

@MyDeveloperDay I am not wedded to "OnlyMultiLine". I picked it, as it seemed reasonable to me, but if you think another string expresses the intent better, then feel free to use it.

Oct 2 2019, 12:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ideasman42 awarded D68296: [clang-format] Add ability to wrap braces after multi-line control statements a Love token.
Oct 2 2019, 10:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mitchell-stellar updated the diff for D68296: [clang-format] Add ability to wrap braces after multi-line control statements.

Thanks for the review. I have added documentation updates.

Oct 2 2019, 7:53 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 1 2019

mitchell-stellar created D68296: [clang-format] Add ability to wrap braces after multi-line control statements.
Oct 1 2019, 2:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project