sammccall (Sam McCall)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 26 2016, 6:53 AM (111 w, 4 d)
Roles
Administrator

Recent Activity

Today

sammccall committed rL344620: [clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction..
[clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction.
Tue, Oct 16, 9:50 AM
sammccall committed rCTE344620: [clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction..
[clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction.
Tue, Oct 16, 9:50 AM
sammccall closed D53286: [clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction..
Tue, Oct 16, 9:50 AM
sammccall updated the diff for D53266: [clangd] Simplify client capabilities parsing..

Rebase to include CodeAction literal support

Tue, Oct 16, 9:42 AM
sammccall committed rCTE344617: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8).
[clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8)
Tue, Oct 16, 9:32 AM
sammccall committed rL344617: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8).
[clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8)
Tue, Oct 16, 9:31 AM
sammccall closed D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8).
Tue, Oct 16, 9:31 AM
sammccall added inline comments to D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8).
Tue, Oct 16, 9:30 AM
sammccall updated the diff for D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8).

rebase only

Tue, Oct 16, 9:30 AM
sammccall added inline comments to D53286: [clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction..
Tue, Oct 16, 9:25 AM
sammccall updated the diff for D53286: [clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction..

Addressed review comments.
Also inverted the sense of the boolean return from onNotify etc, was "should
exit" and is now "should continue", which I think is slightly clearer.

Tue, Oct 16, 9:25 AM
sammccall accepted D53220: Remove possibility to change compile database path at runtime.

Still LG!

Tue, Oct 16, 8:50 AM
sammccall accepted D53322: [clangd] Collect refs from headers..

(please do check there are no duplicates in the output)

Tue, Oct 16, 8:38 AM
sammccall added a comment to D53322: [clangd] Collect refs from headers..

This looks reasonable. +80% to index size is a shame, but not disastrous, and we have ways to shave it.

Tue, Oct 16, 7:52 AM
sammccall added inline comments to D53131: [clangd] Support scope proximity in code completion..
Tue, Oct 16, 7:29 AM
sammccall updated the diff for D53286: [clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction..

Add unit test for JSON transport.

Tue, Oct 16, 4:37 AM
sammccall accepted D53317: [clangd] Allow disble down traversals from root..

Works for me! I think the code can be simplified slightly.

Tue, Oct 16, 3:23 AM
sammccall committed rCTE344595: [clangd] Fix threading bugs in (not-yet-used) BackgroundIndex, re-enable test..
[clangd] Fix threading bugs in (not-yet-used) BackgroundIndex, re-enable test.
Tue, Oct 16, 2:07 AM
sammccall committed rL344595: [clangd] Fix threading bugs in (not-yet-used) BackgroundIndex, re-enable test..
[clangd] Fix threading bugs in (not-yet-used) BackgroundIndex, re-enable test.
Tue, Oct 16, 2:07 AM
sammccall closed D53313: [clangd] Fix threading bugs in (not-yet-used) BackgroundIndex, re-enable test..
Tue, Oct 16, 2:07 AM
sammccall committed rCTE344594: [clangd] Optionally use dex for the preamble parts of the dynamic index..
[clangd] Optionally use dex for the preamble parts of the dynamic index.
Tue, Oct 16, 1:56 AM
sammccall committed rL344594: [clangd] Optionally use dex for the preamble parts of the dynamic index..
[clangd] Optionally use dex for the preamble parts of the dynamic index.
Tue, Oct 16, 1:55 AM
sammccall closed D53288: [clangd] Optionally use dex for the preamble parts of the dynamic index..
Tue, Oct 16, 1:55 AM
sammccall created D53313: [clangd] Fix threading bugs in (not-yet-used) BackgroundIndex, re-enable test..
Tue, Oct 16, 1:51 AM
sammccall added a comment to D53312: [clangd] Support limiting down traversals from sources in FileDistance..

The slightly weird down-traversals semantics are indeed slightly weird. I'm happy to move forward with this approach though if we document it.

Tue, Oct 16, 1:44 AM

Yesterday

sammccall committed rCTE344586: [clangd] Disable timeouting test while investigating.
[clangd] Disable timeouting test while investigating
Mon, Oct 15, 11:37 PM
sammccall committed rL344586: [clangd] Disable timeouting test while investigating.
[clangd] Disable timeouting test while investigating
Mon, Oct 15, 11:37 PM
sammccall committed rL344533: [clangd] Revert include path change in Dexp. NFC.
[clangd] Revert include path change in Dexp. NFC
Mon, Oct 15, 9:49 AM
sammccall committed rCTE344533: [clangd] Revert include path change in Dexp. NFC.
[clangd] Revert include path change in Dexp. NFC
Mon, Oct 15, 9:49 AM
sammccall accepted D53220: Remove possibility to change compile database path at runtime.

I think it'd be a good idea to separate out the on-initialization vs dynamically-changing parameters more - I think they should probably be disjoint in fact.

Mon, Oct 15, 9:44 AM
sammccall added a comment to D53286: [clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction..

For reference, @jkorous has a WIP in D53290.
It's scope is a superset, and I think everything in common is basically the same (they were both based on a common prototype).
Jan is out at the moment, so I think it makes sense to move ahead with this piece - it's progress, and the smaller scope makes landing the change easier.

Mon, Oct 15, 8:20 AM
sammccall accepted D53292: [clangd] Add createIndex in dexp.
Mon, Oct 15, 8:07 AM
sammccall committed rCTE344520: [clangd] Use SyncAPI in more places in tests. NFC.
[clangd] Use SyncAPI in more places in tests. NFC
Mon, Oct 15, 8:06 AM
sammccall committed rL344520: [clangd] Use SyncAPI in more places in tests. NFC.
[clangd] Use SyncAPI in more places in tests. NFC
Mon, Oct 15, 8:06 AM
sammccall created D53288: [clangd] Optionally use dex for the preamble parts of the dynamic index..
Mon, Oct 15, 7:28 AM
sammccall committed rL344513: [clangd] Minimal implementation of automatic static index (not enabled)..
[clangd] Minimal implementation of automatic static index (not enabled).
Mon, Oct 15, 6:36 AM
sammccall committed rCTE344513: [clangd] Minimal implementation of automatic static index (not enabled)..
[clangd] Minimal implementation of automatic static index (not enabled).
Mon, Oct 15, 6:36 AM
sammccall closed D53032: [clangd] Minimal implementation of automatic static index, behind a flag..
Mon, Oct 15, 6:36 AM
sammccall added inline comments to D53032: [clangd] Minimal implementation of automatic static index, behind a flag..
Mon, Oct 15, 6:30 AM
sammccall updated the diff for D53032: [clangd] Minimal implementation of automatic static index, behind a flag..

Address comments, strip out of clangdlspserver for now.

Mon, Oct 15, 6:29 AM
sammccall added a comment to D53286: [clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction..

This patch is big and hard to navigate. I tried to keep it contained, but JSONRPCDispatcher is pretty tangled.

Mon, Oct 15, 5:48 AM
sammccall added inline comments to D53019: [clangd] dump xrefs information in dexp tool..
Mon, Oct 15, 5:42 AM
sammccall created D53286: [clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction..
Mon, Oct 15, 5:41 AM
sammccall accepted D53284: [CodeComplete] Make sure keyword 'template' is added even when code pattern is disabled..
Mon, Oct 15, 5:09 AM
sammccall accepted D53273: [clangd] Fix some references missing in dynamic index..
Mon, Oct 15, 3:33 AM
sammccall accepted D53019: [clangd] dump xrefs information in dexp tool..
Mon, Oct 15, 3:32 AM
sammccall added a comment to D53273: [clangd] Fix some references missing in dynamic index..

Nice fix, just performance concerns.

Mon, Oct 15, 2:23 AM

Sun, Oct 14

sammccall added a comment to D53192: [clangd] Do not query index for new name completions..

(This looks good, of course the Sema patch needs to land first!)

Sun, Oct 14, 11:54 PM
sammccall added a reviewer for D53220: Remove possibility to change compile database path at runtime: sammccall.
Sun, Oct 14, 11:41 PM
sammccall added a comment to D53220: Remove possibility to change compile database path at runtime.

Thanks for cleaning this up!

Sun, Oct 14, 11:40 PM
sammccall added inline comments to D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8).
Sun, Oct 14, 11:30 PM
sammccall updated the diff for D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8).

update comment

Sun, Oct 14, 11:30 PM
sammccall created D53266: [clangd] Simplify client capabilities parsing..
Sun, Oct 14, 11:18 PM

Fri, Oct 12

sammccall created D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8).
Fri, Oct 12, 1:10 PM
sammccall committed rL344363: [clangd] Return Command objects from onCodeAction, rather than ad-hoc JSON. NFC.
[clangd] Return Command objects from onCodeAction, rather than ad-hoc JSON. NFC
Fri, Oct 12, 9:54 AM
sammccall committed rCTE344363: [clangd] Return Command objects from onCodeAction, rather than ad-hoc JSON. NFC.
[clangd] Return Command objects from onCodeAction, rather than ad-hoc JSON. NFC
Fri, Oct 12, 9:54 AM
sammccall added inline comments to D53032: [clangd] Minimal implementation of automatic static index, behind a flag..
Fri, Oct 12, 9:52 AM
sammccall accepted D53202: [python] [tests] Remove cdb lookup failure test.

We could verify the fuzzy-matched results, but we have pretty good testing on the C++ side, so a smoke test here seems fine.

Fri, Oct 12, 9:42 AM
sammccall added inline comments to D53032: [clangd] Minimal implementation of automatic static index, behind a flag..
Fri, Oct 12, 8:40 AM
sammccall added inline comments to D53032: [clangd] Minimal implementation of automatic static index, behind a flag..
Fri, Oct 12, 8:21 AM
sammccall added inline comments to D53032: [clangd] Minimal implementation of automatic static index, behind a flag..
Fri, Oct 12, 7:50 AM
sammccall updated the diff for D53032: [clangd] Minimal implementation of automatic static index, behind a flag..

Oops, forgot one comment.

Fri, Oct 12, 7:50 AM
sammccall updated the diff for D53032: [clangd] Minimal implementation of automatic static index, behind a flag..

Address comments, add tests.
Some changes (enqueue(), blockUntilIdleForTest()) to support testing.

Fri, Oct 12, 7:46 AM
sammccall added inline comments to D53032: [clangd] Minimal implementation of automatic static index, behind a flag..
Fri, Oct 12, 7:45 AM
sammccall committed rC344337: Remove top-level using declaration from header files, as these aliases leak..
Remove top-level using declaration from header files, as these aliases leak.
Fri, Oct 12, 5:23 AM
sammccall committed rL344337: Remove top-level using declaration from header files, as these aliases leak..
Remove top-level using declaration from header files, as these aliases leak.
Fri, Oct 12, 5:23 AM
sammccall closed D53135: Remove top-level using declaration from header files, as these aliases leak..
Fri, Oct 12, 5:23 AM
sammccall added inline comments to D53191: [clang] Use Statement and Namespace instead of Name and PotentiallyQualifiedName.
Fri, Oct 12, 5:20 AM
sammccall added a comment to D53131: [clangd] Support scope proximity in code completion..

(BTW I wouldn't expect to see improvements on eval here, as

Fri, Oct 12, 4:49 AM
sammccall added inline comments to D53135: Remove top-level using declaration from header files, as these aliases leak..
Fri, Oct 12, 3:59 AM

Thu, Oct 11

sammccall updated subscribers of D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files.

Sorry about that. I wasn't familiar with the python bindings.
Your bisect is correct, we changed the behavior that test is testing: now
an approximate match will be returned.

Thu, Oct 11, 11:58 PM
sammccall created D53145: [Tooling] Support src/buildroot to find the build-root, and expose it..
Thu, Oct 11, 10:10 AM
sammccall committed rC344247: [Tooling] Move CompilationDatabasePlugin to the Registry header, where it's….
[Tooling] Move CompilationDatabasePlugin to the Registry header, where it's…
Thu, Oct 11, 6:45 AM
sammccall committed rL344247: [Tooling] Move CompilationDatabasePlugin to the Registry header, where it's….
[Tooling] Move CompilationDatabasePlugin to the Registry header, where it's…
Thu, Oct 11, 6:44 AM
sammccall added a comment to D51725: Allow un-setting the compilation database path.

But I am wondering what to do with the feature that allows clangd to change compilation database path using the didChangeConfiguration notification. In my opinion, it's a bug that it's not possible to switch back to use no explicit compilation database path, so I'd still like to get this patch merged. Or, if we decide this is really not useful, then it should be removed. I don't think we should keep the feature in the current state, either we fix it or remove it.

I would question the usefulness of the option if Theia can live without it, so I'd vouch for removing it. @sammccall, WDYT? Especially wrt to auto-indexing and it being a customizable build directory?

Agree with you both here. Not being able to reset the initial state is weird, but *being able to* is complicated. (Even more so than switching between CDBs).
And since switching between CDBs invalidates almost everything, restarting clangd seems like a great simplification if it's viable for you.
Supporting a single CDB that's available on startup (either a flag, or maybe more likely set during initialize()?) would be a very useful simplification. (Even if it's not a lot of code, I find myself getting tangled in it often).

Thu, Oct 11, 6:27 AM
sammccall committed rCTE344245: [clangd] Remove no-op crash handler, we never set a crash context..
[clangd] Remove no-op crash handler, we never set a crash context.
Thu, Oct 11, 6:08 AM
sammccall committed rL344245: [clangd] Remove no-op crash handler, we never set a crash context..
[clangd] Remove no-op crash handler, we never set a crash context.
Thu, Oct 11, 6:08 AM
sammccall closed D53034: [clangd] Remove no-op crash handler, we never set a crash context..
Thu, Oct 11, 6:08 AM
sammccall added inline comments to D53131: [clangd] Support scope proximity in code completion..
Thu, Oct 11, 5:58 AM
sammccall created D53135: Remove top-level using declaration from header files, as these aliases leak..
Thu, Oct 11, 5:32 AM

Wed, Oct 10

sammccall committed rL344133: [CodeComplete] Fix crash when completing params function declarations..
[CodeComplete] Fix crash when completing params function declarations.
Wed, Oct 10, 3:54 AM
sammccall committed rC344133: [CodeComplete] Fix crash when completing params function declarations..
[CodeComplete] Fix crash when completing params function declarations.
Wed, Oct 10, 3:53 AM
sammccall closed D53070: [CodeComplete] Fix crash when completing params function declarations..
Wed, Oct 10, 3:53 AM
sammccall created D53070: [CodeComplete] Fix crash when completing params function declarations..
Wed, Oct 10, 3:09 AM
sammccall committed rCTE344118: [clangd] Make FSProvider const-correct. NFC.
[clangd] Make FSProvider const-correct. NFC
Wed, Oct 10, 12:49 AM
sammccall committed rL344118: [clangd] Make FSProvider const-correct. NFC.
[clangd] Make FSProvider const-correct. NFC
Wed, Oct 10, 12:48 AM

Tue, Oct 9

sammccall created D53034: [clangd] Remove no-op crash handler, we never set a crash context..
Tue, Oct 9, 12:04 PM
sammccall created D53032: [clangd] Minimal implementation of automatic static index, behind a flag..
Tue, Oct 9, 11:51 AM
sammccall added inline comments to D53019: [clangd] dump xrefs information in dexp tool..
Tue, Oct 9, 8:09 AM
sammccall added inline comments to D53019: [clangd] dump xrefs information in dexp tool..
Tue, Oct 9, 6:21 AM
sammccall committed rCTE344030: [clangd] Fix nondeterministic test.
[clangd] Fix nondeterministic test
Tue, Oct 9, 3:03 AM
sammccall committed rL344030: [clangd] Fix nondeterministic test.
[clangd] Fix nondeterministic test
Tue, Oct 9, 3:03 AM
sammccall accepted D53016: [clangd] Mark colon as a safe character when percent-encoding..
Tue, Oct 9, 2:58 AM
sammccall accepted D52889: [clangd] Revert back to previous heuristic for diagnostic range extraction..
Tue, Oct 9, 1:41 AM
sammccall accepted D52991: [clangd] Avoid cache main file status in preamble..
Tue, Oct 9, 1:08 AM

Mon, Oct 8

sammccall accepted D52976: [clangd] Update the out-of-date yaml-symbol-file flag in clangd..

Hmm, I wonder if we should remove "experimental" text and the hidden bit. Or wait to see if we want to move to automatic index entirely?
May want to mention "must have been created by a compatible clangd-indexer".

Mon, Oct 8, 3:30 AM

Fri, Oct 5

sammccall created D52937: [clangd] Add clangd.serverInfo command to inspect server state..
Fri, Oct 5, 9:58 AM
sammccall committed rCTE343849: [clangd] Remove last usage of ast matchers from SymbolCollector. NFC.
[clangd] Remove last usage of ast matchers from SymbolCollector. NFC
Fri, Oct 5, 7:05 AM
sammccall committed rL343849: [clangd] Remove last usage of ast matchers from SymbolCollector. NFC.
[clangd] Remove last usage of ast matchers from SymbolCollector. NFC
Fri, Oct 5, 7:04 AM
sammccall committed rCTE343845: [clangd] Remove debugging output in test.
[clangd] Remove debugging output in test
Fri, Oct 5, 5:24 AM