Page MenuHomePhabricator

sammccall (Sam McCall)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 26 2016, 6:53 AM (147 w, 4 d)
Roles
Administrator

Recent Activity

Today

sammccall updated the diff for D63760: [clangd] Address limitations in SelectionTree:.

Revert multi-range support. Add early hit detection (before children) instead.
Add more tests.

Tue, Jun 25, 1:59 PM · Restricted Project
sammccall planned changes to D63760: [clangd] Address limitations in SelectionTree:.

Thanks for the comments here and the offline discussion.

Tue, Jun 25, 9:37 AM · Restricted Project
sammccall added inline comments to D63759: [clangd] Don't rename the namespace..
Tue, Jun 25, 6:26 AM · Restricted Project
sammccall created D63760: [clangd] Address limitations in SelectionTree:.
Tue, Jun 25, 4:31 AM · Restricted Project
sammccall accepted D63759: [clangd] Don't rename the namespace..
Tue, Jun 25, 3:54 AM · Restricted Project
sammccall committed rG79f7831aa715: [clangd] Fix NestedNameSpecifierLoc in SelectionTree (authored by sammccall).
[clangd] Fix NestedNameSpecifierLoc in SelectionTree
Tue, Jun 25, 2:46 AM
sammccall committed rL364284: [clangd] Fix NestedNameSpecifierLoc in SelectionTree.
[clangd] Fix NestedNameSpecifierLoc in SelectionTree
Tue, Jun 25, 2:45 AM
sammccall closed D63708: [clangd] Fix NestedNameSpecifierLoc in SelectionTree.
Tue, Jun 25, 2:44 AM · Restricted Project, Restricted Project

Yesterday

sammccall committed rGca89eb5f9c9d: [clangd] Improve SelectionTree string representation (authored by sammccall).
[clangd] Improve SelectionTree string representation
Mon, Jun 24, 6:03 AM
sammccall committed rL364180: [clangd] Improve SelectionTree string representation.
[clangd] Improve SelectionTree string representation
Mon, Jun 24, 6:02 AM
sammccall created D63708: [clangd] Fix NestedNameSpecifierLoc in SelectionTree.
Mon, Jun 24, 5:05 AM · Restricted Project, Restricted Project
sammccall accepted D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping.
Mon, Jun 24, 4:46 AM · Restricted Project, Restricted Project
sammccall accepted D63330: [clangd] Add Value field to HoverInfo.

Implementation LG though please do check that the new test results look useful and not too duplicative

Mon, Jun 24, 3:21 AM · Restricted Project
sammccall accepted D63426: [clangd] Narrow rename to local symbols..
Mon, Jun 24, 3:01 AM · Restricted Project, Restricted Project
sammccall accepted D62804: [clangd] Enable extraction of system includes from custom toolchains.
Mon, Jun 24, 2:35 AM · Restricted Project

Wed, Jun 19

sammccall added a comment to D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping.

Sorry, I'm having trouble understanding this patch. Can you try to find some clearer names for the new concepts, or describe how they differ?

Wed, Jun 19, 12:50 AM · Restricted Project, Restricted Project
sammccall committed rG08372eb73bf0: Revert "[clangd] Return vector<TextEdit> from applyTweak. NFC" (authored by sammccall).
Revert "[clangd] Return vector<TextEdit> from applyTweak. NFC"
Wed, Jun 19, 12:27 AM
sammccall committed rG38047dbca4e7: [clangd] Add ClangdServer accessor for buffer contents (authored by sammccall).
[clangd] Add ClangdServer accessor for buffer contents
Wed, Jun 19, 12:26 AM
sammccall committed rL363766: Revert "[clangd] Return vector<TextEdit> from applyTweak. NFC".
Revert "[clangd] Return vector<TextEdit> from applyTweak. NFC"
Wed, Jun 19, 12:26 AM
sammccall committed rL363765: [clangd] Add ClangdServer accessor for buffer contents.
[clangd] Add ClangdServer accessor for buffer contents
Wed, Jun 19, 12:26 AM

Tue, Jun 18

sammccall added a comment to D63426: [clangd] Narrow rename to local symbols..

Thanks for exposing the ND, cleaner.
Found another problem :-( not in your code but about this whole approach to using the index.
Let's talk tomorrow

Tue, Jun 18, 9:28 AM · Restricted Project, Restricted Project
sammccall accepted D62954: [Syntax] Add a helper to find expansion by its first spelled token.
Tue, Jun 18, 9:15 AM · Restricted Project, Restricted Project
sammccall added inline comments to D63330: [clangd] Add Value field to HoverInfo.
Tue, Jun 18, 6:44 AM · Restricted Project
sammccall committed rG395fde753c91: [clangd] Add hidden tweaks to dump AST/selection. (authored by sammccall).
[clangd] Add hidden tweaks to dump AST/selection.
Tue, Jun 18, 6:36 AM
sammccall committed rL363680: [clangd] Add hidden tweaks to dump AST/selection..
[clangd] Add hidden tweaks to dump AST/selection.
Tue, Jun 18, 6:36 AM
sammccall closed D62538: [clangd] Add hidden tweaks to dump AST/selection..
Tue, Jun 18, 6:36 AM · Restricted Project, Restricted Project
sammccall added inline comments to D62538: [clangd] Add hidden tweaks to dump AST/selection..
Tue, Jun 18, 4:59 AM · Restricted Project, Restricted Project
sammccall committed rG8d41294c1893: [clangd] Add a capability to enable completions with fixes. (authored by sammccall).
[clangd] Add a capability to enable completions with fixes.
Tue, Jun 18, 4:55 AM
sammccall committed rL363664: [clangd] Add a capability to enable completions with fixes..
[clangd] Add a capability to enable completions with fixes.
Tue, Jun 18, 4:55 AM
sammccall closed D63091: [clangd] Add a capability to enable completions with fixes..
Tue, Jun 18, 4:54 AM · Restricted Project, Restricted Project
sammccall accepted D63483: [clangd] Detect C++ language based on well-known file path in vscode extension.
Tue, Jun 18, 4:35 AM · Restricted Project, Restricted Project
sammccall accepted D63481: [clangd] Parse files without extensions if we don't have a compile command..
Tue, Jun 18, 4:35 AM · Restricted Project, Restricted Project
sammccall accepted D62956: [clangd] Collect tokens of main files when building the AST.

Can we add a test using TestTU that does a very basic verification of expanded/spelled tokens (first after preamble, last token in file)?

Tue, Jun 18, 1:57 AM · Restricted Project, Restricted Project
sammccall added a comment to D62954: [Syntax] Add a helper to find expansion by its first spelled token.

LG but needs tests

Tue, Jun 18, 1:53 AM · Restricted Project, Restricted Project
sammccall added inline comments to D62954: [Syntax] Add a helper to find expansion by its first spelled token.
Tue, Jun 18, 1:53 AM · Restricted Project, Restricted Project
sammccall added a comment to D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping.

Can you explain why this is important?
(in the code)

Tue, Jun 18, 1:49 AM · Restricted Project, Restricted Project
sammccall added a comment to D62538: [clangd] Add hidden tweaks to dump AST/selection..

i mean ping

Tue, Jun 18, 1:45 AM · Restricted Project, Restricted Project
sammccall added a comment to D62538: [clangd] Add hidden tweaks to dump AST/selection..

pind

Tue, Jun 18, 1:45 AM · Restricted Project, Restricted Project
sammccall added inline comments to D63426: [clangd] Narrow rename to local symbols..
Tue, Jun 18, 1:41 AM · Restricted Project, Restricted Project

Sun, Jun 16

sammccall added a comment to D63222: [Clangd] Fixed clangd diagnostics priority.

Code gets shorter, tests get longer, very nice :-)

Sun, Jun 16, 2:40 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 11

sammccall added a comment to D63098: [CodeComplete] Allow completing enum values within case statements, and insert 'case' as a fixit..

Not displaying 'case' is actually confusing to my taste.
WDYT about allowing multiple "typed text" chunks or allowing to mark other chunks that are supposed be part of filter text?

Tue, Jun 11, 2:38 AM · Restricted Project
sammccall added a comment to D63092: [Frontend] Use executable path when creating invocation from cmdline.

Thanks for pushing on this. I guess this must affect all clang-tools when used with a wrapper, which seems important. (I've just been using bazel and local cmake, so haven't hit this myself).

Tue, Jun 11, 1:15 AM · Restricted Project

Mon, Jun 10

sammccall created D63098: [CodeComplete] Allow completing enum values within case statements, and insert 'case' as a fixit..
Mon, Jun 10, 2:14 PM · Restricted Project
sammccall committed rGc920c373612b: [clangd] Remove old hidden -use-dex-index flag (authored by sammccall).
[clangd] Remove old hidden -use-dex-index flag
Mon, Jun 10, 1:37 PM
sammccall committed rL362978: [clangd] Remove old hidden -use-dex-index flag.
[clangd] Remove old hidden -use-dex-index flag
Mon, Jun 10, 1:36 PM
sammccall added a comment to D63092: [Frontend] Use executable path when creating invocation from cmdline.

argv[0] does carry important information though, I think this will break a lot of things. It's... concerning that no tests broke.

Mon, Jun 10, 1:26 PM · Restricted Project
sammccall created D63091: [clangd] Add a capability to enable completions with fixes..
Mon, Jun 10, 1:01 PM · Restricted Project, Restricted Project
sammccall created D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be applied by -fixit, available to libclang and clangd, etc)..
Mon, Jun 10, 11:21 AM · Restricted Project
sammccall committed rG3dea52725862: Re-land "[CodeComplete] Improve overload handling for C++ qualified and ref… (authored by sammccall).
Re-land "[CodeComplete] Improve overload handling for C++ qualified and ref…
Mon, Jun 10, 8:16 AM
sammccall committed rL362950: Re-land "[CodeComplete] Improve overload handling for C++ qualified and ref….
Re-land "[CodeComplete] Improve overload handling for C++ qualified and ref…
Mon, Jun 10, 8:14 AM
sammccall committed rG306e474b9146: Revert "[CodeComplete] Improve overload handling for C++ qualified and ref… (authored by sammccall).
Revert "[CodeComplete] Improve overload handling for C++ qualified and ref…
Mon, Jun 10, 7:53 AM
sammccall committed rL362944: Revert "[CodeComplete] Improve overload handling for C++ qualified and ref….
Revert "[CodeComplete] Improve overload handling for C++ qualified and ref…
Mon, Jun 10, 7:52 AM
sammccall committed rG25c6257ba028: [clangd] Revamp textDocument/onTypeFormatting. (authored by sammccall).
[clangd] Revamp textDocument/onTypeFormatting.
Mon, Jun 10, 7:24 AM
sammccall committed rL362939: [clangd] Revamp textDocument/onTypeFormatting..
[clangd] Revamp textDocument/onTypeFormatting.
Mon, Jun 10, 7:24 AM
sammccall closed D60605: [clangd] Revamp textDocument/onTypeFormatting..
Mon, Jun 10, 7:24 AM · Restricted Project, Restricted Project
sammccall added a comment to D60605: [clangd] Revamp textDocument/onTypeFormatting..

OK, this has been stuck for a while and (as discussed a bit offline) I haven't been able to make the alternative approaches work.

Mon, Jun 10, 7:21 AM · Restricted Project, Restricted Project
sammccall committed rG149786d5b7e1: [clangd] Stop marshalling/requiring FormattingOptions. We never did anything… (authored by sammccall).
[clangd] Stop marshalling/requiring FormattingOptions. We never did anything…
Mon, Jun 10, 5:59 AM
sammccall committed rL362934: [clangd] Stop marshalling/requiring FormattingOptions. We never did anything….
[clangd] Stop marshalling/requiring FormattingOptions. We never did anything…
Mon, Jun 10, 5:59 AM
sammccall committed rG94600e466cd8: Revert "Revert "[CodeComplete] Improve overload handling for C++ qualified and… (authored by sammccall).
Revert "Revert "[CodeComplete] Improve overload handling for C++ qualified and…
Mon, Jun 10, 2:51 AM
sammccall committed rL362924: Revert "Revert "[CodeComplete] Improve overload handling for C++ qualified and….
Revert "Revert "[CodeComplete] Improve overload handling for C++ qualified and…
Mon, Jun 10, 2:49 AM

Fri, Jun 7

sammccall added a comment to D61637: [Syntax] Introduce syntax trees.

I've addressed most of the comments, except the naming ones.
We need a convention for naming the language nodes and names for composite and leaf structural nodes.

For "language" nodes, I suggest we use CompoundStatement, Recovery, TopLevelDeclaration, TemplateArgumentList, TypeTemplateArgument, etc. That is, we spell out the words in full, no shorthands like Stmt or Expr. That would make things a bit more verbose, but hopefully that helps distinguish from clang AST.

Fri, Jun 7, 6:22 AM · Restricted Project, Restricted Project
sammccall committed rGf1f6e0fc2468: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified… (authored by sammccall).
[CodeComplete] Improve overload handling for C++ qualified and ref-qualified…
Fri, Jun 7, 2:43 AM
sammccall committed rL362785: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified….
[CodeComplete] Improve overload handling for C++ qualified and ref-qualified…
Fri, Jun 7, 2:43 AM
sammccall closed D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods..
Fri, Jun 7, 2:43 AM · Restricted Project, Restricted Project
sammccall accepted D62999: [clangd] Return empty results on spurious completion triggers.
Fri, Jun 7, 2:14 AM · Restricted Project, Restricted Project
sammccall resigned from D61697: [lit] Disable test on darwin when building shared libs..

Sorry, I don't have any context on this (I just "blindly" fixed an asan error at one point).

Fri, Jun 7, 12:37 AM · Restricted Project, Restricted Project

Thu, Jun 6

sammccall added a comment to D50147: clang-format: support external styles.

One thing that's unclear to me is whether your aim is to

  1. solve a concrete problem for your organization
  2. solve a family of problems for similar organizations
  3. add a new way of configuring styles for many types of users/projects
Thu, Jun 6, 4:18 PM · Restricted Project
sammccall added a comment to D62855: Implementation of auto type expansion..

Sorry about the delay here. Happy to chat offline if I'm being confusing.

Thu, Jun 6, 2:32 PM · Restricted Project
sammccall added inline comments to D62808: [clangd] Print the ignored variant symbols.
Thu, Jun 6, 1:27 PM · Restricted Project
sammccall added a comment to D62804: [clangd] Enable extraction of system includes from custom toolchains.

Implementation looks good. I can't see a better way to solve this problem, it's just a bit unfortunate to have a sophisticated solution but not be able to turn it on by default.

Thu, Jun 6, 1:20 PM · Restricted Project
sammccall accepted D62965: [clang][HeaderSearch] Consider all path separators equal.
Thu, Jun 6, 10:01 AM · Restricted Project, Restricted Project

Tue, Jun 4

sammccall accepted D62615: [CodeComplete] Include more text into typed chunks of pattern completions.
Tue, Jun 4, 1:44 AM · Restricted Project, Restricted Project
sammccall accepted D62814: [clangd] Treat lambdas as functions when preparing hover response.
Tue, Jun 4, 1:31 AM · Restricted Project, Restricted Project

Fri, May 31

sammccall added a comment to D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods..

Oops, we weren't handling the case when the newly-added overload is dominated by an existing one. Fixed.

Fri, May 31, 8:32 AM · Restricted Project, Restricted Project
sammccall updated the diff for D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods..

Handle methods without "normal" identifier names.
Add comments.
Trigger in both directions (dominated and dominated-by).

Fri, May 31, 8:29 AM · Restricted Project, Restricted Project

Wed, May 29

sammccall committed rG4f09d9fcfa28: Qualify use of llvm::empty that's ambiguous with std::empty (authored by sammccall).
Qualify use of llvm::empty that's ambiguous with std::empty
Wed, May 29, 8:01 AM
sammccall committed rL361968: Qualify use of llvm::empty that's ambiguous with std::empty.
Qualify use of llvm::empty that's ambiguous with std::empty
Wed, May 29, 8:01 AM
sammccall updated the diff for D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods..

Remove debug

Wed, May 29, 7:10 AM · Restricted Project, Restricted Project
sammccall created D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods..
Wed, May 29, 5:59 AM · Restricted Project, Restricted Project
sammccall committed rG7964f6fe5fb4: [ADT] add iterator_range::empty() (authored by sammccall).
[ADT] add iterator_range::empty()
Wed, May 29, 3:38 AM
sammccall committed rL361944: [ADT] add iterator_range::empty().
[ADT] add iterator_range::empty()
Wed, May 29, 3:38 AM
sammccall accepted D62575: [clangd] Another improvement for std include mapping..
Wed, May 29, 3:32 AM · Restricted Project, Restricted Project
sammccall accepted D62527: [clangd] Remove the whitelist std symbols in CanonicalIncludes..
Wed, May 29, 3:32 AM · Restricted Project

Tue, May 28

sammccall committed rG81748bae47fd: [clangd] Add SourceManager accessor to ParsedAST. NFC (authored by sammccall).
[clangd] Add SourceManager accessor to ParsedAST. NFC
Tue, May 28, 2:50 PM
sammccall committed rCTE361883: [clangd] Add SourceManager accessor to ParsedAST. NFC.
[clangd] Add SourceManager accessor to ParsedAST. NFC
Tue, May 28, 2:50 PM
sammccall committed rL361883: [clangd] Add SourceManager accessor to ParsedAST. NFC.
[clangd] Add SourceManager accessor to ParsedAST. NFC
Tue, May 28, 2:50 PM
sammccall updated the diff for D62538: [clangd] Add hidden tweaks to dump AST/selection..

Add DumpRecordLayout. Fix a small SelectionTree bug uncovered by these tweaks.

Tue, May 28, 2:34 PM · Restricted Project, Restricted Project
sammccall created D62538: [clangd] Add hidden tweaks to dump AST/selection..
Tue, May 28, 11:04 AM · Restricted Project, Restricted Project
sammccall accepted D62515: [clangd] Compute expected type for templates.
Tue, May 28, 4:45 AM · Restricted Project

Mon, May 27

sammccall added a comment to D61497: [clangd] Introduce a structured hover response.

Still LG

Mon, May 27, 8:25 AM · Restricted Project, Restricted Project
sammccall accepted D62487: [clang] Respect TerseOutput when printing lambdas.
Mon, May 27, 8:24 AM · Restricted Project, Restricted Project
sammccall accepted D61497: [clangd] Introduce a structured hover response.

Thanks, I think you're right about all of this. Implementation looks OK too. Please add TODOs for the cases where we're punting to later vs deciding not to fix.

Mon, May 27, 2:31 AM · Restricted Project, Restricted Project
sammccall accepted D59407: [clangd] Add RelationSlab.

Awesome, thank you!

Mon, May 27, 12:55 AM · Restricted Project, Restricted Project

May 23 2019

sammccall accepted D62309: Fix linking of the refactor tweaks directory.

Thank you!

May 23 2019, 6:35 AM · Restricted Project

May 21 2019

sammccall added a comment to D61637: [Syntax] Introduce syntax trees.

Definitely like the choice of CompositeNode owning the concrete storage!

May 21 2019, 7:24 AM · Restricted Project, Restricted Project
sammccall committed rG0321b370f2db: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to… (authored by sammccall).
[clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to…
May 21 2019, 6:39 AM
sammccall committed rCTE361258: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to….
[clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to…
May 21 2019, 6:39 AM
sammccall committed rL361258: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to….
[clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to…
May 21 2019, 6:39 AM
sammccall closed D62135: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it..
May 21 2019, 6:38 AM · Restricted Project, Restricted Project
sammccall accepted D62137: [Frontend] Return an error on bad inputs to PrecompiledPreabmle.
May 21 2019, 6:37 AM · Restricted Project