sammccall (Sam McCall)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 26 2016, 6:53 AM (78 w, 18 h)
Roles
Administrator

Recent Activity

Yesterday

sammccall updated the diff for D43648: [clangd] Debounce streams of updates..

rebase

Fri, Feb 23, 10:28 AM
sammccall added inline comments to D43648: [clangd] Debounce streams of updates..
Fri, Feb 23, 10:25 AM
sammccall updated the diff for D43648: [clangd] Debounce streams of updates..

Make Deadline a real type with 0/finite/inf semantics.
Pull out another wait() overload.
Expose debounce delay option in clangdserver.

Fri, Feb 23, 10:25 AM
sammccall accepted D43510: [clangd] don't insert new includes if either original header or canonical header is already included..

Thanks, and sorry for the delay!

Fri, Feb 23, 5:59 AM

Thu, Feb 22

sammccall committed rCTE325868: [clangd] BindWithForward -> Bind. NFC.
[clangd] BindWithForward -> Bind. NFC
Thu, Feb 22, 11:56 PM
sammccall committed rL325868: [clangd] BindWithForward -> Bind. NFC.
[clangd] BindWithForward -> Bind. NFC
Thu, Feb 22, 11:56 PM
sammccall created D43648: [clangd] Debounce streams of updates..
Thu, Feb 22, 3:48 PM
sammccall accepted D43634: [clangd] Extend textDocument/didChange to specify whether diagnostics should be generated..

Nice, this will be useful for at least a couple of editor integrations.

Thu, Feb 22, 10:28 AM
sammccall committed rCTE325801: [clangd] fix test use-after-free from r325774.
[clangd] fix test use-after-free from r325774
Thu, Feb 22, 7:38 AM
sammccall committed rL325801: [clangd] fix test use-after-free from r325774.
[clangd] fix test use-after-free from r325774
Thu, Feb 22, 7:38 AM
sammccall committed rCTE325774: [clangd] Allow embedders some control over when diagnostics are generated..
[clangd] Allow embedders some control over when diagnostics are generated.
Thu, Feb 22, 5:16 AM
sammccall committed rL325774: [clangd] Allow embedders some control over when diagnostics are generated..
[clangd] Allow embedders some control over when diagnostics are generated.
Thu, Feb 22, 5:16 AM
sammccall closed D43518: [clangd] Allow embedders some control over when diagnostics are generated..
Thu, Feb 22, 5:16 AM
sammccall added a comment to D43518: [clangd] Allow embedders some control over when diagnostics are generated..

Not convinced about the flow control stuff - I think you might be underestimating the complexity of the cancellation-based approach with the extra functionality.
But if you think it would still be more readable the other way, happy to get a third opinion.

Thu, Feb 22, 3:11 AM
sammccall updated the diff for D43518: [clangd] Allow embedders some control over when diagnostics are generated..

add param names to decls

Thu, Feb 22, 3:08 AM
sammccall accepted D43550: [clangd] Not collect include headers for dynamic index for now..
Thu, Feb 22, 2:07 AM
sammccall added a comment to D43503: Rename LLD lit features for targets from e.g. "x86" -> "x86-registered-target".

Pardon my ignorance, but what is a difference between x86 and x86-registered-target?

Thu, Feb 22, 2:04 AM

Tue, Feb 20

sammccall created D43518: [clangd] Allow embedders some control over when diagnostics are generated..
Tue, Feb 20, 10:56 AM
sammccall added a comment to D43510: [clangd] don't insert new includes if either original header or canonical header is already included..

Mostly nits around naming/doc: you've convinced me that the two headers that are paths or uris or <headers> at different times is the right thing, but we need to be really clear about it.

Tue, Feb 20, 7:21 AM
sammccall added inline comments to D43510: [clangd] don't insert new includes if either original header or canonical header is already included..
Tue, Feb 20, 6:43 AM
sammccall committed rCTE325574: [clangd] Dump stack on crash.
[clangd] Dump stack on crash
Tue, Feb 20, 3:50 AM
sammccall committed rL325574: [clangd] Dump stack on crash.
[clangd] Dump stack on crash
Tue, Feb 20, 3:50 AM
sammccall added a comment to D43503: Rename LLD lit features for targets from e.g. "x86" -> "x86-registered-target".

Sorry for the huge patch :-) Apart from lit.cfg.py, everything is just mechanical changes to REQUIRES lines.

Tue, Feb 20, 1:41 AM
sammccall created D43503: Rename LLD lit features for targets from e.g. "x86" -> "x86-registered-target".
Tue, Feb 20, 1:38 AM

Mon, Feb 19

sammccall committed rL325553: [Sema] Fix -Wunused-variable.
[Sema] Fix -Wunused-variable
Mon, Feb 19, 11:26 PM
sammccall committed rC325553: [Sema] Fix -Wunused-variable.
[Sema] Fix -Wunused-variable
Mon, Feb 19, 11:26 PM
sammccall added inline comments to D43462: [clangd] Fixes for #include insertion..
Mon, Feb 19, 10:07 AM
sammccall added a comment to D41102: Setup clang-doc frontend framework.

Naming conventions tend to stick around for a while - clang-doc/ClangDocXYZ.h seems a bit unwieldy compared to clang-doc/XYZ.h - might be worth considering.

Mon, Feb 19, 8:52 AM · Restricted Project
sammccall added inline comments to D43462: [clangd] Fixes for #include insertion..
Mon, Feb 19, 7:42 AM
sammccall accepted D43455: [clangd] Add brief instructions on how to make a release for vscode-clangd extension..

thanks! couple of nits

Mon, Feb 19, 5:56 AM
sammccall committed rCTE325493: [clangd] Invert return value of fuzzyFind() (fix MemIndex's return value).
[clangd] Invert return value of fuzzyFind() (fix MemIndex's return value)
Mon, Feb 19, 5:06 AM
sammccall committed rL325493: [clangd] Invert return value of fuzzyFind() (fix MemIndex's return value).
[clangd] Invert return value of fuzzyFind() (fix MemIndex's return value)
Mon, Feb 19, 5:06 AM
sammccall accepted D43377: [clangd] Attach more information about Sema completion to traces.
Mon, Feb 19, 4:29 AM
sammccall added inline comments to D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind.
Mon, Feb 19, 3:31 AM
sammccall accepted D43452: [clangd] Bump vs-code clangd extension v0.0.3.

(Do we need to bump this for the market to update properly? How do we decide when to bump it?)

Mon, Feb 19, 2:31 AM
sammccall committed rL325480: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks.
[clangd] Tracing: name worker threads, and enforce naming scheduled async tasks
Mon, Feb 19, 1:59 AM
sammccall committed rCTE325480: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks.
[clangd] Tracing: name worker threads, and enforce naming scheduled async tasks
Mon, Feb 19, 1:59 AM
sammccall closed D43388: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks.
Mon, Feb 19, 1:59 AM
sammccall closed D43388: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks.
Mon, Feb 19, 1:59 AM
sammccall committed rCTE325477: [clangd] Add "clangd.trace" VSCode setting to enable tracing..
[clangd] Add "clangd.trace" VSCode setting to enable tracing.
Mon, Feb 19, 1:48 AM
sammccall committed rL325477: [clangd] Add "clangd.trace" VSCode setting to enable tracing..
[clangd] Add "clangd.trace" VSCode setting to enable tracing.
Mon, Feb 19, 1:48 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Feb 19, 1:48 AM
sammccall accepted D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind.
Mon, Feb 19, 1:41 AM
sammccall committed rCTE325476: [clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input!.
[clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input!
Mon, Feb 19, 1:33 AM
sammccall committed rL325476: [clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input!.
[clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input!
Mon, Feb 19, 1:33 AM
sammccall closed D43381: [clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input!.
Mon, Feb 19, 1:33 AM

Fri, Feb 16

sammccall committed rCTE325357: [clangd] Include timestamps in log messages..
[clangd] Include timestamps in log messages.
Fri, Feb 16, 8:43 AM
sammccall committed rL325357: [clangd] Include timestamps in log messages..
[clangd] Include timestamps in log messages.
Fri, Feb 16, 8:43 AM
sammccall created D43388: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks.
Fri, Feb 16, 7:44 AM
sammccall created D43385: [clangd] Add "clangd.trace" VSCode setting to enable tracing..
Fri, Feb 16, 7:06 AM
sammccall created D43381: [clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input!.
Fri, Feb 16, 4:43 AM
sammccall added a comment to D43377: [clangd] Attach more information about Sema completion to traces.

This looks really useful! Main suggestion is to drop the added span and attach kind to the main span instead. (It's relevant to index too, not just to sema)

Fri, Feb 16, 3:00 AM
sammccall committed rCTE325326: [clangd] TestFS cleanup: getVirtualBlahBlah -> testPath/testRoot. Remove….
[clangd] TestFS cleanup: getVirtualBlahBlah -> testPath/testRoot. Remove…
Fri, Feb 16, 1:46 AM
sammccall committed rL325326: [clangd] TestFS cleanup: getVirtualBlahBlah -> testPath/testRoot. Remove….
[clangd] TestFS cleanup: getVirtualBlahBlah -> testPath/testRoot. Remove…
Fri, Feb 16, 1:46 AM
sammccall added inline comments to D42640: [clangd] collect symbol #include & insert #include in global code completion..
Fri, Feb 16, 1:46 AM
sammccall accepted D42640: [clangd] collect symbol #include & insert #include in global code completion..

LG apart from the .inc handling (happy to chat more)

Fri, Feb 16, 12:45 AM

Thu, Feb 15

sammccall accepted D43246: [clangd] Assert path is absolute when assigning to URIForFile..

LG if we want to do this
(please getFile -> file though!)

Thu, Feb 15, 10:16 AM
sammccall accepted D43330: [gtest] Add PrintTo overload for StringRef..

LG, but good idea to wait on more input

Thu, Feb 15, 10:01 AM
sammccall committed rL325257: [clangd] Use explicit env in test to make lit+windows happy. NFC.
[clangd] Use explicit env in test to make lit+windows happy. NFC
Thu, Feb 15, 8:22 AM
sammccall committed rCTE325257: [clangd] Use explicit env in test to make lit+windows happy. NFC.
[clangd] Use explicit env in test to make lit+windows happy. NFC
Thu, Feb 15, 8:22 AM
sammccall committed rCTE325239: [clangd] Fix make_unique ambiguity, NFC.
[clangd] Fix make_unique ambiguity, NFC
Thu, Feb 15, 6:19 AM
sammccall committed rL325239: [clangd] Fix make_unique ambiguity, NFC.
[clangd] Fix make_unique ambiguity, NFC
Thu, Feb 15, 6:19 AM
sammccall added a comment to D43272: [clangd] Fix tracing now that spans lifetimes can overlap on a thread..

r325239 should fix, sorry!

Thu, Feb 15, 6:19 AM
sammccall added a comment to D43330: [gtest] Add PrintTo overload for StringRef..

This is unfortunate, but it's kind of a consequence of how googletest implements it's universal printers. The reason why I don't think it's a good idea is that this is not a problem specific to StringRef, as any class can come out as giberrish if the user forgets to include the PrintTo function.

Thu, Feb 15, 5:13 AM
sammccall added inline comments to D43229: [clangd] Enable snippet completion based on client capabilities..
Thu, Feb 15, 5:07 AM
sammccall added a comment to D43330: [gtest] Add PrintTo overload for StringRef..

FWIW I'm fine with putting it in StringRef.h or here, (custom/gtest-printers.his strictly better than here though).

Thu, Feb 15, 4:59 AM
sammccall committed rCTE325220: [clangd] Fix tracing now that spans lifetimes can overlap on a thread..
[clangd] Fix tracing now that spans lifetimes can overlap on a thread.
Thu, Feb 15, 12:44 AM
sammccall committed rL325220: [clangd] Fix tracing now that spans lifetimes can overlap on a thread..
[clangd] Fix tracing now that spans lifetimes can overlap on a thread.
Thu, Feb 15, 12:43 AM
sammccall closed D43272: [clangd] Fix tracing now that spans lifetimes can overlap on a thread..
Thu, Feb 15, 12:42 AM
sammccall updated the diff for D43272: [clangd] Fix tracing now that spans lifetimes can overlap on a thread..

address review comments

Thu, Feb 15, 12:40 AM
sammccall added inline comments to D43272: [clangd] Fix tracing now that spans lifetimes can overlap on a thread..
Thu, Feb 15, 12:40 AM

Tue, Feb 13

sammccall committed rCTE325097: [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag.
[clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag
Tue, Feb 13, 7:22 PM
sammccall committed rL325097: [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag.
[clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag
Tue, Feb 13, 7:22 PM
sammccall created D43272: [clangd] Fix tracing now that spans lifetimes can overlap on a thread..
Tue, Feb 13, 7:09 PM
sammccall committed rL325069: Fix off-by-one in set_thread_name which causes truncation to fail on Linux.
Fix off-by-one in set_thread_name which causes truncation to fail on Linux
Tue, Feb 13, 3:28 PM
sammccall added inline comments to D43246: [clangd] Assert path is absolute when assigning to URIForFile..
Tue, Feb 13, 11:45 AM
sammccall accepted D43227: [clangd] Make functions of ClangdServer callback-based.

LG, suggest a tweak to capture() though.

Tue, Feb 13, 11:16 AM
sammccall added inline comments to D43230: [clangd] Explicitly initialize all primitive fields in Protocol.h.
Tue, Feb 13, 10:37 AM
sammccall accepted D43230: [clangd] Explicitly initialize all primitive fields in Protocol.h.

Yup, I got bitten recently from some of our plain-c-style structs with no default initializers (in Index).

Tue, Feb 13, 10:21 AM
sammccall committed rCTE324990: [clangd] Stop exposing Futures from ClangdServer operations..
[clangd] Stop exposing Futures from ClangdServer operations.
Tue, Feb 13, 1:03 AM
sammccall committed rL324990: [clangd] Stop exposing Futures from ClangdServer operations..
[clangd] Stop exposing Futures from ClangdServer operations.
Tue, Feb 13, 1:01 AM
sammccall closed D43127: [clangd] Stop exposing Futures from ClangdServer operations..
Tue, Feb 13, 1:01 AM

Mon, Feb 12

sammccall added inline comments to D43127: [clangd] Stop exposing Futures from ClangdServer operations..
Mon, Feb 12, 8:07 AM
sammccall updated the diff for D43127: [clangd] Stop exposing Futures from ClangdServer operations..

Review comments

Mon, Feb 12, 8:07 AM
sammccall added a comment to D42640: [clangd] collect symbol #include & insert #include in global code completion..

Insertion still LG (couple of nits, inline).

Mon, Feb 12, 7:34 AM
sammccall accepted D43182: [clangd] SymbolLocation only covers symbol name..

Nice!

Mon, Feb 12, 7:12 AM
sammccall added inline comments to D43127: [clangd] Stop exposing Futures from ClangdServer operations..
Mon, Feb 12, 7:05 AM
sammccall updated the diff for D43127: [clangd] Stop exposing Futures from ClangdServer operations..

Change AsyncTaskRunner::wait() to be LLVM_NODISCARD when used with a deadline.
Restore NoConcurrentDiagnostics test to its former glory (with comments)
Other comment fixes.

Mon, Feb 12, 7:05 AM
sammccall committed rL324876: [gtest] Support raw_ostream printing functions more comprehensively..
[gtest] Support raw_ostream printing functions more comprehensively.
Mon, Feb 12, 2:24 AM
sammccall closed D43091: [gtest] Support raw_ostream printing functions more comprehensively..
Mon, Feb 12, 2:24 AM

Fri, Feb 9

sammccall added a comment to D42640: [clangd] collect symbol #include & insert #include in global code completion..

Insertion side LGTM, feel free to split and land.
Sorry I need to take off and will need to get to indexing on monday :(

Fri, Feb 9, 7:15 AM
sammccall updated the diff for D43127: [clangd] Stop exposing Futures from ClangdServer operations..

rebase

Fri, Feb 9, 6:55 AM
sammccall committed rCTE324735: [clangd] Collect definitions when indexing..
[clangd] Collect definitions when indexing.
Fri, Feb 9, 6:44 AM
sammccall committed rL324735: [clangd] Collect definitions when indexing..
[clangd] Collect definitions when indexing.
Fri, Feb 9, 6:44 AM
sammccall closed D42942: [clangd] Collect definitions when indexing..
Fri, Feb 9, 6:44 AM
sammccall closed D42942: [clangd] Collect definitions when indexing..
Fri, Feb 9, 6:44 AM
sammccall added inline comments to D42942: [clangd] Collect definitions when indexing..
Fri, Feb 9, 6:40 AM
sammccall updated the diff for D43127: [clangd] Stop exposing Futures from ClangdServer operations..

Tidy up comment, and revert notify_all to notify_one - it was a red herring.

Fri, Feb 9, 6:36 AM
sammccall created D43127: [clangd] Stop exposing Futures from ClangdServer operations..
Fri, Feb 9, 6:34 AM
sammccall accepted D43122: [clangd] Fix crash when CompilerInvocation can't be created..

just nits

Fri, Feb 9, 5:26 AM