Page MenuHomePhabricator

sammccall (Sam McCall)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 26 2016, 6:53 AM (300 w, 1 d)
Roles
Administrator

Recent Activity

Wed, May 25

sammccall added a comment to D124486: [clangd] ExtractVariable support for C and Objective-C.

Please go ahead and land this, the remaining open comment doesn't really matter.

Wed, May 25, 11:00 AM · Restricted Project, Restricted Project
sammccall accepted D126397: [pseudo] Fix pseudo-gen usage when cross-compiling.

Thank you! I have been banging my head against this, I'm not entirely sure why this works and my version doesn't.

Wed, May 25, 10:44 AM · Restricted Project, Restricted Project
sammccall added a comment to D125667: [pseudo] A basic implementation of compiling cxx grammar at build time..

I'll see if I can fix it quickly, else will revert (there are a couple of fixes stacked on top already, so revert isn't quite clean)

Wed, May 25, 9:52 AM · Restricted Project, Restricted Project

Tue, May 24

sammccall requested review of D126347: [pseudo] WIP: GSS Node refcount (smart pointers).
Tue, May 24, 5:16 PM · Restricted Project, Restricted Project
sammccall requested review of D126337: [pseudo] WIP: GSS node refcounting (dumb pointers).
Tue, May 24, 3:31 PM · Restricted Project, Restricted Project
sammccall committed rG0360b9f1599b: [pseudo] (trivial) bracket-matching (authored by sammccall).
[pseudo] (trivial) bracket-matching
Tue, May 24, 6:14 AM · Restricted Project, Restricted Project
sammccall closed D125911: [pseudo] (trivial) bracket-matching.
Tue, May 24, 6:13 AM · Restricted Project, Restricted Project
sammccall added inline comments to D125911: [pseudo] (trivial) bracket-matching.
Tue, May 24, 6:13 AM · Restricted Project, Restricted Project
sammccall closed D115232: [clangd] Indexing of standard library.

Landed finally as 03ea140b3a285c9a4400ee007b1790b110cbf984

Tue, May 24, 6:07 AM · Restricted Project, Restricted Project
sammccall accepted D126274: [clangd] Handle '--' in QueryDriverDatabase.

Thanks so much for tracking this down!
The number of times we've had this bug :-( I wish we were using something a little more structured than array-of-strings.

Tue, May 24, 1:36 AM · Restricted Project, Restricted Project

Mon, May 23

sammccall accepted D125667: [pseudo] A basic implementation of compiling cxx grammar at build time..
Mon, May 23, 8:51 AM · Restricted Project, Restricted Project
sammccall added a comment to D124690: [clangd] add inlay hints for std::forward-ed parameter packs.

I will update this to split up the control flow into a visitor just collecting a single recursion level and the high-level mapping. A general question here would be whether we should do the resolution by parameter or by parameter pack. Doing it by parameter (like I did it right now) is much easier for inlay hints, especially if the pack gets split up into different parts, but that may not necessarily be the case for template functions and more fuzzy cases like signature help/autocomplete.

Mon, May 23, 2:50 AM · Restricted Project, Restricted Project

Fri, May 20

sammccall added inline comments to D125911: [pseudo] (trivial) bracket-matching.
Fri, May 20, 2:19 PM · Restricted Project, Restricted Project
sammccall added inline comments to D124486: [clangd] ExtractVariable support for C and Objective-C.
Fri, May 20, 9:52 AM · Restricted Project, Restricted Project
sammccall committed rGedc7a0814575: [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs (authored by sammccall).
[clangd] Provide links to clang-tidy and include-cleaner diagnostic docs
Fri, May 20, 7:34 AM · Restricted Project, Restricted Project
sammccall closed D126065: [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs.
Fri, May 20, 7:33 AM · Restricted Project, Restricted Project
sammccall requested review of D126065: [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs.
Fri, May 20, 6:10 AM · Restricted Project, Restricted Project

Thu, May 19

sammccall committed rG1dfd8e99f91c: [Serialization] Delta encode locations in expansion sloc entries (authored by sammccall).
[Serialization] Delta encode locations in expansion sloc entries
Thu, May 19, 4:06 PM · Restricted Project, Restricted Project
sammccall closed D125952: [Serialization] Delta encode locations in expansion sloc entries.
Thu, May 19, 4:06 PM · Restricted Project, Restricted Project
sammccall requested review of D126029: [Bitcode] Add abbreviation for STRUCT_NAME when the name is not char6.
Thu, May 19, 4:05 PM · Restricted Project, Restricted Project
sammccall committed rG481691572d1f: [Serialization] Add missing includes for CHAR_BIT (authored by sammccall).
[Serialization] Add missing includes for CHAR_BIT
Thu, May 19, 1:04 AM · Restricted Project, Restricted Project
sammccall requested review of D125952: [Serialization] Delta encode locations in expansion sloc entries.
Thu, May 19, 1:01 AM · Restricted Project, Restricted Project
sammccall committed rG4df795bff752: [Serialization] Delta-encode consecutive SourceLocations in TypeLoc (authored by sammccall).
[Serialization] Delta-encode consecutive SourceLocations in TypeLoc
Thu, May 19, 12:41 AM · Restricted Project, Restricted Project
sammccall closed D125403: [Serialization] Delta-encode consecutive SourceLocations in TypeLoc.
Thu, May 19, 12:40 AM · Restricted Project, Restricted Project
sammccall added inline comments to D125403: [Serialization] Delta-encode consecutive SourceLocations in TypeLoc.
Thu, May 19, 12:25 AM · Restricted Project, Restricted Project
sammccall accepted D124486: [clangd] ExtractVariable support for C and Objective-C.

Thank you!

Thu, May 19, 12:17 AM · Restricted Project, Restricted Project
sammccall accepted D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector.

Sorry about the delay :-(

Thu, May 19, 12:00 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 18

sammccall added a comment to D125311: [pseudo] Share the underly payload when stripping comments for a token stream.

This looks good, but if that's the idiom we should add it to cook() also.

cook is more tricky, it takes a TokenStream, and returns a new one with an allocator payload:

  • the input TokenStream doesn't have a payload, this is OK
  • the input TokenStream has a payload, but what if the type of payload is not an allocator?

Payload is opaque, it can be a pair of {new payload, inner payload}. e.g.

void TokenStream::addPayload(shared_ptr<void> P) {
  Payload = make_shared<pair<shared_ptr<void>, shared_ptr<void>>>(std::move(P), std::move(Payload));
}
Wed, May 18, 11:41 PM · Restricted Project, Restricted Project
sammccall committed rG4f35ca59d0fe: [clangd] Suppress warning: control reaches end of function (authored by sammccall).
[clangd] Suppress warning: control reaches end of function
Wed, May 18, 11:26 PM · Restricted Project, Restricted Project
sammccall committed rGcd387e43bf89: [pseudo] Squash some warnings. NFC (authored by sammccall).
[pseudo] Squash some warnings. NFC
Wed, May 18, 11:20 PM · Restricted Project, Restricted Project
sammccall committed rG07c663590114: [clang-tidy] Fix logic of assertion (authored by sammccall).
[clang-tidy] Fix logic of assertion
Wed, May 18, 11:14 PM · Restricted Project, Restricted Project
sammccall added a reverting change for rG77533ea443ac: Revert "Reland(2) "[clangd] Indexing of standard library"": rG03ea140b3a28: Reland(3) "[clangd] Indexing of standard library".
Wed, May 18, 11:14 PM · Restricted Project, Restricted Project
sammccall committed rG03ea140b3a28: Reland(3) "[clangd] Indexing of standard library" (authored by sammccall).
Reland(3) "[clangd] Indexing of standard library"
Wed, May 18, 11:14 PM · Restricted Project, Restricted Project
sammccall added a comment to D125911: [pseudo] (trivial) bracket-matching.

The Bracket struct & translation between token/bracket streams is not really justified by the implementation in this patch.
Next patch will run nontrivial algorithms on the bracket strings.

Wed, May 18, 10:26 AM · Restricted Project, Restricted Project
sammccall requested review of D125911: [pseudo] (trivial) bracket-matching.
Wed, May 18, 10:24 AM · Restricted Project, Restricted Project
sammccall added a comment to D115232: [clangd] Indexing of standard library.

I managed to get a stack trace from a bot (by leaving the broken commit up for longer this time).

Wed, May 18, 10:08 AM · Restricted Project, Restricted Project
sammccall added a reverting change for rGca875539f788: Reland(2) "[clangd] Indexing of standard library": rG77533ea443ac: Revert "Reland(2) "[clangd] Indexing of standard library"".
Wed, May 18, 8:39 AM · Restricted Project, Restricted Project
sammccall committed rG77533ea443ac: Revert "Reland(2) "[clangd] Indexing of standard library"" (authored by sammccall).
Revert "Reland(2) "[clangd] Indexing of standard library""
Wed, May 18, 8:39 AM · Restricted Project, Restricted Project
sammccall added a comment to D115232: [clangd] Indexing of standard library.

Hmm, the test keeps crashing on the GN bot: http://45.33.8.238/win/58316/step_9.txt
Unfortunately the stacktrace is not symbolized, and I'm not seeing this elsewhere (e.g. premerge bot).

@thakis, any idea why unittests no longer manage to symbolize stack traces on crash on the windows bot? I believe this used to work...

I do not know. Maybe related to the "run many unit tests in a single process" lit change from a month ago?

Wed, May 18, 8:36 AM · Restricted Project, Restricted Project
sammccall committed rG1236b66a9819: [lit] pass LLVM_SYMBOLIZER_PATH through to tests. (authored by sammccall).
[lit] pass LLVM_SYMBOLIZER_PATH through to tests.
Wed, May 18, 6:31 AM · Restricted Project, Restricted Project
sammccall added a reverting change for rG6aabf60f2fb7: Revert "Reland "[clangd] Indexing of standard library"": rGca875539f788: Reland(2) "[clangd] Indexing of standard library".
Wed, May 18, 6:31 AM · Restricted Project, Restricted Project
sammccall committed rGca875539f788: Reland(2) "[clangd] Indexing of standard library" (authored by sammccall).
Reland(2) "[clangd] Indexing of standard library"
Wed, May 18, 6:31 AM · Restricted Project, Restricted Project
sammccall added inline comments to D125667: [pseudo] A basic implementation of compiling cxx grammar at build time..
Wed, May 18, 5:42 AM · Restricted Project, Restricted Project
sammccall accepted D125868: [Driver] Update set of -std values with C++20 modules enabled.

LG, but can you change the patch description as you're bringing the set up to date rather than just adding gnu++20

Wed, May 18, 5:17 AM · Restricted Project, Restricted Project

Tue, May 17

sammccall committed rG79ca4ed3e782: [pseudo] Design notes from discussion today. NFC (authored by sammccall).
[pseudo] Design notes from discussion today. NFC
Tue, May 17, 3:09 PM · Restricted Project, Restricted Project
sammccall updated subscribers of D115232: [clangd] Indexing of standard library.

Hmm, the test keeps crashing on the GN bot: http://45.33.8.238/win/58316/step_9.txt
Unfortunately the stacktrace is not symbolized, and I'm not seeing this elsewhere (e.g. premerge bot).

Tue, May 17, 12:38 PM · Restricted Project, Restricted Project
sammccall added a reverting change for rGccdb56ac10ee: Reland "[clangd] Indexing of standard library": rG6aabf60f2fb7: Revert "Reland "[clangd] Indexing of standard library"".
Tue, May 17, 12:34 PM · Restricted Project, Restricted Project
sammccall committed rG6aabf60f2fb7: Revert "Reland "[clangd] Indexing of standard library"" (authored by sammccall).
Revert "Reland "[clangd] Indexing of standard library""
Tue, May 17, 12:34 PM · Restricted Project, Restricted Project
sammccall added a reverting change for rG76ddbb1ca747: Revert "[clangd] Indexing of standard library": rGccdb56ac10ee: Reland "[clangd] Indexing of standard library".
Tue, May 17, 12:02 PM · Restricted Project, Restricted Project
sammccall committed rGccdb56ac10ee: Reland "[clangd] Indexing of standard library" (authored by sammccall).
Reland "[clangd] Indexing of standard library"
Tue, May 17, 12:02 PM · Restricted Project, Restricted Project
sammccall committed rGe8e00e342c4f: [pseudo] benchmark cleanups. NFC (authored by sammccall).
[pseudo] benchmark cleanups. NFC
Tue, May 17, 11:23 AM · Restricted Project, Restricted Project
sammccall closed D125312: [pseudo] benchmark cleanups. NFC.
Tue, May 17, 11:23 AM · Restricted Project, Restricted Project
sammccall committed rG127a1492d729: [clangd] Add command-line flag to set background indexing thread priority. (authored by sammccall).
[clangd] Add command-line flag to set background indexing thread priority.
Tue, May 17, 11:18 AM · Restricted Project, Restricted Project
sammccall closed D125673: [clangd] Add command-line flag to set background indexing thread priority..
Tue, May 17, 11:18 AM · Restricted Project, Restricted Project
sammccall updated the diff for D115232: [clangd] Indexing of standard library.

fix HasSubstr matcher type issue

Tue, May 17, 11:12 AM · Restricted Project, Restricted Project
sammccall reopened D115232: [clangd] Indexing of standard library.
Tue, May 17, 11:11 AM · Restricted Project, Restricted Project
sammccall added a reverting change for rGecaa4d9662c9: [clangd] Indexing of standard library: rG76ddbb1ca747: Revert "[clangd] Indexing of standard library".
Tue, May 17, 8:17 AM · Restricted Project, Restricted Project
sammccall committed rG76ddbb1ca747: Revert "[clangd] Indexing of standard library" (authored by sammccall).
Revert "[clangd] Indexing of standard library"
Tue, May 17, 8:17 AM · Restricted Project, Restricted Project
sammccall added a reverting change for D115232: [clangd] Indexing of standard library: rG76ddbb1ca747: Revert "[clangd] Indexing of standard library".
Tue, May 17, 8:17 AM · Restricted Project, Restricted Project
sammccall added a comment to D125794: [pseudo] Remove unnecessary user-defined-string-literal rule..

The intent here is that user-defined-string-literal-chunk := STRING_LITERAL only matches when there's a ud-suffix. And string-literal-chunk := STRING_LITERAL only matches when there isn't.
(e.g. with a rule guard, which we don't have implemented)
If this was happening, would we still have the explosion?

Tue, May 17, 8:01 AM · Restricted Project, Restricted Project
sammccall committed rGecaa4d9662c9: [clangd] Indexing of standard library (authored by sammccall).
[clangd] Indexing of standard library
Tue, May 17, 7:51 AM · Restricted Project, Restricted Project
sammccall closed D115232: [clangd] Indexing of standard library.
Tue, May 17, 7:51 AM · Restricted Project, Restricted Project
sammccall updated the diff for D115232: [clangd] Indexing of standard library.

Address comments
Add end-to-end test
Move ownership of AsyncTaskRunner to allow blockUntilIdle() in test
Fix bugs caught by end-to-end-test

Tue, May 17, 7:50 AM · Restricted Project, Restricted Project
sammccall accepted D125773: [Driver] Do not auto-enable header modules with -std=c++20.

LG, but I think this is choosing a (new) public name for clang modules/header modules, so maybe Richard or others might want to weigh in?

Tue, May 17, 7:03 AM · Restricted Project, Restricted Project

Mon, May 16

sammccall added a comment to D125667: [pseudo] A basic implementation of compiling cxx grammar at build time..

Few initial comments...

Mon, May 16, 5:58 AM · Restricted Project, Restricted Project
sammccall added a comment to D124690: [clangd] add inlay hints for std::forward-ed parameter packs.

Glad this is working! It looks exciting...

Mon, May 16, 5:46 AM · Restricted Project, Restricted Project
sammccall committed rG71cb8c8cb9c1: [clangd] parse all make_unique-like functions in preamble (authored by upsj).
[clangd] parse all make_unique-like functions in preamble
Mon, May 16, 2:24 AM · Restricted Project, Restricted Project
sammccall closed D124688: [clangd] parse all make_unique-like functions in preamble.
Mon, May 16, 2:23 AM · Restricted Project, Restricted Project
sammccall requested review of D125673: [clangd] Add command-line flag to set background indexing thread priority..
Mon, May 16, 2:16 AM · Restricted Project, Restricted Project
sammccall accepted D124688: [clangd] parse all make_unique-like functions in preamble.

Thanks, this looks good now! A last few nits here.

Mon, May 16, 1:41 AM · Restricted Project, Restricted Project
sammccall committed rG9902a0945d22: Add ThreadPriority::Low, and use QoS class Utility on Mac (authored by stk <stk@ableton.com>).
Add ThreadPriority::Low, and use QoS class Utility on Mac
Mon, May 16, 1:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
sammccall added a comment to D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.

Looks great! I'm happy to land it, will do so on Tuesday unless anyone has further comments.

@sammccall Just a friendly ping, in case you forgot. 😄

Mon, May 16, 1:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
sammccall closed D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.
Mon, May 16, 1:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
sammccall added inline comments to D94727: [clangd] Retire some flags for uncontroversial, stable features..
Mon, May 16, 12:55 AM · Restricted Project, Restricted Project, Restricted Project
sammccall accepted D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas.

Great! A few more nits

Mon, May 16, 12:49 AM · Restricted Project, Restricted Project

Wed, May 11

sammccall accepted D125006: [pseudo] Support parsing variant target symbols..
Wed, May 11, 10:40 AM · Restricted Project, Restricted Project
sammccall requested review of D125403: [Serialization] Delta-encode consecutive SourceLocations in TypeLoc.
Wed, May 11, 10:34 AM · Restricted Project, Restricted Project

Tue, May 10

sammccall added a comment to D115187: [clangd] Expose CoawaitExpr's operand in the AST.

I think the issue is related to this loop in AnalyzeImplicitConversions(), which iterates over Expr::children(), and adds each child to a list of expressions to be checked for implicit conversions.

CoroutineSuspendExpr now has the operand as an extra child, and an implicit conversion in the operand gets diagnosed both when processing the operand, and the common-expr.

I'm guessing this will need an explicit carve-out in AnalyzeImplicitConversions. There is already some special handling of other expressions types there, including at least one whose purpose is to avoid duplicate diagnostics.

Tue, May 10, 8:14 AM · Restricted Project, Restricted Project, Restricted Project
sammccall committed rG00a3c9f2a46a: [Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false (authored by sammccall).
[Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false
Tue, May 10, 7:59 AM · Restricted Project, Restricted Project
sammccall closed D125149: [Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false.
Tue, May 10, 7:58 AM · Restricted Project, Restricted Project
sammccall accepted D125228: [clangd] Support for standard inlayHint protocol.

Great! If you didn't already, can you check with VSCode before landing?
This might catch protocol bits we missed, but also will make sure that the disablement of the legacy protocol in vscode-clangd is working as we expect.

Tue, May 10, 7:49 AM · Restricted Project, Restricted Project
sammccall added a comment to D125311: [pseudo] Share the underly payload when stripping comments for a token stream.

This looks good, but if that's the idiom we should add it to cook() also.

Tue, May 10, 7:01 AM · Restricted Project, Restricted Project
sammccall requested review of D125312: [pseudo] benchmark cleanups. NFC.
Tue, May 10, 6:46 AM · Restricted Project, Restricted Project

Mon, May 9

sammccall added a comment to D124909: Fix issues with using clangd with C++ modules.

Hi Kugan, I apologize in advance for a frustrating and long-winded answer...

Mon, May 9, 2:09 PM · Restricted Project, Restricted Project, Restricted Project
sammccall added a comment to D125231: [pseudo] Compile cxx grammar..

Cool! High level thoughts:

Mon, May 9, 1:08 PM · Restricted Project, Restricted Project
sammccall accepted D125006: [pseudo] Support parsing variant target symbols..

Very nice!
And change to compiled grammar size is small.
Would including *every* nonterminal as a start symbol would blow the size up a bit?
This would eliminate some complexity in the interface.

Mon, May 9, 12:16 PM · Restricted Project, Restricted Project
sammccall committed rGa2f2dfde48ac: [clang-fuzzer] Add a tiny tool to generate a fuzzing dictionary for clang (authored by sammccall).
[clang-fuzzer] Add a tiny tool to generate a fuzzing dictionary for clang
Mon, May 9, 9:32 AM · Restricted Project, Restricted Project
sammccall closed D125166: [clang-fuzzer] Add a tiny tool to generate a fuzzing dictionary for clang.
Mon, May 9, 9:32 AM · Restricted Project, Restricted Project
sammccall added a comment to D125228: [clangd] Support for standard inlayHint protocol.

This looks like the right approach to me, thanks for doing this!

Mon, May 9, 9:21 AM · Restricted Project, Restricted Project
sammccall accepted D125226: [pseudo] Add benchmarks for pseudoparser..

Nice! This will be very useful. I think we should have some fixed checked-in examples, but we can add them later.

Mon, May 9, 7:16 AM · Restricted Project, Restricted Project
sammccall committed rG0195163dbae9: [Frontend] when attaching a preamble, don't generate the long predefines buffer. (authored by sammccall).
[Frontend] when attaching a preamble, don't generate the long predefines buffer.
Mon, May 9, 6:56 AM · Restricted Project, Restricted Project
sammccall closed D125180: [Frontend] when attaching a preamble, don't generate the long predefines buffer..
Mon, May 9, 6:56 AM · Restricted Project, Restricted Project
sammccall committed rGf1a9c4b717be: [clangd] Skip (most) predefined macros when scanning for preamble patching. (authored by sammccall).
[clangd] Skip (most) predefined macros when scanning for preamble patching.
Mon, May 9, 6:34 AM · Restricted Project, Restricted Project
sammccall closed D125179: [clangd] Skip (most) predefined macros when scanning for preamble patching..
Mon, May 9, 6:34 AM · Restricted Project, Restricted Project
sammccall committed rGa316a9815a4f: [clangd] Rewrite TweakTesting helpers to avoid reparsing the same code. NFC (authored by sammccall).
[clangd] Rewrite TweakTesting helpers to avoid reparsing the same code. NFC
Mon, May 9, 5:53 AM · Restricted Project, Restricted Project
sammccall closed D125109: [clangd] Rewrite TweakTesting helpers to avoid reparsing the same code. NFC.
Mon, May 9, 5:53 AM · Restricted Project, Restricted Project
sammccall committed rGbb53eb1ef436: [clangd] Skip extra round-trip in parsing args in debug builds. NFC (authored by sammccall).
[clangd] Skip extra round-trip in parsing args in debug builds. NFC
Mon, May 9, 5:47 AM · Restricted Project, Restricted Project
sammccall closed D125169: [clangd] Skip extra round-trip in parsing args in debug builds. NFC.
Mon, May 9, 5:46 AM · Restricted Project, Restricted Project
sammccall committed rGbf9921adb930: [clangd] Disable predefined macros in tests. NFC (authored by sammccall).
[clangd] Disable predefined macros in tests. NFC
Mon, May 9, 5:45 AM · Restricted Project, Restricted Project
sammccall closed D125172: [clangd] Disable predefined macros in tests. NFC.
Mon, May 9, 5:45 AM · Restricted Project, Restricted Project