- User Since
- Aug 26 2016, 6:53 AM (138 w, 19 h)
Thu, Apr 18
I never managed to track this one down, this was really annoying.
Discussed further offline - it's not clear that expressing the flattening as LSP diagnostic -> LSP diagnostic is better than the current Diag -> LSP diagnostic.
Remove accidental copy/paste in lit test.
Propagate the capability to Diagnostics, add lit test.
I do think it can be further simplified, but if not then land as-is.
Rebase and address comments.
Wed, Apr 17
@kadircet if you're interested in the behavior here, you can patch this in and try out with vscode.
-Wfoo instead of foo
remove leftover debugging
unconfusing my git repo
Rebase to head and expand scope a bit:
- now also setting code for clang-tidy checks
- to enable this to be used from the C++ API, the string code is now on Diag
- and also expose Source over LSP (just an oversight?)
address review comments
Tue, Apr 16
OStream constructor is explicit
Just wanted to note I'm going to look at drafting a lower-level streaming output API so cases like this can avoid materializing all those expensive objects.
Thanks for gathering the numbers here, it is really useful to see how people are using this in performance-sensitive contexts. Definitely makes sense to fix this.
Predicate, not compare.
IIUC, this already fixes the cases we'd seen of include-insertion of a header into itself.
Is it feasible to add a test case for that?
Lots more test cases and better handling of braced blocks.
Mon, Apr 15
Fri, Apr 12
I don't think this is a suitable fix :-(
Thu, Apr 11
Wed, Apr 10
These symbols conflict with identically-named symbols in llvm/bindings/go/llvm/IRBindings.h, going to revert (I don't know what the right name is, and in the C API that's probably important)
Very nice! D60503 will conflict, feel free to stall that until this is landed.
On the other hand it will simplify some things, e.g. the prefix is already calculated, and typed scope is available if you want that (no enclosing namespaces though).