- User Since
- Aug 26 2016, 6:53 AM (78 w, 18 h)
Make Deadline a real type with 0/finite/inf semantics.
Pull out another wait() overload.
Expose debounce delay option in clangdserver.
Thanks, and sorry for the delay!
Thu, Feb 22
Nice, this will be useful for at least a couple of editor integrations.
Not convinced about the flow control stuff - I think you might be underestimating the complexity of the cancellation-based approach with the extra functionality.
But if you think it would still be more readable the other way, happy to get a third opinion.
add param names to decls
Tue, Feb 20
Mostly nits around naming/doc: you've convinced me that the two headers that are paths or uris or <headers> at different times is the right thing, but we need to be really clear about it.
Sorry for the huge patch :-) Apart from lit.cfg.py, everything is just mechanical changes to REQUIRES lines.
Mon, Feb 19
Naming conventions tend to stick around for a while - clang-doc/ClangDocXYZ.h seems a bit unwieldy compared to clang-doc/XYZ.h - might be worth considering.
thanks! couple of nits
(Do we need to bump this for the market to update properly? How do we decide when to bump it?)
Fri, Feb 16
This looks really useful! Main suggestion is to drop the added span and attach kind to the main span instead. (It's relevant to index too, not just to sema)
LG apart from the .inc handling (happy to chat more)
Thu, Feb 15
LG if we want to do this
(please getFile -> file though!)
LG, but good idea to wait on more input
r325239 should fix, sorry!
FWIW I'm fine with putting it in StringRef.h or here, (custom/gtest-printers.his strictly better than here though).
address review comments
Tue, Feb 13
LG, suggest a tweak to capture() though.
Yup, I got bitten recently from some of our plain-c-style structs with no default initializers (in Index).
Mon, Feb 12
Insertion still LG (couple of nits, inline).
Change AsyncTaskRunner::wait() to be LLVM_NODISCARD when used with a deadline.
Restore NoConcurrentDiagnostics test to its former glory (with comments)
Other comment fixes.
Fri, Feb 9
Insertion side LGTM, feel free to split and land.
Sorry I need to take off and will need to get to indexing on monday :(
Tidy up comment, and revert notify_all to notify_one - it was a red herring.