Page MenuHomePhabricator

sammccall (Sam McCall)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 26 2016, 6:53 AM (163 w, 5 d)
Roles
Administrator

Recent Activity

Today

sammccall accepted D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended..

Watching for regressions in stat calls sounds really useful.

Wed, Oct 16, 1:11 AM · Restricted Project

Yesterday

sammccall accepted D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..
Tue, Oct 15, 9:06 AM · Restricted Project, Restricted Project
sammccall accepted D68978: [clangd] Propagate main context into ClangdServer.

Otherwise LG

Tue, Oct 15, 6:58 AM · Restricted Project
sammccall added inline comments to D68978: [clangd] Propagate main context into ClangdServer.
Tue, Oct 15, 6:58 AM · Restricted Project
sammccall committed rGbbb8eade6976: [Format] Add machine-readable SPDX license ID to clang-format.el (authored by sammccall).
[Format] Add machine-readable SPDX license ID to clang-format.el
Tue, Oct 15, 12:24 AM
sammccall committed rL374864: [Format] Add machine-readable SPDX license ID to clang-format.el.
[Format] Add machine-readable SPDX license ID to clang-format.el
Tue, Oct 15, 12:24 AM

Thu, Oct 10

sammccall committed rL374300: Add github commit access for sam-mccall.
Add github commit access for sam-mccall
Thu, Oct 10, 3:01 AM

Wed, Oct 9

sammccall added a comment to D68590: [clangd] Improve hover support for Objective-C.

Thanks! This generally looks good, just need to find the right home for some of the logic.

Wed, Oct 9, 8:16 AM · Restricted Project
sammccall accepted D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex.
Wed, Oct 9, 7:01 AM · Restricted Project

Tue, Oct 8

sammccall accepted D68630: [clangd] Disable expand auto on decltype(auto).
Tue, Oct 8, 4:43 AM · Restricted Project

Mon, Oct 7

sammccall committed rG368e0f3757e2: [clangd] If an undocumented definition exists, don't accept documentation from… (authored by sammccall).
[clangd] If an undocumented definition exists, don't accept documentation from…
Mon, Oct 7, 10:09 PM
sammccall committed rL373892: [clangd] If an undocumented definition exists, don't accept documentation from….
[clangd] If an undocumented definition exists, don't accept documentation from…
Mon, Oct 7, 10:09 PM
sammccall closed D68467: [clangd] If an undocumented definition exists, don't accept documentation from other forward decls..
Mon, Oct 7, 10:09 PM · Restricted Project, Restricted Project
sammccall added a comment to D67536: [WIP] [clangd] Add support for an inactive regions notification.

One thing that may be worth considering as well, is that if the client prefers to highlight the text of the line only, it can calculate the length of the line itself. In VSCode for instance, the line lengths are readily available; I imagine other editors are similar since they need that information for many purposes.

Mon, Oct 7, 9:22 AM · Restricted Project
sammccall added a comment to D67536: [WIP] [clangd] Add support for an inactive regions notification.

How would one even measure the line length? SourceManager doesn't sem to have a method like getLineLength() or similar.

Mon, Oct 7, 8:07 AM · Restricted Project
sammccall added inline comments to D67536: [WIP] [clangd] Add support for an inactive regions notification.
Mon, Oct 7, 7:00 AM · Restricted Project
sammccall added a comment to D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..

Mostly LG, just a couple of possible logic bugs.

Mon, Oct 7, 6:41 AM · Restricted Project, Restricted Project
sammccall reopened D51470: Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files..
Mon, Oct 7, 4:14 AM · Restricted Project
sammccall reopened D45842: [Reassociate] swap binop operands to increase factoring potential.

I don't think this just relanded, phab gone mad due to the disk space issues?

Mon, Oct 7, 4:12 AM · Restricted Project

Fri, Oct 4

sammccall created D68467: [clangd] If an undocumented definition exists, don't accept documentation from other forward decls..
Fri, Oct 4, 8:28 AM · Restricted Project, Restricted Project
sammccall committed rGf44ca7f6eba4: Further improve -Wbool-operation bitwise negation message (authored by sammccall).
Further improve -Wbool-operation bitwise negation message
Fri, Oct 4, 7:12 AM
sammccall committed rL373749: Further improve -Wbool-operation bitwise negation message.
Further improve -Wbool-operation bitwise negation message
Fri, Oct 4, 7:09 AM
sammccall accepted D68459: [clang-rename] Fix a crash when renaming a class without definition..
Fri, Oct 4, 6:51 AM · Restricted Project, Restricted Project
sammccall added a comment to rL373614: [Diagnostics] Bitwise negation of a boolean expr always evaluates to true; warn….

FYI: This fires even if the result isn't converted to a boolean, e.g. on this example:

bool a, b, c;
if (a & b & ~c) {}

The wording warning implies that the value of c is ignored, which isn't true: that code is equivalent to if (a && b && !c).

Fri, Oct 4, 4:37 AM
sammccall committed rGb3cc321cb2ee: [Format] Fix docs after r373439 (authored by sammccall).
[Format] Fix docs after r373439
Fri, Oct 4, 2:53 AM
sammccall committed rL373724: [Format] Fix docs after r373439.
[Format] Fix docs after r373439
Fri, Oct 4, 2:52 AM
sammccall added a comment to D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version.

Thanks, rL373724 should fix.

Fri, Oct 4, 2:51 AM · Restricted Project, Restricted Project
sammccall committed rGf6a2086d528d: [lldb] Fix -Wreorder-ctor in r373673 (authored by sammccall).
[lldb] Fix -Wreorder-ctor in r373673
Fri, Oct 4, 2:43 AM
sammccall committed rL373721: [lldb] Fix -Wreorder-ctor in r373673.
[lldb] Fix -Wreorder-ctor in r373673
Fri, Oct 4, 2:42 AM
sammccall committed rG4128dc450069: [lldb] Fix typo in r373675 (authored by sammccall).
[lldb] Fix typo in r373675
Fri, Oct 4, 2:34 AM
sammccall committed rL373719: [lldb] Fix typo in r373675.
[lldb] Fix typo in r373675
Fri, Oct 4, 2:33 AM
sammccall accepted D68439: Second attempt to add iterator_range::empty().
Fri, Oct 4, 1:15 AM · Restricted Project

Wed, Oct 2

sammccall added inline comments to D68335: [CodeComplete] Ensure object is the same in compareOverloads().
Wed, Oct 2, 7:07 AM · Restricted Project, Restricted Project
sammccall accepted D68335: [CodeComplete] Ensure object is the same in compareOverloads().

(oops, meant to accept with comments)

Wed, Oct 2, 7:07 AM · Restricted Project, Restricted Project
sammccall committed rG20c5fbb1af08: [clangd] SelectionTree should mark a node as fully-selected if the only claimed… (authored by sammccall).
[clangd] SelectionTree should mark a node as fully-selected if the only claimed…
Wed, Oct 2, 3:06 AM
sammccall committed rL373442: [clangd] SelectionTree should mark a node as fully-selected if the only claimed….
[clangd] SelectionTree should mark a node as fully-selected if the only claimed…
Wed, Oct 2, 3:00 AM
sammccall closed D66872: [clangd] SelectionTree should mark a node as fully-selected if the only claimed tokens were early-claimed..
Wed, Oct 2, 3:00 AM · Restricted Project, Restricted Project
sammccall committed rG08bfd9e42e14: [ClangFormat] relnotes for r373439 (authored by sammccall).
[ClangFormat] relnotes for r373439
Wed, Oct 2, 2:57 AM
sammccall accepted D68325: [clangd] Bail out early if we are sure that the symbol is used outside of the file..
Wed, Oct 2, 2:56 AM · Restricted Project, Restricted Project
sammccall committed rL373441: [ClangFormat] relnotes for r373439.
[ClangFormat] relnotes for r373439
Wed, Oct 2, 2:50 AM
sammccall committed rGe5032567903d: [ClangFormat] Future-proof Standard option, allow floating or pinning to… (authored by sammccall).
[ClangFormat] Future-proof Standard option, allow floating or pinning to…
Wed, Oct 2, 2:50 AM
sammccall committed rL373439: [ClangFormat] Future-proof Standard option, allow floating or pinning to….
[ClangFormat] Future-proof Standard option, allow floating or pinning to…
Wed, Oct 2, 2:50 AM
sammccall closed D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version.
Wed, Oct 2, 2:50 AM · Restricted Project, Restricted Project
sammccall committed rG442be7277734: [clang-tidy] Fix typo in r373428 (authored by sammccall).
[clang-tidy] Fix typo in r373428
Wed, Oct 2, 2:16 AM
sammccall added inline comments to rL373428: [clang-tidy] Fix for commits rL372706 and rL372711.
Wed, Oct 2, 2:15 AM
sammccall committed rL373436: [clang-tidy] Fix typo in r373428.
[clang-tidy] Fix typo in r373428
Wed, Oct 2, 2:14 AM
sammccall accepted D68324: [clangd] Always send file URIs to editors.
Wed, Oct 2, 2:03 AM · Restricted Project, Restricted Project
sammccall accepted D68322: [clang-rename] Better renaming the typedef decl..
Wed, Oct 2, 2:03 AM · Restricted Project, Restricted Project

Mon, Sep 30

sammccall accepted D68119: [clangd] Handle OverloadExpr in targetDecl.
Mon, Sep 30, 6:50 AM · Restricted Project, Restricted Project

Sep 16 2019

sammccall added a comment to D67358: [clangd] Implement semantic selections..

Which LSP feature is this related to?

Sep 16 2019, 1:57 AM · Restricted Project, Restricted Project

Sep 13 2019

sammccall accepted D67358: [clangd] Implement semantic selections..

Please make sure you run clang-format (I think it'll add missing newlines at EOF)

Sep 13 2019, 7:44 AM · Restricted Project, Restricted Project
sammccall added a comment to D67536: [WIP] [clangd] Add support for an inactive regions notification.

Rather than a separate method with parallel implementation, this seems very closely related to the syntax highlighting feature.

Sep 13 2019, 7:22 AM · Restricted Project
sammccall added a comment to D65043: [Format] Add C++20 standard to style options.

Not sure if this patch is still live?

Sep 13 2019, 7:10 AM · Restricted Project
sammccall updated the diff for D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version.

Add fairly contrived test that demonstrates the difference between c++17 and latest (20) parsing mode.

Sep 13 2019, 3:14 AM · Restricted Project, Restricted Project
sammccall created D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version.
Sep 13 2019, 2:34 AM · Restricted Project, Restricted Project
sammccall accepted D67405: Make FormatToken::Type private..

This looks fine as it is, adding a side-effect to a function that's called setType and is called in lots of places may be hard to reason about.

Sep 13 2019, 1:22 AM · Restricted Project

Sep 9 2019

sammccall added a comment to D67358: [clangd] Implement semantic selections..

Nice! Particularly: great tests.

Sep 9 2019, 11:04 AM · Restricted Project, Restricted Project
sammccall added a comment to D67172: [clangd] Use pre-populated mappings for standard symbols.

"we could try" sounds like we *don't* know how to eliminate it. Parsing manpages aside, I thought the main problem was these symbols are nonstandard and an infinitely portable qname->header mapping simply didn't exist.

I would expect qualified names to be more portable than paths, but might be mistaken. I recall that we might run into problems if folks define some names as macros instead of functions, but I would be interested to see how common is this.

In practice, I expect almost all of these names to be C and thus unqualified.

Sep 9 2019, 8:27 AM · Restricted Project, Restricted Project
sammccall accepted D67172: [clangd] Use pre-populated mappings for standard symbols.

LG, though if we can drop the struct and make MaxSuffixComponents a constant it'd be simpler still.

Sep 9 2019, 7:27 AM · Restricted Project, Restricted Project
sammccall added a comment to D67172: [clangd] Use pre-populated mappings for standard symbols.

I do wonder whether we're microoptimizing for the tests too much, I don't think 5% on the tests is worth very much in itself, unless it's speeding up real workloads or improving the code (it may well be).

Even though tests don't parse real C++ programs, I wouldn't call it a micro-optimization. Spending 5% on such a low-level operation is not ok, small things like that can add up and have a subtle effect on performance.

Only if it's 5% of something meaningful. If the denominator isn't something we care about, then it's really "spending XXX usec is not ok" - which depends on XXX I think.

Sep 9 2019, 5:15 AM · Restricted Project, Restricted Project
sammccall committed rG7c5697c8b24c: [clangd] Update clangd-vscode docs to be more user-focused. (authored by sammccall).
[clangd] Update clangd-vscode docs to be more user-focused.
Sep 9 2019, 4:37 AM
sammccall committed rL371390: [clangd] Update clangd-vscode docs to be more user-focused..
[clangd] Update clangd-vscode docs to be more user-focused.
Sep 9 2019, 4:37 AM
sammccall closed D67092: [clangd] Update clangd-vscode docs to be more user-focused..
Sep 9 2019, 4:37 AM · Restricted Project, Restricted Project
sammccall accepted D66637: [clangd] Support multifile edits as output of Tweaks.
Sep 9 2019, 4:36 AM · Restricted Project, Restricted Project
sammccall added a comment to D67172: [clangd] Use pre-populated mappings for standard symbols.

I had the same reaction as Haojian to the original patch, thanks for clearing that up.

Sep 9 2019, 4:31 AM · Restricted Project, Restricted Project
sammccall added inline comments to D65433: [clangd] DefineInline action availability checks.
Sep 9 2019, 1:02 AM · Restricted Project
sammccall added a comment to D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..

BTW, This approach does look much better to me, it fits well into the VFS abstraction and I'd argue is fixing a bug in RedirectingFileSystem.
We do need to be careful about introducing new bugs, though. (or avoid the generality and just implement the parts LLDB needs, as a separate vfs::FS)

Sep 9 2019, 12:53 AM · Restricted Project, Restricted Project
sammccall updated subscribers of D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..
Sep 9 2019, 12:45 AM · Restricted Project, Restricted Project

Sep 5 2019

sammccall updated the diff for D66872: [clangd] SelectionTree should mark a node as fully-selected if the only claimed tokens were early-claimed..

remove special-case handling of VarDecl in ExtractFunction that is no longer needed.

Sep 5 2019, 7:59 AM · Restricted Project, Restricted Project

Sep 4 2019

sammccall accepted D67163: [Driver] Use shared singleton instance of DriverOptTable.
Sep 4 2019, 6:25 AM · Restricted Project, Restricted Project
sammccall committed rG3d79fd6fcc8a: [clangd] Fix SelectionTree behavior on implicit 'this' (authored by sammccall).
[clangd] Fix SelectionTree behavior on implicit 'this'
Sep 4 2019, 5:15 AM
sammccall committed rL370884: [clangd] Fix SelectionTree behavior on implicit 'this'.
[clangd] Fix SelectionTree behavior on implicit 'this'
Sep 4 2019, 5:14 AM
sammccall committed rGb2a984c0a885: [clangd] Remove macro-expansion-location from getBeginningOfIdentifier. Inline… (authored by sammccall).
[clangd] Remove macro-expansion-location from getBeginningOfIdentifier. Inline…
Sep 4 2019, 3:15 AM
sammccall committed rL370869: [clangd] Remove macro-expansion-location from getBeginningOfIdentifier. Inline….
[clangd] Remove macro-expansion-location from getBeginningOfIdentifier. Inline…
Sep 4 2019, 3:14 AM
sammccall committed rG2ae9da263942: [clangd] Remove obsolete includes. NFC (authored by sammccall).
[clangd] Remove obsolete includes. NFC
Sep 4 2019, 3:03 AM
sammccall committed rL370865: [clangd] Remove obsolete includes. NFC.
[clangd] Remove obsolete includes. NFC
Sep 4 2019, 3:02 AM
sammccall committed rG4ca718561f16: [clangd] Move threading helper to more appropriate header. NFC (authored by sammccall).
[clangd] Move threading helper to more appropriate header. NFC
Sep 4 2019, 2:56 AM
sammccall committed rL370864: [clangd] Move threading helper to more appropriate header. NFC.
[clangd] Move threading helper to more appropriate header. NFC
Sep 4 2019, 2:52 AM
sammccall committed rG915f9785e052: [clangd] Rename ClangdUnit.h -> ParsedAST.h. NFC (authored by sammccall).
[clangd] Rename ClangdUnit.h -> ParsedAST.h. NFC
Sep 4 2019, 2:47 AM
sammccall committed rL370862: [clangd] Rename ClangdUnit.h -> ParsedAST.h. NFC.
[clangd] Rename ClangdUnit.h -> ParsedAST.h. NFC
Sep 4 2019, 2:47 AM
sammccall added inline comments to D66637: [clangd] Support multifile edits as output of Tweaks.
Sep 4 2019, 1:38 AM · Restricted Project, Restricted Project
sammccall committed rGcf3a585fff07: [clangd] Split Preamble.h out of ClangdUnit.h. NFC (authored by sammccall).
[clangd] Split Preamble.h out of ClangdUnit.h. NFC
Sep 4 2019, 12:37 AM
sammccall committed rL370843: [clangd] Split Preamble.h out of ClangdUnit.h. NFC.
[clangd] Split Preamble.h out of ClangdUnit.h. NFC
Sep 4 2019, 12:37 AM
sammccall closed D67117: [clangd] Split Preamble.h out of ClangdUnit.h. NFC.
Sep 4 2019, 12:37 AM · Restricted Project, Restricted Project
sammccall added a comment to D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..

(I replied by email, it seems phabricator doesn't pick it up.)

Sep 4 2019, 12:28 AM · Restricted Project, Restricted Project

Sep 3 2019

sammccall added reviewers for D67117: [clangd] Split Preamble.h out of ClangdUnit.h. NFC: kadircet, ilya-biryukov.
Sep 3 2019, 11:02 AM · Restricted Project, Restricted Project
sammccall created D67117: [clangd] Split Preamble.h out of ClangdUnit.h. NFC.
Sep 3 2019, 10:57 AM · Restricted Project, Restricted Project
sammccall committed rG19cefc28787b: [clangd] Move getBeginningOfIdentifier from ClangdUnit to SourceCode. Drop… (authored by sammccall).
[clangd] Move getBeginningOfIdentifier from ClangdUnit to SourceCode. Drop…
Sep 3 2019, 8:34 AM
sammccall committed rL370768: [clangd] Move getBeginningOfIdentifier from ClangdUnit to SourceCode. Drop….
[clangd] Move getBeginningOfIdentifier from ClangdUnit to SourceCode. Drop…
Sep 3 2019, 8:34 AM
sammccall committed rG97e5de522e6d: [clangd] Decouple macro/decl-under-cursor finding. Don't pretend there can be… (authored by sammccall).
[clangd] Decouple macro/decl-under-cursor finding. Don't pretend there can be…
Sep 3 2019, 7:13 AM
sammccall committed rL370759: [clangd] Decouple macro/decl-under-cursor finding. Don't pretend there can be….
[clangd] Decouple macro/decl-under-cursor finding. Don't pretend there can be…
Sep 3 2019, 7:13 AM
sammccall committed rG80195e7d1c3a: [clangd] Wrong attribute on debug function in r370746 (authored by sammccall).
[clangd] Wrong attribute on debug function in r370746
Sep 3 2019, 6:54 AM
sammccall committed rL370757: [clangd] Wrong attribute on debug function in r370746.
[clangd] Wrong attribute on debug function in r370746
Sep 3 2019, 6:53 AM
sammccall updated the diff for D67092: [clangd] Update clangd-vscode docs to be more user-focused..

Fix mailing list link again

Sep 3 2019, 6:28 AM · Restricted Project, Restricted Project
sammccall updated the diff for D67092: [clangd] Update clangd-vscode docs to be more user-focused..

move images into doc-assets/

Sep 3 2019, 5:01 AM · Restricted Project, Restricted Project
sammccall added inline comments to D67092: [clangd] Update clangd-vscode docs to be more user-focused..
Sep 3 2019, 4:54 AM · Restricted Project, Restricted Project
sammccall updated the diff for D67092: [clangd] Update clangd-vscode docs to be more user-focused..

mention rename

Sep 3 2019, 4:52 AM · Restricted Project, Restricted Project
sammccall updated the diff for D67092: [clangd] Update clangd-vscode docs to be more user-focused..

describe refactoring features

Sep 3 2019, 4:49 AM · Restricted Project, Restricted Project
sammccall committed rG489cc589c557: [clangd] Add targetDecl(), which determines what declaration an AST node refers… (authored by sammccall).
[clangd] Add targetDecl(), which determines what declaration an AST node refers…
Sep 3 2019, 4:41 AM
sammccall committed rL370746: [clangd] Add targetDecl(), which determines what declaration an AST node refers….
[clangd] Add targetDecl(), which determines what declaration an AST node refers…
Sep 3 2019, 4:34 AM