- User Since
- Aug 26 2016, 6:53 AM (147 w, 4 d)
Revert multi-range support. Add early hit detection (before children) instead.
Add more tests.
Thanks for the comments here and the offline discussion.
Implementation LG though please do check that the new test results look useful and not too duplicative
Wed, Jun 19
Sorry, I'm having trouble understanding this patch. Can you try to find some clearer names for the new concepts, or describe how they differ?
Tue, Jun 18
Thanks for exposing the ND, cleaner.
Found another problem :-( not in your code but about this whole approach to using the index.
Let's talk tomorrow
Can we add a test using TestTU that does a very basic verification of expanded/spelled tokens (first after preamble, last token in file)?
LG but needs tests
Can you explain why this is important?
(in the code)
i mean ping
Sun, Jun 16
Code gets shorter, tests get longer, very nice :-)
Tue, Jun 11
Thanks for pushing on this. I guess this must affect all clang-tools when used with a wrapper, which seems important. (I've just been using bazel and local cmake, so haven't hit this myself).
Mon, Jun 10
argv does carry important information though, I think this will break a lot of things. It's... concerning that no tests broke.
OK, this has been stuck for a while and (as discussed a bit offline) I haven't been able to make the alternative approaches work.
Fri, Jun 7
Sorry, I don't have any context on this (I just "blindly" fixed an asan error at one point).
Thu, Jun 6
One thing that's unclear to me is whether your aim is to
- solve a concrete problem for your organization
- solve a family of problems for similar organizations
- add a new way of configuring styles for many types of users/projects
Sorry about the delay here. Happy to chat offline if I'm being confusing.
Implementation looks good. I can't see a better way to solve this problem, it's just a bit unfortunate to have a sophisticated solution but not be able to turn it on by default.
Tue, Jun 4
Fri, May 31
Oops, we weren't handling the case when the newly-added overload is dominated by an existing one. Fixed.
Handle methods without "normal" identifier names.
Trigger in both directions (dominated and dominated-by).
Wed, May 29
Tue, May 28
Add DumpRecordLayout. Fix a small SelectionTree bug uncovered by these tweaks.
Mon, May 27
Thanks, I think you're right about all of this. Implementation looks OK too. Please add TODOs for the cases where we're punting to later vs deciding not to fix.
Awesome, thank you!
May 23 2019
May 21 2019
Definitely like the choice of CompositeNode owning the concrete storage!