Page MenuHomePhabricator

[Alignment][NFC] Finish transition for `Loads`
ClosedPublic

Authored by gchatelet on Mon, Oct 21, 5:56 AM.

Details

Summary

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Diff Detail

Event Timeline

gchatelet created this revision.Mon, Oct 21, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Oct 21, 5:56 AM
courbet added inline comments.Mon, Oct 21, 6:08 AM
llvm/lib/Analysis/Loads.cpp
207

Create an Align here ?

as discussed maybe something like:

'Align DataLayout::getValueOrABITypeAlignment(MaybeAlign)'

gchatelet updated this revision to Diff 225877.Mon, Oct 21, 7:05 AM
  • use DL.getValueOrABITypeAlignment
  • Address comments
gchatelet marked an inline comment as done.Mon, Oct 21, 7:06 AM
courbet accepted this revision.Mon, Oct 21, 7:51 AM
This revision is now accepted and ready to land.Mon, Oct 21, 7:51 AM
This revision was automatically updated to reflect the committed changes.