Page MenuHomePhabricator

Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`
ClosedPublic

Authored by broadwaylamb on Aug 29 2019, 4:00 PM.

Details

Summary

Some Driver tests relied on the default resource direcory having per-os per-arch subdirectory layout, and when clang is built with -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, those test fail, because clang by default assumes per-target subdirectories.

Explicitly set -resource-dir flag to point to a tree with per-os per-arch layout.

See also: D45604, D62469

Event Timeline

broadwaylamb created this revision.Aug 29 2019, 4:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2019, 4:00 PM
broadwaylamb edited the summary of this revision. (Show Details)Aug 29 2019, 4:02 PM
phosek accepted this revision.Aug 29 2019, 4:06 PM

LGTM

This revision is now accepted and ready to land.Aug 29 2019, 4:06 PM

LGTM

Can you please commit this? I don't have commit access.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2019, 9:52 PM