Page MenuHomePhabricator

filcab (Filipe Cabecinhas)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 12:14 PM (348 w, 6 d)

Recent Activity

Mon, Sep 2

filcab committed rL370640: Added filcab.
Added filcab
Mon, Sep 2, 4:08 AM

Feb 5 2019

filcab added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

Hi, there's no reply from the people who were added to this review.
May I understand that as ready to be installed?

filcab is still marked as blocking this. Also I thought you were going to file a new differential that had the commits list cc’ed correctly? See above where I asked you to add a couple of relevant reviewers to the new differential (and me as a subscriber) when you do.

@filcab : Are you fine with the patch as it is right now?

@dexonsmith: I'm not sure why a new differential should be created? I updated reviewers in this one.

Feb 5 2019, 9:41 AM

Jan 25 2019

filcab accepted D57224: [CMake] Quick-Fix FileCheck target does not exist when building against LLVM install-tree with COMPILER_RT_INCLUDE_TESTS=ON.

if you are concerned about dependencies in non-standalone builds, they are handled separately from this. This addition was only done for COMPILER_RT_STANDALONE_BUILD.

Jan 25 2019, 7:33 AM
filcab added a comment to D57224: [CMake] Quick-Fix FileCheck target does not exist when building against LLVM install-tree with COMPILER_RT_INCLUDE_TESTS=ON.

Hah, I had the exact same fix on our private branch.

Jan 25 2019, 7:18 AM

Jan 21 2019

filcab added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
In D56485#1364241, @pcc wrote:

This change would only impact the "diagnostic" (non-production) mode of CFI. In production builds we do not link the runtime library at all. So from a CFI perspective this is fine.

Jan 21 2019, 2:26 AM

Jan 18 2019

filcab added a reviewer for D56485: Always compare C++ typeinfo (based on libstdc++ implementation).: pcc.
Jan 18 2019, 5:59 AM
filcab updated subscribers of D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

On the platform I most care about, we have defined SANITIZER_NON_UNIQUE_TYPEINFO, so I am ok with this patch from our point of view. But I want to make sure other platforms using this are ok with the additional slowdown (assuming they have typeinfo equality).

Jan 18 2019, 5:58 AM
filcab added reviewers for D56485: Always compare C++ typeinfo (based on libstdc++ implementation).: mehdi_amini, rnk.
Jan 18 2019, 5:57 AM

Jan 17 2019

filcab requested changes to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
Jan 17 2019, 7:47 AM
filcab added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

I have a few problems/questions with this patch as it is right now. Please address them before committing.

Jan 17 2019, 7:47 AM

Dec 3 2018

filcab added a comment to D32950: Support C++1z features in `__has_extension`.

Hi Eric,

Dec 3 2018, 6:33 AM

Nov 8 2018

filcab added a comment to D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found..

Sorry to ressurect this review, but I have a few questions:

  • What kind of functions fail?
  • Are there bugzillas to track these?
  • How can a compiler expect to have blacklists for "all" its CFI clients? (I'm ok with having a default for "most-used, well-known, problematic functions", e.g: functions in libstdc++ or libc++)
  • clang/compiler-rt don't seem to have a default blacklist, what should the contents be? This patch seems to be saying "There are some well-known functions that should never be instrumented with CFI, I'll provide a list of names", which doesn't really seem possible to do in general, for "most" CFI-toolchain clients. As I see it, each client will need to have their own blacklist, and provide it as an argument if needed. Which brings us to:
  • If I pass -fsanitize-blacklist=my_blacklist.txt I still get an error. This is not ideal, as I might be working on the blacklist to include in my toolchain/program.
Nov 8 2018, 8:10 AM

Nov 2 2018

filcab added a comment to D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

Thanks for the review.
Unfortunately, I forgot to edit the commit message. Let's hope no one gets too confused (phab reviews will be up anyway, so should be easy to figure out).
Filipe

Nov 2 2018, 10:34 AM
filcab committed rL346001: Change -fsanitize-address-poison-class-member-array-new-cookie to -fsanitize….
Change -fsanitize-address-poison-class-member-array-new-cookie to -fsanitize…
Nov 2 2018, 10:31 AM
filcab committed rC346001: Change -fsanitize-address-poison-class-member-array-new-cookie to -fsanitize….
Change -fsanitize-address-poison-class-member-array-new-cookie to -fsanitize…
Nov 2 2018, 10:31 AM
filcab closed D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.
Nov 2 2018, 10:31 AM
filcab closed D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.
Nov 2 2018, 10:31 AM
filcab updated the diff for D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

Reworded with feedback from the review.

Nov 2 2018, 9:00 AM

Nov 1 2018

filcab updated the diff for D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

Expand yet a bit more.

Nov 1 2018, 10:58 AM
filcab updated the diff for D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

Expanded a bit more on the documentation, mentioning that user code might be technically allowed to access those array cookies, but that users might not want to allow it.

Nov 1 2018, 9:37 AM

Oct 30 2018

filcab added a comment to rL345654: Mark vptr-non-unique-typeinfo as a broken test for NetBSD/i386.

Why is this failing?

Oct 30 2018, 4:59 PM
filcab accepted D50251: [compiler-rt][ubsan] Implicit Conversion Sanitizer - integer sign change - compiler-rt part.

LGTMing.

Oct 30 2018, 11:59 AM · Unknown Object (Project)
filcab accepted D53869: [NFC][compiler-rt] Cleanup Implicit Conversion Sanitizer tests to use sized types.

Feel like actually marking these two reviews as accepted? :)

Oct 30 2018, 11:59 AM · Unknown Object (Project)
filcab added a comment to D53869: [NFC][compiler-rt] Cleanup Implicit Conversion Sanitizer tests to use sized types.

Looks good, thank you. Ideally, we'd have different names on those functions, but unless you have a script that generates this and is very easy to change, I'm ok with keeping them as they are.

Oct 30 2018, 10:56 AM · Unknown Object (Project)
filcab added inline comments to D50251: [compiler-rt][ubsan] Implicit Conversion Sanitizer - integer sign change - compiler-rt part.
Oct 30 2018, 6:24 AM · Unknown Object (Project)
filcab added a comment to D50251: [compiler-rt][ubsan] Implicit Conversion Sanitizer - integer sign change - compiler-rt part.

I have minor questions in inline comments, but sorry, I'll request a big change :-/

Oct 30 2018, 4:37 AM · Unknown Object (Project)
filcab added a comment to D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

So, three points:

  • That's not class-member-specific; you can have a placement operator new[] at global scope that isn't the special void* placement operator and therefore still has a cookie, and it would have just as much flexibility as a class-member override would. So the split you're trying to describe is the standard operators vs. custom ones.
  • Anyone can provide their own definition of the standard operators; there are some semantic restrictions on those definitions, but I'm not sure what about those restrictions would forbid this kind of capture.
  • Even with the standard implementations of the standard replaceable operators, I'm not sure what rule would actually outlaw the client from going from the result of new[] back to the cookie.

    At any rate, taking the feature as a given, the first point suggests -fsanitize-address-poison-custom-array-cookie or something along those lines. If we want a more standard-ese term than "custom", the standard refers to its operators collectively as "library allocation functions", so maybe "non-library".
Oct 30 2018, 4:17 AM
filcab updated the diff for D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

Missed the change in some places

Oct 30 2018, 3:47 AM
filcab updated the diff for D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

Update with name change, using rjmccall's suggestion

Oct 30 2018, 3:45 AM

Oct 26 2018

filcab added a comment to D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

This seems like an unreasonably long flag name. Can you try to find a shorter name for it?

-fsanitize-poison-extra-operator-new?
Not as explicit, but maybe ok if documented?

-fsanitize-address-poison-array-cookie?

I strongly dislike this one because "poison array cookie", in general, is always enabled (it's actually triggered by a runtime flag). This flag is about poisoning it in more cases (cases where the standard doesn't completely disallow accesses to the cookie, so we have to have a flag and can't enable it all the time).

Hmm. This naming discussion might be a proxy for another debate. I understand the argument that programs are allowed to assume a particular C++ ABI and therefore access the array cookie. And I can understand having an option that makes ASan stricter and disallow accessing the array cookie anyway. But I don't understand why this analysis is in any way case-specific, and the discussion you've linked doesn't seem particularly clarifying about that point. Can you explain this a little?

Oct 26 2018, 5:56 AM

Oct 25 2018

filcab added a comment to D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

This seems like an unreasonably long flag name. Can you try to find a shorter name for it?

-fsanitize-poison-extra-operator-new?
Not as explicit, but maybe ok if documented?

-fsanitize-address-poison-array-cookie?

Oct 25 2018, 9:45 AM

Oct 23 2018

filcab added a comment to D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

Thank you,
Filipe

Oct 23 2018, 3:34 AM

Oct 16 2018

filcab added a comment to D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.

This seems like an unreasonably long flag name. Can you try to find a shorter name for it?

Oct 16 2018, 3:59 AM

Oct 10 2018

filcab added a comment to D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks.

LGTM on the clang side too.

Oct 10 2018, 4:25 PM · Restricted Project, Unknown Object (Project)
filcab accepted D50902: [compiler-rt][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks.

Very sorry for the delay, and especially sorry for asking about the same thing over and over :|
Thanks for your patience,

Oct 10 2018, 7:47 AM · Unknown Object (Project)

Oct 8 2018

filcab updated subscribers of D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks.

Sorry about that. I’m away today but I don’t think you’ve answered my
questions about “why not support standalone UBSan in tests”. Sorry if I
missed the answers if you did. Will review the latest tomorrow.

Oct 8 2018, 3:52 AM · Restricted Project, Unknown Object (Project)

Sep 29 2018

filcab updated subscribers of D50902: [compiler-rt][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks.

0 only means “one of those two”, so I prefer your current patch then a
change to genericUB.

Sep 29 2018, 9:16 AM · Unknown Object (Project)
filcab added a comment to D50902: [compiler-rt][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks.

Thanks for working on this,
Filipe

Sep 29 2018, 6:06 AM · Unknown Object (Project)

Sep 27 2018

filcab added inline comments to D50902: [compiler-rt][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks.
Sep 27 2018, 9:31 AM · Unknown Object (Project)
filcab added inline comments to D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks.
Sep 27 2018, 8:26 AM · Restricted Project, Unknown Object (Project)
filcab created D52615: Handle -fsanitize-address-poison-class-member-array-new-cookie in the driver and propagate it to cc1.
Sep 27 2018, 8:13 AM
filcab added inline comments to D50902: [compiler-rt][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks.
Sep 27 2018, 7:54 AM · Unknown Object (Project)

Sep 13 2018

filcab accepted D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..

LGTM. Thank you!

Sep 13 2018, 4:07 PM

Sep 5 2018

filcab added a comment to D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..

For the iOS simulator the host and the device file system are the same so no work is required. For iOS devices the scripts handle this by copying back the log file to the host when they detect log_path= was in ASAN_OPTIONS/TSAN_OPTIONS/UBSAN_OPTIONS.

This made me curious: Why don't the scripts delete the file after copying it to the host?
If the problem here is the extra files leftover, the scripts for iOS devices can handle it, as they already know which files need to be copied. Then we can even avoid adding anything here. It's a much more contained change.

Sep 5 2018, 12:43 PM
filcab added a comment to D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..
To run just-built programs for tests. Not to run anything else

What? Why?
How else can you run commands on the device (cat/cp/rm/etc) and why the semantics of those is different?
Many sanitizer tests already need those commands (e.g. this was recently done for libFuzzer to support device integration)

Most lit commands are run on the host. The %run substitution is there for exactly that: "Take this just-built target executable and run it with these args".
All the cat/rm/etc commands are run on the host, as expected.

Sep 5 2018, 12:06 PM
filcab added a comment to D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..

@filcab The script is in iossim folder, so it's specifically for iOS simulators. Arbitrary devices and their support is irrelevant for this change.

Sep 5 2018, 12:05 PM
filcab added a comment to D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..

I don't think this is acceptable.
We have no guarantees we even have a shell on the devices. The run script might be doing all sort of things for commands to run on the device.

That is true. However for all scripts that are in-tree where this test is meant to pass (currently only the iOS simulator) I've fixed them to work so that %run rm has a special meaning.
We have out-of-tree scripts for running on iOS devices and I've modified those to also handle the %run rm semantics that is being proposed in this patch.

Out of tree consumers of compiler-rt that have their own device test infrastructure need (if this patch is merged) to specially handle %run rm.

%run has been used for one thing: To run just-built programs for tests. Not to run anything else. I don't think we should start to add more functionality to it, especially if we're just be going to special-case commands on it. We can just as easily create different substitutions. I see %run as having a very precise meaning, and not as a "this is a shell-like entry point to the device".

Sep 5 2018, 11:58 AM
filcab added a comment to D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices..

I don't think this is acceptable.
We have no guarantees we even have a shell on the devices. The run script might be doing all sort of things for commands to run on the device.

Sep 5 2018, 6:45 AM

Aug 2 2018

filcab committed rCRT338700: Add header guard to asan_report.h.
Add header guard to asan_report.h
Aug 2 2018, 4:06 AM
filcab committed rL338700: Add header guard to asan_report.h.
Add header guard to asan_report.h
Aug 2 2018, 4:05 AM

Aug 1 2018

filcab committed rL338577: Add missing condition.
Add missing condition
Aug 1 2018, 8:30 AM
filcab committed rCRT338577: Add missing condition.
Add missing condition
Aug 1 2018, 8:30 AM
filcab committed rC338553: Use a dummy target so the test passes when default target is for a toolchain….
Use a dummy target so the test passes when default target is for a toolchain…
Aug 1 2018, 6:43 AM
filcab committed rL338553: Use a dummy target so the test passes when default target is for a toolchain….
Use a dummy target so the test passes when default target is for a toolchain…
Aug 1 2018, 6:42 AM
filcab committed rL338552: Add REQUIRES: native to a test that assumes it.
Add REQUIRES: native to a test that assumes it
Aug 1 2018, 6:42 AM
filcab committed rC338552: Add REQUIRES: native to a test that assumes it.
Add REQUIRES: native to a test that assumes it
Aug 1 2018, 6:42 AM
filcab committed rCRT338535: Test: Enable exceptions for test that needs it.
Test: Enable exceptions for test that needs it
Aug 1 2018, 6:21 AM
filcab committed rL338535: Test: Enable exceptions for test that needs it.
Test: Enable exceptions for test that needs it
Aug 1 2018, 6:21 AM

Jul 26 2018

filcab accepted D48959: [compiler-rt][ubsan] Implicit Cast Sanitizer - integer truncation - compiler-rt part.

I have a nit I'd like to see addressed, otherwise LGTM.

Jul 26 2018, 8:22 AM · Unknown Object (Project)

Jul 20 2018

filcab closed D36434: [compiler-rt] Get rid of "%T" expansions.

Phabricator didn't pick it up. This was committed on July 10.

Jul 20 2018, 6:26 AM · Unknown Object (Project)

Jul 16 2018

filcab committed rCRT337170: [cfi] Don't pass a uint16_t to memset. Make sure the 16-bit constant is….
[cfi] Don't pass a uint16_t to memset. Make sure the 16-bit constant is…
Jul 16 2018, 6:47 AM
filcab committed rL337170: [cfi] Don't pass a uint16_t to memset. Make sure the 16-bit constant is….
[cfi] Don't pass a uint16_t to memset. Make sure the 16-bit constant is…
Jul 16 2018, 6:47 AM
filcab closed D49252: [cfi] Don't pass a uint16_t to memset. Make sure the 16-bit constant is appropriate for us..
Jul 16 2018, 6:47 AM

Jul 12 2018

filcab added a comment to D49252: [cfi] Don't pass a uint16_t to memset. Make sure the 16-bit constant is appropriate for us..

Thank you,
Filipe

Jul 12 2018, 3:46 PM
filcab created D49252: [cfi] Don't pass a uint16_t to memset. Make sure the 16-bit constant is appropriate for us..
Jul 12 2018, 10:12 AM

Jul 10 2018

filcab committed rL336673: [scudo] Use mkdir -p when creating directories for a test.
[scudo] Use mkdir -p when creating directories for a test
Jul 10 2018, 7:05 AM
filcab committed rCRT336673: [scudo] Use mkdir -p when creating directories for a test.
[scudo] Use mkdir -p when creating directories for a test
Jul 10 2018, 7:05 AM
filcab committed rCRT336661: [compiler-rt] Get rid of "%T" expansions.
[compiler-rt] Get rid of "%T" expansions
Jul 10 2018, 5:59 AM
filcab committed rL336661: [compiler-rt] Get rid of "%T" expansions.
[compiler-rt] Get rid of "%T" expansions
Jul 10 2018, 5:58 AM

Jul 6 2018

filcab added inline comments to D48959: [compiler-rt][ubsan] Implicit Cast Sanitizer - integer truncation - compiler-rt part.
Jul 6 2018, 4:18 AM · Unknown Object (Project)

Jul 5 2018

filcab added a comment to D48959: [compiler-rt][ubsan] Implicit Cast Sanitizer - integer truncation - compiler-rt part.

Like i said, not ready for the review :)

Jul 5 2018, 10:50 AM · Unknown Object (Project)
filcab added a comment to D48959: [compiler-rt][ubsan] Implicit Cast Sanitizer - integer truncation - compiler-rt part.

Looks good. I have a few questions, and would like some additional tests (explained in the comments).

Jul 5 2018, 7:28 AM · Unknown Object (Project)

Jul 4 2018

filcab added inline comments to D48935: [llvm-exegesis] Provide a way to handle memory instructions..
Jul 4 2018, 9:40 AM

Jul 3 2018

filcab updated the diff for D36434: [compiler-rt] Get rid of "%T" expansions.

Commandeering revision and posting an updated patch. Please review.

Jul 3 2018, 5:31 AM · Unknown Object (Project)
filcab commandeered D36434: [compiler-rt] Get rid of "%T" expansions.

"Commandeering" revision. I will post an updated patch in a bit, if all goes well with arc.

Jul 3 2018, 5:29 AM · Unknown Object (Project)
filcab added a comment to D46546: add suffix to report file name.

Check out test/sanitizer_common/TestCases/options-include.cc as an example you can use to adapt yours.
You might only need to change env_asan_opts to env_tool_opts to get it to work.

Jul 3 2018, 4:21 AM

Jun 29 2018

filcab committed rLLD335985: [lld] Address post-commit review of r335848.
[lld] Address post-commit review of r335848
Jun 29 2018, 8:39 AM
filcab committed rL335985: [lld] Address post-commit review of r335848.
[lld] Address post-commit review of r335848
Jun 29 2018, 8:39 AM
filcab updated subscribers of D48660: [UBSan] Add silence_unsigned_overflow flag..

Why create yet another way to disable the printing of warnings?
Why not use the suppressions mechanism which is already there?

Jun 29 2018, 7:45 AM
filcab committed rL335961: [cmake] Change WIN32 test to CMAKE_HOST_WIN32.
[cmake] Change WIN32 test to CMAKE_HOST_WIN32
Jun 29 2018, 3:39 AM

Jun 28 2018

filcab committed rC335858: Fix test that was failing on Windows due to too many backslashes.
Fix test that was failing on Windows due to too many backslashes
Jun 28 2018, 7:20 AM
filcab committed rL335858: Fix test that was failing on Windows due to too many backslashes.
Fix test that was failing on Windows due to too many backslashes
Jun 28 2018, 7:20 AM
filcab committed rL335848: Fix warning on MSVC by using size_t arithmetic instead of casting after the….
Fix warning on MSVC by using size_t arithmetic instead of casting after the…
Jun 28 2018, 5:43 AM
filcab committed rLLD335848: Fix warning on MSVC by using size_t arithmetic instead of casting after the….
Fix warning on MSVC by using size_t arithmetic instead of casting after the…
Jun 28 2018, 5:43 AM

Jun 26 2018

filcab abandoned D47952: ASan: Always call the version mismatch symbol before __asan_init.

We end up not needing this with our current setup, so no need to change it.
Thank you,
Filipe

Jun 26 2018, 6:20 AM

Jun 25 2018

filcab added a comment to D48142: [Sanitizers] Make sanitizer allocator linker-initialize compliant..

Clang still warns:

/Users/filcab/dev/llvm/compiler-rt/lib/asan/asan_allocator.cc:793:18: warning: declaration requires a global constructor [-Wglobal-constructors]
static Allocator instance(LINKER_INITIALIZED);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Jun 25 2018, 9:30 AM
filcab added a comment to D48142: [Sanitizers] Make sanitizer allocator linker-initialize compliant..

Clang still warns:

Jun 25 2018, 9:28 AM
filcab added a comment to D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_..

This got committed, but clang still warns:

Jun 25 2018, 9:27 AM
filcab removed a reviewer for D44243: [asan] Make ScopedInErrorReport::current_error_ linker-initialized: filcab.
Jun 25 2018, 5:34 AM · Unknown Object (Project)

Jun 15 2018

filcab added a comment to D36434: [compiler-rt] Get rid of "%T" expansions.

Hi Kuba,

Jun 15 2018, 3:46 AM · Unknown Object (Project)
filcab added a comment to D47952: ASan: Always call the version mismatch symbol before __asan_init.

Ping!

Jun 15 2018, 3:39 AM
filcab added inline comments to D48199: [scudo] Add verbose failures in place of CHECK(0).
Jun 15 2018, 3:30 AM

Jun 8 2018

filcab created D47952: ASan: Always call the version mismatch symbol before __asan_init.
Jun 8 2018, 10:00 AM

Jun 6 2018

filcab added a comment to D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4..

I have a minor nit + what Paul mentioned (missing a -NOT check). Otherwise LGTM.

Jun 6 2018, 4:40 AM

May 25 2018

filcab added inline comments to D47291: Proposal to make rtti errors more generic..
May 25 2018, 6:51 AM

May 19 2018

filcab updated subscribers of rC332804: [Driver] Loosen test for LLVM findNearest.

Is that test not reproducible locally?
I’m always afraid of temporary changes to tests becoming permanent, sorry.

May 19 2018, 5:46 AM

May 18 2018

filcab added inline comments to D45604: Support for multiarch runtimes layout.
May 18 2018, 8:21 AM

May 15 2018

filcab accepted D46836: Fix some rtti-options tests.

LGTM

May 15 2018, 6:58 AM

Apr 25 2018

filcab committed rL330829: [llvm-mca] Make ViewOptions static. NFCI.
[llvm-mca] Make ViewOptions static. NFCI
Apr 25 2018, 7:42 AM

Apr 12 2018

filcab accepted D36434: [compiler-rt] Get rid of "%T" expansions.

Hi Kuba,

Apr 12 2018, 2:55 AM · Restricted Project