Page MenuHomePhabricator

broadwaylamb (Sergej Jaskiewicz)
C++ developer @ Access Softek

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2019, 5:55 AM (67 w, 1 d)

Recent Activity

Thu, Sep 17

broadwaylamb added a comment to D83573: [libunwind] Support for leaf function unwinding..

We're having the same issue on our buildbot:
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/3013

Thu, Sep 17, 10:00 AM · Restricted Project, Restricted Project

Tue, Sep 8

broadwaylamb committed rGe7b40c5492e5: [llvm] [unittest] Allow getting a C string from the TempDir helper class (authored by broadwaylamb).
[llvm] [unittest] Allow getting a C string from the TempDir helper class
Tue, Sep 8, 3:53 PM

Thu, Sep 3

broadwaylamb committed rZORGc1cbdb0af36a: Run libc++ tests on AArch64 Windows-to-Linux cross builders (authored by broadwaylamb).
Run libc++ tests on AArch64 Windows-to-Linux cross builders
Thu, Sep 3, 11:20 AM
broadwaylamb closed D87058: Run libc++ tests on AArch64 Windows-to-Linux cross builders.
Thu, Sep 3, 11:20 AM

Wed, Sep 2

broadwaylamb requested review of D87058: Run libc++ tests on AArch64 Windows-to-Linux cross builders.
Wed, Sep 2, 3:20 PM
broadwaylamb abandoned D84801: [libcxx] [test] XFAIL midpoint.float.pass on AArch64 with compiler-rt.

D85032 has landed, this patch is not needed anymore.

Wed, Sep 2, 3:20 PM · Restricted Project

Tue, Sep 1

broadwaylamb committed rG224d8153b53b: [llvm] [unittests] Fix failing test 'FileCollectorTest.addDirectory' (authored by broadwaylamb).
[llvm] [unittests] Fix failing test 'FileCollectorTest.addDirectory'
Tue, Sep 1, 2:55 PM
broadwaylamb committed rGfad75598d272: [llvm] [unittests] Remove temporary files after they're not needed (authored by broadwaylamb).
[llvm] [unittests] Remove temporary files after they're not needed
Tue, Sep 1, 2:35 PM
broadwaylamb closed D83228: [llvm] [unittests] Remove some temporary files after they're not needed.
Tue, Sep 1, 2:35 PM · Restricted Project
broadwaylamb updated the diff for D83228: [llvm] [unittests] Remove some temporary files after they're not needed.

Make the path() member function of TempDir non-template.

Tue, Sep 1, 2:28 PM · Restricted Project

Mon, Aug 31

broadwaylamb added inline comments to D83228: [llvm] [unittests] Remove some temporary files after they're not needed.
Mon, Aug 31, 5:47 AM · Restricted Project
broadwaylamb added a comment to D83228: [llvm] [unittests] Remove some temporary files after they're not needed.

ping

Mon, Aug 31, 2:36 AM · Restricted Project

Aug 12 2020

broadwaylamb added inline comments to D84801: [libcxx] [test] XFAIL midpoint.float.pass on AArch64 with compiler-rt.
Aug 12 2020, 4:28 PM · Restricted Project

Aug 11 2020

broadwaylamb added a comment to D83228: [llvm] [unittests] Remove some temporary files after they're not needed.

@sammccall could you please take a look?

Aug 11 2020, 11:04 AM · Restricted Project
broadwaylamb updated the diff for D83228: [llvm] [unittests] Remove some temporary files after they're not needed.

Address review comments, change some tests that didn't use the RAII objects to use them where appropriate.

Aug 11 2020, 11:03 AM · Restricted Project

Aug 3 2020

broadwaylamb added inline comments to D84801: [libcxx] [test] XFAIL midpoint.float.pass on AArch64 with compiler-rt.
Aug 3 2020, 11:02 AM · Restricted Project

Jul 29 2020

broadwaylamb added inline comments to D84801: [libcxx] [test] XFAIL midpoint.float.pass on AArch64 with compiler-rt.
Jul 29 2020, 10:08 AM · Restricted Project

Jul 28 2020

broadwaylamb requested review of D84801: [libcxx] [test] XFAIL midpoint.float.pass on AArch64 with compiler-rt.
Jul 28 2020, 2:30 PM · Restricted Project

Jul 27 2020

broadwaylamb added a comment to D83490: [cmake] Support running compiler-rt tests in CrossWinToARMLinux.cmake.
  • looks like ssh.py arguments have been changed since the diff file was placed. Currently the correct string for COMPILER_RT_EMULATOR is the following:
set(COMPILER_RT_EMULATOR                "\\\"${Python3_EXECUTABLE}\\\" \\\"${LLVM_PROJECT_DIR}/libcxx/utils/ssh.py\\\" --execdir %%T --host ${REMOTE_TEST_USER}@${REMOTE_TEST_HOST} %%t" CACHE STRING "")
Jul 27 2020, 4:15 PM · Restricted Project
broadwaylamb committed rGa566e616202b: Reland "[compiler-rt] [test] Allow expanding lit substitutions recursively" (authored by broadwaylamb).
Reland "[compiler-rt] [test] Allow expanding lit substitutions recursively"
Jul 27 2020, 1:44 PM
broadwaylamb committed rG4dd5c2bee366: [lit] Don't expand escapes until all substitutions have been applied (authored by broadwaylamb).
[lit] Don't expand escapes until all substitutions have been applied
Jul 27 2020, 8:09 AM
broadwaylamb closed D83894: [lit] Don't expand escapes until all substitutions have been applied.
Jul 27 2020, 8:09 AM · Restricted Project
broadwaylamb added a comment to D83894: [lit] Don't expand escapes until all substitutions have been applied.

I've verified that it works with the test suites that you've mentioned, and also compiler-rt tests. I'm going to commit it now.

Jul 27 2020, 8:03 AM · Restricted Project

Jul 15 2020

broadwaylamb updated the diff for D83894: [lit] Don't expand escapes until all substitutions have been applied.

Remove redundant conversion of a list comprehension to list.

Jul 15 2020, 12:24 PM · Restricted Project
broadwaylamb added inline comments to D83894: [lit] Don't expand escapes until all substitutions have been applied.
Jul 15 2020, 12:22 PM · Restricted Project
broadwaylamb updated the diff for D83894: [lit] Don't expand escapes until all substitutions have been applied.

Replace %% with #_MARKER_# before each substitution.

Jul 15 2020, 12:16 PM · Restricted Project
broadwaylamb updated the diff for D83894: [lit] Don't expand escapes until all substitutions have been applied.

Address the review comments

Jul 15 2020, 11:50 AM · Restricted Project
Herald added a project to D83894: [lit] Don't expand escapes until all substitutions have been applied: Restricted Project.
Jul 15 2020, 11:21 AM · Restricted Project

Jul 14 2020

broadwaylamb committed rGfaa7e306e41b: Revert "Revert "[compiler-rt] [test] Use the parent process env as base env in… (authored by broadwaylamb).
Revert "Revert "[compiler-rt] [test] Use the parent process env as base env in…
Jul 14 2020, 1:30 AM
broadwaylamb added a reverting change for rG979c5023d3f0: Revert "[compiler-rt] [test] Use the parent process env as base env in tests": rGfaa7e306e41b: Revert "Revert "[compiler-rt] [test] Use the parent process env as base env in….
Jul 14 2020, 1:30 AM

Jul 13 2020

broadwaylamb added a comment to D83719: [compiler-rt][MSAN][test] Update buffersize for UTF-8 to C convert.

Could you please explain why D83486 broke this test and what does PowerPC have to do with it? I’m just curious.

Jul 13 2020, 2:41 PM · Restricted Project

Jul 10 2020

broadwaylamb committed rG979c5023d3f0: Revert "[compiler-rt] [test] Use the parent process env as base env in tests" (authored by broadwaylamb).
Revert "[compiler-rt] [test] Use the parent process env as base env in tests"
Jul 10 2020, 10:02 AM
broadwaylamb added a reverting change for rG5ab446cfe550: [compiler-rt] [test] Use the parent process env as base env in tests: rG979c5023d3f0: Revert "[compiler-rt] [test] Use the parent process env as base env in tests".
Jul 10 2020, 10:02 AM
broadwaylamb added a comment to rG5ab446cfe550: [compiler-rt] [test] Use the parent process env as base env in tests.
Jul 10 2020, 9:54 AM

Jul 9 2020

broadwaylamb added a comment to D83429: [libc++] [test] Introduce the `--test-executable` option in ssh.py.

Is it not possible to satisfy this convention in the compiler-rt tests?

Jul 9 2020, 10:13 AM · Restricted Project
broadwaylamb committed rG8372d505082a: [compiler-rt] [test] Allow expanding lit substitutions recursively (authored by broadwaylamb).
[compiler-rt] [test] Allow expanding lit substitutions recursively
Jul 9 2020, 9:49 AM
broadwaylamb closed D83489: [compiler-rt] [test] Allow expanding lit substitutions recursively.
Jul 9 2020, 9:49 AM · Restricted Project
broadwaylamb committed rG5ab446cfe550: [compiler-rt] [test] Use the parent process env as base env in tests (authored by broadwaylamb).
[compiler-rt] [test] Use the parent process env as base env in tests
Jul 9 2020, 9:45 AM
broadwaylamb closed D83486: [compiler-rt] [test] Use the parent process env as base env in tests.
Jul 9 2020, 9:44 AM · Restricted Project
broadwaylamb committed rGa89d54fd61a6: [compiler-rt] Better Windows support for running tests in external shell (authored by broadwaylamb).
[compiler-rt] Better Windows support for running tests in external shell
Jul 9 2020, 9:40 AM
broadwaylamb closed D83485: [compiler-rt] Better Windows support for running tests in external shell.
Jul 9 2020, 9:40 AM · Restricted Project
broadwaylamb added a comment to D83485: [compiler-rt] Better Windows support for running tests in external shell.

@compnerd thank your for responding so fast!

Jul 9 2020, 9:30 AM · Restricted Project
broadwaylamb added a comment to D83485: [compiler-rt] Better Windows support for running tests in external shell.

Can you add an explanation for why the conversion to ascii was removed? I don't immediately see why that is needed, not that ascii is a great choice.

Jul 9 2020, 9:24 AM · Restricted Project
Herald added a project to D83490: [cmake] Support running compiler-rt tests in CrossWinToARMLinux.cmake: Restricted Project.
Jul 9 2020, 9:06 AM · Restricted Project
Herald added a project to D83489: [compiler-rt] [test] Allow expanding lit substitutions recursively: Restricted Project.
Jul 9 2020, 9:04 AM · Restricted Project
Herald added a project to D83486: [compiler-rt] [test] Use the parent process env as base env in tests: Restricted Project.
Jul 9 2020, 8:50 AM · Restricted Project
Herald added a project to D83485: [compiler-rt] Better Windows support for running tests in external shell: Restricted Project.
Jul 9 2020, 8:36 AM · Restricted Project
broadwaylamb added a comment to D83228: [llvm] [unittests] Remove some temporary files after they're not needed.

Gentle ping.

Jul 9 2020, 7:16 AM · Restricted Project

Jul 8 2020

Herald added a reviewer for D83429: [libc++] [test] Introduce the `--test-executable` option in ssh.py: Restricted Project.
Jul 8 2020, 2:49 PM · Restricted Project

Jul 6 2020

Herald added a project to D83228: [llvm] [unittests] Remove some temporary files after they're not needed: Restricted Project.
Jul 6 2020, 7:26 AM · Restricted Project

Jun 23 2020

broadwaylamb added a comment to D70815: Enable `-funwind-tables` flag when building libunwind.

I went ahead and reverted this, as it broke how some cmake tests within libunwind work.

As this disables linking, it falsely makes any test succeed that depends on linking, and there's a few such tests in cmake/config-ix.cmake (check_library_exists(c fopen "" LIBUNWIND_HAS_C_LIB), check_library_exists(dl dladdr "" LIBUNWIND_HAS_DL_LIB), etc).

Therefore, set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY) has to be carefully placed at a spot where all such tests that does require linking already has been completed.

This was fixed in a later commit, correct?

Jun 23 2020, 1:32 AM · Restricted Project, Restricted Project, Restricted Project

Jun 15 2020

broadwaylamb committed rGc310d0de3955: [cmake] Invoke ssh.py using Python interpreter, not as executable in… (authored by broadwaylamb).
[cmake] Invoke ssh.py using Python interpreter, not as executable in…
Jun 15 2020, 2:22 PM

Jun 10 2020

broadwaylamb committed rGc148e15c255e: [compiler-rt] [test] Fix NameError when loading lit.cfg.py for crt (authored by broadwaylamb).
[compiler-rt] [test] Fix NameError when loading lit.cfg.py for crt
Jun 10 2020, 3:48 AM
broadwaylamb closed D79892: [compiler-rt] [test] Fix NameError when loading lit.cfg.py for crt.
Jun 10 2020, 3:48 AM · Restricted Project

Jun 3 2020

broadwaylamb added a comment to D79892: [compiler-rt] [test] Fix NameError when loading lit.cfg.py for crt.

Do you have commit permissions or do you need us to land this for you?

Jun 3 2020, 1:10 PM · Restricted Project

Jun 1 2020

broadwaylamb added a comment to D79892: [compiler-rt] [test] Fix NameError when loading lit.cfg.py for crt.

@compnerd can I ask you to take a look?

Jun 1 2020, 10:12 AM · Restricted Project

May 25 2020

broadwaylamb added a comment to D79892: [compiler-rt] [test] Fix NameError when loading lit.cfg.py for crt.

ping

May 25 2020, 10:10 AM · Restricted Project
broadwaylamb committed rGb62ce9e05d9e: Re-commit "[libc++] [test] Generate static_test_env on the fly" (authored by broadwaylamb).
Re-commit "[libc++] [test] Generate static_test_env on the fly"
May 25 2020, 9:38 AM
broadwaylamb committed rG3873d0b3d899: Re-commit "[cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake" (authored by broadwaylamb).
Re-commit "[cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake"
May 25 2020, 9:38 AM
broadwaylamb closed D78200: [libc++] [test] Generate static_test_env on the fly.
May 25 2020, 9:38 AM · Restricted Project

May 18 2020

broadwaylamb added a comment to D79892: [compiler-rt] [test] Fix NameError when loading lit.cfg.py for crt.

ping

May 18 2020, 5:19 AM · Restricted Project

May 15 2020

broadwaylamb added inline comments to D79592: [DebugInfo] support for DW_AT_data_location in llvm.
May 15 2020, 8:39 AM · Restricted Project, debug-info
broadwaylamb added inline comments to D79306: llvm rejects DWARF operator DW_OP_push_object_address..
May 15 2020, 8:39 AM · Restricted Project, debug-info

May 14 2020

broadwaylamb updated the diff for D79892: [compiler-rt] [test] Fix NameError when loading lit.cfg.py for crt.

Copy the logic of setting execute_external from lit.common.cfg.py.

May 14 2020, 4:15 AM · Restricted Project

May 13 2020

broadwaylamb updated the summary of D79892: [compiler-rt] [test] Fix NameError when loading lit.cfg.py for crt.
May 13 2020, 11:57 AM · Restricted Project
broadwaylamb created D79892: [compiler-rt] [test] Fix NameError when loading lit.cfg.py for crt.
May 13 2020, 11:57 AM · Restricted Project

May 7 2020

broadwaylamb updated the diff for D78200: [libc++] [test] Generate static_test_env on the fly.

Reimplement CWDGuard using POSIX functions.

May 7 2020, 2:41 PM · Restricted Project
broadwaylamb updated subscribers of D78200: [libc++] [test] Generate static_test_env on the fly.

Buildbot's Git module allows you to pass in a config object, so I don't understand the problem.
http://docs.buildbot.net/0.8.9/manual/cfg-buildsteps.html#git

Are you using an even older version of Buildbot?
If so you can always insert the symlink config option by putting it in a .gitconfig file.

May 7 2020, 2:09 PM · Restricted Project
broadwaylamb committed rGddfe58822eca: Revert "[cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake" (authored by broadwaylamb).
Revert "[cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake"
May 7 2020, 5:04 AM
broadwaylamb added a reverting change for rG67175d8dc53b: [cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake: rGddfe58822eca: Revert "[cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake".
May 7 2020, 5:04 AM

May 6 2020

broadwaylamb added a comment to D78200: [libc++] [test] Generate static_test_env on the fly.

Sorry for jumping in without context, but wanted to chime in on one thing.

Windows doesn't really have a concept of symlinks. So, when the monorepo is cloned, those symlinks turn to ordinary text files. Previously, if we cross-compiled libc++ for some symlink-friendly system (e. g. Linux) and ran tests on the target system, some tests would fail.

This isn't right. Windows has supported symbolic links since Vista. The big limitation was that you needed to be in an elevated process to be able to create symbolic links. Windows 10 lifted that limitation in Developer Mode starting with the April 2017 release (https://blogs.windows.com/windowsdeveloper/2016/12/02/symlinks-windows-10/). If git for Windows isn't creating symbolic links properly, that's a git issue and not a Windows issue (although I recognize it doesn't make much difference for the end user). Some searching suggests that you should be able to configure Git on Windows to handle symlinks correctly (https://github.com/libgit2/libgit2/pull/4713, and https://github.community/t5/How-to-use-Git-and-GitHub/git-bash-symbolic-links-on-windows/m-p/11488#M3732 shows an option to enable symbolic links when running the setup).

May 6 2020, 2:09 PM · Restricted Project
broadwaylamb added a comment to D78200: [libc++] [test] Generate static_test_env on the fly.

If we can solve this problem differently, I'm all for it. One possibility would be to store a tarball of the static environment in the source tree, and then automatically untar it only when on the target system -- this way Windows would never see any symlinks. Thoughts?

May 6 2020, 2:09 PM · Restricted Project
broadwaylamb added a comment to D78200: [libc++] [test] Generate static_test_env on the fly.

I've reverted the commit.

May 6 2020, 1:37 PM · Restricted Project
broadwaylamb committed rG5e3ab8f2299f: Revert "[libc++] [test] Generate static_test_env on the fly" (authored by broadwaylamb).
Revert "[libc++] [test] Generate static_test_env on the fly"
May 6 2020, 1:35 PM
broadwaylamb added a reverting change for rG52cc8bac7780: [libc++] [test] Generate static_test_env on the fly: rG5e3ab8f2299f: Revert "[libc++] [test] Generate static_test_env on the fly".
May 6 2020, 1:35 PM
broadwaylamb added a comment to D78200: [libc++] [test] Generate static_test_env on the fly.

I'm sorry, I've messed up. I first committed this as rG645ad5badbabdeca31de5c98ea8135c5a6e7d710, but then realized that I've committed the previous version of this patch. So I reverted it and recommitted as 52cc8bac7780dbfb90dcc8cfe24696618eeaa06e.

May 6 2020, 5:20 AM · Restricted Project
broadwaylamb updated the diff for D78200: [libc++] [test] Generate static_test_env on the fly.

Update the diff to reflect the committed changes

May 6 2020, 5:20 AM · Restricted Project

May 5 2020

broadwaylamb committed rG67175d8dc53b: [cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake (authored by broadwaylamb).
[cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake
May 5 2020, 3:41 PM
broadwaylamb committed rG52cc8bac7780: [libc++] [test] Generate static_test_env on the fly (authored by broadwaylamb).
[libc++] [test] Generate static_test_env on the fly
May 5 2020, 3:41 PM
broadwaylamb committed rG718a2927ad15: Revert "[libc++] Generate symlinks in static_test_env on the fly" (authored by broadwaylamb).
Revert "[libc++] Generate symlinks in static_test_env on the fly"
May 5 2020, 3:41 PM
broadwaylamb added a reverting change for rG645ad5badbab: [libc++] Generate symlinks in static_test_env on the fly: rG718a2927ad15: Revert "[libc++] Generate symlinks in static_test_env on the fly".
May 5 2020, 3:41 PM
broadwaylamb committed rG645ad5badbab: [libc++] Generate symlinks in static_test_env on the fly (authored by broadwaylamb).
[libc++] Generate symlinks in static_test_env on the fly
May 5 2020, 3:41 PM
broadwaylamb closed D78200: [libc++] [test] Generate static_test_env on the fly.
May 5 2020, 3:40 PM · Restricted Project

May 4 2020

broadwaylamb added inline comments to D78200: [libc++] [test] Generate static_test_env on the fly.
May 4 2020, 10:43 AM · Restricted Project
broadwaylamb added a comment to D78200: [libc++] [test] Generate static_test_env on the fly.

@ldionne @EricWF am I getting it right that this patch is the wrong direction? How the described Windows issue could be resolved otherwise?

May 4 2020, 9:37 AM · Restricted Project

Apr 24 2020

broadwaylamb abandoned D76829: [lit] Introduce setup and teardown routines.
Apr 24 2020, 4:49 PM · Restricted Project
broadwaylamb added a comment to D78200: [libc++] [test] Generate static_test_env on the fly.

ping

Apr 24 2020, 2:05 PM · Restricted Project

Apr 23 2020

broadwaylamb committed rGabe827be9e8c: [libcxx] Add FILE_DEPENDENCIES line to the func.blocks.sh.cpp test (authored by broadwaylamb).
[libcxx] Add FILE_DEPENDENCIES line to the func.blocks.sh.cpp test
Apr 23 2020, 1:36 PM

Apr 22 2020

broadwaylamb committed rG2899103108d3: [TimeProfiler] Emit clock synchronization point (authored by broadwaylamb).
[TimeProfiler] Emit clock synchronization point
Apr 22 2020, 3:16 PM
broadwaylamb closed D78030: [TimeProfiler] Emit clock synchronization point.
Apr 22 2020, 3:15 PM · Restricted Project
broadwaylamb committed rGa5bf02815d8b: [TimeProfiler] Emit real process ID and thread names (authored by broadwaylamb).
[TimeProfiler] Emit real process ID and thread names
Apr 22 2020, 2:42 PM
broadwaylamb closed D78027: [TimeProfiler] Emit real process ID and thread names.
Apr 22 2020, 2:42 PM · Restricted Project
broadwaylamb added a comment to D78030: [TimeProfiler] Emit clock synchronization point.

@russell.gallop thanks! I'll address your comments and commit the change.

Apr 22 2020, 5:22 AM · Restricted Project

Apr 21 2020

broadwaylamb added a comment to D78030: [TimeProfiler] Emit clock synchronization point.

ping

Apr 21 2020, 12:26 PM · Restricted Project
broadwaylamb committed rZORG5d7dae912c7a: Use checks_on_target for libunwind and libc++abi tests on cross-builders (authored by broadwaylamb).
Use checks_on_target for libunwind and libc++abi tests on cross-builders
Apr 21 2020, 2:40 AM
broadwaylamb closed D78483: Use checks_on_target for libunwind and libc++abi tests on cross-builders.

Committed as 5d7dae912c7ac81b6a6ca9827383bd68d1699dbe.

Apr 21 2020, 2:39 AM

Apr 20 2020

broadwaylamb updated the summary of D78483: Use checks_on_target for libunwind and libc++abi tests on cross-builders.
Apr 20 2020, 10:16 AM
broadwaylamb created D78483: Use checks_on_target for libunwind and libc++abi tests on cross-builders.
Apr 20 2020, 4:16 AM

Apr 18 2020

broadwaylamb added inline comments to D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations).
Apr 18 2020, 2:33 PM · Restricted Project
broadwaylamb added inline comments to D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations).
Apr 18 2020, 2:33 PM · Restricted Project