- User Since
- Jan 31 2017, 4:46 PM (321 w, 1 h)
Sat, Mar 25
Fri, Mar 24
Thu, Mar 23
Is there a reason not to just call __llvm_libc::strcmp ?
The two will likely get collapsed by --icf=all anyway, but making it just a tail call to start with seems ideal.
Mon, Mar 20
Fri, Mar 17
Thu, Mar 9
Wed, Mar 8
Mon, Mar 6
Mon, Feb 27
Needs a test case.
Feb 14 2023
This indicates a lack of testing coverage for the runtime. We should add runtime tests that use all the allocator signatures explicitly.
Feb 8 2023
Feb 6 2023
Feb 5 2023
rebased, added clang driver test vs -fsanitize=shadow-call-stack
cleanups per review
Feb 2 2023
LGTM pending acceptance of the spec change.
lgtm but we should probably wait for Fangrui's review too.
Jan 18 2023
The lack of these registers is a regression in LLVM's assembler compared to the GNU assembler.
Assembler syntax exists for humans who write assembly, not just for compilers.
Compilers do not emit CFI that refers to these registers.
Jan 16 2023
Jan 4 2023
Jan 3 2023
I don't think we want this in the generic compiler behavior. It would only make sense if the toolchain runtimes have extra versions, and I don't think we want that many extra versions.
It may be worthwhile to change the asan multilib builds to enable ubsan checks too, but I don't think we want to support two separate asan flavors in the driver.
Dec 9 2022
I thought we agreed that the desirable semantics to keep things simple is that if markup is requested then markup is always printed, period. It shouldn't have anything to do with whether llvm-symbolizer works.
Dec 7 2022
Nov 23 2022
This broke some existing cases using std::basic_string_view<std::byte> and the like.
Nov 8 2022
Oct 24 2022
Oct 18 2022
Oct 17 2022
I'm quite sure that we will always want a means to select the original Itanium ABI. It's also quite likely that there will be future innovations in the Fuchsia C++ ABI and we'll go through migration periods of supporting additional variants and changing the default for Fuchsia targets.
It's certainly correct that we envision each target having an explicit list of viable C++ ABIs to select from.
The C++ ABI is not part of the Fuchsia system ABI, nor what we call the "Fuchsia compiler ABI". Different users of C++ are free to use whatever C++ ABI they like. Only the backend ABI independent of language-specific issues is necessary to interoperate with other code on Fuchsia.
Oct 11 2022
I had imagined making lsan always do this since there's a specific lsan-related rationale for it that applies to everybody.
I'm not clear on how cmake structures things and whether sanitizer_common would have to do it unconditionally since it's used by lsan code.
Oct 6 2022
Sep 20 2022
Sep 16 2022
We haven't quite worked out this signature on the Fuchsia side yet.
Also, this makes the dl_iterate_phdr sequence in InitLoadedGlobals redundant so we should remove that for the Fuchsia configurations.
Sep 14 2022
For the general case, not only glibc but probably all preexisting system libraries that don't have special hwasan support built in, I don't think you can rely on anything to hook into here. If you really needed to, *maybe* you could have dlopen and dlclose interceptors, but that seems really unlikely to go well. Bottom line, you probably have to find a way on those systems to have vanilla init and fini hook behavior (init_array, preinit_array, fini_array, etc.) be sufficient. It's challenging because you really need to come in before any code that could access a global is run, and with a DSO overriding a symbol in one of its DT_NEEDED DSOs the order of init hooks getting called could make it impossible to be in the right place.
Aug 30 2022
Aug 26 2022
Aug 23 2022
You might add some comments in CGVTables.cpp about why this is done and what the alternatives might be in the future.
Aug 22 2022
Jul 28 2022
Jul 27 2022
Jul 13 2022
LGTM, I didn't realize Phabricator considered me to be blocking.
Jul 11 2022
lgtm but be sure that Fuchsia target users get clear release-notes warning about the change.
Jul 7 2022
Jul 6 2022
I don't see a problem having the compiler-rt and compiler changes in the same commit. Seems desirable in this case, actually.
Jun 28 2022
lgtm since the compatibility window for platform versions that didn't have the new entry point has already passed by now.
Jun 15 2022
Landed in a27b9139ab1bbdc93afaf240de2c2b9e45092884
Jun 1 2022
This needs a stub GetRSS for Fuchsia, at least.
Since there's no way to get a useful value for this on Fuchsia as yet, it would be preferable to conditionalize the machinery so it isn't doing no-op work.
May 27 2022
Apr 20 2022