Page MenuHomePhabricator

mcgrathr (Roland McGrath)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2017, 4:46 PM (277 w, 3 d)

Recent Activity

Yesterday

mcgrathr committed rGa27b9139ab1b: [scudo] Clean up Zircon header file uses (authored by mcgrathr).
[scudo] Clean up Zircon header file uses
Fri, May 27, 9:44 PM · Restricted Project, Restricted Project
mcgrathr accepted D126499: [scudo] Ensure pointer is not null.
Fri, May 27, 9:38 PM · Restricted Project
mcgrathr requested review of D126582: [scudo] Clean up Zircon header file uses.
Fri, May 27, 6:33 PM · Restricted Project, Restricted Project

Apr 20 2022

mcgrathr accepted D124136: [fuchsia] Don't include duplicate profiling symbols for Fuchsia.

Lgtm

Apr 20 2022, 5:53 PM · Restricted Project, Restricted Project

Apr 19 2022

mcgrathr accepted D119996: [safestack] Support safestack in stack size diagnostics.
Apr 19 2022, 4:20 PM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

mcgrathr added inline comments to D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array.
Mar 29 2022, 5:39 PM · Restricted Project, Restricted Project
mcgrathr committed rGfd7ec90abd90: [lsan] On Fuchsia, don't use atexit hook for leak checks (authored by mcgrathr).
[lsan] On Fuchsia, don't use atexit hook for leak checks
Mar 29 2022, 5:14 PM · Restricted Project, Restricted Project
mcgrathr closed D88248: [lsan] On Fuchsia, don't use atexit hook for leak checks.
Mar 29 2022, 5:14 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D88248: [lsan] On Fuchsia, don't use atexit hook for leak checks.

rebased

Mar 29 2022, 12:42 PM · Restricted Project, Restricted Project

Mar 28 2022

mcgrathr reopened D122518: [scudo] Use template specialization on Quarantine to avoid zero-length array.
Mar 28 2022, 6:43 PM · Restricted Project, Restricted Project
mcgrathr committed rG1a963d3278c2: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets (authored by mcgrathr).
[Driver] Make -moutline-atomics default for aarch64-fuchsia targets
Mar 28 2022, 4:52 PM · Restricted Project, Restricted Project
mcgrathr closed D122613: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets.
Mar 28 2022, 4:52 PM · Restricted Project, Restricted Project
mcgrathr requested review of D122613: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets.
Mar 28 2022, 2:06 PM · Restricted Project, Restricted Project
mcgrathr committed rG4e731abc5568: [compiler-rt][AArch64] Initialize __aarch64_have_lse_atomics for Fuchsia (authored by mcgrathr).
[compiler-rt][AArch64] Initialize __aarch64_have_lse_atomics for Fuchsia
Mar 28 2022, 11:49 AM · Restricted Project, Restricted Project
mcgrathr closed D118839: [compiler-rt][AArch64] Initialize __aarch64_have_lse_atomics for Fuchsia.
Mar 28 2022, 11:49 AM · Restricted Project, Restricted Project
mcgrathr committed rG39294589bf02: sanitizer_common: Remove Fuchsia support for reading flags from files (authored by mcgrathr).
sanitizer_common: Remove Fuchsia support for reading flags from files
Mar 28 2022, 10:54 AM · Restricted Project, Restricted Project
mcgrathr closed D122500: sanitizer_common: Remove Fuchsia support for reading flags from files.
Mar 28 2022, 10:54 AM · Restricted Project, Restricted Project

Mar 25 2022

mcgrathr requested review of D122500: sanitizer_common: Remove Fuchsia support for reading flags from files.
Mar 25 2022, 12:35 PM · Restricted Project, Restricted Project

Mar 4 2022

mcgrathr added inline comments to D119996: [safestack] Support safestack in stack size diagnostics.
Mar 4 2022, 6:54 PM · Restricted Project, Restricted Project, Restricted Project

Feb 18 2022

mcgrathr accepted D119962: [ifs] Add --exclude flag.
Feb 18 2022, 11:11 AM · Restricted Project

Feb 17 2022

mcgrathr added a comment to D119962: [ifs] Add --exclude flag.

Usually when you have these kinds of things they're called include and exclude.
I don't think we have any known use cases for include, just for exclude so it would be sufficient to start with just that feature.

Feb 17 2022, 6:15 PM · Restricted Project

Feb 16 2022

mcgrathr accepted D119907: [ifs] Add --strip-needed flag.

LGTM but Haowei should give the final say.

Feb 16 2022, 10:05 AM · Restricted Project

Feb 11 2022

mcgrathr added inline comments to D116769: [ifs] Allow llvm-ifs to generate text stub from elf stub.
Feb 11 2022, 3:12 PM · Restricted Project
mcgrathr accepted D116769: [ifs] Allow llvm-ifs to generate text stub from elf stub.

lgtm except for possible susceptibility to invalid DT_STRSZ values.
Perhaps there should be a test case for a corrupted PT_DYNAMIC region.

Feb 11 2022, 1:54 PM · Restricted Project

Feb 7 2022

mcgrathr added inline comments to D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check.
Feb 7 2022, 4:13 PM · Restricted Project, Restricted Project
mcgrathr added inline comments to D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check.
Feb 7 2022, 4:10 PM · Restricted Project, Restricted Project

Feb 2 2022

mcgrathr requested review of D118839: [compiler-rt][AArch64] Initialize __aarch64_have_lse_atomics for Fuchsia.
Feb 2 2022, 12:22 PM · Restricted Project, Restricted Project

Jan 26 2022

mcgrathr accepted D118306: [CMake][Fuchsia] Drop 32-bit ios runtimes.

lgtm

Jan 26 2022, 6:52 PM · Restricted Project
mcgrathr committed rG1510668fb007: [asan] Add missing #include of sanitizer_platform.h (authored by mcgrathr).
[asan] Add missing #include of sanitizer_platform.h
Jan 26 2022, 6:19 PM
mcgrathr closed D118296: [asan] Add missing #include of sanitizer_platform.h.
Jan 26 2022, 6:19 PM · Restricted Project
mcgrathr added inline comments to D118174: [Symbolize][DebugInfoD] Try looking up failed paths as Build IDs..
Jan 26 2022, 5:16 PM · Restricted Project
mcgrathr requested review of D118296: [asan] Add missing #include of sanitizer_platform.h.
Jan 26 2022, 4:43 PM · Restricted Project

Jan 25 2022

mcgrathr added a comment to D118099: [libc][NFC] Fix GCC inline asm compilation problems + workaround clang assertion.

I think in fact the proper thing for this case is to just use a single operand "+t" to directly indicate that the one operand is both input and output. I'm not sure that "=&t" and "0" will behave any different, but this seems to be exactly what "+" is for.

Jan 25 2022, 2:42 PM · Restricted Project
mcgrathr added a comment to D118099: [libc][NFC] Fix GCC inline asm compilation problems + workaround clang assertion.

That a compiler unnecessarily requires the "cc" clobber specification is OK but GCC requiring the input operand to have the "f" modifier instead of the "t" modifier seems not so correct. Should we really care about the GCC problem now?

Ok I've committed without the changes to sqrtl

Jan 25 2022, 2:19 PM · Restricted Project

Jan 24 2022

mcgrathr added a comment to D117933: [ELF] Don't consider directories of the same name as libraries.

Currently a deplib name (${name}) indicates either the literal ${name} or the -l style lib${name}.{a,so}.
We have a conflict if ${name} is foo and there is a directory named foo.

What if we do

if (name.endswith(".a") || name.endswith(".so"))
  findFromSearchPaths
else
  searchLibraryBaseName

?

That should avoid the conflict, too. A directory is unlikely named .so or .a.

Jan 24 2022, 1:47 PM · Restricted Project

Jan 21 2022

mcgrathr accepted D117933: [ELF] Don't consider directories of the same name as libraries.

lgtm

Jan 21 2022, 4:06 PM · Restricted Project

Jan 18 2022

mcgrathr added a comment to D116179: [InstrProf][NFC] Do not assume size of counter type.

Please understand that InstrProfData.inc is now a public installed header file in the compiler-rt installation, at <profile/InstrProfData.inc>. So *any* changes to this file have a quite high standard of compatibility concern.

Jan 18 2022, 5:51 PM · Restricted Project, Restricted Project

Jan 14 2022

mcgrathr accepted D117359: [scudo] Make Scudo compile for C++20.
Jan 14 2022, 2:27 PM · Restricted Project

Jan 11 2022

mcgrathr added inline comments to D116769: [ifs] Allow llvm-ifs to generate text stub from elf stub.
Jan 11 2022, 5:23 PM · Restricted Project
mcgrathr accepted D117058: [ifs] Added missing DT_STRSZ to the .dynamic section.

lgtm

Jan 11 2022, 5:20 PM · Restricted Project

Jan 10 2022

mcgrathr committed rGce167c6fb2ae: [libcxx] Use Fuchsia-native monotonic clock for std::chrono::steady_clock (authored by mcgrathr).
[libcxx] Use Fuchsia-native monotonic clock for std::chrono::steady_clock
Jan 10 2022, 1:15 PM
mcgrathr closed D116606: [libcxx] Use Fuchsia-native monotonic clock for std::chrono::steady_clock.
Jan 10 2022, 1:14 PM · Restricted Project
mcgrathr added a comment to D116606: [libcxx] Use Fuchsia-native monotonic clock for std::chrono::steady_clock.

Ping. This is very similar to the other change I landed recently. It needs approval from a libc++ maintainer.
Thanks.

Jan 10 2022, 9:36 AM · Restricted Project

Jan 7 2022

mcgrathr added inline comments to D116769: [ifs] Allow llvm-ifs to generate text stub from elf stub.
Jan 7 2022, 9:19 PM · Restricted Project
mcgrathr added a comment to D116769: [ifs] Allow llvm-ifs to generate text stub from elf stub.

LGTM modulo the fallback behaviors as mentioned below. But I'll leave the approval to those who have done the review for this specific codebase more generally, since I'm not sure on all the points of LLVM style or what library features are available or best to use.

Jan 7 2022, 4:39 PM · Restricted Project

Jan 6 2022

mcgrathr added inline comments to D116769: [ifs] Allow llvm-ifs to generate text stub from elf stub.
Jan 6 2022, 5:57 PM · Restricted Project

Jan 4 2022

mcgrathr added inline comments to D116606: [libcxx] Use Fuchsia-native monotonic clock for std::chrono::steady_clock.
Jan 4 2022, 11:07 AM · Restricted Project
mcgrathr requested review of D116606: [libcxx] Use Fuchsia-native monotonic clock for std::chrono::steady_clock.
Jan 4 2022, 10:26 AM · Restricted Project
mcgrathr committed rG3064dd8ccffc: [libcxx] Use Fuchsia-native CPRNG for std::random_device (authored by mcgrathr).
[libcxx] Use Fuchsia-native CPRNG for std::random_device
Jan 4 2022, 10:24 AM
mcgrathr closed D116498: [libcxx] Use Fuchsia-native CPRNG for std::random_device.
Jan 4 2022, 10:24 AM · Restricted Project
mcgrathr added inline comments to D116498: [libcxx] Use Fuchsia-native CPRNG for std::random_device.
Jan 4 2022, 9:06 AM · Restricted Project

Jan 2 2022

mcgrathr requested review of D116498: [libcxx] Use Fuchsia-native CPRNG for std::random_device.
Jan 2 2022, 11:54 AM · Restricted Project

Dec 28 2021

mcgrathr raised a concern with rG21dbfd430021: [ELF] --gc-sections: Change startwith(".init") (and ".fini") to exact match.

Just the fact that any follow-up changes were required is clear testament to the fact that this was never a change that was appropriate to commit without community review and approval as all LLVM changes require. Regardless of the technical details, nontrivial changes, especially ones affecting the user-visible semantics, simply should not be committed without proper review. Resistance to reverting unreviewed changes is simply hostile to the community's established standards and code of conduct and frankly does not merit further technical discussion. The appropriate forum for technical discussion is in review of changes such as these *before* they are committed. The appropriate action right now is to revert all the changes that were not properly reviewed and changed behavior in ways that reviewers have not yet had the opportunity to discuss. Once the damage done has been recovered, then it's appropriate to propose the changes you wanted made and allow proper review and discussion about the semantics being changed.

Dec 28 2021, 3:24 PM

Dec 3 2021

mcgrathr added a comment to D115024: [ifs] Patch llvm-ifs to allow output multiple types of stub file at the same time.

This feature seems like a good addition. I'm wondering about the interactions with other switches and if it might make sense to rearchitect some of the CLI API here for the more arcane corners. Maybe it's already orthogonal enough, but I'm not sure. I'm thinking in particular about the various --strip-* options. Perhaps it's the case that all such variations apply only to text IFS output? I'm also wondering if there might be use cases for multiple different kinds of IFS output (i.e. different sets of stripping / arch options). Come to think of it, we could even have uses for multiple ELF stub outputs from the same IFS input with different switches (e.g. arch). So perhaps it makes sense to go in a direction where each output file is separately described with both its format (IFS vs ELF) and its format options (stripping, arch, etc), and there can be any number of such output files in whatever combination. I'm not sure exactly what a CLI syntax for that would look like. Another possibility that might fit well for build system integration is to accept a complex output specification in JSON either as a command-line switch value or from a file.

Dec 3 2021, 9:24 AM · Restricted Project

Nov 30 2021

mcgrathr accepted D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia.
Nov 30 2021, 10:52 AM · Restricted Project, Restricted Project
mcgrathr accepted D114115: [Driver] Support for compressed debug info on Fuchsia.

lgtm, but we should be sure to advise users that their debugging tools may need build adjustments to ensure they support the compressed formats.

Nov 30 2021, 10:47 AM · Restricted Project, Restricted Project
mcgrathr accepted D44605: [Driver] Default to DWARF 5 for Fuchsia.

lgtm, but we should be sure to advise users who may need to use -gdwarf-4 explicitly if their debugging tools become unhappy.

Nov 30 2021, 10:45 AM · Restricted Project
mcgrathr updated the summary of D114383: [InstrProfiling] Add -runtime-counter-relocation=function mode.
Nov 30 2021, 10:43 AM · Restricted Project, Restricted Project
mcgrathr updated the diff for D114383: [InstrProfiling] Add -runtime-counter-relocation=function mode.

renamed callback

Nov 30 2021, 10:43 AM · Restricted Project, Restricted Project
mcgrathr added a comment to D114383: [InstrProfiling] Add -runtime-counter-relocation=function mode.

An alternative I thought of would be to always use a call and generate a (weak) implementation of __llvm_profile_counter_dynamic_bias inside each translation unit. The default generated function would simply return the variable. I'm not sure what the impact on performance would be though.

Nov 30 2021, 10:43 AM · Restricted Project, Restricted Project

Nov 29 2021

mcgrathr added inline comments to D40319: [libcxx] Support getentropy as a source of randomness for std::random_device.
Nov 29 2021, 11:14 AM

Nov 22 2021

mcgrathr updated the diff for D114383: [InstrProfiling] Add -runtime-counter-relocation=function mode.

second copy of InstrProfData.inc

Nov 22 2021, 6:07 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D114383: [InstrProfiling] Add -runtime-counter-relocation=function mode.

Use a DenseMap rather than instruction name to match bias load.

Nov 22 2021, 1:09 PM · Restricted Project, Restricted Project
mcgrathr updated the summary of D114383: [InstrProfiling] Add -runtime-counter-relocation=function mode.
Nov 22 2021, 11:13 AM · Restricted Project, Restricted Project
mcgrathr requested review of D114383: [InstrProfiling] Add -runtime-counter-relocation=function mode.
Nov 22 2021, 10:59 AM · Restricted Project, Restricted Project

Nov 21 2021

mcgrathr committed rGb72b56016a6b: NFC: clang-format lib/Transforms/Instrumentation/InstrProfiling.cpp (authored by mcgrathr).
NFC: clang-format lib/Transforms/Instrumentation/InstrProfiling.cpp
Nov 21 2021, 6:16 PM
mcgrathr closed D114343: NFC: clang-format lib/Transforms/Instrumentation/InstrProfiling.cpp.
Nov 21 2021, 6:16 PM · Restricted Project
mcgrathr requested review of D114343: NFC: clang-format lib/Transforms/Instrumentation/InstrProfiling.cpp.
Nov 21 2021, 6:15 PM · Restricted Project

Nov 16 2021

mcgrathr added inline comments to D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia.
Nov 16 2021, 1:19 PM · Restricted Project, Restricted Project

Nov 10 2021

mcgrathr committed rGff11f0aa5de1: [Clang] Pass -z rel to linker for Fuchsia (authored by mcgrathr).
[Clang] Pass -z rel to linker for Fuchsia
Nov 10 2021, 1:31 PM
mcgrathr closed D113136: [Clang] Pass -z rel to linker for Fuchsia.
Nov 10 2021, 1:31 PM · Restricted Project
mcgrathr added a comment to D113136: [Clang] Pass -z rel to linker for Fuchsia.

Reordered the switches.

Nov 10 2021, 1:02 PM · Restricted Project
mcgrathr updated the diff for D113136: [Clang] Pass -z rel to linker for Fuchsia.

reordered switches

Nov 10 2021, 1:02 PM · Restricted Project
mcgrathr updated the diff for D113136: [Clang] Pass -z rel to linker for Fuchsia.

rebased

Nov 10 2021, 11:25 AM · Restricted Project

Nov 3 2021

mcgrathr requested review of D113136: [Clang] Pass -z rel to linker for Fuchsia.
Nov 3 2021, 12:10 PM · Restricted Project

Sep 23 2021

mcgrathr added inline comments to D110365: [llvm][profile] Add padding after binary IDs.
Sep 23 2021, 6:37 PM · Restricted Project, Restricted Project
mcgrathr added inline comments to D110365: [llvm][profile] Add padding after binary IDs.
Sep 23 2021, 3:23 PM · Restricted Project, Restricted Project
mcgrathr committed rG80b92db02c5a: [profile][fuchsia] Don't include extra NUL in log messages (authored by mcgrathr).
[profile][fuchsia] Don't include extra NUL in log messages
Sep 23 2021, 3:17 PM
mcgrathr closed D110361: [profile][fuchsia] Don't include extra NUL in log messages.
Sep 23 2021, 3:16 PM · Restricted Project
mcgrathr requested review of D110361: [profile][fuchsia] Don't include extra NUL in log messages.
Sep 23 2021, 1:37 PM · Restricted Project

Aug 27 2021

mcgrathr committed rG225eb8a22d41: [libc][NFC] Fix onre more -Wconversion warning in strtoul test code. (authored by mcgrathr).
[libc][NFC] Fix onre more -Wconversion warning in strtoul test code.
Aug 27 2021, 2:13 PM
mcgrathr closed D108845: [libc][NFC] Fix onre more -Wconversion warning in strtoul test code..
Aug 27 2021, 2:13 PM · Restricted Project
mcgrathr requested review of D108845: [libc][NFC] Fix onre more -Wconversion warning in strtoul test code..
Aug 27 2021, 2:12 PM · Restricted Project
mcgrathr committed rG4e1a164d7bd5: [libc] Fix various -Wconversion warnings in strto*l test code. (authored by mcgrathr).
[libc] Fix various -Wconversion warnings in strto*l test code.
Aug 27 2021, 2:04 PM
mcgrathr closed D108800: [libc] Fix various -Wconversion warnings in strto*l test code..
Aug 27 2021, 2:04 PM · Restricted Project
mcgrathr updated the diff for D108800: [libc] Fix various -Wconversion warnings in strto*l test code..

add more casts

Aug 27 2021, 11:51 AM · Restricted Project

Aug 26 2021

mcgrathr requested review of D108800: [libc] Fix various -Wconversion warnings in strto*l test code..
Aug 26 2021, 7:06 PM · Restricted Project
mcgrathr added a comment to D108747: [llvm][ProfileData] Add a warning to indicate potentially corrupted data.

The intent is to sanity-check for garbage header fields. The uncompressed size field is one that you can only warn about heuristically like this I guess. But you can do a definitive test on the CompressedSize field to ensure that it isn't larger than the actual size of the data available. There's no need to even worry about whether UncompressedSize is valid if CompressedSize is clearly invalid.

Aug 26 2021, 9:48 AM · Restricted Project

Aug 25 2021

mcgrathr accepted D107201: [libfuzzer] Use crash stack for fuchsia.
Aug 25 2021, 3:03 PM · Restricted Project
mcgrathr accepted D107023: [libfuzzer] Handle more than one exception in Fuchsia..

lgtm

Aug 25 2021, 2:57 PM · Restricted Project

Aug 23 2021

mcgrathr added inline comments to D108428: [ifs] Add option to hide undefined symbols.
Aug 23 2021, 1:38 PM · Restricted Project

Aug 12 2021

mcgrathr accepted D108000: [IFS] Fix copy constructor warnings in IFSStub.cpp.
Aug 12 2021, 6:45 PM · Restricted Project

Aug 6 2021

mcgrathr committed rG5a2a17969583: [profile][Fuchsia] Add missing system header #include (authored by mcgrathr).
[profile][Fuchsia] Add missing system header #include
Aug 6 2021, 6:00 PM
mcgrathr closed D107616: [profile][Fuchsia] Add missing system header #include.
Aug 6 2021, 5:59 PM · Restricted Project

Aug 5 2021

mcgrathr requested review of D107616: [profile][Fuchsia] Add missing system header #include.
Aug 5 2021, 7:53 PM · Restricted Project

Jul 27 2021

mcgrathr accepted D106725: [libFuzzer] Fix CFI Directives for fuchsia.

lgtm

Jul 27 2021, 4:38 PM · Restricted Project
mcgrathr accepted D106835: [asan][fuchsia] Implement PlatformUnpoisonStacks.

lgtm

Jul 27 2021, 4:34 PM · Restricted Project
mcgrathr accepted D105735: [compiler-rt][hwasan][Fuchsia] Do not emit FindDynamicShadowStart for Fuchsia.

lgtm

Jul 27 2021, 1:15 PM · Restricted Project

Jul 23 2021

mcgrathr accepted D106690: [GWP-ASan] Add version header..

lgtm

Jul 23 2021, 1:37 PM · Restricted Project

Jul 20 2021

mcgrathr accepted D106086: [libc] Add a new test matcher for tests raising floating point exceptions..

lgtm

Jul 20 2021, 10:23 AM · Restricted Project