Page MenuHomePhabricator

mcgrathr (Roland McGrath)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2017, 4:46 PM (321 w, 1 h)

Recent Activity

Sat, Mar 25

mcgrathr committed rG69a0924fac6f: [libc] Add missing cast in fputil sqrt code (authored by mcgrathr).
[libc] Add missing cast in fputil sqrt code
Sat, Mar 25, 4:24 PM · Restricted Project, Restricted Project
mcgrathr closed D146886: [libc] Add missing cast in fputil sqrt code.
Sat, Mar 25, 4:24 PM · Restricted Project, Restricted Project
mcgrathr requested review of D146886: [libc] Add missing cast in fputil sqrt code.
Sat, Mar 25, 2:31 PM · Restricted Project, Restricted Project
mcgrathr committed rGd30de9844e1a: [libc] Define LLVM_LIBC_FUNCTION with a layer of macro expansion (authored by mcgrathr).
[libc] Define LLVM_LIBC_FUNCTION with a layer of macro expansion
Sat, Mar 25, 11:32 AM · Restricted Project, Restricted Project
mcgrathr closed D146863: [libc] Define LLVM_LIBC_FUNCTION with a layer of macro expansion.
Sat, Mar 25, 11:31 AM · Restricted Project, Restricted Project

Fri, Mar 24

mcgrathr committed rG0be1fbac2a77: [libc] Remove unused aarch64 sqrt and sqrtf implementations (authored by mcgrathr).
[libc] Remove unused aarch64 sqrt and sqrtf implementations
Fri, Mar 24, 9:16 PM · Restricted Project, Restricted Project
mcgrathr closed D146865: [libc] Remove unused aarch64 sqrt and sqrtf implementations.
Fri, Mar 24, 9:15 PM · Restricted Project, Restricted Project
mcgrathr requested review of D146865: [libc] Remove unused aarch64 sqrt and sqrtf implementations.
Fri, Mar 24, 9:00 PM · Restricted Project, Restricted Project
mcgrathr requested review of D146863: [libc] Define LLVM_LIBC_FUNCTION with a layer of macro expansion.
Fri, Mar 24, 8:31 PM · Restricted Project, Restricted Project

Thu, Mar 23

mcgrathr added a comment to D146660: [libc][NFC] move strcoll to strcmp template.

Is there a reason not to just call __llvm_libc::strcmp ?
The two will likely get collapsed by --icf=all anyway, but making it just a tail call to start with seems ideal.

Thu, Mar 23, 9:54 AM · Restricted Project, Restricted Project

Mon, Mar 20

mcgrathr committed rG4e298c32d558: [libc] Make string tests compatible with the Fuchsia build (authored by mcgrathr).
[libc] Make string tests compatible with the Fuchsia build
Mon, Mar 20, 10:23 AM · Restricted Project, Restricted Project
mcgrathr closed D146343: [libc] Make string tests compatible with the Fuchsia build.
Mon, Mar 20, 10:23 AM · Restricted Project, Restricted Project

Fri, Mar 17

mcgrathr requested review of D146343: [libc] Make string tests compatible with the Fuchsia build.
Fri, Mar 17, 6:00 PM · Restricted Project, Restricted Project

Thu, Mar 9

mcgrathr added inline comments to D145594: [libc] Add fenv_t and signal macros in riscv.
Thu, Mar 9, 11:01 AM · Restricted Project, Restricted Project

Wed, Mar 8

mcgrathr accepted D145635: [ELF] Make --discard-locals default on riscv.
Wed, Mar 8, 6:24 PM · Restricted Project
mcgrathr added inline comments to D145205: [codegen][riscv] Emit CFI directives when using shadow call stack.
Wed, Mar 8, 6:21 PM · Restricted Project, Restricted Project
mcgrathr added inline comments to D145635: [ELF] Make --discard-locals default on riscv.
Wed, Mar 8, 6:17 PM · Restricted Project
mcgrathr added a comment to D145459: [hwasan] Add non-exception variant of operator delete[] for hwasan.

Hmm, so test in compiler-rt/test/hwasan/TestCases/new-test.cpp does exercise this function via operator delete[](alloc, size, align);, but since we provide weak definitions for these symbols, even if the hwasan implementation isn't provided, then it'll default to the one provided by stdlib_new_delete.cpp.o in libc++. Not sure how easy it would be to tell the testing infrastructure not to use some specific symbols from libc++.

Wed, Mar 8, 1:38 PM · Restricted Project, Restricted Project

Mon, Mar 6

mcgrathr accepted D145205: [codegen][riscv] Emit CFI directives when using shadow call stack.
Mon, Mar 6, 11:32 AM · Restricted Project, Restricted Project

Mon, Feb 27

mcgrathr accepted D144900: [X86] Add DwarfRegNums for segment registers.

lgtm

Mon, Feb 27, 1:55 PM · Restricted Project, Restricted Project
mcgrathr added inline comments to D144900: [X86] Add DwarfRegNums for segment registers.
Mon, Feb 27, 11:33 AM · Restricted Project, Restricted Project
mcgrathr added a comment to D144900: [X86] Add DwarfRegNums for segment registers.

Needs a test case.

Mon, Feb 27, 11:29 AM · Restricted Project, Restricted Project

Feb 14 2023

mcgrathr added a comment to D144030: [hwasan] Add definitions for missing operator delete functions .

This indicates a lack of testing coverage for the runtime. We should add runtime tests that use all the allocator signatures explicitly.

Feb 14 2023, 10:29 AM · Restricted Project, Restricted Project
mcgrathr accepted D144030: [hwasan] Add definitions for missing operator delete functions .

lgtm

Feb 14 2023, 10:21 AM · Restricted Project, Restricted Project

Feb 8 2023

mcgrathr requested review of D143620: [RISCV] Use OS-specific SafeStack ABI for Fuchsia.
Feb 8 2023, 6:08 PM · Restricted Project, Restricted Project

Feb 6 2023

mcgrathr committed rG2406f3bea545: [RISCV] Clean up stack-protector-target test (authored by mcgrathr).
[RISCV] Clean up stack-protector-target test
Feb 6 2023, 4:43 PM · Restricted Project, Restricted Project
mcgrathr closed D143360: [RISCV] Clean up stack-protector-target test.
Feb 6 2023, 4:43 PM · Restricted Project, Restricted Project

Feb 5 2023

mcgrathr added a comment to D143353: [RISCV] Use OS-specific stack-guard ABI for Fuchsia.

Latest feedback was not addressed when committing, and you gave hardly any time for anyone else who regularly works on or reviews changes for the RISC-V backend to comment

Feb 5 2023, 7:10 PM · Restricted Project, Restricted Project
mcgrathr requested review of D143360: [RISCV] Clean up stack-protector-target test.
Feb 5 2023, 7:08 PM · Restricted Project, Restricted Project
mcgrathr committed rGf08d86fc7f44: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia (authored by mcgrathr).
[RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia
Feb 5 2023, 6:59 PM · Restricted Project, Restricted Project
mcgrathr closed D143357: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia.
Feb 5 2023, 6:59 PM · Restricted Project, Restricted Project
mcgrathr committed rG03ff435da540: [RISCV] Default to -ffixed-x18 for Fuchsia (authored by mcgrathr).
[RISCV] Default to -ffixed-x18 for Fuchsia
Feb 5 2023, 6:51 PM · Restricted Project, Restricted Project, Restricted Project
mcgrathr closed D143355: [RISCV] Default to -ffixed-x18 for Fuchsia.
Feb 5 2023, 6:51 PM · Restricted Project, Restricted Project, Restricted Project
mcgrathr committed rG34b21e817f19: [RISCV] Use OS-specific stack-guard ABI for Fuchsia (authored by mcgrathr).
[RISCV] Use OS-specific stack-guard ABI for Fuchsia
Feb 5 2023, 6:46 PM · Restricted Project, Restricted Project
mcgrathr closed D143353: [RISCV] Use OS-specific stack-guard ABI for Fuchsia.
Feb 5 2023, 6:46 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D143357: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia.

remove TODO

Feb 5 2023, 6:40 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D143355: [RISCV] Default to -ffixed-x18 for Fuchsia.

rebased, added clang driver test vs -fsanitize=shadow-call-stack

Feb 5 2023, 6:38 PM · Restricted Project, Restricted Project, Restricted Project
mcgrathr updated the diff for D143353: [RISCV] Use OS-specific stack-guard ABI for Fuchsia.

rebase

Feb 5 2023, 6:37 PM · Restricted Project, Restricted Project
mcgrathr updated the diff for D143355: [RISCV] Default to -ffixed-x18 for Fuchsia.

rebased

Feb 5 2023, 6:13 PM · Restricted Project, Restricted Project, Restricted Project
mcgrathr added inline comments to D143355: [RISCV] Default to -ffixed-x18 for Fuchsia.
Feb 5 2023, 6:13 PM · Restricted Project, Restricted Project, Restricted Project
mcgrathr updated the diff for D143353: [RISCV] Use OS-specific stack-guard ABI for Fuchsia.

cleanups per review

Feb 5 2023, 6:11 PM · Restricted Project, Restricted Project
mcgrathr added inline comments to D143353: [RISCV] Use OS-specific stack-guard ABI for Fuchsia.
Feb 5 2023, 6:11 PM · Restricted Project, Restricted Project
mcgrathr requested review of D143357: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia.
Feb 5 2023, 3:21 PM · Restricted Project, Restricted Project
mcgrathr requested review of D143355: [RISCV] Default to -ffixed-x18 for Fuchsia.
Feb 5 2023, 3:19 PM · Restricted Project, Restricted Project, Restricted Project
mcgrathr requested review of D143353: [RISCV] Use OS-specific stack-guard ABI for Fuchsia.
Feb 5 2023, 3:14 PM · Restricted Project, Restricted Project

Feb 2 2023

mcgrathr accepted D143226: [MC][CodeGen] Define R_RISCV_PLT32 and lower dso_local_equivalent to it.

LGTM pending acceptance of the spec change.

Feb 2 2023, 5:21 PM · Restricted Project, Restricted Project
mcgrathr accepted D143115: [lld][RISCV] Introduce handling for R_RISCV_PLT32 relocation.

lgtm but we should probably wait for Fangrui's review too.

Feb 2 2023, 9:31 AM · Restricted Project, Restricted Project

Jan 18 2023

mcgrathr added a comment to D141879: [X86] Add register definitions for cfi directives.

The lack of these registers is a regression in LLVM's assembler compared to the GNU assembler.

Jan 18 2023, 11:49 AM · Restricted Project, Restricted Project
mcgrathr added a comment to D141879: [X86] Add register definitions for cfi directives.

Assembler syntax exists for humans who write assembly, not just for compilers.
Compilers do not emit CFI that refers to these registers.

Jan 18 2023, 11:49 AM · Restricted Project, Restricted Project

Jan 16 2023

mcgrathr added inline comments to D141879: [X86] Add register definitions for cfi directives.
Jan 16 2023, 5:04 PM · Restricted Project, Restricted Project

Jan 4 2023

mcgrathr committed rG9bb2ec2e23ba: llvm-objdump: Fix --build-id documentation string (authored by mcgrathr).
llvm-objdump: Fix --build-id documentation string
Jan 4 2023, 11:55 AM · Restricted Project, Restricted Project
mcgrathr closed D141009: llvm-objdump: Fix --build-id documentation string.
Jan 4 2023, 11:55 AM · Restricted Project, Restricted Project
mcgrathr added a reviewer for D141009: llvm-objdump: Fix --build-id documentation string: mysterymath.
Jan 4 2023, 11:53 AM · Restricted Project, Restricted Project
mcgrathr requested review of D141009: llvm-objdump: Fix --build-id documentation string.
Jan 4 2023, 11:41 AM · Restricted Project, Restricted Project

Jan 3 2023

mcgrathr added a comment to D140857: Fix Fuchsia dyld in asan-ubsan variant.

I don't think we want this in the generic compiler behavior. It would only make sense if the toolchain runtimes have extra versions, and I don't think we want that many extra versions.
It may be worthwhile to change the asan multilib builds to enable ubsan checks too, but I don't think we want to support two separate asan flavors in the driver.

Jan 3 2023, 11:44 AM · Restricted Project, Restricted Project

Dec 9 2022

mcgrathr added a comment to D139750: Optionally print symbolizer markup backtraces..

I thought we agreed that the desirable semantics to keep things simple is that if markup is requested then markup is always printed, period. It shouldn't have anything to do with whether llvm-symbolizer works.

Dec 9 2022, 5:07 PM · Restricted Project, Restricted Project

Dec 7 2022

mcgrathr accepted D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs.

lgtm

Dec 7 2022, 5:10 PM · Restricted Project, Restricted Project

Nov 23 2022

mcgrathr added a comment to D138307: [libc++] Remove default definition of std::char_traits.

This broke some existing cases using std::basic_string_view<std::byte> and the like.

Nov 23 2022, 12:14 PM · Restricted Project, Restricted Project

Nov 8 2022

mcgrathr accepted D133806: [compiler-rt][hwasan] Call __hwasan_library_loaded via __sanitizer_library_loaded on Fuchsia.

lgtm

Nov 8 2022, 3:24 PM · Restricted Project, Restricted Project
mcgrathr accepted D137676: [compiler-rt][hwasan] Do not call InitLoadedGlobals in __hwasan_init.

lgtm

Nov 8 2022, 3:23 PM · Restricted Project, Restricted Project

Oct 24 2022

mcgrathr added a comment to D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use.

The C++ ABI is not part of the Fuchsia system ABI, nor what we call the "Fuchsia compiler ABI". Different users of C++ are free to use whatever C++ ABI they like. Only the backend ABI independent of language-specific issues is necessary to interoperate with other code on Fuchsia.

Sure enough - but I'm still sort of confused by why the Fuschia Clang target/compiler needs more than one C++ ABI. What is it interoperating with? (GCC doesn't have a Fuschia target implemented, does it? So what's it mean to target the GCC C++ ABI? what is compiling the code that Fuschia is trying to interoperate with when Clang targets Fuschia with a non-default C++ ABI?)

When we use GCC we're using the generic ELF targets. I think it's sufficient for us to tell you that indeed we do want the option of multiple C++ ABIs to select from without justifying everything about our work to a Clang reviewer before we can proceed with meeting the requirements of our system.

Would the generic ELF target support in Clang be adequate to meet that requirement, then? (so Fuschia target could be the custom C++ ABI (& custom C ABI if you likee) and a generic ELF target could be used for GCC ELF compatibility) - then we wouldn't need any C++ ABI customizability?

Oct 24 2022, 10:53 AM · Restricted Project, Restricted Project
mcgrathr added a comment to D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use.

The C++ ABI is not part of the Fuchsia system ABI, nor what we call the "Fuchsia compiler ABI". Different users of C++ are free to use whatever C++ ABI they like. Only the backend ABI independent of language-specific issues is necessary to interoperate with other code on Fuchsia.

Sure enough - but I'm still sort of confused by why the Fuschia Clang target/compiler needs more than one C++ ABI. What is it interoperating with? (GCC doesn't have a Fuschia target implemented, does it? So what's it mean to target the GCC C++ ABI? what is compiling the code that Fuschia is trying to interoperate with when Clang targets Fuschia with a non-default C++ ABI?)

Oct 24 2022, 10:10 AM · Restricted Project, Restricted Project

Oct 18 2022

mcgrathr added a comment to D135716: [compiler-rt] Add opt-in -ftrivial-auto-var-init flag for writing over uninitialized stack variiables.

BTW, would this one solve the problem D130237 this patch is trying to address?

Oct 18 2022, 1:16 PM · Restricted Project, Restricted Project

Oct 17 2022

mcgrathr added a comment to D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use.

I'm quite sure that we will always want a means to select the original Itanium ABI. It's also quite likely that there will be future innovations in the Fuchsia C++ ABI and we'll go through migration periods of supporting additional variants and changing the default for Fuchsia targets.

Oct 17 2022, 3:32 PM · Restricted Project, Restricted Project
mcgrathr added a comment to D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use.

It's certainly correct that we envision each target having an explicit list of viable C++ ABIs to select from.

Oct 17 2022, 12:15 PM · Restricted Project, Restricted Project
mcgrathr added a comment to D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use.

The C++ ABI is not part of the Fuchsia system ABI, nor what we call the "Fuchsia compiler ABI". Different users of C++ are free to use whatever C++ ABI they like. Only the backend ABI independent of language-specific issues is necessary to interoperate with other code on Fuchsia.

Oct 17 2022, 11:33 AM · Restricted Project, Restricted Project

Oct 11 2022

mcgrathr added inline comments to D135716: [compiler-rt] Add opt-in -ftrivial-auto-var-init flag for writing over uninitialized stack variiables.
Oct 11 2022, 4:00 PM · Restricted Project, Restricted Project
mcgrathr added a comment to D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build.

I had imagined making lsan always do this since there's a specific lsan-related rationale for it that applies to everybody.
I'm not clear on how cmake structures things and whether sanitizer_common would have to do it unconditionally since it's used by lsan code.

Oct 11 2022, 2:27 PM · Restricted Project, Restricted Project

Oct 6 2022

mcgrathr added a comment to D135340: [PGO] Make emitted symbols hidden.

The subject should change the emitted symbol to __llvm_profile_raw_version.

Oct 6 2022, 11:25 AM · Restricted Project, Restricted Project, Restricted Project
mcgrathr accepted D135340: [PGO] Make emitted symbols hidden.

lgtm

Oct 6 2022, 11:14 AM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2022

mcgrathr accepted D134289: [Driver] Make --execute-only the default for aarch64-fuchsia.
Sep 20 2022, 10:48 AM · Restricted Project, Restricted Project

Sep 16 2022

mcgrathr added a comment to D133806: [compiler-rt][hwasan] Call __hwasan_library_loaded via __sanitizer_library_loaded on Fuchsia.

We haven't quite worked out this signature on the Fuchsia side yet.
Also, this makes the dl_iterate_phdr sequence in InitLoadedGlobals redundant so we should remove that for the Fuchsia configurations.

Sep 16 2022, 10:36 AM · Restricted Project, Restricted Project

Sep 14 2022

mcgrathr added a comment to D133798: [compiler-rt][hwasan] Add __hwasan_library_loaded/unloaded to hwasan_interface.h.

For the general case, not only glibc but probably all preexisting system libraries that don't have special hwasan support built in, I don't think you can rely on anything to hook into here. If you really needed to, *maybe* you could have dlopen and dlclose interceptors, but that seems really unlikely to go well. Bottom line, you probably have to find a way on those systems to have vanilla init and fini hook behavior (init_array, preinit_array, fini_array, etc.) be sufficient. It's challenging because you really need to come in before any code that could access a global is run, and with a DSO overriding a symbol in one of its DT_NEEDED DSOs the order of init hooks getting called could make it impossible to be in the right place.

Sep 14 2022, 6:20 PM · Restricted Project, Restricted Project

Aug 30 2022

mcgrathr added inline comments to D132706: [Symbolizer] Handle {{{bt}}} symbolizer markup element..
Aug 30 2022, 10:46 AM · Restricted Project, Restricted Project

Aug 26 2022

mcgrathr accepted D132691: [clang] Do not instrument the rtti_proxies under hwasan.
Aug 26 2022, 10:21 AM · Restricted Project, Restricted Project

Aug 23 2022

mcgrathr accepted D132425: [clang] Do not instrument relative vtables under hwasan.

lgtm.
You might add some comments in CGVTables.cpp about why this is done and what the alternatives might be in the future.

Aug 23 2022, 11:22 AM · Restricted Project, Restricted Project

Aug 22 2022

mcgrathr accepted D132416: [Driver][Fuchsia] Add default linker flags.
Aug 22 2022, 4:32 PM · Restricted Project, Restricted Project
mcgrathr added a reviewer for D132416: [Driver][Fuchsia] Add default linker flags: phosek.
Aug 22 2022, 4:32 PM · Restricted Project, Restricted Project

Jul 28 2022

mcgrathr added inline comments to D130662: [libc] Read and write errno via special getter and setter functions..
Jul 28 2022, 8:14 PM · Restricted Project, Restricted Project
mcgrathr added inline comments to D130662: [libc] Read and write errno via special getter and setter functions..
Jul 28 2022, 10:20 AM · Restricted Project, Restricted Project

Jul 27 2022

mcgrathr added inline comments to D130662: [libc] Read and write errno via special getter and setter functions..
Jul 27 2022, 3:27 PM · Restricted Project, Restricted Project

Jul 13 2022

mcgrathr accepted D128387: [hwasan] Add __hwasan_add_frame_record to the hwasan interface.

LGTM, I didn't realize Phabricator considered me to be blocking.

Jul 13 2022, 1:28 PM · Restricted Project, Restricted Project, Restricted Project

Jul 11 2022

mcgrathr accepted D129512: [Driver] Don't use frame pointer on Fuchsia when optimizations are enabled.

lgtm but be sure that Fuchsia target users get clear release-notes warning about the change.

Jul 11 2022, 1:14 PM · Restricted Project, Restricted Project

Jul 7 2022

mcgrathr accepted D129331: [scudo][Fuchsia] Don't assume MapPlatformData::Vmar is valid.
Jul 7 2022, 3:55 PM · Restricted Project, Restricted Project
mcgrathr accepted D129318: [hwasan][fuchsia] Fix features bitmask checking.

lgtm

Jul 7 2022, 12:12 PM · Restricted Project, Restricted Project

Jul 6 2022

mcgrathr added inline comments to D126752: Add Soft/Hard RSS Limits to Scudo Standalone.
Jul 6 2022, 11:21 AM · Restricted Project, Restricted Project
mcgrathr added a comment to D128387: [hwasan] Add __hwasan_add_frame_record to the hwasan interface.

I don't see a problem having the compiler-rt and compiler changes in the same commit. Seems desirable in this case, actually.

Jul 6 2022, 11:14 AM · Restricted Project, Restricted Project, Restricted Project
mcgrathr added inline comments to D127262: [compiler-rt][hwasan] Check address tagging mode in InitializeOsSupport on Fuchsia.
Jul 6 2022, 11:05 AM · Restricted Project, Restricted Project

Jun 28 2022

mcgrathr accepted D128748: Update fuchsia sanitizer sched_yield.

lgtm since the compatibility window for platform versions that didn't have the new entry point has already passed by now.

Jun 28 2022, 1:17 PM · Restricted Project, Restricted Project

Jun 15 2022

mcgrathr closed D126582: [scudo] Clean up Zircon header file uses.

Landed in a27b9139ab1bbdc93afaf240de2c2b9e45092884

Jun 15 2022, 12:31 PM · Restricted Project, Restricted Project
mcgrathr accepted D127887: [CMake][Fuchsia] Use libunwind as the default unwinder.

lgtm

Jun 15 2022, 11:53 AM · Restricted Project, Restricted Project

Jun 1 2022

mcgrathr added a comment to D126752: Add Soft/Hard RSS Limits to Scudo Standalone.

This needs a stub GetRSS for Fuchsia, at least.
Since there's no way to get a useful value for this on Fuchsia as yet, it would be preferable to conditionalize the machinery so it isn't doing no-op work.

Jun 1 2022, 10:26 AM · Restricted Project, Restricted Project
mcgrathr added a reviewer for D126752: Add Soft/Hard RSS Limits to Scudo Standalone: abrachet.
Jun 1 2022, 10:25 AM · Restricted Project, Restricted Project

May 27 2022

mcgrathr committed rGa27b9139ab1b: [scudo] Clean up Zircon header file uses (authored by mcgrathr).
[scudo] Clean up Zircon header file uses
May 27 2022, 9:44 PM · Restricted Project, Restricted Project
mcgrathr accepted D126499: [scudo] Ensure pointer is not null.
May 27 2022, 9:38 PM · Restricted Project, Restricted Project
mcgrathr requested review of D126582: [scudo] Clean up Zircon header file uses.
May 27 2022, 6:33 PM · Restricted Project, Restricted Project

Apr 20 2022

mcgrathr accepted D124136: [fuchsia] Don't include duplicate profiling symbols for Fuchsia.

Lgtm

Apr 20 2022, 5:53 PM · Restricted Project, Restricted Project

Apr 19 2022

mcgrathr accepted D119996: [safestack] Support safestack in stack size diagnostics.
Apr 19 2022, 4:20 PM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

mcgrathr added inline comments to D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array.
Mar 29 2022, 5:39 PM · Restricted Project, Restricted Project
mcgrathr committed rGfd7ec90abd90: [lsan] On Fuchsia, don't use atexit hook for leak checks (authored by mcgrathr).
[lsan] On Fuchsia, don't use atexit hook for leak checks
Mar 29 2022, 5:14 PM · Restricted Project, Restricted Project