Page MenuHomePhabricator

[analyzer] (Urgent!) Add 9.0.0. release notes.
ClosedPublic

Authored by Szelethus on Mon, Aug 26, 12:02 PM.

Details

Summary

I wanted to do this a lot sooner, but I guess better now than never. Please chip in, I may have missed some important patches (especially osx or CTU ones).

Diff Detail

Repository
rL LLVM

Event Timeline

Szelethus created this revision.Mon, Aug 26, 12:02 PM

Please note that LLVM 9.0.0-final is due on the 28th of August.

xbolva00 added inline comments.
clang/docs/ReleaseNotes.rst
251 ↗(On Diff #217219)

Please fix this

263 ↗(On Diff #217219)

Detto

NoQ added inline comments.Mon, Aug 26, 6:32 PM
clang/docs/ReleaseNotes.rst
237–238 ↗(On Diff #217219)

"On LLVM's own codebase" :)

@Charusso: I think we need to cherry-pick all of our latest patches to this checker to 9.0 because otherwise it'll be crashing with the isValidBaseClass() assertion.

NoQ accepted this revision.Mon, Aug 26, 6:40 PM

I approve the patch and i don't see anything obvious that we're missing out (@Szelethus, your GSoC isn't on by default back in 9.0, only in master, right?).

I guess we should really try harder to fill it in with every patch that deserves it.

clang/docs/ReleaseNotes.rst
235 ↗(On Diff #217219)

"of XNU libkern OSObjects", so that it sounded less esoteric :/

237–238 ↗(On Diff #217219)

Please note that LLVM 9.0.0-final is due on the 28th of August.

Mmm, most likely too late.

251 ↗(On Diff #217219)

I think this was supposed to be a joke but i don't insist^^

This revision is now accepted and ready to land.Mon, Aug 26, 6:40 PM
hans added a comment.Tue, Aug 27, 1:14 AM

Please note that LLVM 9.0.0-final is due on the 28th of August.

There are still a lot of open bugs, so it will probably slip at least a little.

clang/docs/ReleaseNotes.rst
237–238 ↗(On Diff #217219)

"all of our latest patches" sounds like a lot, so yeah probably too late.

If it's broken, maybe don't point it out in the release notes. Fixes can go in 9.0.1.

martong added inline comments.Tue, Aug 27, 1:20 AM
clang/docs/ReleaseNotes.rst
269 ↗(On Diff #217219)

Could you please also add:

  • Numerous` ASTImporter` related fixes and improvements which increase the stability of CTU.
  • CTU is enabled to inline virtual functions too.
devnexen added inline comments.
clang/docs/ReleaseNotes.rst
240 ↗(On Diff #217219)

typo recieved

Szelethus updated this revision to Diff 217564.Tue, Aug 27, 6:56 PM

Fixing inlines!

Szelethus marked 10 inline comments as done.Tue, Aug 27, 6:57 PM
In D66765#1646237, @NoQ wrote:

I approve the patch and i don't see anything obvious that we're missing out (@Szelethus, your GSoC isn't on by default back in 9.0, only in master, right?).

Precisely.

I guess we should really try harder to fill it in with every patch that deserves it.

*judges everyone who lets any important patch through without adding it to the release notes from now on*

clang/docs/ReleaseNotes.rst
251 ↗(On Diff #217219)

Let's reserve jokes for greater depths within the developer docs :^)

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptWed, Aug 28, 1:11 AM