Page MenuHomePhabricator

devnexen (David CARLIER)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 30 2017, 8:43 AM (152 w, 5 d)

Recent Activity

Oct 20 2020

devnexen added a comment to D89652: [Sanitizers] DragonFlyBSD ground work to support sanitizers.

Ok that is fair.

Oct 20 2020, 5:54 AM · Restricted Project
devnexen committed rG53065c543fe3: [Sanitizers] Remove OpenBSD support (new attempt) (authored by devnexen).
[Sanitizers] Remove OpenBSD support (new attempt)
Oct 20 2020, 2:16 AM
devnexen closed D89759: [Sanitizers] Remove OpenBSD support (new attempt).
Oct 20 2020, 2:16 AM · Restricted Project
devnexen added a comment to D89652: [Sanitizers] DragonFlyBSD ground work to support sanitizers.

How likely we are going to remove it soon this as unused OpenBSD?
Are we going to have continuous builder?

Oct 20 2020, 1:49 AM · Restricted Project

Oct 19 2020

devnexen requested review of D89759: [Sanitizers] Remove OpenBSD support (new attempt).
Oct 19 2020, 7:15 PM · Restricted Project
devnexen committed rG13e22961f8b4: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases (authored by devnexen).
[clang] update of the DragonFlyBSD's driver for the 5.8.x releases
Oct 19 2020, 6:06 AM
devnexen closed D89690: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases..
Oct 19 2020, 6:06 AM · Restricted Project
devnexen added a comment to D89640: [Sanitizers] Remove OpenBSD support.
Oct 19 2020, 5:56 AM · Restricted Project
devnexen requested review of D89690: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases..
Oct 19 2020, 4:57 AM · Restricted Project

Oct 18 2020

devnexen set the repository for D89652: [Sanitizers] DragonFlyBSD ground work to support sanitizers to rG LLVM Github Monorepo.
Oct 18 2020, 11:32 AM · Restricted Project
devnexen added a reviewer for D89653: [Sanitizers] DragonFlyBSD adding support for builtins: vitalybuka.
Oct 18 2020, 11:32 AM · Restricted Project
devnexen requested review of D89653: [Sanitizers] DragonFlyBSD adding support for builtins.
Oct 18 2020, 11:32 AM · Restricted Project
devnexen updated the diff for D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.

Focusing on ubsan change only

Oct 18 2020, 11:31 AM · Restricted Project
devnexen requested review of D89652: [Sanitizers] DragonFlyBSD ground work to support sanitizers.
Oct 18 2020, 11:30 AM · Restricted Project
devnexen committed rGd09b08919ca6: [Sanitizers] Remove OpenBSD support (authored by devnexen).
[Sanitizers] Remove OpenBSD support
Oct 18 2020, 6:58 AM
devnexen closed D89640: [Sanitizers] Remove OpenBSD support.
Oct 18 2020, 6:58 AM · Restricted Project
devnexen updated the diff for D89640: [Sanitizers] Remove OpenBSD support.

bring back builtins part

Oct 18 2020, 6:43 AM · Restricted Project

Oct 17 2020

devnexen requested review of D89640: [Sanitizers] Remove OpenBSD support.
Oct 17 2020, 10:02 PM · Restricted Project
devnexen added a comment to D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.

This contains unrelated code to ubsan/dragonflybsd. While there can you remove unsupported code for other OSs you introduced? That was never operational?

Oct 17 2020, 1:22 PM · Restricted Project
devnexen requested review of D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.
Oct 17 2020, 11:52 AM · Restricted Project

Jul 24 2020

devnexen abandoned D84558: [compiler-rt] ubsan/asan illumos linkage fix.
Jul 24 2020, 3:24 PM · Restricted Project
Herald added a project to D84558: [compiler-rt] ubsan/asan illumos linkage fix: Restricted Project.
Jul 24 2020, 2:43 PM · Restricted Project

Jul 23 2020

devnexen added a comment to D84046: [compiler-rt] fix build on illumos.
In D84046#2168732, @ro wrote:

Unfortunately I hadn't noticed that you'd silently changed the madvise prototype from the version I'd suggested (and tested on both Solaris 11.4 and OpenIndiana) to one using caddr_t instead of void * for the first arg, this way breaking the Solaris build. Now fixed in D84388.

Please don't do something like this: it just creates unnecessary work.

This is exactly the reason why I asked for a way to distinguish between Illumos and Solaris at compile time (e.g. by predefining __illumos__).
Fixing one by breaking the other just isn't an option.

Jul 23 2020, 1:48 AM · Restricted Project

Jul 22 2020

devnexen committed rGc61dcb8f623e: [compiler-rt] fix build on Illumos (authored by devnexen).
[compiler-rt] fix build on Illumos
Jul 22 2020, 7:20 AM
devnexen closed D84046: [compiler-rt] fix build on illumos.
Jul 22 2020, 7:20 AM · Restricted Project
devnexen updated the diff for D84046: [compiler-rt] fix build on illumos.

Changes per feedback :
madvise prototype for access.

Jul 22 2020, 6:52 AM · Restricted Project

Jul 18 2020

devnexen updated the diff for D84046: [compiler-rt] fix build on illumos.
Jul 18 2020, 11:59 PM · Restricted Project
devnexen added a reviewer for D84046: [compiler-rt] fix build on illumos: eugenis.
Jul 18 2020, 2:12 AM · Restricted Project

Jul 17 2020

devnexen added a reviewer for D84046: [compiler-rt] fix build on illumos: ro.
Jul 17 2020, 9:57 AM · Restricted Project
Herald added a project to D84046: [compiler-rt] fix build on illumos: Restricted Project.
Jul 17 2020, 9:49 AM · Restricted Project

Jan 21 2020

devnexen updated the diff for D72058: [OpenMP] Enabling CPU affinity on Darwin platform proposal.
Jan 21 2020, 10:19 PM · Restricted Project

Jan 20 2020

devnexen committed rGea99c0996348: [OpenMP] affinity little fix for FreeBSD (authored by devnexen).
[OpenMP] affinity little fix for FreeBSD
Jan 20 2020, 10:54 AM
devnexen closed D72132: [OpenMP] affinity little fix for FreeBSD.
Jan 20 2020, 10:54 AM · Restricted Project
devnexen updated the diff for D72058: [OpenMP] Enabling CPU affinity on Darwin platform proposal.
Jan 20 2020, 3:30 AM · Restricted Project

Jan 19 2020

devnexen added a comment to D72132: [OpenMP] affinity little fix for FreeBSD.

ping :-)

Jan 19 2020, 4:23 AM · Restricted Project
devnexen added a comment to D72058: [OpenMP] Enabling CPU affinity on Darwin platform proposal.

ping :-)

Jan 19 2020, 4:23 AM · Restricted Project

Jan 7 2020

devnexen added a comment to D71923: fuzzfork allocating expected number of jobs.

But was there a bug before, or is this just an optimization? Maybe it could just be an array instead?

Jan 7 2020, 3:32 AM · Restricted Project, Restricted Project
devnexen updated the summary of D71923: fuzzfork allocating expected number of jobs.
Jan 7 2020, 2:36 AM · Restricted Project, Restricted Project

Jan 6 2020

devnexen changed the edit policy for D71923: fuzzfork allocating expected number of jobs.
Jan 6 2020, 8:05 PM · Restricted Project, Restricted Project

Jan 3 2020

devnexen changed the edit policy for D72132: [OpenMP] affinity little fix for FreeBSD.
Jan 3 2020, 2:09 AM · Restricted Project

Jan 1 2020

devnexen created D72058: [OpenMP] Enabling CPU affinity on Darwin platform proposal.
Jan 1 2020, 11:45 AM · Restricted Project

Dec 27 2019

devnexen created D71923: fuzzfork allocating expected number of jobs.
Dec 27 2019, 5:41 AM · Restricted Project, Restricted Project

Dec 6 2019

devnexen committed rG27535a144910: [OpenMP] Fix linkage issue on FreeBSD (authored by devnexen).
[OpenMP] Fix linkage issue on FreeBSD
Dec 6 2019, 7:52 AM

Oct 30 2019

devnexen committed rG506992848729: [OpenMP] Reset affinity mask in the process child on FreeBSD (authored by devnexen).
[OpenMP] Reset affinity mask in the process child on FreeBSD
Oct 30 2019, 7:56 AM

Oct 24 2019

devnexen created D69373: [Clang] Fix Sema class build fix.
Oct 24 2019, 3:31 AM · Restricted Project

Oct 21 2019

devnexen committed rGa48633b5bbbb: Fix llvm signal tests build. (authored by devnexen).
Fix llvm signal tests build.
Oct 21 2019, 3:49 AM
devnexen committed rL375406: Fix llvm signal tests build..
Fix llvm signal tests build.
Oct 21 2019, 3:49 AM

Oct 10 2019

devnexen accepted D68723: Fix process launch failure on FreeBSD after r365761.
Oct 10 2019, 12:57 PM · Restricted Project
devnexen committed rG69c9c223a0af: [Sanitizers] Fix getrandom test (authored by devnexen).
[Sanitizers] Fix getrandom test
Oct 10 2019, 5:51 AM
devnexen committed rL374333: [Sanitizers] Fix getrandom test.
[Sanitizers] Fix getrandom test
Oct 10 2019, 5:50 AM
devnexen committed rG90c8b59cfc6e: [Sanitizers] Porting getrandom/getentropy interceptors to FreeBSD (authored by devnexen).
[Sanitizers] Porting getrandom/getentropy interceptors to FreeBSD
Oct 10 2019, 4:35 AM
devnexen committed rL374315: [Sanitizers] Porting getrandom/getentropy interceptors to FreeBSD.
[Sanitizers] Porting getrandom/getentropy interceptors to FreeBSD
Oct 10 2019, 4:33 AM
devnexen added a comment to D68723: Fix process launch failure on FreeBSD after r365761.

@dim I LGTMed this but would it a real issue for you to take on a less disruptive approach proposed by MaskRay ?

I think we should do what @labath suggested (changing Expected to Optional) if that is not very difficult.

Oct 10 2019, 3:19 AM · Restricted Project
devnexen added a comment to D68723: Fix process launch failure on FreeBSD after r365761.

@dim I LGTMed this but would it a real issue for you to take on a less disruptive approach proposed by MaskRay ?

Oct 10 2019, 2:49 AM · Restricted Project
devnexen added a comment to D68723: Fix process launch failure on FreeBSD after r365761.

LGTM otherwise.

I don't think this change should be reverted. It can just be repaired by adding some (void)!xxx;

Oct 10 2019, 1:54 AM · Restricted Project

Oct 9 2019

devnexen accepted D68723: Fix process launch failure on FreeBSD after r365761.

LGTM otherwise.

Oct 9 2019, 11:34 PM · Restricted Project
devnexen added inline comments to D68723: Fix process launch failure on FreeBSD after r365761.
Oct 9 2019, 11:34 PM · Restricted Project
devnexen added a comment to rL365761: [LLDB] Fix FreeBSD build..

@devnexen this appears to cause https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241137, where simply launching a process in lldb triggers a failure:

Expected<T> must be checked before access or destruction.
Expected<T> value was in success state. (Note: Expected<T> values in success mode must still be checked prior to being destroyed).

Btw, note that this only happens when LLVM_ENABLE_ABI_BREAKING_CHECKS is on, but it is not entirely clear to me where that gets toggled. We have it in our pre-generated headers though, so it must come originally from some CMake logic...

Oct 9 2019, 7:54 PM

Oct 8 2019

devnexen committed rGf61f13d4e7e0: [OpenMP] Enable thread affinity on FreeBSD (authored by devnexen).
[OpenMP] Enable thread affinity on FreeBSD
Oct 8 2019, 2:25 PM
devnexen committed rL374118: [OpenMP] Enable thread affinity on FreeBSD.
[OpenMP] Enable thread affinity on FreeBSD
Oct 8 2019, 2:24 PM
devnexen added a comment to D68045: [builtins] Unbreak build on FreeBSD armv7 after D60351.

Can someone land this change? Only tested on FreeBSD because contributing guide didn't cover how to elsewhere i.e., on platforms one doesn't have access to.

Oct 8 2019, 8:54 AM · Restricted Project, Restricted Project
devnexen committed rGd80c2520d9f8: [builtins] Unbreak build on FreeBSD armv7 after D60351 (authored by devnexen).
[builtins] Unbreak build on FreeBSD armv7 after D60351
Oct 8 2019, 8:45 AM
devnexen committed rL374070: [builtins] Unbreak build on FreeBSD armv7 after D60351.
[builtins] Unbreak build on FreeBSD armv7 after D60351
Oct 8 2019, 8:45 AM

Sep 28 2019

devnexen committed rGfef62e1a6843: [OpenMP] FreeBSD address check if mapped more native (authored by devnexen).
[OpenMP] FreeBSD address check if mapped more native
Sep 28 2019, 12:02 PM
devnexen committed rL373152: [OpenMP] FreeBSD address check if mapped more native.
[OpenMP] FreeBSD address check if mapped more native
Sep 28 2019, 12:02 PM

Sep 10 2019

devnexen committed rGc190890c29b9: [LLDB] FreeBSD fix new SetFile call. (authored by devnexen).
[LLDB] FreeBSD fix new SetFile call.
Sep 10 2019, 12:35 AM
devnexen committed rL371491: [LLDB] FreeBSD fix new SetFile call..
[LLDB] FreeBSD fix new SetFile call.
Sep 10 2019, 12:32 AM

Sep 9 2019

devnexen committed rGf707dac742f3: LLDB - Simplify GetProgramFileSpec (authored by devnexen).
LLDB - Simplify GetProgramFileSpec
Sep 9 2019, 9:12 AM
devnexen committed rL371417: LLDB - Simplify GetProgramFileSpec.
LLDB - Simplify GetProgramFileSpec
Sep 9 2019, 9:09 AM
devnexen closed D46518: LLDB - Simplify GetProgramFileSpec.
Sep 9 2019, 9:09 AM · Restricted Project

Aug 28 2019

devnexen accepted D66756: compiler-rt: use more __sanitizer_time_t on FreeBSD.
Aug 28 2019, 8:59 PM · Restricted Project
devnexen added a comment to D66758: compiler-rt: all FreeBSD CPU archs except i386 use 64-bit time_t.

You are right !

Aug 28 2019, 8:58 PM · Restricted Project
devnexen committed rG72cb9db5c79e: [XRay] Fixing one test case for FreeBSD (authored by devnexen).
[XRay] Fixing one test case for FreeBSD
Aug 28 2019, 7:19 AM
devnexen committed rL370209: [XRay] Fixing one test case for FreeBSD.
[XRay] Fixing one test case for FreeBSD
Aug 28 2019, 7:19 AM

Aug 27 2019

devnexen committed rL370035: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD.
[ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD
Aug 27 2019, 3:21 AM
devnexen committed rGbccbd74c6255: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD (authored by devnexen).
[ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD
Aug 27 2019, 3:13 AM
devnexen added inline comments to D66765: [analyzer] (Urgent!) Add 9.0.0. release notes..
Aug 27 2019, 2:31 AM · Restricted Project, Restricted Project
devnexen added inline comments to D66758: compiler-rt: all FreeBSD CPU archs except i386 use 64-bit time_t.
Aug 27 2019, 1:01 AM · Restricted Project
devnexen added a comment to D66756: compiler-rt: use more __sanitizer_time_t on FreeBSD.
Aug 27 2019, 12:23 AM · Restricted Project
devnexen added a comment to D66756: compiler-rt: use more __sanitizer_time_t on FreeBSD.
Aug 27 2019, 12:23 AM · Restricted Project

Aug 26 2019

devnexen committed rL370011: Fix buildbot.
Fix buildbot
Aug 26 2019, 9:26 PM
devnexen committed rG5058dd0f491e: Fix buildbot (authored by devnexen).
Fix buildbot
Aug 26 2019, 9:26 PM
devnexen committed rG4797f68b159e: [Sanitizer] Using huge page on FreeBSD for shadow mapping (authored by devnexen).
[Sanitizer] Using huge page on FreeBSD for shadow mapping
Aug 26 2019, 9:22 PM
devnexen committed rL370008: [Sanitizer] Using huge page on FreeBSD for shadow mapping.
[Sanitizer] Using huge page on FreeBSD for shadow mapping
Aug 26 2019, 9:22 PM
devnexen added a comment to D66582: [Sanitizer] checks ASLR on FreeBSD.
In D66582#1641454, @dim wrote:

LGTM. Maybe nice to merge it to 9.0 after a day or two.

Aug 26 2019, 5:22 AM · Restricted Project, Restricted Project

Aug 22 2019

devnexen committed rGf2003f4cb854: Fixing buildbot due to style. (authored by devnexen).
Fixing buildbot due to style.
Aug 22 2019, 2:53 PM
devnexen committed rL369711: Fixing buildbot due to style..
Fixing buildbot due to style.
Aug 22 2019, 2:53 PM
devnexen committed rGe2ed800d6225: [Sanitizer] checks ASLR on FreeBSD (authored by devnexen).
[Sanitizer] checks ASLR on FreeBSD
Aug 22 2019, 2:43 PM
devnexen committed rL369708: [Sanitizer] checks ASLR on FreeBSD.
[Sanitizer] checks ASLR on FreeBSD
Aug 22 2019, 2:35 PM
devnexen closed D66582: [Sanitizer] checks ASLR on FreeBSD.
Aug 22 2019, 2:35 PM · Restricted Project, Restricted Project
devnexen created D66582: [Sanitizer] checks ASLR on FreeBSD.
Aug 22 2019, 4:56 AM · Restricted Project, Restricted Project

Aug 19 2019

devnexen committed rG949f1908102e: [Sanitizer] arc4random interception on Mac (authored by devnexen).
[Sanitizer] arc4random interception on Mac
Aug 19 2019, 11:19 AM
devnexen committed rL369285: [Sanitizer] arc4random interception on Mac.
[Sanitizer] arc4random interception on Mac
Aug 19 2019, 11:11 AM

Aug 9 2019

devnexen committed rG8d1646bf6670: [Sanitizer] Reenable getusershell interception (authored by devnexen).
[Sanitizer] Reenable getusershell interception
Aug 9 2019, 8:37 PM
devnexen committed rL368504: [Sanitizer] Reenable getusershell interception.
[Sanitizer] Reenable getusershell interception
Aug 9 2019, 8:36 PM

Aug 6 2019

devnexen committed rG074a4c627493: [Sanitizer] little typo (authored by devnexen).
[Sanitizer] little typo
Aug 6 2019, 2:46 PM
devnexen committed rL368093: [Sanitizer] little typo.
[Sanitizer] little typo
Aug 6 2019, 2:45 PM
devnexen committed rG906e727972d1: [Sanitizer] Linux explicitally migrate shadow mapping to Transparent Huge Page (authored by devnexen).
[Sanitizer] Linux explicitally migrate shadow mapping to Transparent Huge Page
Aug 6 2019, 2:33 PM
devnexen committed rL368090: [Sanitizer] Linux explicitally migrate shadow mapping to Transparent Huge Page.
[Sanitizer] Linux explicitally migrate shadow mapping to Transparent Huge Page
Aug 6 2019, 2:29 PM

Aug 5 2019

devnexen committed rG1d92925a5ad8: [Sanitizer] Linux refactor shadow huge page mode handling (authored by devnexen).
[Sanitizer] Linux refactor shadow huge page mode handling
Aug 5 2019, 1:57 PM