Page MenuHomePhabricator

balazske (Balázs Kéri)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
May 23 2018, 7:08 AM (65 w, 1 d)

Recent Activity

Today

balazske added inline comments to D66538: [AST] AST structural equivalence to work internally with pairs..
Thu, Aug 22, 3:32 AM · Restricted Project
balazske abandoned D60465: [ASTImporter] Error handling fix in ImportDefinition_New..

This change is obsolete in the current code. Casting related changes do not look important (and should be a new patch anyway).

Thu, Aug 22, 1:40 AM · Restricted Project
balazske added inline comments to D66538: [AST] AST structural equivalence to work internally with pairs..
Thu, Aug 22, 1:03 AM · Restricted Project

Yesterday

balazske added a comment to D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter.

A "quick fix" for the problem:
https://reviews.llvm.org/D66538

Wed, Aug 21, 7:58 AM · Restricted Project
balazske created D66538: [AST] AST structural equivalence to work internally with pairs..
Wed, Aug 21, 7:55 AM · Restricted Project
balazske added a comment to D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter.

Example about how to get wrong things into NonEquivalentDecls:
We want to compare class C for structural equivalence in the following codes:

class A {}; class B {int i;}; void x(A *); void y(A *); class C { friend void x(A *); friend void y(A *); };

and

class A {}; class B {int i;}; void x(A *); void y(B *); class C { friend void x(A *); friend void y(B *); };

The result is false for C but the NonEquivalentDecls will contain after the compare a void x(A*)<->void x(A*) pair.

Wed, Aug 21, 5:36 AM · Restricted Project
balazske added inline comments to D66336: [ASTImporter] Add development internals docs.
Wed, Aug 21, 1:04 AM · Restricted Project

Fri, Aug 16

balazske committed rGe13e836480fc: [ASTImporter] Import ctor initializers after setting flags. (authored by balazske).
[ASTImporter] Import ctor initializers after setting flags.
Fri, Aug 16, 5:13 AM
balazske committed rL369098: [ASTImporter] Import ctor initializers after setting flags..
[ASTImporter] Import ctor initializers after setting flags.
Fri, Aug 16, 5:13 AM
balazske closed D65935: [ASTImporter] Import ctor initializers after setting flags..
Fri, Aug 16, 5:13 AM · Restricted Project, Restricted Project
balazske added a comment to D65935: [ASTImporter] Import ctor initializers after setting flags..

LLDB probably does the import in other way. CTU test fails without the fix:

FAIL: Clang :: Analysis/ctu-main.cpp (540 of 15341)
******************** TEST 'Clang :: Analysis/ctu-main.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';   rm -rf build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp && mkdir build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp
: 'RUN: at line 2';   mkdir -p build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir
: 'RUN: at line 3';   build/Release/bin/clang -cc1 -internal-isystem build/Release/lib/clang/10.0.0/include -nostdsysteminc -triple x86_64-pc-linux-gnu    -emit-pch -o build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir/ctu-other.cpp.ast llvm-project/clang/test/Analysis/Inputs/ctu-other.cpp
: 'RUN: at line 5';   build/Release/bin/clang -cc1 -internal-isystem build/Release/lib/clang/10.0.0/include -nostdsysteminc -triple x86_64-pc-linux-gnu    -emit-pch -o build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir/ctu-chain.cpp.ast llvm-project/clang/test/Analysis/Inputs/ctu-chain.cpp
: 'RUN: at line 7';   cp llvm-project/clang/test/Analysis/Inputs/ctu-other.cpp.externalDefMap.txt build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir/externalDefMap.txt
: 'RUN: at line 8';   build/Release/bin/clang -cc1 -internal-isystem build/Release/lib/clang/10.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range -triple x86_64-pc-linux-gnu    -analyzer-checker=core,debug.ExprInspection    -analyzer-config experimental-enable-naive-ctu-analysis=true    -analyzer-config ctu-dir=build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir    -verify llvm-project/clang/test/Analysis/ctu-main.cpp
: 'RUN: at line 13';   build/Release/bin/clang -cc1 -internal-isystem build/Release/lib/clang/10.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range -triple x86_64-pc-linux-gnu    -analyzer-checker=core,debug.ExprInspection    -analyzer-config experimental-enable-naive-ctu-analysis=true    -analyzer-config ctu-dir=build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir    -analyzer-config display-ctu-progress=true 2>&1 llvm-project/clang/test/Analysis/ctu-main.cpp | build/Release/bin/FileCheck llvm-project/clang/test/Analysis/ctu-main.cpp
--
Exit Code: 134
Fri, Aug 16, 2:21 AM · Restricted Project, Restricted Project

Wed, Aug 14

balazske committed rGc50959431928: [ASTImporter] Import default expression of param before creating the param. (authored by balazske).
[ASTImporter] Import default expression of param before creating the param.
Wed, Aug 14, 2:42 AM
balazske committed rL368818: [ASTImporter] Import default expression of param before creating the param..
[ASTImporter] Import default expression of param before creating the param.
Wed, Aug 14, 2:42 AM
balazske closed D65577: [ASTImporter] Import default expression of param before creating the param..
Wed, Aug 14, 2:42 AM · Restricted Project
balazske updated the diff for D65935: [ASTImporter] Import ctor initializers after setting flags..
  • Moved 'ctor initializer' import before import of body.
Wed, Aug 14, 2:09 AM · Restricted Project, Restricted Project

Tue, Aug 13

balazske committed rGb427c061ad10: [ASTImporter] Import additional flags for functions. (authored by balazske).
[ASTImporter] Import additional flags for functions.
Tue, Aug 13, 1:04 AM
balazske committed rL368655: [ASTImporter] Import additional flags for functions..
[ASTImporter] Import additional flags for functions.
Tue, Aug 13, 1:03 AM
balazske closed D65999: [ASTImporter] Import additional flags for functions..
Tue, Aug 13, 1:03 AM · Restricted Project, Restricted Project
balazske added inline comments to D65999: [ASTImporter] Import additional flags for functions..
Tue, Aug 13, 12:18 AM · Restricted Project, Restricted Project
balazske updated the diff for D65999: [ASTImporter] Import additional flags for functions..
  • Moved SVEBuiltins test instantiation to non-different position.
Tue, Aug 13, 12:14 AM · Restricted Project, Restricted Project

Mon, Aug 12

balazske committed rG2e16060a8bbb: [ASTImporter] Fix for import of friend class template with definition. (authored by balazske).
[ASTImporter] Fix for import of friend class template with definition.
Mon, Aug 12, 3:08 AM
balazske committed rL368551: [ASTImporter] Fix for import of friend class template with definition..
[ASTImporter] Fix for import of friend class template with definition.
Mon, Aug 12, 3:07 AM
balazske closed D65269: [ASTImporter] Fix for import of friend class template with definition..
Mon, Aug 12, 3:07 AM · Restricted Project, Restricted Project
balazske added inline comments to D65999: [ASTImporter] Import additional flags for functions..
Mon, Aug 12, 2:06 AM · Restricted Project, Restricted Project
balazske updated the diff for D65999: [ASTImporter] Import additional flags for functions..
  • Using StringRef, added comment.
Mon, Aug 12, 1:12 AM · Restricted Project, Restricted Project
balazske added inline comments to D65999: [ASTImporter] Import additional flags for functions..
Mon, Aug 12, 12:51 AM · Restricted Project, Restricted Project
balazske committed rG4b9d20008bbc: [CrossTU] Fix problem with CrossTU AST load limit and progress messages. (authored by balazske).
[CrossTU] Fix problem with CrossTU AST load limit and progress messages.
Mon, Aug 12, 12:18 AM
balazske committed rL368545: [CrossTU] Fix problem with CrossTU AST load limit and progress messages..
[CrossTU] Fix problem with CrossTU AST load limit and progress messages.
Mon, Aug 12, 12:14 AM
balazske closed D66054: [CrossTU] Fix problem with CrossTU AST load limit and progress messages..
Mon, Aug 12, 12:14 AM · Restricted Project, Restricted Project

Sun, Aug 11

balazske added a comment to D65935: [ASTImporter] Import ctor initializers after setting flags..

In this case the problem was that some of the flags of the already created and inserted ToFunction are not initialized. During the import of some "ctor initializers" this non-complete ToFunction may be accessed somehow (by structural equivalence or other code) and an assert comes because invalid value. (Maybe in the test code the second constructor is imported as "ctor initializer" during the import of the first.)

Sun, Aug 11, 11:47 PM · Restricted Project, Restricted Project

Sat, Aug 10

balazske updated the diff for D66054: [CrossTU] Fix problem with CrossTU AST load limit and progress messages..
  • [CrossTU] Fix problem with CrossTU AST load limit and progress messages.
  • Reformat.
Sat, Aug 10, 8:20 AM · Restricted Project, Restricted Project
balazske updated the diff for D65577: [ASTImporter] Import default expression of param before creating the param..

Rename of variables and reformat.

Sat, Aug 10, 8:11 AM · Restricted Project
balazske created D66054: [CrossTU] Fix problem with CrossTU AST load limit and progress messages..
Sat, Aug 10, 6:02 AM · Restricted Project, Restricted Project

Fri, Aug 9

balazske added inline comments to D65999: [ASTImporter] Import additional flags for functions..
Fri, Aug 9, 5:23 AM · Restricted Project, Restricted Project
balazske added a comment to D64753: [CrossTU][NFCI] Refactor loadExternalAST function.

I discovered that there are problems with this change. The number of loaded AST units is not incremented correctly and the "CTU loaded AST file" is displayed for every access to a AST unit (even if it was got from cache). The problem is that the counting and print of AST loads does not handle the case when the load returned a cached result (and no real loading happened). This causes "annoying" messages and the AST unit limit is not handled correctly.

Fri, Aug 9, 4:13 AM · Restricted Project, Restricted Project
Herald added a reviewer for D65999: [ASTImporter] Import additional flags for functions.: a.sidorin.
Fri, Aug 9, 3:24 AM · Restricted Project, Restricted Project

Thu, Aug 8

balazske added a comment to D65577: [ASTImporter] Import default expression of param before creating the param..

Yes importing the parameters should be doable after the create of the function. I am not sure if it fixes this problem, the parameter that has the default expression can still be encountered without the default expression set in it.

Thu, Aug 8, 7:38 AM · Restricted Project
balazske added inline comments to D65577: [ASTImporter] Import default expression of param before creating the param..
Thu, Aug 8, 7:31 AM · Restricted Project
Herald added a reviewer for D65935: [ASTImporter] Import ctor initializers after setting flags.: a.sidorin.
Thu, Aug 8, 3:27 AM · Restricted Project, Restricted Project

Wed, Aug 7

balazske committed rGe9719f9e9e96: [ASTImporter] Do not import FunctionTemplateDecl in record twice. (authored by balazske).
[ASTImporter] Do not import FunctionTemplateDecl in record twice.
Wed, Aug 7, 5:40 AM
balazske committed rL368163: [ASTImporter] Do not import FunctionTemplateDecl in record twice..
[ASTImporter] Do not import FunctionTemplateDecl in record twice.
Wed, Aug 7, 5:40 AM
balazske closed D65203: [ASTImporter] Do not import FunctionTemplateDecl in record twice..
Wed, Aug 7, 5:40 AM · Restricted Project, Restricted Project

Tue, Aug 6

balazske committed rG4e79097dc7c3: [CrossTU] Handle case when no USR could be generated during Decl search. (authored by balazske).
[CrossTU] Handle case when no USR could be generated during Decl search.
Tue, Aug 6, 5:10 AM
balazske committed rL368020: [CrossTU] Handle case when no USR could be generated during Decl search..
[CrossTU] Handle case when no USR could be generated during Decl search.
Tue, Aug 6, 5:10 AM
balazske closed D65445: [CrossTU] Handle case when no USR could be generated during Decl search..
Tue, Aug 6, 5:10 AM · Restricted Project, Restricted Project
balazske updated the diff for D65445: [CrossTU] Handle case when no USR could be generated during Decl search..

Rebase.

Tue, Aug 6, 3:49 AM · Restricted Project, Restricted Project
balazske updated the diff for D65577: [ASTImporter] Import default expression of param before creating the param..

Small but important fix.

Tue, Aug 6, 3:10 AM · Restricted Project
balazske updated the diff for D65577: [ASTImporter] Import default expression of param before creating the param..

A new kind of solution, the previous does not work always.
Still no test for this new problem case (circular dependency between a ParmVarDecl and function of it and a CXXDefaultArgExpr that references to the function probably by UsedContext).

Tue, Aug 6, 2:23 AM · Restricted Project

Fri, Aug 2

balazske updated the diff for D65445: [CrossTU] Handle case when no USR could be generated during Decl search..

Rebase and add a new testing case.

Fri, Aug 2, 1:28 AM · Restricted Project, Restricted Project
balazske added inline comments to D65577: [ASTImporter] Import default expression of param before creating the param..
Fri, Aug 2, 12:25 AM · Restricted Project

Thu, Aug 1

Herald added a reviewer for D65577: [ASTImporter] Import default expression of param before creating the param.: a.sidorin.
Thu, Aug 1, 7:16 AM · Restricted Project

Wed, Jul 31

balazske added a comment to D65445: [CrossTU] Handle case when no USR could be generated during Decl search..

Probably this is a problem case too but only if the f or i has an initializer expression and really no USR is generated for f or i. But what I have found is that there is a VarDecl for a "invisible" variable whose type is the anonymous union and it has a (default) initializer too. If the search reaches DC of the f it will try to get the USR for this variable.

Wed, Jul 31, 6:35 AM · Restricted Project, Restricted Project

Tue, Jul 30

balazske added a comment to D65445: [CrossTU] Handle case when no USR could be generated during Decl search..

It looks like that the problem can happen when the anonymous union is in any DeclContext and for CTU import the import of a variable is requested and that variable is in a related DeclContext (it can be at upper or lower level). (See code of findDefInDeclContext: If used for variables, it goes through every DeclContext and computes USR for specific VarDecls until the one is found. If we have luck it may be found before the union. An anonymous union can not be imported because we get no USR for it so it is OK to ignore these.) So the test can be written in many other forms but this case (the code of f) was encountered in protobuf code.

Tue, Jul 30, 11:43 PM · Restricted Project, Restricted Project
balazske created D65445: [CrossTU] Handle case when no USR could be generated during Decl search..
Tue, Jul 30, 6:19 AM · Restricted Project, Restricted Project

Thu, Jul 25

balazske updated the diff for D65203: [ASTImporter] Do not import FunctionTemplateDecl in record twice..

Added missing test fixture, removed not a related change.

Thu, Jul 25, 7:02 AM · Restricted Project, Restricted Project
balazske added a comment to D64638: [CrossTU] Fix plist macro expansion if macro in other file..

Problem should be fixed now (r367013).

Thu, Jul 25, 5:53 AM · Restricted Project, Restricted Project
balazske committed rGf34da181d273: Fix failing test plist-macros-with-expansion-ctu.c (authored by balazske).
Fix failing test plist-macros-with-expansion-ctu.c
Thu, Jul 25, 5:49 AM
balazske committed rL367013: Fix failing test plist-macros-with-expansion-ctu.c.
Fix failing test plist-macros-with-expansion-ctu.c
Thu, Jul 25, 5:49 AM
balazske committed rGaeac909329a7: [CrossTU] Fix plist macro expansion if macro in other file. (authored by balazske).
[CrossTU] Fix plist macro expansion if macro in other file.
Thu, Jul 25, 3:55 AM
balazske committed rL367006: [CrossTU] Fix plist macro expansion if macro in other file..
[CrossTU] Fix plist macro expansion if macro in other file.
Thu, Jul 25, 3:52 AM
balazske closed D64638: [CrossTU] Fix plist macro expansion if macro in other file..
Thu, Jul 25, 3:52 AM · Restricted Project, Restricted Project
Herald added a reviewer for D65269: [ASTImporter] Fix for import of friend class template with definition.: a.sidorin.
Thu, Jul 25, 2:29 AM · Restricted Project, Restricted Project
balazske updated the diff for D64638: [CrossTU] Fix plist macro expansion if macro in other file..

Added clangFrontend to CMakeLists.txt.

Thu, Jul 25, 1:27 AM · Restricted Project, Restricted Project

Wed, Jul 24

balazske abandoned D64628: [CrossTU] Test change only: improve ctu-main.c.
Wed, Jul 24, 5:39 AM · Restricted Project
Herald added a reviewer for D65203: [ASTImporter] Do not import FunctionTemplateDecl in record twice.: a.sidorin.
Wed, Jul 24, 5:35 AM · Restricted Project, Restricted Project
balazske added a comment to D64638: [CrossTU] Fix plist macro expansion if macro in other file..

The Frontend is needed because "ASTUnit.h" is added now into PlistDiagnostics.cpp. The ASTUnit object is used to pass information out from getImportedFromSourceLocation. The StaticAnalyzerCore library uses CrossTU library, and CrossTU uses Frontend, so I think it may be not a problem if StaticAnalyzerCore will use directly Frontend. Otherwise the getImportedFromSourceLocation can return the Preprocessor (and ASTContext) (in a tuple) instead of an ASTUnit and use of ASTUnit is not needed. (Patch in D65064 contains a test that does work only if the TranslationUnitDecl of the imported-from AST is known, to get this value an ASTUnit or ASTContext must be returned from getImportedFromSourceLocation.)

Wed, Jul 24, 5:30 AM · Restricted Project, Restricted Project
balazske committed rGd22f877356ad: [CrossTU] Add a function to retrieve original source location. (authored by balazske).
[CrossTU] Add a function to retrieve original source location.
Wed, Jul 24, 3:18 AM
balazske committed rL366884: [CrossTU] Add a function to retrieve original source location..
[CrossTU] Add a function to retrieve original source location.
Wed, Jul 24, 3:16 AM
balazske closed D65064: [CrossTU] Add a function to retrieve original source location..
Wed, Jul 24, 3:16 AM · Restricted Project, Restricted Project
balazske updated the diff for D65064: [CrossTU] Add a function to retrieve original source location..

Update diff to one commit with all changes.

Wed, Jul 24, 3:05 AM · Restricted Project, Restricted Project

Jul 23 2019

balazske added a comment to D64638: [CrossTU] Fix plist macro expansion if macro in other file..

Maybe CrossTU should not use the Frontend library? (Now the StaticAnalyzerCore is using CrossTU and CrossTU is using Frontend, in this way StaticAnalyzerCore could use Frontend too.)

Jul 23 2019, 8:05 AM · Restricted Project, Restricted Project
balazske added inline comments to D65064: [CrossTU] Add a function to retrieve original source location..
Jul 23 2019, 7:27 AM · Restricted Project, Restricted Project
balazske added a comment to D64638: [CrossTU] Fix plist macro expansion if macro in other file..

It is possible to use the Preprocessor instead of ASTUnit in getImportedFromSourceLocation. But this will contain less useful (even if currently not used) information. The test extension in D65064 is not possible to do if not ASTUnit is used. (Or a tuple must be used that contains Preprocessor and TranslationUnitDecl and maybe other objects that are stored in the ASTUnit.)

Jul 23 2019, 7:16 AM · Restricted Project, Restricted Project
balazske committed rG739a93558f8c: PlistDiagnostics Fix for compile warning (NFC). (authored by balazske).
PlistDiagnostics Fix for compile warning (NFC).
Jul 23 2019, 3:22 AM
balazske committed rL366792: PlistDiagnostics Fix for compile warning (NFC)..
PlistDiagnostics Fix for compile warning (NFC).
Jul 23 2019, 3:21 AM
balazske committed rG32f220c5fbe5: [CrossTU] Added CTU argument to diagnostic consumer create fn. (authored by balazske).
[CrossTU] Added CTU argument to diagnostic consumer create fn.
Jul 23 2019, 12:06 AM
balazske committed rL366782: [CrossTU] Added CTU argument to diagnostic consumer create fn..
[CrossTU] Added CTU argument to diagnostic consumer create fn.
Jul 23 2019, 12:05 AM
balazske closed D64635: [CrossTU] Added CTU argument to diagnostic consumer create fn..
Jul 23 2019, 12:05 AM · Restricted Project, Restricted Project

Jul 22 2019

balazske added inline comments to D65064: [CrossTU] Add a function to retrieve original source location..
Jul 22 2019, 5:47 AM · Restricted Project, Restricted Project
balazske updated the diff for D65064: [CrossTU] Add a function to retrieve original source location..

Removed ASTImporter from "callback" function.

Jul 22 2019, 5:46 AM · Restricted Project, Restricted Project
balazske added a comment to D64554: [CrossTU] Add a function to retrieve original source location..

New patch:
https://reviews.llvm.org/D65064

Jul 22 2019, 12:50 AM · Restricted Project, Restricted Project
balazske added a child revision for D65064: [CrossTU] Add a function to retrieve original source location.: D64638: [CrossTU] Fix plist macro expansion if macro in other file..
Jul 22 2019, 12:44 AM · Restricted Project, Restricted Project
balazske added a parent revision for D64638: [CrossTU] Fix plist macro expansion if macro in other file.: D65064: [CrossTU] Add a function to retrieve original source location..
Jul 22 2019, 12:43 AM · Restricted Project, Restricted Project
balazske created D65064: [CrossTU] Add a function to retrieve original source location..
Jul 22 2019, 12:38 AM · Restricted Project, Restricted Project

Jul 19 2019

balazske added a reviewer for D64638: [CrossTU] Fix plist macro expansion if macro in other file.: ilya-biryukov.

@ilya-biryukov Please check if it is acceptable to use ASTUnit in PlistDiagnostic.cpp.

Jul 19 2019, 4:10 AM · Restricted Project, Restricted Project

Jul 18 2019

balazske added a comment to D64554: [CrossTU] Add a function to retrieve original source location..

Commit was reverted because we were not aware of that clangAST library can not use clangFrontend library. So a different solution is needed, probably pass a SourceLocation import callback to ASTImporter. (A Preprocessor that can be used in place of ASTUnit here can not be get from a SourceManager or ASTContext.) And then no ImportedFileIDs is needed in ASTImporterSharedState, instead in CrossTranslationUnitContext.

Jul 18 2019, 9:20 AM · Restricted Project, Restricted Project
balazske committed rGd2c576110ef5: [CrossTU] Add a function to retrieve original source location. (authored by balazske).
[CrossTU] Add a function to retrieve original source location.
Jul 18 2019, 8:25 AM
balazske committed rL366449: [CrossTU] Add a function to retrieve original source location..
[CrossTU] Add a function to retrieve original source location.
Jul 18 2019, 8:25 AM
balazske closed D64554: [CrossTU] Add a function to retrieve original source location..
Jul 18 2019, 8:25 AM · Restricted Project, Restricted Project
balazske added inline comments to D64554: [CrossTU] Add a function to retrieve original source location..
Jul 18 2019, 2:28 AM · Restricted Project, Restricted Project
balazske updated the diff for D64554: [CrossTU] Add a function to retrieve original source location..
  • Renamed 'Unit', changed constructors.
Jul 18 2019, 12:07 AM · Restricted Project, Restricted Project

Jul 16 2019

balazske added inline comments to D64554: [CrossTU] Add a function to retrieve original source location..
Jul 16 2019, 5:41 AM · Restricted Project, Restricted Project
balazske added inline comments to D64554: [CrossTU] Add a function to retrieve original source location..
Jul 16 2019, 3:52 AM · Restricted Project, Restricted Project

Jul 15 2019

balazske added a comment to D64628: [CrossTU] Test change only: improve ctu-main.c.

I do not know how the AST import is relevant in this case, the 'implicit' function is not imported here. The test does something similar as the mentioned one, only the reported problem is after the imported function.

Jul 15 2019, 5:30 AM · Restricted Project
balazske committed rG14d115ff98ac: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest. (authored by balazske).
[ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest.
Jul 15 2019, 5:18 AM
balazske committed rL366061: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest..
[ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest.
Jul 15 2019, 5:17 AM
balazske closed D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest..
Jul 15 2019, 5:17 AM · Restricted Project, Restricted Project
balazske added a comment to D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest..

Does it really matter if it is CXX11 or CXX14, in the child patch we use a CXX11 using directive. Anyway, CXX14 is more future proof.

Jul 15 2019, 5:06 AM · Restricted Project, Restricted Project
balazske updated the diff for D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest..
  • Change to Lang_CXX14.
Jul 15 2019, 12:37 AM · Restricted Project, Restricted Project
balazske retitled D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest. from [ASTImporter] Using Lang_CXX11 in ASTImporterVisibilityTest. to [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest..
Jul 15 2019, 12:35 AM · Restricted Project, Restricted Project