Page MenuHomePhabricator

balazske (Balázs Kéri)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
May 23 2018, 7:08 AM (209 w, 2 d)

Recent Activity

Wed, May 25

balazske updated the diff for D125400: [clang][Analyzer] Add errno state to standard functions modeling..

fixed some problems

Wed, May 25, 2:55 AM · Restricted Project, Restricted Project
balazske updated the summary of D125400: [clang][Analyzer] Add errno state to standard functions modeling..
Wed, May 25, 1:54 AM · Restricted Project, Restricted Project
balazske added inline comments to D125400: [clang][Analyzer] Add errno state to standard functions modeling..
Wed, May 25, 1:53 AM · Restricted Project, Restricted Project
balazske updated the diff for D125400: [clang][Analyzer] Add errno state to standard functions modeling..

update

Wed, May 25, 1:53 AM · Restricted Project, Restricted Project

Tue, May 24

balazske updated the diff for D125400: [clang][Analyzer] Add errno state to standard functions modeling..

added comments. added note tag, added test, improved the code

Tue, May 24, 5:35 AM · Restricted Project, Restricted Project

Fri, May 20

balazske updated the diff for D125986: [clang][ASTImporter] Add support for import of UsingPackDecl..

Use of addDeclToContexts, added new test.

Fri, May 20, 8:58 AM · Restricted Project, Restricted Project
balazske added a reviewer for D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.: martong.
Fri, May 20, 8:54 AM · Restricted Project, Restricted Project

Thu, May 19

balazske requested review of D125986: [clang][ASTImporter] Add support for import of UsingPackDecl..
Thu, May 19, 8:58 AM · Restricted Project, Restricted Project

Mon, May 16

balazske added a comment to D125400: [clang][Analyzer] Add errno state to standard functions modeling..

@martong Do you mean that a "describe" function is needed for the return value constraint of the function and for the errno constraint type? Then a note tag can contain what the function is assumed to return on success and what is allowed (or not) to do with errno. For example: "Assuming that 'mkdir' is successful, it returns zero in this case and value of 'errno' is unspecified after the call".

Mon, May 16, 8:58 AM · Restricted Project, Restricted Project

Sun, May 15

balazske added inline comments to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..
Sun, May 15, 11:58 PM · Restricted Project, Restricted Project

Fri, May 13

balazske updated the diff for D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

Using one isa statement for all class names.
Changed the documentation.

Fri, May 13, 5:09 AM · Restricted Project, Restricted Project

Thu, May 12

balazske added reviewers for D125400: [clang][Analyzer] Add errno state to standard functions modeling.: martong, NoQ.
Thu, May 12, 7:08 AM · Restricted Project, Restricted Project
balazske added a comment to D125400: [clang][Analyzer] Add errno state to standard functions modeling..

Function mkdir is modeled incorrectly by the checker. According to the man page it can return 0 or -1 only (-1 is error) but the checker allows non-negative value at success. So the shown bug report is incorrect (it can be only -1 if not 0 and then check of errno is allowed). Anyway the note tags should be added to every function.

Thu, May 12, 7:07 AM · Restricted Project, Restricted Project
balazske added a comment to D125340: [clang][NFC][AST] rename the ImportError to ASTImportError.

LLDB should be at least compilable after the change. If it has an internal ImportError we must not change it. If it uses the renamed class we should rename it, or make an "using" alias and no rename (but not this is the best solution).

Thu, May 12, 12:20 AM · Restricted Project, Restricted Project

Wed, May 11

balazske requested review of D125400: [clang][Analyzer] Add errno state to standard functions modeling..
Wed, May 11, 9:37 AM · Restricted Project, Restricted Project
balazske added a comment to D125362: [NFC][analyzer] Transitive interestingness in BugReporter.

Is it problem if markNotInteresting is used on a symbol that was marked interesting and has subregions?

Wed, May 11, 9:13 AM · Restricted Project, Restricted Project
balazske added a comment to D125340: [clang][NFC][AST] rename the ImportError to ASTImportError.

I found one other place in LibASTImporter.rst where ImportError is used. LLDB should be checked too.

Wed, May 11, 7:24 AM · Restricted Project, Restricted Project
balazske added a comment to D125340: [clang][NFC][AST] rename the ImportError to ASTImportError.

Initially the ImportError was very related to ASTImporter but now the class is used at other less related places and files. ImportError is a too generic name for this unless it can be used at any other "import" in clang which is not the case (the class can be extended with other special data about the import error). Maybe the whole ASTImporter should go into a new namespace, specially if ASTImporter.cpp would be split into parts?

Wed, May 11, 7:18 AM · Restricted Project, Restricted Project

Thu, May 5

balazske added a comment to D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header..

The code looks correct but the diff is not OK. I think that you have separate commits for every change (instead of changing the first with git commit --amend when a new change is made). In this case arc diff --update <ID> main may work (if you have a separate branch for the changes). (I did not found a place in LLVM docs where this part of the process is exactly described.)

Thu, May 5, 7:12 AM · Restricted Project, Restricted Project
balazske added a comment to D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header..

It looks mostly good now, apart from the line 1 comment problem. Usually in a review all phabricator diffs are created against the original commit or at least against an existing (in the current github repository) commit, here the last diff seems to be against an other commit. The next diff should be based on an existing commit (can be same as the original base). Otherwise the arc patch command may not work (I do not know if you use it) and it is difficult to compare changes related to the original code.

Thu, May 5, 12:46 AM · Restricted Project, Restricted Project

Wed, May 4

balazske added inline comments to D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header..
Wed, May 4, 1:05 AM · Restricted Project, Restricted Project
balazske added inline comments to D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header..
Wed, May 4, 12:34 AM · Restricted Project, Restricted Project

Mon, May 2

balazske added a comment to D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header..

A better title: "Move clang::ImportError into own header and rename it (NFC)."

Mon, May 2, 11:46 PM · Restricted Project, Restricted Project
balazske added a comment to D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header..

The ASTImporterLookupTable was not dependent on the ImportError so the header should not be included in that file. It is better in ASTImporterSharedState.h. Alternative solution is to add class ASTImportError into ASTImporterSharedState.h (no new header is needed) and use this file from ASTImporter.h.

Mon, May 2, 11:44 PM · Restricted Project, Restricted Project

Thu, Apr 28

balazske updated the diff for D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

Applied the review comments.

Thu, Apr 28, 5:44 AM · Restricted Project, Restricted Project
balazske added inline comments to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..
Thu, Apr 28, 4:01 AM · Restricted Project, Restricted Project

Apr 13 2022

balazske committed rG596752863e27: [clang][ASTImporter] Fix an import error handling related bug. (authored by balazske).
[clang][ASTImporter] Fix an import error handling related bug.
Apr 13 2022, 1:13 AM · Restricted Project, Restricted Project
balazske closed D122525: [clang][ASTImporter] Fix an import error handling related bug..
Apr 13 2022, 1:12 AM · Restricted Project, Restricted Project
balazske updated the diff for D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

Rebase to newer 'main' branch.

Apr 13 2022, 12:34 AM · Restricted Project, Restricted Project

Apr 12 2022

balazske updated the diff for D122525: [clang][ASTImporter] Fix an import error handling related bug..

Created a common place for the DeclContext child error handling code.

Apr 12 2022, 1:18 AM · Restricted Project, Restricted Project
balazske committed rG2b6e5fa62b80: [clang][ASTImporter] Add import of attribute 'enable_if'. (authored by balazske).
[clang][ASTImporter] Add import of attribute 'enable_if'.
Apr 12 2022, 1:04 AM · Restricted Project, Restricted Project
balazske closed D123397: [clang][ASTImporter] Add import of attribute 'enable_if'..
Apr 12 2022, 1:04 AM · Restricted Project, Restricted Project

Apr 11 2022

balazske added a reviewer for D123397: [clang][ASTImporter] Add import of attribute 'enable_if'.: martong.
Apr 11 2022, 12:58 AM · Restricted Project, Restricted Project

Apr 8 2022

balazske requested review of D123397: [clang][ASTImporter] Add import of attribute 'enable_if'..
Apr 8 2022, 8:54 AM · Restricted Project, Restricted Project

Apr 7 2022

balazske committed rG5479174071ec: [clang][ASTImporter] Not using consumeError at failed import of in-class… (authored by balazske).
[clang][ASTImporter] Not using consumeError at failed import of in-class…
Apr 7 2022, 2:08 AM · Restricted Project, Restricted Project
balazske closed D122528: [clang][ASTImporter] Not using consumeError at failed import of in-class initializer..
Apr 7 2022, 2:08 AM · Restricted Project, Restricted Project
balazske committed rGcc7ed0caaca5: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring. (authored by balazske).
[clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.
Apr 7 2022, 12:40 AM · Restricted Project, Restricted Project
balazske closed D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring..
Apr 7 2022, 12:40 AM · Restricted Project, Restricted Project

Apr 6 2022

balazske updated the diff for D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

Removed a left comment and improved another comment.

Apr 6 2022, 11:56 PM · Restricted Project, Restricted Project
balazske added inline comments to D122525: [clang][ASTImporter] Fix an import error handling related bug..
Apr 6 2022, 7:41 AM · Restricted Project, Restricted Project
balazske added inline comments to D122285: [analyzer] Add path note tags to standard library function summaries..
Apr 6 2022, 2:52 AM · Restricted Project, Restricted Project

Mar 29 2022

balazske added inline comments to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..
Mar 29 2022, 8:04 AM · Restricted Project, Restricted Project
balazske added a comment to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

Code is updated, documentation (rst) not yet. I want to use \ format of tags in the code comments. Many review comments are now out of place (because the list of functions was moved around in the file.)

Mar 29 2022, 8:01 AM · Restricted Project, Restricted Project
balazske updated the diff for D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

rebase, applied the review comments

Mar 29 2022, 7:50 AM · Restricted Project, Restricted Project

Mar 28 2022

balazske added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

I found only small issues.

Mar 28 2022, 3:49 AM · Restricted Project, Restricted Project, Restricted Project
balazske committed rGc5d83cdca457: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr. (authored by balazske).
[clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.
Mar 28 2022, 1:56 AM · Restricted Project, Restricted Project
balazske closed D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr..
Mar 28 2022, 1:55 AM · Restricted Project, Restricted Project

Mar 26 2022

balazske added a reviewer for D122528: [clang][ASTImporter] Not using consumeError at failed import of in-class initializer.: martong.

I wanted to remove this one instance of consumeError because the change in D122525, to ensure that consumeError is called really only from ImportDeclContext (and other places where it is not relevant).

Mar 26 2022, 8:38 AM · Restricted Project, Restricted Project
balazske requested review of D122528: [clang][ASTImporter] Not using consumeError at failed import of in-class initializer..
Mar 26 2022, 8:33 AM · Restricted Project, Restricted Project
balazske added a reviewer for D122525: [clang][ASTImporter] Fix an import error handling related bug.: martong.
Mar 26 2022, 3:20 AM · Restricted Project, Restricted Project
balazske requested review of D122525: [clang][ASTImporter] Fix an import error handling related bug..
Mar 26 2022, 3:10 AM · Restricted Project, Restricted Project

Mar 25 2022

balazske added a comment to D122150: [clang][analyzer] Add checker for bad use of 'errno'..

This errno check will work if a state split is added at every standard function that may set errno at failure. (The success and failure branches have different errno check state, and probably different return value for the function.) Probably this is too many state splits. But a correct program should have anyway checks for the return value that make the same state splits.

Mar 25 2022, 8:47 AM · Restricted Project, Restricted Project
balazske added inline comments to D122150: [clang][analyzer] Add checker for bad use of 'errno'..
Mar 25 2022, 8:37 AM · Restricted Project, Restricted Project
balazske updated the diff for D122150: [clang][analyzer] Add checker for bad use of 'errno'..

Address review comments.

  • Removed caching of errno-related values from the checker.
  • Added note tags.
  • Added documentation comments.
Mar 25 2022, 8:34 AM · Restricted Project, Restricted Project

Mar 22 2022

balazske added a comment to D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr..

Ping
I had a question about if the lit-test is needed with the new unit tests (that contain essentially similar code). But if there is no answer I will commit it with all tests, more test is always better.

Mar 22 2022, 3:12 AM · Restricted Project, Restricted Project
balazske added reviewers for D122150: [clang][analyzer] Add checker for bad use of 'errno'.: martong, steakhal, NoQ.

This checker is made to add a partial support for CERT rule ERR30-C . One part of the rule is "check errno only after the function returns a value indicating failure".

Mar 22 2022, 2:35 AM · Restricted Project, Restricted Project
Herald added a project to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.: Restricted Project.
Mar 22 2022, 1:31 AM · Restricted Project, Restricted Project

Mar 21 2022

balazske requested review of D122150: [clang][analyzer] Add checker for bad use of 'errno'..
Mar 21 2022, 8:30 AM · Restricted Project, Restricted Project

Mar 18 2022

balazske updated the diff for D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring..

Additional documentation related fixes.

Mar 18 2022, 3:08 AM · Restricted Project, Restricted Project
balazske updated the diff for D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring..

Applied the review proposals.
Changed "system call" to "standard function".
Put the string lists into constant std::initializer_list.

Mar 18 2022, 2:00 AM · Restricted Project, Restricted Project

Mar 11 2022

balazske added a comment to D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr..

The last unit test is not much different from the lit test, I could not find more simple code to get the wanted result. Is it still good to have the lit test too?

Mar 11 2022, 6:12 AM · Restricted Project, Restricted Project
balazske updated the diff for D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr..

Added unit tests.

Mar 11 2022, 6:05 AM · Restricted Project, Restricted Project

Mar 9 2022

balazske added a comment to D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr..

I think that the problem may be related to the fact that the in-class initializer is not used by the code in the "To" AST (in ctu-cxxdefaultinitexpr.cpp the problem is with QMultiHash::d field). Probably the expression node in the field is set only if it is used by any CXXDefaultInitExpr, but the hasInClassInitializer value is set always if the code contains in-class initializer. I can try to make a unit test for this case (but the lit test is good to have because it is more complex and can reveal other problems).

Mar 9 2022, 3:09 AM · Restricted Project, Restricted Project
balazske added a comment to D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr..

So, my understanding is that the issue stems from the fact that hasInClassInitializer() gave inconsistent results with getInClassInitializer() for previously imported nodes.

Not really the API is the problem. The real problem was that to create a CXXDefaultInitExpr the field should have a "in-class initializer". CXXDefaultInitExpr has a pointer to the field that is initialized at that place. The field has an "in-class initializer", this is the used expression to initialize the field (CXXDefaultInitExpr is a separate object that is replicated for every initialization in constructors and initializer-list). The in-class initializer expression is not always stored in the AST, in the ToTU it is missing initially. The field has the flag set that it contains in-class initializer but the actual expression is not set yet (probably because the code parser works this way). This expression should be imported before a CXXDefaultInitExpr can be created.

Mar 9 2022, 2:24 AM · Restricted Project, Restricted Project

Mar 8 2022

balazske added a reviewer for D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.: martong.
Mar 8 2022, 2:06 AM · Restricted Project, Restricted Project

Mar 3 2022

balazske updated the diff for D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr..

Improved the test to fix failure on Windows.

Mar 3 2022, 3:57 AM · Restricted Project, Restricted Project
Herald added a project to D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.: Restricted Project.
Mar 3 2022, 2:03 AM · Restricted Project, Restricted Project

Mar 2 2022

balazske requested review of D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr..
Mar 2 2022, 8:40 AM · Restricted Project, Restricted Project

Feb 28 2022

balazske committed rGd8a2afb244da: [clang][analyzer] Add modeling of 'errno'. (authored by balazske).
[clang][analyzer] Add modeling of 'errno'.
Feb 28 2022, 11:22 PM
balazske closed D120310: [clang][analyzer] Add modeling of 'errno'..
Feb 28 2022, 11:22 PM · Restricted Project
balazske added a comment to D120310: [clang][analyzer] Add modeling of 'errno'..

The current build errors are probably not related, the Windows test failure shows up in other differential objects.

Feb 28 2022, 5:14 AM · Restricted Project
balazske updated the diff for D120310: [clang][analyzer] Add modeling of 'errno'..

Removed the static variable.

Feb 28 2022, 12:49 AM · Restricted Project

Feb 25 2022

balazske updated the diff for D120310: [clang][analyzer] Add modeling of 'errno'..

Another try to fix the test failures, rebased to current main.

Feb 25 2022, 8:04 AM · Restricted Project
balazske added a comment to D120310: [clang][analyzer] Add modeling of 'errno'..

The "hip-link-bundle-archive" test looks really unrelated, the others are fixed if we go back to -DERRNO_VAR (no " characters in command line, and probably / does not work too). There are Debian build errors but these look unrelated(?).

Feb 25 2022, 7:52 AM · Restricted Project
balazske updated the diff for D120310: [clang][analyzer] Add modeling of 'errno'..

Rename of "Errno.h", maybe fixes Windows build problem.

Feb 25 2022, 6:14 AM · Restricted Project
balazske reopened D120310: [clang][analyzer] Add modeling of 'errno'..
Feb 25 2022, 6:13 AM · Restricted Project
balazske committed rG29b512ba322c: [clang][analyzer] Add modeling of 'errno'. (authored by balazske).
[clang][analyzer] Add modeling of 'errno'.
Feb 25 2022, 3:44 AM
balazske closed D120310: [clang][analyzer] Add modeling of 'errno'..
Feb 25 2022, 3:44 AM · Restricted Project
balazske updated the diff for D120310: [clang][analyzer] Add modeling of 'errno'..

Fixed remaining problems.

Feb 25 2022, 2:51 AM · Restricted Project
balazske added inline comments to D120310: [clang][analyzer] Add modeling of 'errno'..
Feb 25 2022, 12:28 AM · Restricted Project
balazske updated the diff for D120310: [clang][analyzer] Add modeling of 'errno'..

Removed isErrnoAvailable, added test for getErrnoValue.

Feb 25 2022, 12:27 AM · Restricted Project

Feb 24 2022

balazske updated the diff for D120310: [clang][analyzer] Add modeling of 'errno'..

Changed name of the checker to ErrnoModeling, other small cleanup.

Feb 24 2022, 8:50 AM · Restricted Project
balazske retitled D120310: [clang][analyzer] Add modeling of 'errno'. from [clang][analyzer] Add modeling of 'errno' (work-in-progress). to [clang][analyzer] Add modeling of 'errno'..
Feb 24 2022, 7:46 AM · Restricted Project
balazske added inline comments to D120310: [clang][analyzer] Add modeling of 'errno'..
Feb 24 2022, 7:46 AM · Restricted Project
balazske updated the diff for D120310: [clang][analyzer] Add modeling of 'errno'..

Improved the tests.

Feb 24 2022, 7:40 AM · Restricted Project
balazske added a reviewer for D119675: Also remove the empty StoredDeclsList entry from the lookup table: martong.
Feb 24 2022, 5:39 AM · Restricted Project, Restricted Project
balazske updated the diff for D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring..

Applied review comments, fixed the failing tests.

Feb 24 2022, 1:59 AM · Restricted Project, Restricted Project

Feb 23 2022

balazske added inline comments to D120310: [clang][analyzer] Add modeling of 'errno'..
Feb 23 2022, 7:44 AM · Restricted Project
balazske updated the diff for D120310: [clang][analyzer] Add modeling of 'errno'..

Addressed a part of the review comments.
The test checker is now a separate checker.
Initialization is simplified, checkASTDecl is used.

Feb 23 2022, 7:39 AM · Restricted Project

Feb 22 2022

balazske abandoned D91164: [clang-tidy] Improve C++ support in bugprone-signal-handler..

Newer revision: D118996

Feb 22 2022, 2:06 AM · Restricted Project, Restricted Project
balazske added reviewers for D120310: [clang][analyzer] Add modeling of 'errno'.: NoQ, steakhal, martong.

Documentation not added yet.

Feb 22 2022, 1:16 AM · Restricted Project
balazske requested review of D120310: [clang][analyzer] Add modeling of 'errno'..
Feb 22 2022, 1:08 AM · Restricted Project

Feb 15 2022

balazske added a comment to D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring..

ping

Feb 15 2022, 6:16 AM · Restricted Project, Restricted Project

Feb 13 2022

balazske committed rG83028ad934d6: [clang][AST][ASTImporter] Set record to complete during import of its members. (authored by balazske).
[clang][AST][ASTImporter] Set record to complete during import of its members.
Feb 13 2022, 11:28 PM
balazske closed D116155: [clang][AST][ASTImporter] Set record to complete during import of its members..
Feb 13 2022, 11:28 PM · Restricted Project

Feb 11 2022

balazske updated the diff for D116155: [clang][AST][ASTImporter] Set record to complete during import of its members..

Rebase.

Feb 11 2022, 6:13 AM · Restricted Project
balazske added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Now it would be better to have a checker called UnsafeFunctionsCheck (probably in bugprone) and add the cert checkers "msc24-c" and "msc33-c" as aliases. This makes the check extendable if more (CERT rule related or not) cases for unsafe functions are added.

Feb 11 2022, 3:43 AM · Restricted Project, Restricted Project, Restricted Project
balazske updated the diff for D116155: [clang][AST][ASTImporter] Set record to complete during import of its members..

Fix of test failures.

Feb 11 2022, 3:00 AM · Restricted Project

Feb 8 2022

balazske added a comment to D116155: [clang][AST][ASTImporter] Set record to complete during import of its members..

(The current code does not work, the mentioned fixes must be applied first.)

Feb 8 2022, 12:19 AM · Restricted Project
balazske added a comment to D116155: [clang][AST][ASTImporter] Set record to complete during import of its members..

@martong Ping
We do not have possibility currently to check all LLDB tests. I think we can commit this and observe the buildbots for failure.

Feb 8 2022, 12:13 AM · Restricted Project