Page MenuHomePhabricator

balazske (Balázs Kéri)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
May 23 2018, 7:08 AM (73 w, 6 d)

Recent Activity

Yesterday

balazske added a comment to D67543: [Clang][ASTImporter] Added visibility check for ClassTemplateDecl..

Ping

Mon, Oct 21, 1:47 AM · Restricted Project

Fri, Oct 18

balazske updated the diff for D67545: [clang-tidy] Added DefaultOperatorNewCheck..
  • Fixes from review comments, added C++ version test.
Fri, Oct 18, 8:00 AM · Restricted Project

Fri, Oct 11

balazske added inline comments to D67706: [clang][analyzer] Using CallDescription in StreamChecker..
Fri, Oct 11, 8:51 AM · Restricted Project
balazske added a comment to D67706: [clang][analyzer] Using CallDescription in StreamChecker..

Ping

Fri, Oct 11, 7:27 AM · Restricted Project

Thu, Oct 10

balazske committed rL374368: Request commit access for balazske.
Request commit access for balazske
Thu, Oct 10, 8:33 AM

Wed, Oct 2

balazske updated the diff for D67706: [clang][analyzer] Using CallDescription in StreamChecker..
  • Re-design of eval functions.
  • Added a C++ test with fopen-looking function.
Wed, Oct 2, 3:40 AM · Restricted Project

Tue, Oct 1

balazske added inline comments to D67706: [clang][analyzer] Using CallDescription in StreamChecker..
Tue, Oct 1, 7:59 AM · Restricted Project
balazske added inline comments to D67706: [clang][analyzer] Using CallDescription in StreamChecker..
Tue, Oct 1, 6:29 AM · Restricted Project
balazske updated the diff for D67706: [clang][analyzer] Using CallDescription in StreamChecker..
  • Various code cleanups. Eval functions use CallEvent, CallExpr is removed from state.
Tue, Oct 1, 2:26 AM · Restricted Project

Mon, Sep 30

balazske added inline comments to D67706: [clang][analyzer] Using CallDescription in StreamChecker..
Mon, Sep 30, 3:58 AM · Restricted Project

Fri, Sep 27

balazske updated the diff for D67545: [clang-tidy] Added DefaultOperatorNewCheck..
  • Rename to DefaultOperatorNewAlignmentCheck.
Fri, Sep 27, 6:21 AM · Restricted Project
balazske updated the diff for D67706: [clang][analyzer] Using CallDescription in StreamChecker..

Using CallDescriptionMap.

Fri, Sep 27, 5:16 AM · Restricted Project

Sep 18 2019

balazske added inline comments to D67545: [clang-tidy] Added DefaultOperatorNewCheck..
Sep 18 2019, 7:49 AM · Restricted Project
balazske created D67706: [clang][analyzer] Using CallDescription in StreamChecker..
Sep 18 2019, 6:50 AM · Restricted Project
balazske abandoned D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker..

I try to improve StreamChecker instead.

Sep 18 2019, 2:49 AM · Restricted Project
balazske updated the diff for D67545: [clang-tidy] Added DefaultOperatorNewCheck..

Fixed the test, fixed problems in list.rst.

Sep 18 2019, 2:15 AM · Restricted Project
balazske updated the diff for D67545: [clang-tidy] Added DefaultOperatorNewCheck..

Rebase and update according to comments.
C++17 related changes not implemented yet (possible check for the called allocation function).

Sep 18 2019, 2:03 AM · Restricted Project

Sep 17 2019

balazske added inline comments to D67545: [clang-tidy] Added DefaultOperatorNewCheck..
Sep 17 2019, 8:01 AM · Restricted Project
balazske accepted D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies.
Sep 17 2019, 7:10 AM · Restricted Project, Restricted Project
balazske added inline comments to D67545: [clang-tidy] Added DefaultOperatorNewCheck..
Sep 17 2019, 2:03 AM · Restricted Project
balazske added inline comments to D67545: [clang-tidy] Added DefaultOperatorNewCheck..
Sep 17 2019, 1:08 AM · Restricted Project

Sep 16 2019

balazske added a comment to D67545: [clang-tidy] Added DefaultOperatorNewCheck..

C++17 makes things more difficult because the align is probably handled by operator new, probably not, depending on the defined allocation functions. This can be observed only with a non clang-tidy checker (we could compute the used alignment?). Probably the CERT rule is from the time before C++17. It looks like that by default the alignment is handled correctly in C++17 so the whole check is out of scope for that language version.

Sep 16 2019, 11:53 PM · Restricted Project
balazske added inline comments to D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies.
Sep 16 2019, 12:54 AM · Restricted Project, Restricted Project

Sep 13 2019

balazske created D67545: [clang-tidy] Added DefaultOperatorNewCheck..
Sep 13 2019, 4:04 AM · Restricted Project
Herald added a reviewer for D67543: [Clang][ASTImporter] Added visibility check for ClassTemplateDecl.: a.sidorin.
Sep 13 2019, 3:37 AM · Restricted Project
balazske committed rGf8a89c8fa7fe: [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl. (authored by balazske).
[Clang][ASTImporter] Added visibility check for FunctionTemplateDecl.
Sep 13 2019, 1:05 AM
balazske committed rL371820: [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl..
[Clang][ASTImporter] Added visibility check for FunctionTemplateDecl.
Sep 13 2019, 1:04 AM
balazske closed D67490: [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl..
Sep 13 2019, 1:04 AM · Restricted Project, Restricted Project
balazske added a comment to D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker..

Code of StreamChecker does not look much better, it uses deprecated eval::Call and does not check for escape. But it handles more functions and error at open (still not freopen). A mixture of both would be a better option.

Sep 13 2019, 12:12 AM · Restricted Project

Sep 12 2019

Herald added a reviewer for D67490: [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl.: a.sidorin.
Sep 12 2019, 3:55 AM · Restricted Project, Restricted Project

Sep 11 2019

balazske created D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker..
Sep 11 2019, 11:51 PM · Restricted Project

Sep 6 2019

balazske added a comment to D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies.

OK
Probably the ClassTemplateSpec can not be handled in liberal way because the AST data structure for template specializations do not allow multiple instances with same argument values?

Sep 6 2019, 7:25 AM · Restricted Project, Restricted Project
balazske added inline comments to D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies.
Sep 6 2019, 6:15 AM · Restricted Project, Restricted Project

Sep 5 2019

balazske committed rGcaa42792f33d: Rename of constants in ASTImporterVisibilityTest. NFC. (authored by balazske).
Rename of constants in ASTImporterVisibilityTest. NFC.
Sep 5 2019, 1:00 AM
balazske committed rL371021: Rename of constants in ASTImporterVisibilityTest. NFC..
Rename of constants in ASTImporterVisibilityTest. NFC.
Sep 5 2019, 12:58 AM
balazske closed D67174: Rename of constants in ASTImporterVisibilityTest. NFC..
Sep 5 2019, 12:58 AM · Restricted Project, Restricted Project

Sep 4 2019

balazske added a comment to D64480: [ASTImporter] Added visibility context check for TypedefNameDecl..

Rename of constants:
https://reviews.llvm.org/D67174

Sep 4 2019, 7:41 AM · Restricted Project, Restricted Project
balazske created D67174: Rename of constants in ASTImporterVisibilityTest. NFC..
Sep 4 2019, 7:39 AM · Restricted Project, Restricted Project
balazske committed rGc86d47b6b6fb: [ASTImporter] Added visibility context check for TypedefNameDecl. (authored by balazske).
[ASTImporter] Added visibility context check for TypedefNameDecl.
Sep 4 2019, 7:12 AM
balazske committed rL370903: [ASTImporter] Added visibility context check for TypedefNameDecl..
[ASTImporter] Added visibility context check for TypedefNameDecl.
Sep 4 2019, 7:12 AM
balazske closed D64480: [ASTImporter] Added visibility context check for TypedefNameDecl..
Sep 4 2019, 7:12 AM · Restricted Project, Restricted Project
balazske updated the diff for D64480: [ASTImporter] Added visibility context check for TypedefNameDecl..
  • Added comment about repeated enums in C99.
Sep 4 2019, 1:53 AM · Restricted Project, Restricted Project

Sep 3 2019

balazske added inline comments to D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies.
Sep 3 2019, 3:48 AM · Restricted Project, Restricted Project

Sep 2 2019

balazske committed rGb06b14ba8cf3: [AST] AST structural equivalence to work internally with pairs. (authored by balazske).
[AST] AST structural equivalence to work internally with pairs.
Sep 2 2019, 4:03 AM
balazske committed rL370639: [AST] AST structural equivalence to work internally with pairs..
[AST] AST structural equivalence to work internally with pairs.
Sep 2 2019, 4:03 AM
balazske closed D66538: [AST] AST structural equivalence to work internally with pairs..
Sep 2 2019, 4:03 AM · Restricted Project, Restricted Project
balazske added a comment to D64480: [ASTImporter] Added visibility context check for TypedefNameDecl..

It is worth noting that:

typedef int T;
typedef int T;

is not valid C99 see godbolt

Sep 2 2019, 2:09 AM · Restricted Project, Restricted Project
balazske updated the diff for D64480: [ASTImporter] Added visibility context check for TypedefNameDecl..
  • Removed unneeded structs.
Sep 2 2019, 1:59 AM · Restricted Project, Restricted Project
balazske updated the diff for D64480: [ASTImporter] Added visibility context check for TypedefNameDecl..

Improved the tests.

Sep 2 2019, 1:54 AM · Restricted Project, Restricted Project
balazske committed rG6e0866987949: [ASTImporter] At import of records re-order indirect fields too. (authored by balazske).
[ASTImporter] At import of records re-order indirect fields too.
Sep 2 2019, 12:19 AM
balazske committed rL370621: [ASTImporter] At import of records re-order indirect fields too..
[ASTImporter] At import of records re-order indirect fields too.
Sep 2 2019, 12:18 AM
balazske closed D66866: [ASTImporter] At import of records re-order indirect fields too..
Sep 2 2019, 12:18 AM · Restricted Project, Restricted Project

Aug 30 2019

balazske committed rGb4fd7d425858: [ASTImporter] Propagate errors during import of overridden methods. (authored by balazske).
[ASTImporter] Propagate errors during import of overridden methods.
Aug 30 2019, 3:12 AM
balazske committed rL370457: [ASTImporter] Propagate errors during import of overridden methods..
[ASTImporter] Propagate errors during import of overridden methods.
Aug 30 2019, 3:12 AM
balazske closed D66933: [ASTImporter] Propagate errors during import of overridden methods..
Aug 30 2019, 3:11 AM · Restricted Project, Restricted Project
balazske updated the diff for D66933: [ASTImporter] Propagate errors during import of overridden methods..
  • Renamed ImportOverrides, additional check in test.
Aug 30 2019, 1:57 AM · Restricted Project, Restricted Project

Aug 29 2019

balazske updated the diff for D66866: [ASTImporter] At import of records re-order indirect fields too..
  • Simplified field matcher in tests.
Aug 29 2019, 3:25 AM · Restricted Project, Restricted Project
Herald added a reviewer for D66933: [ASTImporter] Propagate errors during import of overridden methods.: a.sidorin.
Aug 29 2019, 2:58 AM · Restricted Project, Restricted Project

Aug 28 2019

Herald added a reviewer for D66866: [ASTImporter] At import of records re-order indirect fields too.: a.sidorin.
Aug 28 2019, 2:57 AM · Restricted Project, Restricted Project

Aug 26 2019

balazske updated the diff for D66538: [AST] AST structural equivalence to work internally with pairs..
  • Small update to newer C++ syntax, use std::pair in test.
Aug 26 2019, 3:26 AM · Restricted Project, Restricted Project
balazske added a comment to D66538: [AST] AST structural equivalence to work internally with pairs..

I remember that we had "problems" with nonsense ODR warnings where both declarations are the same. Probably the reason for it was this cache problem. Still the NonEquivalentDecls as cache is useful to filter out the non-equivalences that were already encountered to not produce repeated warnings for them.

Aug 26 2019, 12:42 AM · Restricted Project, Restricted Project

Aug 23 2019

balazske added a comment to D66538: [AST] AST structural equivalence to work internally with pairs..

There is a third test which could be useful to test whether there is no faulty cache entries there:

+TEST_F(StructuralEquivalenceCacheTest, DISABLED_NonEq) {
...
+}

This is somewhat the same check that is done in the current tests when the NonEquivalentDecls is checked to not contain any pairs of equivalent Decls. (Specially this line:

EXPECT_FALSE(isInNonEqCache(
      findDeclPair<FunctionDecl>(TU, functionDecl(hasName("x")))));

)

Aug 23 2019, 8:28 AM · Restricted Project, Restricted Project
balazske updated the diff for D66538: [AST] AST structural equivalence to work internally with pairs..
  • Updated tests.
Aug 23 2019, 8:04 AM · Restricted Project, Restricted Project
balazske added a comment to D66538: [AST] AST structural equivalence to work internally with pairs..

The structural equivalency check works (with this patch) the following way: To check a (A1,A2) pair we collect further (X1,X2) pairs that should be checked and put these in DeclsToCheck (if not already there). The check succeeds if every pair is equivalent. The pairs (A1,X2) and (A1,Y2) are checked independently. A true return value from any of the IsStructurallyEquivalent functions means that we did not found non-equivalence in the internal node data but the pairs in DeclsToCheck should be checked too. Return value of false means a non-equivalence in the internal data only is found with the (X1,X2) pair that is currently checked, therefore we found non-equivalence for the original pair and for (X1,X2) too. Again, with the new code the test CheckCommonEquivalence(D1, D2) && CheckKindSpecificEquivalence(D1, D2) fails only if we found difference in the internal node data and we can be sure that D1 and D2 are non-equivalent. The old code does not have this property.

Aug 23 2019, 3:28 AM · Restricted Project, Restricted Project
balazske added a comment to D66538: [AST] AST structural equivalence to work internally with pairs..

It looks like that the original code is correct in the decision of structural equivalence of the original pair. If we have an (A,B) and (A,C) to compare, B and C are in different decl chain, then (A,B) or (A,C) will be non-equivalent (unless B and C are equivalent, but what to do in this case?). The problem was that the code assumed that in this case always A and B (or A and C) are non-equivalent. If NonEquivalentDecls is not filled in this case (or not used at all) the problem does not exist.

I think we must not update the NonEquivalentDecls cache at that level, because as we've seen (during the discussion of https://reviews.llvm.org/D62131) it may store the wrong pairs.
However, it is still okay to cache the inequivalent decls in one level upper, right after the Finish returns.
See this diff https://github.com/martong/clang/compare/NonEqDecls_cache_in_an_upper_level~...martong:NonEqDecls_cache_in_an_upper_level?expand=1
Right now I started a build on our CI to see if it causes any slowdown.

Aug 23 2019, 1:02 AM · Restricted Project, Restricted Project

Aug 22 2019

balazske added inline comments to D66538: [AST] AST structural equivalence to work internally with pairs..
Aug 22 2019, 3:32 AM · Restricted Project, Restricted Project
balazske abandoned D60465: [ASTImporter] Error handling fix in ImportDefinition_New..

This change is obsolete in the current code. Casting related changes do not look important (and should be a new patch anyway).

Aug 22 2019, 1:40 AM · Restricted Project
balazske added inline comments to D66538: [AST] AST structural equivalence to work internally with pairs..
Aug 22 2019, 1:03 AM · Restricted Project, Restricted Project

Aug 21 2019

balazske added a comment to D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter.

A "quick fix" for the problem:
https://reviews.llvm.org/D66538

Aug 21 2019, 7:58 AM · Restricted Project
balazske created D66538: [AST] AST structural equivalence to work internally with pairs..
Aug 21 2019, 7:55 AM · Restricted Project, Restricted Project
balazske added a comment to D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter.

Example about how to get wrong things into NonEquivalentDecls:
We want to compare class C for structural equivalence in the following codes:

class A {}; class B {int i;}; void x(A *); void y(A *); class C { friend void x(A *); friend void y(A *); };

and

class A {}; class B {int i;}; void x(A *); void y(B *); class C { friend void x(A *); friend void y(B *); };

The result is false for C but the NonEquivalentDecls will contain after the compare a void x(A*)<->void x(A*) pair.

Aug 21 2019, 5:36 AM · Restricted Project
balazske added inline comments to D66336: [ASTImporter] Add development internals docs.
Aug 21 2019, 1:04 AM · Restricted Project, Restricted Project

Aug 16 2019

balazske committed rGe13e836480fc: [ASTImporter] Import ctor initializers after setting flags. (authored by balazske).
[ASTImporter] Import ctor initializers after setting flags.
Aug 16 2019, 5:13 AM
balazske committed rL369098: [ASTImporter] Import ctor initializers after setting flags..
[ASTImporter] Import ctor initializers after setting flags.
Aug 16 2019, 5:13 AM
balazske closed D65935: [ASTImporter] Import ctor initializers after setting flags..
Aug 16 2019, 5:13 AM · Restricted Project, Restricted Project
balazske added a comment to D65935: [ASTImporter] Import ctor initializers after setting flags..

LLDB probably does the import in other way. CTU test fails without the fix:

FAIL: Clang :: Analysis/ctu-main.cpp (540 of 15341)
******************** TEST 'Clang :: Analysis/ctu-main.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';   rm -rf build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp && mkdir build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp
: 'RUN: at line 2';   mkdir -p build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir
: 'RUN: at line 3';   build/Release/bin/clang -cc1 -internal-isystem build/Release/lib/clang/10.0.0/include -nostdsysteminc -triple x86_64-pc-linux-gnu    -emit-pch -o build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir/ctu-other.cpp.ast llvm-project/clang/test/Analysis/Inputs/ctu-other.cpp
: 'RUN: at line 5';   build/Release/bin/clang -cc1 -internal-isystem build/Release/lib/clang/10.0.0/include -nostdsysteminc -triple x86_64-pc-linux-gnu    -emit-pch -o build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir/ctu-chain.cpp.ast llvm-project/clang/test/Analysis/Inputs/ctu-chain.cpp
: 'RUN: at line 7';   cp llvm-project/clang/test/Analysis/Inputs/ctu-other.cpp.externalDefMap.txt build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir/externalDefMap.txt
: 'RUN: at line 8';   build/Release/bin/clang -cc1 -internal-isystem build/Release/lib/clang/10.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range -triple x86_64-pc-linux-gnu    -analyzer-checker=core,debug.ExprInspection    -analyzer-config experimental-enable-naive-ctu-analysis=true    -analyzer-config ctu-dir=build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir    -verify llvm-project/clang/test/Analysis/ctu-main.cpp
: 'RUN: at line 13';   build/Release/bin/clang -cc1 -internal-isystem build/Release/lib/clang/10.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range -triple x86_64-pc-linux-gnu    -analyzer-checker=core,debug.ExprInspection    -analyzer-config experimental-enable-naive-ctu-analysis=true    -analyzer-config ctu-dir=build/Release/tools/clang/test/Analysis/Output/ctu-main.cpp.tmp/ctudir    -analyzer-config display-ctu-progress=true 2>&1 llvm-project/clang/test/Analysis/ctu-main.cpp | build/Release/bin/FileCheck llvm-project/clang/test/Analysis/ctu-main.cpp
--
Exit Code: 134
Aug 16 2019, 2:21 AM · Restricted Project, Restricted Project

Aug 14 2019

balazske committed rGc50959431928: [ASTImporter] Import default expression of param before creating the param. (authored by balazske).
[ASTImporter] Import default expression of param before creating the param.
Aug 14 2019, 2:42 AM
balazske committed rL368818: [ASTImporter] Import default expression of param before creating the param..
[ASTImporter] Import default expression of param before creating the param.
Aug 14 2019, 2:42 AM
balazske closed D65577: [ASTImporter] Import default expression of param before creating the param..
Aug 14 2019, 2:42 AM · Restricted Project
balazske updated the diff for D65935: [ASTImporter] Import ctor initializers after setting flags..
  • Moved 'ctor initializer' import before import of body.
Aug 14 2019, 2:09 AM · Restricted Project, Restricted Project

Aug 13 2019

balazske committed rGb427c061ad10: [ASTImporter] Import additional flags for functions. (authored by balazske).
[ASTImporter] Import additional flags for functions.
Aug 13 2019, 1:04 AM
balazske committed rL368655: [ASTImporter] Import additional flags for functions..
[ASTImporter] Import additional flags for functions.
Aug 13 2019, 1:03 AM
balazske closed D65999: [ASTImporter] Import additional flags for functions..
Aug 13 2019, 1:03 AM · Restricted Project, Restricted Project
balazske added inline comments to D65999: [ASTImporter] Import additional flags for functions..
Aug 13 2019, 12:18 AM · Restricted Project, Restricted Project
balazske updated the diff for D65999: [ASTImporter] Import additional flags for functions..
  • Moved SVEBuiltins test instantiation to non-different position.
Aug 13 2019, 12:14 AM · Restricted Project, Restricted Project

Aug 12 2019

balazske committed rG2e16060a8bbb: [ASTImporter] Fix for import of friend class template with definition. (authored by balazske).
[ASTImporter] Fix for import of friend class template with definition.
Aug 12 2019, 3:08 AM
balazske committed rL368551: [ASTImporter] Fix for import of friend class template with definition..
[ASTImporter] Fix for import of friend class template with definition.
Aug 12 2019, 3:07 AM
balazske closed D65269: [ASTImporter] Fix for import of friend class template with definition..
Aug 12 2019, 3:07 AM · Restricted Project, Restricted Project
balazske added inline comments to D65999: [ASTImporter] Import additional flags for functions..
Aug 12 2019, 2:06 AM · Restricted Project, Restricted Project
balazske updated the diff for D65999: [ASTImporter] Import additional flags for functions..
  • Using StringRef, added comment.
Aug 12 2019, 1:12 AM · Restricted Project, Restricted Project
balazske added inline comments to D65999: [ASTImporter] Import additional flags for functions..
Aug 12 2019, 12:51 AM · Restricted Project, Restricted Project
balazske committed rG4b9d20008bbc: [CrossTU] Fix problem with CrossTU AST load limit and progress messages. (authored by balazske).
[CrossTU] Fix problem with CrossTU AST load limit and progress messages.
Aug 12 2019, 12:18 AM
balazske committed rL368545: [CrossTU] Fix problem with CrossTU AST load limit and progress messages..
[CrossTU] Fix problem with CrossTU AST load limit and progress messages.
Aug 12 2019, 12:14 AM
balazske closed D66054: [CrossTU] Fix problem with CrossTU AST load limit and progress messages..
Aug 12 2019, 12:14 AM · Restricted Project, Restricted Project

Aug 11 2019

balazske added a comment to D65935: [ASTImporter] Import ctor initializers after setting flags..

In this case the problem was that some of the flags of the already created and inserted ToFunction are not initialized. During the import of some "ctor initializers" this non-complete ToFunction may be accessed somehow (by structural equivalence or other code) and an assert comes because invalid value. (Maybe in the test code the second constructor is imported as "ctor initializer" during the import of the first.)

Aug 11 2019, 11:47 PM · Restricted Project, Restricted Project

Aug 10 2019

balazske updated the diff for D66054: [CrossTU] Fix problem with CrossTU AST load limit and progress messages..
  • [CrossTU] Fix problem with CrossTU AST load limit and progress messages.
  • Reformat.
Aug 10 2019, 8:20 AM · Restricted Project, Restricted Project
balazske updated the diff for D65577: [ASTImporter] Import default expression of param before creating the param..

Rename of variables and reformat.

Aug 10 2019, 8:11 AM · Restricted Project
balazske created D66054: [CrossTU] Fix problem with CrossTU AST load limit and progress messages..
Aug 10 2019, 6:02 AM · Restricted Project, Restricted Project

Aug 9 2019

balazske added inline comments to D65999: [ASTImporter] Import additional flags for functions..
Aug 9 2019, 5:23 AM · Restricted Project, Restricted Project
balazske added a comment to D64753: [CrossTU][NFCI] Refactor loadExternalAST function.

I discovered that there are problems with this change. The number of loaded AST units is not incremented correctly and the "CTU loaded AST file" is displayed for every access to a AST unit (even if it was got from cache). The problem is that the counting and print of AST loads does not handle the case when the load returned a cached result (and no real loading happened). This causes "annoying" messages and the AST unit limit is not handled correctly.

Aug 9 2019, 4:13 AM · Restricted Project, Restricted Project