Page MenuHomePhabricator

baloghadamsoftware (Balogh, Ádám)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 9 2016, 4:07 AM (180 w, 3 d)

Recent Activity

Sun, Aug 4

baloghadamsoftware closed D65650: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences.

Closed by commit: [[ https://reviews.llvm.org/rG8557f17d887a | https://reviews.llvm.org/rG8557f17d887a: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences ]]

Sun, Aug 4, 11:51 PM · Restricted Project
baloghadamsoftware committed rG8557f17d887a: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences (authored by baloghadamsoftware).
[Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences
Sun, Aug 4, 11:47 PM
baloghadamsoftware committed rL367802: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences.
[Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences
Sun, Aug 4, 11:46 PM

Fri, Aug 2

baloghadamsoftware added a comment to D65650: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences.

This is an emergency patch. Please someone review this patch as soon as possible.

Fri, Aug 2, 6:20 AM · Restricted Project
baloghadamsoftware created D65650: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences.
Fri, Aug 2, 6:14 AM · Restricted Project

Wed, Jul 31

baloghadamsoftware added inline comments to D62525: [Analyzer] Add new visitor to the iterator checkers.
Wed, Jul 31, 4:59 AM · Restricted Project

Tue, Jul 30

baloghadamsoftware added a comment to D62525: [Analyzer] Add new visitor to the iterator checkers.

Gentle ping.

Tue, Jul 30, 5:39 AM · Restricted Project
baloghadamsoftware added a comment to D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers.

Hmm, an idea just popped into my head. I'm not sure whether we have a single checker that does so much complicated (and totally awesome) modeling as IteratorChecker. What do you think about a debug checker similar to debug.ExprInspection, like debug.IteratorInspection?

Tue, Jul 30, 5:36 AM · Restricted Project
baloghadamsoftware added a comment to D62724: [Analyzer] Iterator Checkers - Model `size()` method of containers.

Gentle ping.

Tue, Jul 30, 5:28 AM · Restricted Project
baloghadamsoftware added a comment to D62893: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal.

Gentle ping.

Tue, Jul 30, 5:26 AM · Restricted Project
baloghadamsoftware added a comment to D62895: [Analyzer] Iterator Checkers - Check and simulate `std::advance`, `std::prev` and `std::next`.

Gentle ping.

Tue, Jul 30, 5:26 AM · Restricted Project
baloghadamsoftware added a comment to D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value.

For me it is all the same whether to continue this patch or taking over Péter's.

Tue, Jul 30, 5:26 AM · Restricted Project
baloghadamsoftware added inline comments to D65287: [analyzer][CFG] Don't track the condition of asserts.
Tue, Jul 30, 5:21 AM · Restricted Project, Restricted Project
baloghadamsoftware added a comment to D65382: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const.
In D65382#1605572, @NoQ wrote:

It's counter-idiomatic to pass manager objects (ProgramStateManager, SValBuilder, etc.) as const-references because it tells you pretty much nothing about what you can or cannot do with them. You don't really ever semantically mutate them in the first place. There's no need to mention it every time you pass them around.

Tue, Jul 30, 12:19 AM · Restricted Project, Restricted Project

Mon, Jul 29

baloghadamsoftware added a comment to D65349: [analyzer] Be more careful with destructors of non-regions..

Yes, it crashes! :-) I tried it because I did not believe it, but it does. Is there any real-world use-case for casting concrete integers to class instances? How did you find this crashing case?

Mon, Jul 29, 7:36 AM · Restricted Project, Restricted Project
baloghadamsoftware added a comment to D65361: [analyzer] Trust global initializers when analyzing main()..

Thank you for working on this! I agree, we should trust global initializers in main() in C. Can we maybe detect whether GNU global constructors are enabled or better: used?

Mon, Jul 29, 7:36 AM · Restricted Project
baloghadamsoftware added a comment to D65182: [analyzer] Add fix-it hint support..

Hmm, I was thinking on the same for some time but I wonder how many checkers could find the correct fixits? Maybe the removal fixits of double frees or double file closes, but I am afraid that for most of our path-sensitive checks there are no obvious fixits. Even clang-tidy cannot provide a fixit for most of its findings. However, generally I like the idea, even for the few checkers it can be applied to.

Mon, Jul 29, 7:36 AM · Restricted Project
baloghadamsoftware updated the diff for D49074: [Analyzer] Basic support for multiplication and division in the constraint manager.

Rebased.

Mon, Jul 29, 7:36 AM
baloghadamsoftware added inline comments to D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only).
Mon, Jul 29, 7:36 AM
baloghadamsoftware updated the diff for D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only).

Fixed error when the result of an integer division is compared to zero.

Mon, Jul 29, 7:36 AM

Fri, Jul 26

baloghadamsoftware retitled D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only) from [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager (for == and != only) to [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only).
Fri, Jul 26, 7:11 AM
baloghadamsoftware retitled D49074: [Analyzer] Basic support for multiplication and division in the constraint manager from [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager to [Analyzer] Basic support for multiplication and division in the constraint manager.
Fri, Jul 26, 7:11 AM
baloghadamsoftware updated the summary of D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.
Fri, Jul 26, 7:05 AM · Restricted Project, Restricted Project
baloghadamsoftware added a comment to D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.

Thank you for the very throughout review. I updated my patch according to your comments and tried to answer your concerns.

Fri, Jul 26, 7:03 AM · Restricted Project, Restricted Project
baloghadamsoftware updated the diff for D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.

Updated according to the comments.

Fri, Jul 26, 6:57 AM · Restricted Project, Restricted Project

Jul 25 2019

baloghadamsoftware added a comment to D49074: [Analyzer] Basic support for multiplication and division in the constraint manager.

I evaluated this patch on different open-source projects, with Z3 refutation off and on:

Jul 25 2019, 5:41 AM
baloghadamsoftware updated the diff for D49074: [Analyzer] Basic support for multiplication and division in the constraint manager.

Rebased.

Jul 25 2019, 5:41 AM
baloghadamsoftware updated the diff for D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only).

Intersecting an empty set caused an assertion. Early return inserted to prevent this.

Jul 25 2019, 5:36 AM

Jul 18 2019

baloghadamsoftware added inline comments to D62525: [Analyzer] Add new visitor to the iterator checkers.
Jul 18 2019, 2:19 AM · Restricted Project
baloghadamsoftware updated the diff for D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value.

Fix wrong upload.

Jul 18 2019, 1:00 AM · Restricted Project
baloghadamsoftware added a comment to D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value.
In D63279#1590676, @NoQ wrote:

/me has just noticed that this isn't D34812.

Jul 18 2019, 12:22 AM · Restricted Project

Jul 17 2019

baloghadamsoftware added a comment to D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value.

I am a bit afraid of the performance of the feature because of the extensive use of matchers. Based on my previous experiences matcher creation and disposition are expensive operations. Matchers are meant to be a kind of "static" structures created only once and destroyed at the end. Using them in the core infrastructure may negatively affect the execution time of the whole analysis. Maybe we should get rid of them before turning on this feature as default (which is the ultimate goal).

Jul 17 2019, 6:13 AM · Restricted Project
baloghadamsoftware updated the diff for D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value.

Test case added for loop conditions written in reverse order and code fixed to make the test pass.

Jul 17 2019, 6:07 AM · Restricted Project
baloghadamsoftware added inline comments to D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value.
Jul 17 2019, 6:05 AM · Restricted Project
baloghadamsoftware updated the diff for D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.

Tests for volatile, atomics and noreturn functions added. Check fixed to make these tests pass.

Jul 17 2019, 4:23 AM · Restricted Project, Restricted Project

Jul 16 2019

baloghadamsoftware added a comment to D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.

Thanks for working on this!
You want to use clang/Analysis/Analyses/ExprMutationAnalyzer.h.
See also: D51870

Jul 16 2019, 5:32 AM · Restricted Project, Restricted Project
baloghadamsoftware updated the diff for D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.

Updated according to the comments.

Jul 16 2019, 5:32 AM · Restricted Project, Restricted Project

Jul 15 2019

baloghadamsoftware created D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.
Jul 15 2019, 6:17 AM · Restricted Project, Restricted Project
baloghadamsoftware added a comment to D64274: [analyzer] VirtualCallChecker overhaul..

Hmm, I still fail to understand the problem with the current VirtualCall checker. Is it unstable? Does it report many false positives?

Jul 15 2019, 12:24 AM · Restricted Project, Restricted Project

Jul 4 2019

baloghadamsoftware added a comment to D49074: [Analyzer] Basic support for multiplication and division in the constraint manager.

I tested this on several open-source projects. Lots of false-positives disappeared. There are also some new findings, mainly new false-positives but not because of this feature but of "loops executed 0 times".

Jul 4 2019, 5:15 AM

Jul 1 2019

baloghadamsoftware added a comment to D63920: [CTU] Add support for virtual functions.

Try to set analyzer option IPAMode to something different from its default value which is dynamic-bifurcate in the test file.

Jul 1 2019, 11:26 PM · Restricted Project, Restricted Project

Jun 14 2019

baloghadamsoftware accepted D63080: [analyzer] Track indices of arrays.

LGTM!

Jun 14 2019, 11:09 PM · Restricted Project, Restricted Project

Jun 13 2019

baloghadamsoftware created D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value.
Jun 13 2019, 9:12 AM · Restricted Project

Jun 12 2019

baloghadamsoftware added a comment to D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting..

Looks much better than the original one, but why did the warning move to the correct place just because marking the region as interesting?

Jun 12 2019, 5:09 AM · Restricted Project
baloghadamsoftware requested changes to D63080: [analyzer] Track indices of arrays.
Jun 12 2019, 4:31 AM · Restricted Project, Restricted Project
baloghadamsoftware updated the diff for D62525: [Analyzer] Add new visitor to the iterator checkers.

Visitors now track increments and decrements.

Jun 12 2019, 1:07 AM · Restricted Project

Jun 5 2019

baloghadamsoftware added a comment to D62895: [Analyzer] Iterator Checkers - Check and simulate `std::advance`, `std::prev` and `std::next`.

This patch definitely reduces the number of false positives, but may not be enough. The problem is that std::advance() may call another function that does the actual incremention or decremention, in the gcc implementation it is __advance(). If the std::advance() is inlined but __advance() not then we still get false positive. The obvious way would be to simulate __advance() as well but it is an implementation dependent internal function and may be totally different for other implementations. Another idea is that instead of querying the CheckerContext whether advance() was inlined we go up the exploded graph and find its "precall" state and compare the values of the first parameter related to the second one in the two states. This is a bit more complex and more expensive but this for me this seems to be the correct solution.

Jun 5 2019, 4:09 AM · Restricted Project
baloghadamsoftware added a parent revision for D62895: [Analyzer] Iterator Checkers - Check and simulate `std::advance`, `std::prev` and `std::next`: D62893: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal.
Jun 5 2019, 2:31 AM · Restricted Project
baloghadamsoftware created D62895: [Analyzer] Iterator Checkers - Check and simulate `std::advance`, `std::prev` and `std::next`.
Jun 5 2019, 2:31 AM · Restricted Project
baloghadamsoftware added a child revision for D62893: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal: D62895: [Analyzer] Iterator Checkers - Check and simulate `std::advance`, `std::prev` and `std::next`.
Jun 5 2019, 2:31 AM · Restricted Project
baloghadamsoftware added a comment to D62893: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal.

I left errors caused by mismatched iterators non-fatal for now. This is debatable because passing a function expecting a range iterators for two different containers or applying a container modifier using a mismatched iterator also leads to undefined behavior. However, comparing two iterators of different containers always returns false thus it is non-fatal. Maybe we should separate these two cases and report the first one as fatal, the second one as non-fatal errors.

Jun 5 2019, 2:18 AM · Restricted Project
baloghadamsoftware created D62893: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal.
Jun 5 2019, 2:15 AM · Restricted Project

May 31 2019

baloghadamsoftware created D62724: [Analyzer] Iterator Checkers - Model `size()` method of containers.
May 31 2019, 2:21 AM · Restricted Project

May 30 2019

baloghadamsoftware created D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers.
May 30 2019, 9:24 AM · Restricted Project
baloghadamsoftware added inline comments to D62525: [Analyzer] Add new visitor to the iterator checkers.
May 30 2019, 7:59 AM · Restricted Project
baloghadamsoftware added a comment to D62525: [Analyzer] Add new visitor to the iterator checkers.
In D62525#1519868, @NoQ wrote:

Before someone asks: NoteTags are not applicable here since invalidation and reaching one end of the range happens in many different places. This is also true for container emptiness.

Mm, what's wrong with many different places? If you're worried about code duplication, just put tag construction into a function (?)

May 30 2019, 7:57 AM · Restricted Project
baloghadamsoftware updated the diff for D49074: [Analyzer] Basic support for multiplication and division in the constraint manager.

Rebased.

May 30 2019, 7:46 AM
baloghadamsoftware removed a reviewer for D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only): george.karpenkov.
May 30 2019, 7:41 AM
baloghadamsoftware updated the diff for D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only).

Multipliers limited to less or equal to 255.

May 30 2019, 7:41 AM

May 28 2019

baloghadamsoftware added a comment to D62525: [Analyzer] Add new visitor to the iterator checkers.

Before someone asks: NoteTags are not applicable here since invalidation and reaching one end of the range happens in many different places. This is also true for container emptiness.

May 28 2019, 10:14 AM · Restricted Project
baloghadamsoftware created D62525: [Analyzer] Add new visitor to the iterator checkers.
May 28 2019, 7:12 AM · Restricted Project
baloghadamsoftware committed rG9ed4b316d13f: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags` (authored by baloghadamsoftware).
[Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`
May 28 2019, 6:07 AM
baloghadamsoftware committed rL361818: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`.
[Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`
May 28 2019, 6:07 AM
baloghadamsoftware committed rC361818: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`.
[Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`
May 28 2019, 6:07 AM
baloghadamsoftware closed D62479: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`.
May 28 2019, 6:07 AM · Restricted Project

May 27 2019

baloghadamsoftware retitled D62479: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags` from Replace `CXXSelfAssignmentBRVisitor` with `NoteTags` to [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`.
May 27 2019, 6:08 AM · Restricted Project
baloghadamsoftware created D62479: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`.
May 27 2019, 4:03 AM · Restricted Project

May 21 2019

baloghadamsoftware committed rG5f3deb9bb5a7: [clang-tidy] New option for misc-throw-by-value-catch-by-reference (authored by baloghadamsoftware).
[clang-tidy] New option for misc-throw-by-value-catch-by-reference
May 21 2019, 12:24 AM
baloghadamsoftware committed rCTE361225: [clang-tidy] New option for misc-throw-by-value-catch-by-reference.
[clang-tidy] New option for misc-throw-by-value-catch-by-reference
May 21 2019, 12:24 AM
baloghadamsoftware committed rL361225: [clang-tidy] New option for misc-throw-by-value-catch-by-reference.
[clang-tidy] New option for misc-throw-by-value-catch-by-reference
May 21 2019, 12:23 AM
baloghadamsoftware closed D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference.
May 21 2019, 12:23 AM · Restricted Project, Restricted Project, Restricted Project

May 20 2019

baloghadamsoftware updated the diff for D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference.

Updated according to the comments.

May 20 2019, 6:29 AM · Restricted Project, Restricted Project, Restricted Project
baloghadamsoftware committed rG33160c442449: [Analyzer] Refactor begin and end symbol creation (authored by baloghadamsoftware).
[Analyzer] Refactor begin and end symbol creation
May 20 2019, 4:03 AM
baloghadamsoftware committed rC361141: [Analyzer] Refactor begin and end symbol creation.
[Analyzer] Refactor begin and end symbol creation
May 20 2019, 4:02 AM
baloghadamsoftware committed rL361141: [Analyzer] Refactor begin and end symbol creation.
[Analyzer] Refactor begin and end symbol creation
May 20 2019, 4:01 AM
baloghadamsoftware closed D61136: [Analyzer] Refactor begin and end symbol creation.
May 20 2019, 4:01 AM · Restricted Project, Restricted Project

May 13 2019

baloghadamsoftware created D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference.
May 13 2019, 4:18 AM · Restricted Project, Restricted Project, Restricted Project

May 6 2019

baloghadamsoftware committed rCTE360114: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to….
[clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to…
May 6 2019, 11:16 PM
baloghadamsoftware committed rGecd1a82ee208: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to… (authored by baloghadamsoftware).
[clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to…
May 6 2019, 11:16 PM
baloghadamsoftware committed rL360114: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to….
[clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to…
May 6 2019, 11:15 PM
baloghadamsoftware closed D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures).
May 6 2019, 11:15 PM · Restricted Project, Restricted Project, Restricted Project
baloghadamsoftware committed rG62468003ef97: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in… (authored by baloghadamsoftware).
[clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in…
May 6 2019, 3:40 AM
baloghadamsoftware committed rL360032: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in….
[clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in…
May 6 2019, 3:40 AM
baloghadamsoftware committed rCTE360032: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in….
[clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in…
May 6 2019, 3:40 AM
baloghadamsoftware closed D61422: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic.
May 6 2019, 3:40 AM · Restricted Project, Restricted Project

May 3 2019

baloghadamsoftware added a comment to D61422: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic.

Hmm, I am a little bit skeptical about the utility of this compared to the expense of making the check marginally slower. However, I don't have any specific objections and so I'm not opposed to the patch. LG!

May 3 2019, 6:20 AM · Restricted Project, Restricted Project
baloghadamsoftware updated the diff for D61136: [Analyzer] Refactor begin and end symbol creation.

SymbolConjured * written, feature removed, just refactoring.

May 3 2019, 6:15 AM · Restricted Project, Restricted Project
baloghadamsoftware added inline comments to D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures).
May 3 2019, 5:32 AM · Restricted Project, Restricted Project, Restricted Project
baloghadamsoftware updated the diff for D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures).

New tests added.

May 3 2019, 5:31 AM · Restricted Project, Restricted Project, Restricted Project
baloghadamsoftware added a comment to D61422: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic.

Out of curiosity, have you run this over any large code bases to see what the false positive and true positive rate is?

May 3 2019, 2:27 AM · Restricted Project, Restricted Project
baloghadamsoftware updated the diff for D61422: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic.

Dot added to the end of the comment.

May 3 2019, 2:27 AM · Restricted Project, Restricted Project

May 2 2019

baloghadamsoftware updated the diff for D61422: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic.

Type int in tests replaced by struct S because it has more "sugar". Check also fixed to handle this case.

May 2 2019, 6:36 AM · Restricted Project, Restricted Project
baloghadamsoftware created D61422: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic.
May 2 2019, 1:31 AM · Restricted Project, Restricted Project

Apr 29 2019

baloghadamsoftware created D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures).
Apr 29 2019, 6:39 AM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2019

baloghadamsoftware added inline comments to D61136: [Analyzer] Refactor begin and end symbol creation.
Apr 26 2019, 12:46 AM · Restricted Project, Restricted Project
baloghadamsoftware added a comment to D61136: [Analyzer] Refactor begin and end symbol creation.
In D61136#1479454, @NoQ wrote:

Aha, yup, thx!

Do you plan to centralize other code paths on which you conjure symbols?

Apr 26 2019, 12:39 AM · Restricted Project, Restricted Project
baloghadamsoftware committed rGd538b70b44a1: [Analyzer] Iterator Checkers - Do an early return after handling calls (authored by baloghadamsoftware).
[Analyzer] Iterator Checkers - Do an early return after handling calls
Apr 26 2019, 12:32 AM
baloghadamsoftware committed rL359283: [Analyzer] Iterator Checkers - Do an early return after handling calls.
[Analyzer] Iterator Checkers - Do an early return after handling calls
Apr 26 2019, 12:28 AM
baloghadamsoftware committed rC359283: [Analyzer] Iterator Checkers - Do an early return after handling calls.
[Analyzer] Iterator Checkers - Do an early return after handling calls
Apr 26 2019, 12:28 AM
baloghadamsoftware closed D61134: [Analyzer] Iterator Checkers - Do an early return after handling calls.
Apr 26 2019, 12:28 AM · Restricted Project