baloghadamsoftware (Balogh, Ádám)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 9 2016, 4:07 AM (119 w, 22 h)

Recent Activity

Tue, Jun 19

baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.

I tested all parts of the Iterator Checkers, all tests passed.

Tue, Jun 19, 12:03 PM
baloghadamsoftware updated the diff for D33537: [clang-tidy] Exception Escape Checker.

Typo fixed.

Tue, Jun 19, 2:27 AM · Restricted Project
baloghadamsoftware added inline comments to D33537: [clang-tidy] Exception Escape Checker.
Tue, Jun 19, 1:32 AM · Restricted Project

Mon, Jun 18

baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.

I added extra assertion into the test for the difference. Interestingly, it also works if I assert n-m is in the range instead of m-n.

Mon, Jun 18, 8:51 AM
baloghadamsoftware updated the diff for D35110: [Analyzer] Constraint Manager Negates Difference.

-(-2^n) == -2^n

Mon, Jun 18, 8:46 AM
baloghadamsoftware updated the diff for D33537: [clang-tidy] Exception Escape Checker.

New warning message, more detailed docs.

Mon, Jun 18, 1:16 AM · Restricted Project

Thu, Jun 14

baloghadamsoftware committed rL334804: [ASTImporter] Corrected diagnostic client handling in tests..
[ASTImporter] Corrected diagnostic client handling in tests.
Thu, Jun 14, 11:50 PM
baloghadamsoftware committed rC334804: [ASTImporter] Corrected diagnostic client handling in tests..
[ASTImporter] Corrected diagnostic client handling in tests.
Thu, Jun 14, 11:50 PM
baloghadamsoftware closed D47445: [ASTImporter] Corrected diagnostic client handling in tests..
Thu, Jun 14, 11:50 PM

Wed, Jun 13

baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.

Any idea how to proceed?

Wed, Jun 13, 9:48 AM

Mon, Jun 4

baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.
In D35110#1119496, @NoQ wrote:

Which expressions are constrained? Why does the difference use the whole range? Is it something that could have been fixed by the "enforce that separately" part in my old comment:

iterator-related symbols are all planned to be within range [-2²⁹, -2²⁹], right? So if we subtract one such symbol from another, it's going to be in range [-2³⁰, 2³⁰]. Can we currently infer that? Or maybe we should make the iterator checker to enforce that separately?

?

Mon, Jun 4, 12:27 AM

Fri, Jun 1

baloghadamsoftware added a comment to D47417: [analyzer] Add missing state transition in IteratorChecker.

Did the tests execute? I am not sure. First problem is the the container may become dead before the iterator, so its Begin and End symbols may be inaccessible. This is easy to solve by marking the container of the iterator as live. However, there is a second problem that disables correct tracking of iterators: memory regions are marked as dead, however there are LazyCompoundVals referring to them. Is this maybe a bug in SymbolReaper?

Fri, Jun 1, 2:06 AM

Thu, May 31

baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.

Maybe if we could apply somehow a [-MAX/2..MAX/2] constraint to both sides of the rearranged equality in SimpleSValBuilder.

Thu, May 31, 4:17 AM
baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.

Sorry, Artem, but it does not work this way. Even if the symbolic expressions are constrained to [-MAX/4..MAX/4], after rearrangement the difference still uses the whole range, thus m>n becomes m-n>0, where in the false branch the range for m-n is [MIN..0]. Then if we check n>=m the range set is reversed to [MIN..MIN]U[0..MAX] which results UNKNOWN for n-m. It does not solve any of our problems and there is no remedy on the checker's side.

Thu, May 31, 2:49 AM

Wed, May 30

baloghadamsoftware accepted D47417: [analyzer] Add missing state transition in IteratorChecker.

Oh, it slipped through somehow. Thanks for fixing this!

Wed, May 30, 11:52 PM

Mon, May 28

baloghadamsoftware updated the diff for D35110: [Analyzer] Constraint Manager Negates Difference.

I still disagree, but I want the review to continue so I did the requested modifications.

Mon, May 28, 4:43 AM

Fri, May 25

baloghadamsoftware added inline comments to D33537: [clang-tidy] Exception Escape Checker.
Fri, May 25, 6:18 AM · Restricted Project

Wed, May 23

baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.

Can we continue the discussion here, please? We should involve Devin and/or George as well if we cannot agree ourselves.

Wed, May 23, 6:04 AM
baloghadamsoftware added a comment to D47155: [analyzer] Improve simplifySVal performance..

Hello! Thank you for addressing this problem. Are these kinds of symbols common in real code? For me it seems very artificial. However, I agree with George, it would be better to have this value as an analyzer option with a default value (of 20).

Wed, May 23, 6:03 AM

May 7 2018

baloghadamsoftware added inline comments to D33537: [clang-tidy] Exception Escape Checker.
May 7 2018, 6:07 AM · Restricted Project
baloghadamsoftware updated the diff for D33537: [clang-tidy] Exception Escape Checker.

Updated according to the comments.

May 7 2018, 6:02 AM · Restricted Project

May 4 2018

baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.

I chose option 1 for now.

May 4 2018, 6:53 AM
baloghadamsoftware updated the diff for D35110: [Analyzer] Constraint Manager Negates Difference.

Fixed according to the comments.

May 4 2018, 6:53 AM
baloghadamsoftware updated the diff for D33537: [clang-tidy] Exception Escape Checker.

New test added.

May 4 2018, 4:36 AM · Restricted Project
baloghadamsoftware added inline comments to D33537: [clang-tidy] Exception Escape Checker.
May 4 2018, 4:35 AM · Restricted Project
baloghadamsoftware updated the diff for D33537: [clang-tidy] Exception Escape Checker.

Typo fixed.

May 4 2018, 4:07 AM · Restricted Project
baloghadamsoftware added a comment to D33537: [clang-tidy] Exception Escape Checker.

It looks like you've missed some comments or uploaded a wrong patch.

May 4 2018, 12:02 AM · Restricted Project
baloghadamsoftware updated the diff for D33537: [clang-tidy] Exception Escape Checker.

Retrying...

May 4 2018, 12:01 AM · Restricted Project

May 3 2018

baloghadamsoftware updated the diff for D32906: [Analyzer] Iterator Checker - Part 10: Support for iterators passed as parameter.

Rebased, and minor modifications done according to the comments.

May 3 2018, 6:34 AM
baloghadamsoftware edited reviewers for D32906: [Analyzer] Iterator Checker - Part 10: Support for iterators passed as parameter, added: dcoughlin, george.karpenkov; removed: zaks.anna.
May 3 2018, 5:01 AM
baloghadamsoftware updated the diff for D32905: [Analyzer] Iterator Checker - Part 9: Evaluation of std::find-like calls.

Rebased.

May 3 2018, 4:15 AM
baloghadamsoftware edited reviewers for D32905: [Analyzer] Iterator Checker - Part 9: Evaluation of std::find-like calls, added: dcoughlin, george.karpenkov; removed: zaks.anna.
May 3 2018, 4:14 AM
baloghadamsoftware edited reviewers for D32904: [Analyzer] Iterator Checker - Part 8: Support for assign, clear, insert, emplace and erase operations, added: dcoughlin; removed: zaks.anna.
May 3 2018, 4:13 AM

May 2 2018

baloghadamsoftware added inline comments to D35110: [Analyzer] Constraint Manager Negates Difference.
May 2 2018, 11:47 PM
baloghadamsoftware updated the diff for D32904: [Analyzer] Iterator Checker - Part 8: Support for assign, clear, insert, emplace and erase operations.

Rebased.

May 2 2018, 6:57 AM
baloghadamsoftware added inline comments to D35110: [Analyzer] Constraint Manager Negates Difference.
May 2 2018, 6:56 AM

Apr 27 2018

baloghadamsoftware edited reviewers for D32902: [Analyzer] Iterator Checker - Part 7: Support for push and pop operations, added: dcoughlin; removed: zaks.anna.
Apr 27 2018, 7:14 AM
baloghadamsoftware updated the diff for D32902: [Analyzer] Iterator Checker - Part 7: Support for push and pop operations.

Rebased to Part6. Also fixed a test failing now: it is not enough to mark the symbolic expressions as live, but if it is a SymIntExpr (it can be nothing else, except SymbolConjured), we also have to mark the left side of it (which is always SymbolConjured) as live. Using scanReachableSymbols() here would be too heavyweight.

Apr 27 2018, 6:44 AM

Apr 26 2018

baloghadamsoftware updated the diff for D32860: [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for constructors and comparisons.

Rebased to Part 5.

Apr 26 2018, 7:15 AM
baloghadamsoftware updated the diff for D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers.

One test failed after rebased to the current master branch. Depending on the internal implementation of the iterator and the move operation of the container it could happen that after moving a container the begin() or end() of the target of the move returns an already existing iterator position to the source of the move which is wrong. Therefore we must first check for begin() and end() and only then check for the existence of the iterator position of the return value of a function returning an iterator.

Apr 26 2018, 6:50 AM

Apr 19 2018

baloghadamsoftware added inline comments to D45839: [analyzer] Add support for WebKit "unified sources"..
Apr 19 2018, 11:08 PM
baloghadamsoftware updated the diff for D33537: [clang-tidy] Exception Escape Checker.

Updated according to the comments.

Apr 19 2018, 4:52 AM · Restricted Project

Apr 13 2018

baloghadamsoftware committed rL330064: [Analyzer] Fix for SValBuilder expressions rearrangement.
[Analyzer] Fix for SValBuilder expressions rearrangement
Apr 13 2018, 1:26 PM
baloghadamsoftware committed rC330064: [Analyzer] Fix for SValBuilder expressions rearrangement.
[Analyzer] Fix for SValBuilder expressions rearrangement
Apr 13 2018, 1:26 PM
baloghadamsoftware closed D45557: [Analyzer] Fix for SValBuilder expressions rearrangement.
Apr 13 2018, 1:26 PM
baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.

No more pending dependency, so we can continue the review.

Apr 13 2018, 2:46 AM
baloghadamsoftware updated the diff for D45557: [Analyzer] Fix for SValBuilder expressions rearrangement.

Updated according to the comments.

Apr 13 2018, 2:41 AM

Apr 12 2018

baloghadamsoftware created D45557: [Analyzer] Fix for SValBuilder expressions rearrangement.
Apr 12 2018, 1:31 AM

Apr 11 2018

baloghadamsoftware added a comment to D33537: [clang-tidy] Exception Escape Checker.

Thank you for your thorough review, I will do the fixes next week, after the Euro LLVM.

Apr 11 2018, 3:41 AM · Restricted Project
baloghadamsoftware updated the diff for D35110: [Analyzer] Constraint Manager Negates Difference.

Rebased to the newly committed SValbuilder rearranger patch

Apr 11 2018, 12:43 AM
baloghadamsoftware abandoned D34508: [Analyzer] Bug Reporter Visitor to Display Values of Variables - PRELIMINARY!.
Apr 11 2018, 12:33 AM
baloghadamsoftware abandoned D35109: [Analyzer] SValBuilder Comparison Rearrangement.
Apr 11 2018, 12:32 AM

Apr 10 2018

baloghadamsoftware committed rC329780: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer….
[Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer…
Apr 10 2018, 11:25 PM
baloghadamsoftware committed rL329780: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer….
[Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer…
Apr 10 2018, 11:25 PM
baloghadamsoftware closed D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).
Apr 10 2018, 11:25 PM

Apr 9 2018

baloghadamsoftware added a comment to D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).

George or Devin, please accept it or give me some feedback if not. Since this patch affects the core infrastructure I think it is wise to merge it only if at least two of you have accepted it. Artem is one, I need a second one as well.

Apr 9 2018, 1:34 AM

Mar 28 2018

baloghadamsoftware updated the diff for D33537: [clang-tidy] Exception Escape Checker.

,html removed from release notes.

Mar 28 2018, 12:14 PM · Restricted Project
baloghadamsoftware added inline comments to D33537: [clang-tidy] Exception Escape Checker.
Mar 28 2018, 8:33 AM · Restricted Project
baloghadamsoftware updated the diff for D33537: [clang-tidy] Exception Escape Checker.

Updated according to the comments.

Mar 28 2018, 8:29 AM · Restricted Project
baloghadamsoftware added inline comments to D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).
Mar 28 2018, 3:50 AM
baloghadamsoftware updated the diff for D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).

Comment fixed.

Mar 28 2018, 3:45 AM

Mar 23 2018

baloghadamsoftware updated the diff for D33537: [clang-tidy] Exception Escape Checker.

Moved to bugprone.

Mar 23 2018, 5:41 AM · Restricted Project
baloghadamsoftware added a comment to D33537: [clang-tidy] Exception Escape Checker.

Escaping exception is certainly a bug, so it should go into bugprone then.

Mar 23 2018, 2:10 AM · Restricted Project

Mar 19 2018

baloghadamsoftware added inline comments to D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).
Mar 19 2018, 9:44 AM
baloghadamsoftware added inline comments to D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).
Mar 19 2018, 9:41 AM
baloghadamsoftware updated the diff for D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).

Updated according to the comments.

Mar 19 2018, 9:41 AM

Mar 12 2018

baloghadamsoftware updated subscribers of D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls.
Mar 12 2018, 5:56 AM
baloghadamsoftware added a comment to D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls.

By moving the code that sets the type name of an anoynmous declaration from Import(Decl*) to ImportDefinition(RecordDecl*, RecordDecl*, ImportDefinitionKind) (and the same for Enum) we will not crash upon importing typedefs containing anonymous strcutures. This is a patch-over-patch for it, including the test cases:

Mar 12 2018, 5:54 AM

Mar 6 2018

baloghadamsoftware added a comment to D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls.

Thank you for the patch.

Mar 6 2018, 1:51 AM

Jan 24 2018

baloghadamsoftware added a comment to D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).

Thank you for your comments. Since the original author of this particular code is Artem, I think he will answer your questions.

Jan 24 2018, 6:53 AM

Jan 18 2018

baloghadamsoftware added a reviewer for D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option): george.karpenkov.
Jan 18 2018, 6:41 AM
baloghadamsoftware updated the diff for D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).

Updated according to the comments.

Jan 18 2018, 6:40 AM

Jan 17 2018

baloghadamsoftware edited reviewers for D32860: [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for constructors and comparisons, added: dcoughlin; removed: zaks.anna.
Jan 17 2018, 7:42 AM
baloghadamsoftware edited reviewers for D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers, added: dcoughlin; removed: zaks.anna.
Jan 17 2018, 7:42 AM
baloghadamsoftware edited reviewers for D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters, added: dcoughlin; removed: zaks.anna.
Jan 17 2018, 7:42 AM
baloghadamsoftware updated the diff for D32860: [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for constructors and comparisons.

Rebased.

Jan 17 2018, 7:42 AM
baloghadamsoftware updated the diff for D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers.

Rebased.

Jan 17 2018, 7:42 AM
baloghadamsoftware updated the diff for D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters.

Updated according to some comments.

Jan 17 2018, 7:00 AM
baloghadamsoftware edited reviewers for D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments, added: dcoughlin; removed: zaks.anna.
Jan 17 2018, 5:34 AM
baloghadamsoftware updated the diff for D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments.

Updated according to the comments.

Jan 17 2018, 5:34 AM
baloghadamsoftware added inline comments to D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters.
Jan 17 2018, 1:30 AM
baloghadamsoftware added a comment to D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments.

Thanks you for your comments! I have one question:

Jan 17 2018, 1:22 AM

Jan 16 2018

baloghadamsoftware updated the diff for D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers.

Rebased to current part 4. New tests added. Comments added.

Jan 16 2018, 7:47 AM

Jan 15 2018

baloghadamsoftware updated the diff for D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters.

Rebased to current Part 3. Comment added.

Jan 15 2018, 8:58 AM
baloghadamsoftware updated the diff for D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments.

Rebased to current Part 2.

Jan 15 2018, 8:57 AM
baloghadamsoftware added inline comments to D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments.
Jan 15 2018, 3:16 AM

Jan 11 2018

baloghadamsoftware removed a reviewer for D35110: [Analyzer] Constraint Manager Negates Difference: zaks.anna.
Jan 11 2018, 6:49 AM
baloghadamsoftware edited reviewers for D32642: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks, added: dcoughlin; removed: zaks.anna.
Jan 11 2018, 6:49 AM
baloghadamsoftware updated the diff for D32642: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks.

Updated to be based upon D41938 and D35110.

Jan 11 2018, 6:48 AM
baloghadamsoftware updated the summary of D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).
Jan 11 2018, 6:15 AM
baloghadamsoftware updated the diff for D35110: [Analyzer] Constraint Manager Negates Difference.

Updated to be based upon D41938.

Jan 11 2018, 5:56 AM
baloghadamsoftware edited dependencies for D35110: [Analyzer] Constraint Manager Negates Difference, added: 1; removed: 1.
Jan 11 2018, 2:11 AM
baloghadamsoftware added a dependent revision for D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option): D35110: [Analyzer] Constraint Manager Negates Difference.
Jan 11 2018, 2:11 AM
baloghadamsoftware removed a dependent revision for D35109: [Analyzer] SValBuilder Comparison Rearrangement: D35110: [Analyzer] Constraint Manager Negates Difference.
Jan 11 2018, 2:11 AM
baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.
In D35110#972430, @NoQ wrote:

Strange, but modifying the tests from m <relation> n to m - n <relation> 0 does not help. The statement if (m - n <relation> 0) does not store a range for m - n in the constraint manager. With the other patch which automatically changes m <relation> n to m - n <relation> 0 the range is stored automatically.

I guess we can easily assume how a SymIntExpr relates to a number by storing a range on the opaque left-hand-side symbol, no matter how complicated it is, but we cannot assume how a symbol relates to a symbol (there's no obvious range to store). That's just how assumeSym currently works.

Jan 11 2018, 2:11 AM
baloghadamsoftware created D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).
Jan 11 2018, 1:44 AM

Jan 10 2018

baloghadamsoftware edited reviewers for D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors, added: NoQ; removed: zaks.anna.
Jan 10 2018, 4:44 AM
baloghadamsoftware added a dependency for D35110: [Analyzer] Constraint Manager Negates Difference: D35109: [Analyzer] SValBuilder Comparison Rearrangement.
Jan 10 2018, 4:37 AM
baloghadamsoftware added a dependent revision for D35109: [Analyzer] SValBuilder Comparison Rearrangement: D35110: [Analyzer] Constraint Manager Negates Difference.
Jan 10 2018, 4:37 AM

Jan 8 2018

baloghadamsoftware added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.

Strange, but modifying the tests from m <relation> n to m - n <relation> 0 does not help. The statement if (m - n <relation> 0) does not store a range for m - n in the constraint manager. With the other patch which automatically changes m <relation> n to m - n <relation> 0 the range is stored automatically.

Jan 8 2018, 6:59 AM