Page MenuHomePhabricator

[HIP] Fix visibility for 'extern' device variables.
ClosedPublic

Authored by hliao on Jun 7 2019, 12:23 PM.

Details

Summary
  • Fix a bug which misses the change for a variable to be set with target-specific attributes.

Diff Detail

Event Timeline

hliao created this revision.Jun 7 2019, 12:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2019, 12:23 PM
hliao added a comment.Nov 5 2019, 10:41 AM

Sam, could you review this? Even though it has no functionality issue so far, from the code sequence, once there's an addrspacecast is inserted, we lose the chance to set target specific attributes if any.

yaxunl accepted this revision.Nov 5 2019, 10:57 AM
yaxunl added a subscriber: scchan.

LGTM. Thanks! @scchan This may fix the undefined symbol in work item struct issue at -O0

This revision is now accepted and ready to land.Nov 5 2019, 10:57 AM
This revision was automatically updated to reflect the committed changes.