Page MenuHomePhabricator
Differential D62000

[AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
ClosedPublic
Actions

Authored by c-rhodes on May 16 2019, 3:49 AM.

Details

Reviewers
sdesmalen
SjoerdMeijer
ostannard
rovka
Commits
rZORG49eef9c6c475: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
rG49eef9c6c475: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
rG96c5929926f6: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
rL361136: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
Summary

This patch adds support for the predicated integer halving add/sub
instructions:

  • SHADD, UHADD, SRHADD, URHADD
  • SHSUB, UHSUB, SHSUBR, UHSUBR

The specification can be found here:
https://developer.arm.com/docs/ddi0602/latest

Diff Detail

Repository
rL LLVM

Event Timeline

c-rhodes created this revision.May 16 2019, 3:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2019, 3:49 AM
Herald added subscribers: kristof.beyls, tschuett, javed.absar. · View Herald Transcript
c-rhodes added a parent revision: D61998: [AArch64][SVE2] Asm: add saturating multiply-add interleaved long instructions.May 16 2019, 3:51 AM
c-rhodes added a child revision: D62001: [AArch64][SVE2] Asm: add SADALP and UADALP instructions.May 16 2019, 3:56 AM
rovka accepted this revision.May 17 2019, 1:33 AM

LGTM but I have one question :)

test/MC/AArch64/SVE2/shadd-diagnostics.s
32 ↗(On Diff #199780)

Should we also test that <Pg>/z errors out?

This revision is now accepted and ready to land.May 17 2019, 1:33 AM
c-rhodes added inline comments.May 17 2019, 1:46 AM
test/MC/AArch64/SVE2/shadd-diagnostics.s
32 ↗(On Diff #199780)

Yes good spot, I'll add test for that

Closed by commit rL361136: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions (authored by c-rhodes). · Explain WhyMay 20 2019, 3:32 AM
This revision was automatically updated to reflect the committed changes.
c-rhodes marked an inline comment as done.May 20 2019, 3:33 AM

Revision Contents
Changeset List

PathSize
llvm/
trunk/
lib/
Target/
AArch64/
10 lines
33 lines
test/
MC/
AArch64/
SVE2/
37 lines
59 lines
37 lines
59 lines
37 lines
59 lines
37 lines
59 lines
37 lines
59 lines
37 lines
59 lines
37 lines
59 lines
37 lines
59 lines

Diff 200236

View Options

llvm/trunk/lib/Target/AArch64/AArch64SVEInstrInfo.td

Loading...
View Options

llvm/trunk/lib/Target/AArch64/SVEInstrFormats.td

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/shadd-diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/shadd.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/shsub-diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/shsub.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/shsubr-diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/shsubr.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/srhadd-diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/srhadd.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/uhadd-diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/uhadd.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/uhsub-diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/uhsub.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/uhsubr-diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/uhsubr.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/urhadd-diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/SVE2/urhadd.s

Loading...