Differential D62000

[AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
ClosedPublic
Actions

Authored by c-rhodes on May 16 2019, 3:49 AM.

Details

Reviewers

sdesmalen
SjoerdMeijer
ostannard
rovka

Commits

rL361136: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
rZORG49eef9c6c475: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
rG96c5929926f6: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
rG49eef9c6c475: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions

Summary

This patch adds support for the predicated integer halving add/sub
instructions:

SHADD, UHADD, SRHADD, URHADD
SHSUB, UHSUB, SHSUBR, UHSUBR

The specification can be found here:
https://developer.arm.com/docs/ddi0602/latest

Diff Detail

Repository: rL LLVM

Event Timeline

c-rhodes created this revision.May 16 2019, 3:49 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2019, 3:49 AM

Herald added subscribers: kristof.beyls, tschuett, javed.absar. · View Herald Transcript

c-rhodes added a parent revision: D61998: [AArch64][SVE2] Asm: add saturating multiply-add interleaved long instructions.May 16 2019, 3:51 AM

c-rhodes added a child revision: D62001: [AArch64][SVE2] Asm: add SADALP and UADALP instructions.May 16 2019, 3:56 AM

LGTM but I have one question :)

test/MC/AArch64/SVE2/shadd-diagnostics.s
32 ↗	(On Diff #199780)	Should we also test that <Pg>/z errors out?

This revision is now accepted and ready to land.May 17 2019, 1:33 AM

c-rhodes added inline comments.May 17 2019, 1:46 AM

test/MC/AArch64/SVE2/shadd-diagnostics.s
32 ↗	(On Diff #199780)	Yes good spot, I'll add test for that

Closed by commit rL361136: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions (authored by c-rhodes, committed by ). · Explain WhyMay 20 2019, 3:32 AM

This revision was automatically updated to reflect the committed changes.

c-rhodes marked an inline comment as done.May 20 2019, 3:33 AM

Revision Contents
Changeset List

			Path	Packages
M			llvm/trunk/lib/Target/AArch64/AArch64SVEInstrInfo.td (10 lines)
M			llvm/trunk/lib/Target/AArch64/SVEInstrFormats.td (33 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/shadd-diagnostics.s (37 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/shadd.s (59 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/shsub-diagnostics.s (37 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/shsub.s (59 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/shsubr-diagnostics.s (37 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/shsubr.s (59 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/srhadd-diagnostics.s (37 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/srhadd.s (59 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/uhadd-diagnostics.s (37 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/uhadd.s (59 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/uhsub-diagnostics.s (37 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/uhsub.s (59 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/uhsubr-diagnostics.s (37 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/uhsubr.s (59 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/urhadd-diagnostics.s (37 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/urhadd.s (59 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	199780			May 16 2019, 3:41 AM	★	★
Diff 2	200236	361135	rL361136	May 20 2019, 3:35 AM	★	★

Status	Author	Revision
Closed	c-rhodes	D62602 [AArch64][SVE2] Add CPU and arch directive tests
Closed	c-rhodes	D62601 [AArch64][SVE2] Asm: support WHILE instructions
Closed	c-rhodes	D62600 [AArch64][SVE2] Asm: support TBL/TBX instructions
Closed	c-rhodes	D62599 [AArch64][SVE2] Asm: support SVE2 store instructions
Closed	c-rhodes	D62530 [AArch64][SVE2] Asm: support SVE2 vector splice (constructive)
Closed	c-rhodes	D62528 [AArch64][SVE2] Asm: support SVE2 load instructions
Closed	c-rhodes	D62526 [AArch64][SVE2] Asm: support FCVTX/FLOGB instructions
Closed	c-rhodes	D62518 [AArch64][SVE2] Asm: add ext (immediate offset, constructive) instruction
Closed	c-rhodes	D62387 [AArch64][SVE2] Asm: support SVE Bitwise Logical - Unpredicated Group
Closed	c-rhodes	D62386 [AArch64][SVE2] Asm: support Floating Point Widening Multiply-Add
Closed	c-rhodes	D62383 [AArch64][SVE2] Asm: support SVE2 Floating Point Pairwise Group
Closed	c-rhodes	D62382 [AArch64][SVE2] Asm: support SVE2 Floating Point Convert Group
Closed	c-rhodes	D62307 [AArch64][SVE2] Asm: support SVE2 Crypto Extensions Group
Closed	c-rhodes	D62306 [AArch64][SVE2] Asm: support SVE2 Histogram Computation Groups
Closed	c-rhodes	D62304 [AArch64][SVE2] Asm: support SVE2 Misc Group
Closed	c-rhodes	D62206 [AArch64][SVE2] Asm: support SVE2 String Processing Group
Closed	c-rhodes	D62205 [AArch64][SVE2] Asm: support SVE2 Narrowing Group
Closed	c-rhodes	D62204 [AArch64][SVE2] Asm: support SVE2 Accumulate Group
Closed	c-rhodes	D62145 [AArch64][SVE2] Asm: add PMULLB/PMULLT instructions
Closed	c-rhodes	D62142 [AArch64][SVE2] Asm: add integer add/sub long/wide instructions
Closed	c-rhodes	D62140 [AArch64][SVE2] Asm: add various bitwise shift instructions
Closed	c-rhodes	D62130 [AArch64][SVE2] Asm: add saturating add/sub instructions
Closed	c-rhodes	D62129 [AArch64][SVE2] Asm: add integer unary instructions (predicated)
Closed	c-rhodes	D62128 [AArch64][SVE2] Asm: add integer pairwise arithmetic instructions
Closed	c-rhodes	D62001 [AArch64][SVE2] Asm: add SADALP and UADALP instructions
Closed	c-rhodes	D62000 [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
Closed	c-rhodes	D61998 [AArch64][SVE2] Asm: add saturating multiply-add interleaved long instructions
Closed	c-rhodes	D61997 [AArch64][SVE2] Asm: add saturating multiply-add long instructions
Closed	c-rhodes	D61951 [AArch64][SVE2] Asm: add integer multiply-add long instructions
Closed	c-rhodes	D61936 [AArch64][SVE2] Asm: add integer multiply long instructions
Closed	c-rhodes	D61906 [AArch64][SVE2] Asm: implement CMLA/SQRDCMLAH instructions
Closed	c-rhodes	D61903 [AArch64][SVE2] Asm: implement CDOT instruction
Closed	c-rhodes	D61902 [AArch64][SVE2] Asm: add unpredicated integer multiply instructions
Closed	c-rhodes	D61515 [AArch64][SVE2] Asm: add SQRDMLAH/SQRDMLSH instructions
Closed	c-rhodes	D61514 [AArch64][SVE2] Asm: add integer multiply-add/subtract (indexed) instructions
Closed	c-rhodes	D61513 [AArch64][SVE2] Add SVE2 target features to backend and TargetParser