Differential D61906

[AArch64][SVE2] Asm: implement CMLA/SQRDCMLAH instructions
ClosedPublic
Actions

Authored by c-rhodes on Tue, May 14, 8:39 AM.

Details

Reviewers

sdesmalen
SjoerdMeijer
ostannard
rovka

Commits

rL360871: [AArch64][SVE2] Asm: implement CMLA/SQRDCMLAH instructions
rG472c6ef8b0f5: [AArch64][SVE2] Asm: implement CMLA/SQRDCMLAH instructions

Summary

This patch adds support for the indexed and unpredicated vectors forms
of the CMLA and SQRDCMLAH instructions.

The specification can be found here:
https://developer.arm.com/docs/ddi0602/latest

Diff Detail

Repository: rL LLVM

Event Timeline

c-rhodes created this revision.Tue, May 14, 8:39 AM

Herald added a project: Restricted Project. · View Herald TranscriptTue, May 14, 8:39 AM

Herald added subscribers: kristof.beyls, tschuett, javed.absar. · View Herald Transcript

c-rhodes added a parent revision: D61903: [AArch64][SVE2] Asm: implement CDOT instruction.Tue, May 14, 8:39 AM

LGTM

This revision is now accepted and ready to land.Tue, May 14, 11:59 PM

c-rhodes added a child revision: D61936: [AArch64][SVE2] Asm: add integer multiply long instructions.Wed, May 15, 2:42 AM

Closed by commit rL360871: [AArch64][SVE2] Asm: implement CMLA/SQRDCMLAH instructions (authored by c-rhodes, committed by ). · Explain WhyThu, May 16, 2:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			llvm/trunk/lib/Target/AArch64/AArch64SVEInstrInfo.td (9 lines)
M			llvm/trunk/lib/Target/AArch64/SVEInstrFormats.td (30 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/cmla-diagnostics.s (103 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/cmla.s (156 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/sqrdcmlah-diagnostics.s (103 lines)
M			llvm/trunk/test/MC/AArch64/SVE2/sqrdcmlah.s (156 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	199459			Tue, May 14, 8:34 AM	★	★
Diff 2	199773	360870	rL360871	Thu, May 16, 2:42 AM	★	★

Status	Author	Revision
Needs Review	c-rhodes	D62387 [AArch64][SVE2] Asm: support SVE Bitwise Logical - Unpredicated Group
Needs Review	c-rhodes	D62386 [AArch64][SVE2] Asm: support Floating Point Widening Multiply-Add
Needs Review	c-rhodes	D62383 [AArch64][SVE2] Asm: support SVE2 Floating Point Pairwise Group
Accepted	c-rhodes	D62382 [AArch64][SVE2] Asm: support SVE2 Floating Point Convert Group
Accepted	c-rhodes	D62307 [AArch64][SVE2] Asm: support SVE2 Crypto Extensions Group
Accepted	c-rhodes	D62306 [AArch64][SVE2] Asm: support SVE2 Histogram Computation Groups
Accepted	c-rhodes	D62304 [AArch64][SVE2] Asm: support SVE2 Misc Group
Closed	c-rhodes	D62206 [AArch64][SVE2] Asm: support SVE2 String Processing Group
Closed	c-rhodes	D62205 [AArch64][SVE2] Asm: support SVE2 Narrowing Group
Closed	c-rhodes	D62204 [AArch64][SVE2] Asm: support SVE2 Accumulate Group
Closed	c-rhodes	D62145 [AArch64][SVE2] Asm: add PMULLB/PMULLT instructions
Closed	c-rhodes	D62142 [AArch64][SVE2] Asm: add integer add/sub long/wide instructions
Closed	c-rhodes	D62140 [AArch64][SVE2] Asm: add various bitwise shift instructions
Closed	c-rhodes	D62130 [AArch64][SVE2] Asm: add saturating add/sub instructions
Closed	c-rhodes	D62129 [AArch64][SVE2] Asm: add integer unary instructions (predicated)
Closed	c-rhodes	D62128 [AArch64][SVE2] Asm: add integer pairwise arithmetic instructions
Closed	c-rhodes	D62001 [AArch64][SVE2] Asm: add SADALP and UADALP instructions
Closed	c-rhodes	D62000 [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions
Closed	c-rhodes	D61998 [AArch64][SVE2] Asm: add saturating multiply-add interleaved long instructions
Closed	c-rhodes	D61997 [AArch64][SVE2] Asm: add saturating multiply-add long instructions
Closed	c-rhodes	D61951 [AArch64][SVE2] Asm: add integer multiply-add long instructions
Closed	c-rhodes	D61936 [AArch64][SVE2] Asm: add integer multiply long instructions
Closed	c-rhodes	D61906 [AArch64][SVE2] Asm: implement CMLA/SQRDCMLAH instructions
Closed	c-rhodes	D61903 [AArch64][SVE2] Asm: implement CDOT instruction
Closed	c-rhodes	D61902 [AArch64][SVE2] Asm: add unpredicated integer multiply instructions
Closed	c-rhodes	D61515 [AArch64][SVE2] Asm: add SQRDMLAH/SQRDMLSH instructions
Closed	c-rhodes	D61514 [AArch64][SVE2] Asm: add integer multiply-add/subtract (indexed) instructions
Closed	c-rhodes	D61513 [AArch64][SVE2] Add SVE2 target features to backend and TargetParser